Re: [PATCH] staging: dgnc: Replace CamelCase namings with underscores.

On Mon, Oct 17, 2016 at 1:16 PM, Greg KH wrote: > > On Mon, Oct 17, 2016 at 01:13:55AM +0530, Pankaj Bharadiya wrote: > > Replace CamelCase names with underscores to comply with the standard > > kernel coding style. > > > > Signed-off-by: Pankaj Bharadiya

[PATCH -next] staging: rts5208: rtsx.c: Fix invalid use of sizeof in rtsx_probe()

From: Wei Yongjun sizeof() when applied to a pointer typed expression gives the size of the pointer, not that of the pointed data. Fixes: 2eb9d8cbb3c3 ("staging: rts5208: rtsx.c: Alloc sizeof struct") Signed-off-by: Wei Yongjun ---

Re: [lustre-devel] [PATCH 08/28] staging: lustre: restore initialization of return code

On Monday, October 17, 2016 3:37:11 PM CEST Linus Torvalds wrote: > On Mon, Oct 17, 2016 at 3:29 PM, Arnd Bergmann wrote: > > > > Sorry, I pasted the wrong error message when writing the changelog. > > Not just the warning, the summary above it talks about the wrong > function

[PATCH 08/28 v2] staging: lustre: restore initialization of return code

A recent rework dropped the initialization of the initialization of the successful return code in lov_getstripe: drivers/staging/lustre/lustre/lov/lov_pack.c: In function 'lov_getstripe': drivers/staging/lustre/lustre/lov/lov_pack.c:426:9: error: 'rc' may be used uninitialized in this function

Re: [PATCH 1/2] staging: lustre: replace uses of class_devno_max by MAX_OBD_DEVICES

On Oct 17, 2016, at 15:46, Aya Mahfouz wrote: > > class_devno_max is an inline function that returns > MAX_OBD_DEVICES. Replace all calls to the function > by MAX_OBD_DEVICES. Thanks for your patch, but unfortunately it can't be accepted. This function was added

Re: [lustre-devel] [PATCH 08/28] staging: lustre: restore initialization of return code

On Mon, Oct 17, 2016 at 3:29 PM, Arnd Bergmann wrote: > > Sorry, I pasted the wrong error message when writing the changelog. Not just the warning, the summary above it talks about the wrong function too. And the commit it references doesn't actually exist either. So apparently

Re: [lustre-devel] [PATCH 08/28] staging: lustre: restore initialization of return code

On Monday, October 17, 2016 10:23:00 PM CEST Patrick Farrell wrote: > Arnd, > > > The description and the actual patch don't seem to match up. Am I missing > something? Sorry, I pasted the wrong error message when writing the changelog. > From: lustre-devel

[PATCH 21/28] net/hyperv: avoid uninitialized variable

The hdr_offset variable is only if we deal with a TCP or UDP packet, but as the check surrounding its usage tests for skb_is_gso() instead, the compiler has no idea if the variable is initialized or not at that point: drivers/net/hyperv/netvsc_drv.c: In function ‘netvsc_start_xmit’:

[PATCH 14/28] iio: accel: sca3000_core: avoid potentially uninitialized variable

The newly added __sca3000_get_base_freq function handles all valid modes of the SCA3000_REG_ADDR_MODE register, but gcc notices that any other value (i.e. 0x00) causes the base_freq variable to not get initialized: drivers/staging/iio/accel/sca3000_core.c: In function 'sca3000_write_raw':

[PATCH 09/28] staging: lustre: remove broken dead code in cfs_cpt_table_create_pattern

After a recent bugfix, we get a warning about the use of an uninitialized variable: drivers/staging/lustre/lnet/libcfs/linux/linux-cpu.c: In function 'cfs_cpt_table_create_pattern': drivers/staging/lustre/lnet/libcfs/linux/linux-cpu.c:833:7: error: 'str' may be used uninitialized in this

[PATCH 08/28] staging: lustre: restore initialization of return code

A recent rework removed the initialization of the successful return code from lpfc_write_firmware: drivers/scsi/lpfc/lpfc_init.c: In function 'lpfc_write_firmware': drivers/scsi/lpfc/lpfc_init.c:10333:214: error: format '%ld' expects argument of type 'long int', but argument 9 has type 'size_t

[PATCH 2/2] staging: lustre: remove class_devno_max

class_devno_max is an inline function that is not used anymore. Hence, it is removed. Signed-off-by: Aya Mahfouz --- drivers/staging/lustre/lustre/include/obd_class.h | 5 - 1 file changed, 5 deletions(-) diff --git

Re: [PATCH] staging: dgnc: replace DGNC_VERIFY_BOARD macro

On Mon, Oct 17, 2016 at 10:29 AM, Greg KH wrote: > On Fri, Oct 14, 2016 at 07:22:57PM +0200, Fernando Apesteguia wrote: >> The patch replaces the macro with a function (dgnc_get_board) and >> substitutes the macro statement with a call to that function and a >>

[PATCH 1/2] staging: lustre: replace uses of class_devno_max by MAX_OBD_DEVICES

class_devno_max is an inline function that returns MAX_OBD_DEVICES. Replace all calls to the function by MAX_OBD_DEVICES. Signed-off-by: Aya Mahfouz --- drivers/staging/lustre/lustre/obdclass/class_obd.c | 6 +++---

[PATCH 0/2] staging: lustre: replace and remove class_devno_max

class_devno_max is an inline function that is written with the sole purpose of returning the value of MAX_OBD_DEVICES. Since no computations are made by the class_devno_max, replace it with MAX_OBD_DEVICES. Aya Mahfouz (2): staging: lustre: replace uses of class_devno_max by MAX_OBD_DEVICES

Re: [RFC PATCH v1 21/28] KVM: introduce KVM_SEV_ISSUE_CMD ioctl

> I am not sure if I fully understand this feedback. Let me summaries what > we have right now. > > At highest level SEV key management commands are divided into two sections: > > - platform management : commands used during platform provisioning. PSP > drv provides ioctl's for these commands.

Re: [PATCH] staging: lov.ko: lov_object.c: fix sparse warning setting function to static

On Mon, Oct 17, 2016 at 03:21:52PM -0400, Ryan Swan wrote: > Fixed: sparse WARNING: symbol 'lov_read_and_clear_async_rc' was not declared. > Should it be static? I don't believe you actually test-built this change :( > > Signed-off-by: Ryan Swan > --- >

Re: [PATCH] Staging: media: bcm2048: Use octal permissions '0444'

On Mon, Oct 17, 2016 at 10:10:08PM +0530, Shyam Saini wrote: > On Mon, 2016-10-17 at 18:07 +0200, Greg KH wrote: > > On Mon, Oct 17, 2016 at 09:24:19PM +0530, Shyam Saini wrote: > > > > > > Fixed following checkpatch warning > > > Symbolic permissions 'S_IRUGO' are not preferred. Consider using >

[PATCH v2 3/3] doc: add documentation for uio-hv-generic

From: Stephen Hemminger Update UIO documentation to include basic information about uio_hv_generic. Signed-off-by: Stephen Hemminger --- Documentation/DocBook/uio-howto.tmpl | 62 1 file changed, 62

[PATCH v2 1/3] vmbus: add support for dynamic device id's

From: Stephen Hemminger This patch adds sysfs interface to dynamically bind new UUID values to existing VMBus device. This is useful for generic UIO driver to act similar to uio_pci_generic. Signed-off-by: Stephen Hemminger --- v2 - allow device

[PATCH v2 2/3] uio-hv-generic: new userspace i/o driver for VMBus

From: Stephen Hemminger This is a new driver to enable userspace networking on VMBus. It is based largely on the similar driver that already exists for PCI, and earlier work done by Brocade to support DPDK. Signed-off-by: Stephen Hemminger --- v2

[PATCH] staging: lov.ko: lov_object.c: fix sparse warning setting function to static

Fixed: sparse WARNING: symbol 'lov_read_and_clear_async_rc' was not declared. Should it be static? Signed-off-by: Ryan Swan --- drivers/staging/lustre/lustre/lov/lov_object.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 05/14] staging: fsl-mc: update MAINTAINERS

-German has moved on to other things and wished to be removed as a maintainer -cleanup the driver description to use the proper name of the driver (i.e. the fsl-mc bus driver) and remove incorrect references to Freescale Signed-off-by: Stuart Yoder Acked-by: J. German

[PATCH] staging: fbtft: Fix module autoload

If the driver is built as a module, autoload won't work because the module alias information is not filled. So user-space can't match the registered device with the corresponding module. Export the module alias information using the MODULE_DEVICE_TABLE() macro. Before this patch: $ modinfo

[PATCH 14/14] staging: fsl-mc: uprev binary interface to match MC v10.x

From: Ioana Ciornei DPAA2 will not support MC firmware versions prior to MC v10.x. Update the MC interface code and drivers to reflect this. -update the object .h files and code that builds commands to include the new command version in the command header -object

[PATCH 13/14] staging: fsl-mc: update copyright dates

Many source files have evolved without copyright date updates. Update the dates to reflect work through 2016. Signed-off-by: Stuart Yoder --- drivers/staging/fsl-mc/bus/dpcon-cmd.h | 2 +- drivers/staging/fsl-mc/bus/dpmcp.h | 2 +-

[PATCH 08/14] staging: fsl-mc: cleanup: convert uintX_t types to uX

From: Ioana Ciornei Replace all uses of uintX_t types with uX types in order to comply with kernel coding style and resolve checkpatch warnings. Signed-off-by: Ioana Ciornei Signed-off-by: Stuart Yoder ---

[PATCH 06/14] staging: fsl-mc: irq: shorten name of interrupt name

For /proc/interrupts readability, platform bus MSIs are named "ITS-pMSI" in the GIC ITS implementation for that bus. Follow a similar naming convention and call fsl-mc bus MSIs "ITS-fMSI". Signed-off-by: Stuart Yoder ---

[PATCH 12/14] staging: fsl-mc: improve comment wording

improve and clarify miscellaneous comments -when referring to the bus call it "fsl-mc" -reduce the verbosity of some comments for clarity -improve wording of the slightly confusing term "MC object device" Signed-off-by: Stuart Yoder ---

[PATCH 03/14] staging: fsl-mc: clean up Kconfig description

Except for copyrights we are avoiding all references to Freescale, which no longer exists as a brand. Cleanup Freescale references and simplify the Kconfig description of the fsl-mc bus. Signed-off-by: Stuart Yoder --- drivers/staging/fsl-mc/bus/Kconfig | 22

[PATCH 00/14] staging: fsl-mc: cleanup and uprev to MC v10.x

This patch does miscellaneous minor cleanup and uprevs the supported MC firmware version to 10.x. I believe with this series the TODO items on our list are complete, with the exception of "Add at least one device driver for a DPAA2 object", which I expect to send a patch for very soon. I plan to

[PATCH 01/14] staging: fsl-mc: cleanup: move dpbp and dpcon cmd headers

The dpbp and dpcon cmd header files should not be in the public include directory but should be private to the bus driver. Signed-off-by: Stuart Yoder --- drivers/staging/fsl-mc/{include => bus}/dpbp-cmd.h | 0 drivers/staging/fsl-mc/bus/dpbp.c | 3 ++-

[PATCH 09/14] staging: fsl-mc: misc whitespace cleanup

From: Ioana Ciornei Make whitespace consistent with other fsl-mc source files. -delete extraneous tabs -align start of function arguments properly -for structs and function definitions, separate type and variable name by a single space -remove multiple blank

[PATCH 11/14] staging: fsl-mc: message cleanup

Cleanup and clarify messages -use "fsl-mc" prefix for all messages that don't come from dev_* functions -remove unnecessary verbosity to make things clearer -use explicit __func__ arguments to clarify some error messages -improve misc wording for clarity Signed-off-by: Stuart Yoder

[PATCH 10/14] staging: fsl-mc: cleanup comment style

Be consistent and use kernel-preferred multi-line comment style everywhere. Signed-off-by: Stuart Yoder --- drivers/staging/fsl-mc/bus/dpbp-cmd.h | 3 ++- drivers/staging/fsl-mc/bus/dpbp.c | 3 ++- drivers/staging/fsl-mc/bus/dpcon-cmd.h | 3 ++-

[PATCH 07/14] staging: fsl-mc: dprc: shorten DPRC interrupt name

improve readibility of the DPRC interrupt name in sysfs by shortening this and just using the device name. There is only one interrupt DPRC used, so no further differentiation is needed. Signed-off-by: Stuart Yoder --- drivers/staging/fsl-mc/bus/dprc-driver.c | 2 +- 1

[PATCH 02/14] staging: fsl-mc: add missing includes to fsl-mc-private.h

fsl-mc-private.h references several definitions that it does not explicitly have includes for. Up until now we've gotten lucky due to include ordering that things compile. Add the missing includes. Signed-off-by: Stuart Yoder ---

[PATCH 04/14] staging: fsl-mc: update Kconfig dependency

The Kconfig dependency previously included ARM64, which is not strictly correct. Change it to ARCH_LAYERSCAPE which is the SoC platform that includes the DPAA2 hardware. Signed-off-by: Stuart Yoder --- drivers/staging/fsl-mc/bus/Kconfig | 2 +- 1 file changed, 1

Re: [RFC PATCH v1 21/28] KVM: introduce KVM_SEV_ISSUE_CMD ioctl

Hi Paolo, On 10/13/2016 05:45 AM, Paolo Bonzini wrote: On 23/08/2016 01:28, Brijesh Singh wrote: The ioctl will be used by qemu to issue the Secure Encrypted Virtualization (SEV) guest commands to transition a guest into into SEV-enabled mode. a typical usage: struct kvm_sev_launch_start

[PATCH] staging: lustre: remove unused identifier OBD_INIT_CHECK

OBD_INIT_CHECK was previously used by a conditional group. This is no longer the case so it can be removed. Signed-off-by: Aya Mahfouz --- drivers/staging/lustre/lustre/obdclass/class_obd.c | 1 - 1 file changed, 1 deletion(-) diff --git

Re: [PATCH -next] greybus: arche-platform: Add missing of_node_put() in arche_platform_change_state()

On Mon, Oct 17, 2016 at 04:37:20PM +, Wei Yongjun wrote: > From: Wei Yongjun > > This node pointer is returned by of_find_compatible_node() with > refcount incremented in this function. of_node_put() on it before > exitting this function. > > This is detected by

Re: [PATCH] Staging: media: bcm2048: Use octal permissions '0444'

On Mon, 2016-10-17 at 18:07 +0200, Greg KH wrote: > On Mon, Oct 17, 2016 at 09:24:19PM +0530, Shyam Saini wrote: > > > > Fixed following checkpatch warning > > Symbolic permissions 'S_IRUGO' are not preferred. Consider using > > octal > > permissions '0444' > > > > Signed-off-by: Shyam Saini

[PATCH -next] greybus: arche-platform: Add missing of_node_put() in arche_platform_change_state()

From: Wei Yongjun This node pointer is returned by of_find_compatible_node() with refcount incremented in this function. of_node_put() on it before exitting this function. This is detected by Coccinelle semantic patch. Signed-off-by: Wei Yongjun

Re: [PATCH] staging: rtl8188eu: Fix coding style errors

Yes, thanks for the heads up. I'll try to avoid such mistakes in the next patches On Mon, Oct 17, 2016 at 6:29 PM, Greg KH wrote: > On Mon, Oct 17, 2016 at 06:17:21PM +0200, Carlos Maiolino wrote: >> >> --- >> >> drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 28 >>

Re: [PATCH] staging: rtl8188eu: Fix coding style errors

On Mon, Oct 17, 2016 at 06:17:21PM +0200, Carlos Maiolino wrote: > >> --- > >> drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 28 > >> +-- > >> 1 file changed, 14 insertions(+), 14 deletions(-) > > > > Any reason you didn't use scripts/get_maintainer.pl to cc: the

Re: [PATCH] staging: rtl8188eu: Fix coding style errors

>> --- >> drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 28 >> +-- >> 1 file changed, 14 insertions(+), 14 deletions(-) > > Any reason you didn't use scripts/get_maintainer.pl to cc: the relevant > maintainers and developers of this code? > > thanks, > > greg k-h Not

Re: [PATCH] Staging: media: bcm2048: Use octal permissions '0644'

On Mon, Oct 17, 2016 at 09:23:07PM +0530, Shyam Saini wrote: > Fixed following checkpatch.pl warning > WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. > Consider using octal permissions '0644'. > > Signed-off-by: Shyam Saini > --- >

Re: [PATCH] Staging: media: bcm2048: Use octal permissions '0444'

On Mon, Oct 17, 2016 at 09:24:19PM +0530, Shyam Saini wrote: > Fixed following checkpatch warning > Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal > permissions '0444' > > Signed-off-by: Shyam Saini > --- >

Re: [PATCH] staging: rtl8188eu: Fix coding style errors

On Mon, Oct 17, 2016 at 05:39:22PM +0200, Carlos Maiolino wrote: > Fix coding style errors reported by checkpatch.pl, specifically: > > ERROR: space prohibited before that ',' (ctx:WxW) > > This patch get rid of all "ERROR" messages from checkpatch.pl for this file > > Signed-off-by: Carlos

[PATCH] Staging: media: bcm2048: Use octal permissions '0444'

Fixed following checkpatch warning Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444' Signed-off-by: Shyam Saini --- drivers/staging/media/bcm2048/radio-bcm2048.c | 18 +- 1 file changed, 9 insertions(+), 9

[PATCH] Staging: media: bcm2048: Use octal permissions '0644'

Fixed following checkpatch.pl warning WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. Signed-off-by: Shyam Saini --- drivers/staging/media/bcm2048/radio-bcm2048.c | 40 +-- 1 file

[PATCH v5 0/4] Add support for led triggers on phy link state change

Fix skge driver that declared enum contants that conflicted with enum constants in linux/leds.h Create function that encapsulates actions taken during the adjust phy link step of phy state changes. Create function that provides list of speeds currently supported by the phy. Add support for led

[PATCH v5 2/4] net: phy: Encapsulate actions performed during link state changes into function phy_adjust_link

During phy state machine state transitions some set of actions should occur whenever the link state changes. These actions should be encapsulated into a single function This patch adds the phy_adjust_link function, which is called whenever phydev->adjust_link would have been called before.

[PATCH v5 1/4] skge: Rename LED_OFF and LED_ON in marvel skge driver to avoid conflicts with leds namespace

Adding led support for phy causes namespace conflicts for some phy drivers. The marvel skge driver declared an enum for representing the states of Link LED Register. The enum contained constant LED_OFF which conflicted with declartation found in linux/leds.h. LED_OFF changed to LED_REG_OFF Also

[PATCH v5 4/4] net: phy: leds: add support for led triggers on phy link state change

Create an option CONFIG_LED_TRIGGER_PHY (default n), which will create a set of led triggers for each instantiated PHY device. There is one LED trigger per link-speed, per-phy. The triggers are registered during phy_attach and unregistered during phy_detach. This allows for a user to configure

[PATCH v5 3/4] net: phy: Create phy_supported_speeds function which lists speeds currently supported by a phydevice

phy_supported_speeds provides a means to get a list of all the speeds a phy device currently supports. Signed-off-by: Zach Brown --- drivers/net/phy/phy.c | 35 +++ include/linux/phy.h | 15 +++ 2 files changed, 50 insertions(+)

[PATCH 5/5] [media] st-cec: Fix module autoload

If the driver is built as a module, autoload won't work because the module alias information is not filled. So user-space can't match the registered device with the corresponding module. Export the module alias information using the MODULE_DEVICE_TABLE() macro. Before this patch: $ modinfo

[PATCH 4/5] [media] s5p-cec: Fix module autoload

If the driver is built as a module, autoload won't work because the module alias information is not filled. So user-space can't match the registered device with the corresponding module. Export the module alias information using the MODULE_DEVICE_TABLE() macro. Before this patch: $ modinfo

[PATCH 0/5] [media] Fix module autoload for media platform drivers

Hello Mauro, I noticed that module autoload won't be working in a bunch of media platform drivers because the module alias information is not filled in the modules. This patch series contains the fixes for them. Best regards, Javier Javier Martinez Canillas (5): [media] v4l: vsp1: Fix module

[PATCH] staging: rtl8188eu: Fix coding style errors

Fix coding style errors reported by checkpatch.pl, specifically: ERROR: space prohibited before that ',' (ctx:WxW) This patch get rid of all "ERROR" messages from checkpatch.pl for this file Signed-off-by: Carlos Maiolino ---

Re: [PATCH] staging: greybus: audio: Rename cport with intf_id

On Sun, Oct 16, 2016 at 03:29:14PM +0530, Pankaj Bharadiya wrote: > gb_audio_manager_module_descriptor's cport field is actually used to > manage and pass interface id to user space. > > Thus rename gb_audio_manager_module_descriptor's 'cport' field and > few other things to avoid confusion.

Re: [PATCH] staging: greybus: es2: Use kmemdup instead of kmalloc and memcpy

[+CC: staging list ] On Sun, Oct 16, 2016 at 02:19:48PM +0530, sayli karnik wrote: > This patch replaces kmalloc and memcpy with kmemdup for duplication of > memory. > > Signed-off-by: sayli karnik Acked-by: Johan Hovold > --- >

[PATCH -next] staging: bcm2708_vchiq: fix return value check in vchiq_platform_conn_state_changed()

From: Wei Yongjun In case of error, the function kthread_create() returns ERR_PTR() and never returns NULL. The NULL test in the return value check should be replaced with IS_ERR(). Signed-off-by: Wei Yongjun ---

[PATCH -next] staging: bcm2708_vchiq: remove .owner field for driver

From: Wei Yongjun Remove .owner field if calls are used which set it automatically. Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci Signed-off-by: Wei Yongjun --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c |

[PATCH -next] staging: bcm2708_vchiq: fix return value check in vchiq_init_state()

From: Wei Yongjun In case of error, the function kthread_create() returns ERR_PTR() and never returns NULL. The NULL test in the return value check should be replaced with IS_ERR(). Signed-off-by: Wei Yongjun ---

Re: [RFC PATCH v1 00/28] x86: Secure Encrypted Virtualization (AMD)

Hi Paolo, Thanks for reviews. I will incorporate your feedbacks in v2. On 10/13/2016 06:19 AM, Paolo Bonzini wrote: On 23/08/2016 01:23, Brijesh Singh wrote: TODO: - send qemu/seabios RFC's on respective mailing list - integrate the psp driver with CCP driver (they share the PCI id's) - add

[PATCH 1/1] Staging: gs_fpgaboot: Use octal permissions '0444'

Fixed following checkpatch warning WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. Signed-off-by: Shyam Saini --- drivers/staging/gs_fpgaboot/gs_fpgaboot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [PATCH 0/3] staging: ks7010: Coding style fixes

On Mon, Oct 17, 2016 at 01:26:51PM +0200, Carlos Maiolino wrote: > Hi Greg, > > I've based these patches on top of linux-next. Thanks anyway. > > Which tree are you applying these patches on? I'll make sure to submit > next patches based on your tree. While the -rc1 merge window was open, I

Re: [PATCH 0/3] staging: ks7010: Coding style fixes

Hi Greg, I've based these patches on top of linux-next. Thanks anyway. Which tree are you applying these patches on? I'll make sure to submit next patches based on your tree. Cheers On Mon, Oct 17, 2016 at 10:27 AM, Greg KH wrote: > On Sun, Oct 16, 2016 at

[PATCH v2 1/2] staging: dgnc: Remove some redundant functions

dgnc_tty_preinit() and dgnc_tty_post_uninit() functions are used to allocate and free "dgnc_TmpWriteBuf" and this "dgnc_TmpWriteBuf" is not really getting used. Hence remove these redundant functions. Also remove dgnc_TmpWriteBuf variable as it is not used anymore. Signed-off-by: Pankaj

[PATCH v2 0/2] staging: dgnc: Code cleaup

Hi, This patchset does minor cleanup for dgnc driver. v1->v2: - Split into multiple patches - remove redundant dgnc_tmp_write_buf variable and function calls - rename dgnc_default_termios to default_termios Pankaj Bharadiya (2): staging: dgnc: Remove some redundant functions staging: dgnc:

[PATCH v2 2/2] staging: dgnc: Replace CamelCase namings with underscores

Replace CamelCase names with underscores to comply with the standard kernel coding style. Signed-off-by: Pankaj Bharadiya --- drivers/staging/dgnc/dgnc_tty.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_tty.c

Re: [PATCH] staging: greybus: audio: remove redundant slot field

On Mon, Oct 17, 2016 at 2:42 PM, Pankaj Bharadiya wrote: > gb_audio_manager_module_descriptor's intf_id field maintains the > information about the interface on which module is connected hence > having an extra slot field is redundant. > > Thus remove the slot field

Re: [PATCH] staging: greybus: audio: remove redundant slot field

On Mon, Oct 17, 2016 at 2:42 PM, Pankaj Bharadiya wrote: > gb_audio_manager_module_descriptor's intf_id field maintains the > information about the interface on which module is connected hence > having an extra slot field is redundant. > > Thus remove the slot field

[PATCH] staging: greybus: audio: remove redundant slot field

gb_audio_manager_module_descriptor's intf_id field maintains the information about the interface on which module is connected hence having an extra slot field is redundant. Thus remove the slot field and its associated code. Signed-off-by: Pankaj Bharadiya ---

Re: linux-4.9-rc1/drivers/staging/lustre/lustre/osc/osc_request.c:973: always false test ?

On Mon, Oct 17, 2016 at 07:33:33AM +, David Binderman wrote: > Hello there, > > > > linux-4.9-rc1/drivers/staging/lustre/lustre/osc/osc_request.c:973]: (style) > Checking if unsigned variable 'cli.cl_avail_grant' is less than zero. > > > > Source code is > > > >    if

Re: [PATCH] staging: dgnc: replace DGNC_VERIFY_BOARD macro

On Fri, Oct 14, 2016 at 07:22:57PM +0200, Fernando Apesteguia wrote: > The patch replaces the macro with a function (dgnc_get_board) and > substitutes the macro statement with a call to that function and a > comparison on the returned value. > > This removes a checkpatch warning. > >

Re: [PATCH 0/3] staging: ks7010: Coding style fixes

On Sun, Oct 16, 2016 at 10:16:00PM +0200, Carlos Maiolino wrote: > A small patchset fixing some coding style errors identified by checkpatch.pl > > Greg. I splitted the single patch into 3 different patches now, hope I set it > right now :) > > Also added a blank line before the signed-off.

Re: [PATCH] staging: dgnc: dgnc_tty: Add missing static keyword.

On Mon, Oct 17, 2016 at 12:40:01AM +0100, Cathal Mullaney wrote: > Fixed sparse warning; function not declared static. > > Signed-off-by: Cathal Mullaney > --- > drivers/staging/dgnc/dgnc_tty.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Someone else

Re: [PATCH] staging: dgnc: Replace CamelCase namings with underscores.

On Mon, Oct 17, 2016 at 01:13:55AM +0530, Pankaj Bharadiya wrote: > Replace CamelCase names with underscores to comply with the standard > kernel coding style. > > Signed-off-by: Pankaj Bharadiya > --- > drivers/staging/dgnc/dgnc_tty.c | 20 ++-- > 1

linux-4.9-rc1/drivers/staging/lustre/lustre/osc/osc_request.c:973: always false test ?

Hello there, linux-4.9-rc1/drivers/staging/lustre/lustre/osc/osc_request.c:973]: (style) Checking if unsigned variable 'cli.cl_avail_grant' is less than zero. Source code is    if (cli->cl_avail_grant < 0) { Suggest code rework. Regards David Binderman

Re: [PATCH] staging/lustre/llite: Move unstable_stats from sysfs to debugfs

On Sun, Oct 16, 2016 at 01:16:50PM -0400, Oleg Drokin wrote: > It's multiple values per file, so it has no business being in sysfs, > besides it was assuming seqfile anyway. > > Introduced by > commit d806f30e639b ("staging: lustre: osc: revise unstable pages accounting") In the future, the