[PATCH v3] staging : rtl8712: Free memory when kmalloc fails

2016-10-27 Thread Souptick Joarder
There are few functions where we need to free previously allocated memory when kmalloc fails. Else it may lead to memory leakage. In _init_cmd_priv() and _r8712_init_xmit_priv(), in few places we are not freeing previously allocated memory when kmalloc fails. Signed-off-by: Souptick joarder

[PATCH 3/3] staging: sm750fb: Shorten local variables names.

2016-10-27 Thread Elise Lennion
Shorter names are preferred by C variables naming convention, they are easier to write and aren't more difficult to understand. Signed-off-by: Elise Lennion --- drivers/staging/sm750fb/ddk750_power.c | 26 +- 1 file changed, 13 insertions(+), 13

[PATCH 2/3] staging: sm750fb: Replace functions CamelCase naming with underscores.

2016-10-27 Thread Elise Lennion
Replace CamelCase function names with underscores to comply with the standard kernel coding style. Signed-off-by: Elise Lennion --- drivers/staging/sm750fb/ddk750_chip.c| 4 ++-- drivers/staging/sm750fb/ddk750_display.c | 2 +-

[PATCH 1/3] staging: sm750fb: Refine code in set_current_gate().

2016-10-27 Thread Elise Lennion
The 'switch' statement in set_current_gate() had only two possible scenarios, so it was replaced with an 'if' statement to make the code shorter and easier to understand. Signed-off-by: Elise Lennion --- drivers/staging/sm750fb/ddk750_power.c | 24

Re: [PATCH 12/29] staging: lustre: mdc: manage number of modify RPCs in flight

2016-10-27 Thread kbuild test robot
Hi Gregoire, [auto build test WARNING on staging/staging-testing] [also build test WARNING on next-20161027] [cannot apply to v4.9-rc2] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] [Suggest to use git(>=2.9.0) format-patch --base= (or --b

[PATCH 22/29] staging: lustre: llite: add LL_IOC_FUTIMES_3

2016-10-27 Thread James Simmons
From: John L. Hammond Add a new regular file ioctl LL_IOC_FUTIMES_3 similar to futimes() but which allows setting of all three inode timestamps. Use this ioctl during HSM restore to ensure that the volatile file has the same timestamps as the file to be restored.

[PATCH 28/29] staging: lustre: ptlrpc: imp_peer_committed_transno should increase

2016-10-27 Thread James Simmons
From: Alex Zhuravlev imp_peer_committed_transno should not decrease as this can confuse the users if imp_peer_committed_transno is used to check commit status. Signed-off-by: Alex Zhuravlev Intel-bug-id:

[PATCH 10/29] staging: lustre: ptlrpc: embed highest XID in each request

2016-10-27 Thread James Simmons
From: Gregoire Pichon Atomically assign XIDs and put request and sending list so we can learn the lowest unreplied XID at any point. This allows to embed in every resquests the highest XID for which a reply has been received and does not have an unreplied

[PATCH 11/29] staging: lustre: llite: basic support of SELinux in CLIO

2016-10-27 Thread James Simmons
From: Sebastien Buisson Bring the ability to properly initiate security context on SELinux-enabled client and store it on server side via extended attribute. Security context initialization is not atomic, but that would require a wire protocol change to send security

[PATCH 25/29] staging: lustre: llite: Inform copytool of dataversion changes

2016-10-27 Thread James Simmons
From: Henri Doreau Notify copytool that a file could not be archived due to dataversion change. This does not introduce any functional change but ensures that errors are consistently reported in copytool logs. Signed-off-by: Henri Doreau Intel-bug-id:

[PATCH 14/29] staging: lustre: ptlrpc: Do not resend req with allow_replay

2016-10-27 Thread James Simmons
From: wang di If the request is allowed to be sent during recovery, and it is not timeout yet, then we do not need to resend it in the final stage of recovery. Unnecessary resend will cause the bulk request to resend the request with different mbit, but same xid, and on the

[PATCH 27/29] staging: lustre: headers: Create single .h for lu_seq_range

2016-10-27 Thread James Simmons
From: Ben Evans Put lu_seq_range related functions into a single .h. Include directly from files which use it, and remove definitions from lustre_idl.h. Signed-off-by: Ben Evans Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6401 Reviewed-on:

[PATCH 26/29] staging: lustre: ptlrpc: do not switch out-of-date context

2016-10-27 Thread James Simmons
From: Sebastien Buisson When trying to replace a dead sec context with a new one, we must ensure the new context is already up-to-date. If it is not the case, just return from sptlrpc_req_replace_dead_ctx() and come later when the new context has been updated.

[PATCH 07/29] staging: lustre: lov: remove LSM from struct lustre_md

2016-10-27 Thread James Simmons
From: John L. Hammond In struct lustre_md replace the struct lov_stripe_md *lsm member with an opaque struct lu_buf layout which holds the layout metadata returned by the server. Refactor the LOV object initialization and layout change code to accommodate this. Simplify

[PATCH 20/29] staging: lustre: recovery: don't skip open replay on reconnect

2016-10-27 Thread James Simmons
From: Niu Yawei Once reconnect happened during replay, we'd continue the open replay with the last failed replay, but not the next. Signed-off-by: Niu Yawei Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6802 Reviewed-on:

[PATCH 15/29] staging: lustre: obdecho: don't copy lu_site

2016-10-27 Thread James Simmons
From: Niu Yawei While creating an echo device, echo_device_alloc() copies the lu_site from MD stack, such kind of copy result in uninitialized mutex and other potential issues. Instead of copying the lu_site, we'd use the lu_site by pointer directly. Signed-off-by: Niu

[PATCH 16/29] staging: lustre: mdc: deactive MDT permanently

2016-10-27 Thread James Simmons
From: wang di Add active proc entry for MDC, and mark MDC to be inactive once the MDC is deactivated. Signed-off-by: wang di Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6586 Reviewed-on: http://review.whamcloud.com/14747 Reviewed-by: Lai Siyao

[PATCH 29/29] staging: lustre: llog: record the minimum record size

2016-10-27 Thread James Simmons
From: wang di The minimum record size will be recorded in llh_size, which is only used by fixed size record llog now, and also add another flag LLOG_F_IS_FIXSIZE to indicate the fix size record llog. Signed-off-by: wang di Intel-bug-id:

[PATCH 24/29] staging: lustre: ptlrpc: Forbid too early NRS policy tunings

2016-10-27 Thread James Simmons
From: Henri Doreau Wait for a NRS policy to be fully started before allowing to apply related tunings, so that all fields are properly initialized. Signed-off-by: Henri Doreau Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6673 Reviewed-on:

[PATCH 08/29] staging: lustre: clio: update file attributes after sync

2016-10-27 Thread James Simmons
From: Bobi Jam This really only affects clients that are attached to lustre server running ZFS, because zfs does not update # of blocks until the blocks are flushed to disk. This patch update file's blocks attribute after OST_SYNC completes. Signed-off-by: Bobi Jam

[PATCH 18/29] staging: lustre: mdt: disable IMA support

2016-10-27 Thread James Simmons
From: Hongchao Zhang For IMA (Integrity Measurement Architecture), there are two xattr "security.ima" and "security.evm" to protect the file to be modified accidentally or maliciously, the two xattr are not compatible with VBR, then disable it to workaround the problem

[PATCH 23/29] staging: lustre: ptlrpc: do not sleep if encpool reached max capacity

2016-10-27 Thread James Simmons
From: Sebastien Buisson When encryption is enabled RPCs are encrypted just before being sent. The encryption requires allocating memory in the encoding pool. The current implementation in sptlrpc_enc_pool_get_pages() is deadlock-prone. Indeed, if there is no more free

[PATCH 21/29] staging: lustre: obdclass: race lustre_profile_list

2016-10-27 Thread James Simmons
From: Hiroya Nozaki Running multiple mounts at the same time results in lustre_profile_list corruption when adding a new profile. This patch adds a new spin_lock to protect the list and avoid the bug Signed-off-by: Hiroya Nozaki

[PATCH 04/29] staging: lustre: obdclass: variable llog chunk size

2016-10-27 Thread James Simmons
From: Andreas Dilger Do not use fix LLOG_CHUNK_SIZE (8192 bytes), and it will get the llog_chunk_size from llog_log_hdr. Accordingly llog header will be variable too, so we can enlarge the bitmap in the header, then have more records in each llog file. Signed-off-by:

[PATCH 13/29] staging: lustre: llite: report back to user bad stripe count

2016-10-27 Thread James Simmons
From: wang di If the user is requesting a stripe count larger than what is supported in the file system then report back to the user an error as well as what is the largest possible striping. Signed-off-by: wang di Intel-bug-id:

[PATCH 05/29] staging: lustre: lmv: allow cross-MDT rename and link

2016-10-27 Thread James Simmons
From: wang di Remove checks for cross-MDT operation, so cross-MDT rename and link will be allowed. Remove obsolete locality parameters in MDT lock API after all of cross-MDT operations are allowed. This is the client side changed only so the upstream client can support this.

[PATCH 17/29] staging: lustre: ptlrpc: replay bulk request

2016-10-27 Thread James Simmons
From: wang di Even though the server might already got the bulk replay request, but bulk transfer timeout, let's replay the bulk request, i.e. treat such replay as same as no replied replay request (See ptlrpc_replay_interpret()). Signed-off-by: wang di

[PATCH 01/29] staging: lustre: osc: remove handling cl_avail_grant less than zero

2016-10-27 Thread James Simmons
Earlier cl_avail_grant was changed to an unsigned int. Juila Lawall reported for the upstream client the following which affects the Intel branch as well: drivers/staging/lustre/lustre/osc/osc_request.c:1045:5-24: WARNING: Unsigned expression compared with zero: cli -> cl_avail_grant < 0 Since

[PATCH 06/29] staging: lustre: ptlrpc: Introduce iovec to bulk descriptor

2016-10-27 Thread James Simmons
From: Amir Shehata Added a union to ptlrpc_bulk_desc for KVEC and KIOV buffers. bd_type has been changed to be a bit mask. Bits are set in bd_type to specify {put,get}{source,sink}{kvec,kiov} changed all instances in the code to access the union properly ASSUMPTION: all

[PATCH 19/29] staging: lustre: ldlm: reclaim granted locks defensively

2016-10-27 Thread James Simmons
From: Niu Yawei It was discovered that to many ldlm locks where being created on the server side to the point of memory exhaustion. The work of LU-6529 introduced watermarks to avoid this memory exhaustion. This is the client side part of this work for the upstream client.

[PATCH 09/29] staging: lustre: dne: setdirstripe should fail if not supported

2016-10-27 Thread James Simmons
From: Lai Siyao If MDS doesn't support striped directory, creating striped directory from a userland utility such as 'lfs setdirstripe' should fail. Signed-off-by: Lai Siyao Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6661 Reviewed-on:

[PATCH 03/29] staging: lustre: llite: restart short read/write for normal IO

2016-10-27 Thread James Simmons
From: Bobi Jam If normal IO got short read/write, we'd restart the IO from where we've accomplished until we meet EOF or error happens. Signed-off-by: Bobi Jam Signed-off-by: Jinshan Xiong Intel-bug-id:

[PATCH 12/29] staging: lustre: mdc: manage number of modify RPCs in flight

2016-10-27 Thread James Simmons
From: Gregoire Pichon This patch is the main client part of a new feature that supports multiple modify metadata RPCs in parallel. Its goal is to improve metadata operations performance of a single client, while maintening the consistency of MDT reply reconstruction and

[PATCH 02/29] staging: lustre: llite: remove IS_ERR(master_inode) check

2016-10-27 Thread James Simmons
The kernel function ilookup5_nowait never returns IS_ERR so we can remove the IS_ERR check in the ll_md_blocking_ast() function. Signed-off-by: James Simmons Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8697 Reviewed-on: http://review.whamcloud.com/23151 Reported-by:

[PATCH 00/29] Batch one for work from 2.7.55 to 2.7.59

2016-10-27 Thread James Simmons
The first two patches are fixes for problems pointed out by Dan Carpenter and Julia LaWall. Batch of fixes from the Lustre 2.8 version. Basic support for selinux which before this work prevented lustre from running. First patch to cleanup lustre_idl.h which is a uapi header. All these patches are

[driver-core:driver-core-testing 2/6] drivers/built-in.o:undefined reference to `process_srcu'

2016-10-27 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git driver-core-testing head: ae17f29d0bb84a43b6c5f3e9fac0b124960c53f7 commit: eb6b1b0ba7aa8da0b67bba65764d1258f87b924e [2/6] driver core: Functional dependencies tracking support config: mips-allnoconfig (attached as

[driver-core:driver-core-testing 2/6] drivers/base/core.o:(.text.__device_link_del+0x48): undefined reference to `call_srcu'

2016-10-27 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git driver-core-testing head: ae17f29d0bb84a43b6c5f3e9fac0b124960c53f7 commit: eb6b1b0ba7aa8da0b67bba65764d1258f87b924e [2/6] driver core: Functional dependencies tracking support config: parisc-allnoconfig (attached as

[PATCH] staging: comedi: ni_tio: fix buggy ni_tio_clock_period_ps() return value

2016-10-27 Thread Ian Abbott
`ni_tio_clock_period_ps()` used to return the clock period in picoseconds, and had a `BUG()` call for invalid cases. It was changed to pass the clock period back via a pointer parameter and return an error for the invalid cases. Unfortunately the code to handle user-specified clock sources with

Re: [PATCH v2] staging : rtl8712: Free memory when kmalloc fails

2016-10-27 Thread Souptick Joarder
On Thu, Oct 27, 2016 at 6:40 PM, Greg KH wrote: > On Thu, Oct 27, 2016 at 01:46:13PM +0530, Souptick Joarder wrote: >> There are few functions where we need to free previously allocated memory >> when kmalloc fails.Else it may lead to memory leakage.In

Re: [PATCH v2 0/2] staging: nvec: ps2: fix touchpad operation

2016-10-27 Thread Marc Dietrich
Am Donnerstag, 27. Oktober 2016, 17:22:07 CEST schrieb Paul Fertser: > Status quo on Toshiba ac100 (paz00) is that the integrated elantech touchpad > is detected as an ImPS/2 mouse and so it's kind of functional but advanced > synaptics configuration isn't available. > > When only serio type is

[PATCH v2 2/2] Revert "staging: nvec: ps2: change serio type to passthrough"

2016-10-27 Thread Paul Fertser
This reverts commit 36b30d6138f4677514aca35ab76c20c1604baaad. This is necessary to detect paz00 (ac100) touchpad properly as one speaking ETPS/2 protocol. Without it X.org's synaptics driver doesn't work as the touchpad is detected as an ImPS/2 mouse instead. Commit

[PATCH v2 1/2] drivers: staging: nvec: remove bogus reset command for PS/2 interface

2016-10-27 Thread Paul Fertser
This command was sent behind serio's back and the answer to it was confusing atkbd probe function which lead to the elantech touchpad getting detected as a keyboard. To prevent this from happening just let every party do its part of the job. Signed-off-by: Paul Fertser ---

[PATCH v2 0/2] staging: nvec: ps2: fix touchpad operation

2016-10-27 Thread Paul Fertser
Status quo on Toshiba ac100 (paz00) is that the integrated elantech touchpad is detected as an ImPS/2 mouse and so it's kind of functional but advanced synaptics configuration isn't available. When only serio type is changed it leads to atkbd misdetecting the touchpad as a keyboard. So first goes

Re: [PATCH] drivers: staging: nvec: remove bogus reset command for PS/2 interface

2016-10-27 Thread Marc Dietrich
Hi Paul, thanks for finding the issue! Am Donnerstag, 27. Oktober 2016, 16:55:14 CEST schrieb Paul Fertser: > This command was sent behind serio's back and the answer to it was > confusing atkbd probe function which lead to the elantech touchpad > getting detected as a keyboard. > > To prevent

[PATCH] drivers: staging: nvec: remove bogus reset command for PS/2 interface

2016-10-27 Thread Paul Fertser
This command was sent behind serio's back and the answer to it was confusing atkbd probe function which lead to the elantech touchpad getting detected as a keyboard. To prevent this from happening just let every party do its part of the job. Signed-off-by: Paul Fertser ---

Re: [PATCH v2 1/2] staging: lustre: remove broken dead code in cfs_cpt_table_create_pattern

2016-10-27 Thread Arnd Bergmann
On Thursday, October 27, 2016 3:12:42 PM CEST Greg Kroah-Hartman wrote: > On Tue, Oct 25, 2016 at 11:22:30PM +0200, Arnd Bergmann wrote: > > After a recent bugfix, we get a warning about the use of an uninitialized > > variable: > > > > drivers/staging/lustre/lnet/libcfs/linux/linux-cpu.c: In

Re: [PATCH 4/5] staging: vc04_services: fix CamelCase

2016-10-27 Thread Greg Kroah-Hartman
On Thu, Oct 27, 2016 at 04:24:31AM +0300, Dan Carpenter wrote: > On Wed, Oct 26, 2016 at 06:13:13PM -0700, Eric Anholt wrote: > > Stefan Wahren writes: > > > > > This fixes the CamelCase of some variables. > > > > > > Signed-off-by: Stefan Wahren

Re: [PATCH v2 1/2] staging: lustre: remove broken dead code in cfs_cpt_table_create_pattern

2016-10-27 Thread Greg Kroah-Hartman
On Tue, Oct 25, 2016 at 11:22:30PM +0200, Arnd Bergmann wrote: > After a recent bugfix, we get a warning about the use of an uninitialized > variable: > > drivers/staging/lustre/lnet/libcfs/linux/linux-cpu.c: In function > 'cfs_cpt_table_create_pattern': >

Re: [PATCH v2] staging : rtl8712: Free memory when kmalloc fails

2016-10-27 Thread Greg KH
On Thu, Oct 27, 2016 at 01:46:13PM +0530, Souptick Joarder wrote: > There are few functions where we need to free previously allocated memory > when kmalloc fails.Else it may lead to memory leakage.In _init_cmd_priv() > and _r8712_init_xmit_priv(),in few places we are not freeing previously >

Re: [PATCH] staging :rtl8712: Free memory when kmalloc fails

2016-10-27 Thread Greg KH
On Thu, Oct 27, 2016 at 01:00:01PM +0530, Souptick Joarder wrote: > On Thu, Oct 27, 2016 at 11:20 AM, Greg KH wrote: > > On Thu, Oct 27, 2016 at 11:10:09AM +0530, Souptick Joarder wrote: > >> There are few functions where we need to free previously allocated memory >

Re: [PATCH 2/3] staging: most: hdm-usb: do h/w specific synchronization at configuration time

2016-10-27 Thread Greg KH
On Thu, Oct 27, 2016 at 01:00:47PM +0200, Christian Gromm wrote: > On Thu, 27 Oct 2016 12:00:28 +0300 > Dan Carpenter wrote: > > > On Thu, Oct 27, 2016 at 10:57:07AM +0200, Christian Gromm wrote: > > > On Wed, 26 Oct 2016 17:22:50 +0300 > > > Dan Carpenter

Re: [PATCH 2/3] staging: most: hdm-usb: do h/w specific synchronization at configuration time

2016-10-27 Thread Christian Gromm
On Thu, 27 Oct 2016 12:00:28 +0300 Dan Carpenter wrote: > On Thu, Oct 27, 2016 at 10:57:07AM +0200, Christian Gromm wrote: > > On Wed, 26 Oct 2016 17:22:50 +0300 > > Dan Carpenter wrote: > > > > > On Tue, Oct 25, 2016 at 05:44:20PM +0200,

Re: [PATCH 2/3] staging: most: hdm-usb: do h/w specific synchronization at configuration time

2016-10-27 Thread Dan Carpenter
On Thu, Oct 27, 2016 at 10:57:07AM +0200, Christian Gromm wrote: > On Wed, 26 Oct 2016 17:22:50 +0300 > Dan Carpenter wrote: > > > On Tue, Oct 25, 2016 at 05:44:20PM +0200, Christian Gromm wrote: > > > From: Andrey Shvetsov > > > > > > This

Re: [PATCH 2/3] staging: most: hdm-usb: do h/w specific synchronization at configuration time

2016-10-27 Thread Christian Gromm
On Wed, 26 Oct 2016 17:22:50 +0300 Dan Carpenter wrote: > On Tue, Oct 25, 2016 at 05:44:20PM +0200, Christian Gromm wrote: > > From: Andrey Shvetsov > > > > This patch puts the synchronization procedure trigger for asynchronous > > channels

[PATCH v2] staging : rtl8712: Free memory when kmalloc fails

2016-10-27 Thread Souptick Joarder
There are few functions where we need to free previously allocated memory when kmalloc fails.Else it may lead to memory leakage.In _init_cmd_priv() and _r8712_init_xmit_priv(),in few places we are not freeing previously allocated memory when kmalloc fails. Signed-off-by: Souptick joarder

Re: [PATCH] staging :rtl8712: Free memory when kmalloc fails

2016-10-27 Thread Souptick Joarder
On Thu, Oct 27, 2016 at 11:20 AM, Greg KH wrote: > On Thu, Oct 27, 2016 at 11:10:09AM +0530, Souptick Joarder wrote: >> There are few functions where we need to free previously allocated memory >> when kmalloc fails. Else it may lead to memory leakage. >> In

RE: Patchwork for this mailing list?

2016-10-27 Thread KY Srinivasan
> -Original Message- > From: devel [mailto:driverdev-devel-boun...@linuxdriverproject.org] On > Behalf Of Greg KH > Sent: Wednesday, October 26, 2016 10:38 PM > To: Dan Carpenter > Cc: de...@driverdev.osuosl.org > Subject: Re: Patchwork for this mailing list? >

Re: Patchwork for this mailing list?

2016-10-27 Thread Dan Carpenter
On Thu, Oct 27, 2016 at 07:37:42AM +0200, Greg KH wrote: > A whole new list for just a single tiny subsystem? That's crazy too. > What about the virtualization list instead? That's where the vmware and > other subsystems that look like this all hang out at. > Sounds like a winning idea to me.