Re: [patch] staging: lustre: lnet: memory corruption in selftest

2016-11-25 Thread Dilger, Andreas
On Nov 24, 2016, at 04:10, Dan Carpenter wrote: > > We want sizeof(struct lstcon_node) but instead we're getting the sizeof > a pointer. > > Fixes: 8d78f0f2ba76 ("staging: lustre: lnet: cleanup some of the > 80 line > issues") > Signed-off-by: Dan Carpenter

Re: [PATCH v2] Staging: iio: adc: fix sysfs files modes in ad7192.c

2016-11-25 Thread Boyan Vladinov
Ignore patch version...comments below Will resend it On 24.11.2016 19:38, Boyan Vladinov wrote: Fixes sysfs entries user/group modes and coding style warnings found by checkpatch.pl tool. Also use the IIO_DEVICE_ATTR_[RO|RW] and macros to create device attributes Signed-off-by: Boyan Vladinov

fixed drivers/staging/most/mostcore/core.c coding style

2016-11-25 Thread wenhungyang
fix drivers/staging/most/mostcore/core.c coding style 1. move static from MACRO to function name 2. change symbolic permission such as 'S_IRUGO' to number >From 3e1dba83090c58251aae1dc7aca431bb11632a98 Mon Sep 17 00:00:00 2001 From: wenhungyang Date: Wed, 23 Nov 2016

Re: [lustre-devel] [PATCH 09/10] staging: lustre: libcfs: remove zero comparisons in headers

2016-11-25 Thread Dilger, Andreas
On Nov 18, 2016, at 09:48, James Simmons wrote: > > Remove the zero comparisions in the libcfs headers. > > Signed-off-by: James Simmons > --- > .../lustre/include/linux/libcfs/libcfs_crypto.h|2 +- >

Re: [lustre-devel] [patch] staging: lustre/ptlrpc: small leak on allocation failure

2016-11-25 Thread Dilger, Andreas
On Nov 24, 2016, at 04:12, Dan Carpenter wrote: > > We should free "desc" before returning NULL. > > Signed-off-by: Dan Carpenter Reviewed-by: Andreas Dilger > diff --git

[PATCH v2] staging: most: Eliminate usage of symbolic permissions

2016-11-25 Thread Jason Litzinger
Litzinger <jlitzinger...@gmail.com> --- changelog: v2) Fix missing semicolon on hunk with _ATTR_WO. Tested/built/loaded linux-next(next-20161125) Test-built staging-next from staging tree drivers/staging/most/mostcore/core.c | 18 -- 1 file changed, 8 insertions(+), 10 del

Re: [PATCH v2] staging: lustre: osc: Performance tune for LRU

2016-11-25 Thread Dan Carpenter
On Wed, Nov 23, 2016 at 06:01:45PM -0500, James Simmons wrote: > From: Jinshan Xiong > > Early launch page LRU work in osc_io_rw_iter_init(); > Change the page LRU shrinking policy by OSC attributes; > Delete the contented lock osc_object::oo_seatbelt > The cli_name()

Re: [PATCH] staging: rtl8712: Fix coding style warnings on Block comments

2016-11-25 Thread Dan Carpenter
On Sun, Nov 20, 2016 at 05:01:52PM -0800, Vijai Kumar K wrote: > + *Please insert all the queue initialization using _init_queue below Add a space after the '*'. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org

[PATCH] staging: gdm724x: Align parameters to parenthesis

2016-11-25 Thread Dawid Kurek
Align parameters to open parenthesis. Also remove one blank line in sequence of two. Signed-off-by: Dawid Kurek --- drivers/staging/gdm724x/gdm_lte.h | 14 +++--- drivers/staging/gdm724x/gdm_tty.h | 1 - drivers/staging/gdm724x/netlink_k.h | 3 ++- 3 files

Re: [PATCH v2 net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver

2016-11-25 Thread kbuild test robot
Hi Lino, [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Lino-Sanfilippo/net-ethernet-slicoss-add-slicoss-gigabit-ethernet-driver/20161125-190558 config: sparc64-allmodconfig (attached as .config) compiler: sparc64-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1

[c157e58488d1] fix core.c coding-style

2016-11-25 Thread wenhungyang
Signed-off-by: wenhungyang --- drivers/staging/most/mostcore/core.c | 40 ++-- 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/drivers/staging/most/mostcore/core.c b/drivers/staging/most/mostcore/core.c index 4c580d1..9286c36

Re: [PATCH v2 1/5] staging: speakup: synth.c Spaces around operators

2016-11-25 Thread Dan Carpenter
On Sat, Nov 19, 2016 at 12:35:43PM -0500, Walt Feasel wrote: > Make suggested checkpatch modification for > CHECK: spaces preferred around that '+,|,-,/' > > Signed-off-by: Walt Feasel > --- > v2 makes changes to correct for email format patch submission > >

Re: [PATCH] staging: most: Eliminate symbolic permissions usage

2016-11-25 Thread kbuild test robot
-permissions-usage/20161125-194750 config: ia64-allmodconfig (attached as .config) compiler: ia64-linux-gcc (GCC) 6.2.0 reproduce: wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save

Re: Follow up on Ion from LPC

2016-11-25 Thread Dan Carpenter
On Fri, Nov 18, 2016 at 01:07:51PM -0800, Laura Abbott wrote: > I'd like to keep using linaro-mm-sig as a mailing list for Ion > discussion as well as drivers-devel. You could add it to MAINTAINERS so people thinking about ION know it exists. regards, dan carpenter

[PATCH 2/7] hv: allocate synic pages for all present CPUs

2016-11-25 Thread Vitaly Kuznetsov
It may happen that not all CPUs are online when we do hv_synic_alloc() and in case more CPUs come online later we may try accessing these allocated structures. Signed-off-by: Vitaly Kuznetsov --- drivers/hv/hv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

[PATCH 7/7] hv: make CPU offlining prevention fine-grained

2016-11-25 Thread Vitaly Kuznetsov
Since commit e513229b4c38 ("Drivers: hv: vmbus: prevent cpu offlining on newer hypervisors") cpu offlining was disabled. It is still true that we can't offline CPUs which have VMBus channels bound to them but we may have 'free' CPUs (e.v. we booted with maxcpus= parameter and onlined CPUs after

[PATCH 3/7] hv: init percpu_list in hv_synic_alloc()

2016-11-25 Thread Vitaly Kuznetsov
Initializing hv_context.percpu_list in hv_synic_alloc() helps to prevent a crash in percpu_channel_enq() when not all CPUs were online during initialization and it naturally belongs there. Signed-off-by: Vitaly Kuznetsov --- drivers/hv/hv.c | 4 ++-- 1 file changed, 2

[PATCH 6/7] hv: switch to cpuhp state machine for synic init/cleanup

2016-11-25 Thread Vitaly Kuznetsov
To make it possible to online/offline CPUs switch to cpuhp infrastructure for doing hv_synic_init()/hv_synic_cleanup(). Signed-off-by: Vitaly Kuznetsov --- drivers/hv/hv.c | 15 +++ drivers/hv/hyperv_vmbus.h | 4 ++-- drivers/hv/vmbus_drv.c| 19

[PATCH 0/7] hv: CPU onlining/offlining fixes and improvements

2016-11-25 Thread Vitaly Kuznetsov
Some time ago we forbade CPU offlining for Hyper-V and this was sufficient if you boot with all CPUs onlined. Turns out, people may want to limit the number online CPUs by passing 'maxcpus=' kernel parameter and we hit a crash in Hyper-V code in this case. After some thinking, I think we may not

[PATCH 1/7] hv: acquire vmbus_connection.channel_mutex in vmbus_free_channels()

2016-11-25 Thread Vitaly Kuznetsov
"kernel BUG at drivers/hv/channel_mgmt.c:350!" is observed when hv_vmbus module is unloaded. BUG_ON() was introduced in commit 85d9aa705184 ("Drivers: hv: vmbus: add an API vmbus_hvsock_device_unregister()") as vmbus_free_channels() codepath was apparently forgotten. Fixes: 85d9aa705184

[PATCH 5/7] hv: check all present cpus in vmbus_wait_for_unload()

2016-11-25 Thread Vitaly Kuznetsov
It should never happen, but let's get prepared to receiving a confirmation for VMBus unload on an offlined CPU. As we allocate all structures for all present CPUs now it's safe. Signed-off-by: Vitaly Kuznetsov --- drivers/hv/channel_mgmt.c | 4 ++-- 1 file changed, 2

[PATCH 4/7] hv: change clockevents unbind tactics

2016-11-25 Thread Vitaly Kuznetsov
To get prepared to CPU offlining support we need co change the way how we unbind clockevent devices. As one CPU may go online/offline multiple times we need to bind it in hv_synic_init() and unbind it in hv_synic_cleanup(). The is an additional corner case: when we unload the module completely we

Re: [Linaro-mm-sig] Follow up on Ion from LPC

2016-11-25 Thread Benjamin Gaignard
Hi Laura, Thanks for what you are doing on ION. As soon that will be ok I will submit again the driver for sti platform. After reading your mail I have the feeling that solves cache, devicetree and legacy support problems will be difficult. Since "Unix Device Memory Allocator" claims that it

Re: [PATCH 08/10] staging: lustre: libcfs: remove NULL comparisons in headers

2016-11-25 Thread Dan Carpenter
On Fri, Nov 18, 2016 at 11:48:42AM -0500, James Simmons wrote: > diff --git a/drivers/staging/lustre/include/linux/libcfs/libcfs_private.h > b/drivers/staging/lustre/include/linux/libcfs/libcfs_private.h > index 93bff1b..fc180b8 100644 > ---

Re: [PATCH 3/3] staging: comedi: s626: use preferred kernel type u32

2016-11-25 Thread Ian Abbott
On 24/11/16 20:33, Saber Rezvani wrote: From 5a907ea23f93f4358a91eb75915ef4b6134a9034 Mon Sep 17 00:00:00 2001 From: Saber Date: Thu, 24 Nov 2016 23:35:52 +0330 Subject: [PATCH 3/3] staging: comedi: s626: use preferred kernel type u32 Fix the checkpatch.pl issue: CHECK:

Re: [PATCH 2/3] staging: comedi: s626: use preferred kernel type u16

2016-11-25 Thread Ian Abbott
On 24/11/16 20:32, Saber Rezvani wrote: From 946376d81bd841696316123586028914448523d1 Mon Sep 17 00:00:00 2001 From: Saber Date: Thu, 24 Nov 2016 23:25:47 +0330 Subject: [PATCH 2/3] staging: comedi: s626: use preferred kernel type u16 Fix the checkpatch.pl issue: CHECK:

Re: [PATCH 1/3] staging: comedi: s626: use preferred kernel type u8

2016-11-25 Thread Ian Abbott
On 24/11/16 20:31, Saber Rezvani wrote: From c3dd43f3d43e7bec8f7f1140519ffc1f3b727b01 Mon Sep 17 00:00:00 2001 From: Saber Date: Thu, 24 Nov 2016 23:15:21 +0330 Subject: [PATCH 1/3] staging: comedi: s626: use preferred kernel type u8 All that extra header stuff above will

Aw: Re: [PATCH v2 net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver

2016-11-25 Thread Lino Sanfilippo
Hi, > > On Fri, Nov 25, 2016 at 12:13:04AM +0100, Lino Sanfilippo wrote: > > --- a/include/linux/pci_ids.h > > +++ b/include/linux/pci_ids.h > > @@ -2015,6 +2015,24 @@ > > #define PCI_SUBDEVICE_ID_CCD_OV4S 0xE888 > > #define PCI_SUBDEVICE_ID_CCD_OV8S 0xE998 > > > > +#define

Re: [PATCH v2 net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver

2016-11-25 Thread Greg KH
On Fri, Nov 25, 2016 at 12:13:04AM +0100, Lino Sanfilippo wrote: > --- a/include/linux/pci_ids.h > +++ b/include/linux/pci_ids.h > @@ -2015,6 +2015,24 @@ > #define PCI_SUBDEVICE_ID_CCD_OV4S0xE888 > #define PCI_SUBDEVICE_ID_CCD_OV8S0xE998 > > +#define PCI_VENDOR_ID_ALACRITECH

[PATCH v2 1/1] staging: ks7010: fixed 'space prohibited after that *' erros.

2016-11-25 Thread Yamanappagouda Patil
Fixed checkpatch.pl errors related to "space prohibited after that '*' or '&'" in ks_wlan_net.c file. Signed-off-by: Yamanappagouda Patil --- drivers/staging/ks7010/ks_wlan_net.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git

[PATCH] Staging: media: davinci_vpfe: - Fix for memory leak if decoder initialization fails.

2016-11-25 Thread Shailendra Verma
Fix to avoid possible memory leak if the decoder initialization got failed.Free the allocated memory for file handle object before return in case decoder initialization fails. Signed-off-by: Shailendra Verma --- drivers/staging/media/davinci_vpfe/vpfe_video.c |3

Re: [PATCH] staging: most: Eliminate symbolic permissions usage

2016-11-25 Thread Jason Litzinger
On Thu, Nov 24, 2016 at 03:10:29PM -0700, Jason Litzinger wrote: > Fix checkpatch warnings regarding the use of symbolic permissions. > > Where the MOST_CHANNEL_ATTR macro is used, convert to octal permissions > over symbolic. > > Where _ATTR is used directly, replace with _ATTR_RW/_ATTR_WO and