VERTRAULICH

Mein lieber Freund, Ich mцchte mich erstmals gerne vorstellen. Mein Name ist Herr Morato Ortega die persцnliche Investment Berater und Vermцgensverwalterin meines verstorbenen Mandanten, der ihre familienname tragt. Er war als privater Geschдftsmann im internationalen Bereich tдtig. Im Jahr

Re: [PATCH 1/1] staging: android: ashmem: convert range macros to inlines and clean-up

On Mon, Dec 05, 2016 at 08:01:35PM +, Guillaume Tucker wrote: > On 12/05/16 18:08, Greg Kroah-Hartman wrote: > > On Mon, Dec 05, 2016 at 05:34:15PM +, Guillaume Tucker wrote: > >> Convert ashmem_range related macros to inline functions to fix > >> checkpatch errors. Clean up the code in

Re: [PATCH 10/14] rtlwifi: Add BTC_TRACE_STRING to new btcoex

On Mon, Dec 05, 2016 at 04:34:08PM -0600, Larry Finger wrote: > On 12/05/2016 03:34 PM, Dan Carpenter wrote: > > On Thu, Dec 01, 2016 at 07:48:29PM -0600, Larry Finger wrote: > > > --- > > > wireless-drivers-next.orig/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.h > > > +++ > > >

RE: [PATCH] pci-hyperv: use kmalloc to allocate hypercall params buffer

> -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Monday, December 5, 2016 8:53 AM > To: Long Li > Cc: KY Srinivasan ; Haiyang Zhang > ; Bjorn Helgaas ; >

Re: [PATCH 12/19] staging: iio: isl29028: fix comparison between signed and unsigned integers

On Mon, Dec 05, 2016 at 11:53:39PM +0300, Dan Carpenter wrote: > On Sat, Dec 03, 2016 at 09:19:36PM -0500, Brian Masney wrote: > > Fixed warning found by make W=2 to reduce the amount of build noise: > > > > warning: comparison between signed and unsigned integer expressions > > [-Wsign-compare]

RE: [PATCH] pci-hyperv: use kmalloc to allocate hypercall params buffer

> -Original Message- > From: KY Srinivasan > Sent: Monday, December 5, 2016 1:23 PM > To: Cathy Avery ; Bjorn Helgaas > ; Long Li > Cc: de...@linuxdriverproject.org > Subject: RE: [PATCH] pci-hyperv: use kmalloc to allocate

Re: [lustre-devel] [bug report] staging: add Lustre file system client support

On Nov 23, 2016, at 7:29 AM, Dan Carpenter wrote: > Hi Lustre Devs, > > The patch d7e09d0397e8: "staging: add Lustre file system client > support" from May 2, 2013, leads to the following static checker > warning: > > drivers/staging/lustre/lnet/selftest/console.c:1336 lstcon_test_add()

Re: [PATCH 04/22] staging: lustre: osc: handle osc eviction correctly

On Dec 5, 2016, at 3:55 PM, Dan Carpenter wrote: > On Fri, Dec 02, 2016 at 07:53:11PM -0500, James Simmons wrote: >> @@ -3183,8 +3182,10 @@ static int discard_cb(const struct lu_env *env, >> struct cl_io *io, >> /* page is top page. */ >> info->oti_next_index = osc_index(ops) + 1; >>

Re: [lustre-devel] [PATCH] staging: lustre: Fix a spatch warning due to an assignment from kernel to user space

On Dec 2, 2016, at 12:33 PM, Quentin Lambert wrote: > lnet_ipif_enumerate was assigning a pointer from kernel space to user > space. This patch uses copy_to_user to properly do that assignment. I guess it's a false positive? While lnet_sock_ioctl()->kernel_sock_unlocked_ioctl() does call into

Re: [PATCH] staging: lustre: Fix function declaration/definition mismatch

On Dec 4, 2016, at 10:06 PM, wrote: > From: Sandeep Jain > > Fixes following Sparse errors. > lprocfs_status.c:1568:5: error: symbol 'lprocfs_wr_root_squash' > redeclared with different type... >

Re: [PATCH] staging: lustre: mgc: make llog_process_lock static

On Dec 4, 2016, at 9:21 PM, wrote: > From: Sandeep Jain > > Fix following sparse warning. > mgc_request.c:376:1: > warning: symbol 'llog_process_lock' was not declared. Should it be static? > >

Re: [PATCH 1/1] staging: lustre: lnet: fix improper return value

On Dec 3, 2016, at 7:52 AM, Pan Bian wrote: > From: Pan Bian > > At the end of function lstcon_group_info(), "return 0" seems improper. > It may be better to return the value of rc. > > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188811 > > Signed-off-by: Pan

Re: [PATCH 10/14] rtlwifi: Add BTC_TRACE_STRING to new btcoex

On 12/05/2016 03:34 PM, Dan Carpenter wrote: On Thu, Dec 01, 2016 at 07:48:29PM -0600, Larry Finger wrote: --- wireless-drivers-next.orig/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.h +++ wireless-drivers-next/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.h @@

[PATCH v4 net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver

Add driver for Alacritech gigabit ethernet cards with SLIC (session-layer interface control) technology. The driver provides basic support without SLIC for the following devices: - Mojave cards (single port PCI Gigabit) both copper and fiber - Oasis cards (single and dual port PCI-x Gigabit)

[PATCH v4 net-next 2/2] MAINTAINERS: add entry for slicoss ethernet driver

Add myself as maintainer for the slicoss ethernet driver. Signed-off-by: Lino Sanfilippo --- MAINTAINERS | 5 + 1 file changed, 5 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 6781a3f..bb9af28 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -562,6 +562,11

Gigabit ethernet driver for Alacritechs SLIC devices (v4)

Hi, this is the forth version of the slicoss gigabit ethernet driver (which is a rework of the driver from Alacritech which can currently be found under drivers/staging/slicoss). The driver is supposed to support Mojave, Oasis and Kalahari cards, for both copper and fiber. If this code is

Re: [lustre-devel] [PATCH 3/6] staging: lustre: obdclass: Create a header for obdo related functions

Sorry, I was unclear. I have no problem with white space changes on their own or when they are on the same line as something else you're changing. What I meant is that when you're just moving functions around then don't mix unrelated white space changes into that patch. I have automated scripts

Re: [lustre-devel] [PATCH 3/6] staging: lustre: obdclass: Create a header for obdo related functions

> On Dec 5, 2016, at 13:50, Dan Carpenter wrote: > > On Fri, Dec 02, 2016 at 02:40:47PM -0500, James Simmons wrote: >> -__u32 local_flags = 0; >> +u32 local_flags = 0; > >> -if (local_flags != 0) { >> +if (local_flags) { > > Please avoid these

Re: [PATCH 1/7] rtlwifi: btcoexist: Update routines for RTL8192EE

On Mon, Dec 05, 2016 at 11:17:28AM -0600, Larry Finger wrote: > On 12/05/2016 05:38 AM, Dan Carpenter wrote: > >On Sat, Dec 03, 2016 at 11:32:01AM -0600, Larry Finger wrote: > >>From: Ping-Ke Shih > >> > >>The btcoexist routines for the RTL8192EE have been extensively

Re: [PATCH 10/14] rtlwifi: Add BTC_TRACE_STRING to new btcoex

On Thu, Dec 01, 2016 at 07:48:29PM -0600, Larry Finger wrote: > --- > wireless-drivers-next.orig/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.h > +++ > wireless-drivers-next/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.h > @@ -27,6 +27,29 @@ > > #include

RE: [PATCH] pci-hyperv: use kmalloc to allocate hypercall params buffer

> -Original Message- > From: devel [mailto:driverdev-devel-boun...@linuxdriverproject.org] On > Behalf Of Cathy Avery > Sent: Monday, December 5, 2016 4:54 AM > To: Bjorn Helgaas ; Long Li > Cc: de...@linuxdriverproject.org > Subject: Re:

Re: [PATCH 05/14] rtlwifi: Add TX report and disable key will wait until report acked.

On Thu, Dec 01, 2016 at 07:48:24PM -0600, Larry Finger wrote: > diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/trx.c > b/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/trx.c > index 2d48ccd..0f9d9f0 100644 > --- a/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/trx.c > +++

Re: [PATCH 05/22] staging: lustre: lmv: remove nlink check in lmv_revalidate_slaves

On Fri, Dec 02, 2016 at 07:53:12PM -0500, James Simmons wrote: > From: wang di > > Remove nlink < 2 check in lmv_revalidate_slaves, because > after nlink reaches to LDISKFS_LINK_MAX (65000), the inode > nlink will be set to 1. > I don't understand how this changelog matches

Re: [PATCH 04/22] staging: lustre: osc: handle osc eviction correctly

On Fri, Dec 02, 2016 at 07:53:11PM -0500, James Simmons wrote: > @@ -3183,8 +3182,10 @@ static int discard_cb(const struct lu_env *env, struct > cl_io *io, > /* page is top page. */ > info->oti_next_index = osc_index(ops) + 1; > if (cl_page_own(env, io, page) == 0) { > -

Re: [PATCH v3 20/28] staging: iio: tsl2583: don't assume an unsigned int is 32 bits

On Thu, Nov 10, 2016 at 04:25:56AM -0500, Brian Masney wrote: > in_illuminance_lux_table_store assumes that an unsigned int is 32 bits. It's a totally safe assumption. The only problem is that it's less readable than sizeof(). regards, dan carpenter

Re: [PATCH 5/6] staging: lustre: headers: Move functions out of lustre_idl.h

On Fri, Dec 02, 2016 at 02:40:49PM -0500, James Simmons wrote: > -/* If LDLM_ENQUEUE, 1 slot is already occupied, 1 is available. > - * Otherwise, 2 are available. > - */ > -#define ldlm_request_bufsize(count, type)\ > -({

Re: [PATCH 12/19] staging: iio: isl29028: fix comparison between signed and unsigned integers

On Sat, Dec 03, 2016 at 09:19:36PM -0500, Brian Masney wrote: > Fixed warning found by make W=2 to reduce the amount of build noise: > > warning: comparison between signed and unsigned integer expressions > [-Wsign-compare] Ugh... Please don't do work arounds for nonsense warnings. W=2 is so

Re: [PATCH v3 4/9] bus: fsl-mc: dpio: add frame descriptor and scatter/gather APIs

On Fri, Dec 02, 2016 at 12:12:14PM +, Laurentiu Tudor wrote: > > +static inline bool dpaa2_sg_is_final(const struct dpaa2_sg_entry *sg) > > +{ > > + return !!(le16_to_cpu(sg->format_offset) >> SG_FINAL_FLAG_SHIFT); > > In other places in this file we don't use the '!!' to convert to bool.

Re: [PATCH] staging: lustre: Fix a spatch warning due to an assignment from kernel to user space

On Fri, Dec 02, 2016 at 06:33:32PM +0100, Quentin Lambert wrote: > lnet_ipif_enumerate was assigning a pointer from kernel space to user > space. This patch uses copy_to_user to properly do that assignment. Put the exact warning message here. > > Signed-off-by: Quentin Lambert

Re: [PATCH] staging: dgnc: Fix lines longer than 80 characters

On Fri, Dec 02, 2016 at 08:13:49PM +0100, Fernando Apesteguia wrote: > For the first lines of the patch, I opted to create a small function > instead of breaking the the line in a weird way. These first ones are the nice. > @@ -2511,13 +2516,15 @@ static int dgnc_tty_ioctl(struct tty_struct

Re: [PATCH 02/14] rtlwifi: Fix programing CAM content sequence.

On Thu, Dec 01, 2016 at 07:48:21PM -0600, Larry Finger wrote: > From: Ping-Ke Shih > > There is a potential race condition when the control byte of a CAM > entry is written first. Write in reverse order to correct the condition. > > Signed-off-by: Ping-Ke Shih

Re: [PATCH 3/6] staging: lustre: obdclass: Create a header for obdo related functions

On Fri, Dec 02, 2016 at 02:40:47PM -0500, James Simmons wrote: > - __u32 local_flags = 0; > + u32 local_flags = 0; > - if (local_flags != 0) { > + if (local_flags) { Please avoid these unrelated white space changes. regards, dan carpenter

Re: [PATCH 1/1] staging: android: ashmem: convert range macros to inlines and clean-up

On 12/05/16 18:08, Greg Kroah-Hartman wrote: > On Mon, Dec 05, 2016 at 05:34:15PM +, Guillaume Tucker wrote: >> Convert ashmem_range related macros to inline functions to fix >> checkpatch errors. Clean up the code in related existing inline >> functions. > > How about breaking this up into

[PATCH v2 2/2] staging: android: ashmem: clean up range inline functions

Clean up the code in inline functions that deal with page and range addresses. Use bool instead of int for boolean return types and remove superfluous brackets. Signed-off-by: Guillaume Tucker --- drivers/staging/android/ashmem.c | 28 ++-- 1

[PATCH v2 1/2] staging: android: ashmem: convert range macros to inlines

Convert range_size and range_on_lru macros to inline functions to fix checkpatch check: CHECK: Macro argument reuse 'range' - possible side-effects? Signed-off-by: Guillaume Tucker --- drivers/staging/android/ashmem.c | 12 1 file changed, 8

[PATCH v2 0/2] staging: android: ashmem: convert range macros to inlines and clean-up

This is to fix some checkpatch.pl checks by converting macros to static inline functions and do a bit of clean-up in existing inline functions. I've run some Android unit tests on a HiKey board and made a small kernel-side test function to sanity check it. I realise this code is a bit stale so

Re: [PATCH 1/1] staging: android: ashmem: convert range macros to inlines and clean-up

On Mon, Dec 05, 2016 at 05:34:15PM +, Guillaume Tucker wrote: > Convert ashmem_range related macros to inline functions to fix > checkpatch errors. Clean up the code in related existing inline > functions. How about breaking this up into two different patches, one for the inlines, and one to

[PATCH 1/1] staging: android: ashmem: convert range macros to inlines and clean-up

Convert ashmem_range related macros to inline functions to fix checkpatch errors. Clean up the code in related existing inline functions. Signed-off-by: Guillaume Tucker --- drivers/staging/android/ashmem.c | 40 ++-- 1 file

[PATCH 0/1] staging: android: ashmem: convert range macros to inlines and clean-up

This is to fix some checkpatch.pl errors by converting macros to static inline functions and do a bit of clean-up in existing inline functions. I've run some Android unit tests on a HiKey board and made a small kernel-side test function to sanity check it. I realise this code is a bit stale so

Re: [PATCH] Staging: comedi: kcomedilib: Add module_init/exit function

On 05/12/16 16:57, Cheah Kok Cheong wrote: Add init/exit function to follow LKM semantics. Apparently this module can still load/unload without the init/exit function. Tested loading/unloading with and without this patch. Signed-off-by: Cheah Kok Cheong ---

Re: [PATCH 1/7] rtlwifi: btcoexist: Update routines for RTL8192EE

On 12/05/2016 05:38 AM, Dan Carpenter wrote: On Sat, Dec 03, 2016 at 11:32:01AM -0600, Larry Finger wrote: From: Ping-Ke Shih The btcoexist routines for the RTL8192EE have been extensively rewritten. This patch does a million things and is totally unreviewable. The

[PATCH] Staging: comedi: kcomedilib: Add module_init/exit function

Add init/exit function to follow LKM semantics. Apparently this module can still load/unload without the init/exit function. Tested loading/unloading with and without this patch. Signed-off-by: Cheah Kok Cheong --- drivers/staging/comedi/kcomedilib/kcomedilib_main.c | 12

Re: [PATCH] pci-hyperv: use kmalloc to allocate hypercall params buffer

On Tue, 8 Nov 2016 14:04:38 -0800 Long Li wrote: > + spin_lock_irqsave(>retarget_msi_interrupt_lock, flags); > + > + params = >retarget_msi_interrupt_params; > + memset(params, 0, sizeof(*params)); > + params->partition_id = HV_PARTITION_ID_SELF; >

RE: [PATCH 04/15] Drivers: hv: vmbus: Prevent sending data on a rescinded channel

> -Original Message- > From: Dan Carpenter [mailto:dan.carpen...@oracle.com] > Sent: Monday, December 5, 2016 2:01 AM > To: KY Srinivasan > Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; > de...@linuxdriverproject.org; o...@aepfle.de;

[PATCH 2/2] Staging: dgnc: dgnc_neo.c: Use usleep_range over udelay to improve coalescing processor wakeups

In most cases, usleep_range is better than udelay, as the precise wakeup from udelay is unnecessary. usleep_range gives a much better chance of coalescing processor wakeups. Signed-off-by: Shiva Kerdel --- drivers/staging/dgnc/dgnc_neo.c | 10 +- 1 file changed, 5

[PATCH 1/2] Staging: dgnc: dgnc_cls.c: Use usleep_range over udelay to improve coalescing processor wakeups

In most cases, usleep_range is better than udelay, as the precise wakeup from udelay is unnecessary. usleep_range gives a much better chance of coalescing processor wakeups. Signed-off-by: Shiva Kerdel --- drivers/staging/dgnc/dgnc_cls.c | 6 +++--- 1 file changed, 3

[PATCH v3] Staging: wlan-ng: hfa384x_usb.c Fixed too long code line warnings.

Fixed checkpatch warning "line over 80 characters" in wlan-ng/hfa384x_usb.c file. Signed-off-by: Yan Laijun --- Changes in v2: - Remove initialization of usbin on its decarlation. --- Changes in v3: - Move usbin's assignment to where it's used for the first time. ---

Re: [PATCH] pci-hyperv: use kmalloc to allocate hypercall params buffer

Hi, Is the double semicolon a typo? Thanks, Cathy diff --git a/drivers/pci/host/pci-hyperv.c b/drivers/pci/host/pci-hyperv.c index 763ff87..ca553df 100644 --- a/drivers/pci/host/pci-hyperv.c +++ b/drivers/pci/host/pci-hyperv.c @@ -378,6 +378,8 @@ struct hv_pcibus_device { struct

Re: [PATCH 1/7] rtlwifi: btcoexist: Update routines for RTL8192EE

On Sat, Dec 03, 2016 at 11:32:01AM -0600, Larry Finger wrote: > From: Ping-Ke Shih > > The btcoexist routines for the RTL8192EE have been extensively rewritten. > This patch does a million things and is totally unreviewable. The patch description doesn't say what patch

[patch] staging: lustre: cl_page: fix a typo in comments

We want to "sever" all the ways to get a new pointer to "pg". Signed-off-by: Dan Carpenter diff --git a/drivers/staging/lustre/lustre/obdclass/cl_page.c b/drivers/staging/lustre/lustre/obdclass/cl_page.c index bdc0aa5846ef..cd9a40ca4448 100644 ---

Re: [PATCH 04/15] Drivers: hv: vmbus: Prevent sending data on a rescinded channel

On Thu, Dec 01, 2016 at 09:28:41AM -0800, k...@exchange.microsoft.com wrote: > From: K. Y. Srinivasan > > After the channel is rescinded, the host does not read from the rescinded > channel. > Fail writes to a channel that has already been rescinded What are the user