Re: [PATCH] net-next: treewide use is_vlan_dev() helper function.

On Fri, 2017-02-03 at 22:26 -0600, Parav Pandit wrote: > This patch makes use of is_vlan_dev() function instead of flag > comparison which is exactly done by is_vlan_dev() helper function. Thanks. btw: after applying this patch, there is one left $ git grep -E -n "&\s*IFF_802_1Q_VLAN\b" --

Re: Staging: speakup - syle fix permissions to octal

(adding Julia Lawall) On Fri, 2017-02-03 at 20:44 -0800, Guenter Roeck wrote: > On Sat, Jan 28, 2017 at 07:05:09PM +1300, Derek Robson wrote: > > A style fix across whole driver. > > changed permissions to octal style, found using checkpatch > > > > Signed-off-by: Derek Robson

[PATCH v2] Drivers: staging: speakup: spk_priv.h - style fix

Changed function definition argument to have identifier name. found using checkpatch Signed-off-by: Derek Robson --- Version 1 had missing ; and so broke the build drivers/staging/speakup/spk_priv.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: Staging: speakup - syle fix permissions to octal

On Sat, Jan 28, 2017 at 07:05:09PM +1300, Derek Robson wrote: > A style fix across whole driver. > changed permissions to octal style, found using checkpatch > > Signed-off-by: Derek Robson FWIW, I think changes like this are best done using coccinelle. That ensures that the

[PATCH] staging: fbtft: fbtft-bus.c: Fix checkpatch error

Fix checkpatch error: ERROR: space prohibited before that close parenthesis ')' Signed-off-by: Youngdo Lee --- drivers/staging/fbtft/fbtft-bus.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging/fbtft/fbtft-bus.c

[PATCH] net-next: treewide use is_vlan_dev() helper function.

This patch makes use of is_vlan_dev() function instead of flag comparison which is exactly done by is_vlan_dev() helper function. Signed-off-by: Parav Pandit Reviewed-by: Daniel Jurgens --- drivers/infiniband/core/cma.c| 6

Re: Drivers: staging: speakup: spk_priv.h - style fix

On Sat, Feb 04, 2017 at 12:56:41PM +1300, Derek Robson wrote: > Changed function definition argument to have identifier name. > found using checkpatch > > Signed-off-by: Derek Robson > --- > drivers/staging/speakup/spk_priv.h | 4 ++-- > 1 file changed, 2 insertions(+), 2

Re: [PATCH] Drivers: staging: speakup: spk_priv.h - style fix

On Sat, 2017-02-04 at 16:31 +1300, Derek Robson wrote: > On Sat, Feb 04, 2017 at 10:41:20AM +0800, kbuild test robot wrote: > > Hi Derek, > > > > [auto build test ERROR on staging/staging-testing] > > [also build test ERROR on v4.10-rc6 next-20170203] > > [if y

Re: [PATCH] Drivers: staging: speakup: spk_priv.h - style fix

On Sat, Feb 04, 2017 at 10:41:20AM +0800, kbuild test robot wrote: > Hi Derek, > > [auto build test ERROR on staging/staging-testing] > [also build test ERROR on v4.10-rc6 next-20170203] > [if your patch is applied to the wrong git tree, please drop us a note to > help

Re: [PATCH] Drivers: staging: speakup: spk_priv.h - style fix

Hi Derek, [auto build test ERROR on staging/staging-testing] [also build test ERROR on v4.10-rc6 next-20170203] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Derek-Robson/Drivers-staging

Re: [PATCH] Drivers: staging: speakup: spk_priv.h - style fix

Hi Derek, [auto build test ERROR on staging/staging-testing] [also build test ERROR on v4.10-rc6 next-20170203] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Derek-Robson/Drivers-staging

Re: Is it time to move drivers/staging/netlogic/ out of staging?

On 02/03/2017 12:44 PM, Greg KH wrote: > On Fri, Feb 03, 2017 at 12:38:45PM -0800, Florian Fainelli wrote: >> On 02/03/2017 12:36 PM, Greg KH wrote: >>> On Fri, Feb 03, 2017 at 10:57:16AM -0800, Joe Perches wrote: On Fri, 2017-02-03 at 10:50 -0800, Florian Fainelli wrote: > (with JC's

[PATCH] Staging: iio: resolver: ad2s1210.c - style fix

Changed symbolic permissions to octal permissions. Found using checkpatch Signed-off-by: Derek Robson --- drivers/staging/iio/resolver/ad2s1210.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git

[PATCH] Drivers: staging: speakup: spk_priv.h - style fix

Changed function definition argument to have identifier name. found using checkpatch Signed-off-by: Derek Robson --- drivers/staging/speakup/spk_priv.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/speakup/spk_priv.h

Re: [PATCH] Fixed coding style issues of xmit_linux.c

On Fri, Feb 03, 2017 at 07:49:26PM +0530, Abhijit Naik wrote: > This patch will increase readability of xmit_linux.c file. > > Removed following type of coding style warnings generated for xmit_linux.c, > 1. Braces {} are not necessary for single statement blocks > 2. Block comments

Re: Is it time to move drivers/staging/netlogic/ out of staging?

On 02/03/2017 12:36 PM, Greg KH wrote: > On Fri, Feb 03, 2017 at 10:57:16AM -0800, Joe Perches wrote: >> On Fri, 2017-02-03 at 10:50 -0800, Florian Fainelli wrote: >>> (with JC's other email) >> >> And now with Greg's proper email too >> >>> On 02/03/2017 10:47 AM, Joe Perches wrote: 64 bit

Re: Is it time to move drivers/staging/netlogic/ out of staging?

On Fri, Feb 03, 2017 at 12:38:45PM -0800, Florian Fainelli wrote: > On 02/03/2017 12:36 PM, Greg KH wrote: > > On Fri, Feb 03, 2017 at 10:57:16AM -0800, Joe Perches wrote: > >> On Fri, 2017-02-03 at 10:50 -0800, Florian Fainelli wrote: > >>> (with JC's other email) > >> > >> And now with Greg's

Re: Is it time to move drivers/staging/netlogic/ out of staging?

On Fri, Feb 03, 2017 at 10:57:16AM -0800, Joe Perches wrote: > On Fri, 2017-02-03 at 10:50 -0800, Florian Fainelli wrote: > > (with JC's other email) > > And now with Greg's proper email too > > > On 02/03/2017 10:47 AM, Joe Perches wrote: > > > 64 bit stats isn't implemented, but is that really

Re: [RFC] Resolving "false positive" error message from checkpatch.pl

On Fri, 2017-02-03 at 13:10 +0100, Slawomir Stepien wrote: > On Feb 03, 2017 11:27, Greg KH wrote: > > On Fri, Feb 03, 2017 at 11:11:35AM +0100, Slawomir Stepien wrote: > > > Hi all > > > > > > There is a "false positive" error reported by checkpatch.pl: > > > > > > ERROR: Use 4 digit octal

Re: Is it time to move drivers/staging/netlogic/ out of staging?

On Fri, 2017-02-03 at 10:50 -0800, Florian Fainelli wrote: > (with JC's other email) And now with Greg's proper email too > On 02/03/2017 10:47 AM, Joe Perches wrote: > > 64 bit stats isn't implemented, but is that really necessary? > > Anything else? > > Joe, do you have such hardware that you

Is it time to move drivers/staging/netlogic/ out of staging?

64 bit stats isn't implemented, but is that really necessary? Anything else? It seems like the driver doesn't need to be there anymore. ___ devel mailing list de...@linuxdriverproject.org

Re: [PATCH 3/6] staging: bcm2835-v4l2: Add a build system for the module.

Em Fri, 27 Jan 2017 13:55:00 -0800 Eric Anholt escreveu: > This is derived from the downstream tree's build system, but with just > a single Kconfig option. > > For now the driver only builds on 32-bit arm -- the aarch64 build > breaks due to the driver using arm-specific cache

Re: Is it time to move drivers/staging/netlogic/ out of staging?

(with JC's other email) On 02/03/2017 10:47 AM, Joe Perches wrote: > 64 bit stats isn't implemented, but is that really necessary? > Anything else? Joe, do you have such hardware that you are interested in getting supported, or was that just to reduce the amount of drivers in staging? I am

[PATCH] staging: bcm2835-audio: remove unused macro

The VC_AUDIO_MAX_MSG_LEN macro is not used anywhere and has coding style violations. Signed-off-by: Hendrik v. Raven --- drivers/staging/bcm2835-audio/vc_vchi_audioserv_defs.h | 3 --- 1 file changed, 3 deletions(-) diff --git

Re: [PATCH v3 00/24] i.MX Media Driver

On 02/02/2017 02:29 PM, Russell King - ARM Linux wrote: On Thu, Feb 02, 2017 at 11:12:41AM -0800, Steve Longerbeam wrote: Here is the current .queue_setup() op in imx-media-capture.c: static int capture_queue_setup(struct vb2_queue *vq, unsigned int *nbuffers,

Re: [PATCH] staging: bcm2835-audio: fix spacing of macro

On Fri, 2017-02-03 at 17:17 +0100, Hendrik v. Raven wrote: > VC_AUDIO_MAX_MSG_LEN This macro seems unused and might as well be removed. ___ devel mailing list de...@linuxdriverproject.org

Re: [PATCH v3 00/24] i.MX Media Driver

On 02/03/2017 06:41 AM, Laurent Pinchart wrote: Hello, On Wednesday 01 Feb 2017 16:19:27 Steve Longerbeam wrote: On 02/01/2017 01:30 AM, Philipp Zabel wrote: media-ctl propagates the output pad format to all remote subdevices' input pads for all enabled links:

[PATCH] Staging: bcm2835-audio: removed spaces around parenthesis

Removed unnecessary spaces around parenthesis as reported by checkpatch.pl Signed-off-by: Michael Rupprecht --- drivers/staging/bcm2835-audio/bcm2835-vchiq.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git

[PATCH] staging: bcm2835-audio: fix spacing of macro

removes the unwanted spaces inside of sizeof( ), removing a complaint of checkpatch.pl. Also removes the second space behind the macro name. Signed-off-by: Hendrik v. Raven --- drivers/staging/bcm2835-audio/vc_vchi_audioserv_defs.h | 2 +- 1 file changed, 1 insertion(+),

Re: [PATCH 3/9] staging: fsl-mc: add device release callback

On 02/03/2017 02:02 AM, Stuart Yoder wrote: > >> -Original Message- >> From: upstream-release-boun...@linux.freescale.net [mailto:upstream-release- >> boun...@linux.freescale.net] On Behalf Of laurentiu.tu...@nxp.com >> Sent: Wednesday, February 01, 2017 5:43 AM >> To:

[PATCH] staging:most/hdm-i2c: Replace symbolic permissions with octal permissions

WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. This warning was detected by checkpatch.pl for hdm_i2c.c. Signed-off-by: Zhengyi Shen --- drivers/staging/most/hdm-i2c/hdm_i2c.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH v3 00/24] i.MX Media Driver

Hello, On Wednesday 01 Feb 2017 16:19:27 Steve Longerbeam wrote: > On 02/01/2017 01:30 AM, Philipp Zabel wrote: > > On Tue, 2017-01-31 at 17:26 -0800, Steve Longerbeam wrote: > > [...] > > > >>> # Set pad formats > >>> media-ctl --set-v4l2 "'tc358743 1-000f':0[fmt:UYVY/1920x1080]" > >>>

[PATCH] Fixed coding style issues of xmit_linux.c

This patch will increase readability of xmit_linux.c file. Removed following type of coding style warnings generated for xmit_linux.c, 1. Braces {} are not necessary for single statement blocks 2. Block comments use a trailing */ on a separate line Signed-off-by: Abhijit Naik

[PATCH] staging: octeon: Fix line over 80 characters

From: Kamal Heib This patch fix the line over 80 characters warning that was detected using checkpatch.pl script. Fixes: 6fe5efa1415c ('staging: octeon: Convert create_singlethread_workqueue()') Cc: Bhaktipriya Shridhar Signed-off-by: Kamal Heib

Re: [RFC] Resolving "false positive" error message from checkpatch.pl

On Feb 03, 2017 04:39, Joe Perches wrote: > On Fri, 2017-02-03 at 13:10 +0100, Slawomir Stepien wrote: > > On Feb 03, 2017 11:27, Greg KH wrote: > > > On Fri, Feb 03, 2017 at 11:11:35AM +0100, Slawomir Stepien wrote: > > > > Hi all > > > > > > > > There is a "false positive" error reported by

Re: [RFC] Resolving "false positive" error message from checkpatch.pl

On Fri, Feb 03, 2017 at 01:10:20PM +0100, Slawomir Stepien wrote: > On Feb 03, 2017 11:27, Greg KH wrote: > > On Fri, Feb 03, 2017 at 11:11:35AM +0100, Slawomir Stepien wrote: > > > Hi all > > > > > > There is a "false positive" error reported by checkpatch.pl: > > > > > > ERROR: Use 4 digit

Re: [RFC] Resolving "false positive" error message from checkpatch.pl

On Feb 03, 2017 11:27, Greg KH wrote: > On Fri, Feb 03, 2017 at 11:11:35AM +0100, Slawomir Stepien wrote: > > Hi all > > > > There is a "false positive" error reported by checkpatch.pl: > > > > ERROR: Use 4 digit octal (0777) not decimal permissions > > #272: FILE:

Re: [PATCH 4/9] staging: fsl-mc: don't use devres api for refcounted objects

On 02/03/2017 02:02 AM, Stuart Yoder wrote: > > >> -Original Message- >> From: laurentiu.tu...@nxp.com [mailto:laurentiu.tu...@nxp.com] >> Sent: Wednesday, February 01, 2017 5:43 AM >> To: gre...@linuxfoundation.org >> Cc: de...@driverdev.osuosl.org; linux-ker...@vger.kernel.org;

Re: [PATCH 00/60] staging: lustre: batches of fixes for lustre client

On Sat, Jan 28, 2017 at 07:04:28PM -0500, James Simmons wrote: > Batch of missing fixes for lustre for the upstream client. I've applied most of these, please fix up the rest, rebase, and resend. thanks, greg k-h ___ devel mailing list

Re: [PATCH 10/60] staging: lustre: obdclass: add more info to sysfs version string

On Sat, Jan 28, 2017 at 07:04:38PM -0500, James Simmons wrote: > From: Andreas Dilger > > Update the sysfs "version" file to print "lustre: " with > the version number. > > Signed-off-by: Andreas Dilger > Intel-bug-id:

Re: [PATCH 2/9] staging: fsl-mc: fix device ref counting

On Fri, Feb 03, 2017 at 10:17:53AM +, Laurentiu Tudor wrote: > Hi Greg, > > Thanks for having a look. Comment below. > > On 02/03/2017 11:56 AM, Greg KH wrote: > > On Wed, Feb 01, 2017 at 05:43:22AM -0600, laurentiu.tu...@nxp.com wrote: > >> From: Laurentiu Tudor >

Re: [RFC] Resolving "false positive" error message from checkpatch.pl

On Fri, Feb 03, 2017 at 11:11:35AM +0100, Slawomir Stepien wrote: > Hi all > > There is a "false positive" error reported by checkpatch.pl: > > ERROR: Use 4 digit octal (0777) not decimal permissions > #272: FILE: drivers/staging/iio/meter/ade7759.c:272: > +static IIO_DEV_ATTR_CH_OFF(1, S_IWUSR

[RFC] Resolving "false positive" error message from checkpatch.pl

Hi all There is a "false positive" error reported by checkpatch.pl: ERROR: Use 4 digit octal (0777) not decimal permissions #272: FILE: drivers/staging/iio/meter/ade7759.c:272: +static IIO_DEV_ATTR_CH_OFF(1, S_IWUSR | S_IRUGO, + ade7759_read_8bit, +

Re: [PATCH 2/9] staging: fsl-mc: fix device ref counting

Hi Greg, Thanks for having a look. Comment below. On 02/03/2017 11:56 AM, Greg KH wrote: > On Wed, Feb 01, 2017 at 05:43:22AM -0600, laurentiu.tu...@nxp.com wrote: >> From: Laurentiu Tudor >> >> Drop unneeded get_device() call at device creation >> and, as per

Re: [PATCH] staging:bcm2048 : Add parentheses around variable x

On Sat, Dec 03, 2016 at 03:14:26PM +0530, Tabrez khan wrote: > Add parentheses around variable x for the readability purpose. > It's not really about readability... regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org

Re: [PATCH] staging:bcm2048 : Add parentheses around variable x

Em Sat, 3 Dec 2016 15:14:26 +0530 Tabrez khan escreveu: > Add parentheses around variable x for the readability purpose. > > This warning was found using checkpatch.pl. > > Signed-off-by: Tabrez khan > --- >

Re: [PATCH 2/9] staging: fsl-mc: fix device ref counting

On Wed, Feb 01, 2017 at 05:43:22AM -0600, laurentiu.tu...@nxp.com wrote: > From: Laurentiu Tudor > > Drop unneeded get_device() call at device creation > and, as per documentation, drop reference count > after using device_find_child() return. > > Signed-off-by:

Re: [PATCH] staging: gdm724x: fix sparse warnings in file gdm_lte.c

On Tue, Jan 31, 2017 at 07:37:19PM +0100, Javier Rodriguez wrote: > drivers/staging/gdm724x/gdm_lte.c:201:33: warning: incorrect type in > assignment (different base types) > drivers/staging/gdm724x/gdm_lte.c:201:33:expected unsigned int [unsigned] > [addressable] [usertype] ph_len >

Re: [PATCH v2] staging: wlan-ng: This patch fixes the checkpatch.pl warning:

On Tue, Jan 31, 2017 at 09:20:15AM -0500, Maksymilian Piechota wrote: > Fix checkpatch.pl warning: Your subject is odd, it leaves something to the imagination :( > > WARNING: Statements should start on a tabstop > > V2: whole if statement cleared up Put this below the --- line. v3? thanks,

Re: [PATCH] staging/emxx_udc: Fix styling issues

On Thu, Feb 02, 2017 at 08:56:54PM +0800, Zhengyi Shen wrote: > Fix line over 80 characters. > Statements longer than 80 columns were broken into sensible chunks. > Descendants in four different palces were in the same uniform style. > > Signed-off-by: Zhengyi Shen > --- >

Re: [PATCH v4] staging: rtl8192e: Aligning the * on each line in block comments

On Fri, Feb 03, 2017 at 10:56:12AM +0530, Arushi wrote: > This patch fixes the issue by aligning the * on each line in block comments. > [Patch v1] is rejected as the changes done is not following the linux > coding style and [Patch v2] is rejected because forgot to mention the > cause of