Re: [PATCH] staging: rtl8192u: ieee80211: Fix space required after }.

2017-04-05 Thread Joe Perches
On Wed, 2017-04-05 at 21:23 +0200, Valerio Genovese wrote: > This was reported by checkpatch.pl: > ERROR: space required after that close brace '}' > > Signed-off-by: Valerio Genovese > --- > drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h | 2 +- > 1 file changed, 1

[PATCH] format-security: move static strings to const

2017-04-05 Thread Kees Cook
While examining output from trial builds with -Wformat-security enabled, many strings were found that should be defined as "const", or as a char array instead of char pointer. This makes some static analysis easier, by producing fewer false positives. As these are all trivial changes, it seemed

[PATCH] staging: rtl8192u: ieee80211: Fix space required after }.

2017-04-05 Thread Valerio Genovese
This was reported by checkpatch.pl: ERROR: space required after that close brace '}' Signed-off-by: Valerio Genovese --- drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v3 2/2] scsi: storvsc: Add support for FC rport.

2017-04-05 Thread Cathy Avery
Included in the current storvsc driver for Hyper-V is the ability to access luns on an FC fabric via a virtualized fiber channel adapter exposed by the Hyper-V host. The driver also attaches to the FC transport to allow host and port names to be published under /sys/class/fc_host/hostX. Current

[PATCH v3 1/2] scsi: scsi_transport_fc: Add dummy initiator role to rport

2017-04-05 Thread Cathy Avery
This patch allows scsi drivers that expose virturalized fibre channel devices but that do not expose rports to successfully rescan the scsi bus via echo "- - -" > /sys/class/scsi_host/hostX/scan. Drivers can create a pseudo rport and indicate FC_PORT_ROLE_FCP_DUMMY_INITIATOR as the rport's role in

[PATCH v3 0/2] scsi: storvsc: Add support for FC rport

2017-04-05 Thread Cathy Avery
The updated patch set provides a way for drivers ( specifically storvsc in this case ) that expose virturalized fc devices but that do not expose rports to be manually scanned. This is done via creating a pseudo rport in storvsc and a corresponding dummy initiator rport role in the fc transport.

Re: [PATCH v6 17/39] platform: add video-multiplexer subdevice driver

2017-04-05 Thread Pavel Machek
On Wed 2017-04-05 13:58:39, Lucas Stach wrote: > Am Mittwoch, den 05.04.2017, 13:18 +0200 schrieb Pavel Machek: > > Hi! > > > > > + * video stream multiplexer controlled via gpio or syscon > > > + * > > > + * Copyright (C) 2013 Pengutronix, Sascha Hauer > > > + * Copyright

Re: [RFC] [media] imx: assume MEDIA_ENT_F_ATV_DECODER entities output video on pad 1

2017-04-05 Thread Mauro Carvalho Chehab
Em Wed, 5 Apr 2017 13:02:52 -0400 Devin Heitmueller escreveu: > > I remember I looked on this when I wrote the driver, but I was > > unable to find a way for em28xx to parse (or forward) such > > data packets. > > I'm pretty sure it's possible, but I haven't

Re: [RFC] [media] imx: assume MEDIA_ENT_F_ATV_DECODER entities output video on pad 1

2017-04-05 Thread Devin Heitmueller
>> For what it's worth, I doubt most of the em28xx designs have the >> tvp5150 interrupt request line connected in any way. > > True. But, on embedded hardware, such line may be connected into the > SoC. Actually, from the IGEPv3 expansion diagram: > > >

[PATCH 29/38] Annotate hardware config module parameters in drivers/staging/speakup/

2017-04-05 Thread David Howells
When the kernel is running in secure boot mode, we lock down the kernel to prevent userspace from modifying the running kernel image. Whilst this includes prohibiting access to things like /dev/mem, it must also prevent access by means of configuring driver modules in such a way as to cause a

[PATCH 30/38] Annotate hardware config module parameters in drivers/staging/vme/

2017-04-05 Thread David Howells
When the kernel is running in secure boot mode, we lock down the kernel to prevent userspace from modifying the running kernel image. Whilst this includes prohibiting access to things like /dev/mem, it must also prevent access by means of configuring driver modules in such a way as to cause a

[PATCH 28/38] Annotate hardware config module parameters in drivers/staging/media/

2017-04-05 Thread David Howells
When the kernel is running in secure boot mode, we lock down the kernel to prevent userspace from modifying the running kernel image. Whilst this includes prohibiting access to things like /dev/mem, it must also prevent access by means of configuring driver modules in such a way as to cause a

Re: [RFC] [media] imx: assume MEDIA_ENT_F_ATV_DECODER entities output video on pad 1

2017-04-05 Thread Mauro Carvalho Chehab
Em Wed, 5 Apr 2017 11:39:06 -0400 Devin Heitmueller escreveu: > > Currently, the driver doesn't support (2), because, at the time > > I wrote the driver, I didn't find a way to read the interrupts generated > > by tvp5150 at em28xx[1], due to the lack of em28xx

Re: [RFC] [media] imx: assume MEDIA_ENT_F_ATV_DECODER entities output video on pad 1

2017-04-05 Thread Devin Heitmueller
> Currently, the driver doesn't support (2), because, at the time > I wrote the driver, I didn't find a way to read the interrupts generated > by tvp5150 at em28xx[1], due to the lack of em28xx documentation, > but adding support for it shoudn't be hard. I may eventually do it > when I have some

Re: [RFC] [media] imx: assume MEDIA_ENT_F_ATV_DECODER entities output video on pad 1

2017-04-05 Thread Mauro Carvalho Chehab
Em Wed, 05 Apr 2017 11:34:19 +0200 Philipp Zabel escreveu: > On Wed, 2017-04-05 at 09:21 +0100, Russell King - ARM Linux wrote: > [...] > > > Actually what was I thinking, the TVP5150 is already an example of > > > such a device. > > > > > > All of this could be solved

Re: [RFC] [media] imx: assume MEDIA_ENT_F_ATV_DECODER entities output video on pad 1

2017-04-05 Thread Javier Martinez Canillas
Hello Philipp, On Wed, Apr 5, 2017 at 5:34 AM, Philipp Zabel wrote: > On Wed, 2017-04-05 at 09:21 +0100, Russell King - ARM Linux wrote: [snip] > I think the output part is accurate, as the audio pad is an artifact of > an unrelated change. I'm not so sure about the VBI

RE: [PATCH] drivers/staging/lustre: Coding-guideline: Missing a blank line after declarations

2017-04-05 Thread Hammond, John
> On Tue, Apr 04, 2017 at 02:45:26PM +0530, Pushkar Jambhlekar wrote: > > diff --git a/drivers/staging/lustre/lustre/obdclass/cl_page.c > > b/drivers/staging/lustre/lustre/obdclass/cl_page.c > > index cd9a40c..71fcc4c 100644 > > --- a/drivers/staging/lustre/lustre/obdclass/cl_page.c > > +++

[PATCH v2 21/21] docs-rst: fix usb cross-references

2017-04-05 Thread Mauro Carvalho Chehab
As some USB documentation files got moved, adjust their cross-references to their new place. Signed-off-by: Mauro Carvalho Chehab --- Documentation/ABI/stable/sysfs-bus-usb| 2 +- Documentation/driver-api/usb/URB.rst | 2 ++

[PATCH v2] Staging: lustre cleanup macros in libcfs_private.h

2017-04-05 Thread Craig Inches
This resolves a checkpatch warning that "Single statement macros should not use a do {} while (0) loop" by removing the loop and adjusting line length accordingly. Signed-off-by: Craig Inches --- Changes in v2: - Kept statements together - Kept operator on previous

[PATCH] staging: fsl-mc/dpio: Fix early writing of valid bit

2017-04-05 Thread Ioana Radulescu
Commands written to the QMan software portals have a valid bit in the "verb" field of the command that, when set with the right value, notifies the hardware that the command is fully written and ready to be processed. The "verb" field should be the last one to be written in the swp command

RE: [PATCH] unisys: visornic: Replace symbolic perms with octal

2017-04-05 Thread Kershner, David A
> -Original Message- > From: Thomas Jespersen [mailto:laumann.tho...@gmail.com] > Sent: Tuesday, April 4, 2017 3:15 PM > To: Kershner, David A > Cc: gre...@linuxfoundation.org; Sell, Timothy C > ; Binder, David Anthony >

Re: [PATCH v6 17/39] platform: add video-multiplexer subdevice driver

2017-04-05 Thread Lucas Stach
Am Mittwoch, den 05.04.2017, 13:18 +0200 schrieb Pavel Machek: > Hi! > > > + * video stream multiplexer controlled via gpio or syscon > > + * > > + * Copyright (C) 2013 Pengutronix, Sascha Hauer > > + * Copyright (C) 2016 Pengutronix, Philipp Zabel

Re: [PATCH 03/24] staging: ks7010: add BUG_ON() to catch programmer error

2017-04-05 Thread Tobin C. Harding
On Wed, Apr 05, 2017 at 11:59:31AM +0300, Dan Carpenter wrote: > On Tue, Apr 04, 2017 at 09:59:30PM +1000, Tobin C. Harding wrote: > > On Tue, Apr 04, 2017 at 01:21:33PM +0300, Dan Carpenter wrote: > > > On Sun, Apr 02, 2017 at 10:18:09AM +1000, Tobin C. Harding wrote: > > > > Constant is used to

Re: [PATCH v6 19/39] media: Add i.MX media core driver

2017-04-05 Thread Pavel Machek
Hi! > +References > +-- > + > +[1] "i.MX 6Dual/6Quad Applications Processor Reference Manual" > +[2] "i.MX 6Solo/6DualLite Applications Processor Reference Manual" [2] is not present in the text above. [1] is there many times. What is purpose of this section?

Re: [PATCH v6 19/39] media: Add i.MX media core driver

2017-04-05 Thread Pavel Machek
Hi! > +https://boundarydevices.com/products/nit6x_5mp I'd use /product/ in url, as it redirects there. > +https://boundarydevices.com/product/nit6x_5mp_mipi ..and for consistency. > +The following example configures a direct conversion pipeline to capture > +from the OV5640, transmitting on

Re: [PATCH v6 17/39] platform: add video-multiplexer subdevice driver

2017-04-05 Thread Pavel Machek
Hi! > + * video stream multiplexer controlled via gpio or syscon > + * > + * Copyright (C) 2013 Pengutronix, Sascha Hauer > + * Copyright (C) 2016 Pengutronix, Philipp Zabel This is actually quite interesting. Same email address for two people...

Re: [PATCH] Staging: lustre cleanup macros in libcfs_private.h

2017-04-05 Thread Dilger, Andreas
On Apr 3, 2017, at 15:13, Craig Inches wrote: > > This resolves a checkpatch warning that "Single statement macros should > not use a do {} while (0) loop" by removing the loop and adjusting line > length accordingly. > > Signed-off-by: Craig Inches

Re: [lustre-devel] [PATCH] drivers/staging/lustre: Coding-guideline: Missing a blank line after declarations

2017-04-05 Thread Dilger, Andreas
On Apr 4, 2017, at 03:38, Dan Carpenter wrote: > > On Tue, Apr 04, 2017 at 02:45:26PM +0530, Pushkar Jambhlekar wrote: >> diff --git a/drivers/staging/lustre/lustre/obdclass/cl_page.c >> b/drivers/staging/lustre/lustre/obdclass/cl_page.c >> index cd9a40c..71fcc4c

Re: [RFC] [media] imx: assume MEDIA_ENT_F_ATV_DECODER entities output video on pad 1

2017-04-05 Thread Philipp Zabel
On Tue, 2017-04-04 at 15:11 -0700, Steve Longerbeam wrote: > > On 03/30/2017 10:25 AM, Philipp Zabel wrote: > > The TVP5150 DT bindings specify a single output port (port 0) that > > corresponds to the video output pad (pad 1, DEMOD_PAD_VID_OUT). > > > > Signed-off-by: Philipp Zabel

Re: [RFC] [media] imx: assume MEDIA_ENT_F_ATV_DECODER entities output video on pad 1

2017-04-05 Thread Philipp Zabel
On Wed, 2017-04-05 at 09:21 +0100, Russell King - ARM Linux wrote: [...] > > Actually what was I thinking, the TVP5150 is already an example of > > such a device. > > > > All of this could be solved if there was some direction information > > in port nodes. > > I disagree. > > Philipp identified

Re: [PATCH 03/24] staging: ks7010: add BUG_ON() to catch programmer error

2017-04-05 Thread Dan Carpenter
On Tue, Apr 04, 2017 at 09:59:30PM +1000, Tobin C. Harding wrote: > On Tue, Apr 04, 2017 at 01:21:33PM +0300, Dan Carpenter wrote: > > On Sun, Apr 02, 2017 at 10:18:09AM +1000, Tobin C. Harding wrote: > > > Constant is used to allocate memory for a buffer, then buffer is > > > filled upto 'size'

Re: [RFC] [media] imx: assume MEDIA_ENT_F_ATV_DECODER entities output video on pad 1

2017-04-05 Thread Russell King - ARM Linux
On Tue, Apr 04, 2017 at 05:44:05PM -0700, Steve Longerbeam wrote: > > > On 04/04/2017 05:40 PM, Steve Longerbeam wrote: > > > > > >On 04/04/2017 04:10 PM, Russell King - ARM Linux wrote: > >>On Thu, Mar 30, 2017 at 07:25:49PM +0200, Philipp Zabel wrote: > >>>The TVP5150 DT bindings specify a

[lkp-robot] [staging] 0789e2c538: kernel_BUG_at_drivers/base/driver.c

2017-04-05 Thread kernel test robot
FYI, we noticed the following commit: commit: 0789e2c538a0f766600f51cff83dc389b9ea3ad0 ("staging: unisys: visorbus: get rid of create_bus_type.") https://github.com/0day-ci/linux David-Kershner/staging-unisys-Add-additional-error-handling-to-the-s-Par-drivers/20170329-031020 in testcase: