Re: [PATCH v4] staging: vboxvideo: Add vboxvideo to drivers/staging

2017-06-26 Thread kbuild test robot
Hi Hans, [auto build test ERROR on staging/staging-testing] [also build test ERROR on v4.12-rc7 next-20170626] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Hans-de-Goede/staging-vboxvideo-Add

Re: [PATCH v3 08/10] x86/hyper-v: use hypercall for remote TLB flush

2017-06-26 Thread Andy Lutomirski
On Tue, May 23, 2017 at 5:36 AM, Vitaly Kuznetsov wrote: > Andy Lutomirski writes: > >> >> Also, can you share the benchmark you used for these patches? > > I didn't do much while writing the patchset, mostly I was running the > attached dumb trasher (32

[PATCH] Staging: visorbus: Fix coding style warning from checkpatch.pl.

2017-06-26 Thread Quytelda Kahja
Replace the literal function name "create_bus_instance" with the format specifier "%s" so it can be dynamically filled by the __func__ macro. Signed-off-by: Quytelda Kahja --- drivers/staging/unisys/visorbus/visorbus_main.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: endian bitshift defects [ was: staging: fusb302: don't bitshift __le16 type ]

2017-06-26 Thread Julia Lawall
On Mon, 26 Jun 2017, Frans Klaver wrote: > On Fri, Jun 23, 2017 at 07:37:28PM -0400, Julia Lawall wrote: > > > > > > On Sat, 24 Jun 2017, Frans Klaver wrote: > > > > > Hm. For some reason the great mail filtering scheme decided to push > > > this past my inbox :-/ > > > > > > On Sat, Jun 17,

RE: [PATCH 08/10] x86/hyper-v: use hypercall for remote TLB flush

2017-06-26 Thread KY Srinivasan
> -Original Message- > From: devel [mailto:driverdev-devel-boun...@linuxdriverproject.org] On > Behalf Of Vitaly Kuznetsov > Sent: Monday, June 26, 2017 1:15 AM > To: k...@exchange.microsoft.com > Cc: o...@aepfle.de; Stephen Hemminger ; >

Re: endian bitshift defects [ was: staging: fusb302: don't bitshift __le16 type ]

2017-06-26 Thread Frans Klaver
On Fri, Jun 23, 2017 at 07:37:28PM -0400, Julia Lawall wrote: > > > On Sat, 24 Jun 2017, Frans Klaver wrote: > > > Hm. For some reason the great mail filtering scheme decided to push > > this past my inbox :-/ > > > > On Sat, Jun 17, 2017 at 12:44 AM, Joe Perches wrote: > > >

Re: [PATCH 6/7] staging: wilc1000: Change ac based on acm status

2017-06-26 Thread kbuild test robot
Hi Aditya, [auto build test ERROR on staging/staging-testing] [also build test ERROR on v4.12-rc7 next-20170626] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Aditya-Shankar/staging-wilc1000

[PATCH v2] staging: sm750fb: always take the lock

2017-06-26 Thread AbdAllah-MEZITI
This patch - Always take the lock: The current code only takes the lock if multiple instances are in use. This is error-prone, and confuses static analyzers. As taking the lock in case of a single instance is harmless and cheap, change the code to always take the lock. - That also fix the sparse

Re: [PATCH v3] staging: vboxvideo: Add vboxvideo to drivers/staging

2017-06-26 Thread Hans de Goede
Hi, On 26-06-17 18:24, Daniel Vetter wrote: On Mon, Jun 26, 2017 at 06:06:19PM +0200, Hans de Goede wrote: Hi, On 23-06-17 11:31, Daniel Vetter wrote: On Thu, Jun 22, 2017 at 11:11:37AM +0200, Hans de Goede wrote: This commit adds the vboxvideo drm/kms driver for the virtual graphics card

Re: [PATCH v3] staging: vboxvideo: Add vboxvideo to drivers/staging

2017-06-26 Thread Hans de Goede
Hi, On 22-06-17 14:03, Dan Carpenter wrote: > This is obviously much better and easier to review. I ended up > reviewing it like I would normal code instead of staging code. My main > thing is could you please re-write the module init error handling so > that each function does its own error

RE: [staging:staging-testing 357/367] make[5]: *** No rule to make target 'drivers/staging/fsl-mc/bus/dpmng.o', needed by 'drivers/staging/fsl-mc/bus/mc-bus-driver.o'.

2017-06-26 Thread Laurentiu Tudor
> -Original Message- > From: Greg Kroah-Hartman [mailto:gre...@linuxfoundation.org] > Sent: Monday, June 26, 2017 2:55 PM > To: Laurentiu Tudor > > On Mon, Jun 26, 2017 at 01:48:01PM +0200, Greg Kroah-Hartman wrote: > > On Mon, Jun 26, 2017 at 09:06:11AM +,

Re: [staging:staging-testing 357/367] make[5]: *** No rule to make target 'drivers/staging/fsl-mc/bus/dpmng.o', needed by 'drivers/staging/fsl-mc/bus/mc-bus-driver.o'.

2017-06-26 Thread Greg Kroah-Hartman
On Mon, Jun 26, 2017 at 01:48:01PM +0200, Greg Kroah-Hartman wrote: > On Mon, Jun 26, 2017 at 09:06:11AM +, Laurentiu Tudor wrote: > > Hi Greg, > > > > > -Original Message- > > > From: Greg Kroah-Hartman [mailto:gre...@linuxfoundation.org] > > > Sent: Monday, June 26, 2017 11:50 AM >

Re: [staging:staging-testing 357/367] make[5]: *** No rule to make target 'drivers/staging/fsl-mc/bus/dpmng.o', needed by 'drivers/staging/fsl-mc/bus/mc-bus-driver.o'.

2017-06-26 Thread Greg Kroah-Hartman
On Mon, Jun 26, 2017 at 09:06:11AM +, Laurentiu Tudor wrote: > Hi Greg, > > > -Original Message- > > From: Greg Kroah-Hartman [mailto:gre...@linuxfoundation.org] > > Sent: Monday, June 26, 2017 11:50 AM > > To: Laurentiu Tudor > > > > On Mon, Jun 26, 2017 at

[PATCH v2 4/8] staging: wilc1000: Add function to balance packet count

2017-06-26 Thread Aditya Shankar
Add a new function to track the cound of packets and determine the ratio of current number of packets to maximum count of packets. Signed-off-by: Aditya Shankar --- drivers/staging/wilc1000/wilc_wlan.c | 17 + 1 file changed, 17 insertions(+) diff

[PATCH v2 6/8] staging: wilc1000: Get packet count from firmware

2017-06-26 Thread Aditya Shankar
Add a new function to get packet count from the firmware. 31:25 24 23:17 16 15:98 7:2 1 0 VO CNT VO ACM VI CNT VI ACM BE CNT BE ACM BK CNT BK ACM VMM ready Signed-off-by: Aditya Shankar ---

[PATCH v2 8/8] staging: wilc1000: Update ACM bit status

2017-06-26 Thread Aditya Shankar
Add a new function to update ACM bit status for a queue for all access categories. Signed-off-by: Aditya Shankar --- drivers/staging/wilc1000/wilc_wlan.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/staging/wilc1000/wilc_wlan.c

[PATCH v2 7/8] staging: wilc1000: Change ac based on acm status

2017-06-26 Thread Aditya Shankar
Add a new function to check and alter the ac if needed based on the acm status for a particular queue. Signed-off-by: Aditya Shankar --- drivers/staging/wilc1000/wilc_wlan.c | 10 ++ 1 file changed, 10 insertions(+) diff --git

[PATCH v2 3/8] staging: wilc1000: WMM classification of data

2017-06-26 Thread Aditya Shankar
This patch adds a new function to classify data to available WMM access categories based on the DSCP value in the header. Signed-off-by: Aditya Shankar --- drivers/staging/wilc1000/wilc_wlan.c | 51 1 file changed, 51

[PATCH v2 1/8] staging: wilc1000: Add support for AC classification.

2017-06-26 Thread Aditya Shankar
This patch adds new variables and defines for adding access category classification Signed-off-by: Aditya Shankar --- drivers/staging/wilc1000/wilc_wlan.h | 25 + 1 file changed, 25 insertions(+) diff --git

[PATCH v2 5/8] staging: wilc1000: Add new variable for ac queue management

2017-06-26 Thread Aditya Shankar
This patch adds a new variable in the wilc struct to manage ac queues. Signed-off-by: Aditya Shankar --- drivers/staging/wilc1000/wilc_wfi_netdevice.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/wilc1000/wilc_wfi_netdevice.h

[PATCH v2 0/8] Enable access category classification on Tx path

2017-06-26 Thread Aditya Shankar
This patch series adds changes made to implement access category based data classification and manages buffers allocation between different access categories on the Tx path. Aditya Shankar (8): staging: wilc1000: Add support for AC classification. staging: wilc1000: Add function to calculate

[PATCH v2 2/8] staging: wilc1000: Add function to calculate ac queue limit

2017-06-26 Thread Aditya Shankar
This patch adds a function which calculates the queue limit for a given access category queue. Signed-off-by: Aditya Shankar --- drivers/staging/wilc1000/wilc_wlan.c | 42 1 file changed, 42 insertions(+) diff --git

Re: endian bitshift defects [ was: staging: fusb302: don't bitshift __le16 type ]

2017-06-26 Thread Julia Lawall
On Mon, 26 Jun 2017, Frans Klaver wrote: > On Sat, Jun 24, 2017 at 1:37 AM, Julia Lawall wrote: > > > > > > On Sat, 24 Jun 2017, Frans Klaver wrote: > > > >> Hm. For some reason the great mail filtering scheme decided to push > >> this past my inbox :-/ > >> > >> On Sat,

Re: [PATCH] staging: sm750fb: always take the lock

2017-06-26 Thread Geert Uytterhoeven
On Mon, Jun 26, 2017 at 11:16 AM, Frans Klaver wrote: > On Mon, Jun 26, 2017 at 11:11 AM, Geert Uytterhoeven > wrote: >> On Mon, Jun 26, 2017 at 7:45 AM, AbdAllah-MEZITI >> wrote: >>> This patch >>> - will always take

Re: [PATCH] staging: sm750fb: always take the lock

2017-06-26 Thread Frans Klaver
On Mon, Jun 26, 2017 at 11:11 AM, Geert Uytterhoeven wrote: > On Mon, Jun 26, 2017 at 7:45 AM, AbdAllah-MEZITI > wrote: >> This patch >> - will always take the lock > > Why? > > "The current code only takes the lock if multiple instances are

Re: [PATCH] staging: sm750fb: always take the lock

2017-06-26 Thread Geert Uytterhoeven
On Mon, Jun 26, 2017 at 7:45 AM, AbdAllah-MEZITI wrote: > This patch > - will always take the lock Why? "The current code only takes the lock if multiple instances are in use. This is error-prone, and confuses static analyzers. As taking the lock in case of a

RE: [staging:staging-testing 357/367] make[5]: *** No rule to make target 'drivers/staging/fsl-mc/bus/dpmng.o', needed by 'drivers/staging/fsl-mc/bus/mc-bus-driver.o'.

2017-06-26 Thread Laurentiu Tudor
Hi Greg, > -Original Message- > From: Greg Kroah-Hartman [mailto:gre...@linuxfoundation.org] > Sent: Monday, June 26, 2017 11:50 AM > To: Laurentiu Tudor > > On Mon, Jun 26, 2017 at 08:39:20AM +, Laurentiu Tudor wrote: > > Hi Greg, > > > > > -Original

Re: [staging:staging-testing 357/367] make[5]: *** No rule to make target 'drivers/staging/fsl-mc/bus/dpmng.o', needed by 'drivers/staging/fsl-mc/bus/mc-bus-driver.o'.

2017-06-26 Thread Greg Kroah-Hartman
On Mon, Jun 26, 2017 at 08:39:20AM +, Laurentiu Tudor wrote: > Hi Greg, > > > -Original Message- > > From: Greg Kroah-Hartman [mailto:gre...@linuxfoundation.org] > > > > On Sat, Jun 24, 2017 at 08:17:59PM +0800, kbuild test robot wrote: > > > tree: > >

RE: [staging:staging-testing 357/367] make[5]: *** No rule to make target 'drivers/staging/fsl-mc/bus/dpmng.o', needed by 'drivers/staging/fsl-mc/bus/mc-bus-driver.o'.

2017-06-26 Thread Laurentiu Tudor
Hi Greg, > -Original Message- > From: Greg Kroah-Hartman [mailto:gre...@linuxfoundation.org] > > On Sat, Jun 24, 2017 at 08:17:59PM +0800, kbuild test robot wrote: > > tree: > https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.ker >

Re: [PATCH 08/10] x86/hyper-v: use hypercall for remote TLB flush

2017-06-26 Thread Vitaly Kuznetsov
note to > help improve the system] > > url: > https://github.com/0day-ci/linux/commits/kys-exchange-microsoft-com/x86-hyper-v-include-hyperv-only-when-CONFIG_HYPERV-is-set/20170626-133601 > config: i386-randconfig-a0-06250447 (attached as .config) > compiler: gcc-5 (

Re: endian bitshift defects [ was: staging: fusb302: don't bitshift __le16 type ]

2017-06-26 Thread Frans Klaver
On Sat, Jun 24, 2017 at 1:37 AM, Julia Lawall wrote: > > > On Sat, 24 Jun 2017, Frans Klaver wrote: > >> Hm. For some reason the great mail filtering scheme decided to push >> this past my inbox :-/ >> >> On Sat, Jun 17, 2017 at 12:44 AM, Joe Perches

[PATCH 7/7] staging: wilc1000: Update ACM bit status

2017-06-26 Thread Aditya Shankar
Add a new function to update ACM bit status for a queue for all access categories. Signed-off-by: Aditya Shankar --- drivers/staging/wilc1000/wilc_wlan.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/staging/wilc1000/wilc_wlan.c

[PATCH 3/7] staging: wilc1000: WMM classification of data

2017-06-26 Thread Aditya Shankar
This patch adds a new function to classify data to available WMM access categories based on the DSCP value in the header. Signed-off-by: Aditya Shankar --- drivers/staging/wilc1000/wilc_wlan.c | 51 1 file changed, 51

[PATCH 5/7] staging: wilc1000: Get packet count from firmware

2017-06-26 Thread Aditya Shankar
Add a new function to get packet count from the firmware. 31:25 24 23:17 16 15:98 7:2 1 0 VO CNT VO ACM VI CNT VI ACM BE CNT BE ACM BK CNT BK ACM VMM ready Signed-off-by: Aditya Shankar ---

[PATCH 2/7] staging: wilc1000: Add function to calculate ac queue limit

2017-06-26 Thread Aditya Shankar
This patch adds a function which calculates the queue limit for a given access category queue. Signed-off-by: Aditya Shankar --- drivers/staging/wilc1000/wilc_wlan.c | 42 1 file changed, 42 insertions(+) diff --git

[PATCH 6/7] staging: wilc1000: Change ac based on acm status

2017-06-26 Thread Aditya Shankar
Add a new function to check and alter the ac if needed based on the acm status for a particular queue. Signed-off-by: Aditya Shankar --- drivers/staging/wilc1000/wilc_wlan.c | 10 ++ 1 file changed, 10 insertions(+) diff --git

[PATCH 1/7] staging: wilc1000: Add support for AC classification.

2017-06-26 Thread Aditya Shankar
This patch adds new variables and defines for adding access category classification Signed-off-by: Aditya Shankar --- drivers/staging/wilc1000/wilc_wlan.h | 25 + 1 file changed, 25 insertions(+) diff --git

[PATCH 0/7] Enable access category classification on Tx path

2017-06-26 Thread Aditya Shankar
This patch series adds changes made to implement access category based data classification and manages buffers allocation between different access categories on the Tx path. Aditya Shankar (7): staging: wilc1000: Add support for AC classification. staging: wilc1000: Add function to calculate

[PATCH 4/7] staging: wilc1000: Add function to balance packet count

2017-06-26 Thread Aditya Shankar
Add a new function to track the cound of packets and determine the ratio of current number of packets to maximum count of packets. Signed-off-by: Aditya Shankar --- drivers/staging/wilc1000/wilc_wlan.c | 17 + 1 file changed, 17 insertions(+) diff

Re: [PATCH 08/10] x86/hyper-v: use hypercall for remote TLB flush

2017-06-26 Thread kbuild test robot
/commits/kys-exchange-microsoft-com/x86-hyper-v-include-hyperv-only-when-CONFIG_HYPERV-is-set/20170626-133601 config: i386-randconfig-a0-06250447 (attached as .config) compiler: gcc-5 (Debian 5.4.1-2) 5.4.1 20160904 reproduce: # save the attached .config to linux build tree make ARCH=i386

Re: [PATCH] staging: sm750fb: always take the lock

2017-06-26 Thread Frans Klaver
There's no version number. Which one is the correct one? On Mon, Jun 26, 2017 at 7:45 AM, AbdAllah-MEZITI wrote: > This patch > - will always take the lock > - fix the sparse warning: > drivers/staging/sm750fb/sm750.c:159:13: warning: context imbalance in >

Re: [PATCH] staging: sm750fb: always take the lock

2017-06-26 Thread Frans Klaver
On Sun, Jun 25, 2017 at 11:39 PM, AbdAllah-MEZITI wrote: > Subject: [PATCH] staging: sm750fb: always take the lock When sending a new version of your patch, include a version number: Subject: [PATCH V2] staging: ... Frans