Re: [PATCH] staging: ccree: use size_t consistently

On Wed, Dec 20, 2017 at 07:23:31AM +, Gilad Ben-Yossef wrote: > Fix declaration, implementation and wrapper function to use > the same size_t type we actually define the parameter to be. > > Fixes: 3f268f5d6669 ("staging: ccree: turn compile time debug log to params") > Signed-off-by: Gilad

Re: [PATCH] Staging: ccree: Add blank line after declarations

On Wed, Dec 20, 2017 at 09:32:06AM +0200, Gilad Ben-Yossef wrote: > Hi, > > I've missed this patch as I wasn't CCed and just noticed it in staging-next... > > On Sat, Dec 16, 2017 at 1:43 AM, Kamal Heib wrote: > > This patch adds a blank line after declarations to > >

Re: [PATCH] Staging: ccree: Add blank line after declarations

Hi, I've missed this patch as I wasn't CCed and just noticed it in staging-next... On Sat, Dec 16, 2017 at 1:43 AM, Kamal Heib wrote: > This patch adds a blank line after declarations to > improve code readability. > > Issue find by checkpatch.pl script. > WARNING: Missing

[PATCH] staging: ccree: use size_t consistently

Fix declaration, implementation and wrapper function to use the same size_t type we actually define the parameter to be. Fixes: 3f268f5d6669 ("staging: ccree: turn compile time debug log to params") Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/ssi_driver.c | 2

Re: [PATCH v1 2/4] lib/net_utils: Introduce mac_pton_from_user()

On Tue, Dec 19, 2017 at 09:14:10PM +0200, Andy Shevchenko wrote: > Some drivers are getting MAC from user space. Make a helper for them. > > Signed-off-by: Andy Shevchenko > --- > include/linux/kernel.h | 1 + > lib/net_utils.c| 12 > 2

Re: [staging:staging-testing 284/298] drivers/staging/ccree/ssi_driver.c:83:6: error: conflicting types for '__dump_byte_array'

On Tue, Dec 19, 2017 at 6:37 PM, Greg Kroah-Hartman wrote: > On Tue, Dec 19, 2017 at 11:02:33PM +0800, kbuild test robot wrote: >> tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git >> staging-testing >> head:

Re: [PATCH v1 05/10] staging: atomisp: Remove non-ACPI leftovers

On Tue, Dec 19, 2017 at 10:59:52PM +0200, Andy Shevchenko wrote: > @@ -1147,10 +1145,8 @@ static int gc2235_probe(struct i2c_client *client) > if (ret) > gc2235_remove(client); This error handling is probably wrong... > > - if (ACPI_HANDLE(>dev)) > - ret =

Re: PROBLEM: 4.15.0-rc3 APIC causes lockups on Core 2 Duo laptop

Hi Thomas, At 12/20/2017 08:31 AM, Thomas Gleixner wrote: On Tue, 19 Dec 2017, Alexandru Chirvasitu wrote: I had never heard of 'bisect' before this casual mention (you might tell I am a bit out of my depth). I've since applied it to Linus' tree between bebc608 Linux 4.14 (good) and

Re: PROBLEM: 4.15.0-rc3 APIC causes lockups on Core 2 Duo laptop

On Tue, 19 Dec 2017, Alexandru Chirvasitu wrote: > I had never heard of 'bisect' before this casual mention (you might tell > I am a bit out of my depth). I've since applied it to Linus' tree between > bebc608 Linux 4.14 (good) > > and > > 4fbd8d1 Linux 4.15-rc1 (bad) Is Linus current head

Re: [PATCH RFC 2/7] KVM: nVMX: modify vmcs12 fields to match Hyper-V enlightened VMCS

On 19/12/2017 18:40, Jim Mattson wrote: > I'm not sure that's really the right way to go, since any guest that > has already read the IA32_VMX_BASIC MSR has a right to expect the VMCS > revision to remain unchanged. Hmm, not just that, "the VMCS revision identifier is never written by the

[PATCH v1 01/10] staging: atomisp: Don't leak GPIO resources if clk_get() failed

In case devm_clk_get() call fails the previously requested GPIOs are left requested. Fix this by moving GPIO request code after devm_clk_get() call. Signed-off-by: Andy Shevchenko --- .../staging/media/atomisp/platform/intel-mid/atomisp_gmin_platform.c | 4

[PATCH v1 07/10] staging: atomisp: Remove redundant PCI code

There is no need to keep a reference to PCI root bridge. Signed-off-by: Andy Shevchenko --- drivers/staging/media/atomisp/pci/atomisp2/atomisp_internal.h | 1 - drivers/staging/media/atomisp/pci/atomisp2/atomisp_v4l2.c | 8 2 files changed, 9

[PATCH v1 09/10] staging: atomisp: Use standard DMI match table

The traditional pattern is to use DMI matching table and provide a corresponding driver_data in it. Convert driver to use DMI matching table. Signed-off-by: Andy Shevchenko --- .../platform/intel-mid/atomisp_gmin_platform.c | 109 + 1

[PATCH v1 04/10] staging: atomisp: Disable custom format for now

Custom video format 'M101' is not supported in upstream and as a result user will get ugly warning: Unknown pixelformat 0x3130314d [ cut here ] WARNING: CPU: 3 PID: 1574 at drivers/media/v4l2-core/v4l2-ioctl.c:1291 v4l_enum_fmt+0xcf1/0x13a0 [videodev] Signed-off-by:

[PATCH v1 08/10] staging: atomisp: Unexport local function

There is no need to export function which is only used once in the same module where it's defined. Signed-off-by: Andy Shevchenko --- drivers/staging/media/atomisp/include/linux/atomisp_gmin_platform.h | 1 -

[PATCH v1 10/10] staging: atomisp: Fix DMI matching entry for MRD7

MRD7 board has in particular Base Board Information Manufacturer: Intel Corp. Product Name: TABLET Version: MRD 7 Fix the DMI matching entry for it. Signed-off-by: Andy Shevchenko ---

[PATCH v1 06/10] staging: atomisp: Switch to use struct device_driver directly

In a preparation of split PCI glue driver from core part, convert the driver to use more generic struct device_driver. Signed-off-by: Andy Shevchenko --- .../staging/media/atomisp/pci/atomisp2/atomisp_drvfs.c | 17 -

[PATCH v1 05/10] staging: atomisp: Remove non-ACPI leftovers

Since all drivers are solely requiring ACPI enumeration, there is no need to additionally check for legacy platform data or ACPI handle. Remove leftovers from the sensors and platform code. Signed-off-by: Andy Shevchenko ---

[PATCH v1 03/10] staging: atomisp: lm3554: Fix control values

Driver fails to initialize due to insane settings in the control init array. Fix this by moving to sanity. Signed-off-by: Andy Shevchenko --- drivers/staging/media/atomisp/i2c/atomisp-lm3554.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-)

Re: [PATCH 1/5] staging: rtl8712: style fix over 80 characters warnings

The patch is corrupt. Read Documentation/process/email-clients.rst regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH v4 4/5] staging: rtl8712: style fix unneeded else

This patch fixes a coding style issues in the rtl8712 module as noted by checkpatch.pl where an unnecessary else is used. It fixes the following checkpatch.pl warning: WARNING: else is not generally useful after a break or return Signed-off-by: Martin Homuth ---

[PATCH v4 0/5] staging: rtl8712: fix several checkpatch style issues

This patch series fixes some coding style issues reported by checkpatch.pl. It is based on next-20171218 v2: - avoid line-wrapping by thunderbird - use temporary pointers to avoid index in separate line ([2/5]) v3: - missed one reference simplification ([2/5]) - fix some checkpatch checks

[PATCH v4 1/5] staging: rtl8712: style fix over 80 characters warnings

This patch fixes various coding style issues in the rtl8712 module as noted by checkpatch.pl by reducing the characters per line to under 80. It fixes the following checkpatch.pl warning: WARNING: line over 80 characters Signed-off-by: Martin Homuth ---

[PATCH v4 5/5] staging: rtl8712: style fix returned error code

This patch fixes a coding style issues in the rtl8712 module as noted by checkpatch.pl regarding the returned error code. It fixes the following checkpatch.pl warning: WARNING: ENOSYS means 'invalid syscall nr' and nothing else Signed-off-by: Martin Homuth ---

[PATCH v4 2/5] staging: rtl8712: style fix multiple line dereferences

This patch fixes various coding style issues in the rtl8712 module as noted by checkpatch.pl related to dereferencing over multiple lines. It fixes the following checkpatch.pl warning: WARNING: Avoid multiple line dereference - prefer %s Signed-off-by: Martin Homuth ---

[PATCH v4 3/5] staging: rtl8712: style fix indentation

This patch fixes various coding style issues in the rtl8712 module as noted by checkpatch.pl related to indentation. It fixes the following checkpatch.pl warning: WARNING: suspect code indent for conditional statements Signed-off-by: Martin Homuth ---

RE: [PATCH v2 3/8] media: v4l2-async: simplify v4l2_async_subdev structure

Hi Mauro, Thanks for the patch. > -Original Message- > From: Mauro Carvalho Chehab [mailto:mche...@smtp.s-opensource.com] > On Behalf Of Mauro Carvalho Chehab > Sent: Tuesday, December 19, 2017 3:18 AM > To: Linux Media Mailing List > Cc: Mauro Carvalho

Re: [PATCH v3 2/5] staging: rtl8712: style fix multiple line dereferences

On 12/19/2017 05:41 PM, Joe Perches wrote: > On Tue, 2017-12-19 at 17:32 +0100, Martin Homuth wrote: >> This patch fixes various coding style issues in the rtl8712 module as >> noted by checkpatch.pl related to dereferencing over multiple lines. > [] >> diff --git

[PATCHv2] staging: pi433: pi433_write fixed the return value

The pi433_write function should return the number of processed bytes Reported-by: Marcin Ciupak Signed-off-by: Oliver Graute --- Changes in v2: - added Reported-By Tag drivers/staging/pi433/pi433_if.c | 2 +- 1 file changed, 1

[PATCH 2/3] staging: greybus: audio_codec.c: Fix multiple checkpatch errors

This patch fixes the following errors found by checkpatch: 1- Prefer kernel type 'u32' over 'uint32_t'. 2- Space required around that ':'. 3- Alignment should match open parenthesis. 4- Don't use multiple blank lines. Signed-off-by: Kamal Heib ---

[PATCH 3/3] staging: greybus: audio_codec.h: Fix multiple checkpatch errors

This patch fixes the following errors found by checkpatch: 1- Prefer kernel type 'u32' over 'uint32_t'. 2- Alignment should match open parenthesis. Signed-off-by: Kamal Heib --- drivers/staging/greybus/audio_codec.h | 12 ++-- 1 file changed, 6 insertions(+), 6

[PATCH 1/3] staging: greybus: arche-apb-ctrl.c: Fix multiple blank lines error

Fix "don't use multiple blank lines" error found by checkpatch.pl. Signed-off-by: Kamal Heib --- drivers/staging/greybus/arche-apb-ctrl.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/greybus/arche-apb-ctrl.c b/drivers/staging/greybus/arche-apb-ctrl.c

[PATCH 0/3] staging: greybus: Fix multiple checkpatch errors

This patch set fixes multiple error found by checkpatch.pl in the greybus drivers. Kamal Heib (3): staging: greybus: arche-apb-ctrl.c: Fix multiple blank lines error staging: greybus: audio_codec.c: Fix multiple checkpatch errors staging: greybus: audio_codec.h: Fix multiple checkpatch

[PATCH] staging: pi433: pi433_write fixed the return value

The pi433_write function should return the number of processed bytes. This fix endless sending if write is invoked from userspace. Signed-off-by: Oliver Graute --- drivers/staging/pi433/pi433_if.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [-next PATCH 0/4] sysfs and DEVICE_ATTR_

On 12/19/2017 12:15 PM, Joe Perches wrote: drivers/char/ipmi/ipmi_msghandler.c| 17 +++--- For ipmi: Acked-by: Corey Minyard ___ devel mailing list de...@linuxdriverproject.org

Re: first try to send data with pi433 on Raspberry Pi

On Tue, Dec 19, 2017 at 07:59:33PM +0100, Oliver Graute wrote: > On 12/12/17, Marcin Ciupak wrote: > > > > this is due to fact that pi433_write returns 0 on successful copy while > > it should return 'copied' value. So it is a bug :) > > > > '0' means nothing was copied so userpsace calls

[PATCH v1 2/4] lib/net_utils: Introduce mac_pton_from_user()

Some drivers are getting MAC from user space. Make a helper for them. Signed-off-by: Andy Shevchenko --- include/linux/kernel.h | 1 + lib/net_utils.c| 12 2 files changed, 13 insertions(+) diff --git a/include/linux/kernel.h

[PATCH v1 3/4] staging: rtl8723bs: Replace mac address parsing

Replace copy_from_user() + sscanf() with mac_pton_from_user(). While here, replace memcpy(..., ETH_ALEN) with ether_addr_copy(). Signed-off-by: Andy Shevchenko --- drivers/staging/rtl8723bs/core/rtw_debug.c | 18 ++ 1 file changed, 6

[PATCH v1 4/4] staging: rtl8712: Replace mac address parsing

Replace copy_from_user() + mac_pton() with mac_pton_from_user(). Signed-off-by: Andy Shevchenko --- drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git

[PATCH v1 1/4] lib/net_utils: Relax NULL-termination requirement on input string

We have not been caring about garbage at the end of input string and this change doesn't affect it. What we prevent here is possibility to go over boundaries when input string is not NULL terminated at all. Allow mac_pton() work on non-NULL terminated strings. Signed-off-by: Andy Shevchenko

[PATCH] Staging: rtl8723bs: Do not check for NOT NULL before kfree()

Do not check for NOT NULL before calling kfree because if the pointer is NULL, no action occurs. Done using the following semantic patch by coccinelle. @@ expression ptr; @@ - if (ptr != NULL) kfree(ptr); Signed-off-by: Shreeya Patel ---

Re: first try to send data with pi433 on Raspberry Pi

On 12/12/17, Marcin Ciupak wrote: > > this is due to fact that pi433_write returns 0 on successful copy while > it should return 'copied' value. So it is a bug :) > > '0' means nothing was copied so userpsace calls pi433_write again and > again, data is put to fifo and when it is full it goes to

Re: [-next PATCH 0/4] sysfs and DEVICE_ATTR_

On Tue, 19 Dec 2017, Joe Perches wrote: > drivers/gpu/drm/i915/i915_sysfs.c | 12 ++-- For i915, Acked-by: Jani Nikula -- Jani Nikula, Intel Open Source Technology Center ___ devel mailing

Re: [PATCH] scsi: storvsc: Fix scsi_cmd error assignments in storvsc_handle_error

On Tue, 19 Dec 2017 13:32:48 -0500 Cathy Avery wrote: > When an I/O is returned with an srb_status of SRB_STATUS_INVALID_LUN > which has zero good_bytes it must be assigned an error. Otherwise > the I/O will be continuously requeued and will cause a deadlock in the > case

[PATCH] scsi: storvsc: Fix scsi_cmd error assignments in storvsc_handle_error

When an I/O is returned with an srb_status of SRB_STATUS_INVALID_LUN which has zero good_bytes it must be assigned an error. Otherwise the I/O will be continuously requeued and will cause a deadlock in the case where disks are being hot added and removed. sd_probe_async will wait forever for its

[-next PATCH 0/4] sysfs and DEVICE_ATTR_

Joe Perches (4): sysfs.h: Use octal permissions treewide: Use DEVICE_ATTR_RW treewide: Use DEVICE_ATTR_RO treewide: Use DEVICE_ATTR_WO arch/arm/mach-pxa/sharpsl_pm.c | 4 +- arch/s390/kernel/smp.c | 2 +- arch/s390/kernel/topology.c

[-next PATCH 3/4] treewide: Use DEVICE_ATTR_RO

Convert DEVICE_ATTR uses to DEVICE_ATTR_RO where possible. Done with perl script: $ git grep -w --name-only DEVICE_ATTR | \ xargs perl -i -e 'local $/; while (<>) { s/\bDEVICE_ATTR\s*\(\s*(\w+)\s*,\s*\(?(?:\s*S_IRUGO\s*|\s*0444\s*)\)?\s*,\s*\1_show\s*,\s*NULL\s*\)/DEVICE_ATTR_RO(\1)/g;

[staging:staging-next 284/304] drivers/staging/ccree/ssi_driver.c:90:2: warning: format '%lu' expects argument of type 'long unsigned int', but argument 5 has type 'size_t'

tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-next head: f772fa121d50d980457dc0c37152e30bf60c6452 commit: 3f268f5d6669b61e38ad65095480cdf80389ae40 [284/304] staging: ccree: turn compile time debug log to params config: i386-randconfig-b0-12200126 (attached

[PATCH v4] staging: lustre: Replace 'uint32_t' with 'u32' and 'uint64_t' with 'u64'

There are two reasons for replacing 'uint32_t' with 'u32' and 'uint64_t' with 'u64': 1) As Linus Torvalds have said we should use kernel types: http://lkml.iu.edu/hypermail//linux/kernel/1506.0/00160.html 2) There are only few places in the lustre codebase that use such types. In the most cases

Re: [PATCH v3 2/5] staging: rtl8712: style fix multiple line dereferences

On Tue, 2017-12-19 at 17:32 +0100, Martin Homuth wrote: > This patch fixes various coding style issues in the rtl8712 module as > noted by checkpatch.pl related to dereferencing over multiple lines. [] > diff --git a/drivers/staging/rtl8712/rtl8712_recv.c >

Re: [staging:staging-testing 284/298] drivers/staging/ccree/ssi_driver.c:83:6: error: conflicting types for '__dump_byte_array'

On Tue, Dec 19, 2017 at 11:02:33PM +0800, kbuild test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git > staging-testing > head: 893b103a3e9ce255e9afe8103d90f28ac2124eb8 > commit: 3f268f5d6669b61e38ad65095480cdf80389ae40 [284/298] staging: ccree: > turn

[PATCH v3 1/5] staging: rtl8712: style fix over 80 characters warnings

This patch fixes various coding style issues in the rtl8712 module as noted by checkpatch.pl by reducing the characters per line to under 80. It fixes the following checkpatch.pl warning: WARNING: line over 80 characters Signed-off-by: Martin Homuth ---

[PATCH v3 4/5] staging: rtl8712: style fix unneeded else

This patch fixes a coding style issues in the rtl8712 module as noted by checkpatch.pl where an unnecessary else is used. It fixes the following checkpatch.pl warning: WARNING: else is not generally useful after a break or return Signed-off-by: Martin Homuth ---

[PATCH v3 3/5] staging: rtl8712: style fix indentation

This patch fixes various coding style issues in the rtl8712 module as noted by checkpatch.pl related to indentation. It fixes the following checkpatch.pl warning: WARNING: suspect code indent for conditional statements Signed-off-by: Martin Homuth ---

[PATCH v3 2/5] staging: rtl8712: style fix multiple line dereferences

This patch fixes various coding style issues in the rtl8712 module as noted by checkpatch.pl related to dereferencing over multiple lines. It fixes the following checkpatch.pl warning: WARNING: Avoid multiple line dereference - prefer %s Signed-off-by: Martin Homuth ---

[PATCH v3 5/5] staging: rtl8712: style fix returned error code

This patch fixes a coding style issues in the rtl8712 module as noted by checkpatch.pl regarding the returned error code. It fixes the following checkpatch.pl warning: WARNING: ENOSYS means 'invalid syscall nr' and nothing else Signed-off-by: Martin Homuth ---

[PATCH v3 0/5] staging: rtl8712: fix several checkpatch style issues

This patch series fixes some coding style issues reported by checkpatch.pl. It is based on next-20171218 v2: - avoid line-wrapping by thunderbird - use temporary pointers to avoid index in separate line ([2/5]) v3: - missed one reference simplification ([2/5]) - fix some checkpatch checks

Re: [PATCH v4] staging: fsl-mc: move bus driver out of staging

On Tue, Dec 19, 2017 at 03:39:44PM +, Laurentiu Tudor wrote: > On 12/19/2017 05:29 PM, Greg KH wrote: > > On Tue, Dec 19, 2017 at 03:21:19PM +, Laurentiu Tudor wrote: > >> > >> > >> On 12/19/2017 04:48 PM, Greg KH wrote: > >>> On Wed, Nov 29, 2017 at 12:08:44PM +0200,

[PATCH] staging: pi433: fix CamelCase for fifo variables

Fixes checkpatch warnings: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic ---

Re: [PATCH v4] staging: fsl-mc: move bus driver out of staging

On 12/19/2017 05:29 PM, Greg KH wrote: > On Tue, Dec 19, 2017 at 03:21:19PM +, Laurentiu Tudor wrote: >> >> >> On 12/19/2017 04:48 PM, Greg KH wrote: >>> On Wed, Nov 29, 2017 at 12:08:44PM +0200, laurentiu.tu...@nxp.com wrote: From: Stuart Yoder Move the

Re: [PATCH v4] staging: fsl-mc: move bus driver out of staging

On Tue, Dec 19, 2017 at 03:21:19PM +, Laurentiu Tudor wrote: > > > On 12/19/2017 04:48 PM, Greg KH wrote: > > On Wed, Nov 29, 2017 at 12:08:44PM +0200, laurentiu.tu...@nxp.com wrote: > >> From: Stuart Yoder > >> > >> Move the source files out of staging into their

Re: [PATCH v4] staging: fsl-mc: move bus driver out of staging

On 12/19/2017 04:48 PM, Greg KH wrote: > On Wed, Nov 29, 2017 at 12:08:44PM +0200, laurentiu.tu...@nxp.com wrote: >> From: Stuart Yoder >> >> Move the source files out of staging into their final locations: >>-include files in drivers/staging/fsl-mc/include go to

[staging:staging-testing 284/298] drivers/staging/ccree/ssi_driver.c:83:6: error: conflicting types for '__dump_byte_array'

tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-testing head: 893b103a3e9ce255e9afe8103d90f28ac2124eb8 commit: 3f268f5d6669b61e38ad65095480cdf80389ae40 [284/298] staging: ccree: turn compile time debug log to params config: i386-randconfig-x073-201751

[PATCH 3/6 v5] staging: pi433: replace unsigned with unsigned int

Fixes checkpatch warning: WARNING: Prefer 'unsigned int' to bare use of 'unsigned' Signed-off-by: Valentin Vidic --- v5: resend patchset based on comments drivers/staging/pi433/pi433_if.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 6/6 v5] staging: pi433: remove unused function

As it turns out rf69_get_lna_gain is not used at all. Signed-off-by: Valentin Vidic --- v5: resend patchset based on comments drivers/staging/pi433/rf69.c | 18 -- drivers/staging/pi433/rf69.h | 1 - 2 files changed, 19 deletions(-) diff --git

[PATCH 5/6 v5] staging: pi433: replace printk calls with dev_dbg

Fixes checkpatch warning: WARNING: printk() should include KERN_ facility level Signed-off-by: Valentin Vidic --- v5: resend patchset based on comments drivers/staging/pi433/pi433_if.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 4/6 v5] staging: pi433: avoid logging ENOMEM messages

Fixes checkpatch warning: WARNING: Possible unnecessary 'out of memory' message Signed-off-by: Valentin Vidic --- v5: resend patchset based on comments drivers/staging/pi433/pi433_if.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git

[PATCH 2/6 v5] staging: pi433: cleanup local variable declaration

Fix variable naming and checkpatch warning: WARNING: Missing a blank line after declarations Signed-off-by: Valentin Vidic --- v5: resend patchset based on comments drivers/staging/pi433/pi433_if.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff

Re: [PATCH v4] staging: fsl-mc: move bus driver out of staging

On Wed, Nov 29, 2017 at 12:08:44PM +0200, laurentiu.tu...@nxp.com wrote: > From: Stuart Yoder > > Move the source files out of staging into their final locations: > -include files in drivers/staging/fsl-mc/include go to include/linux/fsl > -irq-gic-v3-its-fsl-mc-msi.c

[RFC PATCH] Staging: rtl8723bs: initinterrupt8723bsdio() can be static

Fixes: 8642fab9ea22 ("Staging: rtl8723bs: Change names to conform to the kernel code") Signed-off-by: Fengguang Wu --- sdio_ops.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/sdio_ops.c

Re: [PATCH] staging: wilc1000: Fix lines ending with parentheses

On Sat, Dec 16, 2017 at 01:25:19PM +0530, Aditya Shankar wrote: > This patch fixes the "Lines should not end with a '('" > problem reported by checkpatch > > Signed-off-by: Aditya Shankar > --- > drivers/staging/wilc1000/linux_mon.c | 12 ++-- > 1 file

Re: [PATCH 3/3] staging: dgnc: dgnc_neo.c: remove unnecessary parentheses

On Sat, Dec 16, 2017 at 10:16:01PM +0200, Kamal Heib wrote: > Cleanup the "Unnecessary parentheses around " checkpatch.pl error. > > Signed-off-by: Kamal Heib > --- > drivers/staging/dgnc/dgnc_neo.c | 22 +++--- > 1 file changed, 11 insertions(+), 11

Re: [PATCH 2/3] staging: dgnc: dgnc_cls.c: remove unnecessary parentheses

On Sat, Dec 16, 2017 at 10:16:00PM +0200, Kamal Heib wrote: > Cleanup the "Unnecessary parentheses around " checkpatch.pl error. > > Signed-off-by: Kamal Heib > --- > drivers/staging/dgnc/dgnc_cls.c | 16 > 1 file changed, 8 insertions(+), 8 deletions(-) >

Re: [PATCH 1/3] staging: dgnc: dgnc_tty.c: remove unnecessary parentheses

On Sat, Dec 16, 2017 at 10:15:59PM +0200, Kamal Heib wrote: > Cleanup the "Unnecessary parentheses around " checkpatch.pl error. > > Signed-off-by: Kamal Heib > --- > drivers/staging/dgnc/dgnc_tty.c | 38 +++--- > 1 file changed, 19

Re: [PATCH] Staging: Pi433: Bugfix for wrong argument for sizeof() in TX thread

On Mon, Dec 18, 2017 at 07:27:58PM +0200, Marcus Wolf wrote: > sizeof(array) != sizeof(pointer to array) > Fixes: "staging: pi433: reduce stack size in tx thread" > > Signed-off-by: Marcus Wolf This should be listed as: Fixes: 62f39d49d168 ("staging: pi433: reduce

Re: [PATCH 6/8 v4] staging: pi433: remove unused function

On Thu, Dec 14, 2017 at 04:20:20PM +0100, Valentin Vidic wrote: > As it turns out rf69_get_lna_gain is not used at all. > > Signed-off-by: Valentin Vidic > --- > v2: - drop change for SHIFT_DATAMODUL_MODULATION_TYPE > - move shifting to the header file > v3: - drop

Re: [PATCH v3] staging: comedi: ni_*: Fix style warnings.

On Thu, Dec 14, 2017 at 01:31:05AM -0600, Aniruddha Shastri wrote: > Two of these warnings are now line-too-long warnings. I think these > warnings are preferable to the ones listed below. The longest line is > only 85 chars wide, which is reasonable. > > Warnings fixed: > ni_atmio.c:239:

Re: [PATCH RFC 0/7] KVM: nVMX: enlightened VMCS initial implementation

Paolo Bonzini writes: > On 18/12/2017 18:17, Vitaly Kuznetsov wrote: >> The original author of these patches does no longer work at Red Hat, I >> agreed to take this over and send upstream. Here is his original >> description: >> >> "Makes KVM implement the enlightened VMCS

Re: [PATCH RFC 0/7] KVM: nVMX: enlightened VMCS initial implementation

On 18/12/2017 18:17, Vitaly Kuznetsov wrote: > The original author of these patches does no longer work at Red Hat, I > agreed to take this over and send upstream. Here is his original > description: > > "Makes KVM implement the enlightened VMCS feature per Hyper-V TLFS 5.0b. > I've measured

Re: [PATCH RFC 2/7] KVM: nVMX: modify vmcs12 fields to match Hyper-V enlightened VMCS

On 19/12/2017 13:25, Vitaly Kuznetsov wrote: > >> At this point in time, I don't think you can just blithely change the >> virtual VMCS layout and revision number. Existing VMs using the old >> layout and revision number must continue to work on versions of kvm >> past this point. You could tie

Re: [PATCH RFC 2/7] KVM: nVMX: modify vmcs12 fields to match Hyper-V enlightened VMCS

Jim Mattson writes: > At this point in time, I don't think you can just blithely change the > virtual VMCS layout and revision number. Existing VMs using the old > layout and revision number must continue to work on versions of kvm > past this point. You could tie the layout

Re: [PATCH v4 3/3] media: atomisp: delete empty default struct values.

On Sat, Dec 02, 2017 at 10:12:01PM +, Jeremy Sowden wrote: > Removing zero-valued struct-members left a number of the default > struct-values empty. These values have now been removed. > > Signed-off-by: Jeremy Sowden This one should be squashed as well. -- Sakari

Re: [PATCH v4 1/3] media: atomisp: convert default struct values to use compound-literals with designated initializers.

Hi Jeremy, On Sat, Dec 02, 2017 at 10:11:59PM +, Jeremy Sowden wrote: > The CSS API uses a lot of nested anonymous structs defined in object > macros to assign default values to its data-structures. These have been > changed to use compound-literals and designated initializers to make > them

Re: [PATCH v2 5/8] media: v4l2-mediabus: convert flags to enums and document them

On Tue, 2017-12-19 at 09:18 -0200, Mauro Carvalho Chehab wrote: > There is a mess with media bus flags: there are two sets of > flags, one used by parallel and ITU-R BT.656 outputs, > and another one for CSI2. > > Depending on the type, the same bit has different meanings. > > That's very

[PATCH v2 3/8] media: v4l2-async: simplify v4l2_async_subdev structure

The V4L2_ASYNC_MATCH_FWNODE match criteria requires just one struct to be filled (struct fwnode_handle). The V4L2_ASYNC_MATCH_DEVNAME match criteria requires just a device name. So, it doesn't make sense to enclose those into structs, as the criteria can go directly into the union. That makes

[PATCH v2 5/8] media: v4l2-mediabus: convert flags to enums and document them

There is a mess with media bus flags: there are two sets of flags, one used by parallel and ITU-R BT.656 outputs, and another one for CSI2. Depending on the type, the same bit has different meanings. That's very confusing, and counter-intuitive. So, split them into two sets of flags, inside an

Re: [PATCH 3/8] media: v4l2-async: simplify v4l2_async_subdev structure

On Mon, 2017-12-18 at 17:53 -0200, Mauro Carvalho Chehab wrote: > The V4L2_ASYNC_MATCH_FWNODE match criteria requires just one > struct to be filled (struct fwnode_handle). The V4L2_ASYNC_MATCH_DEVNAME > match criteria requires just a device name. > > So, it doesn't make sense to enclose those

Re: [PATCH V2] hyper-v: use GFP_KERNEL for hv_context.hv_numa_map

On 2017/12/19 1:05, Stephen Hemminger wrote: On Mon, 18 Dec 2017 17:02:52 +0800 Jia-Ju Bai wrote: The kzalloc function is called with GFP_ATOMIC. But according to driver call graph, it is not in atomic context, namely no spinlock is held nor in an interrupt handler.

Re: PROBLEM: 4.15.0-rc3 APIC causes lockups on Core 2 Duo laptop

Thank you! On Mon, Dec 18, 2017 at 11:11:31AM +0100, Pavel Machek wrote: > Hi! > On Mon 2017-12-18 03:20:11, Alexandru Chirvasitu wrote: > > Short description of the problem: latest rc kernel results in seemingly > > APIC-caused hard lockups, whereas latest stable kernel works fine. > > > > I

Re: [PATCH 3/8] media: v4l2-async: simplify v4l2_async_subdev structure

On Mon, Dec 18, 2017 at 05:53:57PM -0200, Mauro Carvalho Chehab wrote: > The V4L2_ASYNC_MATCH_FWNODE match criteria requires just one > struct to be filled (struct fwnode_handle). The V4L2_ASYNC_MATCH_DEVNAME > match criteria requires just a device name. > > So, it doesn't make sense to enclose