Add braces to certain "multiline" conditions where "multiline" means
including comments.
Signed-off-by: kballou
---
drivers/staging/xgifb/vb_setmode.c | 26 +-
1 file changed, 17 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/xgifb/vb_setmode.c
b/drivers/sta
This patch series fixes a number of checkpatch issues with the `xgifb`
driver in staging. This is my first patch set, so keeping it short
for learning.
In patches 2/3 and 3/3, there are a number of "CamelCase" and
"unnecessary parentheses" checks still failing. I'm not sure if I
should be fixing
Fix a number of checkpatch warnings in xgfib/vb_setmode.c about line
length being over 80 characters.
Signed-off-by: kballou
---
drivers/staging/xgifb/vb_setmode.c | 78 ++
1 file changed, 54 insertions(+), 24 deletions(-)
diff --git a/drivers/staging/xgifb/v
Correct minor checkpatch issues.
Signed-off-by: kballou
---
drivers/staging/xgifb/vb_table.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/xgifb/vb_table.h b/drivers/staging/xgifb/vb_table.h
index 0da63e1da32f..42ecf7fe6766 100644
--- a/drivers/staging/x
On Thu, Jan 11, 2018 at 11:15:31PM -0700, kballou wrote:
> Correct minor checkpatch issues.
>
> Signed-off-by: kballou
I need a "real" name here please. I doubt you sign legal documents this
way, right?
thanks,
greg k-h
___
devel mailing list
de...@
On Thu, Jan 11, 2018 at 10:21:09AM -0800, Eric Anholt wrote:
> Greg Kroah-Hartman writes:
>
> > Now that the SPDX tag is in all
> > drivers/staging/vc04_services/bcm2835-audio/ files, that identifies the
> > license in a specific and legally-defined manner. So the extra GPL text
> > wording can
On 01/10/2018 06:06 PM, Zengtao (B) wrote:
-邮件原件-
发件人: Laura Abbott [mailto:labb...@redhat.com]
发送时间: 2018年1月11日 8:01
收件人: Zengtao (B) ; Dan Carpenter
; Chenfeng (puck)
抄送: sumit.sem...@linaro.org; gre...@linuxfoundation.org;
a...@android.com; tk...@android.com; m...@android.com;
de...@d
Greg Kroah-Hartman writes:
> Now that the SPDX tag is in all
> drivers/staging/vc04_services/bcm2835-audio/ files, that identifies the
> license in a specific and legally-defined manner. So the extra GPL text
> wording can be removed as it is no longer needed at all.
>
> This is done on a quest
I've been working off and on with this. Since you're getting into the
counters in a couple of the patches, part of the reason for all the
#defines here are because MDC, MDT and OST counters are all shoved into
the same array dynamically, sometimes. It would be a much cleaner
approach to have a se
This patch right aligns all backslashes in multi-line macros
in obd_class.h for better readability.
Signed-off-by: Fabian Huegel
Signed-off-by: Christoph Volkert
---
drivers/staging/lustre/lustre/include/obd_class.h | 166 +++---
1 file changed, 83 insertions(+), 83 deletions(-)
Fixed four lines that went over the 80 character limit
to reduce checkpatch warnings.
Signed-off-by: Fabian Huegel
Signed-off-by: Christoph Volkert
---
drivers/staging/lustre/lustre/include/obd_class.h | 14 ++
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/drivers/s
This patch properly left aligns all member identifiers in every
struct defined in obd_class.h for better readability.
Signed-off-by: Fabian Huegel
Signed-off-by: Christoph Volkert
---
drivers/staging/lustre/lustre/include/obd_class.h | 44 +++
1 file changed, 22 insertions(+
Checkpatch was complaining about missing identifier names in function
declarations. So we added the missing names according to the names in
the respective function implementation. *obd_import* was sometimes named
*import* and sometimes *imp* (in genops.c), so to avoid confusion we just
named it imp
Some complex multi-line macros were not enclosed by a do-while(0),
so we fixed that.
Signed-off-by: Fabian Huegel
Signed-off-by: Christoph Volkert
---
drivers/staging/lustre/lustre/include/obd_class.h | 16
1 file changed, 12 insertions(+), 4 deletions(-)
diff --git a/drivers/
Most multi-line comments started on the first line, but the preferred
linux kernel style is to start multi-line comments on the second line.
Some comments became less readable after the change, so we changed them
to single-line comments.
Signed-off-by: Fabian Huegel
Signed-off-by: Christoph Volke
Checkpatch wants complex macros to be enclosed in parentheses, so we
put parentheses around these four macros.
Signed-off-by: Fabian Huegel
Signed-off-by: Christoph Volkert
---
drivers/staging/lustre/lustre/include/obd_class.h | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff
This macro was only used in four places to declare two variables.
It saved one line of code, but in our opinion hurt readability.
So we removed the macro, substituting every occurrence with the
declaration of the two variables (like the preprocessor would have done).
Signed-off-by: Fabian Huegel
We cleaned up a lot of checkpatch errors and warnings in obd_class.h,
but there are still some CHECKs and two warnings about flow control
inside macros left.
Changing those macros to inline functions would probably
be a good idea, unfortunatly it's not straightforward since they use
'#op' to print
Hi Ajay,
Just a little note for your future patches: all changes history would
be good to be kept here, something like this:
changes in v3: this, this and this
changes in v2: this and this
Thanks,
Claudiu
On 11.01.2018 16:12, Ajay Singh wrote:
> Changes since v2: Removed v2 patch number 3,4,5
No one needs to see this global variable, so make it static.
Cc: Lidza Louina
Cc: Mark Hounschell
Signed-off-by: Greg Kroah-Hartman
---
drivers/staging/dgnc/dgnc_driver.c | 2 +-
drivers/staging/dgnc/dgnc_driver.h | 1 -
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/sta
There's no need for this spinlock to be global, so make it a static
variable.
Cc: Lidza Louina
Cc: Mark Hounschell
Signed-off-by: Greg Kroah-Hartman
---
drivers/staging/dgnc/dgnc_driver.c | 2 +-
drivers/staging/dgnc/dgnc_driver.h | 1 -
2 files changed, 1 insertion(+), 2 deletions(-)
diff --
There were some global variables not being used at all, so just delete
them.
Cc: Lidza Louina
Cc: Mark Hounschell
Signed-off-by: Greg Kroah-Hartman
---
drivers/staging/dgnc/dgnc_driver.c | 1 -
drivers/staging/dgnc/dgnc_driver.h | 2 --
2 files changed, 3 deletions(-)
diff --git a/drivers/sta
There's no need for a special character device just to get some random
information out of a single serial port driver. So remove the
dgnc_mgmt.c file, and some structures and ioctl definitions that only it
was using.
Cc: Lidza Louina
Cc: Mark Hounschell
Signed-off-by: Greg Kroah-Hartman
---
d
There's no need for the world to know the number of dgnc boards in the
system, so just make it a static variable.
Cc: Lidza Louina
Cc: Mark Hounschell
Signed-off-by: Greg Kroah-Hartman
---
drivers/staging/dgnc/dgnc_driver.c | 2 +-
drivers/staging/dgnc/dgnc_driver.h | 1 -
2 files changed, 1 i
The dgnc driver defined numerous TTY defines that the core kernel
already defines. So just remove this duplication.
Cc: Lidza Louina
Cc: Mark Hounschell
Signed-off-by: Greg Kroah-Hartman
---
drivers/staging/dgnc/digi.h | 24
1 file changed, 24 deletions(-)
diff --git
There was just one function in it, and it duplicated what
msleep_interruptable() was doing, which is pointless, so delete it and
fix up the one calling site.
Cc: Lidza Louina
Cc: Mark Hounschell
Signed-off-by: Greg Kroah-Hartman
---
drivers/staging/dgnc/Makefile | 2 +-
drivers/staging/dg
2017-12-16 0:38 GMT+09:00 Masahiro Yamada :
> Commit 6341e62b212a ("kconfig: use bool instead of boolean for type
> definition attributes") did treewide replacement of 'boolean', and
> also mentioned the keyword 'boolean' would be dropped later on.
>
> Some years have passed, but it has not happene
This patch removes enum typedef BUS_RELEASE_T and define
"enum bus_release" to use instead of typedef.
checkpatch.pl not to add new typedef warning is fixed with this patch.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/wilc_wlan.c| 2 +-
drivers/staging/wilc1000/wilc_wlan_if.h | 4
This patch removes enum typedef BUS_ACQUIRE_T and define
enum bus_acquire to use instead of typedef.
checkpatch.pl not to add new typedef warning is fixed with this patch.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/wilc_wlan.c| 2 +-
drivers/staging/wilc1000/wilc_wlan_if.h | 4 +
This patch removes typedef from enum BSSTYPE_T and
rename it to bss_types.
It fixes "WARNING: do not add new typdefs" warning
reported by checkpatch.pl.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/host_interface.c | 2 +-
drivers/staging/wilc1000/wilc_wlan_if.h | 4 ++--
2 files ch
This patch removes enum typedef CHIP_PS_STATE_T and introduce
enum chip_ps_states to use instead of typedef.
checkpatch.pl not to add new typedef warning is fixed with this patch.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/wilc_wlan.c| 2 +-
drivers/staging/wilc1000/wilc_wlan_if
This patch removed the unnecessary enum typedef for BEACON_IE &
TX_RATE_T
It fix "WARNING: do not add new typedefs" reported by checkpatch.pl
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/wilc_wlan_if.h | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/
This patch has removed G_OPERATING_MODE_T typedef enum.
Now, its used as anonymous-enums for constants.
checkpatch.pl warning to avoid new typedef is fixes with this patch.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/wilc_wlan_if.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletion
Changes since v2: Removed v2 patch number 3,4,5 , where were handling
different changes under same subject line.
As those changes were independent, will work on those items and
send as separate patch later.
Ajay Singh (6):
staging: wilc1000: removed typedef from
There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.
Signed-off-by: Wei Yongjun
---
drivers/staging/ccree/cc_driver.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/ccree/cc_driver.c
b
On 01/11/2018 01:19 AM, Joe Perches wrote:
> On Wed, 2018-01-10 at 17:01 +, Luis de Bethencourt wrote:
>> On 01/10/2018 04:51 PM, Luis de Bethencourt wrote:
>>> Hi,
>>>
>>> Removing the last patch from the original series after Dan's comment.
>>>
>>> Tomorrow, I will send a new patch that remov
Am Donnerstag, 11. Januar 2018, 10:17:10 CET schrieb Gilad Ben-Yossef:
Hi Gilad,
> + // verify weak keys
> + if (ctx_p->flow_mode == S_DIN_to_DES) {
> + if (!des_ekey(tmp, key) &&
> + (crypto_tfm_get_flags(tfm) & CRYPTO_TFM_REQ_WEAK_KEY)) {
> +
It's good to have SPDX identifiers in all files to make it easier to
audit the kernel tree for correct licenses.
Fix up the remaining staging speakup files to have a proper SPDX
identifier, based on the license text in the file itself. The SPDX
identifier is a legally binding shorthand, which can
Now that the SPDX tag is in all drivers/staging/typec/ files, that
identifies the license in a specific and legally-defined manner. So the
extra GPL text wording can be removed as it is no longer needed at all.
This is done on a quest to remove the 700+ different ways that files in
the kernel des
It's good to have SPDX identifiers in all files to make it easier to
audit the kernel tree for correct licenses.
Fix up the bcm2835-camera driver to have a proper SPDX identifier, based
on the license text in the file itself. The SPDX identifier is a
legally binding shorthand, which can be used i
These lines are less than 80 characters so we don't need to break them
up into chunks.
Signed-off-by: Dan Carpenter
diff --git a/drivers/staging/ccree/cc_aead.c b/drivers/staging/ccree/cc_aead.c
index 265adffdab41..b58413172231 100644
--- a/drivers/staging/ccree/cc_aead.c
+++ b/drivers/staging/c
Now that the SPDX tag is in all fbtft files, that identifies the license
in a specific and legally-defined manner. So the extra GPL text wording
can be removed as it is no longer needed at all.
This is done on a quest to remove the 700+ different ways that files in
the kernel describe the GPL lic
Now that the SPDX tag is in the clocking-wizard driver files, that
identifies the license in a specific and legally-defined manner. So the
extra GPL text wording can be removed as it is no longer needed at all.
This is done on a quest to remove the 700+ different ways that files in
the kernel des
It's good to have SPDX identifiers in all files to make it easier to
audit the kernel tree for correct licenses.
Fix up the staging clocking-wizard driver to have a proper SPDX
identifier, based on the license text in the file itself. The SPDX
identifier is a legally binding shorthand, which can
Now that the SPDX tag is in all
drivers/staging/vc04_services/bcm2835-camera/ files, that identifies the
license in a specific and legally-defined manner. So the extra GPL text
wording can be removed as it is no longer needed at all.
This is done on a quest to remove the 700+ different ways that
It's good to have SPDX identifiers in all files to make it easier to
audit the kernel tree for correct licenses.
Fix up the staging fwserial driver to have a proper SPDX identifier,
based on the license text in the file itself. The SPDX identifier is a
legally binding shorthand, which can be used
Now that the SPDX tag is in all drivers/staging/vme/ files, that
identifies the license in a specific and legally-defined manner. So the
extra GPL text wording can be removed as it is no longer needed at all.
This is done on a quest to remove the 700+ different ways that files in
the kernel descr
Now that the SPDX tag is in all drivers/staging/speakup/ files, that
identifies the license in a specific and legally-defined manner. So the
extra GPL text wording can be removed as it is no longer needed at all.
This is done on a quest to remove the 700+ different ways that files in
the kernel d
Now that the SPDX tag is in all drivers/staging/octeon/ files, that
identifies the license in a specific and legally-defined manner. So the
extra GPL text wording can be removed as it is no longer needed at all.
This is done on a quest to remove the 700+ different ways that files in
the kernel de
Now that the SPDX tag is in all drivers/staging/dgnc files, that
identifies the license in a specific and legally-defined manner. So the
extra GPL text wording can be removed as it is no longer needed at all.
This is done on a quest to remove the 700+ different ways that files in
the kernel descr
It's good to have SPDX identifiers in all files to make it easier to
audit the kernel tree for correct licenses.
Fix up the staging emxx_udc driver to have a proper SPDX identifier,
based on the license text in the file itself. The SPDX identifier is a
legally binding shorthand, which can be used
Now that the SPDX tag is in all drivers/staging/fwserial/ files, that
identifies the license in a specific and legally-defined manner. So the
extra GPL text wording can be removed as it is no longer needed at all.
This is done on a quest to remove the 700+ different ways that files in
the kernel
Now that the SPDX tag is in the emxx_udc driver files, that identifies
the license in a specific and legally-defined manner. So the extra GPL
text wording can be removed as it is no longer needed at all.
This is done on a quest to remove the 700+ different ways that files in
the kernel describe t
It's good to have SPDX identifiers in all files to make it easier to
audit the kernel tree for correct licenses.
Fix up the staging octeon driver to have a proper SPDX identifier, based
on the license text in the file itself. The SPDX identifier is a
legally binding shorthand, which can be used i
Now that the SPDX tag is in all
drivers/staging/vc04_services/bcm2835-audio/ files, that identifies the
license in a specific and legally-defined manner. So the extra GPL text
wording can be removed as it is no longer needed at all.
This is done on a quest to remove the 700+ different ways that f
Now that the SPDX tag is in all drivers/staging/nvec/ files, that
identifies the license in a specific and legally-defined manner. So the
extra GPL text wording can be removed as it is no longer needed at all.
This is done on a quest to remove the 700+ different ways that files in
the kernel desc
It's good to have SPDX identifiers in all files to make it easier to
audit the kernel tree for correct licenses.
Fix up the bcm2835-audio driver to have a proper SPDX identifier, based
on the license text in the file itself. The SPDX identifier is a
legally binding shorthand, which can be used in
It's good to have SPDX identifiers in all files to make it easier to
audit the kernel tree for correct licenses.
Fix up the all of the staging fbtft drivers to have a proper SPDX
identifier, based on the license text in the file itself. The SPDX
identifier is a legally binding shorthand, which ca
It's good to have SPDX identifiers in all files to make it easier to
audit the kernel tree for correct licenses.
Fix up the staging dgnc driver to have a proper SPDX identifier, based
on the license text in the file itself. The SPDX identifier is a
legally binding shorthand, which can be used ins
It's good to have SPDX identifiers in all files to make it easier to
audit the kernel tree for correct licenses.
Fix up the drivers/staging/typec/ files to have a proper SPDX
identifier, based on the license text in the file itself. The SPDX
identifier is a legally binding shorthand, which can be
It's good to have SPDX identifiers in all files to make it easier to
audit the kernel tree for correct licenses.
Fix up the staging nvec driver to have a proper SPDX identifiers, based
on the license text in the file itself. The SPDX identifier is a
legally binding shorthand, which can be used in
It's good to have SPDX identifiers in all files to make it easier to
audit the kernel tree for correct licenses.
Fix up the remaining staging vme driver to have a proper SPDX
identifier, based on the license text in the file itself. The SPDX
identifier is a legally binding shorthand, which can be
On Thu, Jan 11, 2018 at 09:17:10AM +, Gilad Ben-Yossef wrote:
> Add CryptoCell ablkcipher support
>
Hello
I have some minor comments:
ablkcipher is deprecated, so you need to use skcipher instead.
> Signed-off-by: Gilad Ben-Yossef
> ---
> drivers/crypto/ccree/Makefile|2 +-
>
Update Arm TrustZone CryptoCell driver entry move into drivers/crypto/
Signed-off-by: Gilad Ben-Yossef
---
MAINTAINERS | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 1082846..560e068 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -3273,12
Add CryptoCell AEAD support
Signed-off-by: Gilad Ben-Yossef
---
drivers/crypto/ccree/Makefile|2 +-
drivers/crypto/ccree/cc_aead.c | 2702 ++
drivers/crypto/ccree/cc_aead.h | 109 ++
drivers/crypto/ccree/cc_buffer_mgr.c | 882 +++
Add FIPS mode support to CryptoCell driver
Signed-off-by: Gilad Ben-Yossef
---
drivers/crypto/ccree/Makefile| 1 +
drivers/crypto/ccree/cc_driver.c | 29 +-
drivers/crypto/ccree/cc_driver.h | 1 +
drivers/crypto/ccree/cc_fips.c | 112 +++
dr
Introduce basic low level Arm TrustZone CryptoCell HW support.
This first patch doesn't actually register any Crypto API
transformations, these will follow up in the next patch.
This first revision supports the CC 712 REE component.
Signed-off-by: Gilad Ben-Yossef
---
drivers/crypto/Kconfig
Add CryptoCell async. hash and HMAC support.
Signed-off-by: Gilad Ben-Yossef
---
drivers/crypto/ccree/Makefile|2 +-
drivers/crypto/ccree/cc_buffer_mgr.c | 257
drivers/crypto/ccree/cc_driver.c | 13 +
drivers/crypto/ccree/cc_driver.h |1 +
drivers/crypto/ccree/cc
Add CryptoCell ablkcipher support
Signed-off-by: Gilad Ben-Yossef
---
drivers/crypto/ccree/Makefile|2 +-
drivers/crypto/ccree/cc_buffer_mgr.c | 125
drivers/crypto/ccree/cc_buffer_mgr.h | 10 +
drivers/crypto/ccree/cc_cipher.c | 1167 ++
d
Remove the ccree driver from the staging tree in preparation to
introducing it in the crypto tree.
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/Kconfig|2 -
drivers/staging/Makefile |1 -
.../devicetree/bindings/crypto/arm-cryp
Arm TrustZone CryptoCell is a security hardware IP that
includes support for hardware based hash, digest, cipher
and AEAD operations. This driver provides support for
these as part of the Linux Crypto sub-system.
The driver spent some time now in the staging tree being
cleaned up and is now submit
Here are my remaining Smatch warnings:
drivers/staging/ccree/cc_driver.c:219 init_cc_resources()
error: '%pa' can only be followed by one of [dp]
drivers/staging/ccree/cc_driver.c
217
218 if (rc) {
219 dev_err(dev, "Failed in dma_set_mask, mask=%par\n"
The driver uses a mixture of signed and unsigned integer variables for
holding arrays lengths and indices, which gives rise to sparse warnings
when the addresses of signed variables are passed to functions expecting
pointers to unsigned integers. This patch-set fixes those warnings by
converting t
Replaced hard-coded indices used during initialization of array elements
with a variable which is incremented once initialization of each element
is complete.
Signed-off-by: Jeremy Sowden
---
drivers/staging/ccree/cc_aead.c | 48 +++--
1 file changed, 27 inser
This patch fixes sparse warnings arising when the addresses of signed
variables are passed to functions expecting pointers to unsigned
integers by converting those signed variables to unsigned as follows:
* changed the types of a number of index and length variables from
signed to unsigned i
On 2018-01-11, at 08:25:20 +0200, Gilad Ben-Yossef wrote:
> On Wed, Jan 10, 2018 at 3:33 PM, Jeremy Sowden wrote:
> > This patch fixes sparse warnings arising when the addresses of signed
> > variables are passed to functions expecting pointers to unsigned
> > integers by converting those signed v
76 matches
Mail list logo
