On 01/31/2018 03:00 PM, Greg KH wrote:
On Wed, Jan 31, 2018 at 02:03:42PM +0200, Alexey Skidanov wrote:
Any driver may access shared buffers, created by ion, using dma_buf_vmap and
dma_buf_vunmap dma-buf API that maps/unmaps previosuly allocated buffers into
the kernel virtual address space. Th
Removed parenthesis causing a coding style warning.
Signed-off-by: Quytelda Kahja
---
drivers/staging/fwserial/dma_fifo.c | 2 +-
drivers/staging/fwserial/fwserial.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/fwserial/dma_fifo.c
b/drivers/staging/fwse
ion_page_pool.c now is used to apply pool APIs for system heap, which do
not need do any initial at device_initcall. Therefore ion_page_pool_init
can be nuked.
Signed-off-by: Yisheng Xie
---
drivers/staging/android/ion/ion_page_pool.c | 7 ---
1 file changed, 7 deletions(-)
diff --git a/dri
ion_buffer_fault_user_mappings's definition has been removed and not be
used anymore, just remove its useless declaration.
Signed-off-by: Yisheng Xie
---
drivers/staging/android/ion/ion.h | 9 -
1 file changed, 9 deletions(-)
diff --git a/drivers/staging/android/ion/ion.h
b/drivers/sta
After rewrite of ion_page_pool, some of its include file is no need
anymore, just remove it.
Signed-off-by: Yisheng Xie
---
drivers/staging/android/ion/ion_page_pool.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/android/ion/ion_page_pool.c
b/drivers/staging/android/io
Hi Greg,
On 2018/1/31 19:32, Greg KH wrote:
> On Wed, Jan 31, 2018 at 05:50:52PM +0800, Yisheng Xie wrote:
>> ion_page_pool.c now is used to apply pool APIs for system heap, which do
>> not need do any initial at device_initcall.
>>
>> Meanwhile, this patch also remove some useless include files.
On Wed, 31 Jan 2018 12:16:49 +0100
Mohammed Gamal wrote:
> On Tue, 2018-01-30 at 11:29 -0800, Stephen Hemminger wrote:
> > On Tue, 23 Jan 2018 10:34:04 +0100
> > Mohammed Gamal wrote:
> >
> > > Split each of the functions into two for each of send/recv buffers
> > >
> > > Signed-off-by: Moha
> Subject: RE: [PATCH 1/1] scsi: storvsc: Spread interrupts when picking a
> channel for I/O requests
>
> > From: Long Li
> > Sent: Wednesday, January 31, 2018 12:23 PM
> > To: Michael Kelley (EOSG) ; KY
> > Srinivasan ; Stephen Hemminger
> > ; martin.peter...@oracle.com;
> > de...@linuxdriverproj
> From: Long Li
> Sent: Wednesday, January 31, 2018 12:23 PM
> To: Michael Kelley (EOSG) ; KY Srinivasan
> ; Stephen Hemminger ;
> martin.peter...@oracle.com; de...@linuxdriverproject.org;
> linux-ker...@vger.kernel.org;
> linux-s...@vger.kernel.org; James E . J . Bottomley
> Subject: RE: [PATCH
> Subject: RE: [PATCH 1/1] scsi: storvsc: Spread interrupts when picking a
> channel for I/O requests
>
> Updated/corrected two email addresses ...
>
> > -Original Message-
> > From: Michael Kelley (EOSG)
> > Sent: Wednesday, January 24, 2018 2:14 PM
> > To: KY Srinivasan ; Stephen Hemmin
Looks good to me.
On Tue, Jan 30, 2018 at 11:11 PM, Eric Biggers wrote:
> From: Eric Biggers
>
> If the kzalloc() in binder_get_thread() fails, binder_poll()
> dereferences the resulting NULL pointer.
>
> Fix it by returning POLLERR if the memory allocation failed.
>
> This bug was found by syzk
> -Original Message-
> From: Michael Kelley (EOSG)
> Sent: Wednesday, January 24, 2018 2:50 PM
> To: KY Srinivasan ; Stephen Hemminger
> ; martin.peter...@oracle.com; Long Li
> ; j...@linux.vnet.ibm.com;
> de...@linuxdriverproject.org; linux-ker...@vger.kernel.org; linux-
> s...@vger.kern
The driver no longer needs to include drivers/staging/unisys/include, so we
can get rid of it.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorinput/Makefile | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/unisys/visorinput/Makefile
b/driv
Checkpatch was giving errors about an open parenthesis being the last thing
on a line. This patch cleans up some names and removes the checkpatch
warnings.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorinput/visorinput.c | 19 +--
1 file cha
Miscellaneous patches to the visorinput driver.
David Kershner (5):
staging: unisys: visorinput: Clean up Makefile includes
staging: unisys: visorinput: remove duplicate comments
staging: unisys: visorinput: combine ultrainputreport.h with visorinput.c
staging: unisys: visorinput: Fix spac
From: Tim Sell
Previously, we used a hack to determine the max x,y resolution of the
visor virtual mouse: we just looked at the resolution of the
first-registered framebuffer device, using the currently-valid assumption
that in a Unisys s-Par guest environment the video will be provided by an
efi
Comments were based on individual entries, if we group the entries, we can
get rid of duplicate comments.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorinput/ultrainputreport.h | 16 +
1 file changed, 7 insertions(+), 9 deletions(-)
diff --git
Several of the comments in the code were not using the full 80 characters
of the screen. This patch combines the lines to make full use of the
screen.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorinput/visorinput.c | 64 ---
1 file changed,
The file ultrainputreport.h was just being used by visorinput.c. Move the
definitions into visorinput.c and get rid of the file.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorinput/ultrainputreport.h | 55 +-
drivers/staging/unisys/visorinput/vi
Hello Hans de Goede,
The patch 554c0a3abf21: "staging: Add rtl8723bs sdio wifi driver"
from Mar 29, 2017, leads to the following static checker warning:
drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c:1374
_PHY_PathADDAOn8723B()
warn: both sides of ternary the same: '29360148' 0x0
On Wed, Jan 31, 2018 at 01:00:35PM +0100, Dmitry Vyukov wrote:
> On Wed, Jan 31, 2018 at 9:08 AM, Dan Carpenter
> wrote:
> > On Tue, Jan 30, 2018 at 11:59:47PM -0800, Eric Biggers wrote:
> >> On Fri, Dec 01, 2017 at 04:22:00PM -0800, syzbot wrote:
> >> > syzkaller has found reproducer for the fol
On Wed, Jan 31, 2018 at 02:03:42PM +0200, Alexey Skidanov wrote:
> Any driver may access shared buffers, created by ion, using dma_buf_vmap and
> dma_buf_vunmap dma-buf API that maps/unmaps previosuly allocated buffers into
> the kernel virtual address space. The implementation of these API is miss
Any driver may access shared buffers, created by ion, using dma_buf_vmap and
dma_buf_vunmap dma-buf API that maps/unmaps previosuly allocated buffers into
the kernel virtual address space. The implementation of these API is missing in
the current ion implementation.
Signed-off-by: Alexey Skidanov
On Wed, Jan 31, 2018 at 05:50:52PM +0800, Yisheng Xie wrote:
> ion_page_pool.c now is used to apply pool APIs for system heap, which do
> not need do any initial at device_initcall.
>
> Meanwhile, this patch also remove some useless include files.
Please only do one thing per patch, otherwise if
On Tue, 2018-01-30 at 11:29 -0800, Stephen Hemminger wrote:
> On Tue, 23 Jan 2018 10:34:04 +0100
> Mohammed Gamal wrote:
>
> > Split each of the functions into two for each of send/recv buffers
> >
> > Signed-off-by: Mohammed Gamal
>
> Splitting these functions is not necessary
How so? We nee
On Wed, Jan 31, 2018 at 10:52:08AM +0100, Ulf Magnusson wrote:
> On Wed, Jan 31, 2018 at 9:46 AM, Dan Carpenter
> wrote:
> > On Wed, Jan 31, 2018 at 09:41:24AM +0100, Ulf Magnusson wrote:
> >> On Wed, Jan 31, 2018 at 9:06 AM, Dan Carpenter
> >> wrote:
> >> > On Tue, Jan 30, 2018 at 08:05:27PM +
ion_page_pool.c now is used to apply pool APIs for system heap, which do
not need do any initial at device_initcall.
Meanwhile, this patch also remove some useless include files.
Signed-off-by: Yisheng Xie
---
drivers/staging/android/ion/ion_page_pool.c | 11 ---
1 file changed, 11 dele
On Wed, Jan 31, 2018 at 9:46 AM, Dan Carpenter wrote:
> On Wed, Jan 31, 2018 at 09:41:24AM +0100, Ulf Magnusson wrote:
>> On Wed, Jan 31, 2018 at 9:06 AM, Dan Carpenter
>> wrote:
>> > On Tue, Jan 30, 2018 at 08:05:27PM +0100, Ulf Magnusson wrote:
>> >> In preparation for adding a warning ("kconf
Blank help texts are probably either a typo, a Kconfig misunderstanding,
or some kind of half-committing to adding a help text (in which case a
TODO comment would be clearer, if the help text really can't be added
right away).
Best to remove them, IMO.
Signed-off-by: Ulf Magnusson
---
drivers/s
Blank help texts are probably either a typo, a Kconfig misunderstanding,
or some kind of half-committing to adding a help text (in which case a
TODO comment would be clearer, if the help text really can't be added
right away).
Best to remove them, IMO.
Signed-off-by: Ulf Magnusson
---
drivers/s
On Wed, Jan 31, 2018 at 09:41:24AM +0100, Ulf Magnusson wrote:
> On Wed, Jan 31, 2018 at 9:06 AM, Dan Carpenter
> wrote:
> > On Tue, Jan 30, 2018 at 08:05:27PM +0100, Ulf Magnusson wrote:
> >> In preparation for adding a warning ("kconfig: Warn if help text is
> >> blank"): https://lkml.org/lkml/
On Sun, Jan 28, 2018 at 12:41:25PM -0600, Larry Finger wrote:
> On 01/28/2018 08:05 AM, Erik Liodden wrote:
> > Add identifier names to function definition arguments to comply with
> > the kernel coding style and the naming convention in the rest of the
> > file.
> >
> > Issues found by checkpatch
On Wed, Jan 31, 2018 at 9:06 AM, Dan Carpenter wrote:
> On Tue, Jan 30, 2018 at 08:05:27PM +0100, Ulf Magnusson wrote:
>> In preparation for adding a warning ("kconfig: Warn if help text is
>> blank"): https://lkml.org/lkml/2018/1/30/516
>>
>
> Please don't start the boddy of the email in the midd
On Wed, Jan 31, 2018 at 07:19:05PM +1300, Shannon Booth wrote:
> Fixed a coding style issue.
>
> Signed-off-by: Shannon Booth
> ---
> drivers/staging/speakup/main.c | 9 ++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/speakup/main.c b/drivers/staging
On Wed, Jan 31, 2018 at 01:44:47AM +0200, alexey wrote:
>
>
> On 01/31/2018 12:15 AM, Greg KH wrote:
> > On Tue, Jan 30, 2018 at 10:39:13PM +0200, Alexey Skidanov wrote:
> > > dma_buf_vmap and dma_buf_vunmap allow drivers to access buffers, created
> > > by ion.
> > But why would anyone ever wan
On Tue, Jan 30, 2018 at 11:59:47PM -0800, Eric Biggers wrote:
> On Fri, Dec 01, 2017 at 04:22:00PM -0800, syzbot wrote:
> > syzkaller has found reproducer for the following crash on
> > 3c1c4ddffb58b9e10b3365764fe59546130b3f32
> > git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/mas
On Tue, Jan 30, 2018 at 08:05:27PM +0100, Ulf Magnusson wrote:
> In preparation for adding a warning ("kconfig: Warn if help text is
> blank"): https://lkml.org/lkml/2018/1/30/516
>
Please don't start the boddy of the email in the middle of a sentence.
It looks like this:
https://marc.info/?l=l
On Fri, Dec 01, 2017 at 04:22:00PM -0800, syzbot wrote:
> syzkaller has found reproducer for the following crash on
> 3c1c4ddffb58b9e10b3365764fe59546130b3f32
> git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/master
> compiler: gcc (GCC) 7.1.1 20170620
> .config is attached
> Raw c
The point is that you have to send a v3 patch which includes that
information. And please CC all the android folk as well.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listin
39 matches
Mail list logo