[PATCH 0/3] Initial driver support for Xilinx M2M Video Scaler

2018-02-20 Thread Rohit Athavale 
This patch series has three commits :
 - Driver support for the Xilinx M2M Video Scaler IP
 - TODO document
 - DT binding doc

Changes in HW register map is expected as the IP undergoes changes.
This is a first attempt at the driver as an early prototype.

This is a M2M Video Scaler IP that uses polyphases filters to perform
video scaling. The driver will be used by an application like a
gstreamer plugin.

Rohit Athavale (3):
  staging: xm2mvscale: Driver support for Xilinx M2M Video Scaler
  staging: xm2mvscale: Add TODO for the driver
  Documentation: devicetree: bindings: Add DT binding doc for xm2mvsc
driver

 drivers/staging/Kconfig|   2 +
 drivers/staging/Makefile   |   1 +
 .../devicetree/bindings/xm2mvscaler.txt|  25 +
 drivers/staging/xm2mvscale/Kconfig |  12 +
 drivers/staging/xm2mvscale/Makefile|   3 +
 drivers/staging/xm2mvscale/TODO|  15 +
 drivers/staging/xm2mvscale/ioctl_xm2mvsc.h | 134 +++
 drivers/staging/xm2mvscale/scaler_hw_xm2m.c| 945 +
 drivers/staging/xm2mvscale/scaler_hw_xm2m.h| 152 
 drivers/staging/xm2mvscale/xm2m_vscale.c   | 783 +
 drivers/staging/xm2mvscale/xvm2mvsc_hw_regs.h  | 204 +
 11 files changed, 2276 insertions(+)
 create mode 100644 
drivers/staging/xm2mvscale/Documentation/devicetree/bindings/xm2mvscaler.txt
 create mode 100644 drivers/staging/xm2mvscale/Kconfig
 create mode 100644 drivers/staging/xm2mvscale/Makefile
 create mode 100644 drivers/staging/xm2mvscale/TODO
 create mode 100644 drivers/staging/xm2mvscale/ioctl_xm2mvsc.h
 create mode 100644 drivers/staging/xm2mvscale/scaler_hw_xm2m.c
 create mode 100644 drivers/staging/xm2mvscale/scaler_hw_xm2m.h
 create mode 100644 drivers/staging/xm2mvscale/xm2m_vscale.c
 create mode 100644 drivers/staging/xm2mvscale/xvm2mvsc_hw_regs.h

--
1.9.1

This email and any attachments are intended for the sole use of the named 
recipient(s) and contain(s) confidential information that may be proprietary, 
privileged or copyrighted under applicable law. If you are not the intended 
recipient, do not read, copy, or forward this email message or any attachments. 
Delete this email message and any attachments immediately.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 3/3] Documentation: devicetree: bindings: Add DT binding doc for xm2mvsc driver

2018-02-20 Thread Rohit Athavale 
This commit adds the binding doc for the DT that the driver expects.
Driver has been tested against Zynq US+ board.

Signed-off-by: Rohit Athavale 
---
 .../devicetree/bindings/xm2mvscaler.txt| 25 ++
 1 file changed, 25 insertions(+)
 create mode 100644 
drivers/staging/xm2mvscale/Documentation/devicetree/bindings/xm2mvscaler.txt

diff --git 
a/drivers/staging/xm2mvscale/Documentation/devicetree/bindings/xm2mvscaler.txt 
b/drivers/staging/xm2mvscale/Documentation/devicetree/bindings/xm2mvscaler.txt
new file mode 100644
index 000..1f3d805
--- /dev/null
+++ 
b/drivers/staging/xm2mvscale/Documentation/devicetree/bindings/xm2mvscaler.txt
@@ -0,0 +1,25 @@
+Xilinx M2M Video Scaler
+---
+This document describes the DT bindings required by the
+Xilinx M2M Video Scaler driver.
+
+Required Properties:
+- compatible   : Must be "xlnx,v-m2m-scaler"
+- reg  : Memory map for module access
+- reset-gpios  : Should contain GPIO reset phandle
+- interrupt-parent : Interrupt controller the interrupt is routed through
+- interrupts   : Should contain DMA channel interrupt
+- xlnx,scaler-num-taps : The number of filter taps for scaling filter
+- xlnx,scaler-max-chan : The maximum number of supported scaling channels
+
+Examples
+-
+   v_multi_scaler: v_multi_scaler@a000 {
+   compatible = "xlnx,v-m2m-scaler";
+   reg = <0x0 0xa000 0x0 0x1>;
+   reset-gpios = < 78 1>;
+   interrupt-parent = <>;
+   interrupts = <0 89 4>;
+   xlnx,scaler-num-taps = <6>;
+   xlnx,scaler-max-chan = <4>;
+   };
--
1.9.1

This email and any attachments are intended for the sole use of the named 
recipient(s) and contain(s) confidential information that may be proprietary, 
privileged or copyrighted under applicable law. If you are not the intended 
recipient, do not read, copy, or forward this email message or any attachments. 
Delete this email message and any attachments immediately.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 1/3] staging: xm2mvscale: Driver support for Xilinx M2M Video Scaler

2018-02-20 Thread Rohit Athavale 
This commit adds driver support for the pre-release Xilinx M2M Video
Scaler IP. There are three parts to this driver :

 - The Hardware/IP layer that reads and writes register of the IP
   contained in the scaler_hw_xm2m.c
 - The set of ioctls that applications would need to know contained
   in ioctl_xm2mvsc.h
 - The char driver that consumes the IP layer in xm2m_vscale.c

Signed-off-by: Rohit Athavale 
---
 drivers/staging/Kconfig   |   2 +
 drivers/staging/Makefile  |   1 +
 drivers/staging/xm2mvscale/Kconfig|  12 +
 drivers/staging/xm2mvscale/Makefile   |   3 +
 drivers/staging/xm2mvscale/ioctl_xm2mvsc.h| 134 
 drivers/staging/xm2mvscale/scaler_hw_xm2m.c   | 945 ++
 drivers/staging/xm2mvscale/scaler_hw_xm2m.h   | 152 +
 drivers/staging/xm2mvscale/xm2m_vscale.c  | 783 +
 drivers/staging/xm2mvscale/xvm2mvsc_hw_regs.h | 204 ++
 9 files changed, 2236 insertions(+)
 create mode 100644 drivers/staging/xm2mvscale/Kconfig
 create mode 100644 drivers/staging/xm2mvscale/Makefile
 create mode 100644 drivers/staging/xm2mvscale/ioctl_xm2mvsc.h
 create mode 100644 drivers/staging/xm2mvscale/scaler_hw_xm2m.c
 create mode 100644 drivers/staging/xm2mvscale/scaler_hw_xm2m.h
 create mode 100644 drivers/staging/xm2mvscale/xm2m_vscale.c
 create mode 100644 drivers/staging/xm2mvscale/xvm2mvsc_hw_regs.h

diff --git a/drivers/staging/Kconfig b/drivers/staging/Kconfig
index e95ab68..3ee3a3e 100644
--- a/drivers/staging/Kconfig
+++ b/drivers/staging/Kconfig
@@ -122,4 +122,6 @@ source "drivers/staging/vboxvideo/Kconfig"

 source "drivers/staging/pi433/Kconfig"

+source "drivers/staging/xm2mvscale/Kconfig"
+
 endif # STAGING
diff --git a/drivers/staging/Makefile b/drivers/staging/Makefile
index af8cd6a..29ce417 100644
--- a/drivers/staging/Makefile
+++ b/drivers/staging/Makefile
@@ -52,3 +52,4 @@ obj-$(CONFIG_BCM2835_VCHIQ)   += vc04_services/
 obj-$(CONFIG_CRYPTO_DEV_CCREE) += ccree/
 obj-$(CONFIG_DRM_VBOXVIDEO)+= vboxvideo/
 obj-$(CONFIG_PI433)+= pi433/
+obj-$(CONFIG_XILINX_M2M_VSC)   += xm2mvscale/
diff --git a/drivers/staging/xm2mvscale/Kconfig 
b/drivers/staging/xm2mvscale/Kconfig
new file mode 100644
index 000..68ccbca
--- /dev/null
+++ b/drivers/staging/xm2mvscale/Kconfig
@@ -0,0 +1,12 @@
+config XILINX_M2M_VSC
+   tristate "Xilinx M2M Video Scaler"
+   depends on ARCH_ZYNQMP && OF
+   select DMA_SHARED_BUFFER
+   ---help---
+ This driver is developed for Xilinx M2M Video Scaler IP,
+ designed to allow passage of frame buffers from the source
+ kernel sub-system, apply video scaling and forward to the
+ sink kernel sub-system.
+
+ To compile this driver as a module, choose M here.
+ If unsure, choose N.
diff --git a/drivers/staging/xm2mvscale/Makefile 
b/drivers/staging/xm2mvscale/Makefile
new file mode 100644
index 000..ec777e1
--- /dev/null
+++ b/drivers/staging/xm2mvscale/Makefile
@@ -0,0 +1,3 @@
+xm2m_vscale_drv-y := scaler_hw_xm2m.o
+xm2m_vscale_drv-y += xm2m_vscale.o
+obj-$(CONFIG_XILINX_M2M_VSC) += xm2m_vscale_drv.o
diff --git a/drivers/staging/xm2mvscale/ioctl_xm2mvsc.h 
b/drivers/staging/xm2mvscale/ioctl_xm2mvsc.h
new file mode 100644
index 000..03bd7ab
--- /dev/null
+++ b/drivers/staging/xm2mvscale/ioctl_xm2mvsc.h
@@ -0,0 +1,134 @@
+/*
+ * Xilinx Memory-to-Memory Video Scaler IP
+ *
+ * Copyright (C) 2018 Xilinx, Inc. All rights reserved.
+ *
+ * SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note
+ */
+#ifndef __IOCTL_XM2MVSC_H__
+#define __IOCTL_XM2MVSC_H__
+
+/* Xilinx Video Specific Color/Pixel Formats */
+enum xm2mvsc_pix_fmt {
+   XILINX_FRMBUF_FMT_RGBX8 = 10,
+   XILINX_FRMBUF_FMT_YUVX8,
+   XILINX_FRMBUF_FMT_YUYV8,
+   XILINX_FRMBUF_FMT_RGBA8,
+   XILINX_FRMBUF_FMT_YUVA8,
+   XILINX_FRMBUF_FMT_RGBX10,
+   XILINX_FRMBUF_FMT_YUVX10,
+   /* RGB565 takes the value of 17 */
+   XILINX_FRMBUF_FMT_Y_UV8 = 18,
+   XILINX_FRMBUF_FMT_Y_UV8_420,
+   XILINX_FRMBUF_FMT_RGB8,
+   XILINX_FRMBUF_FMT_YUV8,
+   XILINX_FRMBUF_FMT_Y_UV10,
+   XILINX_FRMBUF_FMT_Y_UV10_420,
+   XILINX_FRMBUF_FMT_Y8,
+   XILINX_FRMBUF_FMT_Y10,
+   XILINX_FRMBUF_FMT_BGRA8,
+   XILINX_FRMBUF_FMT_BGRX8,
+   XILINX_FRMBUF_FMT_UYVY8,
+   XILINX_FRMBUF_FMT_BGR8,
+};
+
+/* struct xm2mvsc_qdata - Struct to enqueue a descriptor
+ * @srcbuf_ht: Height of source buffer
+ * @srcbuf_wt: Width of source buffer
+ * @srcbuf_bpp: Bytes per pixel of source buffer
+ * @srcbuf_cft: Color/Pixel format of source buffer
+ * @srcbuf_size: Size of the source buffer requested
+ * @srcbuf_mmap: Identify if srcbuf is mmap'ed
+ * @srcbuf_stride: Stride of the source buffer
+ * @dstbuf_ht: Height of destination buffer
+ * @dstbuf_wt: Width of destination buffer
+ * @dstbuf_bpp: Bytes per pixel of destination buffer
+ * @dstbuf_cft: Color/Pixel format

[PATCH 2/3] staging: xm2mvscale: Add TODO for the driver

2018-02-20 Thread Rohit Athavale 
This commit highlights the key functionalities that will be
improved upon in a future patch set.

Signed-off-by: Rohit Athavale 
---
 drivers/staging/xm2mvscale/TODO | 15 +++
 1 file changed, 15 insertions(+)
 create mode 100644 drivers/staging/xm2mvscale/TODO

diff --git a/drivers/staging/xm2mvscale/TODO b/drivers/staging/xm2mvscale/TODO
new file mode 100644
index 000..ba5fd23
--- /dev/null
+++ b/drivers/staging/xm2mvscale/TODO
@@ -0,0 +1,15 @@
+* Possible remaining coding style fix.
+* Add support for DMABUF.
+* This is an early prototype, hardware register map changes are expected.
+* Update driver for 64-bit DMA address once the new Xilinx M2M Scaler IP
+  has support for 64-bit DMA Addresses. Current IP supports 32-bit DMA 
addresses.
+* Remove deadcode.
+* Add documents in Documentation beyond the DT binding doc.
+* This needs a home  in the proper drivers area (example : drivers/misc/),
+  once the quality of the driver is improved. Suggestions about where
+  it should be placed are welcome.
+* The IOCTL header could be moved to an uapi/* area once this is out of 
staging.
+
+Please send any patches to:
+Greg Kroah-Hartman  and Rohit Athavale 
+
--
1.9.1

This email and any attachments are intended for the sole use of the named 
recipient(s) and contain(s) confidential information that may be proprietary, 
privileged or copyrighted under applicable law. If you are not the intended 
recipient, do not read, copy, or forward this email message or any attachments. 
Delete this email message and any attachments immediately.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Apply for a Loan Access Fund

2018-02-20 Thread Apply for a Loan 
Constant Contact

Do you need a loan,You want to pay off bills, Expand your business? Look no 
further we offer all kinds of loans both long and short term loan.

Multi-component loans:
We specialize in investments in private sectors within our financial Investment 
services are M development and management, financial and operational 
management, due diligence and capital planning and development.

We also finance multi-component, multi annual investment program using a single 
“framework loan”. This funds a range of projects, usually by a national or 
local public sector body, most frequently regarding infrastructure, energy, oil 
and gas, efficiency/renewable, transport and urban renovation, real 
estate,emerging markets and high-technology,communications, software and 
digital content and services.

Conditions:
The project must be in line with our lending objectives and must be 
economically, financially, technically and environmentally sound. Financing 
conditions depend on the investment loan type and the security offered because 
our loans investment program is a strategic firm specializing in financial 
growth and loans/debt funding platform.

We've developed a lending program that makes it easy for us to meet our 
clients' loan investment borrowing needs. We grant loans from a minimum range 
of 100,000 US Dollars (One Hundred Thousand US Dollars ) to maximum 100Million 
US Dollars ( One Hundred Million US Dollars ) on any viable projects presented 
by your management after independent review on your business project BP model 
presentation.

Repayment:
Loan repayment is normally on a semi-annual or annual basis. Grace periods for 
capital repayment may be granted for a project’s construction phase of one year 
defer grace period for  Re-payment.

Interest rates:
Interest rates can be fixed, floating, revisable or convertible (i.e. allowing 
for a change of interest rate formula during the lifetime of a loan at 
predetermined periods) we offer all kinds of loans both long and short term 
loan for only 2% interest rate.

We intend to maintain a silent/financial position on our business with you or 
your company. If you are seriously interested with our offer we look forward to 
your favorable response.

We look forward to your favorable response.
Regards,
Bharat Kannan
Loan Agent
Pemail: bharatkexpatcen...@aol.com
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH-next] staging: rtl8188eu: Remove unneeded cast

2018-02-20 Thread Larry Finger 

On 02/20/2018 10:37 AM, Christopher Diaz Riveros wrote:

Fix Coccinelle alert:

drivers/staging//rtl8188eu/os_dep/usb_intf.c:336:13-27: WARNING: casting value 
returned by memory allocation function to (struct adapter *) is useless.

This issue was detected by using the Coccinelle software.

Signed-off-by: Christopher Diaz Riveros 


Acked-by: Larry Finger 



---
  drivers/staging/rtl8188eu/os_dep/usb_intf.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8188eu/os_dep/usb_intf.c 
b/drivers/staging/rtl8188eu/os_dep/usb_intf.c
index 32c7225a831e..127ecf896fc9 100644
--- a/drivers/staging/rtl8188eu/os_dep/usb_intf.c
+++ b/drivers/staging/rtl8188eu/os_dep/usb_intf.c
@@ -333,7 +333,7 @@ static struct adapter *rtw_usb_if1_init(struct dvobj_priv 
*dvobj,
struct net_device *pmondev;
int status = _FAIL;
  
-	padapter = (struct adapter *)vzalloc(sizeof(*padapter));

+   padapter = vzalloc(sizeof(*padapter));
if (padapter == NULL)
goto exit;
padapter->dvobj = dvobj;



___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

RE: [PATCH] X86/UAPI: Use __u64 instead of u64 in hyperv.h

2018-02-20 Thread KY Srinivasan 


> -Original Message-
> From: KarimAllah Ahmed 
> Sent: Monday, February 19, 2018 11:40 PM
> To: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org;
> x...@kernel.org
> Cc: KarimAllah Ahmed ; KY Srinivasan
> ; Haiyang Zhang ; Stephen
> Hemminger ; Thomas Gleixner
> ; Ingo Molnar ; H . Peter Anvin
> 
> Subject: [PATCH] X86/UAPI: Use __u64 instead of u64 in hyperv.h
> 
> ... since u64 has a hidden header dependency that was not there before
> using it (i.e. it breaks our VMM build). Also, __u64 is the right way to
> expose the data type through UAPI.
> 
> Fixes: 93286261 ("x86/hyperv: Reenlightenment notifications support")
> Signed-off-by: KarimAllah Ahmed 
> Cc: K. Y. Srinivasan 
> Cc: Haiyang Zhang 
> Cc: Stephen Hemminger 
> Cc: Thomas Gleixner 
> Cc: Ingo Molnar 
> Cc: H. Peter Anvin 
> Cc: x...@kernel.org
> Cc: de...@linuxdriverproject.org
> Cc: linux-ker...@vger.kernel.org

Acked-by: K. Y. Srinivasan 
> ---
>  arch/x86/include/uapi/asm/hyperv.h | 18 +-
>  1 file changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/arch/x86/include/uapi/asm/hyperv.h
> b/arch/x86/include/uapi/asm/hyperv.h
> index 197c2e6..0994143 100644
> --- a/arch/x86/include/uapi/asm/hyperv.h
> +++ b/arch/x86/include/uapi/asm/hyperv.h
> @@ -241,24 +241,24 @@
>  #define HV_X64_MSR_REENLIGHTENMENT_CONTROL   0x4106
> 
>  struct hv_reenlightenment_control {
> - u64 vector:8;
> - u64 reserved1:8;
> - u64 enabled:1;
> - u64 reserved2:15;
> - u64 target_vp:32;
> + __u64 vector:8;
> + __u64 reserved1:8;
> + __u64 enabled:1;
> + __u64 reserved2:15;
> + __u64 target_vp:32;
>  };
> 
>  #define HV_X64_MSR_TSC_EMULATION_CONTROL 0x4107
>  #define HV_X64_MSR_TSC_EMULATION_STATUS  0x4108
> 
>  struct hv_tsc_emulation_control {
> - u64 enabled:1;
> - u64 reserved:63;
> + __u64 enabled:1;
> + __u64 reserved:63;
>  };
> 
>  struct hv_tsc_emulation_status {
> - u64 inprogress:1;
> - u64 reserved:63;
> + __u64 inprogress:1;
> + __u64 reserved:63;
>  };
> 
>  #define HV_X64_MSR_HYPERCALL_ENABLE  0x0001
> --
> 2.7.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH-next] staging: rtl8188eu: Remove unneeded cast

2018-02-20 Thread Christopher Diaz Riveros 
Fix Coccinelle alert:

drivers/staging//rtl8188eu/os_dep/usb_intf.c:336:13-27: WARNING: casting value 
returned by memory allocation function to (struct adapter *) is useless.

This issue was detected by using the Coccinelle software.

Signed-off-by: Christopher Diaz Riveros 
---
 drivers/staging/rtl8188eu/os_dep/usb_intf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8188eu/os_dep/usb_intf.c 
b/drivers/staging/rtl8188eu/os_dep/usb_intf.c
index 32c7225a831e..127ecf896fc9 100644
--- a/drivers/staging/rtl8188eu/os_dep/usb_intf.c
+++ b/drivers/staging/rtl8188eu/os_dep/usb_intf.c
@@ -333,7 +333,7 @@ static struct adapter *rtw_usb_if1_init(struct dvobj_priv 
*dvobj,
struct net_device *pmondev;
int status = _FAIL;
 
-   padapter = (struct adapter *)vzalloc(sizeof(*padapter));
+   padapter = vzalloc(sizeof(*padapter));
if (padapter == NULL)
goto exit;
padapter->dvobj = dvobj;
-- 
2.16.2

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH-next] staging: emxx_udc: Remove unneeded cast

2018-02-20 Thread Christopher Diaz Riveros 
Fix Coccinelle alert:

drivers/staging//emxx_udc/emxx_udc.c:2689:19-21: WARNING: casting value 
returned by memory allocation function to (u8 *) is useless.

This issue was detected by using the Coccinelle software.

Signed-off-by: Christopher Diaz Riveros 
---
 drivers/staging/emxx_udc/emxx_udc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/emxx_udc/emxx_udc.c 
b/drivers/staging/emxx_udc/emxx_udc.c
index 7517001fb8f0..ad69a1e536a7 100644
--- a/drivers/staging/emxx_udc/emxx_udc.c
+++ b/drivers/staging/emxx_udc/emxx_udc.c
@@ -2686,7 +2686,7 @@ static int nbu2ss_ep_queue(
 
if (req->unaligned) {
if (!ep->virt_buf)
-   ep->virt_buf = (u8 *)dma_alloc_coherent(
+   ep->virt_buf = dma_alloc_coherent(
NULL, PAGE_SIZE,
>phys_buf, GFP_ATOMIC | GFP_DMA);
if (ep->epnum > 0)  {
-- 
2.16.2

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH-next] staging: rtl8723bs: Remove unneeded cast

2018-02-20 Thread Christopher Diaz Riveros 
Fix Coccinelle alert:

drivers/staging//rtl8723bs/os_dep/sdio_intf.c:340:13-27: WARNING: casting value 
returned by memory allocation function to (struct adapter *) is useless.

This issue was detected by using the Coccinelle software.

Signed-off-by: Christopher Diaz Riveros 
---
 drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c 
b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
index 943324877707..99c407ba0874 100644
--- a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
+++ b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
@@ -337,7 +337,7 @@ static struct adapter *rtw_sdio_if1_init(struct dvobj_priv 
*dvobj, const struct
struct adapter *padapter = NULL;
PSDIO_DATA psdio = >intf_data;
 
-   padapter = (struct adapter *)vzalloc(sizeof(*padapter));
+   padapter = vzalloc(sizeof(*padapter));
if (padapter == NULL) {
goto exit;
}
-- 
2.16.2

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 07/12] staging: wilc1000: rename pstrStatistics to avoid camelCase

2018-02-20 Thread Ajay Singh 
Fix "Avoid caseCase" issue found by checkpatch.pl script.

Signed-off-by: Ajay Singh 
---
 drivers/staging/wilc1000/host_interface.c | 20 ++--
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/drivers/staging/wilc1000/host_interface.c 
b/drivers/staging/wilc1000/host_interface.c
index 9eb808e..593f7f1 100644
--- a/drivers/staging/wilc1000/host_interface.c
+++ b/drivers/staging/wilc1000/host_interface.c
@@ -1889,7 +1889,7 @@ static void handle_get_rssi(struct wilc_vif *vif)
 }
 
 static s32 handle_get_statistics(struct wilc_vif *vif,
-struct rf_info *pstrStatistics)
+struct rf_info *stats)
 {
struct wid wid_list[5];
u32 wid_cnt = 0, result = 0;
@@ -1897,31 +1897,31 @@ static s32 handle_get_statistics(struct wilc_vif *vif,
wid_list[wid_cnt].id = WID_LINKSPEED;
wid_list[wid_cnt].type = WID_CHAR;
wid_list[wid_cnt].size = sizeof(char);
-   wid_list[wid_cnt].val = (s8 *)>link_speed;
+   wid_list[wid_cnt].val = (s8 *)>link_speed;
wid_cnt++;
 
wid_list[wid_cnt].id = WID_RSSI;
wid_list[wid_cnt].type = WID_CHAR;
wid_list[wid_cnt].size = sizeof(char);
-   wid_list[wid_cnt].val = (s8 *)>rssi;
+   wid_list[wid_cnt].val = (s8 *)>rssi;
wid_cnt++;
 
wid_list[wid_cnt].id = WID_SUCCESS_FRAME_COUNT;
wid_list[wid_cnt].type = WID_INT;
wid_list[wid_cnt].size = sizeof(u32);
-   wid_list[wid_cnt].val = (s8 *)>tx_cnt;
+   wid_list[wid_cnt].val = (s8 *)>tx_cnt;
wid_cnt++;
 
wid_list[wid_cnt].id = WID_RECEIVED_FRAGMENT_COUNT;
wid_list[wid_cnt].type = WID_INT;
wid_list[wid_cnt].size = sizeof(u32);
-   wid_list[wid_cnt].val = (s8 *)>rx_cnt;
+   wid_list[wid_cnt].val = (s8 *)>rx_cnt;
wid_cnt++;
 
wid_list[wid_cnt].id = WID_FAILED_COUNT;
wid_list[wid_cnt].type = WID_INT;
wid_list[wid_cnt].size = sizeof(u32);
-   wid_list[wid_cnt].val = (s8 *)>tx_fail_cnt;
+   wid_list[wid_cnt].val = (s8 *)>tx_fail_cnt;
wid_cnt++;
 
result = wilc_send_config_pkt(vif, GET_CFG, wid_list,
@@ -1931,13 +1931,13 @@ static s32 handle_get_statistics(struct wilc_vif *vif,
if (result)
netdev_err(vif->ndev, "Failed to send scan parameters\n");
 
-   if (pstrStatistics->link_speed > TCP_ACK_FILTER_LINK_SPEED_THRESH &&
-   pstrStatistics->link_speed != DEFAULT_LINK_SPEED)
+   if (stats->link_speed > TCP_ACK_FILTER_LINK_SPEED_THRESH &&
+   stats->link_speed != DEFAULT_LINK_SPEED)
wilc_enable_tcp_ack_filter(true);
-   else if (pstrStatistics->link_speed != DEFAULT_LINK_SPEED)
+   else if (stats->link_speed != DEFAULT_LINK_SPEED)
wilc_enable_tcp_ack_filter(false);
 
-   if (pstrStatistics != >wilc->dummy_statistics)
+   if (stats != >wilc->dummy_statistics)
complete(_wait_response);
return 0;
 }
-- 
2.7.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 08/12] staging: wilc1000: rename strDisconnectNotifInfo to avoid camelCase

2018-02-20 Thread Ajay Singh 
Fix "Avoid camelCase" issue found by checkpatch.pl script.

Signed-off-by: Ajay Singh 
---
 drivers/staging/wilc1000/host_interface.c | 24 
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/drivers/staging/wilc1000/host_interface.c 
b/drivers/staging/wilc1000/host_interface.c
index 593f7f1..64a2060 100644
--- a/drivers/staging/wilc1000/host_interface.c
+++ b/drivers/staging/wilc1000/host_interface.c
@@ -1330,7 +1330,7 @@ static s32 handle_rcvd_gnrl_async_info(struct wilc_vif 
*vif,
u8 u8MacStatusReasonCode;
u8 u8MacStatusAdditionalInfo;
struct connect_info strConnectInfo;
-   struct disconnect_info strDisconnectNotifInfo;
+   struct disconnect_info disconn_info;
s32 s32Err = 0;
struct host_if_drv *hif_drv = vif->hif_drv;
 
@@ -1462,16 +1462,16 @@ static s32 handle_rcvd_gnrl_async_info(struct wilc_vif 
*vif,
hif_drv->usr_conn_req.ies = NULL;
} else if ((u8MacStatus == MAC_DISCONNECTED) &&
   (hif_drv->hif_state == HOST_IF_CONNECTED)) {
-   memset(, 0, sizeof(struct 
disconnect_info));
+   memset(_info, 0, sizeof(struct 
disconnect_info));
 
if (hif_drv->usr_scan_req.scan_result) {
del_timer(_drv->scan_timer);
handle_scan_done(vif, SCAN_EVENT_ABORTED);
}
 
-   strDisconnectNotifInfo.reason = 0;
-   strDisconnectNotifInfo.ie = NULL;
-   strDisconnectNotifInfo.ie_len = 0;
+   disconn_info.reason = 0;
+   disconn_info.ie = NULL;
+   disconn_info.ie_len = 0;
 
if (hif_drv->usr_conn_req.conn_result) {
wilc_optaining_ip = false;
@@ -1480,7 +1480,7 @@ static s32 handle_rcvd_gnrl_async_info(struct wilc_vif 
*vif,

hif_drv->usr_conn_req.conn_result(CONN_DISCONN_EVENT_DISCONN_NOTIF,
  NULL,
  0,
- 
,
+ _info,
  
hif_drv->usr_conn_req.arg);
} else {
netdev_err(vif->ndev, "Connect result NULL\n");
@@ -1800,13 +1800,13 @@ static void handle_disconnect(struct wilc_vif *vif)
if (result) {
netdev_err(vif->ndev, "Failed to send dissconect\n");
} else {
-   struct disconnect_info strDisconnectNotifInfo;
+   struct disconnect_info disconn_info;
 
-   memset(, 0, sizeof(struct 
disconnect_info));
+   memset(_info, 0, sizeof(struct disconnect_info));
 
-   strDisconnectNotifInfo.reason = 0;
-   strDisconnectNotifInfo.ie = NULL;
-   strDisconnectNotifInfo.ie_len = 0;
+   disconn_info.reason = 0;
+   disconn_info.ie = NULL;
+   disconn_info.ie_len = 0;
 
if (hif_drv->usr_scan_req.scan_result) {
del_timer(_drv->scan_timer);
@@ -1824,7 +1824,7 @@ static void handle_disconnect(struct wilc_vif *vif)

hif_drv->usr_conn_req.conn_result(CONN_DISCONN_EVENT_DISCONN_NOTIF,
  NULL,
  0,
- 
,
+ _info,
  
hif_drv->usr_conn_req.arg);
} else {
netdev_err(vif->ndev, "conn_result = NULL\n");
-- 
2.7.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 12/12] staging: wilc1000: rename _WPARxGtk_end_case_ label to avoid camelCase

2018-02-20 Thread Ajay Singh 
Fix "Avoid camelCase" issue found by checkpatch.pl script.

Signed-off-by: Ajay Singh 
---
 drivers/staging/wilc1000/host_interface.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/wilc1000/host_interface.c 
b/drivers/staging/wilc1000/host_interface.c
index 0cfb79d..253225c 100644
--- a/drivers/staging/wilc1000/host_interface.c
+++ b/drivers/staging/wilc1000/host_interface.c
@@ -1620,7 +1620,7 @@ static int handle_key(struct wilc_vif *vif,
pu8keybuf = kzalloc(RX_MIC_KEY_MSG_LEN, GFP_KERNEL);
if (!pu8keybuf) {
ret = -ENOMEM;
-   goto _WPARxGtk_end_case_;
+   goto out_wpa_rx_gtk;
}
 
if (pstrHostIFkeyAttr->attr.wpa.seq)
@@ -1651,7 +1651,7 @@ static int handle_key(struct wilc_vif *vif,
pu8keybuf = kzalloc(RX_MIC_KEY_MSG_LEN, GFP_KERNEL);
if (!pu8keybuf) {
ret = -ENOMEM;
-   goto _WPARxGtk_end_case_;
+   goto out_wpa_rx_gtk;
}
 
if (hif_drv->hif_state == HOST_IF_CONNECTED)
@@ -1677,7 +1677,7 @@ static int handle_key(struct wilc_vif *vif,
kfree(pu8keybuf);
complete(_drv->comp_test_key_block);
}
-_WPARxGtk_end_case_:
+out_wpa_rx_gtk:
kfree(pstrHostIFkeyAttr->attr.wpa.key);
kfree(pstrHostIFkeyAttr->attr.wpa.seq);
if (ret)
-- 
2.7.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 09/12] staging: wilc1000: rename pstrDelStaParam to avoid camelCase

2018-02-20 Thread Ajay Singh 
Fix "Avoid camelCase" issue found by checkpatch.pl script.

Signed-off-by: Ajay Singh 
---
 drivers/staging/wilc1000/host_interface.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/wilc1000/host_interface.c 
b/drivers/staging/wilc1000/host_interface.c
index 64a2060..8ec33b3 100644
--- a/drivers/staging/wilc1000/host_interface.c
+++ b/drivers/staging/wilc1000/host_interface.c
@@ -2162,8 +2162,7 @@ static void handle_del_all_sta(struct wilc_vif *vif,
complete(_wait_response);
 }
 
-static void handle_del_station(struct wilc_vif *vif,
-  struct del_sta *pstrDelStaParam)
+static void handle_del_station(struct wilc_vif *vif, struct del_sta *param)
 {
s32 result = 0;
struct wid wid;
@@ -2179,7 +2178,7 @@ static void handle_del_station(struct wilc_vif *vif,
 
cur_byte = wid.val;
 
-   ether_addr_copy(cur_byte, pstrDelStaParam->mac_addr);
+   ether_addr_copy(cur_byte, param->mac_addr);
 
result = wilc_send_config_pkt(vif, SET_CFG, , 1,
  wilc_get_vif_idx(vif));
-- 
2.7.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 03/12] staging: wilc1000: rename variables using camelCase in handle_rcvd_ntwrk_info()

2018-02-20 Thread Ajay Singh 
Fix "Avoid camelCase" issue found by checkpatch.pl script.

Signed-off-by: Ajay Singh 
---
 drivers/staging/wilc1000/host_interface.c | 45 +++
 1 file changed, 22 insertions(+), 23 deletions(-)

diff --git a/drivers/staging/wilc1000/host_interface.c 
b/drivers/staging/wilc1000/host_interface.c
index 0f1eb17..f79618a 100644
--- a/drivers/staging/wilc1000/host_interface.c
+++ b/drivers/staging/wilc1000/host_interface.c
@@ -1248,18 +1248,17 @@ static s32 handle_rcvd_ntwrk_info(struct wilc_vif *vif,
  struct rcvd_net_info *rcvd_info)
 {
u32 i;
-   bool bNewNtwrkFound;
+   bool found;
s32 result = 0;
-   struct network_info *pstrNetworkInfo = NULL;
-   void *pJoinParams = NULL;
+   struct network_info *info = NULL;
+   void *params = NULL;
struct host_if_drv *hif_drv = vif->hif_drv;
 
-   bNewNtwrkFound = true;
+   found = true;
 
if (hif_drv->usr_scan_req.scan_result) {
-   wilc_parse_network_info(rcvd_info->buffer, );
-   if (!pstrNetworkInfo ||
-   !hif_drv->usr_scan_req.scan_result) {
+   wilc_parse_network_info(rcvd_info->buffer, );
+   if (!info || !hif_drv->usr_scan_req.scan_result) {
netdev_err(vif->ndev, "driver is null\n");
result = -EINVAL;
goto done;
@@ -1267,36 +1266,36 @@ static s32 handle_rcvd_ntwrk_info(struct wilc_vif *vif,
 
for (i = 0; i < hif_drv->usr_scan_req.rcvd_ch_cnt; i++) {
if (memcmp(hif_drv->usr_scan_req.net_info[i].bssid,
-  pstrNetworkInfo->bssid, 6) == 0) {
-   if (pstrNetworkInfo->rssi <= 
hif_drv->usr_scan_req.net_info[i].rssi) {
+  info->bssid, 6) == 0) {
+   if (info->rssi <= 
hif_drv->usr_scan_req.net_info[i].rssi) {
goto done;
} else {
-   hif_drv->usr_scan_req.net_info[i].rssi 
= pstrNetworkInfo->rssi;
-   bNewNtwrkFound = false;
+   hif_drv->usr_scan_req.net_info[i].rssi 
= info->rssi;
+   found = false;
break;
}
}
}
 
-   if (bNewNtwrkFound) {
+   if (found) {
if (hif_drv->usr_scan_req.rcvd_ch_cnt < 
MAX_NUM_SCANNED_NETWORKS) {
-   
hif_drv->usr_scan_req.net_info[hif_drv->usr_scan_req.rcvd_ch_cnt].rssi = 
pstrNetworkInfo->rssi;
+   
hif_drv->usr_scan_req.net_info[hif_drv->usr_scan_req.rcvd_ch_cnt].rssi = 
info->rssi;
 

memcpy(hif_drv->usr_scan_req.net_info[hif_drv->usr_scan_req.rcvd_ch_cnt].bssid,
-  pstrNetworkInfo->bssid, 6);
+  info->bssid, 6);
 
hif_drv->usr_scan_req.rcvd_ch_cnt++;
 
-   pstrNetworkInfo->new_network = true;
-   pJoinParams = 
host_int_parse_join_bss_param(pstrNetworkInfo);
+   info->new_network = true;
+   params = host_int_parse_join_bss_param(info);
 
-   
hif_drv->usr_scan_req.scan_result(SCAN_EVENT_NETWORK_FOUND, pstrNetworkInfo,
+   
hif_drv->usr_scan_req.scan_result(SCAN_EVENT_NETWORK_FOUND, info,
  
hif_drv->usr_scan_req.arg,
- pJoinParams);
+ params);
}
} else {
-   pstrNetworkInfo->new_network = false;
-   
hif_drv->usr_scan_req.scan_result(SCAN_EVENT_NETWORK_FOUND, pstrNetworkInfo,
+   info->new_network = false;
+   
hif_drv->usr_scan_req.scan_result(SCAN_EVENT_NETWORK_FOUND, info,
  
hif_drv->usr_scan_req.arg, NULL);
}
}
@@ -1305,9 +1304,9 @@ static s32 handle_rcvd_ntwrk_info(struct wilc_vif *vif,
kfree(rcvd_info->buffer);
rcvd_info->buffer = NULL;
 
-   if (pstrNetworkInfo) {
-   kfree(pstrNetworkInfo->ies);
-   kfree(pstrNetworkInfo);
+   if (info) {
+   kfree(info->ies);
+   kfree(info);
}
 
return result;
-- 
2.7.4

___
devel mailing list

[PATCH 06/12] staging: wilc1000: rename pstrSetBeaconParam to avoid camelCase

2018-02-20 Thread Ajay Singh 
Fix "Avoid camelCase" issue found by checkpatch.pl script.

Signed-off-by: Ajay Singh 
---
 drivers/staging/wilc1000/host_interface.c | 51 +++
 1 file changed, 25 insertions(+), 26 deletions(-)

diff --git a/drivers/staging/wilc1000/host_interface.c 
b/drivers/staging/wilc1000/host_interface.c
index 57f0201..9eb808e 100644
--- a/drivers/staging/wilc1000/host_interface.c
+++ b/drivers/staging/wilc1000/host_interface.c
@@ -1986,8 +1986,7 @@ static s32 handle_get_inactive_time(struct wilc_vif *vif,
return result;
 }
 
-static void handle_add_beacon(struct wilc_vif *vif,
- struct beacon_attr *pstrSetBeaconParam)
+static void handle_add_beacon(struct wilc_vif *vif, struct beacon_attr *param)
 {
s32 result = 0;
struct wid wid;
@@ -1995,38 +1994,38 @@ static void handle_add_beacon(struct wilc_vif *vif,
 
wid.id = (u16)WID_ADD_BEACON;
wid.type = WID_BIN;
-   wid.size = pstrSetBeaconParam->head_len + pstrSetBeaconParam->tail_len 
+ 16;
+   wid.size = param->head_len + param->tail_len + 16;
wid.val = kmalloc(wid.size, GFP_KERNEL);
if (!wid.val)
goto ERRORHANDLER;
 
cur_byte = wid.val;
-   *cur_byte++ = (pstrSetBeaconParam->interval & 0xFF);
-   *cur_byte++ = ((pstrSetBeaconParam->interval >> 8) & 0xFF);
-   *cur_byte++ = ((pstrSetBeaconParam->interval >> 16) & 0xFF);
-   *cur_byte++ = ((pstrSetBeaconParam->interval >> 24) & 0xFF);
+   *cur_byte++ = (param->interval & 0xFF);
+   *cur_byte++ = ((param->interval >> 8) & 0xFF);
+   *cur_byte++ = ((param->interval >> 16) & 0xFF);
+   *cur_byte++ = ((param->interval >> 24) & 0xFF);
 
-   *cur_byte++ = (pstrSetBeaconParam->dtim_period & 0xFF);
-   *cur_byte++ = ((pstrSetBeaconParam->dtim_period >> 8) & 0xFF);
-   *cur_byte++ = ((pstrSetBeaconParam->dtim_period >> 16) & 0xFF);
-   *cur_byte++ = ((pstrSetBeaconParam->dtim_period >> 24) & 0xFF);
+   *cur_byte++ = (param->dtim_period & 0xFF);
+   *cur_byte++ = ((param->dtim_period >> 8) & 0xFF);
+   *cur_byte++ = ((param->dtim_period >> 16) & 0xFF);
+   *cur_byte++ = ((param->dtim_period >> 24) & 0xFF);
 
-   *cur_byte++ = (pstrSetBeaconParam->head_len & 0xFF);
-   *cur_byte++ = ((pstrSetBeaconParam->head_len >> 8) & 0xFF);
-   *cur_byte++ = ((pstrSetBeaconParam->head_len >> 16) & 0xFF);
-   *cur_byte++ = ((pstrSetBeaconParam->head_len >> 24) & 0xFF);
+   *cur_byte++ = (param->head_len & 0xFF);
+   *cur_byte++ = ((param->head_len >> 8) & 0xFF);
+   *cur_byte++ = ((param->head_len >> 16) & 0xFF);
+   *cur_byte++ = ((param->head_len >> 24) & 0xFF);
 
-   memcpy(cur_byte, pstrSetBeaconParam->head, 
pstrSetBeaconParam->head_len);
-   cur_byte += pstrSetBeaconParam->head_len;
+   memcpy(cur_byte, param->head, param->head_len);
+   cur_byte += param->head_len;
 
-   *cur_byte++ = (pstrSetBeaconParam->tail_len & 0xFF);
-   *cur_byte++ = ((pstrSetBeaconParam->tail_len >> 8) & 0xFF);
-   *cur_byte++ = ((pstrSetBeaconParam->tail_len >> 16) & 0xFF);
-   *cur_byte++ = ((pstrSetBeaconParam->tail_len >> 24) & 0xFF);
+   *cur_byte++ = (param->tail_len & 0xFF);
+   *cur_byte++ = ((param->tail_len >> 8) & 0xFF);
+   *cur_byte++ = ((param->tail_len >> 16) & 0xFF);
+   *cur_byte++ = ((param->tail_len >> 24) & 0xFF);
 
-   if (pstrSetBeaconParam->tail)
-   memcpy(cur_byte, pstrSetBeaconParam->tail, 
pstrSetBeaconParam->tail_len);
-   cur_byte += pstrSetBeaconParam->tail_len;
+   if (param->tail)
+   memcpy(cur_byte, param->tail, param->tail_len);
+   cur_byte += param->tail_len;
 
result = wilc_send_config_pkt(vif, SET_CFG, , 1,
  wilc_get_vif_idx(vif));
@@ -2035,8 +2034,8 @@ static void handle_add_beacon(struct wilc_vif *vif,
 
 ERRORHANDLER:
kfree(wid.val);
-   kfree(pstrSetBeaconParam->head);
-   kfree(pstrSetBeaconParam->tail);
+   kfree(param->head);
+   kfree(param->tail);
 }
 
 static void handle_del_beacon(struct wilc_vif *vif)
-- 
2.7.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 05/12] staging: wilc1000: rename Handle_SetMulticastFilter to avoid camelCase

2018-02-20 Thread Ajay Singh 
Fix "Avoid camelCase" issue found by checkpatch.pl script.

Signed-off-by: Ajay Singh 
---
 drivers/staging/wilc1000/host_interface.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/wilc1000/host_interface.c 
b/drivers/staging/wilc1000/host_interface.c
index fd21765..57f0201 100644
--- a/drivers/staging/wilc1000/host_interface.c
+++ b/drivers/staging/wilc1000/host_interface.c
@@ -2404,8 +2404,8 @@ static void handle_power_management(struct wilc_vif *vif,
netdev_err(vif->ndev, "Failed to send power management\n");
 }
 
-static void Handle_SetMulticastFilter(struct wilc_vif *vif,
- struct set_multicast *hif_set_mc)
+static void handle_set_mcast_filter(struct wilc_vif *vif,
+   struct set_multicast *hif_set_mc)
 {
s32 result = 0;
struct wid wid;
@@ -2621,7 +2621,7 @@ static void host_if_work(struct work_struct *work)
break;
 
case HOST_IF_MSG_SET_MULTICAST_FILTER:
-   Handle_SetMulticastFilter(msg->vif, >body.multicast_info);
+   handle_set_mcast_filter(msg->vif, >body.multicast_info);
break;
 
case HOST_IF_MSG_DEL_ALL_STA:
-- 
2.7.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 10/12] staging: wilc1000: rename pstrStationParam to avoid camelCase

2018-02-20 Thread Ajay Singh 
Fix "Avoid camelCase" issue found by checkpatch.pl script.

Signed-off-by: Ajay Singh 
---
 drivers/staging/wilc1000/host_interface.c | 46 +++
 1 file changed, 22 insertions(+), 24 deletions(-)

diff --git a/drivers/staging/wilc1000/host_interface.c 
b/drivers/staging/wilc1000/host_interface.c
index 8ec33b3..8528ff8 100644
--- a/drivers/staging/wilc1000/host_interface.c
+++ b/drivers/staging/wilc1000/host_interface.c
@@ -2061,40 +2061,38 @@ static void handle_del_beacon(struct wilc_vif *vif)
 }
 
 static u32 WILC_HostIf_PackStaParam(u8 *pu8Buffer,
-   struct add_sta_param *pstrStationParam)
+   struct add_sta_param *param)
 {
u8 *cur_byte;
 
cur_byte = pu8Buffer;
 
-   memcpy(cur_byte, pstrStationParam->bssid, ETH_ALEN);
+   memcpy(cur_byte, param->bssid, ETH_ALEN);
cur_byte +=  ETH_ALEN;
 
-   *cur_byte++ = pstrStationParam->aid & 0xFF;
-   *cur_byte++ = (pstrStationParam->aid >> 8) & 0xFF;
+   *cur_byte++ = param->aid & 0xFF;
+   *cur_byte++ = (param->aid >> 8) & 0xFF;
 
-   *cur_byte++ = pstrStationParam->rates_len;
-   if (pstrStationParam->rates_len > 0)
-   memcpy(cur_byte, pstrStationParam->rates,
-  pstrStationParam->rates_len);
-   cur_byte += pstrStationParam->rates_len;
+   *cur_byte++ = param->rates_len;
+   if (param->rates_len > 0)
+   memcpy(cur_byte, param->rates, param->rates_len);
+   cur_byte += param->rates_len;
 
-   *cur_byte++ = pstrStationParam->ht_supported;
-   memcpy(cur_byte, >ht_capa,
-  sizeof(struct ieee80211_ht_cap));
+   *cur_byte++ = param->ht_supported;
+   memcpy(cur_byte, >ht_capa, sizeof(struct ieee80211_ht_cap));
cur_byte += sizeof(struct ieee80211_ht_cap);
 
-   *cur_byte++ = pstrStationParam->flags_mask & 0xFF;
-   *cur_byte++ = (pstrStationParam->flags_mask >> 8) & 0xFF;
+   *cur_byte++ = param->flags_mask & 0xFF;
+   *cur_byte++ = (param->flags_mask >> 8) & 0xFF;
 
-   *cur_byte++ = pstrStationParam->flags_set & 0xFF;
-   *cur_byte++ = (pstrStationParam->flags_set >> 8) & 0xFF;
+   *cur_byte++ = param->flags_set & 0xFF;
+   *cur_byte++ = (param->flags_set >> 8) & 0xFF;
 
return cur_byte - pu8Buffer;
 }
 
 static void handle_add_station(struct wilc_vif *vif,
-  struct add_sta_param *pstrStationParam)
+  struct add_sta_param *param)
 {
s32 result = 0;
struct wid wid;
@@ -2102,14 +2100,14 @@ static void handle_add_station(struct wilc_vif *vif,
 
wid.id = (u16)WID_ADD_STA;
wid.type = WID_BIN;
-   wid.size = WILC_ADD_STA_LENGTH + pstrStationParam->rates_len;
+   wid.size = WILC_ADD_STA_LENGTH + param->rates_len;
 
wid.val = kmalloc(wid.size, GFP_KERNEL);
if (!wid.val)
goto ERRORHANDLER;
 
cur_byte = wid.val;
-   cur_byte += WILC_HostIf_PackStaParam(cur_byte, pstrStationParam);
+   cur_byte += WILC_HostIf_PackStaParam(cur_byte, param);
 
result = wilc_send_config_pkt(vif, SET_CFG, , 1,
  wilc_get_vif_idx(vif));
@@ -2117,7 +2115,7 @@ static void handle_add_station(struct wilc_vif *vif,
netdev_err(vif->ndev, "Failed to send add station\n");
 
 ERRORHANDLER:
-   kfree(pstrStationParam->rates);
+   kfree(param->rates);
kfree(wid.val);
 }
 
@@ -2190,7 +2188,7 @@ static void handle_del_station(struct wilc_vif *vif, 
struct del_sta *param)
 }
 
 static void handle_edit_station(struct wilc_vif *vif,
-   struct add_sta_param *pstrStationParam)
+   struct add_sta_param *param)
 {
s32 result = 0;
struct wid wid;
@@ -2198,14 +2196,14 @@ static void handle_edit_station(struct wilc_vif *vif,
 
wid.id = (u16)WID_EDIT_STA;
wid.type = WID_BIN;
-   wid.size = WILC_ADD_STA_LENGTH + pstrStationParam->rates_len;
+   wid.size = WILC_ADD_STA_LENGTH + param->rates_len;
 
wid.val = kmalloc(wid.size, GFP_KERNEL);
if (!wid.val)
goto ERRORHANDLER;
 
cur_byte = wid.val;
-   cur_byte += WILC_HostIf_PackStaParam(cur_byte, pstrStationParam);
+   cur_byte += WILC_HostIf_PackStaParam(cur_byte, param);
 
result = wilc_send_config_pkt(vif, SET_CFG, , 1,
  wilc_get_vif_idx(vif));
@@ -2213,7 +2211,7 @@ static void handle_edit_station(struct wilc_vif *vif,
netdev_err(vif->ndev, "Failed to send edit station\n");
 
 ERRORHANDLER:
-   kfree(pstrStationParam->rates);
+   kfree(param->rates);
kfree(wid.val);
 }
 
-- 
2.7.4

___
devel mailing list
de...@linuxdriverproject.org

[PATCH 11/12] staging: wilc1000: rename _WPAPtk_end_case_ label to avoid camelCase

2018-02-20 Thread Ajay Singh 
Fix "Avoid camelCase" issue found by checkpatch.pl script.

Signed-off-by: Ajay Singh 
---
 drivers/staging/wilc1000/host_interface.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/wilc1000/host_interface.c 
b/drivers/staging/wilc1000/host_interface.c
index 8528ff8..0cfb79d 100644
--- a/drivers/staging/wilc1000/host_interface.c
+++ b/drivers/staging/wilc1000/host_interface.c
@@ -1690,7 +1690,7 @@ static int handle_key(struct wilc_vif *vif,
pu8keybuf = kmalloc(PTK_KEY_MSG_LEN + 1, GFP_KERNEL);
if (!pu8keybuf) {
ret = -ENOMEM;
-   goto _WPAPtk_end_case_;
+   goto out_wpa_ptk;
}
 
memcpy(pu8keybuf, pstrHostIFkeyAttr->attr.wpa.mac_addr, 
6);
@@ -1719,7 +1719,7 @@ static int handle_key(struct wilc_vif *vif,
if (!pu8keybuf) {
netdev_err(vif->ndev, "No buffer send PTK\n");
ret = -ENOMEM;
-   goto _WPAPtk_end_case_;
+   goto out_wpa_ptk;
}
 
memcpy(pu8keybuf, pstrHostIFkeyAttr->attr.wpa.mac_addr, 
6);
@@ -1739,7 +1739,7 @@ static int handle_key(struct wilc_vif *vif,
complete(_drv->comp_test_key_block);
}
 
-_WPAPtk_end_case_:
+out_wpa_ptk:
kfree(pstrHostIFkeyAttr->attr.wpa.key);
if (ret)
return ret;
-- 
2.7.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 02/12] staging: wilc1000: rename ptstrJoinBssParam to avoid camelCase

2018-02-20 Thread Ajay Singh 
Fix "Avoid camelCase" issue found by checkpatch.pl script.

Signed-off-by: Ajay Singh 
---
 drivers/staging/wilc1000/host_interface.c | 78 +++
 1 file changed, 39 insertions(+), 39 deletions(-)

diff --git a/drivers/staging/wilc1000/host_interface.c 
b/drivers/staging/wilc1000/host_interface.c
index f3a56e5..0f1eb17 100644
--- a/drivers/staging/wilc1000/host_interface.c
+++ b/drivers/staging/wilc1000/host_interface.c
@@ -909,7 +909,7 @@ static s32 handle_connect(struct wilc_vif *vif,
struct wid wid_list[8];
u32 wid_cnt = 0, dummyval = 0;
u8 *cur_byte = NULL;
-   struct join_bss_param *ptstrJoinBssParam;
+   struct join_bss_param *bss_param;
struct host_if_drv *hif_drv = vif->hif_drv;
 
if (memcmp(pstrHostIFconnectAttr->bssid, wilc_connected_ssid, ETH_ALEN) 
== 0) {
@@ -918,8 +918,8 @@ static s32 handle_connect(struct wilc_vif *vif,
return result;
}
 
-   ptstrJoinBssParam = pstrHostIFconnectAttr->params;
-   if (!ptstrJoinBssParam) {
+   bss_param = pstrHostIFconnectAttr->params;
+   if (!bss_param) {
netdev_err(vif->ndev, "Required BSSID not found\n");
result = -ENOENT;
goto ERRORHANDLER;
@@ -1031,8 +1031,8 @@ static s32 handle_connect(struct wilc_vif *vif,
netdev_err(vif->ndev, "Channel out of range\n");
*(cur_byte++) = 0xFF;
}
-   *(cur_byte++)  = (ptstrJoinBssParam->cap_info) & 0xFF;
-   *(cur_byte++)  = ((ptstrJoinBssParam->cap_info) >> 8) & 0xFF;
+   *(cur_byte++)  = (bss_param->cap_info) & 0xFF;
+   *(cur_byte++)  = ((bss_param->cap_info) >> 8) & 0xFF;
 
if (pstrHostIFconnectAttr->bssid)
memcpy(cur_byte, pstrHostIFconnectAttr->bssid, 6);
@@ -1042,57 +1042,57 @@ static s32 handle_connect(struct wilc_vif *vif,
memcpy(cur_byte, pstrHostIFconnectAttr->bssid, 6);
cur_byte += 6;
 
-   *(cur_byte++)  = (ptstrJoinBssParam->beacon_period) & 0xFF;
-   *(cur_byte++)  = ((ptstrJoinBssParam->beacon_period) >> 8) & 0xFF;
-   *(cur_byte++)  =  ptstrJoinBssParam->dtim_period;
+   *(cur_byte++)  = (bss_param->beacon_period) & 0xFF;
+   *(cur_byte++)  = ((bss_param->beacon_period) >> 8) & 0xFF;
+   *(cur_byte++)  =  bss_param->dtim_period;
 
-   memcpy(cur_byte, ptstrJoinBssParam->supp_rates, MAX_RATES_SUPPORTED + 
1);
+   memcpy(cur_byte, bss_param->supp_rates, MAX_RATES_SUPPORTED + 1);
cur_byte += (MAX_RATES_SUPPORTED + 1);
 
-   *(cur_byte++)  =  ptstrJoinBssParam->wmm_cap;
-   *(cur_byte++)  = ptstrJoinBssParam->uapsd_cap;
+   *(cur_byte++)  =  bss_param->wmm_cap;
+   *(cur_byte++)  = bss_param->uapsd_cap;
 
-   *(cur_byte++)  = ptstrJoinBssParam->ht_capable;
-   hif_drv->usr_conn_req.ht_capable = ptstrJoinBssParam->ht_capable;
+   *(cur_byte++)  = bss_param->ht_capable;
+   hif_drv->usr_conn_req.ht_capable = bss_param->ht_capable;
 
-   *(cur_byte++)  =  ptstrJoinBssParam->rsn_found;
-   *(cur_byte++)  =  ptstrJoinBssParam->rsn_grp_policy;
-   *(cur_byte++) =  ptstrJoinBssParam->mode_802_11i;
+   *(cur_byte++)  =  bss_param->rsn_found;
+   *(cur_byte++)  =  bss_param->rsn_grp_policy;
+   *(cur_byte++) =  bss_param->mode_802_11i;
 
-   memcpy(cur_byte, ptstrJoinBssParam->rsn_pcip_policy, 
sizeof(ptstrJoinBssParam->rsn_pcip_policy));
-   cur_byte += sizeof(ptstrJoinBssParam->rsn_pcip_policy);
+   memcpy(cur_byte, bss_param->rsn_pcip_policy, 
sizeof(bss_param->rsn_pcip_policy));
+   cur_byte += sizeof(bss_param->rsn_pcip_policy);
 
-   memcpy(cur_byte, ptstrJoinBssParam->rsn_auth_policy, 
sizeof(ptstrJoinBssParam->rsn_auth_policy));
-   cur_byte += sizeof(ptstrJoinBssParam->rsn_auth_policy);
+   memcpy(cur_byte, bss_param->rsn_auth_policy, 
sizeof(bss_param->rsn_auth_policy));
+   cur_byte += sizeof(bss_param->rsn_auth_policy);
 
-   memcpy(cur_byte, ptstrJoinBssParam->rsn_cap, 
sizeof(ptstrJoinBssParam->rsn_cap));
-   cur_byte += sizeof(ptstrJoinBssParam->rsn_cap);
+   memcpy(cur_byte, bss_param->rsn_cap, sizeof(bss_param->rsn_cap));
+   cur_byte += sizeof(bss_param->rsn_cap);
 
*(cur_byte++) = REAL_JOIN_REQ;
-   *(cur_byte++) = ptstrJoinBssParam->noa_enabled;
+   *(cur_byte++) = bss_param->noa_enabled;
 
-   if (ptstrJoinBssParam->noa_enabled) {
-   *(cur_byte++) = (ptstrJoinBssParam->tsf) & 0xFF;
-   *(cur_byte++) = ((ptstrJoinBssParam->tsf) >> 8) & 0xFF;
-   *(cur_byte++) = ((ptstrJoinBssParam->tsf) >> 16) & 0xFF;
-   *(cur_byte++) = ((ptstrJoinBssParam->tsf) >> 24) & 0xFF;
+   if (bss_param->noa_enabled) {
+   *(cur_byte++) = (bss_param->tsf) & 0xFF;
+   *(cur_byte++) = ((bss_param->tsf) >> 8) & 0xFF;
+   *(cur_byte++) = ((bss_param->tsf) >> 16) & 0xFF;
+

[PATCH 04/12] staging: wilc1000: rename pu32InactiveTime to avoid camelCase

2018-02-20 Thread Ajay Singh 
Fix "Avoid camelCase" issue found by checkpatch.pl script.

Signed-off-by: Ajay Singh 
---
 drivers/staging/wilc1000/host_interface.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/wilc1000/host_interface.c 
b/drivers/staging/wilc1000/host_interface.c
index f79618a..fd21765 100644
--- a/drivers/staging/wilc1000/host_interface.c
+++ b/drivers/staging/wilc1000/host_interface.c
@@ -3164,7 +3164,7 @@ int wilc_set_operation_mode(struct wilc_vif *vif, u32 
mode)
 }
 
 s32 wilc_get_inactive_time(struct wilc_vif *vif, const u8 *mac,
-  u32 *pu32InactiveTime)
+  u32 *out_val)
 {
s32 result = 0;
struct host_if_msg msg;
@@ -3187,7 +3187,7 @@ s32 wilc_get_inactive_time(struct wilc_vif *vif, const u8 
*mac,
else
wait_for_completion(_drv->comp_inactive_time);
 
-   *pu32InactiveTime = inactive_time;
+   *out_val = inactive_time;
 
return result;
 }
-- 
2.7.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 01/12] staging: wilc1000: rename pu8HdnNtwrksWidVal to avoid camelCase

2018-02-20 Thread Ajay Singh 
Fix "Avoid camelCase" issue found by checkpatch.pl script.

Signed-off-by: Ajay Singh 
---
 drivers/staging/wilc1000/host_interface.c | 8 
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/wilc1000/host_interface.c 
b/drivers/staging/wilc1000/host_interface.c
index 6f93966..f3a56e5 100644
--- a/drivers/staging/wilc1000/host_interface.c
+++ b/drivers/staging/wilc1000/host_interface.c
@@ -754,7 +754,7 @@ static s32 handle_scan(struct wilc_vif *vif, struct 
scan_attr *scan_info)
u32 i;
u8 *buffer;
u8 valuesize = 0;
-   u8 *pu8HdnNtwrksWidVal = NULL;
+   u8 *hdn_ntwk_wid_val = NULL;
struct host_if_drv *hif_drv = vif->hif_drv;
 
hif_drv->usr_scan_req.scan_result = scan_info->result;
@@ -780,8 +780,8 @@ static s32 handle_scan(struct wilc_vif *vif, struct 
scan_attr *scan_info)
 
for (i = 0; i < scan_info->hidden_network.n_ssids; i++)
valuesize += ((scan_info->hidden_network.net_info[i].ssid_len) 
+ 1);
-   pu8HdnNtwrksWidVal = kmalloc(valuesize + 1, GFP_KERNEL);
-   wid_list[index].val = pu8HdnNtwrksWidVal;
+   hdn_ntwk_wid_val = kmalloc(valuesize + 1, GFP_KERNEL);
+   wid_list[index].val = hdn_ntwk_wid_val;
if (wid_list[index].val) {
buffer = wid_list[index].val;
 
@@ -858,7 +858,7 @@ static s32 handle_scan(struct wilc_vif *vif, struct 
scan_attr *scan_info)
kfree(scan_info->hidden_network.net_info);
scan_info->hidden_network.net_info = NULL;
 
-   kfree(pu8HdnNtwrksWidVal);
+   kfree(hdn_ntwk_wid_val);
 
return result;
 }
-- 
2.7.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 00/12] staging: wilc1000: fixes to avoid use of camelCase in host interface

2018-02-20 Thread Ajay Singh 
This patch series contains fixes for "Avoid camelCase" issues found by
checkpatch.pl script.

Ajay Singh (12):
  staging: wilc1000: rename pu8HdnNtwrksWidVal to avoid camelCase
  staging: wilc1000: rename ptstrJoinBssParam to avoid camelCase
  staging: wilc1000: rename variables using camelCase in
handle_rcvd_ntwrk_info()
  staging: wilc1000: rename pu32InactiveTime to avoid camelCase
  staging: wilc1000: rename Handle_SetMulticastFilter to avoid camelCase
  staging: wilc1000: rename pstrSetBeaconParam to avoid camelCase
  staging: wilc1000: rename pstrStatistics to avoid camelCase
  staging: wilc1000: rename strDisconnectNotifInfo to avoid camelCase
  staging: wilc1000: rename pstrDelStaParam to avoid camelCase
  staging: wilc1000: rename pstrStationParam to avoid camelCase
  staging: wilc1000: rename _WPAPtk_end_case_ label to avoid camelCase
  staging: wilc1000: rename _WPARxGtk_end_case_ label to avoid camelCase

 drivers/staging/wilc1000/host_interface.c | 299 +++---
 1 file changed, 147 insertions(+), 152 deletions(-)

-- 
2.7.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] staging: pi433: fix CamelCase for addressFiltering

2018-02-20 Thread Valentin Vidic 
Fixes checkpatch warning:

  CHECK: Avoid CamelCase: 

Signed-off-by: Valentin Vidic 
---
 drivers/staging/pi433/pi433_if.c  | 4 ++--
 drivers/staging/pi433/pi433_if.h  | 2 +-
 drivers/staging/pi433/rf69.c  | 4 ++--
 drivers/staging/pi433/rf69.h  | 2 +-
 drivers/staging/pi433/rf69_enum.h | 2 +-
 5 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c
index e8ddc924bb04..aad1debd34a2 100644
--- a/drivers/staging/pi433/pi433_if.c
+++ b/drivers/staging/pi433/pi433_if.c
@@ -230,8 +230,8 @@ rf69_set_rx_cfg(struct pi433_device *dev, struct 
pi433_rx_cfg *rx_cfg)
if (ret < 0)
return ret;
}
-   ret = rf69_set_adressFiltering(dev->spi,
-  rx_cfg->enable_address_filtering);
+   ret = rf69_set_address_filtering(dev->spi,
+rx_cfg->enable_address_filtering);
if (ret < 0)
return ret;
 
diff --git a/drivers/staging/pi433/pi433_if.h b/drivers/staging/pi433/pi433_if.h
index 22c1631d0bf0..b3fa4fe64c5c 100644
--- a/drivers/staging/pi433/pi433_if.h
+++ b/drivers/staging/pi433/pi433_if.h
@@ -125,7 +125,7 @@ struct pi433_rx_cfg {
/* packet format */
enum option_on_off  enable_sync;
enum option_on_off  enable_length_byte;   /* should be used in 
combination with sync, only */
-   enum addressFiltering   enable_address_filtering; /* operational with 
sync, only */
+   enum address_filtering  enable_address_filtering; /* operational with 
sync, only */
enum option_on_off  enable_crc;   /* only operational, 
if sync on and fixed length or length byte is used */
 
__u8sync_length;
diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c
index 91c834059710..b2cea5f52eea 100644
--- a/drivers/staging/pi433/rf69.c
+++ b/drivers/staging/pi433/rf69.c
@@ -684,9 +684,9 @@ int rf69_disable_crc(struct spi_device *spi)
return rf69_clear_bit(spi, REG_PACKETCONFIG1, 
MASK_PACKETCONFIG1_CRC_ON);
 }
 
-int rf69_set_adressFiltering(struct spi_device *spi, enum addressFiltering 
addressFiltering)
+int rf69_set_address_filtering(struct spi_device *spi, enum address_filtering 
address_filtering)
 {
-   switch (addressFiltering) {
+   switch (address_filtering) {
case filteringOff:
return rf69_read_mod_write(spi, REG_PACKETCONFIG1, 
MASK_PACKETCONFIG1_ADDRESSFILTERING, PACKETCONFIG1_ADDRESSFILTERING_OFF);
case nodeAddress:
diff --git a/drivers/staging/pi433/rf69.h b/drivers/staging/pi433/rf69.h
index 21d7034e2c79..cf89b556cb00 100644
--- a/drivers/staging/pi433/rf69.h
+++ b/drivers/staging/pi433/rf69.h
@@ -53,7 +53,7 @@ int rf69_set_sync_values(struct spi_device *spi, u8 
sync_values[8]);
 int rf69_set_packet_format(struct spi_device *spi, enum packetFormat 
packetFormat);
 int rf69_enable_crc(struct spi_device *spi);
 int rf69_disable_crc(struct spi_device *spi);
-int rf69_set_adressFiltering(struct spi_device *spi, enum addressFiltering 
addressFiltering);
+int rf69_set_address_filtering(struct spi_device *spi, enum address_filtering 
address_filtering);
 int rf69_set_payload_length(struct spi_device *spi, u8 payload_length);
 int rf69_set_node_address(struct spi_device *spi, u8 nodeAddress);
 int rf69_set_broadcast_address(struct spi_device *spi, u8 broadcastAddress);
diff --git a/drivers/staging/pi433/rf69_enum.h 
b/drivers/staging/pi433/rf69_enum.h
index 478e3a4c4948..cba3c5b3995c 100644
--- a/drivers/staging/pi433/rf69_enum.h
+++ b/drivers/staging/pi433/rf69_enum.h
@@ -128,7 +128,7 @@ enum tx_start_condition {
fifo_not_empty
 };
 
-enum addressFiltering {
+enum address_filtering {
filteringOff,
nodeAddress,
nodeOrBroadcastAddress
-- 
2.16.1

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] staging: pi433: fix CamelCase for thresholdDecrement

2018-02-20 Thread Valentin Vidic 
Fixes checkpatch warning:

  CHECK: Avoid CamelCase: 

Signed-off-by: Valentin Vidic 
---
 drivers/staging/pi433/Documentation/pi433.txt | 2 +-
 drivers/staging/pi433/pi433_if.h  | 2 +-
 drivers/staging/pi433/rf69.c  | 4 ++--
 drivers/staging/pi433/rf69.h  | 2 +-
 drivers/staging/pi433/rf69_enum.h | 2 +-
 5 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/pi433/Documentation/pi433.txt 
b/drivers/staging/pi433/Documentation/pi433.txt
index 61ba9700d7dc..3313dff3c37e 100644
--- a/drivers/staging/pi433/Documentation/pi433.txt
+++ b/drivers/staging/pi433/Documentation/pi433.txt
@@ -180,7 +180,7 @@ rf params:
threshold value for the signal strength on the receiver input.
If this value is exceeded, a reception cycle starts
Allowed values: 0...255
-   thresholdDecrement
+   threshold_decrement
in order to adapt to different levels of singnal strength, over
time the receiver gets more and more sensitive. This value
determs, how fast the sensitivity increases.
diff --git a/drivers/staging/pi433/pi433_if.h b/drivers/staging/pi433/pi433_if.h
index 69847f978a69..22c1631d0bf0 100644
--- a/drivers/staging/pi433/pi433_if.h
+++ b/drivers/staging/pi433/pi433_if.h
@@ -115,7 +115,7 @@ struct pi433_rx_cfg {
enum modulation modulation;
 
__u8rssi_threshold;
-   enum thresholdDecrement threshold_decrement;
+   enum threshold_decrement threshold_decrement;
enum antenna_impedance  antenna_impedance;
enum lnaGainlna_gain;
enum mantisse   bw_mantisse;/* normal: 0x50 */
diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c
index 722d95a3777f..91c834059710 100644
--- a/drivers/staging/pi433/rf69.c
+++ b/drivers/staging/pi433/rf69.c
@@ -476,9 +476,9 @@ int rf69_set_bandwidth_during_afc(struct spi_device *spi, 
enum mantisse mantisse
return rf69_set_bandwidth_intern(spi, REG_AFCBW, mantisse, exponent);
 }
 
-int rf69_set_ook_threshold_dec(struct spi_device *spi, enum thresholdDecrement 
thresholdDecrement)
+int rf69_set_ook_threshold_dec(struct spi_device *spi, enum 
threshold_decrement threshold_decrement)
 {
-   switch (thresholdDecrement) {
+   switch (threshold_decrement) {
case dec_every8th:
return rf69_read_mod_write(spi, REG_OOKPEAK, 
MASK_OOKPEAK_THRESDEC, OOKPEAK_THRESHDEC_EVERY_8TH);
case dec_every4th:
diff --git a/drivers/staging/pi433/rf69.h b/drivers/staging/pi433/rf69.h
index 147d89390745..21d7034e2c79 100644
--- a/drivers/staging/pi433/rf69.h
+++ b/drivers/staging/pi433/rf69.h
@@ -40,7 +40,7 @@ int rf69_set_antenna_impedance(struct spi_device *spi, enum 
antenna_impedance an
 int rf69_set_lna_gain(struct spi_device *spi, enum lnaGain lnaGain);
 int rf69_set_bandwidth(struct spi_device *spi, enum mantisse mantisse, u8 
exponent);
 int rf69_set_bandwidth_during_afc(struct spi_device *spi, enum mantisse 
mantisse, u8 exponent);
-int rf69_set_ook_threshold_dec(struct spi_device *spi, enum thresholdDecrement 
thresholdDecrement);
+int rf69_set_ook_threshold_dec(struct spi_device *spi, enum 
threshold_decrement threshold_decrement);
 int rf69_set_dio_mapping(struct spi_device *spi, u8 DIONumber, u8 value);
 bool rf69_get_flag(struct spi_device *spi, enum flag flag);
 int rf69_set_rssi_threshold(struct spi_device *spi, u8 threshold);
diff --git a/drivers/staging/pi433/rf69_enum.h 
b/drivers/staging/pi433/rf69_enum.h
index 196c95dfe327..478e3a4c4948 100644
--- a/drivers/staging/pi433/rf69_enum.h
+++ b/drivers/staging/pi433/rf69_enum.h
@@ -82,7 +82,7 @@ enum mantisse {
mantisse24
 };
 
-enum thresholdDecrement {
+enum threshold_decrement {
dec_every8th,
dec_every4th,
dec_every2nd,
-- 
2.16.1

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] staging: pi433: fix CamelCase for txStartCondition

2018-02-20 Thread Valentin Vidic 
Fixes checkpatch warning:

  CHECK: Avoid CamelCase: 

Signed-off-by: Valentin Vidic 
---
 drivers/staging/pi433/pi433_if.h  | 2 +-
 drivers/staging/pi433/rf69.c  | 4 ++--
 drivers/staging/pi433/rf69.h  | 2 +-
 drivers/staging/pi433/rf69_enum.h | 2 +-
 4 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/pi433/pi433_if.h b/drivers/staging/pi433/pi433_if.h
index c4e4ea086a24..69847f978a69 100644
--- a/drivers/staging/pi433/pi433_if.h
+++ b/drivers/staging/pi433/pi433_if.h
@@ -69,7 +69,7 @@ struct pi433_tx_cfg {
 
enum paRamp pa_ramp;
 
-   enum txStartCondition   tx_start_condition;
+   enum tx_start_condition tx_start_condition;
 
__u16   repetitions;
 
diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c
index 42c2e1c6b386..722d95a3777f 100644
--- a/drivers/staging/pi433/rf69.c
+++ b/drivers/staging/pi433/rf69.c
@@ -714,9 +714,9 @@ int rf69_set_broadcast_address(struct spi_device *spi, u8 
broadcastAddress)
return rf69_write_reg(spi, REG_BROADCASTADRS, broadcastAddress);
 }
 
-int rf69_set_tx_start_condition(struct spi_device *spi, enum txStartCondition 
txStartCondition)
+int rf69_set_tx_start_condition(struct spi_device *spi, enum 
tx_start_condition tx_start_condition)
 {
-   switch (txStartCondition) {
+   switch (tx_start_condition) {
case fifo_level:
return rf69_clear_bit(spi, REG_FIFO_THRESH, 
MASK_FIFO_THRESH_TXSTART);
case fifo_not_empty:
diff --git a/drivers/staging/pi433/rf69.h b/drivers/staging/pi433/rf69.h
index 2c0d130f7a03..147d89390745 100644
--- a/drivers/staging/pi433/rf69.h
+++ b/drivers/staging/pi433/rf69.h
@@ -57,7 +57,7 @@ int rf69_set_adressFiltering(struct spi_device *spi, enum 
addressFiltering addre
 int rf69_set_payload_length(struct spi_device *spi, u8 payload_length);
 int rf69_set_node_address(struct spi_device *spi, u8 nodeAddress);
 int rf69_set_broadcast_address(struct spi_device *spi, u8 broadcastAddress);
-int rf69_set_tx_start_condition(struct spi_device *spi, enum txStartCondition 
txStartCondition);
+int rf69_set_tx_start_condition(struct spi_device *spi, enum 
tx_start_condition tx_start_condition);
 int rf69_set_fifo_threshold(struct spi_device *spi, u8 threshold);
 int rf69_set_dagc(struct spi_device *spi, enum dagc dagc);
 
diff --git a/drivers/staging/pi433/rf69_enum.h 
b/drivers/staging/pi433/rf69_enum.h
index 5629af716e4f..196c95dfe327 100644
--- a/drivers/staging/pi433/rf69_enum.h
+++ b/drivers/staging/pi433/rf69_enum.h
@@ -123,7 +123,7 @@ enum packetFormat {
packetLengthVar
 };
 
-enum txStartCondition {
+enum tx_start_condition {
fifo_level,
fifo_not_empty
 };
-- 
2.16.1

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re"Hello,

2018-02-20 Thread Ms. Hu. 


How are you and the family?

I am Ms.chui, I am seeking your partnership in re-profiling some offshore 
investment funds. 
Please contact me on my private email at huic...@gmail.com for more information.

Regards.

Ms. chui.
Email: huic...@gmail.com
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v2] staging:iio:meter: Add name to function definition arguments

2018-02-20 Thread Dan Carpenter 
On Tue, Feb 20, 2018 at 09:21:56AM -0300, Rodrigo Siqueira wrote:
> On 02/20, Dan Carpenter wrote:
> > > On Mon, Feb 19, 2018 at 01:28:32PM -0300, rodrigosiqueira wrote:
> > ^^^
> > This looks good, but you need to fix your from email header.
> 
> Thanks for the review, and the feedback related to the email header.
> I already fixed it. Is it necessary to resend the patch?
>  

I don't know?  Sometimes mainainters will cleanup patches themselves...

Probably it's simplest to just resend, yes.

regards,
dan carpenter

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v2] staging:iio:meter: Add name to function definition arguments

2018-02-20 Thread Rodrigo Siqueira 
On 02/20, Dan Carpenter wrote:
> > On Mon, Feb 19, 2018 at 01:28:32PM -0300, rodrigosiqueira wrote:
> ^^^
> This looks good, but you need to fix your from email header.

Thanks for the review, and the feedback related to the email header.
I already fixed it. Is it necessary to resend the patch?
 
> regards,
> dan carpenter
> 
> 
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel