Re: [PATCH v4 1/2] staging: vt6655: check for memory allocation failures

On 2018/3/30 13:51, Ji-Hun Kim wrote: There are no null pointer checking on rd_info and td_info values which are allocated by kzalloc. It has potential null pointer dereferencing issues. Implement error handling code on device_init_rd*, device_init_td* and vnt_start for the allocation

Re: [PATCH net-next] hv_netvsc: Clean up extra parameter from rndis_filter_receive_data()

From: Haiyang Zhang Date: Fri, 30 Mar 2018 13:57:59 -0700 > From: Haiyang Zhang > > The variables, msg and data, have the same value. This patch removes > the extra one. > > Signed-off-by: Haiyang Zhang Applied.

Re: [PATCH 04/11] staging: vchiq_arm: Clear VLA warning

Hi Stefan, I love your patch! Perhaps something to improve: [auto build test WARNING on staging/staging-testing] [also build test WARNING on v4.16-rc7 next-20180329] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

[PATCH 11/11] staging: vchiq_core: Free kthreads in error case

We need to free the kthreads in error case before leaving vchiq_init_state() otherwise we leak resources. Signed-off-by: Stefan Wahren --- .../staging/vc04_services/interface/vchiq_arm/vchiq_core.c| 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-)

[PATCH 09/11] staging: vchiq_arm: Avoid long udelay

vchiq_initialise() is used in non-interrupt context, so we can replace udelay with usleep_range as suggested by timers-howto.txt. Signed-off-by: Stefan Wahren --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH 06/11] staging: vchiq_arm: Make index variable more self-explaining

The chance to mixup i and j is very high. So rename variable j to a more explaining one. Signed-off-by: Stefan Wahren --- .../staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git

[PATCH 05/11] staging: vchiq_arm: Rework second abort criterion

In order to make the code easier to review, move the second abort criterion into the loop and the incrementation into a separate line. Signed-off-by: Stefan Wahren --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 7 +-- 1 file changed, 5

[PATCH 01/11] staging: vchiq_core: Fix missing semaphore release in error case

The bail out branch in case of a invalid tx_pos missed a semaphore release. Dan Carpenter found this with a static checker. Fixes: d1eab9dec610 ("staging: vchiq_core: Bail out in case of invalid tx_pos") Reported-by: Dan Carpenter Signed-off-by: Stefan Wahren

[PATCH 02/11] staging: vchiq_core: Remove stackhog in process_free_queue

This removes the stackhog in process_free_queue by allocating the necessary memory within the recycle thread main function instead of the stack. Signed-off-by: Stefan Wahren --- .../vc04_services/interface/vchiq_arm/vchiq_core.c | 16 1 file

[PATCH 08/11] staging: vchiq_arm: Fix multiline dereferences

Multiline dereferences aren't nice to review. So fix this checkpatch warning. Signed-off-by: Stefan Wahren --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git

[PATCH 10/11] staging: vchiq_core: Move all wake-ups to one point

Move all calls of wake_up_process to one point, whichs makes the following implementation of clean-up code easier. Signed-off-by: Stefan Wahren --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)

[PATCH 04/11] staging: vchiq_arm: Clear VLA warning

The kernel would like to have all stack VLA usage removed[1]. The array here is fixed (declared with a const variable) but it appears like a VLA to the compiler. Also, currently we are putting 768 bytes on the stack. So save stack space and removes the VLA build warning by making it static. [1]:

[PATCH 07/11] staging: vc04_services: Use __func__ macro

It's better to use the __func__ macro instead of open-code the function name. This fixes the following checkpatch warning: WARNING: Prefer using '"%s...", __func__' to using 'x', this function's name, in a string Signed-off-by: Stefan Wahren ---

[PATCH 03/11] staging: vchiq_core: remove BITSET_ZERO

Hiding memset behind a macro isn't the best, because it relies on that the parameter is not a pointer. Luckily all user has been removed, so we can remove BITSET_ZERO too. Signed-off-by: Stefan Wahren --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h | 1

Re: [PATCH v2 01/75] staging: ks7010: Use the ARRAY_SIZE() macro to calculate array sizes.

On Sat, 2018-03-31 at 11:41 +0300, Dan Carpenter wrote: > On Fri, Mar 30, 2018 at 11:36:13PM -0700, Joe Perches wrote: > > On Fri, 2018-03-30 at 23:07 -0700, Quytelda Kahja wrote: > > > This macro, provided in 'linux/kernel.h', will calculate the size > > > more succinctly than a division

Re: [PATCH] Patch to replace DEFINE_SEMAPHORE with DEFINE_BINARY_SEMAPHORE

On Sat, Mar 31, 2018 at 07:16:21PM +0530, Wasim Nazir wrote: > This message contains confidential information and is intended only for the > individual(s) named. If you are not the intended recipient, you are > notified that disclosing, copying, distributing or taking any action in > reliance

Re: [PATCH v2 68/75] staging: ks7010: Replace manual array copy with ether_addr_copy().

I'm in a hurry because I'm leaving for a long weekend so I've reviewed the first easy 67 patches but this one is tricky and I'm not able to review it properly before I leave. On Fri, Mar 30, 2018 at 11:08:48PM -0700, Quytelda Kahja wrote: > Copying the dummy HW address into the struct net_device

Re: [PATCH v2 71/75] staging: ks7010: Remove dummy address set.

On Fri, Mar 30, 2018 at 11:08:51PM -0700, Quytelda Kahja wrote: > Setting a dummy address during the driver probe is not necessary. > The dev_addr field is already zeroed out from alloc_etherdev(). > > Signed-off-by: Quytelda Kahja > --- >

Re: [PATCH v2 69/75] staging: ks7010: Remove extra blank line between functions.

On Fri, Mar 30, 2018 at 11:08:49PM -0700, Quytelda Kahja wrote: > Remove an extra blank line indicated by checkpatch. > > Signed-off-by: Quytelda Kahja > --- > drivers/staging/ks7010/ks7010_sdio.c | 3 ++- > drivers/staging/ks7010/ks_hostif.c | 1 - > 2 files changed, 2

Re: [PATCH v2 01/75] staging: ks7010: Use the ARRAY_SIZE() macro to calculate array sizes.

On Fri, Mar 30, 2018 at 11:36:13PM -0700, Joe Perches wrote: > On Fri, 2018-03-30 at 23:07 -0700, Quytelda Kahja wrote: > > This macro, provided in 'linux/kernel.h', will calculate the size > > more succinctly than a division operation. > > It's nice that you send patches, but please try to send

Re: [PATCH v2 01/75] staging: ks7010: Use the ARRAY_SIZE() macro to calculate array sizes.

On Fri, 2018-03-30 at 23:07 -0700, Quytelda Kahja wrote: > This macro, provided in 'linux/kernel.h', will calculate the size > more succinctly than a division operation. It's nice that you send patches, but please try to send a cover letter with your patch series. Also, 75 patches is quite a lot

[PATCH v2 75/75] staging: ks7010: Replace memcpy() with ether_addr_copy().

ether_addr_copy() is the function for copying a hardware address, so replace the manual memcpy() operation with ether_addr_copy(). Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_hostif.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v2 69/75] staging: ks7010: Remove extra blank line between functions.

Remove an extra blank line indicated by checkpatch. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks7010_sdio.c | 3 ++- drivers/staging/ks7010/ks_hostif.c | 1 - 2 files changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH v2 65/75] staging: ks7010: Remove trailing _t from 'struct pmk_t'.

The "_t" suffix is not needed for structure names in this driver, and is a reflection of an older typedef system that is no longer in place. Replace all occurences of 'struct pmk_t' with 'struct pmk'. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_hostif.c |

[PATCH v2 61/75] staging: ks7010: Remove trailing _t from 'struct wpa_key_t'.

The "_t" suffix is not needed for structure names in this driver, and is a reflection of an older typedef system that is no longer in place. Replace all occurences of 'struct wpa_key_t' with 'struct wpa_key'. Signed-off-by: Quytelda Kahja ---

[PATCH v2 74/75] staging: ks7010: Replace memcmp() with ether_addr_equal().

ether_addr_equal() is the function for comparing HW addresses, so remove the manual memcmp operation and replace it with ether_addr_equals(). Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_hostif.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

[PATCH v2 53/75] staging: ks7010: Remove trailing _t from 'struct wps_ie_t'.

The "_t" suffix is not needed for structure names in this driver, and is a reflection of an older typedef system that is no longer in place. Replace all occurences of 'struct wps_ie_t' with 'struct wps_ie'. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_wlan.h

[PATCH v2 58/75] staging: ks7010: Remove trailing _t from 'struct power_save_status_t'.

The "_t" suffix is not needed for structure names in this driver, and is a reflection of an older typedef system that is no longer in place. Replace all occurences of 'struct power_save_status_t' with 'struct power_save_status'. Signed-off-by: Quytelda Kahja ---

[PATCH v2 70/75] staging: ks7010: Rename ks_wlan_set_multicast_list()

All of the net_device_ops callbacks are named after their counterparts in the kernel's 'struct net_device_ops', except ks_wlan_set_multicast_list(). Rename it to ks_wlan_set_rx_mode() for greater consistency. Signed-off-by: Quytelda Kahja ---

[PATCH v2 63/75] staging: ks7010: Remove trailing _t from 'struct wpa_status_t'.

The "_t" suffix is not needed for structure names in this driver, and is a reflection of an older typedef system that is no longer in place. Replace all occurences of 'struct wpa_status_t' with 'struct wpa_status'. Signed-off-by: Quytelda Kahja ---

[PATCH v2 73/75] staging: ks7010: Remove unnecessary casts in 'struct ks_wlan_handler_def'.

The casts used when initializing members of this data structure mirror the types the variables already have. Remove the casts. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_wlan_net.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH v2 55/75] staging: ks7010: Remove trailing _t from 'struct local_aplist_t'.

The "_t" suffix is not needed for structure names in this driver, and is a reflection of an older typedef system that is no longer in place. Replace all occurences of 'struct local_aplist_t' with 'struct local_aplist'. Signed-off-by: Quytelda Kahja ---

[PATCH v2 68/75] staging: ks7010: Replace manual array copy with ether_addr_copy().

Copying the dummy HW address into the struct net_device doesn't need to be done byte by byte; use ether_addr_copy() instead. Additionally, dev->dev_addr is not eight bytes long. ether_setup() sets the dev->addr_len to ETH_ALEN (defined as 6) in the net core code. Signed-off-by: Quytelda Kahja

[PATCH v2 67/75] staging: ks7010: Remove trailing _t from 'struct michael_mic_t'.

The "_t" suffix is not needed for structure names in this driver, and is a reflection of an older typedef system that is no longer in place. Replace all occurences of 'struct michael_mic_t' with 'struct michael_mic'. Signed-off-by: Quytelda Kahja ---

[PATCH v2 64/75] staging: ks7010: Remove trailing _t from 'struct pmk_list_t'.

The "_t" suffix is not needed for structure names in this driver, and is a reflection of an older typedef system that is no longer in place. Replace all occurences of 'struct pmk_list_t' with 'struct pmk_list'. Signed-off-by: Quytelda Kahja ---

[PATCH v2 71/75] staging: ks7010: Remove dummy address set.

Setting a dummy address during the driver probe is not necessary. The dev_addr field is already zeroed out from alloc_etherdev(). Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_wlan_net.c | 6 -- 1 file changed, 6 deletions(-) diff --git

[PATCH v2 54/75] staging: ks7010: Remove trailing _t from 'struct local_ap_t'.

The "_t" suffix is not needed for structure names in this driver, and is a reflection of an older typedef system that is no longer in place. Replace all occurences of 'struct local_ap_t' with 'struct local_ap'. Signed-off-by: Quytelda Kahja ---

[PATCH v2 40/75] staging: ks7010: Remove trailing _t from 'struct association_request_t'.

The "_t" suffix is not needed for structure names in this driver, and is a reflection of an older typedef system that is no longer in place. Replace all occurences of 'struct association_request_t' with 'struct association_request'. Signed-off-by: Quytelda Kahja ---

[PATCH v2 72/75] staging: ks7010: Change 'device_open_status' to a bool.

The 'device_open_status' member of 'struct ks_wlan_private' is only ever set to zero or one, so it makes more sense for it to be a bool instead of an int. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_wlan.h | 2 +- drivers/staging/ks7010/ks_wlan_net.c |

[PATCH v2 59/75] staging: ks7010: Remove trailing _t from 'struct sleep_status_t'.

The "_t" suffix is not needed for structure names in this driver, and is a reflection of an older typedef system that is no longer in place. Replace all occurences of 'struct sleep_status_t' with 'struct sleep_status'. Signed-off-by: Quytelda Kahja ---

[PATCH v2 66/75] staging: ks7010: Remove trailing _t from 'struct wps_status_t'.

The "_t" suffix is not needed for structure names in this driver, and is a reflection of an older typedef system that is no longer in place. Replace all occurences of 'struct wps_status_t' with 'struct wps_status'. Signed-off-by: Quytelda Kahja ---

[PATCH v2 62/75] staging: ks7010: Remove trailing _t from 'struct mic_failure_t'.

The "_t" suffix is not needed for structure names in this driver, and is a reflection of an older typedef system that is no longer in place. Replace all occurences of 'struct mic_failure_t' with 'struct mic_failure'. Signed-off-by: Quytelda Kahja ---

[PATCH v2 60/75] staging: ks7010: Remove trailing _t from 'struct scan_ext_t'.

The "_t" suffix is not needed for structure names in this driver, and is a reflection of an older typedef system that is no longer in place. Replace all occurences of 'struct scan_ext_t' with 'struct scan_ext'. Signed-off-by: Quytelda Kahja ---

[PATCH v2 46/75] staging: ks7010: Remove unused 'struct hostif_phy_information_confirm_t'.

'struct hostif_phy_information_confirm_t' is not used in this driver. Remove 'struct hostif_phy_information_confirm_t'. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_hostif.h | 12 1 file changed, 12 deletions(-) diff --git

[PATCH v2 52/75] staging: ks7010: Remove trailing _t from 'struct rsn_ie_t'.

The "_t" suffix is not needed for structure names in this driver, and is a reflection of an older typedef system that is no longer in place. Replace all occurences of 'struct rsn_ie_t' with 'struct rsn_ie'. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_wlan.h

[PATCH v2 56/75] staging: ks7010: Remove trailing _t from 'struct local_gain_t'.

The "_t" suffix is not needed for structure names in this driver, and is a reflection of an older typedef system that is no longer in place. Replace all occurences of 'struct local_gain_t' with 'struct local_gain'. Signed-off-by: Quytelda Kahja ---

[PATCH v2 41/75] staging: ks7010: Remove trailing _t from 'struct association_response_t'.

The "_t" suffix is not needed for structure names in this driver, and is a reflection of an older typedef system that is no longer in place. Replace all occurences of 'struct association_response_t' with 'struct association_response'. Signed-off-by: Quytelda Kahja ---

[PATCH v2 48/75] staging: ks7010: Remove unused 'struct hostif_sleep_confirm_t'.

'struct hostif_sleep_confirm_t' is not used in this driver. Remove 'struct hostif_sleep_confirm_t'. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_hostif.h | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/ks7010/ks_hostif.h

[PATCH v2 35/75] staging: ks7010: Remove unused 'struct hostif_infrastructure_set_confirm_t'.

'struct hostif_infrastructure_set_confirm_t' is not used in this driver. Remove 'struct hostif_infrastructure_set_confirm_t'. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_hostif.h | 5 - 1 file changed, 5 deletions(-) diff --git

[PATCH v2 57/75] staging: ks7010: Remove trailing _t from 'struct local_eeprom_sum_t'.

The "_t" suffix is not needed for structure names in this driver, and is a reflection of an older typedef system that is no longer in place. Replace all occurences of 'struct local_eeprom_sum_t' with 'struct local_eeprom_sum'. Signed-off-by: Quytelda Kahja ---

[PATCH v2 51/75] staging: ks7010: Remove trailing _t from 'struct hostt_t'.

The "_t" suffix is not needed for structure names in this driver, and is a reflection of an older typedef system that is no longer in place. Replace all occurences of 'struct hostt_t' with 'struct hostt'. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_wlan.h |

[PATCH v2 50/75] staging: ks7010: Remove unused 'struct hostif_mic_failure_confirm_t'.

'struct hostif_mic_failure_confirm_t' is not used in this driver. Remove 'struct hostif_mic_failure_confirm_t'. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_hostif.h | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/ks7010/ks_hostif.h

[PATCH v2 33/75] staging: ks7010: Remove unused 'struct hostif_ps_adhoc_set_confirm_t'.

'struct hostif_ps_adhoc_set_confirm_t' is not used in this driver. Remove 'struct hostif_ps_adhoc_set_confirm_t'. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_hostif.h | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/ks7010/ks_hostif.h

[PATCH v2 49/75] staging: ks7010: Remove trailing _t from 'struct hostif_mic_failure_request_t'.

The "_t" suffix is not needed for structure names in this driver, and is a reflection of an older typedef system that is no longer in place. Replace all occurences of 'struct hostif_mic_failure_request_t' with 'struct hostif_mic_failure_request'. Signed-off-by: Quytelda Kahja

[PATCH v2 10/75] staging: ks7010: Remove unused 'struct hostif_mib_get_confirm_t'.

'struct hostif_mib_get_confirm_t' is not used in this driver. Remove 'struct hostif_mib_get_confirm_t'. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_hostif.h | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/ks7010/ks_hostif.h

[PATCH v2 23/75] staging: ks7010: Remove unused 'struct rsn_t'.

'struct rsn_t' is not used in this driver. Remove 'struct rsn_t'. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_hostif.h | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/ks7010/ks_hostif.h b/drivers/staging/ks7010/ks_hostif.h index

[PATCH v2 14/75] staging: ks7010: Remove unused 'struct hostif_power_mgmt_confirm_t'.

'struct hostif_power_mgmt_confirm_t' is not used in this driver. Remove 'struct hostif_power_mgmt_confirm_t'. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_hostif.h | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/ks7010/ks_hostif.h

[PATCH v2 37/75] staging: ks7010: Remove trailing _t from 'struct hostif_adhoc_set2_request_t'.

The "_t" suffix is not needed for structure names in this driver, and is a reflection of an older typedef system that is no longer in place. Replace all occurences of 'struct hostif_adhoc_set2_request_t' with 'struct hostif_adhoc_set2_request'. Signed-off-by: Quytelda Kahja

[PATCH v2 42/75] staging: ks7010: Remove unused 'struct hostif_associate_indication_t'.

'struct hostif_associate_indication_t' is not used in this driver. Remove 'struct hostif_associate_indication_t'. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_hostif.h | 8 1 file changed, 8 deletions(-) diff --git

[PATCH v2 28/75] staging: ks7010: Remove unused 'struct hostif_connect_indication_t'.

'struct hostif_connect_indication_t' is not used in this driver. Remove 'struct hostif_connect_indication_t'. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_hostif.h | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/ks7010/ks_hostif.h

[PATCH v2 15/75] staging: ks7010: Remove trailing _t from 'struct hostif_start_request_t'.

The "_t" suffix is not needed for structure names in this driver, and is a reflection of an older typedef system that is no longer in place. Replace all occurences of 'struct hostif_start_request_t' with 'struct hostif_start_request'. Signed-off-by: Quytelda Kahja ---

[PATCH v2 32/75] staging: ks7010: Remove trailing _t from 'struct hostif_ps_adhoc_set_request_t'.

The "_t" suffix is not needed for structure names in this driver, and is a reflection of an older typedef system that is no longer in place. Replace all occurences of 'struct hostif_ps_adhoc_set_request_t' with 'struct hostif_ps_adhoc_set_request'. Signed-off-by: Quytelda Kahja

[PATCH v2 24/75] staging: ks7010: Remove trailing _t from 'struct erp_params_t'.

The "_t" suffix is not needed for structure names in this driver, and is a reflection of an older typedef system that is no longer in place. Replace all occurences of 'struct erp_params_t' with 'struct erp_params'. Signed-off-by: Quytelda Kahja ---

[PATCH v2 34/75] staging: ks7010: Remove trailing _t from 'struct hostif_infrastructure_set_request_t'.

The "_t" suffix is not needed for structure names in this driver, and is a reflection of an older typedef system that is no longer in place. Replace all occurences of 'struct hostif_infrastructure_set_request_t' with 'struct hostif_infrastructure_set_request'. Signed-off-by: Quytelda Kahja

[PATCH v2 20/75] staging: ks7010: Remove trailing _t from 'struct ds_parms_t'.

The "_t" suffix is not needed for structure names in this driver, and is a reflection of an older typedef system that is no longer in place. Replace all occurences of 'struct ds_parms_t' with 'struct ds_parms'. Signed-off-by: Quytelda Kahja ---

[PATCH v2 38/75] staging: ks7010: Remove unused 'struct hostif_adhoc_set_confirm_t'.

'struct hostif_adhoc_set_confirm_t' is not used in this driver. Remove 'struct hostif_adhoc_set_confirm_t'. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_hostif.h | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/ks7010/ks_hostif.h

[PATCH v2 29/75] staging: ks7010: Remove trailing _t from 'struct hostif_stop_request_t'.

The "_t" suffix is not needed for structure names in this driver, and is a reflection of an older typedef system that is no longer in place. Replace all occurences of 'struct hostif_stop_request_t' with 'struct hostif_stop_request'. Signed-off-by: Quytelda Kahja ---

[PATCH v2 18/75] staging: ks7010: Remove trailing _t from 'struct rate_set8_t'.

The "_t" suffix is not needed for structure names in this driver, and is a reflection of an older typedef system that is no longer in place. Replace all occurences of 'struct rate_set8_t' with 'struct rate_set8'. Signed-off-by: Quytelda Kahja ---

[PATCH v2 47/75] staging: ks7010: Remove trailing _t from 'struct hostif_sleep_request_t'.

The "_t" suffix is not needed for structure names in this driver, and is a reflection of an older typedef system that is no longer in place. Replace all occurences of 'struct hostif_sleep_request_t' with 'struct hostif_sleep_request'. Signed-off-by: Quytelda Kahja ---

[PATCH v2 44/75] staging: ks7010: Remove unused 'struct hostif_bss_scan_confirm_t'.

'struct hostif_bss_scan_confirm_t' is not used in this driver. Remove 'struct hostif_bss_scan_confirm_t'. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_hostif.h | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/ks7010/ks_hostif.h

[PATCH v2 45/75] staging: ks7010: Remove trailing _t from 'struct hostif_phy_information_request_t'.

The "_t" suffix is not needed for structure names in this driver, and is a reflection of an older typedef system that is no longer in place. Replace all occurences of 'struct hostif_phy_information_request_t' with 'struct hostif_phy_information_request'. Signed-off-by: Quytelda Kahja

[PATCH v2 43/75] staging: ks7010: Remove trailing _t from 'struct hostif_bss_scan_request_t'.

The "_t" suffix is not needed for structure names in this driver, and is a reflection of an older typedef system that is no longer in place. Replace all occurences of 'struct hostif_bss_scan_request_t' with 'struct hostif_bss_scan_request'. Signed-off-by: Quytelda Kahja ---

[PATCH v2 36/75] staging: ks7010: Remove trailing _t from 'struct hostif_adhoc_set_request_t'.

The "_t" suffix is not needed for structure names in this driver, and is a reflection of an older typedef system that is no longer in place. Replace all occurences of 'struct hostif_adhoc_set_request_t' with 'struct hostif_adhoc_set_request'. Signed-off-by: Quytelda Kahja

[PATCH v2 30/75] staging: ks7010: Remove unused 'struct hostif_stop_confirm_t'.

'struct hostif_stop_confirm_t' is not used in this driver. Remove 'struct hostif_stop_confirm_t'. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_hostif.h | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/ks7010/ks_hostif.h

[PATCH v2 39/75] staging: ks7010: Remove unused 'struct last_associate_t'.

'struct last_associate_t' is not used in this driver. Remove 'struct last_associate_t'. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_hostif.h | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/ks7010/ks_hostif.h

[PATCH v2 21/75] staging: ks7010: Remove trailing _t from 'struct cf_parms_t'.

The "_t" suffix is not needed for structure names in this driver, and is a reflection of an older typedef system that is no longer in place. Replace all occurences of 'struct cf_parms_t' with 'struct cf_parms'. Signed-off-by: Quytelda Kahja ---

[PATCH v2 31/75] staging: ks7010: Remove trailing _t from 'struct hostif_request_t'.

The "_t" suffix is not needed for structure names in this driver, and is a reflection of an older typedef system that is no longer in place. Replace all occurences of 'struct hostif_request_t' with 'struct hostif_request'. Signed-off-by: Quytelda Kahja ---

[PATCH v2 06/75] staging: ks7010: Remove unused 'struct hostif_data_indication_t'.

'struct hostif_data_indication_t' is not used in this driver. Remove 'struct hostif_data_indication_t'. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_hostif.h | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/staging/ks7010/ks_hostif.h

[PATCH v2 13/75] staging: ks7010: Remove trailing _t from 'struct hostif_power_mgmt_request_t'.

The "_t" suffix is not needed for structure names in this driver, and is a reflection of an older typedef system that is no longer in place. Replace all occurences of 'struct hostif_power_mgmt_request_t' with 'struct hostif_power_mgmt_request'. Signed-off-by: Quytelda Kahja

[PATCH v2 25/75] staging: ks7010: Remove trailing _t from 'struct rate_set16_t'.

The "_t" suffix is not needed for structure names in this driver, and is a reflection of an older typedef system that is no longer in place. Replace all occurences of 'struct rate_set16_t' with 'struct rate_set16'. Signed-off-by: Quytelda Kahja ---

[PATCH v2 17/75] staging: ks7010: Remove trailing _t from 'struct ssid_t'.

The "_t" suffix is not needed for structure names in this driver, and is a reflection of an older typedef system that is no longer in place. Replace all occurences of 'struct ssid_t' with 'struct ssid'. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_hostif.h |

[PATCH v2 26/75] staging: ks7010: Remove trailing _t from 'struct ap_info_t'.

The "_t" suffix is not needed for structure names in this driver, and is a reflection of an older typedef system that is no longer in place. Replace all occurences of 'struct ap_info_t' with 'struct ap_info'. Signed-off-by: Quytelda Kahja ---

[PATCH v2 22/75] staging: ks7010: Remove trailing _t from 'struct ibss_parms_t'.

The "_t" suffix is not needed for structure names in this driver, and is a reflection of an older typedef system that is no longer in place. Replace all occurences of 'struct ibss_parms_t' with 'struct ibss_parms'. Signed-off-by: Quytelda Kahja ---

[PATCH v2 19/75] staging: ks7010: Remove trailing _t from 'struct fh_parms_t'.

The "_t" suffix is not needed for structure names in this driver, and is a reflection of an older typedef system that is no longer in place. Replace all occurences of 'struct fh_parms_t' with 'struct fh_parms'. Signed-off-by: Quytelda Kahja ---

[PATCH v2 27/75] staging: ks7010: Remove trailing _t from 'struct link_ap_info_t'.

The "_t" suffix is not needed for structure names in this driver, and is a reflection of an older typedef system that is no longer in place. Replace all occurences of 'struct link_ap_info_t' with 'struct link_ap_info'. Signed-off-by: Quytelda Kahja ---

[PATCH v2 12/75] staging: ks7010: Remove unused 'struct hostif_mib_set_confirm_t'.

'struct hostif_mib_set_confirm_t' is not used in this driver. Remove 'struct hostif_mib_set_confirm_t'. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_hostif.h | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/ks7010/ks_hostif.h

[PATCH v2 07/75] staging: ks7010: Remove trailing _t from 'struct channel_list_t'.

The "_t" suffix is not needed for structure names in this driver, and is a reflection of an older typedef system that is no longer in place. Replace all occurences of 'struct channel_list_t' with 'struct channel_list'. Signed-off-by: Quytelda Kahja ---

[PATCH v2 16/75] staging: ks7010: Remove unused 'struct hostif_start_confirm_t'.

'struct hostif_start_confirm_t' is not used in this driver. Remove 'struct hostif_start_confirm_t'. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_hostif.h | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/ks7010/ks_hostif.h

[PATCH v2 01/75] staging: ks7010: Use the ARRAY_SIZE() macro to calculate array sizes.

This macro, provided in 'linux/kernel.h', will calculate the size more succinctly than a division operation. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_wlan_net.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git

[PATCH v2 09/75] staging: ks7010: Remove trailing _t from 'struct hostif_mib_value_t'.

The "_t" suffix is not needed for structure names in this driver, and is a reflection of an older typedef system that is no longer in place. Replace all occurences of 'struct hostif_mib_value_t' with 'struct hostif_mib_value'. Signed-off-by: Quytelda Kahja ---

[PATCH v2 08/75] staging: ks7010: Remove trailing _t from 'struct hostif_mib_get_request_t'.

The "_t" suffix is not needed for structure names in this driver, and is a reflection of an older typedef system that is no longer in place. Replace all occurences of 'struct hostif_mib_get_request_t' with 'struct hostif_mib_get_request'. Signed-off-by: Quytelda Kahja ---

[PATCH v2 11/75] staging: ks7010: Remove trailing _t from 'struct hostif_mib_set_request_t'.

The "_t" suffix is not needed for structure names in this driver, and is a reflection of an older typedef system that is no longer in place. Replace all occurences of 'struct hostif_mib_set_request_t' with 'struct hostif_mib_set_request'. Signed-off-by: Quytelda Kahja ---

[PATCH v2 02/75] staging: ks7010: Remove trailing _t from 'struct wpa_suite_t'.

The "_t" suffix is not needed for structure names in this driver, and is a reflection of an older typedef system that is no longer in place. Replace all occurences of 'struct wpa_suite_t' with 'struct wpa_suite'. Signed-off-by: Quytelda Kahja ---

[PATCH v2 04/75] staging: ks7010: Remove trailing _t from 'struct pmk_cache_t'.

The "_t" suffix is not needed for structure names in this driver, and is a reflection of an older typedef system that is no longer in place. Replace all occurences of 'struct pmk_cache_t' with 'struct pmk_cache'. Signed-off-by: Quytelda Kahja ---

[PATCH v2 03/75] staging: ks7010: Remove trailing _t from 'struct rsn_mode_t'.

The "_t" suffix is not needed for structure names in this driver, and is a reflection of an older typedef system that is no longer in place. Replace all occurences of 'struct rsn_mode_t' with 'struct rsn_mode'. Signed-off-by: Quytelda Kahja ---

[PATCH v2 05/75] staging: ks7010: Remove trailing _t from 'struct hostif_data_request_t'.

The "_t" suffix is not needed for structure names in this driver, and is a reflection of an older typedef system that is no longer in place. Replace all occurences of 'struct hostif_data_request_t' with 'struct hostif_data_request'. Signed-off-by: Quytelda Kahja ---