[PATCH v2] staging: iio: ad2s1210: fix 'assignment operator' style checks
This patch fixes all "Assignment operator '=' should be on the previous
line" checks found in ad2s1210.c with checkpatch.pl.
Signed-off-by: Matheus Tavares
---
Changes in v2: In v1, tabs were accidentally converted to whitespaces.
Now, tabs were preserved.
drivers/staging/iio/resolver/ad2s1210.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/iio/resolver/ad2s1210.c
b/drivers/staging/iio/resolver/ad2s1210.c
index ac13b99bd9cb..d4b1c2c010f2 100644
--- a/drivers/staging/iio/resolver/ad2s1210.c
+++ b/drivers/staging/iio/resolver/ad2s1210.c
@@ -301,8 +301,8 @@ static ssize_t ad2s1210_store_control(struct device *dev,
"ad2s1210: write control register fail\n");
goto error_ret;
}
- st->resolution
- = ad2s1210_resolution_value[data & AD2S1210_SET_RESOLUTION];
+ st->resolution =
+ ad2s1210_resolution_value[data & AD2S1210_SET_RESOLUTION];
if (st->pdata->gpioin) {
data = ad2s1210_read_resolution_pin(st);
if (data != st->resolution)
@@ -363,8 +363,8 @@ static ssize_t ad2s1210_store_resolution(struct device *dev,
dev_err(dev, "ad2s1210: setting resolution fail\n");
goto error_ret;
}
- st->resolution
- = ad2s1210_resolution_value[data & AD2S1210_SET_RESOLUTION];
+ st->resolution =
+ ad2s1210_resolution_value[data & AD2S1210_SET_RESOLUTION];
if (st->pdata->gpioin) {
data = ad2s1210_read_resolution_pin(st);
if (data != st->resolution)
--
2.18.0
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
RE: [v2, 1/5] net: dpaa2: move DPAA2 PTP driver out of staging/
Hi Andrew, Sorry for late. Just come back from holiday. Hi Ioana, Could you generate an additional patch for dpaa2_eth to address Andrew's comments? There was also a warning when checked patch. FSL_DPAA2_ETH needed more description. WARNING: please write a paragraph that describes the config symbol fully #66: FILE: drivers/net/ethernet/freescale/dpaa2/Kconfig:1: +config FSL_DPAA2_ETH Thanks a lot. Best regards, Yangbo Lu > -Original Message- > From: Andrew Lunn > Sent: Sunday, September 30, 2018 3:46 AM > To: Y.b. Lu > Cc: linux-ker...@vger.kernel.org; de...@driverdev.osuosl.org; > net...@vger.kernel.org; Richard Cochran ; > David S . Miller ; Ioana Ciocoi Radulescu > ; Greg Kroah-Hartman > > Subject: Re: [v2, 1/5] net: dpaa2: move DPAA2 PTP driver out of staging/ > > > +++ b/drivers/net/ethernet/freescale/dpaa2/Kconfig > > @@ -0,0 +1,15 @@ > > +config FSL_DPAA2_ETH > > + tristate "Freescale DPAA2 Ethernet" > > + depends on FSL_MC_BUS && FSL_MC_DPIO > > Could you add in here COMPILE_TEST? > > > + depends on NETDEVICES && ETHERNET > > With the move out of staging, i don't think these two are required. > > Andrew ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 09/11] staging:rtl8192u: Remove unnecessary line continuation - Style
Remove the unnecessary line continuation character to clear checkpatch issue. This is a simple coding style change which should not impact runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/ieee80211_module.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c index f134cd5a9829..1b0f45f1bb84 100644 --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c @@ -215,8 +215,7 @@ void free_ieee80211(struct net_device *dev) #ifdef CONFIG_IEEE80211_DEBUG u32 ieee80211_debug_level; -static int debug = \ - // IEEE80211_DL_INFO | +static int debug = // IEEE80211_DL_INFO | // IEEE80211_DL_WX | // IEEE80211_DL_SCAN | // IEEE80211_DL_STATE | -- 2.19.0 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 10/11] staging:rtl8192u: Correct code alignment - Style
Correct the alignment of a function, this clears checkpatch issue.
This is a simple coding style change which should not impact runtime
code execution.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/ieee80211/ieee80211_module.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
b/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
index 1b0f45f1bb84..5dc780119eff 100644
--- a/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
+++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
@@ -244,7 +244,7 @@ static int show_debug_level(struct seq_file *m, void *v)
}
static ssize_t write_debug_level(struct file *file, const char __user *buffer,
-size_t count, loff_t *ppos)
+size_t count, loff_t *ppos)
{
unsigned long val;
int err = kstrtoul_from_user(buffer, count, 0, );
--
2.19.0
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 03/11] staging:rtl8192u: Clear error with line ending ( - Style
Rewrite function call to clear the checkpatch issue with lines ending
with a '(' character.
This is a coding style change which should have no impact on runtime
code execution.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/ieee80211/ieee80211_module.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
b/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
index bd64d126ba2b..20348a1f2d32 100644
--- a/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
+++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
@@ -64,9 +64,9 @@ static inline int ieee80211_networks_allocate(struct
ieee80211_device *ieee)
if (ieee->networks)
return 0;
- ieee->networks = kcalloc(
- MAX_NETWORK_COUNT, sizeof(struct ieee80211_network),
- GFP_KERNEL);
+ ieee->networks = kcalloc(MAX_NETWORK_COUNT,
+sizeof(struct ieee80211_network),
+GFP_KERNEL);
if (!ieee->networks) {
printk(KERN_WARNING "%s: Out of memory allocating beacons\n",
ieee->dev->name);
--
2.19.0
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 00/11] staging:rtl8192u: Coding Style changes
Just a number of simple coding style changes in the file ieee80211_module.c John Whitmore (11): staging:rtl8192u: Add missing SPDX-License-Identifier - Style staging:rtl8192u: Removed commented out include - Style staging:rtl8192u: Clear error with line ending ( - Style staging:rtl8192u: Remove extra blank lines - Style staging:rtl8192u: Add spaces around + operator - Style staging:rtl8192u: Rewrite test for null - Style staging:rtl8192u: Correct code indentation - Style staging:rtl8192u: Add missing blank lines - Style staging:rtl8192u: Remove unnecessary line continuation - Style staging:rtl8192u: Correct code alignment - Style staging:rtl8192u: Correct comparison with NULL - Style .../rtl8192u/ieee80211/ieee80211_module.c | 32 +-- 1 file changed, 15 insertions(+), 17 deletions(-) -- 2.19.0 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 08/11] staging:rtl8192u: Add missing blank lines - Style
Add missing blank lines after declarations. This clears the resulting
checkpatch issue.
This is a simple coding style change which should not impact runtime
code execution.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/ieee80211/ieee80211_module.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
b/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
index c31db21f7e63..f134cd5a9829 100644
--- a/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
+++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
@@ -199,6 +199,7 @@ void free_ieee80211(struct net_device *dev)
for (i = 0; i < WEP_KEYS; i++) {
struct ieee80211_crypt_data *crypt = ieee->crypt[i];
+
if (crypt) {
if (crypt->ops)
crypt->ops->deinit(crypt->priv);
@@ -248,6 +249,7 @@ static ssize_t write_debug_level(struct file *file, const
char __user *buffer,
{
unsigned long val;
int err = kstrtoul_from_user(buffer, count, 0, );
+
if (err)
return err;
ieee80211_debug_level = val;
--
2.19.0
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 11/11] staging:rtl8192u: Correct comparison with NULL - Style
Correct code to remote comparison with NULL, this clears the resulting
checkpatch issue.
This is a coding style change which should not impact runtime code
execution.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/ieee80211/ieee80211_module.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
b/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
index 5dc780119eff..57127d2a462a 100644
--- a/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
+++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
@@ -275,7 +275,7 @@ int __init ieee80211_debug_init(void)
ieee80211_debug_level = debug;
ieee80211_proc = proc_mkdir(DRV_NAME, init_net.proc_net);
- if (ieee80211_proc == NULL) {
+ if (!ieee80211_proc) {
IEEE80211_ERROR("Unable to create " DRV_NAME
" proc directory\n");
return -EIO;
--
2.19.0
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 07/11] staging:rtl8192u: Correct code indentation - Style
Rewrite code block to correct the indentation of code. This clears the
resulting checkpatch issue.
This is a coding style change which should not impact runtime code
execution.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/ieee80211/ieee80211_module.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
b/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
index 9bbacec52e1f..c31db21f7e63 100644
--- a/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
+++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
@@ -167,9 +167,9 @@ struct net_device *alloc_ieee80211(int sizeof_priv)
INIT_LIST_HEAD(>ibss_mac_hash[i]);
for (i = 0; i < 17; i++) {
- ieee->last_rxseq_num[i] = -1;
- ieee->last_rxfrag_num[i] = -1;
- ieee->last_packet_time[i] = 0;
+ ieee->last_rxseq_num[i] = -1;
+ ieee->last_rxfrag_num[i] = -1;
+ ieee->last_packet_time[i] = 0;
}
/* These function were added to load crypte module autoly */
--
2.19.0
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 06/11] staging:rtl8192u: Rewrite test for null - Style
Rewrite a test for NULL to comply with the coding style and clear the
checkpatch issue.
This is a coding style change which should not impact runtime
code execution.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/ieee80211/ieee80211_module.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
b/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
index 0fe65dd8c407..9bbacec52e1f 100644
--- a/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
+++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
@@ -155,7 +155,7 @@ struct net_device *alloc_ieee80211(int sizeof_priv)
ieee80211_softmac_init(ieee);
ieee->pHTInfo = kzalloc(sizeof(RT_HIGH_THROUGHPUT), GFP_KERNEL);
- if (ieee->pHTInfo == NULL) {
+ if (!ieee->pHTInfo) {
IEEE80211_DEBUG(IEEE80211_DL_ERR, "can't alloc memory for
HTInfo\n");
goto failed;
}
--
2.19.0
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 04/11] staging:rtl8192u: Remove extra blank lines - Style
Remove the extra blank lines to clear checkpatch issue.
This is a simple coding style change which should have no impact
on runtime code execution.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/ieee80211/ieee80211_module.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
b/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
index 20348a1f2d32..c52eac0bf6f6 100644
--- a/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
+++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
@@ -94,7 +94,6 @@ static inline void ieee80211_networks_initialize(struct
ieee80211_device *ieee)
list_add_tail(>networks[i].list,
>network_free_list);
}
-
struct net_device *alloc_ieee80211(int sizeof_priv)
{
struct ieee80211_device *ieee;
@@ -121,7 +120,6 @@ struct net_device *alloc_ieee80211(int sizeof_priv)
}
ieee80211_networks_initialize(ieee);
-
/* Default fragmentation threshold is maximum payload size */
ieee->fts = DEFAULT_FTS;
ieee->scan_age = DEFAULT_MAX_SCAN_AGE;
@@ -186,7 +184,6 @@ struct net_device *alloc_ieee80211(int sizeof_priv)
return NULL;
}
-
void free_ieee80211(struct net_device *dev)
{
struct ieee80211_device *ieee = netdev_priv(dev);
--
2.19.0
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 01/11] staging:rtl8192u: Add missing SPDX-License-Identifier - Style
Add the missing SPDX-License-Identifier tag to file to clear the checkpatch issue. This is a coding style change which should have no impact on runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/ieee80211_module.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c index 90a097f2cd4e..5f8229f2c757 100644 --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c @@ -1,3 +1,4 @@ +// SPDX-License-Identifier: GPL-2.0 /*** * * Copyright(c) 2004 Intel Corporation. All rights reserved. -- 2.19.0 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 02/11] staging:rtl8192u: Removed commented out include - Style
Remove commented out #include directive. Additionally shorted a block comment to clear the checkpatch issue with line length. These are coding style changes which should have no impact on runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/ieee80211_module.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c index 5f8229f2c757..bd64d126ba2b 100644 --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c @@ -29,10 +29,9 @@ * James P. Ketrenos * Intel Corporation, 5200 N.E. Elam Young Parkway, Hillsboro, OR 97124-6497 * - ***/ + **/ #include -/* #include */ #include #include #include -- 2.19.0 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 05/11] staging:rtl8192u: Add spaces around + operator - Style
Add spaces around '+' operator to clear the checkpatch issue. This is a coding style change which should have no impact on runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/ieee80211_module.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c index c52eac0bf6f6..0fe65dd8c407 100644 --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c @@ -109,7 +109,7 @@ struct net_device *alloc_ieee80211(int sizeof_priv) } ieee = netdev_priv(dev); - memset(ieee, 0, sizeof(struct ieee80211_device)+sizeof_priv); + memset(ieee, 0, sizeof(struct ieee80211_device) + sizeof_priv); ieee->dev = dev; err = ieee80211_networks_allocate(ieee); -- 2.19.0 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: iio: adt7316: fix parenthesis alignment
On Thu, 4 Oct 2018 20:06:55 -0300
Renato Lui Geh wrote:
> This patch fixes all "Alignment should match open parenthesis" check
> warnings found by checkpatch.pl in the addac/adt7316 driver.
>
> Signed-off-by: Renato Lui Geh
Hi,
Mostly good, but alignment doesn't override other considerations such
as consistency in argument naming.
Thanks,
Jonathan
> ---
> drivers/staging/iio/addac/adt7316.c | 462 ++--
> drivers/staging/iio/addac/adt7316.h | 2 +-
> 2 files changed, 233 insertions(+), 231 deletions(-)
>
...
> @@ -1363,9 +1365,9 @@ static ssize_t
> adt7316_show_in_analog_temp_offset(struct device *dev,
> }
>
> static ssize_t adt7316_store_in_analog_temp_offset(struct device *dev,
> - struct device_attribute *attr,
> - const char *buf,
> - size_t len)
> +struct device_attribute *att,
I wasn't expecting to see a rename in here. I know it's not a big thing
as the parameter isn't even used, but it is better to have consistency
of naming than a minor improvement in alignment.
> +const char *buf,
> +size_t len)
> {
>
> static ssize_t adt7316_store_ex_analog_temp_offset(struct device *dev,
> - struct device_attribute *attr,
> - const char *buf,
> - size_t len)
> +struct device_attribute *att,
Same here...
> +const char *buf,
> +size_t len)
> {
> struct iio_dev *dev_info = dev_to_iio_dev(dev);
> struct adt7316_chip_info *chip = iio_priv(dev_info);
...
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v2 2/2] staging: iio: cdc: ad7150: fix misaligned lines
On Fri, 5 Oct 2018 10:05:15 +0200 Slawomir Stepien wrote: > These lines were misaligned, but the checkpatch.pl didn't indicate them > as such. > > Signed-off-by: Slawomir Stepien Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to play with it. Thanks, Jonathan > --- > drivers/staging/iio/cdc/ad7150.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/iio/cdc/ad7150.c > b/drivers/staging/iio/cdc/ad7150.c > index e2c70063fa0f..24f74ce60f80 100644 > --- a/drivers/staging/iio/cdc/ad7150.c > +++ b/drivers/staging/iio/cdc/ad7150.c > @@ -183,8 +183,8 @@ static int ad7150_write_event_params(struct iio_dev > *indio_dev, > case IIO_EV_TYPE_THRESH: > value = chip->threshold[rising][chan]; > return i2c_smbus_write_word_data(chip->client, > - ad7150_addresses[chan][3], > - swab16(value)); > + ad7150_addresses[chan][3], > + swab16(value)); > case IIO_EV_TYPE_MAG_ADAPTIVE: > sens = chip->mag_sensitivity[rising][chan]; > timeout = chip->mag_timeout[rising][chan]; ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v2 1/2] staging: iio: cdc: ad7150: use value copy to shorten the line length
On Fri, 5 Oct 2018 10:04:44 +0200
Slawomir Stepien wrote:
> By using the copy of channel attribute, we can now make the lines short
> enough to eliminate the checkpatch.pl problem:
>
> CHECK: Alignment should match open parenthesis
>
> Signed-off-by: Slawomir Stepien
Applied to the togreg branch of iio.git and pushed out as testing for the
autobuilders to play with it.
Thanks,
Jonathan
> ---
> drivers/staging/iio/cdc/ad7150.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/iio/cdc/ad7150.c
> b/drivers/staging/iio/cdc/ad7150.c
> index d16084d7068c..e2c70063fa0f 100644
> --- a/drivers/staging/iio/cdc/ad7150.c
> +++ b/drivers/staging/iio/cdc/ad7150.c
> @@ -102,18 +102,19 @@ static int ad7150_read_raw(struct iio_dev *indio_dev,
> {
> int ret;
> struct ad7150_chip_info *chip = iio_priv(indio_dev);
> + int channel = chan->channel;
>
> switch (mask) {
> case IIO_CHAN_INFO_RAW:
> ret = i2c_smbus_read_word_data(chip->client,
> - ad7150_addresses[chan->channel][0]);
> +ad7150_addresses[channel][0]);
> if (ret < 0)
> return ret;
> *val = swab16(ret);
> return IIO_VAL_INT;
> case IIO_CHAN_INFO_AVERAGE_RAW:
> ret = i2c_smbus_read_word_data(chip->client,
> - ad7150_addresses[chan->channel][1]);
> +ad7150_addresses[channel][1]);
> if (ret < 0)
> return ret;
> *val = swab16(ret);
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: iio: ad2s1210: fix 'assignment operator' style checks
On Fri, Oct 05, 2018 at 10:24:26PM -0300, Matheus Tavares Bernardino wrote: > This patch fixes all "Assignment operator '=' should be on the previous > line" checks found in ad2s1210.c by checkpatch.pl. > > Signed-off-by: Matheus Tavares > --- As already pointed out tabs -> whitespace issue. I assume you attached or copied the patch into your email client and sent it. Usually, these clients wrap the message which leads to patch corruption and hence it would apply to the maintainer's git tree cleanly. Therefore, I would suggest using `git send-email`. Also, as a safety measure you may use the `--dry-run` flag of `git send-email` to see how it would look like when you send the patch. Thanks -- Himanshu Jha Undergraduate Student Department of Electronics & Communication Guru Tegh Bahadur Institute of Technology ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: iio: ad2s1210: fix 'assignment operator' style checks
On Fri, 5 Oct 2018 22:24:26 -0300
Matheus Tavares Bernardino wrote:
> This patch fixes all "Assignment operator '=' should be on the previous
> line" checks found in ad2s1210.c by checkpatch.pl.
>
> Signed-off-by: Matheus Tavares
Hi Matheus,
Good change, but unfortunately your email client as converted
tabs into spaces so it cannot be applied. Try git am
with this email and you'll see what I mean.
See Documentation/process/email-clients.rst for some hints on this.
Looking forward to V2 with that fixed!
Thanks,
Jonathan
> ---
> drivers/staging/iio/resolver/ad2s1210.c | 8
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/iio/resolver/ad2s1210.c
> b/drivers/staging/iio/resolver/ad2s1210.c
> index ac13b99bd9cb..d4b1c2c010f2 100644
> --- a/drivers/staging/iio/resolver/ad2s1210.c
> +++ b/drivers/staging/iio/resolver/ad2s1210.c
> @@ -301,8 +301,8 @@ static ssize_t ad2s1210_store_control(struct device *dev,
> "ad2s1210: write control register fail\n");
> goto error_ret;
> }
> -st->resolution
> -= ad2s1210_resolution_value[data & AD2S1210_SET_RESOLUTION];
> +st->resolution =
> +ad2s1210_resolution_value[data & AD2S1210_SET_RESOLUTION];
> if (st->pdata->gpioin) {
> data = ad2s1210_read_resolution_pin(st);
> if (data != st->resolution)
> @@ -363,8 +363,8 @@ static ssize_t ad2s1210_store_resolution(struct device
> *dev,
> dev_err(dev, "ad2s1210: setting resolution fail\n");
> goto error_ret;
> }
> -st->resolution
> -= ad2s1210_resolution_value[data & AD2S1210_SET_RESOLUTION];
> +st->resolution =
> +ad2s1210_resolution_value[data & AD2S1210_SET_RESOLUTION];
> if (st->pdata->gpioin) {
> data = ad2s1210_read_resolution_pin(st);
> if (data != st->resolution)
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
