Re: [PATCH 1/2] staging: iio: adc: ad7192: Add clock for external clock reference

2019-01-24 Thread Stephen Boyd
Quoting Jonathan Cameron (2018-12-16 02:07:41) > Rob, Clk experts, questions for you below. > > Jonathan > > > On Thu, 13 Dec 2018 17:39:22 -0800 > Stephen Boyd wrote: > > > Quoting Jonathan Cameron (2018-12-08 07:29:54) > > > On Thu, 6 Dec 2018 11:10:51 +0200 > > > Mircea Caprioru wrote: >

[PATCH] staging:iio:ad7152: Rename misspelled RESEVERD -> RESERVED

2019-01-24 Thread Rodrigo Ribeiro
Remove the checkpatch.pl check: CHECK: 'RESEVERD' may be misspelled - perhaps 'RESERVED'? Signed-off-by: Rodrigo Ribeiro Signed-off-by: Rafael Tsuha --- This macro is not used anywhere. Should we just correct the spelling or remove the macro? drivers/staging/iio/cdc/ad7152.c | 2 +- 1 file

Re: [PATCH] staging: android: ion: Allocate from heap ID directly without mask

2019-01-24 Thread Brian Starkey
On Thu, Jan 24, 2019 at 10:12:10AM -0600, Andrew F. Davis wrote: > On 1/24/19 9:24 AM, Brian Starkey wrote: [snip] > > > > What do you think about renaming ion_allocation_data.unused to heap_id > > and adding a flag instead? It's adding cruft to a staging API, but it > > might soften the

Re: [PATCH 13/14] staging: android: ion: Do not sync CPU cache on map/unmap

2019-01-24 Thread Brian Starkey
On Thu, Jan 24, 2019 at 10:04:46AM -0600, Andrew F. Davis wrote: > On 1/23/19 11:11 AM, Brian Starkey wrote: [snip] > > I'm very new to all this, so any pointers to history in this area are > appreciated. > [snip] > > > In case you didn't come across it already, the effort which seems to >

Re: [PATCH] staging: android: ion: Allocate from heap ID directly without mask

2019-01-24 Thread Andrew F. Davis
On 1/24/19 9:24 AM, Brian Starkey wrote: > Hi Andrew, > > On Wed, Jan 23, 2019 at 01:28:35PM -0600, Andrew F. Davis wrote: >> Previously the heap to allocate from was selected by a mask of allowed >> heap types. This may have been done as a primitive form of constraint >> solving, the first heap

[PATCH v11 03/13] media: staging/imx7: add imx7 CSI subdev driver

2019-01-24 Thread Rui Miguel Silva
This add the media entity subdevice and control driver for the i.MX7 CMOS Sensor Interface. Signed-off-by: Rui Miguel Silva --- drivers/staging/media/imx/imx7-media-csi.c | 1360 1 file changed, 1360 insertions(+) create mode 100644

[PATCH v11 12/13] media: video-mux: add bayer formats

2019-01-24 Thread Rui Miguel Silva
Add non vendor bayer formats to the allowed format array. Signed-off-by: Rui Miguel Silva Reviewed-by: Philipp Zabel --- drivers/media/platform/video-mux.c | 20 1 file changed, 20 insertions(+) diff --git a/drivers/media/platform/video-mux.c

[PATCH v11 08/13] ARM: dts: imx7: Add video mux, csi and mipi_csi and connections

2019-01-24 Thread Rui Miguel Silva
This patch adds the device tree nodes for csi, video multiplexer and mipi-csi besides the graph connecting the necessary endpoints to make the media capture entities to work in imx7 Warp board. Signed-off-by: Rui Miguel Silva --- arch/arm/boot/dts/imx7s-warp.dts | 51

[PATCH v11 04/13] media: staging/imx7: add imx7 CSI subdev driver

2019-01-24 Thread Rui Miguel Silva
This add the media entity subdevice and control driver for the i.MX7 CMOS Sensor Interface. Signed-off-by: Rui Miguel Silva --- drivers/staging/media/imx/Kconfig | 9 - drivers/staging/media/imx/Makefile | 2 ++ 2 files changed, 10 insertions(+), 1 deletion(-) diff --git

[PATCH v11 00/13] media: staging/imx7: add i.MX7 media driver

2019-01-24 Thread Rui Miguel Silva
Hi, This series introduces the Media driver to work with the i.MX7 SoC. it uses the already existing imx media core drivers but since the i.MX7, contrary to i.MX5/6, do not have an IPU and because of that some changes in the imx media core are made along this series to make it support that case.

[PATCH v11 05/13] media: staging/imx7: add MIPI CSI-2 receiver subdev for i.MX7

2019-01-24 Thread Rui Miguel Silva
Adds MIPI CSI-2 subdev for i.MX7 to connect with sensors with a MIPI CSI-2 interface. Signed-off-by: Rui Miguel Silva --- drivers/staging/media/imx/Makefile |1 + drivers/staging/media/imx/imx7-mipi-csis.c | 1184 2 files changed, 1185 insertions(+) create mode

[PATCH v11 09/13] ARM: dts: imx7s-warp: add ov2680 sensor node

2019-01-24 Thread Rui Miguel Silva
Warp7 comes with a Omnivision OV2680 sensor, add the node here to make complete the camera data path for this system. Add the needed regulator to the analog voltage supply, the port and endpoints in mipi_csi node and the pinctrl for the reset gpio. Signed-off-by: Rui Miguel Silva ---

[PATCH v11 13/13] media: MAINTAINERS: add entry for Freescale i.MX7 media driver

2019-01-24 Thread Rui Miguel Silva
Add maintainer entry for the imx7 media csi, mipi csis driver, dt-bindings and documentation. Signed-off-by: Rui Miguel Silva --- MAINTAINERS | 11 +++ 1 file changed, 11 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 51029a425dbe..ad267b3dd18b 100644 --- a/MAINTAINERS +++

[PATCH v11 11/13] media: staging/imx: add i.MX7 entries to TODO file

2019-01-24 Thread Rui Miguel Silva
Add some i.MX7 related entries to TODO file. Signed-off-by: Rui Miguel Silva --- drivers/staging/media/imx/TODO | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/staging/media/imx/TODO b/drivers/staging/media/imx/TODO index aeeb15494a49..6f29b5ca5324 100644 ---

[PATCH v11 06/13] ARM: dts: imx7s: add mipi phy power domain

2019-01-24 Thread Rui Miguel Silva
Add power domain index 0 related with mipi-phy to imx7s. While at it rename pcie power-domain node to remove pgc prefix. Signed-off-by: Rui Miguel Silva --- arch/arm/boot/dts/imx7s.dtsi | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/imx7s.dtsi

[PATCH v11 10/13] media: imx7.rst: add documentation for i.MX7 media driver

2019-01-24 Thread Rui Miguel Silva
Add rst document to describe the i.MX7 media driver and also a working example from the Warp7 board usage with a OV2680 sensor. Signed-off-by: Rui Miguel Silva --- Documentation/media/v4l-drivers/imx7.rst | 157 ++ Documentation/media/v4l-drivers/index.rst | 1 + 2 files

[PATCH v11 07/13] ARM: dts: imx7s: add multiplexer controls

2019-01-24 Thread Rui Miguel Silva
The IOMUXC General Purpose Register has bitfield to control video bus multiplexer to control the CSI input between the MIPI-CSI2 and parallel interface. Add that register and mask. Signed-off-by: Rui Miguel Silva Reviewed-by: Philipp Zabel --- arch/arm/boot/dts/imx7s.dtsi | 9 - 1 file

[PATCH v11 02/13] media: dt-bindings: add bindings for i.MX7 media driver

2019-01-24 Thread Rui Miguel Silva
Add bindings documentation for i.MX7 media drivers. The imx7 MIPI CSI2 and imx7 CMOS Sensor Interface. Signed-off-by: Rui Miguel Silva Reviewed-by: Rob Herring Acked-by: Sakari Ailus --- .../devicetree/bindings/media/imx7-csi.txt| 45 ++ .../bindings/media/imx7-mipi-csi2.txt

[PATCH v11 01/13] media: staging/imx: rearrange group id to take in account IPU

2019-01-24 Thread Rui Miguel Silva
Some imx system do not have IPU, so prepare the imx media drivers to support this kind of devices. Rename the group ids to include an _IPU_ prefix, add a new group id to support systems with only a CSI without IPU, and also rename the create internal links to make it clear that only systems with

Re: [PATCH 13/14] staging: android: ion: Do not sync CPU cache on map/unmap

2019-01-24 Thread Andrew F. Davis
On 1/23/19 11:11 AM, Brian Starkey wrote: > Hi Andrew, > > On Wed, Jan 23, 2019 at 10:51:24AM -0600, Andrew F. Davis wrote: >> On 1/22/19 11:33 AM, Sumit Semwal wrote: >>> Hello everyone, >>> >>> Sincere apologies for chiming in a bit late here, but was off due to >>> some health issues. >>> >>

Re: [PATCH] staging: android: ion: Allocate from heap ID directly without mask

2019-01-24 Thread Brian Starkey
Hi Andrew, On Wed, Jan 23, 2019 at 01:28:35PM -0600, Andrew F. Davis wrote: > Previously the heap to allocate from was selected by a mask of allowed > heap types. This may have been done as a primitive form of constraint > solving, the first heap type that matched any set bit of the heap mask >

Re: [PATCH 1/2] PCI: hv: Replace hv_vp_set with hv_vpset

2019-01-24 Thread Vitaly Kuznetsov
Maya Nakamura writes: > Remove a duplicate definition of VP set (hv_vp_set) and use the common > definition (hv_vpset) that is used in other places. > > Signed-off-by: Maya Nakamura > --- > drivers/pci/controller/pci-hyperv.c | 25 - > 1 file changed, 12 insertions(+),

Re: [PATCH v2 2/2] media: cedrus: Add HEVC/H.265 decoding support

2019-01-24 Thread Paul Kocialkowski
Hi, On Tue, 2018-11-27 at 09:21 +0100, Maxime Ripard wrote: > Hi! > > On Fri, Nov 23, 2018 at 02:02:09PM +0100, Paul Kocialkowski wrote: > > This introduces support for HEVC/H.265 to the Cedrus VPU driver, with > > both uni-directional and bi-directional prediction modes supported. > > > >

[PATCH v2] Revert "media: cedrus: Allow using the current dst buffer as reference"

2019-01-24 Thread Paul Kocialkowski
This reverts commit cf20ae1535eb690a87c29b9cc7af51881384e967. The vb2_find_timestamp helper was modified to allow finding buffers regardless of their current state in the queue. This means that we no longer have to take particular care of references to the current capture buffer. Signed-off-by:

Re: [PATCH] Revert "media: cedrus: Allow using the current dst buffer as reference"

2019-01-24 Thread Paul Kocialkowski
Hi, On Thu, 2019-01-24 at 11:32 +0100, Greg KH wrote: > On Thu, Jan 24, 2019 at 10:55:42AM +0100, Paul Kocialkowski wrote: > > This reverts commit cf20ae1535eb690a87c29b9cc7af51881384e967. > > > > The vb2_find_timestamp helper was modified to allow finding buffers > > regardless of their current

Re: [PATCH 2/2] PCI: hv: Refactor hv_irq_unmask() to use cpumask_to_vpset()

2019-01-24 Thread Dan Carpenter
On Wed, Jan 23, 2019 at 01:02:12PM -0800, Maya Nakamura wrote: > @@ -908,12 +906,12 @@ static void hv_irq_unmask(struct irq_data *data) > struct retarget_msi_interrupt *params; > struct hv_pcibus_device *hbus; > struct cpumask *dest; > + cpumask_var_t tmp; > struct

Re: [linux-sunxi] [PATCH v2 1/2] media: v4l: Add definitions for the HEVC slice format and controls

2019-01-24 Thread Ayaka
Sent from my iPad > On Jan 24, 2019, at 6:27 PM, Paul Kocialkowski > wrote: > > Hi, > >> On Thu, 2019-01-10 at 21:32 +0800, ayaka wrote: >> I forget a important thing, for the rkvdec and rk hevc decoder, it would >> requests cabac table, scaling list, picture parameter set and reference

Re: [linux-sunxi] [PATCH v2 1/2] media: v4l: Add definitions for the HEVC slice format and controls

2019-01-24 Thread Ayaka
Sent from my iPad > On Jan 24, 2019, at 6:36 PM, Paul Kocialkowski > wrote: > > Hi, > >> On Tue, 2019-01-08 at 18:00 +0800, Ayaka wrote: >> >> Sent from my iPad >> >>> On Jan 8, 2019, at 4:38 PM, Paul Kocialkowski >>> wrote: >>> >>> Hi, >>> On Tue, 2019-01-08 at 09:16 +0800,

Re: [PATCH v10 12/13] media: video-mux: add bayer formats

2019-01-24 Thread Philipp Zabel
On Wed, 2019-01-23 at 10:52 +, Rui Miguel Silva wrote: > Add non vendor bayer formats to the allowed format array. > > Signed-off-by: Rui Miguel Silva > --- > drivers/media/platform/video-mux.c | 20 > 1 file changed, 20 insertions(+) > > diff --git

Re: [PATCH v10 01/13] media: staging/imx: refactor imx media device probe

2019-01-24 Thread Sakari Ailus
Hi Rui, On Wed, Jan 23, 2019 at 10:52:10AM +, Rui Miguel Silva wrote: > Refactor and move media device initialization code to a new common > module, so it can be used by other devices, this will allow for example > a near to introduce imx7 CSI driver, to use this media device. > >

Re: [linux-sunxi] [PATCH v2 1/2] media: v4l: Add definitions for the HEVC slice format and controls

2019-01-24 Thread Paul Kocialkowski
Hi, On Tue, 2019-01-08 at 18:00 +0800, Ayaka wrote: > > Sent from my iPad > > > On Jan 8, 2019, at 4:38 PM, Paul Kocialkowski > > wrote: > > > > Hi, > > > > > On Tue, 2019-01-08 at 09:16 +0800, Ayaka wrote: > > > > > > Sent from my iPad > > > > > > > On Jan 7, 2019, at 5:57 PM, Paul

Re: [PATCH] Revert "media: cedrus: Allow using the current dst buffer as reference"

2019-01-24 Thread Greg KH
On Thu, Jan 24, 2019 at 10:55:42AM +0100, Paul Kocialkowski wrote: > This reverts commit cf20ae1535eb690a87c29b9cc7af51881384e967. > > The vb2_find_timestamp helper was modified to allow finding buffers > regardless of their current state in the queue. This means that we > no longer have to take

Re: [linux-sunxi] [PATCH v2 1/2] media: v4l: Add definitions for the HEVC slice format and controls

2019-01-24 Thread Paul Kocialkowski
Hi, On Thu, 2019-01-10 at 21:32 +0800, ayaka wrote: > I forget a important thing, for the rkvdec and rk hevc decoder, it would > requests cabac table, scaling list, picture parameter set and reference > picture storing in one or various of DMA buffers. I am not talking about > the data been

[PATCH] Revert "media: cedrus: Allow using the current dst buffer as reference"

2019-01-24 Thread Paul Kocialkowski
This reverts commit cf20ae1535eb690a87c29b9cc7af51881384e967. The vb2_find_timestamp helper was modified to allow finding buffers regardless of their current state in the queue. This means that we no longer have to take particular care of references to the current capture buffer. ---

[PATCH 2/2] media: cedrus: Remove completed item from TODO list (dma-buf references)

2019-01-24 Thread Paul Kocialkowski
Access to reference frames that were imported from dma-buf was taken care of and is no longer a pending item on the driver's TODO list. Signed-off-by: Paul Kocialkowski --- drivers/staging/media/sunxi/cedrus/TODO | 5 - 1 file changed, 5 deletions(-) diff --git

[PATCH 1/2] media: vb2: Keep dma-buf buffers mapped until they are freed

2019-01-24 Thread Paul Kocialkowski
From: Pawel Osciak When using vb2 for video decoding, dequeued capture buffers may still be accessed by the hardware: this is the case when they are used as reference frames for decoding subsequent frames. When the buffer is imported with dma-buf, it needs to be mapped before access. Until now,

Re: [PATCH] staging: erofs: fix potential double iput in erofs_read_super()

2019-01-24 Thread Chao Yu
On 2019/1/23 14:12, Chengguang Xu wrote: > Some error cases like failing from d_make_root() will > cause double iput because d_make_root() also does iput > in its error path. > > Signed-off-by: Chengguang Xu Reviewed-by: Chao Yu Thanks, ___ devel