Re: [PATCH v2] nfit: add Hyper-V NVDIMM DSM command set to white list

2019-02-01 Thread Dan Williams
On Fri, Feb 1, 2019 at 7:32 PM Dexuan Cui wrote: > > > From: Dan Williams > > Sent: Friday, February 1, 2019 5:29 PM > > ... > > Honestly, the quickest path to something functional for Linux is to > > simply delete the _LSR support and use raw mode defined namespaces. > > Why have labels if they

Re: [PATCH v2] nfit: add Hyper-V NVDIMM DSM command set to white list

2019-02-01 Thread Dan Williams
On Fri, Feb 1, 2019 at 6:17 PM Dexuan Cui wrote: > > From: Dan Williams [..] > > Honestly, the quickest path to something functional for Linux is to > > simply delete the _LSR support and use raw mode defined namespaces. > > Why have labels if they are read-only and the region is sufficient for

Re: [RFC net-next 11/13] nfp: Handle SWITCHDEV_PORT_ATTR_GET event

2019-02-01 Thread Florian Fainelli
Le 2/1/19 à 7:45 PM, Jakub Kicinski a écrit : > On Fri, 1 Feb 2019 14:06:55 -0800, Florian Fainelli wrote: >> Following patches will change the way we communicate getting or setting >> a port's attribute and use a blocking notifier to perform those tasks. >> >> Prepare nfp to support receiving

Re: [RFC net-next 11/13] nfp: Handle SWITCHDEV_PORT_ATTR_GET event

2019-02-01 Thread Jakub Kicinski
On Fri, 1 Feb 2019 14:06:55 -0800, Florian Fainelli wrote: > Following patches will change the way we communicate getting or setting > a port's attribute and use a blocking notifier to perform those tasks. > > Prepare nfp to support receiving notifier events targeting > SWITCHDEV_PORT_ATTR_GET

RE: [PATCH v2] nfit: add Hyper-V NVDIMM DSM command set to white list

2019-02-01 Thread Dexuan Cui
> From: Dan Williams > Sent: Friday, February 1, 2019 5:29 PM > ... > Honestly, the quickest path to something functional for Linux is to > simply delete the _LSR support and use raw mode defined namespaces. > Why have labels if they are read-only and the region is sufficient for > defining

RE: [PATCH v2] nfit: add Hyper-V NVDIMM DSM command set to white list

2019-02-01 Thread Dexuan Cui
> From: Dan Williams > Sent: Friday, February 1, 2019 5:29 PM > > ... > > The "size" and "mode" still don't look right, but the improvement is that > > now I can see a good descriptive "name", which I suppose is retrieved > > from Hyper-V. > > Mode is right, there is no way for Hyper-V to create

[PATCH V2 00/10] X86/KVM/Hyper-V: Add HV ept tlb range list flush support in KVM

2019-02-01 Thread lantianyu1986
From: Lan Tianyu This patchset is to introduce hv ept tlb range list flush function support in the KVM MMU component. Flushing ept tlbs of several address range can be done via single hypercall and new list flush function is used in the kvm_mmu_commit_zap_page() and FNAME(sync_page). This

[PATCH V2 1/10] X86/Hyper-V: Add parameter offset for hyperv_fill_flush_guest_mapping_list()

2019-02-01 Thread lantianyu1986
From: Lan Tianyu Add parameter offset to specify start position to add flush ranges in guest address list of struct hv_guest_mapping_flush_list. Signed-off-by: Lan Tianyu --- arch/x86/hyperv/nested.c| 4 ++-- arch/x86/include/asm/mshyperv.h | 2 +- arch/x86/kvm/vmx/vmx.c | 2

Re: [PATCH v2] nfit: add Hyper-V NVDIMM DSM command set to white list

2019-02-01 Thread Dan Williams
On Fri, Feb 1, 2019 at 5:06 PM Dexuan Cui wrote: > > > From: Linux-nvdimm On Behalf Of > > Dexuan Cui > > Sent: Friday, February 1, 2019 4:34 PM > > > > > ... > > > > > Those reads find a namespace index block > > > > > and a label. Unfortunately the label has the LOCAL flag set and Linux > > >

RE: [PATCH v2] nfit: add Hyper-V NVDIMM DSM command set to white list

2019-02-01 Thread Dexuan Cui
> From: Linux-nvdimm On Behalf Of > Dexuan Cui > Sent: Friday, February 1, 2019 4:34 PM > > > > ... > > > > Those reads find a namespace index block > > > > and a label. Unfortunately the label has the LOCAL flag set and Linux > > > > explicitly ignores pmem namespace labels with that bit set.

Re: [PATCH v2] nfit: add Hyper-V NVDIMM DSM command set to white list

2019-02-01 Thread Dan Williams
On Fri, Feb 1, 2019 at 4:34 PM Dexuan Cui wrote: > > > From: Dan Williams > > Sent: Friday, February 1, 2019 3:47 PM > > To: Dexuan Cui > > > > I believe it's the same reason. Without 11189c1089da the _LSR method > > will fail, and otherwise it works and finds the label that it doesn't > >

RE: [PATCH v2] nfit: add Hyper-V NVDIMM DSM command set to white list

2019-02-01 Thread Dexuan Cui
> From: Dan Williams > Sent: Friday, February 1, 2019 3:47 PM > To: Dexuan Cui > > I believe it's the same reason. Without 11189c1089da the _LSR method > will fail, and otherwise it works and finds the label that it doesn't > like. Exactly. > I'm not seeing "invalid" data in your failure log.

Re: [PATCH v2] nfit: add Hyper-V NVDIMM DSM command set to white list

2019-02-01 Thread Dan Williams
On Fri, Feb 1, 2019 at 3:17 PM Dexuan Cui wrote: > > > From: Dan Williams > > Sent: Friday, February 1, 2019 9:29 AM > > > Hi Dan, > > > Unluckily it looks this commit causes a regression ... > > > With the patch, "ndctl list" shows nothing, and /dev/pmem0 can't appear. > > > If I revert the

RE: [PATCH v2] nfit: add Hyper-V NVDIMM DSM command set to white list

2019-02-01 Thread Dexuan Cui
> From: Dan Williams > Sent: Friday, February 1, 2019 9:29 AM > > Hi Dan, > > Unluckily it looks this commit causes a regression ... > > With the patch, "ndctl list" shows nothing, and /dev/pmem0 can't appear. > > If I revert the patch, it will be back to normal. > > > > I attached the

[RFC net-next 06/13] staging: fsl-dpaa2: ethsw: Handle SWITCHDEV_PORT_ATTR_GET/SET

2019-02-01 Thread Florian Fainelli
Following patches will change the way we communicate getting or setting a port's attribute and use a blocking notifier to perform those tasks. Prepare ethsw to support receiving notifier events targeting SWITCHDEV_PORT_ATTR_GET/SET and simply translate that into the existing

[RFC net-next 09/13] mlxsw: switchx2: Handle SWITCHDEV_PORT_ATTR_GET event

2019-02-01 Thread Florian Fainelli
Following patches will change the way we communicate getting or setting a port's attribute and use a blocking notifier to perform those tasks. Prepare bnxt to support receiving notifier events targeting SWITCHDEV_PORT_ATTR_GET and simply translate that into the existing

[RFC net-next 12/13] netdevsim: Handle SWITCHDEV_PORT_ATTR_GET event

2019-02-01 Thread Florian Fainelli
Following patches will change the way we communicate getting or setting a port's attribute and use a blocking notifier to perform those tasks. Prepare netdevsim to support receiving notifier events targeting SWITCHDEV_PORT_ATTR_GET and simply translate that into the existing

[RFC net-next 04/13] mlxsw: spectrum_switchdev: Handle SWITCHDEV_PORT_ATTR_GET/SET

2019-02-01 Thread Florian Fainelli
Following patches will change the way we communicate getting or setting a port's attribute and use a blocking notifier to perform those tasks. Prepare mlxsw to support receiving notifier events targeting SWITCHDEV_PORT_ATTR_GET/SET and simply translate that into the existing

[RFC net-next 08/13] liquidio: Handle SWITCHDEV_PORT_ATTR_GET event

2019-02-01 Thread Florian Fainelli
Following patches will change the way we communicate getting or setting a port's attribute and use a blocking notifier to perform those tasks. Prepare bnxt to support receiving notifier events targeting SWITCHDEV_PORT_ATTR_GET and simply translate that into the existing

[RFC net-next 11/13] nfp: Handle SWITCHDEV_PORT_ATTR_GET event

2019-02-01 Thread Florian Fainelli
Following patches will change the way we communicate getting or setting a port's attribute and use a blocking notifier to perform those tasks. Prepare nfp to support receiving notifier events targeting SWITCHDEV_PORT_ATTR_GET and simply translate that into the existing

[RFC net-next 10/13] net/mlx5e: Handle SWITCHDEV_PORT_ATTR_GET event

2019-02-01 Thread Florian Fainelli
Following patches will change the way we communicate getting or setting a port's attribute and use a blocking notifier to perform those tasks. Prepare mlx5e/en_rep.c to support receiving notifier events targeting SWITCHDEV_PORT_ATTR_GET and simply translate that into the existing

[RFC net-next 13/13] net: switchdev: Replace port attr get/set SDO with a notification

2019-02-01 Thread Florian Fainelli
Drop switchdev_ops.switchdev_port_attr_get and _set. Drop the uses of this field from all clients, which were migrated to use switchdev notification in the previous patches. Add a new function switchdev_port_attr_notify() that sends the switchdev notifications SWITCHDEV_PORT_ATTR_GET and _SET.

[RFC net-next 05/13] net: mscc: ocelot: Handle SWITCHDEV_PORT_ATTR_GET/SET

2019-02-01 Thread Florian Fainelli
Following patches will change the way we communicate getting or setting a port's attribute and use a blocking notifier to perform those tasks. Prepare ocelot to support receiving notifier events targeting SWITCHDEV_PORT_ATTR_GET/SET and simply translate that into the existing

[RFC net-next 07/13] bnxt: Handle SWITCHDEV_PORT_ATTR_GET event

2019-02-01 Thread Florian Fainelli
Following patches will change the way we communicate getting or setting a port's attribute and use a blocking notifier to perform those tasks. Prepare bnxt to support receiving notifier events targeting SWITCHDEV_PORT_ATTR_GET and simply translate that into the existing

[RFC net-next 03/13] net: dsa: Handle SWITCHDEV_PORT_ATTR_GET/SET

2019-02-01 Thread Florian Fainelli
Following patches will change the way we communicate getting or setting a port's attribute and use a blocking notifier to perform those tasks. Prepare DSA to support receiving notifier events targeting SWITCHDEV_PORT_ATTR_GET/SET and simply translate that into the existing

[RFC net-next 01/13] switchdev: Add SWITCHDEV_PORT_ATTR_SET, SWITCHDEV_PORT_ATTR_GET

2019-02-01 Thread Florian Fainelli
In preparation for allowing switchdev enabled drivers to veto specific attribute settings from within the context of the caller, introduce a new switchdev notifier type for port attributes. Suggested-by: Ido Schimmel Signed-off-by: Florian Fainelli --- include/net/switchdev.h | 10 ++

[RFC net-next 02/13] rocker: Handle SWITCHDEV_PORT_ATTR_GET/SET

2019-02-01 Thread Florian Fainelli
Following patches will change the way we communicate getting or setting a port's attribute and use a blocking notifier to perform those tasks. Prepare rocker to support receiving notifier events targeting SWITCHDEV_PORT_ATTR_GET/SET and simply translate that into the existing

[RFC net-next 00/13] Get rid of switchdev_ops

2019-02-01 Thread Florian Fainelli
Hi all, This patch series converts SWITCHDEV_PORT_ATTR_{GET,SET} to use a blocking notifier, similar to how SWITCHDEV_PORT_OBJ_{ADD,DEL} has been changed recently by Petr. This was suggested by Ido to help with a particular use case I have where I want to be able to veto a switchdev bridge

[PATCH v2 2/2] staging: iio: frequency: ad9833: Load clock using clock framework

2019-02-01 Thread Beniamin Bia
From: Beniamin Bia The clock frequency is loaded from device-tree using clock framework instead of statically value. The change allow configuration of the device via device-trees and better initialization sequence. This is part of broader effort to add device-tree support to this driver and take

RE: [PATCH] media: staging/intel-ipu3: Implement lock for stream on/off operations

2019-02-01 Thread Mani, Rajmohan
Hi Sakari, > Subject: Re: [PATCH] media: staging/intel-ipu3: Implement lock for stream > on/off operations > > Hi Raj, > > On Wed, Jan 30, 2019 at 05:17:15PM +, Mani, Rajmohan wrote: > > Hi Sakari, > > > > > -Original Message- > > > From: Sakari Ailus

[PATCH v2 1/2] staging: iio: frequency: ad9833: Get frequency value statically

2019-02-01 Thread Beniamin Bia
From: Beniamin Bia The values from platform data were replaced by statically values. This was just a intermediate step of taking this driver out of staging and load data from device tree. Signed-off-by: Beniamin Bia --- Changes in v2: - The platform data structure was removed and the

RE: [PATCH] Drivers: hv: vmbus: Add mutex lock to channel show functions

2019-02-01 Thread Dexuan Cui
> From: Kimberly Brown > Sent: Thursday, January 31, 2019 9:47 AM > ... > 2) Prevent a deadlock that can occur between the proposed mutex_lock() > call in the vmbus_chan_attr_show() function and the sysfs/kernfs functions. Hi Kim, Can you please share more details about the deadlock? It's

[driver-core:driver-core-testing 34/36] ERROR: "__arm_smccc_hvc" [drivers/firmware/stratix10-svc.ko] undefined!

2019-02-01 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git driver-core-testing head: 8d84b18f5678d3adfdb9375dfb0d968da2dc753d commit: 095ff29d2b882847f608cf7192361dedc22c0623 [34/36] firmware: intel_stratix10_service: add hardware dependency config: x86_64-allmodconfig

Re: [PATCH v2 1/2] staging: iio: ad7780: add gain & filter gpio support

2019-02-01 Thread Renato Lui Geh
On 02/01, Popa, Stefan Serban wrote: Adding support for gpios, normally doesn't have anything to do with the information stored in the iio_chan_spec struct. Also, we need to try to work with the already defined attributes. In your case, setting the gain GPIO is equivalent to modifying the

Re: [PATCH v2] nfit: add Hyper-V NVDIMM DSM command set to white list

2019-02-01 Thread Dan Williams
On Fri, Feb 1, 2019 at 9:14 AM Dexuan Cui wrote: > > > From: Dan Williams > > Sent: Tuesday, January 29, 2019 10:24 PM > > On Mon, Jan 28, 2019 at 4:56 PM Dexuan Cui wrote: > > > > > > > > > Add the Hyper-V _DSM command set to the white list of NVDIMM command > > > sets. > > > > > > Thanks Dan

Re: [PATCH] media: staging/intel-ipu3: Implement lock for stream on/off operations

2019-02-01 Thread Sakari Ailus
Hi Raj, On Wed, Jan 30, 2019 at 05:17:15PM +, Mani, Rajmohan wrote: > Hi Sakari, > > > -Original Message- > > From: Sakari Ailus [mailto:sakari.ai...@linux.intel.com] > > Sent: Wednesday, January 30, 2019 12:59 AM > > To: Mani, Rajmohan > > Cc: Mauro Carvalho Chehab ; Greg

Re: [PATCH v2 1/2] staging: iio: ad7780: add gain & filter gpio support

2019-02-01 Thread Popa, Stefan Serban
On Vi, 2019-02-01 at 12:55 -0200, Renato Lui Geh wrote: > On 01/30, Popa, Stefan Serban wrote: > > > > On Du, 2019-01-27 at 18:30 -0200, Renato Lui Geh wrote: > > > > > > Previously, the AD7780 driver only supported gpio for the 'powerdown' > > > pin. This commit adds suppport for the 'gain' and

Re: [PATCH v2 1/2] staging: iio: ad7780: add gain & filter gpio support

2019-02-01 Thread Renato Lui Geh
On 01/30, Popa, Stefan Serban wrote: On Du, 2019-01-27 at 18:30 -0200, Renato Lui Geh wrote: Previously, the AD7780 driver only supported gpio for the 'powerdown' pin. This commit adds suppport for the 'gain' and 'filter' pin. Signed-off-by: Renato Lui Geh Signed-off-by: Giuliano Belinassi

[PATCH V2 00/10] X86/KVM/Hyper-V: Add HV ept tlb range list flush support in KVM

2019-02-01 Thread lantianyu1986
From: Lan Tianyu This patchset is to introduce hv ept tlb range list flush function support in the KVM MMU component. Flushing ept tlbs of several address range can be done via single hypercall and new list flush function is used in the kvm_mmu_commit_zap_page() and FNAME(sync_page). This

Re: [PATCH] Drivers: hv: vmbus: Add mutex lock to channel show functions

2019-02-01 Thread Sasha Levin
On Thu, Jan 31, 2019 at 12:47:07PM -0500, Kimberly Brown wrote: On Thu, Jan 31, 2019 at 04:45:35PM +, Michael Kelley wrote: From: Sasha Levin Sent: Thursday, January 31, 2019 7:20 AM > > I've queued this one for hyper-fixes, thanks all! > Actually, please hold off on queuing this one. In

Re: [PATCH 1/9 v3] staging: spi: mt7621: Switch to SPDX identifier

2019-02-01 Thread Mark Brown
On Fri, Feb 01, 2019 at 11:17:07AM +0100, Stefan Roese wrote: > @@ -1,3 +1,4 @@ > +// SPDX-License-Identifier: GPL-2.0 > /* > * spi-mt7621.c -- MediaTek MT7621 SPI controller driver > * Please convert the entire comment into a C++ comment so it looks more intentional. signature.asc

[PATCH v2] staging: erofs: keep corrupted fs from crashing kernel in erofs_namei()

2019-02-01 Thread Gao Xiang
As Al pointed out, " ... and while we are at it, what happens to unsigned int nameoff = le16_to_cpu(de[mid].nameoff); unsigned int matched = min(startprfx, endprfx); struct qstr dname = QSTR_INIT(data + nameoff, unlikely(mid >= ndirents - 1) ?

Re: [PATCH 3/3] Staging: media: ipu3: fixed max charecter style issue

2019-02-01 Thread Sakari Ailus
Hi Prashanta, On Sun, Jan 27, 2019 at 10:24:16PM +0530, Prashantha SP wrote: > fixed coding style issue. Initial capital letter is preferred. > > Signed-off-by: Prashantha SP > --- > drivers/staging/media/ipu3/ipu3-css.c | 178 ++ > 1 file changed, 94 insertions(+),

[PATCH 8/9 v3] staging: spi: mt7621: Use macros instead of hardcoded values

2019-02-01 Thread Stefan Roese
This patch uses macros instead of hardcoded values for the SPI_MASTER register access in mt7621_spi_reset() and mt7621_spi_prepare(). Signed-off-by: Stefan Roese Cc: Mark Brown Cc: Greg Kroah-Hartman Cc: NeilBrown Cc: Sankalp Negi Cc: Chuanhong Guo Cc: John Crispin --- v3: - New patch,

[PATCH 9/9 v3] staging: spi: mt7621: Remove superfluous pre-declaration of struct mt7621_spi

2019-02-01 Thread Stefan Roese
This patch removes the superfluous pre-declaration of struct mt7621_spi. Signed-off-by: Stefan Roese Cc: Mark Brown Cc: Greg Kroah-Hartman Cc: NeilBrown Cc: Sankalp Negi Cc: Chuanhong Guo Cc: John Crispin --- v3: - New patch, changes spilt into separate patches

[PATCH 6/9 v3] staging: spi: mt7621: Use recommended comment style

2019-02-01 Thread Stefan Roese
This patch changes some comments to use the recommended multi-line comment style. Signed-off-by: Stefan Roese Cc: Mark Brown Cc: Greg Kroah-Hartman Cc: NeilBrown Cc: Sankalp Negi Cc: Chuanhong Guo Cc: John Crispin --- v3: - New patch, changes spilt into separate patches

[PATCH 1/9 v3] staging: spi: mt7621: Switch to SPDX identifier

2019-02-01 Thread Stefan Roese
Adopt the SPDX license identifier headers to ease license compliance management. Signed-off-by: Stefan Roese Cc: Mark Brown Cc: Greg Kroah-Hartman Cc: NeilBrown Cc: Sankalp Negi Cc: Chuanhong Guo Cc: John Crispin --- v3: - No change v2: - Changes are done to the driver in staging before

[PATCH 4/9 v3] staging: spi: mt7621: Remove superfluous SPI_BPW_MASK definition

2019-02-01 Thread Stefan Roese
This patch removes the SPI_BPW_MASK definition as this is already available in include/linux/spi/spi.h. Signed-off-by: Stefan Roese Cc: Mark Brown Cc: Greg Kroah-Hartman Cc: NeilBrown Cc: Sankalp Negi Cc: Chuanhong Guo Cc: John Crispin --- v3: - New patch, changes spilt into separate

[PATCH 7/9 v3] staging: spi: mt7621: Sort register definitions

2019-02-01 Thread Stefan Roese
This patch sorts the SPI register definitions by increasing addresses. Signed-off-by: Stefan Roese Cc: Mark Brown Cc: Greg Kroah-Hartman Cc: NeilBrown Cc: Sankalp Negi Cc: Chuanhong Guo Cc: John Crispin --- v3: - New patch, changes spilt into separate patches

[PATCH 2/9 v3] staging: spi: mt7621: Clean up excessive header usage

2019-02-01 Thread Stefan Roese
This patch removes unnecessary header includes and sorts the remaining ones alphabetically. Signed-off-by: Stefan Roese Cc: Mark Brown Cc: Greg Kroah-Hartman Cc: NeilBrown Cc: Sankalp Negi Cc: Chuanhong Guo Cc: John Crispin --- v3: - New patch, changes spilt into separate patches

[PATCH 3/9 v3] staging: spi: mt7621: Add return code check on device_reset()

2019-02-01 Thread Stefan Roese
This patch adds a return code check on device_reset() and removes the compile warning. Signed-off-by: Stefan Roese Cc: Mark Brown Cc: Greg Kroah-Hartman Cc: NeilBrown Cc: Sankalp Negi Cc: Chuanhong Guo Cc: John Crispin --- v3: - New patch, changes spilt into separate patches

[PATCH 5/9 v3] staging: spi: mt7621: Minor cosmetic changes

2019-02-01 Thread Stefan Roese
Align macro definitions and add some empty lines to make the code better readable. Signed-off-by: Stefan Roese Cc: Mark Brown Cc: Greg Kroah-Hartman Cc: NeilBrown Cc: Sankalp Negi Cc: Chuanhong Guo Cc: John Crispin --- v3: - New patch, changes spilt into separate patches

Re: [PATCH 2/2 v2] staging: spi: mt7621: Minor code cleanup

2019-02-01 Thread NeilBrown
On Fri, Feb 01 2019, Stefan Roese wrote: > On 01.02.19 10:03, Greg Kroah-Hartman wrote: >> On Fri, Feb 01, 2019 at 09:57:12AM +0100, Stefan Roese wrote: >>> This patch cleans up some minor issues with this driver: >>> - Remove unnecessary header includes >>> - Sort header alphabetically >>> - Use

Re: [PATCH 2/2 v2] staging: spi: mt7621: Minor code cleanup

2019-02-01 Thread Greg Kroah-Hartman
On Fri, Feb 01, 2019 at 10:16:23AM +0100, Stefan Roese wrote: > On 01.02.19 10:03, Greg Kroah-Hartman wrote: > > On Fri, Feb 01, 2019 at 09:57:12AM +0100, Stefan Roese wrote: > > > This patch cleans up some minor issues with this driver: > > > - Remove unnecessary header includes > > > - Sort

Re: [PATCH 2/2 v2] staging: spi: mt7621: Minor code cleanup

2019-02-01 Thread Stefan Roese
On 01.02.19 10:03, Greg Kroah-Hartman wrote: On Fri, Feb 01, 2019 at 09:57:12AM +0100, Stefan Roese wrote: This patch cleans up some minor issues with this driver: - Remove unnecessary header includes - Sort header alphabetically - Use correct comment style - Add return code check on

[PATCH 2/2 v2] staging: spi: mt7621: Minor code cleanup

2019-02-01 Thread Stefan Roese
This patch cleans up some minor issues with this driver: - Remove unnecessary header includes - Sort header alphabetically - Use correct comment style - Add return code check on device_reset() - Remove SPI_BPW_MASK definition (already available in include/linux/spi/spi.h) - Use macros instead of

[PATCH 1/2 v2] staging: spi: mt7621: Switch to SPDX identifier

2019-02-01 Thread Stefan Roese
Adopt the SPDX license identifier headers to ease license compliance management. Signed-off-by: Stefan Roese Cc: Mark Brown Cc: Greg Kroah-Hartman Cc: NeilBrown Cc: Sankalp Negi Cc: Chuanhong Guo Cc: John Crispin --- v2: - Changes are done to the driver in staging before moving it out of

Re: [PATCH 2/2 v2] staging: spi: mt7621: Minor code cleanup

2019-02-01 Thread Greg Kroah-Hartman
On Fri, Feb 01, 2019 at 09:57:12AM +0100, Stefan Roese wrote: > This patch cleans up some minor issues with this driver: > - Remove unnecessary header includes > - Sort header alphabetically > - Use correct comment style > - Add return code check on device_reset() > - Remove SPI_BPW_MASK

Re: [PATCH] staging: android: ion: fix sys heap pool's gfp_flags

2019-02-01 Thread Xiaqing (A)
On 2019/2/1 16:15, Dan Carpenter wrote: On Fri, Feb 01, 2019 at 02:59:46PM +0800, Qing Xia wrote: In the first loop, gfp_flags will be modified to high_order_gfp_flags, and there will be no chance to change back to low_order_gfp_flags. Fixes: e7f63771 ("ION: Sys_heap: Add cached pool to

Re: [PATCH] staging: android: ion: fix sys heap pool's gfp_flags

2019-02-01 Thread Dan Carpenter
On Fri, Feb 01, 2019 at 02:59:46PM +0800, Qing Xia wrote: > In the first loop, gfp_flags will be modified to high_order_gfp_flags, > and there will be no chance to change back to low_order_gfp_flags. > > Fixes: e7f63771 ("ION: Sys_heap: Add cached pool to spead up cached buffer > alloc") Huh...