Sorry for the delay due to business travel.
On 2019/1/29 2:30, Dan Carpenter wrote:
> On Tue, Jan 29, 2019 at 12:41:55AM +0800, Chao Yu wrote:
>> Hi Dan and Xiang,
>>
>> On 2019-1-28 21:48, Gao Xiang wrote:
>>> Hi Dan,
>>>
>>> On 2019/1/28 21:33, Dan Carpenter wrote:
Hopefully, regular
From: Colin Ian King
There is an earlier null check on pointer dev which implies it may be null,
however the assignment of pointer pref and the call to free_ieee82011 on
a null dev can cause null pointer dereference errors. Fix this by moving
the assignment of priv and the the call to
From: Colin Ian King
Currently the call to cdev_add is missing a check for failure. Fix this by
checking for failure and exiting via a new error path that ensures the
allocated comp_channel struct is kfree'd.
Detected by CoverityScan, CID#1462359 ("Unchecked return value")
Fixes: 9bc79bbcd0c5
ping?
On 22/12/2018 11:49, Colin King wrote:
> From: Colin Ian King
>
> The comparison css->pipes[pipe].bindex < 0 is always false because
> bindex is an unsigned int. Fix this by using a signed integer for
> the comparison.
>
> Detected by CoverityScan, CID#1476023 ("Unsigned compared
From: Colin Ian King
Multiplying two unsigned ints leads to an unsigned int result. The
intention is that the result is a unsigned long long, so to fix the
overflow cast the div to an unsigned long long to ensure that the
multiplication is on unsigned long longs to avoid overflow.
Detected by
On Fri, Feb 01, 2019 at 06:24:24PM +, Dexuan Cui wrote:
> > From: Kimberly Brown
> > Sent: Thursday, January 31, 2019 9:47 AM
> > ...
> > 2) Prevent a deadlock that can occur between the proposed mutex_lock()
> > call in the vmbus_chan_attr_show() function and the sysfs/kernfs functions.
> Hi
From: Ajay Singh
Remove 'add_sta_param' structure as its not used now.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/host_interface.h | 11 ---
1 file changed, 11 deletions(-)
diff --git a/drivers/staging/wilc1000/host_interface.h
b/drivers/staging/wilc1000/host_interface.h
From: Ajay Singh
Rename timeout related macros to have their unit clear from their name.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/host_interface.c | 8
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 4 ++--
drivers/staging/wilc1000/wilc_wlan.c
From: Ajay Singh
Refactor linux_wlan_init_test_config() to use correct endianness for wid
values and remove unnecessary code.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/linux_wlan.c | 200 +---
drivers/staging/wilc1000/wilc_wlan_if.h | 1 -
2 files
From: Ajay Singh
Avoid use of static variable for monitor net_device and move it inside
wilc structure.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/linux_mon.c | 52 +++
drivers/staging/wilc1000/linux_wlan.c | 4 +-
From: Ajay Singh
Before calling an operation on net_device check if that interface is
available.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/linux_wlan.c | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/wilc1000/linux_wlan.c
From: Ajay Singh
Avoid use of interface name i.e 'wlan0' & 'p2p0' to check the interface
type in dev_state_ev_handler(). Now making use of netdev_ops and iface
type to know interface. Reorder the functions to avoid the forward
declaration after the above changes
Signed-off-by: Ajay Singh
---
From: Ajay Singh
This series contains cleanup patches and modification to handle few mainline
review comments mentioned below:
- avoid static variable for monitor net_device.
- remove conditional locking in wilc_wfi_deinit_mon_interface().
- avoid use of interface name('wlan0' & 'p2p0')
From: Ajay Singh
Remove SSID string compare instead use interface type check for p2p
client interface.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/host_interface.h | 1 -
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 19 ++-
2 files changed, 6
From: Ajay Singh
Remove macro define which are already present in the included header.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/linux_mon.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/wilc1000/linux_mon.c
b/drivers/staging/wilc1000/linux_mon.c
index
From: Ajay Singh
Use random number to assign to cookie value.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
From: Ajay Singh
wilc_wfi_deinit_mon_interface() calls unregister_netdev() which
requires the rtnl lock again. Now move wilc_wfi_deinit_mon_interface()
out of wilc_mac_close(). Also remove explicit call to wilc_mac_close()
because unregister_netdev() takes care of calling wilc_mac_close().
From: Ajay Singh
Remove use of 'terminated_handle' variable and set the 'hif_drv' to
NULL once it's free.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/host_interface.c | 15 +++
1 file changed, 7 insertions(+), 8 deletions(-)
diff --git
From: Ajay Singh
The value of 'vif_num'(interface count) starts with 0, so modified the
loop conditions to execute for all interface.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/host_interface.c | 2 +-
drivers/staging/wilc1000/linux_wlan.c | 8
2 files changed, 5
From: Ajay Singh
Make use of cookie information to pass to wpa_s and handle cookie value
received in the cfg80211_ops callbacks.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/host_interface.c | 72 +++
drivers/staging/wilc1000/host_interface.h | 13
From: Ajay Singh
Refactor scan() cfg80211 callback function and use correct value for
valid channel number limit.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/host_interface.h | 2 +-
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 55 +++
2 files
From: Ajay Singh
Remove unnecessary debug log messages.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/linux_wlan.c | 31 ---
1 file changed, 31 deletions(-)
diff --git a/drivers/staging/wilc1000/linux_wlan.c
b/drivers/staging/wilc1000/linux_wlan.c
index
On Fri, Feb 01, 2019 at 06:38:05AM +0100, Hugo Lefeuvre wrote:
> Replace schedule(); try_to_freeze() by freezable_schedule().
>
> Tasks calling freezable_schedule() set the PF_FREEZER_SKIP flag
> before calling schedule(). Unlike tasks calling schedule();
> try_to_freeze() tasks calling
On Fri, 1 Feb 2019 17:01:38 +0200
Beniamin Bia wrote:
> From: Beniamin Bia
>
> The clock frequency is loaded from device-tree using clock framework
> instead of statically value. The change allow configuration of
> the device via device-trees and better initialization sequence.
> This is part
On Fri, 1 Feb 2019 17:01:37 +0200
Beniamin Bia wrote:
> From: Beniamin Bia
>
> The values from platform data were replaced by statically values.
> This was just a intermediate step of taking this driver out of staging and
> load data from device tree.
>
> Signed-off-by: Beniamin Bia
Applied
Fri, Feb 01, 2019 at 11:06:44PM CET, f.faine...@gmail.com wrote:
>Hi all,
>
>This patch series converts SWITCHDEV_PORT_ATTR_{GET,SET} to use a
>blocking notifier, similar to how SWITCHDEV_PORT_OBJ_{ADD,DEL} has been
>changed recently by Petr.
>
>This was suggested by Ido to help with a particular
Fri, Feb 01, 2019 at 11:06:45PM CET, f.faine...@gmail.com wrote:
>In preparation for allowing switchdev enabled drivers to veto specific
>attribute settings from within the context of the caller, introduce a
>new switchdev notifier type for port attributes.
>
>Suggested-by: Ido Schimmel
From: Lan Tianyu
Hyper-V doesn't provide irq remapping for IO-APIC. To enable x2apic,
set x2apic destination mode to physcial mode when x2apic is available
and Hyper-V IOMMU driver makes sure cpus assigned with IO-APIC irqs have
8-bit APIC id.
Signed-off-by: Lan Tianyu
---
Change since v1:
From: Lan Tianyu
On the bare metal, enabling X2APIC mode requires interrupt remapping
function which helps to deliver irq to cpu with 32-bit APIC ID.
Hyper-V doesn't provide interrupt remapping function so far and Hyper-V
MSI protocol already supports to deliver interrupt to the CPU whose
On Tue, 29 Jan 2019 16:31:00 -0200
Camylla Cantanheide wrote:
> From: Feulo
>
> Align broken line to match upper line parenthesis. Solves the
> checkpatch.pl's message
>
> CHECK: Alignment should match open parenthesis.
>
> Signed-off-by: Feulo
For reference should be full name (though I'm
On Sun, 27 Jan 2019 18:33:52 -0200
Renato Lui Geh wrote:
> Move ad7780 ADC driver out of staging and into the mainline.
>
> The ad7780 is a sigma-delta analog to digital converter. This driver provides
> reading voltage values and status bits from both the ad778x and ad717x series.
> Its
31 matches
Mail list logo
