On 2019/5/15 12:31, Masahiro Yamada wrote:
> The top level Makefile adds -Wall globally:
>
> KBUILD_CFLAGS := -Wall -Wundef -Werror=strict-prototypes -Wno-trigraphs \
>
> I see two "-Wall" added for compiling objects in drivers/staging/erofs/.
>
> Signed-off-by: Masahiro Yamada
Looks
The top level Makefile adds -Wall globally:
KBUILD_CFLAGS := -Wall -Wundef -Werror=strict-prototypes -Wno-trigraphs \
I see two "-Wall" added for compiling objects in drivers/staging/erofs/.
Signed-off-by: Masahiro Yamada
---
drivers/staging/erofs/Makefile | 2 +-
1 file changed, 1
Fix following checkpatch.pl warnings by using %s and __func__
in strings instead of function names.
WARNING: Prefer using '"%s...", __func__' to using
'_rtl92e_dm_check_rate_adaptive', this function's name, in a string
WARNING: Prefer using '"%s...", __func__' to using 'rtl92e_dm_restore_state',
On Tue, May 14, 2019 at 09:24:38PM +0530, Puranjay Mohan wrote:
> On Tue, May 14, 2019 at 04:09:05PM +0200, Greg KH wrote:
> > On Tue, May 14, 2019 at 02:42:31PM +0530, Puranjay Mohan wrote:
> > > Remove braces around a single if statement to fix following
> > > checkpatch.pl warning.
> > >
This series fix the following errors/warnings:
-Correct spelling mistakes.
-Replace NULL comparison.
-Add space around operators.
-Remove braces from single if statement.
Puranjay Mohan (5):
Staging: rtl8192u: ieee80211: Fix coding style warning
Staging: rtl8192u: ieee80211: Fix spelling
Correct spelling mistakes at two places in comments.
Signed-off-by: Puranjay Mohan
---
drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c
Fix coding style errors by adding spaces around '&&' operators.
Signed-off-by: Puranjay Mohan
---
drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c
On Tue, May 14, 2019 at 12:44:53PM -0400, Steven Rostedt wrote:
> OK, this has gotten my attention.
>
> This thread is quite long, do you have a git repo I can look at, and
> also where is the first task_lock() taken before the
> find_lock_task_mm()?
>
> -- Steve
Hi Steve,
This is the git repo
Fix comparison to NULL, chang to !x operation.
Issue found using checkpatch.pl
Signed-off-by: Puranjay Mohan
---
drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git
Fix coding style errors related to braces for if-else statements.
Signed-off-by: Puranjay Mohan
---
.../staging/rtl8192u/ieee80211/ieee80211_tx.c | 58 +++
1 file changed, 20 insertions(+), 38 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c
Remove braces around a single if statement to fix following
checkpatch.pl warning.
WARNING: braces {} are not necessary for single statement blocks
Signed-off-by: Puranjay Mohan
---
drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff
On Mon, 13 May 2019 09:45:55 -0700
Sultan Alsawaf wrote:
> On Fri, May 10, 2019 at 05:10:25PM +0200, Oleg Nesterov wrote:
> > I am starting to think I am ;)
> >
> > If you have task1 != task2 this code
> >
> > task_lock(task1);
> > task_lock(task2);
> >
> > should trigger
Fix the warning issued by checkpatch
Prefer kernel type 'u32' over 'uint32_t'
Signed-off-by: Madhumitha Prabakaran
---
drivers/staging/vc04_services/bcm2835-camera/mmal-msg.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
On Tue, May 14, 2019 at 04:09:05PM +0200, Greg KH wrote:
> On Tue, May 14, 2019 at 02:42:31PM +0530, Puranjay Mohan wrote:
> > Remove braces around a single if statement to fix following
> > checkpatch.pl warning.
> > WARNING: braces {} are not necessary for single statement blocks
> >
> >
On Tue, May 14, 2019 at 02:42:31PM +0530, Puranjay Mohan wrote:
> Remove braces around a single if statement to fix following
> checkpatch.pl warning.
> WARNING: braces {} are not necessary for single statement blocks
>
> Signed-off-by: Puranjay Mohan
> ---
>
> V2 - remove extra blank line
Fix comparison to NULL, chang to !x operation.
Issue found using checkpatch.pl
Signed-off-by: Puranjay Mohan
---
V2 - Remove extra parentheses around *crypt
drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git
Fix coding style errors related to braces for if-else statements.
Signed-off-by: Puranjay Mohan
---
V2 - Remove extra blank lines.
.../staging/rtl8192u/ieee80211/ieee80211_tx.c | 58 +++
1 file changed, 20 insertions(+), 38 deletions(-)
diff --git
Remove braces around a single if statement to fix following
checkpatch.pl warning.
WARNING: braces {} are not necessary for single statement blocks
Signed-off-by: Puranjay Mohan
---
V2 - remove extra blank line before the closing brace.
drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c | 3
18 matches
Mail list logo
