On Thu, 2019-05-16 at 23:55 +0530, Hariprasad Kelam wrote:
> On Thu, May 16, 2019 at 11:00:56AM +0300, Dan Carpenter wrote:
> > On Wed, May 15, 2019 at 11:15:36PM +0530, Hariprasad Kelam wrote:
> > > @@ -1042,7 +1042,7 @@ sint sta2ap_data_frame(
> > > }
> > >
> > > *psta =
>-Original Message-
>From: devel On Behalf Of
>Define separate simple show functions for each attribute instead of having a
>one big one containing a chain of conditionals.
>
>+static ssize_t s2c_dma_ch_show(struct device *dev,
>+ struct device_attribute
>-Original Message-
>From: devel On Behalf Of
>Previously the next card number was assigned from a static int local variable,
>which was read and later incremented. This was not thread- safe, so now we
>use an atomic_t and atomic_fetch_add instead.
Switching to atomic_fetch_add is
Removed trailing white-space from four files.
Signed-off-by: Jeremy Sowden
---
drivers/staging/kpc2000/kpc2000/cell_probe.c | 62 ++---
drivers/staging/kpc2000/kpc2000/core.c | 98 ++--
drivers/staging/kpc2000/kpc2000/fileops.c| 2 +-
Previously the next card number was assigned from a static int local
variable, which was read and later incremented. This was not thread-
safe, so now we use an atomic_t and atomic_fetch_add instead.
Updated TODO.
Signed-off-by: Jeremy Sowden
---
drivers/staging/kpc2000/TODO | 1 -
Define separate simple show functions for each attribute instead of
having a one big one containing a chain of conditionals.
Replaced scnprintf calls with sprintf since all the outputs are short
bounded strings or single integers.
All of the device attributes are read-only, so use DEVICE_ATTR_RO
The definitions are only used to populate the kpc_uio_class_attrs
attribute array, so declare them as static.
Fixes the following sparse warnings:
drivers/staging/kpc2000/kpc2000/cell_probe.c:220:1: warning: symbol
'dev_attr_offset' was not declared. Should it be static?
These apply on top of the ones I sent earlier this week, which are
currently in the staging-test branch.
There's one white-space patch, a number relating to device attributes
and one that fixes a race affecting the assignment of card numbers.
Jeremy Sowden (9):
staging: kpc2000: removed
Fixed indentation of cpld_reconfigure store call-back and definition of
attribute list.
Signed-off-by: Jeremy Sowden
---
drivers/staging/kpc2000/kpc2000/core.c | 55 ++
1 file changed, 29 insertions(+), 26 deletions(-)
diff --git a/drivers/staging/kpc2000/kpc2000/core.c
Define separate simple show functions for each attribute instead of
having a one big one containing a chain of conditionals.
Replaced calls to scnprintf with sprintf since all the outputs are
single integers.
All the readable device attributes are read-only, so use DEVICE_ATTR_RO
to define them.
The definitions are only used to populate the kp_attr_list attribute
array, so declare them as static.
Fixes the following sparse warnings:
drivers/staging/kpc2000/kpc2000/core.c:152:1: warning: symbol 'dev_attr_ssid'
was not declared. Should it be static?
The show functions of two attributes output nothing and they are unused.
Removed them.
Signed-off-by: Jeremy Sowden
---
drivers/staging/kpc2000/kpc2000/cell_probe.c | 16
1 file changed, 16 deletions(-)
diff --git a/drivers/staging/kpc2000/kpc2000/cell_probe.c
The call-backs used the same recipe to get the pcard from dev:
struct pci_dev *pdev = to_pci_dev(dev);
struct kp2000_device *pcard;
if (!pdev) return -ENXIO;
pcard = pci_get_drvdata(pdev);
if (!pcard) return -ENXIO;
where to_pci_dev is a wrapper for container_of.
However,
Fix the warning issued by checkpatch
Prefer kernel type 'u32' over 'uint32_t'.
Along with that include a blank line after a declaration
to maintain Linux kernel coding style.
Signed-off-by: Madhumitha Prabakaran
---
Changes in v2:
- Modified subject line
- Included one more change in control.c
On 2019-05-16, at 22:45:33 +0200, Greg KH wrote:
> On Thu, May 16, 2019 at 09:04:02PM +0100, Jeremy Sowden wrote:
> > Define separate simple show functions for each attribute instead of
> > having a one big one containing a chain of conditionals.
>
> There's nothing wrong with a change of
On 2019-05-16, at 20:17:51 +, Matt Sickler wrote:
> >-Original Message-
> >From: devel On Behalf Of
> >Define separate simple show functions for each attribute instead of having a
> >one big one containing a chain of conditionals.
> >
> >+static ssize_t s2c_dma_ch_show(struct device
On Thu, May 16, 2019 at 09:04:02PM +0100, Jeremy Sowden wrote:
> Define separate simple show functions for each attribute instead of
> having a one big one containing a chain of conditionals.
There's nothing wrong with a change of contitionals, if you do it right
:)
> Signed-off-by: Jeremy
Most of the device attributes are read-only, so use DEVICE_ATTR_RO
to define them.
Signed-off-by: Jeremy Sowden
---
drivers/staging/kpc2000/kpc2000/core.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/kpc2000/kpc2000/core.c
The definitions are only used to populate the kp_attr_list attribute
array, so declare them as static.
Fixes the following sparse warnings:
drivers/staging/kpc2000/kpc2000/core.c:152:1: warning: symbol 'dev_attr_ssid'
was not declared. Should it be static?
The definitions are only used to populate the kpc_uio_class_attrs
attribute array, so declare them as static.
Fixes the following sparse warnings:
drivers/staging/kpc2000/kpc2000/cell_probe.c:220:1: warning: symbol
'dev_attr_offset' was not declared. Should it be static?
Removed trailing white-space from four files.
Signed-off-by: Jeremy Sowden
---
drivers/staging/kpc2000/kpc2000/cell_probe.c | 62 ++---
drivers/staging/kpc2000/kpc2000/core.c | 98 ++--
drivers/staging/kpc2000/kpc2000/fileops.c| 2 +-
The call-backs used the same recipe to get the pcard from dev:
struct pci_dev *pdev = to_pci_dev(dev);
struct kp2000_device *pcard;
if (!pdev) return -ENXIO;
pcard = pci_get_drvdata(pdev);
if (!pcard) return -ENXIO;
where to_pci_dev is a wrapper for container_of.
However,
These apply on top of the ones I sent earlier this week, which are
currently in the staging-test branch.
There's one white-space patch, a number relating to device attributes
and one that fixes a race affecting the assignment of card numbers.
Jeremy Sowden (11):
staging: kpc2000: removed
Define separate simple show functions for each attribute instead of
having a one big one containing a chain of conditionals.
Signed-off-by: Jeremy Sowden
---
drivers/staging/kpc2000/kpc2000/cell_probe.c | 138 ---
1 file changed, 92 insertions(+), 46 deletions(-)
diff --git
All of the device attributes are read-only, so use DEVICE_ATTR_RO to
define them.
Signed-off-by: Jeremy Sowden
---
drivers/staging/kpc2000/kpc2000/cell_probe.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/kpc2000/kpc2000/cell_probe.c
The show functions of two attributes output nothing. Removed them.
Signed-off-by: Jeremy Sowden
---
drivers/staging/kpc2000/kpc2000/cell_probe.c | 16
1 file changed, 16 deletions(-)
diff --git a/drivers/staging/kpc2000/kpc2000/cell_probe.c
Fixed indentation of cpld_reconfigure store call-back and definition of
attribute list.
Signed-off-by: Jeremy Sowden
---
drivers/staging/kpc2000/kpc2000/core.c | 51 ++
1 file changed, 27 insertions(+), 24 deletions(-)
diff --git a/drivers/staging/kpc2000/kpc2000/core.c
Define separate simple show functions for each attribute instead of
having a one big one containing a chain of conditionals.
Signed-off-by: Jeremy Sowden
---
drivers/staging/kpc2000/kpc2000/core.c | 91 +++---
1 file changed, 67 insertions(+), 24 deletions(-)
diff --git
Previously the next card number was assigned from a static int local
variable, which was read and later incremented. This was not thread-
safe, so now we use an atomic_t and atomic_fetch_add instead.
Updated TODO.
Signed-off-by: Jeremy Sowden
---
drivers/staging/kpc2000/TODO | 1 -
On Thu, May 16, 2019 at 11:00:56AM +0300, Dan Carpenter wrote:
> On Wed, May 15, 2019 at 11:15:36PM +0530, Hariprasad Kelam wrote:
> > @@ -1042,7 +1042,7 @@ sint sta2ap_data_frame(
> > }
> >
> > *psta = rtw_get_stainfo(pstapriv, pattrib->src);
> > - if (*psta ==
Support for ad7616 running in software was added. In order
to activate the software mode, HW_RNGSEL pins must be pulled low.
Oversampling and input ranges are now configured in corresponding
registers. Ad7616 has multiple scale options when it is configured
in software mode.
Signed-off-by:
187口216口21564薇
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
In order to support AD7616 software mode, the spi register access must be
added and the calculation of registers address must be generic.
The length of address and bit which specifies the read/write operation is
different for every device, that is why it was made generic.
Signed-off-by: Beniamin
Support for register access was added for spi devices.
Signed-off-by: Beniamin Bia
---
drivers/iio/adc/ad7606.c | 25 +
1 file changed, 25 insertions(+)
diff --git a/drivers/iio/adc/ad7606.c b/drivers/iio/adc/ad7606.c
index f77df3efe43f..b03bdce4fd4e 100644
---
The device dependent options which are going to be different for devices
which will be supported in the future by this driver,
were moved in chip info for a more generic driver. This patch allows
supporting more devices by the driver. Also, it is an intermediate
step of adding support for ad7616
Because this driver will support multiple configurations for software,
the software configuration was made generic.
Signed-off-by: Beniamin Bia
---
drivers/iio/adc/ad7606.c | 40 +---
drivers/iio/adc/ad7606.h | 2 ++
2 files changed, 39 insertions(+), 3
On 05/15, Sultan Alsawaf wrote:
>
> On Wed, May 15, 2019 at 04:58:32PM +0200, Oleg Nesterov wrote:
> > Could you explain in detail what exactly did you do and what do you see in
> > dmesg?
> >
> > Just in case, lockdep complains only once, print_circular_bug() does
> > debug_locks_off()
> > so
Returns error code from 'vnt_int_start_interrupt()' so the device's private
buffers will be correctly freed and 'struct ieee80211_hw' start function
will return an error code.
Signed-off-by: Quentin Deslandes
---
drivers/staging/vt6656/int.c | 4 +++-
drivers/staging/vt6656/int.h |
Returns error code from 'vnt_int_start_interrupt()' so the device's private
buffers will be correctly freed and 'struct ieee80211_hw' start function
will return an error code.
Signed-off-by: Quentin Deslandes
---
v2: instead of removing status variable, returns its value to caller and
handle
On Thu, May 16, 2019 at 11:39:51AM +0200, Greg Kroah-Hartman wrote:
> On Thu, May 16, 2019 at 09:31:05AM +, Quentin Deslandes wrote:
> > Fixed 'set but not used' warning message on a status variable. The
> > called function returning the status code 'vnt_start_interrupt_urb()'
> > clean up
On Thu, May 16, 2019 at 12:19:53PM +0200, Greg Kroah-Hartman wrote:
> On Thu, May 16, 2019 at 09:50:38AM +, Quentin Deslandes wrote:
> > On Thu, May 16, 2019 at 11:39:51AM +0200, Greg Kroah-Hartman wrote:
> > > On Thu, May 16, 2019 at 09:31:05AM +, Quentin Deslandes wrote:
> > > > Fixed
On Thu, May 16, 2019 at 09:50:38AM +, Quentin Deslandes wrote:
> On Thu, May 16, 2019 at 11:39:51AM +0200, Greg Kroah-Hartman wrote:
> > On Thu, May 16, 2019 at 09:31:05AM +, Quentin Deslandes wrote:
> > > Fixed 'set but not used' warning message on a status variable. The
> > > called
On Thu, May 16, 2019 at 09:31:05AM +, Quentin Deslandes wrote:
> Fixed 'set but not used' warning message on a status variable. The
> called function returning the status code 'vnt_start_interrupt_urb()'
> clean up after itself and the caller function
> 'vnt_int_start_interrupt()' does not
Fixed 'set but not used' warning message on a status variable. The
called function returning the status code 'vnt_start_interrupt_urb()'
clean up after itself and the caller function
'vnt_int_start_interrupt()' does not returns any value.
Signed-off-by: Quentin Deslandes
---
Fix following warnings reported by coccicheck:
WARNING: Comparison to bool
by using !x in place of (x == false) and
x in place of (x == true).
Signed-off-by: Puranjay Mohan
---
drivers/staging/rtl8723bs/hal/HalHWImg8723B_BB.c | 4 ++--
drivers/staging/rtl8723bs/hal/HalHWImg8723B_MAC.c | 2 +-
On Wed, 2019-05-15 at 18:39 +0200, Greg KH wrote:
> On Wed, May 15, 2019 at 09:06:44PM +0800, Kai-Heng Feng wrote:
> > 296 files changed, 206166 insertions(+)
> I'm not going to take another 200k lines for a simple wifi driver.
Good.
Realtek _really_ needs to improve the driver software.
On Wed, May 15, 2019 at 11:15:36PM +0530, Hariprasad Kelam wrote:
> @@ -1042,7 +1042,7 @@ sint sta2ap_data_frame(
> }
>
> *psta = rtw_get_stainfo(pstapriv, pattrib->src);
> - if (*psta == NULL) {
> + if (!*psta == NULL) {
47 matches
Mail list logo
