[PATCH v8 2/5] gpu: ipu-v3: ipu-ic: Fully describe colorspace conversions

Only providing the input and output RGB/YUV space to the IC task init functions is not sufficient. To fully characterize a colorspace conversion, the Y'CbCr encoding standard, and quantization also need to be specified. Define a 'struct ipu_ic_colorspace' that includes all the above. This allows

[PATCH v8 5/5] media: imx: Try colorimetry at both sink and source pads

Retask imx_media_fill_default_mbus_fields() to try colorimetry parameters, renaming it to to imx_media_try_colorimetry(), and call it at both sink and source pad try_fmt's. The unrelated check for uninitialized field value is moved out to appropriate places in each subdev try_fmt. The IC now

[PATCH] staging: rtl8723bs: Add missing blank lines

This patch resolves the following warning from checkpatch.pl WARNING: Missing a blank line after declarations Signed-off-by: Fabio Lima --- drivers/staging/rtl8723bs/core/rtw_debug.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/rtl8723bs/core/rtw_debug.c

Re: staging: mt7621-pci: factor out 'mt7621_pcie_enable_port' function

Hi Sergio, Thanks for the quick response. On 21/5/19 6:14 pm, Sergio Paracuellos wrote: On Tue, May 21, 2019 at 8:44 AM Greg Ungerer wrote: I am working on a couple of different MedaiTek MT7621 based platforms and am having problems with the PCI bus on those. Big picture is that the PCI bus

Re: [PATCH 10/10] docs: fix broken documentation links

On Monday, May 20, 2019 4:47:39 PM CEST Mauro Carvalho Chehab wrote: > Mostly due to x86 and acpi conversion, several documentation > links are still pointing to the old file. Fix them. > > Signed-off-by: Mauro Carvalho Chehab > --- > Documentation/acpi/dsd/leds.txt | 2 +- >

Re: [PATCH] staging: rtl8192u: Remove an unnecessary NULL check

On Tue, May 21, 2019 at 10:42 AM Nathan Chancellor wrote: > > Clang warns: > > drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c:2663:47: warning: > address of array 'param->u.wpa_ie.data' will always evaluate to 'true' > [-Wpointer-bool-conversion] > (param->u.wpa_ie.len &&

[PATCH] staging: rtl8723bs: Fix Coverity warning in rtw_dbg_port()

Fix the following Coverity warning: File: drivers/staging/rtl8723bs/os_dep/ioctl_linux.c in function rtw_dbg_port(): CID 18480: Operands don't affect result (CONSTANT_EXPRESSION_RESULT) dead_error_condition: The condition (extra_arg & 7U) > 7U cannot be true. if ((extra_arg & 0x07) >

[Patch v2] staging: rtl8723bs: core: rtw_ap: fix Unneeded variable: "ret". Return "0

Function "rtw_sta_flush" always returns 0 value. So change return type of rtw_sta_flush from int to void. Same thing applies for rtw_hostapd_sta_flush Signed-off-by: Hariprasad Kelam -- Changes v2 - change return type of rtw_sta_flush - drivers/staging/rtl8723bs/core/rtw_ap.c

Re: [PATCH] staging: wilc1000: remove redundant masking of pkt_offset

On 5/21/19 6:17 AM, Colin King wrote: > External E-Mail > > > From: Colin Ian King > > The masking update of pkg_offset is redundant as the updated > value is never read and pkg_offset is re-assigned on the next > iteration of the loop. Clean this up by removing the redundant > assignment. > >

[PATCH] staging: fieldbus: arcx-anybus: change custom -> mmio regmap

The arcx-anybus's registers are accessed via a memory-mapped IO region. A regmap associated with this region is created using custom reg_read() / reg_write() callbacks. However, an abstraction which creates a memory-mapped IO region backed regmap already exists: devm_regmap_init_mmio(). Replace

[PATCH] staging: rtl8192u: Remove an unnecessary NULL check

Clang warns: drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c:2663:47: warning: address of array 'param->u.wpa_ie.data' will always evaluate to 'true' [-Wpointer-bool-conversion] (param->u.wpa_ie.len && !param->u.wpa_ie.data))

Re: [PATCH] staging: fieldbus: anybuss: force address space conversion

On Tue, May 21, 2019 at 12:53 PM Sven Van Asbroeck wrote: > > On Tue, May 21, 2019 at 12:24 PM Greg KH wrote: > > > > what is so odd about this code that makes you have to jump through > > strange hoops that no other driver has to? > > > > Basically because it creates a regmap which accesses

Re: staging: Add rtl8723bs sdio wifi driver

Hi, On 5/21/19 3:49 PM, Colin Ian King wrote: Hi, static analysis with Coverity has detected an issues in the rtl8723bs wifi driver: File: drivers/staging/rtl8723bs/os_dep/ioctl_linux.c in function rtw_dbg_port(): CID 18480: Operands don't affect result (CONSTANT_EXPRESSION_RESULT)

Re: [PATCH] staging: fieldbus: anybuss: force address space conversion

On Tue, May 21, 2019 at 12:24 PM Greg KH wrote: > > what is so odd about this code that makes you have to jump through > strange hoops that no other driver has to? > Basically because it creates a regmap which accesses __iomem memory, instead of i2c/spi. This was done because future hardware in

Re: [PATCH] staging: fieldbus: anybuss: force address space conversion

On Tue, May 21, 2019 at 11:53:15AM -0400, Sven Van Asbroeck wrote: > On Tue, May 21, 2019 at 11:42 AM Greg KH wrote: > > > > Ick, if you are using __force, almost always something is wrong. > > > > What if I create a separate structure for the regmap context ? > > struct anybus_regmap_context {

Re: [PATCH] staging: fieldbus: anybuss: force address space conversion

On Tue, May 21, 2019 at 11:42 AM Greg KH wrote: > > Ick, if you are using __force, almost always something is wrong. > What if I create a separate structure for the regmap context ? struct anybus_regmap_context { void __iomem *base; }; Then just store the base pointer inside the

Re: [PATCH] staging: fieldbus: anybuss: force address space conversion

On Tue, May 21, 2019 at 11:19:59AM -0400, Sven Van Asbroeck wrote: > On Tue, May 21, 2019 at 11:13 AM Dan Carpenter > wrote: > > > > There is no need to use __force. Just: > > > > void __iomem *base = (void __iomem *)context; > > > > For the rest as well. > > Yes, that appears to work

Re: [PATCH] staging: fieldbus: anybuss: force address space conversion

On Tue, May 21, 2019 at 11:13 AM Dan Carpenter wrote: > > There is no need to use __force. Just: > > void __iomem *base = (void __iomem *)context; > > For the rest as well. Yes, that appears to work for 'void *' -> __iomem, but not the other way around: + return

Re: [PATCH] staging/gasket: Fix string split

On Tue, May 21, 2019 at 05:07:28PM +0200, Tianzheng Li wrote: > This patch removes unnecessary quoted string splits. > > Signed-off-by: Tianzheng Li > Signed-off-by: Jie Zhang What do the two sign off mean here? What did Jie Zhang do? Who wrote this patch? Co-developed-by? Reviewed-by?

Re: [PATCH] staging: fieldbus: anybuss: force address space conversion

On Tue, May 21, 2019 at 10:51:16AM -0400, Sven Van Asbroeck wrote: > The regmap's context (stored as 'void *') consists of a pointer to > __iomem. Mixing __iomem and non-__iomem addresses generates > sparse warnings. > > Fix by using __force when converting to/from 'void __iomem *' and > the

[PATCH] staging/gasket: Fix string split

This patch removes unnecessary quoted string splits. Signed-off-by: Tianzheng Li Signed-off-by: Jie Zhang --- drivers/staging/gasket/gasket_core.c | 6 ++ drivers/staging/gasket/gasket_ioctl.c | 3 +-- drivers/staging/gasket/gasket_page_table.c | 14 ++ 3 files

Re: [PATCH] staging: fieldbus: solve warning incorrect type dev_core.c

Ok, perfect! Oscar Gomez Fuente ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] staging: fieldbus: anybuss: force address space conversion

The regmap's context (stored as 'void *') consists of a pointer to __iomem. Mixing __iomem and non-__iomem addresses generates sparse warnings. Fix by using __force when converting to/from 'void __iomem *' and the regmap's context. Signed-off-by: Sven Van Asbroeck ---

Re: [PATCH v3] staging: fieldbus: core: fix ->poll() annotation

On Tue, May 21, 2019 at 10:37 AM Dan Carpenter wrote: > > > If you're resending someone's patch, you have to add your own Signed off > by line as well. Everyone who touches a patch has to sign that they > didn't add any of SCO's all powerful UnixWare source code into the > patch. > Thank you

Re: [PATCH v3] staging: fieldbus: core: fix ->poll() annotation

On Tue, May 21, 2019 at 10:20:09AM -0400, Sven Van Asbroeck wrote: > From: Oscar Gomez Fuente > > ->poll() functions should return __poll_t, but the fieldbus > core's poll() does not. This generates a sparse warning. > > Fix the ->poll() return value, and use recommended __poll_t > constants

[PATCH] Staging: rtl8188eu: core: Use !x in place of NULL comparisons

Change (x == NULL) to !x and (x != NULL) to x, to fix following checkpatch.pl warnings: CHECK: Comparison to NULL could be written "!x". Signed-off-by: Puranjay Mohan --- drivers/staging/rtl8188eu/core/rtw_recv.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git

Re: [PATCH v3] staging: fieldbus: core: fix ->poll() annotation

On Tue, May 21, 2019 at 10:20 AM Sven Van Asbroeck wrote: > > From: Oscar Gomez Fuente > > ->poll() functions should return __poll_t, but the fieldbus > core's poll() does not. This generates a sparse warning. > > Fix the ->poll() return value, and use recommended __poll_t > constants

Re: [PATCH] staging: fieldbus: solve warning incorrect type dev_core.c

On Tue, May 21, 2019 at 10:17 AM Greg KH wrote: > > > Greg already took this patch a while ago :) > Thanks for bringing that up Greg, I'll double-check your tree next time. Oscar, please ignore the v3 patch I posted. Sven ___ devel mailing list

[PATCH v3] staging: fieldbus: core: fix ->poll() annotation

From: Oscar Gomez Fuente ->poll() functions should return __poll_t, but the fieldbus core's poll() does not. This generates a sparse warning. Fix the ->poll() return value, and use recommended __poll_t constants (EPOLLxxx). Signed-off-by: Oscar Gomez Fuente ---

Re: [PATCH] staging: fieldbus: solve warning incorrect type dev_core.c

On Tue, May 21, 2019 at 10:13:58AM -0400, Sven Van Asbroeck wrote: > On Fri, May 17, 2019 at 1:50 PM Oscar Gomez Fuente > wrote: > > > > These changes solve a warning realated to an incorrect type inilizer in the > > function > > fieldbus_poll. > > > > Signed-off-by: Oscar Gomez Fuente > > ---

[PATCH] Staging: rtl8188eu: os_dep: Replace comparison with zero to !x

Change comparison to zero to !x. Replace (x == 0) to !x. Signed-off-by: Puranjay Mohan --- drivers/staging/rtl8188eu/os_dep/rtw_android.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/os_dep/rtw_android.c

Re: [PATCH] staging: fieldbus: solve warning incorrect type dev_core.c

On Fri, May 17, 2019 at 1:50 PM Oscar Gomez Fuente wrote: > > These changes solve a warning realated to an incorrect type inilizer in the > function > fieldbus_poll. > > Signed-off-by: Oscar Gomez Fuente > --- I've reviewed your patch and tested it on a live system. Everything looks good.

Re: [PATCH] staging/gasket: Fix string split

On Tue, May 21, 2019 at 03:50:12PM +0200, Tianzheng Li wrote: > This patch removes unnecessary quoted string splits. > Signed-off-by: Tianzheng Li > Signed-off-by: Jie Zhang We need a blank line before the signed-off-by line. Care to fix this up and resend? thanks, greg k-h

[PATCH] Staging: rtl8192u: ieee80211: Replace function names in strings with "%s", __func__

Use "%s", __func__ in place of strings which contain function names. Signed-off-by: Puranjay Mohan --- drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c

[PATCH] staging/gasket: Fix string split

This patch removes unnecessary quoted string splits. Signed-off-by: Tianzheng Li Signed-off-by: Jie Zhang --- drivers/staging/gasket/gasket_core.c | 6 ++ drivers/staging/gasket/gasket_ioctl.c | 3 +-- drivers/staging/gasket/gasket_page_table.c | 14 ++ 3 files

staging: Add rtl8723bs sdio wifi driver

Hi, static analysis with Coverity has detected an issues in the rtl8723bs wifi driver: File: drivers/staging/rtl8723bs/os_dep/ioctl_linux.c in function rtw_dbg_port(): CID 18480: Operands don't affect result (CONSTANT_EXPRESSION_RESULT) dead_error_condition: The condition (extra_arg & 7U) > 7U

[PATCH] Staging: rtl8723bs: os_dep: Remove functions that don't do anything.

Remove functions which just print the name of function and return 0, These functions fake the network core to say that they support these options. Signed-off-by: Puranjay Mohan --- .../staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 28 +-- 1 file changed, 1 insertion(+), 27

[PATCH] staging: wilc1000: remove redundant masking of pkt_offset

From: Colin Ian King The masking update of pkg_offset is redundant as the updated value is never read and pkg_offset is re-assigned on the next iteration of the loop. Clean this up by removing the redundant assignment. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King ---

Re: [PATCH v3 3/6] staging: kpc2000: simplified kp2000_device retrieval in device attributes call-backs.

On Fri, May 17, 2019 at 01:54:51PM +0200, Greg KH wrote: > On Fri, May 17, 2019 at 12:03:12PM +0100, Jeremy Sowden wrote: > > static ssize_t show_attr(struct device *dev, struct device_attribute > > *attr, char *buf) > > { > > -struct pci_dev *pdev = to_pci_dev(dev); > > -struct

[PATCH v6 3/6] staging: kpc2000: added separate show functions for readable kp device attributes, defined them as read-only, and declared them static.

Defined separate simple show functions for each attribute instead of having a one big one containing a chain of conditionals. Replaced calls to scnprintf with sprintf since all the outputs are single integers. All the readable device attributes are read-only, so used DEVICE_ATTR_RO to define

[PATCH v6 2/6] staging: kpc2000: added a helper to get struct kp2000_device from struct device.

The attribute call-backs all use the same formula to get the pcard from dev: struct pci_dev *pdev = to_pci_dev(dev); struct kp2000_device *pcard; if (!pdev) return -ENXIO; pcard = pci_get_drvdata(pdev); if (!pcard) return -ENXIO; Added a function to reduce the duplicated code.

[PATCH v6 1/6] staging: kpc2000: improved formatting of core.c.

* Indented with tabs. * Broke lines over 80 columns where possible. * Removed braces from one-statement blocks. * Tidied up some comments. * Removed multiple blank lines. Signed-off-by: Jeremy Sowden --- drivers/staging/kpc2000/kpc2000/core.c | 769 ++--- 1 file

[PATCH v6 0/6] staging: kpc2000: another batch of fixes

There are a number relating to device attributes, one formatting patch, and another that changes how card numbers are assigned. Greg reckoned that the changes to the code in the attribute call-backs that gets the struct kpc2000 object from the struct device object were broken. I've reviewed them

[PATCH v6 5/6] staging: kpc2000: simplified kp2000_device retrieval in device attribute call-backs.

All the call-backs used the same formula to retrieve the pcard from dev: struct pci_dev *pdev = to_pci_dev(dev); struct kp2000_device *pcard; if (!pdev) return NULL; pcard = pci_get_drvdata(pdev); Since to_pci_dev is a wrapper for container_of, it will not return NULL, and since

[PATCH v6 4/6] staging: kpc2000: use IDA to assign card numbers.

Previously the next card number was assigned from a static int local variable. Replaced it with an IDA. Avoids the assignment of ever- increasing card-numbers by allowing them to be reused. Updated TODO. Corrected format-specifier for unsigned pcard->card_num. Signed-off-by: Jeremy Sowden

[PATCH v6 6/6] staging: kpc2000: removed superfluous NULL checks from device attribute call-backs.

All the attribute show call-backs check whether pcard is NULL. However, pci_set_drvdata(pdev, pcard) is called before the sysfs files are created during probe, and pci_set_drvdata(pdev, NULL) is not called until after they are destroyed during remove; therefore, pcard will not be NULL, and we can

Re: [PATCH 0/5] Updates to staging driver: kpc_i2c

On Tue, May 21, 2019 at 08:15:52AM +, Geordan Neukum wrote: > On Mon, May 20, 2019 at 10:30:26AM +0200, Greg Kroah-Hartman wrote: > > On Sat, May 18, 2019 at 02:29:55AM +, Geordan Neukum wrote: > > > Attached are an assortment of updates to the kpc_i2c driver in the > > > staging subtree.

Re: [PATCH 0/5] Updates to staging driver: kpc_i2c

> On Mon, May 20, 2019 at 10:30:26AM +0200, Greg Kroah-Hartman wrote: > > All now queued up. I'll rebase my patches that move this file on top of > yours, as kbuild found some problems with mine, and I'll resend them to > the list. > > Thanks. ** Same content as last reply, just realized that I

Re: [PATCH v5 3/8] staging: kpc2000: improved formatting of core.c.

Re: [PATCH v5 3/8] staging: kpc2000: improved formatting of core.c.

On Tue, May 21, 2019 at 08:56:30AM +0100, Jeremy Sowden wrote: > * Indented with tabs. > * Broke lines over 80 columns where possible. > * Removed braces from one-statement blocks. > * Tidied up some comments. > * Removed multiple blank lines. > > Signed-off-by: Jeremy Sowden > --- >

Re: [PATCH 0/5] Updates to staging driver: kpc_i2c

On Mon, May 20, 2019 at 10:30:26AM +0200, Greg Kroah-Hartman wrote: > On Sat, May 18, 2019 at 02:29:55AM +, Geordan Neukum wrote: > > Attached are an assortment of updates to the kpc_i2c driver in the > > staging subtree. > > All now queued up. I'll rebase my patches that move this file on

Re: staging: mt7621-pci: factor out 'mt7621_pcie_enable_port' function

Hi Greg, On Tue, May 21, 2019 at 8:44 AM Greg Ungerer wrote: > > > Hi Sergio, > > I am working on a couple of different MedaiTek MT7621 based platforms > and am having problems with the PCI bus on those. > > Big picture is that the PCI bus on my boards worked in linux-4.20 > (with the obvious

Re: TODO advice for octeon-usb?

On Tue, May 21, 2019 at 02:05:32AM +0300, Aaro Koskinen wrote: > Hi, > > I'm looking for input what should be done next to get > drivers/staging/octeon-usb out of staging. > > Thousands of checkpatch errors/warnings have been fixed (starting point > was

[PATCH v5 2/8] staging: kpc2000: removed two kpc_uio_class device attributes.

The show functions of two attributes output nothing and they are unused. Removed them. Signed-off-by: Jeremy Sowden Reported-by: Matt Sickler --- drivers/staging/kpc2000/kpc2000/cell_probe.c | 16 1 file changed, 16 deletions(-) diff --git

[PATCH v5 5/8] staging: kpc2000: added separate show functions for readable kp device attributes, defined them as read-only, and declared them static.

Defined separate simple show functions for each attribute instead of having a one big one containing a chain of conditionals. Replaced calls to scnprintf with sprintf since all the outputs are single integers. All the readable device attributes are read-only, so used DEVICE_ATTR_RO to define

[PATCH v5 1/8] staging: kpc2000: added separate show functions for kpc_uio_class device attributes, defined them as read-only and declared them static.

Defined separate simple show functions for each attribute instead of having a one big one containing a chain of conditionals. Replaced scnprintf calls with sprintf since all the outputs are short bounded strings or single integers. All of the device attributes are read-only, so used

[PATCH v5 7/8] staging: kpc2000: simplified kp2000_device retrieval in device attribute call-backs.

All the call-backs used the same formula to retrieve the pcard from dev: struct pci_dev *pdev = to_pci_dev(dev); struct kp2000_device *pcard; if (!pdev) return NULL; pcard = pci_get_drvdata(pdev); Since to_pci_dev is a wrapper for container_of, it will not return NULL, and since

[PATCH v5 6/8] staging: kpc2000: use IDA to assign card numbers.

Previously the next card number was assigned from a static int local variable. Replaced it with an IDA. Avoids the assignment of ever- increasing card-numbers by allowing them to be reused. Updated TODO. Corrected format-specifier for unsigned pcard->card_num. Signed-off-by: Jeremy Sowden

[PATCH v5 8/8] staging: kpc2000: removed superfluous NULL checks from device attribute call-backs.

All the attribute show call-backs check whether pcard is NULL. However, pci_set_drvdata(pdev, pcard) is called before the sysfs files are created during probe, and pci_set_drvdata(pdev, NULL) is not called until after they are destroyed during remove; therefore, pcard will not be NULL, and we can

[PATCH v5 3/8] staging: kpc2000: improved formatting of core.c.

* Indented with tabs. * Broke lines over 80 columns where possible. * Removed braces from one-statement blocks. * Tidied up some comments. * Removed multiple blank lines. Signed-off-by: Jeremy Sowden --- drivers/staging/kpc2000/kpc2000/core.c | 788 ++--- 1 file

[PATCH v5 4/8] staging: kpc2000: added a helper to get struct kp2000_device from struct device.

The attribute call-backs all use the same formula to get the pcard from dev: struct pci_dev *pdev = to_pci_dev(dev); struct kp2000_device *pcard; if (!pdev) return -ENXIO; pcard = pci_get_drvdata(pdev); if (!pcard) return -ENXIO; Added a function to reduce the duplicated code.

[PATCH v5 0/8] staging: kpc2000: another batch of fixes

There are a number relating to device attributes, one formatting patch, and another that changes how card numbers are assigned. Greg reckoned that the changes to the code in the attribute call-backs that gets the struct kpc2000 object from the struct device object were broken. I've reviewed them

Re: staging: mt7621-pci: factor out 'mt7621_pcie_enable_port' function

Hi Sergio, I am working on a couple of different MedaiTek MT7621 based platforms and am having problems with the PCI bus on those. Big picture is that the PCI bus on my boards worked in linux-4.20 (with the obvious compilation breakage fixed), and it does not work in linux-5.0 or linux-5.1.

Re: [PATCH 6/7] staging: vt6656: clean-up registers initialization error path

On Mon, May 20, 2019 at 04:39:04PM +, Quentin Deslandes wrote: > Avoid discarding function's return code during register initialization. > Handle it instead and return 0 on success or a negative errno value on > error. > > Signed-off-by: Quentin Deslandes > --- >

Re: TODO advice for octeon-usb?

Hi, Aaro Koskinen writes: > I'm looking for input what should be done next to get > drivers/staging/octeon-usb out of staging. > > Thousands of checkpatch errors/warnings have been fixed (starting point > was ), > also the size of the