Re: [PATCH V3 08/15] staging: unisys: visorhba: use sg helper to operate scatterlist

2019-06-13 Thread Greg Kroah-Hartman
On Fri, Jun 14, 2019 at 10:53:09AM +0800, Ming Lei wrote: > Use the scatterlist iterators and remove direct indexing of the > scatterlist array. > > This way allows us to pre-allocate one small scatterlist, which can be > chained with one runtime allocated scatterlist if the pre-allocated one >

Re: [PATCH V3 07/15] usb: image: microtek: use sg helper to operate scatterlist

2019-06-13 Thread Finn Thain
On Fri, 14 Jun 2019, Ming Lei wrote: > Use the scatterlist iterators and remove direct indexing of the > scatterlist array. > > This way allows us to pre-allocate one small scatterlist, which can be > chained with one runtime allocated scatterlist if the pre-allocated one > isn't enough for the

Re: [PATCH V3 10/15] scsi: aha152x: use sg helper to operate scatterlist

2019-06-13 Thread Finn Thain
Hi Ming, On Fri, 14 Jun 2019, Ming Lei wrote: > Use the scatterlist iterators and remove direct indexing of the > scatterlist array. > > This way allows us to pre-allocate one small scatterlist, which can be > chained with one runtime allocated scatterlist if the pre-allocated one > isn't

[Patch v2 2/3] staging: rtl8723bs: hal: sdio_halinit: fix spaces preferred around that unary operator

2019-06-13 Thread Hariprasad Kelam
This patch fixes below issues reported by checkpatch CHECK: spaces preferred around that '+' (ctx:VxV) CHECK: spaces preferred around that '<<' (ctx:VxV) CHECK: spaces preferred around that '|' (ctx:VxV) Signed-off-by: Hariprasad Kelam -- changes in v2: Send proper patch without corruption

[Patch v2 3/3] staging: rtl8723bs: hal: sdio_halinit: fix Comparison to NULL

2019-06-13 Thread Hariprasad Kelam
This patch fixes below issue reported by checkpatch CHECK: Comparison to NULL could be written "psta" CHECK: Comparison to NULL could be written "psta" Signed-off-by: Hariprasad Kelam - changes in v2: Send proper patch with out corruption ---

[PATCH V3 06/15] scsi: pmcraid: use sg helper to operate scatterlist

2019-06-13 Thread Ming Lei
Use the scatterlist iterators and remove direct indexing of the scatterlist array. This way allows us to pre-allocate one small scatterlist, which can be chained with one runtime allocated scatterlist if the pre-allocated one isn't enough for the whole request. Signed-off-by: Ming Lei ---

[PATCH V3 13/15] scsi: ppa: use sg helper to operate scatterlist

2019-06-13 Thread Ming Lei
Use the scatterlist iterators and remove direct indexing of the scatterlist array. This way allows us to pre-allocate one small scatterlist, which can be chained with one runtime allocated scatterlist if the pre-allocated one isn't enough for the whole request. Signed-off-by: Ming Lei ---

[PATCH V3 12/15] scsi: pcmcia: nsp_cs: use sg helper to operate scatterlist

2019-06-13 Thread Ming Lei
Use the scatterlist iterators and remove direct indexing of the scatterlist array. This way allows us to pre-allocate one small scatterlist, which can be chained with one runtime allocated scatterlist if the pre-allocated one isn't enough for the whole request. Signed-off-by: Ming Lei ---

[PATCH V3 11/15] scsi: imm: use sg helper to operate scatterlist

2019-06-13 Thread Ming Lei
Use the scatterlist iterators and remove direct indexing of the scatterlist array. This way allows us to pre-allocate one small scatterlist, which can be chained with one runtime allocated scatterlist if the pre-allocated one isn't enough for the whole request. Signed-off-by: Ming Lei ---

[PATCH V3 15/15] NCR5380: Support chained sg lists

2019-06-13 Thread Ming Lei
From: Finn Thain My understanding is that support for chained scatterlists is to become mandatory for LLDs. Use the scatterlist iterators and remove direct indexing of the scatterlist array. This way allows us to pre-allocate one small scatterlist, which can be chained with one runtime

[PATCH V3 07/15] usb: image: microtek: use sg helper to operate scatterlist

2019-06-13 Thread Ming Lei
Use the scatterlist iterators and remove direct indexing of the scatterlist array. This way allows us to pre-allocate one small scatterlist, which can be chained with one runtime allocated scatterlist if the pre-allocated one isn't enough for the whole request. Cc: Oliver Neukum Cc: Greg

[PATCH V3 09/15] s390: zfcp_fc: use sg helper to operate scatterlist

2019-06-13 Thread Ming Lei
Use the scatterlist iterators and remove direct indexing of the scatterlist array. This way allows us to pre-allocate one small scatterlist, which can be chained with one runtime allocated scatterlist if the pre-allocated one isn't enough for the whole request. Cc: Steffen Maier Cc: Benjamin

[PATCH V3 14/15] scsi: wd33c93: use sg helper to operate scatterlist

2019-06-13 Thread Ming Lei
Use the scatterlist iterators and remove direct indexing of the scatterlist array. This way allows us to pre-allocate one small scatterlist, which can be chained with one runtime allocated scatterlist if the pre-allocated one isn't enough for the whole request. Signed-off-by: Ming Lei ---

[Patch v2 1/3] staging: rtl8723bs: hal: sdio_halinit: fix comparison to true/false is error prone

2019-06-13 Thread Hariprasad Kelam
fix below issues reported by checkpatch CHECK: Using comparison to false is error prone CHECK: Using comparison to true is error prone Signed-off-by: Hariprasad Kelam changes in v2: send proper patch without corruption --- drivers/staging/rtl8723bs/hal/sdio_halinit.c | 18

[PATCH V3 10/15] scsi: aha152x: use sg helper to operate scatterlist

2019-06-13 Thread Ming Lei
Use the scatterlist iterators and remove direct indexing of the scatterlist array. This way allows us to pre-allocate one small scatterlist, which can be chained with one runtime allocated scatterlist if the pre-allocated one isn't enough for the whole request. Signed-off-by: Ming Lei ---

[PATCH V3 08/15] staging: unisys: visorhba: use sg helper to operate scatterlist

2019-06-13 Thread Ming Lei
Use the scatterlist iterators and remove direct indexing of the scatterlist array. This way allows us to pre-allocate one small scatterlist, which can be chained with one runtime allocated scatterlist if the pre-allocated one isn't enough for the whole request. Cc: de...@driverdev.osuosl.org Cc:

[PATCH V3 04/15] scsi: mvumi: use sg helper to operate scatterlist

2019-06-13 Thread Ming Lei
Use the scatterlist iterators and remove direct indexing of the scatterlist array. This way allows us to pre-allocate one small scatterlist, which can be chained with one runtime allocated scatterlist if the pre-allocated one isn't enough for the whole request. Reviewed-by: Ewan D. Milne

[PATCH V3 05/15] scsi: ipr: use sg helper to operate scatterlist

2019-06-13 Thread Ming Lei
Use the scatterlist iterators and remove direct indexing of the scatterlist array. This way allows us to pre-allocate one small scatterlist, which can be chained with one runtime allocated scatterlist if the pre-allocated one isn't enough for the whole request. Signed-off-by: Ming Lei ---

[PATCH V3 00/15] use sg helper to operate scatterlist

2019-06-13 Thread Ming Lei
Hi, Scsi MQ makes a large static allocation for the first scatter gather list chunk for the driver to use. This is a performance headache we'd like to fix by reducing the size of the allocation to a 2 element array. Doing this will break the current guarantee that any driver using SG_ALL

[PATCH V3 01/15] scsi: vmw_pscsi: use sg helper to operate scatterlist

2019-06-13 Thread Ming Lei
Use the scatterlist iterators and remove direct indexing of the scatterlist array. This way allows us to pre-allocate one small scatterlist, which can be chained with one runtime allocated scatterlist if the pre-allocated one isn't enough for the whole request. Reviewed-by: Ewan D. Milne

[PATCH V3 03/15] scsi: lpfc: use sg helper to operate scatterlist

2019-06-13 Thread Ming Lei
Use the scatterlist iterators and remove direct indexing of the scatterlist array. This way allows us to pre-allocate one small scatterlist, which can be chained with one runtime allocated scatterlist if the pre-allocated one isn't enough for the whole request. Reviewed by: Ewan D. Milne

[PATCH V3 02/15] scsi: advansys: use sg helper to operate scatterlist

2019-06-13 Thread Ming Lei
Use the scatterlist iterators and remove direct indexing of the scatterlist array. This way allows us to pre-allocate one small scatterlist, which can be chained with one runtime allocated scatterlist if the pre-allocated one isn't enough for the whole request. Reviewed-by: Ewan D. Milne

[PATCH] staging: rtl8723bs: Resolve checkpatch error "that open brace { should be on the previous line" in the rtl8723bs driver

2019-06-13 Thread Shobhit Kukreti
Cleaned up the code from the following files to get rid of check patch error "that open brace { should be on the previous line" drivers/staging/rtl8723bs/os_dep/mlme_linux.c drivers/staging/rtl8723bs/os_dep/recv_linux.c drivers/staging/rtl8723bs/os_dep/rtw_proc.c

memory leak in binder_transaction

2019-06-13 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:d1fdb6d8 Linux 5.2-rc4 git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=15e5ce1ea0 kernel config: https://syzkaller.appspot.com/x/.config?x=cb38d33cd06d8d48 dashboard link:

Re: [PATCH] x86/hyperv: Disable preemption while setting reenlightenment vector

2019-06-13 Thread Thomas Gleixner
On Wed, 12 Jun 2019, Vitaly Kuznetsov wrote: > Dmitry Safonov writes: > > diff --git a/arch/x86/hyperv/hv_init.c b/arch/x86/hyperv/hv_init.c > > index 1608050e9df9..0bdd79ecbff8 100644 > > --- a/arch/x86/hyperv/hv_init.c > > +++ b/arch/x86/hyperv/hv_init.c > > @@ -91,7 +91,7 @@

[driver-core:debugfs_cleanup 129/129] drivers/gpu//drm/sti/sti_compositor.c:55:9: warning: 'return' with a value, in function returning void

2019-06-13 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git debugfs_cleanup head: 9831e93ace88fcb51c013ceca0b097133c8efb5f commit: 9831e93ace88fcb51c013ceca0b097133c8efb5f [129/129] drm: huge cleanup... config: arm-allmodconfig (attached as .config) compiler:

Re: [PATCH V2 08/15] staging: unisys: visorhba: use sg helper to operate sgl

2019-06-13 Thread James Bottomley
On Thu, 2019-06-13 at 12:16 +0200, Greg Kroah-Hartman wrote: > On Thu, Jun 13, 2019 at 06:04:11PM +0800, Ming Lei wrote: > > On Thu, Jun 13, 2019 at 11:52:14AM +0200, Greg Kroah-Hartman wrote: > > > On Thu, Jun 13, 2019 at 03:13:28PM +0800, Ming Lei wrote: > > > > The current way isn't safe for

[PATCH] staging: most: deregister net and video config subsystems with configFS

2019-06-13 Thread Christian Gromm
This patch makes the modules net and video deregister its config subsystems when the modules are removed from the kernel. Signed-off-by: Christian Gromm --- drivers/staging/most/net/net.c | 1 + drivers/staging/most/video/video.c | 1 + 2 files changed, 2 insertions(+) diff --git

Hello,

2019-06-13 Thread Issa Ahmed
Hello, I am Mr. Abdulahi Issa, from Burkina Faso in West African region. I work with the Bank of Africa here Which i am the audit manager . Can you safe Guard these amount( $13.5 Million USD) for me in your Country?? Further Details will be given to you if you show Interest. Regards Mr.

[PATCH] staging: kpc2000: remove dead code in core.c

2019-06-13 Thread Simon Sandström
Fixes checkpatch warning: "Consider removing the code enclosed by this #if 0 and its #endif". Signed-off-by: Simon Sandström --- drivers/staging/kpc2000/kpc2000/core.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/kpc2000/kpc2000/core.c

Re: [PATCH V2 08/15] staging: unisys: visorhba: use sg helper to operate sgl

2019-06-13 Thread Dan Carpenter
On Thu, Jun 13, 2019 at 06:04:11PM +0800, Ming Lei wrote: > On Thu, Jun 13, 2019 at 11:52:14AM +0200, Greg Kroah-Hartman wrote: > > On Thu, Jun 13, 2019 at 03:13:28PM +0800, Ming Lei wrote: > > > The current way isn't safe for chained sgl, so use sg helper to > > > operate sgl. > > > > I can not

Re: [PATCH V2 08/15] staging: unisys: visorhba: use sg helper to operate sgl

2019-06-13 Thread Greg Kroah-Hartman
On Thu, Jun 13, 2019 at 06:04:11PM +0800, Ming Lei wrote: > On Thu, Jun 13, 2019 at 11:52:14AM +0200, Greg Kroah-Hartman wrote: > > On Thu, Jun 13, 2019 at 03:13:28PM +0800, Ming Lei wrote: > > > The current way isn't safe for chained sgl, so use sg helper to > > > operate sgl. > > > > I can not

Re: [PATCH V2 08/15] staging: unisys: visorhba: use sg helper to operate sgl

2019-06-13 Thread Ming Lei
On Thu, Jun 13, 2019 at 11:52:14AM +0200, Greg Kroah-Hartman wrote: > On Thu, Jun 13, 2019 at 03:13:28PM +0800, Ming Lei wrote: > > The current way isn't safe for chained sgl, so use sg helper to > > operate sgl. > > I can not make any sense out of this changelog. > > What "isn't safe"? What is

Re: [PATCH 32/34] staging: media: soc_camera: mt9t031: simplify getting the adapter of a client

2019-06-13 Thread Simon Horman
On Sat, Jun 08, 2019 at 12:56:11PM +0200, Wolfram Sang wrote: > We have a dedicated pointer for that, so use it. Much easier to read and > less computation involved. > > Signed-off-by: Wolfram Sang Reviewed-by: Simon Horman > --- > > Please apply to your subsystem tree. > >

Re: [PATCH 31/34] staging: media: soc_camera: imx074: simplify getting the adapter of a client

2019-06-13 Thread Simon Horman
On Sat, Jun 08, 2019 at 12:56:10PM +0200, Wolfram Sang wrote: > We have a dedicated pointer for that, so use it. Much easier to read and > less computation involved. > > Signed-off-by: Wolfram Sang Reviewed-by: Simon Horman > --- > > Please apply to your subsystem tree. > >

Re: [PATCH 33/34] staging: media: soc_camera: soc_mt9v022: simplify getting the adapter of a client

2019-06-13 Thread Simon Horman
On Sat, Jun 08, 2019 at 12:56:12PM +0200, Wolfram Sang wrote: > We have a dedicated pointer for that, so use it. Much easier to read and > less computation involved. > > Signed-off-by: Wolfram Sang Reviewed-by: Simon Horman > --- > > Please apply to your subsystem tree. > >

Re: [PATCH V2 08/15] staging: unisys: visorhba: use sg helper to operate sgl

2019-06-13 Thread Greg Kroah-Hartman
On Thu, Jun 13, 2019 at 03:13:28PM +0800, Ming Lei wrote: > The current way isn't safe for chained sgl, so use sg helper to > operate sgl. I can not make any sense out of this changelog. What "isn't safe"? What is a "sgl"? Can this be applied "out of order"? confused, greg k-h

Re: [PATCH 2/2] staging: rtl8723bs: hal: sdio_halinit: fix spaces preferred around that unary operator

2019-06-13 Thread Greg Kroah-Hartman
On Wed, Jun 12, 2019 at 08:00:19AM +0530, Hariprasad Kelam wrote: > CHECK: spaces preferred around that '+' (ctx:VxV) > CHECK: spaces preferred around that '<<' (ctx:VxV) > CHECK: spaces preferred around that '|' (ctx:VxV) > > Signed-off-by: Hariprasad Kelam > --- >

Re: [PATCH 1/2] staging: rtl8723bs: hal: sdio_halinit: fix comparison to true/false is error prone

2019-06-13 Thread Greg Kroah-Hartman
On Wed, Jun 12, 2019 at 07:59:57AM +0530, Hariprasad Kelam wrote: > CHECK: Using comparison to false is error prone > CHECK: Using comparison to true is error prone > > Signed-off-by: Hariprasad Kelam > --- > drivers/staging/rtl8723bs/hal/sdio_halinit.c | 16 > 1 file changed,

[PATCH RESEND] staging: kpc2000: removed DMA AIO implementation.

2019-06-13 Thread Jeremy Sowden
The existing implementation for doing DMA via asynchronous IO didn't work and there was no longer a use-case for it. Removed it. Fixed a few checkpatch warnings about too-long lines and extraneous braces in the process. Reported-by: Matt Sickler Signed-off-by: Jeremy Sowden ---

Re: [PATCH 1/6] staging: kpc2000_dma: added Kconfig to enable asynchronous I/O.

2019-06-13 Thread Greg KH
On Thu, Jun 13, 2019 at 10:13:06AM +0100, Jeremy Sowden wrote: > On 2019-06-13, at 10:45:31 +0200, Greg KH wrote: > > On Tue, Jun 11, 2019 at 08:50:59PM +0100, Jeremy Sowden wrote: > > > The DMA driver has call-backs for doing asynchronous I/O which are > > > protected by a CONFIG_ macro which is

Re: [PATCH][next] staging: media: meson: remove redundant initialization of mpeg12

2019-06-13 Thread Maxime Jourdan
Hi Colin, On Wed, Jun 12, 2019 at 4:42 PM Colin King wrote: > > From: Colin Ian King > > The pointer mpeg12 is being initialized however that value is never > read and mpeg12 is being re-assigned almost immediately afterwards. > Remove the redundant initialization. > > Addresses-Coverity:

Re: [PATCH 1/6] staging: kpc2000_dma: added Kconfig to enable asynchronous I/O.

2019-06-13 Thread Jeremy Sowden
On 2019-06-13, at 10:45:31 +0200, Greg KH wrote: > On Tue, Jun 11, 2019 at 08:50:59PM +0100, Jeremy Sowden wrote: > > The DMA driver has call-backs for doing asynchronous I/O which are > > protected by a CONFIG_ macro which is not defined. Added a Kconfig > > stanza to define it. > > > > Cc: Matt

Re: [PATCH 1/6] staging: kpc2000_dma: added Kconfig to enable asynchronous I/O.

2019-06-13 Thread Greg KH
On Tue, Jun 11, 2019 at 08:50:59PM +0100, Jeremy Sowden wrote: > The DMA driver has call-backs for doing asynchronous I/O which are > protected by a CONFIG_ macro which is not defined. Added a Kconfig > stanza to define it. > > Cc: Matt Sickler > Signed-off-by: Jeremy Sowden > --- >

Re: [PATCH 01/11] staging: rtl8723bs: core: Remove function eeprom_read_sz()

2019-06-13 Thread Nishka Dasgupta
On 13/06/19 2:05 PM, Dan Carpenter wrote: On Thu, Jun 13, 2019 at 01:53:20PM +0530, Nishka Dasgupta wrote: On 13/06/19 12:15 PM, Dan Carpenter wrote: On Wed, Jun 12, 2019 at 11:34:29PM +0530, Nishka Dasgupta wrote: Remove unused function eeprom_read_sz. Issue found with Coccinelle.

[PATCH v3 1/2] staging: erofs: add requirements field in superblock

2019-06-13 Thread Gao Xiang
There are some backward incompatible features pending for months, mainly due to on-disk format expensions. However, we should ensure that it cannot be mounted with old kernels. Otherwise, it will causes unexpected behaviors. Fixes: ba2b77a82022 ("staging: erofs: add super block operations") Cc:

Re: [PATCH 01/11] staging: rtl8723bs: core: Remove function eeprom_read_sz()

2019-06-13 Thread Dan Carpenter
On Thu, Jun 13, 2019 at 01:53:20PM +0530, Nishka Dasgupta wrote: > On 13/06/19 12:15 PM, Dan Carpenter wrote: > > On Wed, Jun 12, 2019 at 11:34:29PM +0530, Nishka Dasgupta wrote: > > > Remove unused function eeprom_read_sz. > > > Issue found with Coccinelle. > > > > > > Signed-off-by: Nishka

Re: [PATCH 01/11] staging: rtl8723bs: core: Remove function eeprom_read_sz()

2019-06-13 Thread Nishka Dasgupta
On 13/06/19 12:15 PM, Dan Carpenter wrote: On Wed, Jun 12, 2019 at 11:34:29PM +0530, Nishka Dasgupta wrote: Remove unused function eeprom_read_sz. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta This is great but you need to remove the declaration from the .h file as well. I

[PATCH V2 08/15] staging: unisys: visorhba: use sg helper to operate sgl

2019-06-13 Thread Ming Lei
The current way isn't safe for chained sgl, so use sg helper to operate sgl. Cc: de...@driverdev.osuosl.org Cc: Greg Kroah-Hartman Signed-off-by: Ming Lei --- drivers/staging/unisys/visorhba/visorhba_main.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git

Re: [PATCH 01/11] staging: rtl8723bs: core: Remove function eeprom_read_sz()

2019-06-13 Thread Dan Carpenter
On Wed, Jun 12, 2019 at 11:34:29PM +0530, Nishka Dasgupta wrote: > Remove unused function eeprom_read_sz. > Issue found with Coccinelle. > > Signed-off-by: Nishka Dasgupta This is great but you need to remove the declaration from the .h file as well. I noticed some of the other patches have