Hi Brett, Greg,
I am a little busy with some work stuff, so sorry for my late response.
On Mon, Jun 17, 2019 at 5:57 AM Greg Ungerer wrote:
>
> Hi Brett,
>
> On 15/6/19 11:53 pm, Brett Neumeier wrote:
> [snip]
> > For what it's worth -- possibly nothing? -- I grabbed the most recent six
> >
this patch fixes below issue reported by checkpatch.pl
CHECK: Lines should not end with a '('
CHECK: Lines should not end with a '('
Signed-off-by: Hariprasad Kelam
---
drivers/staging/rtl8723bs/hal/odm_RegConfig8723B.h | 61 ++
1 file changed, 28 insertions(+), 33
This patch is a cleanup which replaces rtw_malloc(wep_total_len) with
kzalloc() and removes the memset().
The rtw_malloc() does GFP_ATOMIC allocations when in_atomic() is true.
But as the comments for in_atomic() describe, the in_atomic() check
should not be used in driver code. The in_atomic()
Cleaned Up code to fix brace style issues reported by checkpatch:
-space required before the open brace '{'
-Unbalanced braces around if/else statements
Signed-off-by: Shobhit Kukreti
---
drivers/staging/rtl8723bs/hal/hal_btcoex.c | 25 +++--
1 file changed, 11
Removing comparisons to True/False in if statements.
Checkpatch reported:
CHECK: Using comparison to true is error prone
Signed-off-by: Shobhit Kukreti
---
drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git
Cleaned up the code to resolve the checkpatch error else should follow
close brace '}' from the following files:
mlme_linux.c
recv_linux.c
sdio_intf.c
Signed-off-by: Shobhit Kukreti
---
drivers/staging/rtl8723bs/os_dep/mlme_linux.c | 6 ++
drivers/staging/rtl8723bs/os_dep/recv_linux.c |
Cleaned up the code from the following files to get rid of
check patch error "that open brace { should be on the previous line"
drivers/staging/rtl8723bs/os_dep/mlme_linux.c
drivers/staging/rtl8723bs/os_dep/recv_linux.c
drivers/staging/rtl8723bs/os_dep/rtw_proc.c
This patchset fixes the following errors reported by checkpatch in the
staging/rtl8723bs driver.
Patch[1/3]: Fix check patch error "that open brace { should be on the
previous line"
Patch[2/3]: Fix the error else should follow close brace '}'
Patch[3/3]: Fix Indentation Error
The patch
Resolve indentation errors which were caused by a mix of space and tabs
for indentation. Previous patch to fix if-else brace styles revealed
the indentation error
Signed-off-by: Shobhit Kukreti
---
drivers/staging/rtl8723bs/os_dep/recv_linux.c | 6 ++---
Hi Ming,
> So convert drivers to use scatterlist helper.
I applied this series with a bunch of edits and clarifying comments. It
was quite the nightmare to rebase 5.3/scsi-queue to satisfy the ordering
requirements, locate the scattered fixes, tweak tags, etc. Hope I got
everything right.
It
On Tue, 2019-06-18 at 19:14 +0300, Dmitry Osipenko wrote:
> The BIT macro isn't available in userspace. Checkpatch complains about
> shifts being used instead of the macro and people are starting to send
> patches without realizing that it's a UAPI header file. Hence let's
> replace the BIT macro
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git
debugfs_cleanup
head: b1494ab6cdfdf79167ae2e9054d57e86a4130f5f
commit: 13e71424e523cd0da6095ac037ed2ecdf0424f68 [151/155] gpio: mockup: no
need to check return value of debugfs_create functions
config:
this patch fixes below issues reported by checkpatch
CHECK: Using comparison to true is error prone
CHECK: Using comparison to false is error prone
Signed-off-by: Hariprasad Kelam
---
drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c | 14 +++---
1 file changed, 7 insertions(+), 7
This patch fixes below issues reported by checkpatch
CHECK: Comparison to NULL could be written "psta"
CHECK: Comparison to NULL could be written
"pmlmepriv->wps_probe_resp_ie"
CHECK: Comparison to NULL could be written "psta"
Signed-off-by: Hariprasad Kelam
---
On Tue, 2019-06-18 at 20:37 +0200, Johannes Berg wrote:
> On Tue, 2019-06-18 at 11:23 -0700, Joe Perches wrote:
> > include/uapi/linux/nl80211.h: * bitmask of BIT(NL80211_BAND_*) as described
> > in %enum
> >
> >
> That's a comment :P
That's true and that's nice.
It was a casual grep and the
On Tue, 2019-06-18 at 11:23 -0700, Joe Perches wrote:
>
> include/uapi/linux/nl80211.h: * bitmask of BIT(NL80211_BAND_*) as described
> in %enum
>
>
That's a comment :P
johannes
___
devel mailing list
de...@linuxdriverproject.org
alloc_etherdev function internally calls kvzalloc . So we may not need
explicit memset after this call.
Signed-off-by: Hariprasad Kelam
---
drivers/staging/wilc1000/wilc_netdev.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/wilc1000/wilc_netdev.c
alloc_etherdev function internally calls kvzalloc . So we may not need
explicit memset after this call.
Signed-off-by: Hariprasad Kelam
---
drivers/staging/rtl8192e/rtllib_module.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtl8192e/rtllib_module.c
alloc_etherdev function internally calls kvzalloc . So we may not need
explicit memset after this call.
Signed-off-by: Hariprasad Kelam
---
drivers/staging/rtl8192u/ieee80211/ieee80211_module.c | 1 -
1 file changed, 1 deletion(-)
diff --git
kmalloc followed by memset can be replaced with kzalloc.
Signed-off-by: Hariprasad Kelam
---
drivers/staging/rtl8712/rtl871x_io.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_io.c
b/drivers/staging/rtl8712/rtl871x_io.c
index
All Tegra's could provide memory isolation for the video decoder
hardware using IOMMU, it is also required for Tegra30+ in order
to handle sparse dmabuf's which GPU exports in a default kernel
configuration.
Inspired-by: Thierry Reding
Signed-off-by: Dmitry Osipenko
---
The __packed macro isn't available in userspace with the kernel headers.
Checkpatch asks to use the macro, which is unwanted in a case of a UAPI
header. There is no much benefit in a tight packing of the structures,
hence let's pack them manually to cleanup things a tad. Note that there
is no
All NVIDIA Tegra SoC generations provide IOMMU support for the video
decoder engine. Document new optional device-tree property that connects
VDE with the IOMMU provider.
Signed-off-by: Dmitry Osipenko
---
Documentation/devicetree/bindings/media/nvidia,tegra-vde.txt | 2 ++
1 file changed, 2
Hello,
This series cleans up some of minor shortcomings that are caused by
checkpatch recommendations that are not very applicable for the driver.
Then IOMMU support is added to the driver and now it can handle sparse
memory buffers that GPU hands to VDE in a default kernel configuration
on
Frequent IOMMU remappings take about 50% of CPU usage because there is
quite a lot to remap. Defer dmabuf's unmapping by 5 seconds in order to
mitigate the mapping overhead which goes away completely and driver works
as fast as in a case of a disabled IOMMU. The case of a disabled IOMMU
should
Enable IOMMU support for the video decoder.
Signed-off-by: Dmitry Osipenko
---
arch/arm/boot/dts/tegra30.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/boot/dts/tegra30.dtsi b/arch/arm/boot/dts/tegra30.dtsi
index 934caa83c8db..ce162125e7bf 100644
---
The BIT macro isn't available in userspace. Checkpatch complains about
shifts being used instead of the macro and people are starting to send
patches without realizing that it's a UAPI header file. Hence let's
replace the BIT macro with a hex values to make everyone happy.
Signed-off-by: Dmitry
The video decoder driver was tested by time and works absolutely fine.
The reason why it is in staging is because it doesn't provide common V4L
interface yet, this shouldn't stop driver enabling in the defconfig since
our userspace (libvdpau-tegra) provides combined acceleration of decoding
and
It's weird that that binder_alloc_copy_from_buffer() is a void function.
It would be easier to do the error handling at that point, instead of in
the callers. It feels like we keep hitting similar bugs to this.
regards,
dan carpenter
___
devel mailing
Hello,
syzbot found the following crash on:
HEAD commit:9e0babf2 Linux 5.2-rc5
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=159e6121a0
kernel config: https://syzkaller.appspot.com/x/.config?x=d16883d6c7f0d717
dashboard link:
From: Colin Ian King
Currently there are several left shifts that are assigned to 64 bit
unsigned longs where a signed int 1 is being shifted, resulting in
an integer overflow. Fix this bit using the BIT_ULL macro to perform
a 64 bit shift. Also clean up an overly long statement.
On Tue, Jun 18, 2019 at 07:14:10AM +0530, Hariprasad Kelam wrote:
> kmalloc with memset can be replaced with kzalloc.
>
> Signed-off-by: Hariprasad Kelam
> -
> changes in v2: Replace rtw_zmalloc with kzalloc
> ---
> ---
The changelog should say something like:
This patch is a cleanup
On 2019/6/18 15:05, Greg Kroah-Hartman wrote:
> On Tue, Jun 18, 2019 at 02:52:21PM +0800, Gao Xiang wrote:
>>
>>
>> On 2019/6/18 14:45, Greg Kroah-Hartman wrote:
>>> On Tue, Jun 18, 2019 at 02:18:00PM +0800, Gao Xiang wrote:
On 2019/6/18 13:47, Greg Kroah-Hartman wrote:
> On
On Tue, Jun 18, 2019 at 02:52:21PM +0800, Gao Xiang wrote:
>
>
> On 2019/6/18 14:45, Greg Kroah-Hartman wrote:
> > On Tue, Jun 18, 2019 at 02:18:00PM +0800, Gao Xiang wrote:
> >>
> >>
> >> On 2019/6/18 13:47, Greg Kroah-Hartman wrote:
> >>> On Tue, Jun 18, 2019 at 09:47:08AM +0800, Gao Xiang
On Sun, Jun 16, 2019 at 09:19:49AM -0700, Shobhit Kukreti wrote:
> Cleaned up the code from the following files to get rid of
> check patch error "that open brace { should be on the previous line"
>
> drivers/staging/rtl8723bs/os_dep/mlme_linux.c
> drivers/staging/rtl8723bs/os_dep/recv_linux.c
>
On Sun, Jun 16, 2019 at 10:46:19AM +0530, Hariprasad Kelam wrote:
> rtw_malloc with memset can be replaced with rtw_zmalloc.
>
> Signed-off-by: Hariprasad Kelam
> ---
> drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git
On Tue, Jun 18, 2019 at 07:14:10AM +0530, Hariprasad Kelam wrote:
> kmalloc with memset can be replaced with kzalloc.
Yes, but did you audit the call-paths of this to ensure that GFP_KERNEL
is the correct value for kzalloc() here? If so, please document that in
the changelog.
thanks,
greg k-h
On 2019/6/18 14:45, Greg Kroah-Hartman wrote:
> On Tue, Jun 18, 2019 at 02:18:00PM +0800, Gao Xiang wrote:
>>
>>
>> On 2019/6/18 13:47, Greg Kroah-Hartman wrote:
>>> On Tue, Jun 18, 2019 at 09:47:08AM +0800, Gao Xiang wrote:
On 2019/6/18 4:36, Greg Kroah-Hartman wrote:
> On
On Tue, Jun 18, 2019 at 02:18:00PM +0800, Gao Xiang wrote:
>
>
> On 2019/6/18 13:47, Greg Kroah-Hartman wrote:
> > On Tue, Jun 18, 2019 at 09:47:08AM +0800, Gao Xiang wrote:
> >>
> >>
> >> On 2019/6/18 4:36, Greg Kroah-Hartman wrote:
> >>> On Sat, Jun 15, 2019 at 02:16:11AM +0800, Gao Xiang
On 2019/6/18 13:47, Greg Kroah-Hartman wrote:
> On Tue, Jun 18, 2019 at 09:47:08AM +0800, Gao Xiang wrote:
>>
>>
>> On 2019/6/18 4:36, Greg Kroah-Hartman wrote:
>>> On Sat, Jun 15, 2019 at 02:16:11AM +0800, Gao Xiang wrote:
At last, this is RFC patch v1, which means it is not suitable for
40 matches
Mail list logo
