Resolve checkpatch warning:
Prefer kzalloc(sizeof(*ptr)...) over kzalloc(sizeof(struct ..)
Signed-off-by: Shobhit Kukreti
---
drivers/staging/erofs/super.c | 2 +-
drivers/staging/erofs/unzip_vle.c | 3 +--
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git
From: Melissa Wen
[ Upstream commit df4d737ee4d7205aaa6275158aeebff87fd14488 ]
According to the AD7150 configuration register description, bit 7 assumes
value 1 when the threshold mode is fixed and 0 when it is adaptive,
however, the operation that identifies this mode was considering the
From: Melissa Wen
[ Upstream commit df4d737ee4d7205aaa6275158aeebff87fd14488 ]
According to the AD7150 configuration register description, bit 7 assumes
value 1 when the threshold mode is fixed and 0 when it is adaptive,
however, the operation that identifies this mode was considering the
From: Melissa Wen
[ Upstream commit df4d737ee4d7205aaa6275158aeebff87fd14488 ]
According to the AD7150 configuration register description, bit 7 assumes
value 1 when the threshold mode is fixed and 0 when it is adaptive,
however, the operation that identifies this mode was considering the
From: Melissa Wen
[ Upstream commit df4d737ee4d7205aaa6275158aeebff87fd14488 ]
According to the AD7150 configuration register description, bit 7 assumes
value 1 when the threshold mode is fixed and 0 when it is adaptive,
however, the operation that identifies this mode was considering the
Fix a cut error in find_pipeline_entity(). The start entity must be
passed to media_entity_to_video_device() in find_pipeline_entity(), not
pad->entity. The pad is only put to use later, after determining the start
entity is not the entity being searched for.
Fixes: 3ef46bc97ca2 ("media:
Thanks for catching,
On 6/26/19 11:27 AM, Colin Ian King wrote:
Hi,
Static analysis with Coverity on Linux next has found a potential issue
with the following commit:
commit 3ef46bc97ca2c918b7657a08220c7340a9bb07a2
Author: Steve Longerbeam
Date: Fri May 10 17:50:11 2019 -0400
media:
Hi,
Static analysis with Coverity on Linux next has found a potential issue
with the following commit:
commit 3ef46bc97ca2c918b7657a08220c7340a9bb07a2
Author: Steve Longerbeam
Date: Fri May 10 17:50:11 2019 -0400
media: staging/imx: Improve pipeline searching
The issue is in
On Wed, 2019-06-26 at 16:28 +0200, Tobias Nießen wrote:
> This commit uses the fact that
>
> if (a) {
> if (b) {
> ...
> }
> }
>
> can instead be written as
>
> if (a && b) {
> ...
> }
>
> without any change in behavior,
Remove variable rtStatus and return phy_RF6052_Config_ParaFile function
directly
Signed-off-by: Hariprasad Kelam
---
drivers/staging/rtl8723bs/hal/rtl8723b_rf6052.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_rf6052.c
Remove set but unsed variable pHalData in below functions
_InitOperationMode
SetHwReg8723BS
Signed-off-by: Hariprasad Kelam
---
drivers/staging/rtl8723bs/hal/sdio_halinit.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c
Remove set but unsed variable pHalData in hw_var_set_mlme_join
function
Signed-off-by: Hariprasad Kelam
---
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
Remove set but unsed variable pHalData in rtl8723b_set_FwRsvdPagePkt
function
Signed-off-by: Hariprasad Kelam
---
drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c
The commit 52c4dfcead49 ("Staging: vc04_services: Cleanup in
ctrl_set_bitrate()") changed the return behavior of ctrl_set_bitrate().
We cannot do this because of a bug in the firmware, which breaks probing
of bcm2835-camera:
bcm2835-v4l2: mmal_init: failed to set all camera controls: -3
Both these patches seem fine.
On Wed, Jun 26, 2019 at 04:28:56PM +0200, Tobias Nießen wrote:
> This commit uses the fact that
>
> if (a) {
> if (b) {
> ...
> }
> }
>
> can instead be written as
>
> if (a && b) {
> ...
> }
This bitwisen / boolean expression can be made more readable while
reducing the line lengths at the same time. This commit uses the
fact that
a & (b | c) == (b | c)
evaluates to true if and only if
(a & b) && (a & c)
is true. Since b and c are constants with relatively long names,
This commit uses the fact that
if (a) {
if (b) {
...
}
}
can instead be written as
if (a && b) {
...
}
without any change in behavior, allowing to decrease the indentation
of the contained code block and thus reducing the
The following two patches improve the code style in the rts5208 staging
driver. Many other style issues cannot be resolved without much more
extensive refactoring.
___
devel mailing list
de...@linuxdriverproject.org
The interrupt handler `dt282x_interrupt()` causes a null pointer
dereference for those supported boards that have no analog output
support. For these boards, `dev->write_subdev` will be `NULL` and
therefore the `s_ao` subdevice pointer variable will be `NULL`. In that
case, the following call
Move analogix chip ANX78XX bridge driver into "analogix" directory.
Signed-off-by: Xin Ji
---
drivers/gpu/drm/bridge/Kconfig | 10 -
drivers/gpu/drm/bridge/Makefile|3 +-
drivers/gpu/drm/bridge/analogix-anx78xx.c | 1485
The interrupt handler `pci230_interrupt()` causes a null pointer
dereference for a PCI260 card. There is no analog output subdevice for
a PCI260. The `dev->write_subdev` subdevice pointer and therefore the
`s_ao` subdevice pointer variable will be `NULL` for a PCI260. The
following call near
Hi Greg,
On Wed, Jun 26, 2019 at 2:18 PM Greg Ungerer wrote:
>
> Hi Sergio,
>
> On 26/6/19 5:10 pm, Sergio Paracuellos wrote:
> > On Wed, Jun 26, 2019 at 5:31 AM Greg Ungerer wrote:
> >> On 25/6/19 10:47 pm, Sergio Paracuellos wrote:
> >>> On Tue, Jun 25, 2019 at 7:18 AM Sergio Paracuellos
>
Add missing parenthesis to PCIE_FTS_NUM_LO macro to do the
same it was being done in original code.
Fixes: a4b2eb912bb1 ("staging: mt7621-pci: rewrite RC FTS configuration")
Signed-off-by: Sergio Paracuellos
---
drivers/staging/mt7621-pci/pci-mt7621.c | 2 +-
1 file changed, 1 insertion(+), 1
From: Ajay Singh
Removed the use of two hardcoded interfaces and added support to
add/remove the network interfaces dynamically.
Now the driver will have single default interface with name 'wlan0' and
later other interface can be added from user space application e.g
using 'iw add' command.
Also
From: Ajay Singh
Cleanup patch to remove the passing of driver handler, get the 'idx'
value inside the called function.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/host_interface.c | 116 ++
drivers/staging/wilc1000/wilc_wlan.c | 3 +-
From: Ajay Singh
Removed the 'driver_handler_id' & 'ifc_id' elements and used 'idx' to
identify the handler.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/host_interface.c | 3 +--
drivers/staging/wilc1000/host_interface.h | 1 -
drivers/staging/wilc1000/wilc_netdev.c
From: Ajay Singh
This patch series mainly contains the changes to support the
add/delete of wlan0/p2p0 network interfaces dynamically. The driver
will be loaded with a single default interface and later new interfaces
can be added or removed.
Also included few cleanup patches in this series.
From: Ajay Singh
For the error path in wilc_wlan_initialize(), the resources are not
cleanup in the correct order. Reverted the previous changes and use the
correct order to free during error condition.
Fixes: b46d68825c2d ("staging: wilc1000: remove COMPLEMENT_BOOT")
Cc:
Signed-off-by: Ajay
From: Ajay Singh
Cleanup patch to avoid loop to traverse the interfaces instead make use
of vif received from net_device priv data.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/host_interface.c | 7 +--
drivers/staging/wilc1000/wilc_netdev.c| 16 +---
2 files
From: Ajay Singh
Remove use of 'src_addr' element in wilc_vif, as the same information
already copied to net_device->dev_addr.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/wilc_netdev.c| 3 +--
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 2 +-
From: Ajay Singh
Rename 'host_interface' source and header file to include the 'wilc_'
prefix in its name.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/Makefile | 2 +-
drivers/staging/wilc1000/{host_interface.c => wilc_hif.c} | 0
From: Ajay Singh
Moved the handling of p2p related operation in the caller context instead
of using workqueue.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/host_interface.c | 46 ---
1 file changed, 17 insertions(+), 29 deletions(-)
diff --git
On Wed, Jun 26, 2019 at 10:44:38AM +, Xin Ji wrote:
> Move analogix chip ANX78XX bridge driver into "analogix" directory.
>
> Signed-off-by: Xin Ji
> ---
> drivers/gpu/drm/bridge/Kconfig | 10 -
> drivers/gpu/drm/bridge/Makefile|3 +-
>
Hi Sergio,
On 26/6/19 5:10 pm, Sergio Paracuellos wrote:
On Wed, Jun 26, 2019 at 5:31 AM Greg Ungerer wrote:
On 25/6/19 10:47 pm, Sergio Paracuellos wrote:
On Tue, Jun 25, 2019 at 7:18 AM Sergio Paracuellos
wrote:
On Tue, Jun 25, 2019 at 7:10 AM Greg Ungerer wrote:
On 23/6/19 3:58 pm,
From: Yue Hu
Already check if ->datamode is supported in read_inode(), no need to check
again in the next fill_inline_data() only called by fill_inode().
Signed-off-by: Yue Hu
Reviewed-by: Gao Xiang
Reviewed-by: Chao Yu
---
v2: add tags.
drivers/staging/erofs/inode.c | 2 --
1 file
Hi Yue,
On 2019/6/26 18:39, Yue Hu wrote:
> From: Yue Hu
>
> Already check if ->datamode is supported in read_inode(), no need to check
> again in the next fill_inline_data() only called by fill_inode().
>
> Signed-off-by: Yue Hu
> Reviewed-by: Gao Xiang
> Reviewed-by: Chao Yu
Bump the
Hi Stefan.
On Tue, 25 Jun 2019 at 17:30, Stefan Wahren wrote:
>
> Hi Dan,
> hi Dave,
>
> Am 25.06.19 um 09:55 schrieb Dan Carpenter:
> > On Tue, Jun 25, 2019 at 12:13:15AM +0200, Stefan Wahren wrote:
> >> The commit 52c4dfcead49 ("Staging: vc04_services: Cleanup in
> >> ctrl_set_bitrate()")
From: Yue Hu
Already check if ->datamode is supported in read_inode(), no need to check
again in the next fill_inline_data() only called by fill_inode().
Signed-off-by: Yue Hu
Reviewed-by: Gao Xiang
Reviewed-by: Chao Yu
---
drivers/staging/erofs/inode.c | 2 --
1 file changed, 2
On 26/06/2019 07:44, Nishka Dasgupta wrote:
Remove unused function log_csv_error.
Issue found with Coccinelle.
Signed-off-by: Nishka Dasgupta
---
drivers/staging/greybus/tools/loopback_test.c | 6 --
1 file changed, 6 deletions(-)
diff --git
Hi Yue,
On 2019/6/26 11:30, Yue Hu wrote:
> From: Yue Hu
>
> We should consider the error returned by fill_inline_data() when filling
> last page in fill_inode(). If not getting inode will be successful even
> though last page is bad. That is illogical. Also change -EAGAIN to 0 in
>
Hi Yue,
On 2019/6/26 11:28, Yue Hu wrote:
> From: Yue Hu
>
> Already check if ->datamode is supported in read_inode(), no need to check
> again in the next fill_inline_data() only called by fill_inode().
>
> Signed-off-by: Yue Hu
You should add all the 'Reviewed-by' / 'Acked-by' / ... tags
Update __ccwdev_check_busid() and __ccwgroupdev_check_busid() to use
"const" qualifiers to fix the compiler warning.
Reported-by: kbuild test robot
Cc: gre...@linuxfoundation.org
Cc: de...@driverdev.osuosl.org
Signed-off-by: Suzuki K Poulose
---
drivers/s390/cio/ccwgroup.c | 2 +-
Hi Ming,
On 6/26/19 5:07 AM, Ming Lei wrote:
On Tue, Jun 25, 2019 at 12:51:04PM +0200, Steffen Maier wrote:
I don't mind doing this change for zfcp. However, I'm having doubts
regarding the rationale in the commit description.
However, I still suggest to do it because it will make us to
This is better.
Reviewed-by: Dan Carpenter
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
The unconditioned jump will prohibit to ever reach the break-statement.
Deleting this needless statement, the code becomes more understandable.
Signed-off-by: Fabian Krueger
Signed-off-by: Michael Scheiderer
Cc:
---
drivers/staging/kpc2000/kpc2000_spi.c | 1 -
1 file changed, 1 deletion(-)
Replaced 'unsigned' with it's equivalent 'unsigned int' to reduce
confusion while reading the code.
Signed-off-by: Fabian Krueger
Signed-off-by: Michael Scheiderer
Cc:
---
drivers/staging/kpc2000/kpc2000_spi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
Instead of using the function name hard coded as string, using __func__
and the '%s'-placeholder will always give the current name of the
function. When renaming a function, the debugging-messages won't have to
be rewritten.
Signed-off-by: Fabian Krueger
Signed-off-by: Michael Scheiderer
Cc:
Added spaces on the left side of parenthesis and on both sides of binary
operators. Also realigned else and else if so it matches the
parenthesis line.
This refactoring makes the code more readable.
Signed-off-by: Fabian Krueger
Signed-off-by: Michael Scheiderer
Cc:
---
Removed brackets on around one-lined if-cases.
This refactoring makes the code more readable.
Signed-off-by: Fabian Krueger
Signed-off-by: Michael Scheiderer
Cc:
---
drivers/staging/kpc2000/kpc2000_spi.c | 30 +--
1 file changed, 10 insertions(+), 20 deletions(-)
diff
Replaced __attribute__((packed)) with __packed. Both ways of attributing
are equivalent, but being shorter, __packed should be preferred.
This refactoring makes the core more readable.
Signed-off-by: Fabian Krueger
Signed-off-by: Michael Scheiderer
Cc:
---
After the declarations in a function, there should be a blank line, so
that the declaration part is visibly separated from the rest.
This refactoring makes the code more readable.
Signed-off-by: Fabian Krueger
Signed-off-by: Michael Scheiderer
Cc:
---
drivers/staging/kpc2000/kpc2000_spi.c | 4
A patch-series that will remove warnings, errors and check-messages,
noted and highlighted by the checkpatch.pl script concerning
kpc2000_spi.c.
Signed-off-by: Fabian Krueger
Signed-off-by: Michael Scheiderer
Cc:
Fabian Krueger (8):
staging: kpc2000: add line breaks
staging: kpc2000:
To fix some checkpatch-warnings some lines of this module had to be
shortened so that they do not exceed 80 characters per line.
This refactoring makes the code more readable.
Signed-off-by: Fabian Krueger
Signed-off-by: Michael Scheiderer
Cc:
---
drivers/staging/kpc2000/kpc2000_spi.c | 34
On 2019/6/26 11:30, Yue Hu wrote:
> From: Yue Hu
>
> We should consider the error returned by fill_inline_data() when filling
> last page in fill_inode(). If not getting inode will be successful even
> though last page is bad. That is illogical. Also change -EAGAIN to 0 in
> fill_inline_data()
Hi Greg,
On Wed, Jun 26, 2019 at 5:31 AM Greg Ungerer wrote:
>
> Hi Sergio,
>
> On 25/6/19 10:47 pm, Sergio Paracuellos wrote:
> > On Tue, Jun 25, 2019 at 7:18 AM Sergio Paracuellos
> > wrote:
> >> On Tue, Jun 25, 2019 at 7:10 AM Greg Ungerer wrote:
> >>> On 23/6/19 3:58 pm, Sergio Paracuellos
On 2019/6/26 11:28, Yue Hu wrote:
> From: Yue Hu
>
> Already check if ->datamode is supported in read_inode(), no need to check
> again in the next fill_inline_data() only called by fill_inode().
>
> Signed-off-by: Yue Hu
Reviewed-by: Chao Yu
Thanks,
Remove function clk_sce as all it does is call clk_gat_sce.
Modify call site of clk_sce to call clk_gat_sce instead.
Issue found with Coccinelle.
Signed-off-by: Nishka Dasgupta
---
drivers/staging/comedi/drivers/amplc_dio200_common.c | 8 +---
1 file changed, 1 insertion(+), 7 deletions(-)
Remove function gat_sce as all it does is call clk_gat_sce.
Modify call sites of the former to call the latter directly.
Issue found with Coccinelle.
Signed-off-by: Nishka Dasgupta
---
drivers/staging/comedi/drivers/amplc_dio200_common.c | 8 +---
1 file changed, 1 insertion(+), 7
Remove function mite_request_channel_in_range as all it does is call
__mite_request_channel.
Rename __mite_request_channel to mite_request_channel_in_range and
change its type from static to non-static to maintain compatibility with
call sites.
Change only remaining call site of
Remove return variable as its value is not altered between
initialisation and return.
Issue found with Coccinelle.
Signed-off-by: Nishka Dasgupta
---
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
Remove function odm_TXPowerTrackingInit as all it does is call
odm_TXPowerTrackingThermalMeterInit.
Rename odm_TXPowerTrackingThermalMeterInit to odm_TXPowerTrackingInit
for compatibility with call sites.
Issue found with Coccinelle.
Signed-off-by: Nishka Dasgupta
---
Remove the declarations of the following unused functions from
rtw_eeprom.h:
- eeprom_write16
- eeprom_read16
- eeprom_read_sz
- read_eeprom_content
- read_eeprom_content_by_attrib.
Signed-off-by: Nishka Dasgupta
---
drivers/staging/rtl8188eu/include/rtw_eeprom.h | 6 --
1 file changed, 6
Remove function ODM_TXPowerTrackingCheck as all it does is call
odm_TXPowerTrackingCheckCE.
Rename odm_TXPowerTrackingCheckCE to ODM_TXPowerTrackingCheck for
compatibility with call sites.
Issue found with Coccinelle.
Signed-off-by: Nishka Dasgupta
---
drivers/staging/rtl8188eu/hal/odm.c
Change type of function rtl8192_rx_initiate from int to void as it
always returns 0 and this value is never used.
Signed-off-by: Nishka Dasgupta
---
drivers/staging/rtl8192u/r8192U_core.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git
Remove unused function dm_backup_dynamic_mechanism_state.
Issue found with Coccinelle.
Signed-off-by: Nishka Dasgupta
---
drivers/staging/rtl8192u/r8192U_dm.c | 12
drivers/staging/rtl8192u/r8192U_dm.h | 1 -
2 files changed, 13 deletions(-)
diff --git
Remove unused function log_csv_error.
Issue found with Coccinelle.
Signed-off-by: Nishka Dasgupta
---
drivers/staging/greybus/tools/loopback_test.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/staging/greybus/tools/loopback_test.c
Remove function r8712_dequeue_cmd as all it does is call _dequeue_cmd.
Rename _dequeue_cmd to r8712_dequeue_cmd and change its type from static
to non-static to maintain compatibility with call sites.
Issue found with Coccinelle.
Signed-off-by: Nishka Dasgupta
---
Change return values of function mp_start_test() from _SUCCESS/_FAIL to
0/-ENOMEM and modify call sites accordingly.
Signed-off-by: Nishka Dasgupta
---
drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git
Change return values of function r8712_parse_wpa2_ie from
_SUCCESS/_FAIL to 0/-EINVAL.
Signed-off-by: Nishka Dasgupta
---
drivers/staging/rtl8712/ieee80211.c | 12 ++--
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 2 +-
2 files changed, 7 insertions(+), 7 deletions(-)
Change call site of function r8712_xmit_resource_alloc to add a check
for its return value.
Change return values of r8712_xmit_resource_alloc from
_SUCCESS/_FAIL to 0/-ENOMEM.
Signed-off-by: Nishka Dasgupta
---
drivers/staging/rtl8712/rtl871x_xmit.c | 3 ++-
drivers/staging/rtl8712/xmit_linux.c
Change return type of function _r8712_free_sta_priv from u32 to void as
it always returns _SUCCESS and this return value is never used.
Signed-off-by: Nishka Dasgupta
---
drivers/staging/rtl8712/rtl871x_sta_mgt.c | 3 +--
drivers/staging/rtl8712/sta_info.h| 2 +-
2 files changed, 2
Change return values of r8712_getrfreg_cmd from _SUCCESS/_FAIL to
0/-ENOMEM respectively. Modify call site accordingly.
Signed-off-by: Nishka Dasgupta
---
drivers/staging/rtl8712/rtl871x_cmd.c | 8
drivers/staging/rtl8712/rtl871x_cmd.h | 2 +-
Merge function _enqueue_cmd into function r8712_enqueue_cmd as
_enqueue_cmd is only called by r8712_enqueue_cmd, and then only once.
Signed-off-by: Nishka Dasgupta
---
drivers/staging/rtl8712/rtl871x_cmd.c | 17 +++--
1 file changed, 7 insertions(+), 10 deletions(-)
diff --git
Add check for the return value of function _r8712_init_sta_priv at call
site.
Change return values of the function from _SUCCESS/_FAIL to 0/-ENOMEM
respectively.
Change return type of the function from u32 to int to enable return of
-ENOMEM.
Signed-off-by: Nishka Dasgupta
---
Change return values of function r8712_parse_wpa_ie from _SUCCESS/_FAIL
to 0/-EINVAL. Modify call site accordingly.
Signed-off-by: Nishka Dasgupta
---
drivers/staging/rtl8712/ieee80211.c | 12 ++--
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 2 +-
2 files changed, 7
75 matches
Mail list logo
