Change return type of r8712_xmitframe_aggr_1st from u8 to void as it
always returns _SUCCESS and its return value is never used.
Signed-off-by: Nishka Dasgupta
---
drivers/staging/rtl8712/rtl8712_xmit.c | 6 ++
drivers/staging/rtl8712/rtl8712_xmit.h | 4 ++--
2 files changed, 4
Change return type of r8712_construct_txaggr_cmd_desc from u8 to void
(and remove its return statement) as it always returns _SUCCESS and its
return value is never stored, checked or otherwise used.
Signed-off-by: Nishka Dasgupta
---
drivers/staging/rtl8712/rtl8712_xmit.c | 4 +---
1 file
Change the return values in _r8712_init_xmit_priv from _SUCCESS/_FAIL to
0/-ENOMEM respectively. Change return type from sint to int.
Signed-off-by: Nishka Dasgupta
---
drivers/staging/rtl8712/rtl871x_xmit.c | 14 +++---
drivers/staging/rtl8712/rtl871x_xmit.h | 4 ++--
2 files changed,
Change return values of r8712_update_attrib from _SUCCESS and _FAIL to 0
and -ENOMEM or -EINVAL respectively. Modify call site to check for the
new failure conditions. Also modify the return type from sint to int.
Signed-off-by: Nishka Dasgupta
---
drivers/staging/rtl8712/rtl871x_xmit.c | 16
Change return values of make_wlanhdr from _SUCCESS/_FAIL to 0/-EINVAL.
Modify call site to check for non-zero return values instead of _FAIL.
Change return type from sint to int.
Signed-off-by: Nishka Dasgupta
---
drivers/staging/rtl8712/rtl871x_xmit.c | 10 +-
1 file changed, 5
Change return type of r8712_dump_aggr_xframe from u8 to void as it
always returns _SUCCESS and its return value is never used.
Signed-off-by: Nishka Dasgupta
---
drivers/staging/rtl8712/rtl8712_xmit.c | 6 ++
drivers/staging/rtl8712/rtl8712_xmit.h | 4 ++--
2 files changed, 4 insertions(+),
Change return type of r8712_construct_txaggr_cmd_hdr from u8 to void as
it always returns _SUCCESS and its return value is never used.
Signed-off-by: Nishka Dasgupta
---
drivers/staging/rtl8712/rtl8712_xmit.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git
Change return type of r8712_free_xmitbuf from int to void (and remove
its return values) as its return value is never used.
Signed-off-by: Nishka Dasgupta
---
drivers/staging/rtl8712/rtl871x_xmit.c | 5 ++---
drivers/staging/rtl8712/rtl871x_xmit.h | 4 ++--
2 files changed, 4 insertions(+), 5
Change return type of r8712_xmit_direct from int to void as its return
value is never used. Remove return statement accordingly.
Signed-off-by: Nishka Dasgupta
---
drivers/staging/rtl8712/rtl8712_xmit.c | 3 +--
drivers/staging/rtl8712/rtl871x_xmit.h | 2 +-
2 files changed, 2 insertions(+), 3
On 8/7/19 10:42 PM, Michael Ellerman wrote:
> Hi John,
>
> john.hubb...@gmail.com writes:
>> diff --git a/arch/powerpc/mm/book3s64/iommu_api.c
>> b/arch/powerpc/mm/book3s64/iommu_api.c
>> index b056cae3388b..e126193ba295 100644
>> --- a/arch/powerpc/mm/book3s64/iommu_api.c
>> +++
Length of a binderfs device name cannot exceed BINDERFS_MAX_NAME.
This patch adds a check in binderfs_init() to ensure the same
for the default binder devices that will be created in every
binderfs instance.
Co-developed-by: Christian Brauner
Signed-off-by: Christian Brauner
Signed-off-by:
On Thu, 2019-08-08 at 18:40 +0200, Greg KH wrote:
> On Thu, Aug 08, 2019 at 06:39:05PM +0200, Greg KH wrote:
> > On Fri, Aug 02, 2019 at 03:05:05PM -0700, Joe Perches wrote:
> > > On Fri, 2019-08-02 at 14:55 -0700, Stephen Hemminger wrote:
> > > > On Fri, 2 Aug 2019 19:56:02 +
> > > > Jose
> From: Bjorn Helgaas
> Sent: Thursday, August 8, 2019 12:19 PM
> To: Dexuan Cui
>
> On Thu, Aug 08, 2019 at 06:46:51PM +, Dexuan Cui wrote:
> >
> > In pci_legacy_suspend_late(), the device state is moved to PCI_UNKNOWN.
> > In pci_pm_thaw_noirq(), the state is supposed to be moved back to
On Thu, Aug 08, 2019 at 06:46:51PM +, Dexuan Cui wrote:
>
> In pci_legacy_suspend_late(), the device state is moved to PCI_UNKNOWN.
> In pci_pm_thaw_noirq(), the state is supposed to be moved back to PCI_D0,
> but the current code misses the pci_legacy_resume_early() path, so the
> state
From: Adham Abozaeid
Send abort request to WILC from wilc_wlan_stop instead of resetting the
CPU.
The abort request was being sent from wilc_wlan_cleanup after the CPU
was reset which wasn't the correct order. The abort request handler
in the chip will take care of resetting the CPU.
In pci_legacy_suspend_late(), the device state is moved to PCI_UNKNOWN.
In pci_pm_thaw_noirq(), the state is supposed to be moved back to PCI_D0,
but the current code misses the pci_legacy_resume_early() path, so the
state remains in PCI_UNKNOWN in that path, and during hiberantion this
causes
On 8/8/19 9:25 AM, Weiny, Ira wrote:
>>
>> On 8/7/19 7:36 PM, Ira Weiny wrote:
>>> On Wed, Aug 07, 2019 at 10:46:49AM +0200, Michal Hocko wrote:
On Wed 07-08-19 10:37:26, Jan Kara wrote:
> On Fri 02-08-19 12:14:09, John Hubbard wrote:
>> On 8/2/19 7:52 AM, Jan Kara wrote:
>>> On
On 8/7/19 4:03 AM, Dan Carpenter wrote:
> External E-Mail
>
>
> On Tue, Aug 06, 2019 at 07:32:08PM +, adham.aboza...@microchip.com wrote:
>> Hi Dan
>>
>> On 8/6/19 5:46 AM, Dan Carpenter wrote:
>>> External E-Mail
>>>
>>>
>>> On Thu, Jul 25, 2019 at 09:31:34PM +,
Hi Dan
On 8/7/19 4:03 AM, Dan Carpenter wrote:
> External E-Mail
>
>
> On Tue, Aug 06, 2019 at 07:32:08PM +, adham.aboza...@microchip.com wrote:
>> Hi Dan
>>
>> On 8/6/19 5:46 AM, Dan Carpenter wrote:
>>> External E-Mail
>>>
>>>
>>> On Thu, Jul 25, 2019 at 09:31:34PM +,
On Thu, Aug 08, 2019 at 06:39:05PM +0200, Greg KH wrote:
> On Fri, Aug 02, 2019 at 03:05:05PM -0700, Joe Perches wrote:
> > On Fri, 2019-08-02 at 14:55 -0700, Stephen Hemminger wrote:
> > > On Fri, 2 Aug 2019 19:56:02 +
> > > Jose Carlos Cazarin Filho wrote:
> > >
> > > > Fix checkpath
On Fri, Aug 02, 2019 at 03:05:05PM -0700, Joe Perches wrote:
> On Fri, 2019-08-02 at 14:55 -0700, Stephen Hemminger wrote:
> > On Fri, 2 Aug 2019 19:56:02 +
> > Jose Carlos Cazarin Filho wrote:
> >
> > > Fix checkpath error:
> > > CHECK: spaces preferred around that '*' (ctx:WxV)
> > >
>
> On 8/7/19 7:36 PM, Ira Weiny wrote:
> > On Wed, Aug 07, 2019 at 10:46:49AM +0200, Michal Hocko wrote:
> >> On Wed 07-08-19 10:37:26, Jan Kara wrote:
> >>> On Fri 02-08-19 12:14:09, John Hubbard wrote:
> On 8/2/19 7:52 AM, Jan Kara wrote:
> > On Fri 02-08-19 07:24:43, Matthew Wilcox
On Thu, 2019-08-08 at 13:23 +0200, Greg Kroah-Hartman wrote:
> On Thu, Aug 08, 2019 at 04:15:44AM -0700, Joe Perches wrote:
> > On Thu, 2019-08-08 at 11:41 +0200, Greg Kroah-Hartman wrote:
> > > On Thu, Aug 08, 2019 at 11:25:09AM +0200, Greg Kroah-Hartman wrote:
> > > > Joe rightly points out that
Hi Gabriel,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on staging/staging-testing]
[cannot apply to v5.3-rc3 next-20190808]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day
Looks good to me.
Reviewed-by: Dan Carpenter
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Thu, Aug 08, 2019 at 12:10:09PM +0530, Nishka Dasgupta wrote:
> - if (_r8712_init_sta_priv(>stapriv))
> - return _FAIL;
> + ret = _r8712_init_sta_priv(>stapriv);
> + if (ret)
> + return ret;
> padapter->stapriv.padapter = padapter;
>
On Thu, 2019-08-08 at 11:41 +0200, Greg Kroah-Hartman wrote:
> On Thu, Aug 08, 2019 at 11:25:09AM +0200, Greg Kroah-Hartman wrote:
> > Joe rightly points out that we should be using the "Obsolete" status for
> > these two subsystems.
>
> Even with that change, I don't see get_maintainers.pl tell
On Thu, Aug 08, 2019 at 04:15:44AM -0700, Joe Perches wrote:
> On Thu, 2019-08-08 at 11:41 +0200, Greg Kroah-Hartman wrote:
> > On Thu, Aug 08, 2019 at 11:25:09AM +0200, Greg Kroah-Hartman wrote:
> > > Joe rightly points out that we should be using the "Obsolete" status for
> > > these two
Hello Ajay Singh,
The patch 9bc061e88054: "staging: wilc1000: added support to
dynamically add/remove interfaces" from Jun 26, 2019, leads to the
following static checker warning:
drivers/staging/wilc1000/wilc_wlan.c:497 wilc_wlan_handle_txq()
warn: missing error code here?
On Thu, Aug 08, 2019 at 11:25:09AM +0200, Greg Kroah-Hartman wrote:
> Joe rightly points out that we should be using the "Obsolete" status for
> these two subsystems.
Even with that change, I don't see get_maintainers.pl tell me I
shouldn't be sending a patch in for this area:
$ cat x.patch
Joe rightly points out that we should be using the "Obsolete" status for
these two subsystems.
Also I got the path name wrong for the wusbcore tree.
Reported-by: Joe Perches
Fixes: 71ed79b0e4be ("USB: Move wusbcore and UWB to staging as it is obsolete")
Signed-off-by: Greg Kroah-Hartman
diff
Change return values of r8712_xmit_classifier from _SUCCESS and _FAIL to
0 and -EINVAL respectively.
Modify call site to check for non-zero return values instead of _FAIL.
Change return type from sint to int.
Signed-off-by: Nishka Dasgupta
---
drivers/staging/rtl8712/rtl8712_xmit.c | 2 +-
Change return type of init_default_value from u8 to void as it always
returns _SUCCESS. Remove now-unnecessary return statement.
Modify call site to simply call the function.
Signed-off-by: Nishka Dasgupta
---
drivers/staging/rtl8712/os_intfs.c | 6 ++
1 file changed, 2 insertions(+), 4
Change return type of amsdu_to_msdu from int to void as it always
returns _SUCCESS. Remove return statement as well.
As this return value was never anything other than _SUCCESS, remove the
if-branch that depends on the return value not being _SUCCESS.
Remove local variable that was only used in
Change return values of recv_indicatepkt_reorder from _SUCCESS/_FAIL to
0/-ENOMEM and -EINVAL.
Within recv_indicatepkt_reorder, modify comparison to true and use the
respective value directly.
Modify call site of recv_indicatepkt_reorder to check for the new return
values.
Signed-off-by: Nishka
Remove while loop as it only runs while the function check_cmd_fifo
returns _FAIL, whereas check_cmd_fifo always returns _SUCCESS (and hence
this loop will never run).
Remove now unused function check_cmd_fifo.
Signed-off-by: Nishka Dasgupta
---
drivers/staging/rtl8712/rtl8712_cmd.c | 12
Change return type of r8712_free_drv_sw from u8 to void and remove its
return statement as it always returns the same value (_SUCCESS) and even
this value is never stored, checked or otherwise used.
Signed-off-by: Nishka Dasgupta
---
drivers/staging/rtl8712/os_intfs.c | 3 +--
Change return values of r8712_wlanhdr_to_ethhdr from _SUCCESS/_FAIL to
0/-ENOMEM. Modify the function containing a call site of
r8712_wlanhdr_to_ethhdr so that it compares the return value to
0/-ENOMEM instead of _SUCCESS/_FAIL.
Change the return type of r8712_wlanhdr_to_ethhdr from sint to int to
Change return type of recvbuf2recvframe from int to void as its return
value is never used. Modify or remove return statements accordingly.
Signed-off-by: Nishka Dasgupta
---
drivers/staging/rtl8712/rtl8712_recv.c | 12 +---
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git
Change return type of r8712_recv_entry from s32 to void as its return
value is never used. Modify or remove return statements accordingly.
Signed-off-by: Nishka Dasgupta
---
drivers/staging/rtl8712/recv_osdep.h | 2 +-
drivers/staging/rtl8712/rtl871x_recv.c | 5 ++---
2 files changed, 3
Change return values of init_drv_sw from _SUCCESS and _FAIL to 0 and
-ENOMEM. Change return type from u8 to int to allow this.
Add a return variable to streamline return of error codes of called
functions.
Modify call site to check for non-zero return value instead of _FAIL.
Signed-off-by: Nishka
41 matches
Mail list logo
