Re: [PATCH 5/7] media: use the BIT() macro

2019-08-22 Thread Laurent Pinchart
Hi Mauro, Thank you for the patch. On Thu, Aug 22, 2019 at 04:39:32PM -0300, Mauro Carvalho Chehab wrote: > As warned by cppcheck: > > [drivers/media/dvb-frontends/cx24123.c:434]: (error) Shifting signed > 32-bit value by 31 bits is undefined behaviour >

rtl8192u - meaning of TO_DO_LIST?

2019-08-22 Thread stephen
Hi all, Similar to Colin's question yesterday about the rtl8192u driver, is anybody familiar with the TO_DO_LIST define? As I looked through checkpatch warnings I saw a particular concerning pattern in drivers/staging/rtl8192u/r8192U.h:2183: #ifdef TO_DO_LIST if (Adapter->bInHctTest)

COMPENSATION PAYMENT OF $4,800,000 MILLION DOLLAR

2019-08-22 Thread Bandile Macartney
COMPENSATION PAYMENT OF $4,800,000 MILLION DOLLAR Attention please, This is to bring to your kind attention that the World Bank in affiliation with the (IMF) has sanctioned some African countries to compensate the scam victims, including people that had an unfinished transaction or

[PATCH v2] erofs: move erofs out of staging

2019-08-22 Thread Gao Xiang
EROFS filesystem has been merged into linux-staging for a year. EROFS is designed to be a better solution of saving extra storage space with guaranteed end-to-end performance for read-only files with the help of reduced metadata, fixed-sized output compression and decompression inplace

[PATCH 3/8] media: docs-rst: Document m2m stateless video decoder interface

2019-08-22 Thread Jernej Skrabec
From: Alexandre Courbot Documents the protocol that user-space should follow when communicating with stateless video decoders. The stateless video decoding API makes use of the new request and tags APIs. While it has been implemented with the Cedrus driver so far, it should probably still be

[PATCH 6/8] media: cedrus: h264: Support multiple slices per frame

2019-08-22 Thread Jernej Skrabec
With recent changes, support for decoding multi-slice frames can be easily added now. Signal VPU if current slice is first in frame or not and add information about first macroblock coordinates. Signed-off-by: Jernej Skrabec --- drivers/staging/media/sunxi/cedrus/cedrus_h264.c | 11 ++-

[PATCH 7/8] media: cedrus: Add support for holding capture buffer

2019-08-22 Thread Jernej Skrabec
When frame contains multiple slices and driver works in slice mode, it's more efficient to hold capture buffer in queue until all slices of a same frame are decoded. Add support for that to Cedrus driver by exposing and implementing V4L2_BUF_CAP_SUPPORTS_M2M_HOLD_CAPTURE_BUF capability.

[PATCH 1/8] vb2: add V4L2_BUF_FLAG_M2M_HOLD_CAPTURE_BUF

2019-08-22 Thread Jernej Skrabec
From: Hans Verkuil This patch adds support for the V4L2_BUF_FLAG_M2M_HOLD_CAPTURE_BUF flag. It also adds a new V4L2_BUF_CAP_SUPPORTS_M2M_HOLD_CAPTURE_BUF capability and a v4l2_m2m_release_capture_buf() helper function. Drivers should set vb2_queue->subsystem_flags to

[PATCH 8/8] media: cedrus: Add support for V4L2_DEC_CMD_FLUSH

2019-08-22 Thread Jernej Skrabec
This command is useful for explicitly flushing last decoded frame. Signed-off-by: Jernej Skrabec --- .../staging/media/sunxi/cedrus/cedrus_video.c | 34 +++ 1 file changed, 34 insertions(+) diff --git a/drivers/staging/media/sunxi/cedrus/cedrus_video.c

[PATCH 2/8] videodev2.h: add V4L2_DEC_CMD_FLUSH

2019-08-22 Thread Jernej Skrabec
From: Hans Verkuil Add this new V4L2_DEC_CMD_FLUSH decoder command and document it. Signed-off-by: Hans Verkuil Signed-off-by: Jernej Skrabec --- Documentation/media/uapi/v4l/vidioc-decoder-cmd.rst | 11 ++- Documentation/media/videodev2.h.rst.exceptions | 1 +

[PATCH 4/8] media: docs-rst: Document memory-to-memory video encoder interface

2019-08-22 Thread Jernej Skrabec
From: Tomasz Figa Due to complexity of the video encoding process, the V4L2 drivers of stateful encoder hardware require specific sequences of V4L2 API calls to be followed. These include capability enumeration, initialization, encoding, encode parameters change, drain and reset. Specifics of

[PATCH 0/8] media: cedrus: h264: Support multi-slice frames

2019-08-22 Thread Jernej Skrabec
This series is continuation of work from https://patchwork.linuxtv.org/cover/58186/ It picks up unmerged patches (9-12) from aforementioned series and adds support for decoding multi-slice H264 frames along with support for V4L2_DEC_CMD_FLUSH and V4L2_BUF_FLAG_M2M_HOLD_CAPTURE_BUF in Cedrus

[PATCH 5/8] media: cedrus: Detect first slice of a frame

2019-08-22 Thread Jernej Skrabec
When codec supports multiple slices in one frame, VPU has to know when first slice of each frame is being processed, presumably to correctly clear/set data in auxiliary buffers. Add first_slice field to cedrus_run structure and set it according to timestamps of capture and output buffers. If

[PATCH] staging: rtl8192u: Add space around binary operators

2019-08-22 Thread Sumera Priyadarsini
This patch fixes the file r8180_93cx6.c to avoid the checkpatch.pl warnings: CHECK: spaces preferred around that '<<' (ctx:VxV) CHECK: spaces preferred around that '-' (ctx:VxV) Signed-off-by: Sumera Priyadarsini --- drivers/staging/rtl8192u/r8180_93cx6.c | 6 +++--- 1 file

[PATCH] staging: rtl8192u: Fix indentation

2019-08-22 Thread Stephen Brennan
Checkpatch reports WARNING:SUSPECT_CODE_INDENT in several places. Fix this by aligning code properly with tabs. Signed-off-by: Stephen Brennan --- .../rtl8192u/ieee80211/ieee80211_crypt_ccmp.c | 2 +- .../staging/rtl8192u/ieee80211/ieee80211_rx.c | 112 +-

Re: WARNING in rollback_registered_many (2)

2019-08-22 Thread Andrey Konovalov
On Thu, Aug 22, 2019 at 3:07 PM Andrey Konovalov wrote: > > On Wed, Aug 7, 2019 at 4:03 PM Andrey Konovalov wrote: > > > > On Fri, Apr 12, 2019 at 1:32 PM Andrey Konovalov > > wrote: > > > > > > On Fri, Apr 12, 2019 at 1:29 AM syzbot > > > wrote: > > > > > > > > syzbot has found a reproducer

[PATCH] staging: rtl8192u: Remove unnecessary blank lines

2019-08-22 Thread Sumera Priyadarsini
This patch fixes the file r8180_93cx6.c to avoid the checkpatch.pl warning: CHECK: Please don't use multiple blank lines Signed-off-by: Sumera Priyadarsini --- drivers/staging/rtl8192u/r8180_93cx6.c | 5 - 1 file changed, 5 deletions(-) diff --git

Re: WARNING in r871xu_dev_remove

2019-08-22 Thread syzbot
Hello, syzbot has tested the proposed patch but the reproducer still triggered crash: KASAN: use-after-free Read in device_release_driver_internal == BUG: KASAN: use-after-free in __mutex_lock_common kernel/locking/mutex.c:912

Re: WARNING in r871xu_dev_remove

2019-08-22 Thread Oliver Neukum
Am Donnerstag, den 22.08.2019, 07:28 -0700 schrieb syzbot: > Hello, > > syzbot found the following crash on: > > HEAD commit:eea39f24 usb-fuzzer: main usb gadget fuzzer driver > git tree: https://github.com/google/kasan.git usb-fuzzer > console output:

WARNING in r871xu_dev_remove

2019-08-22 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:eea39f24 usb-fuzzer: main usb gadget fuzzer driver git tree: https://github.com/google/kasan.git usb-fuzzer console output: https://syzkaller.appspot.com/x/log.txt?x=163ae01260 kernel config:

Re: WARNING in rollback_registered_many (2)

2019-08-22 Thread Oliver Neukum
Am Mittwoch, den 07.08.2019, 16:03 +0200 schrieb Andrey Konovalov: I may offer a preliminary analysis. Regards Oliver > On Fri, Apr 12, 2019 at 1:32 PM Andrey Konovalov > wrote: > > > > On Fri, Apr 12, 2019 at 1:29 AM syzbot > > wrote: > > > > > > syzbot has found a

Re: [PATCH v8 00/24] erofs: promote erofs from staging v8

2019-08-22 Thread Gao Xiang
Hi Greg, On Thu, Aug 15, 2019 at 11:06:03AM +0200, Greg Kroah-Hartman wrote: > On Thu, Aug 15, 2019 at 12:41:31PM +0800, Gao Xiang wrote: > > [I strip the previous cover letter, the old one can be found in v6: > > https://lore.kernel.org/r/20190802125347.166018-1-gaoxian...@huawei.com/] > > > >

Re: [PATCH] Staging: isdn/gigaset : Fix bare unsigned warnings and trailing lines errors

2019-08-22 Thread Dan Carpenter
Hi Martin, These drivers are ancient and going to be deleted soon. We're not accepting cleanups for them at this point. On Wed, Aug 21, 2019 at 03:27:39PM +, Martin Tomes wrote: > There are many bare use of unsigned warnings and trailing statements should > be on next line errors from

[PATCH] Staging: isdn/gigaset : Fix bare unsigned warnings and trailing lines errors

2019-08-22 Thread Martin Tomes
There are many bare use of unsigned warnings and trailing statements should be on next line errors from checkpatch.pl script. Change the code by adding 'unsigned int'. Move 'break' statement of 'switch' command to next line. Signed-off-by: Martin Tomes ---

Re: [PATCH] staging: rtl8192u: remove redundant assignment to pointer crypt

2019-08-22 Thread Dan Carpenter
On Thu, Aug 22, 2019 at 09:46:09AM +0100, Colin King wrote: > From: Colin Ian King > > The pointer crypt is being set with a value that is never read, > the assignment is redundant and hence can be removed. > > Thanks to Dan Carpenter for sanity checking that this was indeed > redundant. > >

[PATCH] staging: rtl8192u: remove redundant assignment to pointer crypt

2019-08-22 Thread Colin King
From: Colin Ian King The pointer crypt is being set with a value that is never read, the assignment is redundant and hence can be removed. Thanks to Dan Carpenter for sanity checking that this was indeed redundant. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King ---

Re: Added Realtek rtl8192u driver to staging - static analysis report.

2019-08-22 Thread Dan Carpenter
On Wed, Aug 21, 2019 at 07:18:39PM +0100, Colin Ian King wrote: > Hi, > > Static analysis of linux-next picked up an issue with the following commit: > > commit 8fc8598e61f6f384f3eaf1d9b09500c12af47b37 > Author: Jerry Chuang > Date: Tue Nov 3 07:17:11 2009 -0200 > > Staging: Added