**SPAM** Please treat as a matter of very urgent importance.

2019-10-25 Thread William Johnson 
Please be informed that all the processes for the smooth transfer into your 
account has been completed hence
 the payment is ready please confirm the receipt of this message immediately 
for more details.

Regards,

William Johnson.
--

The information contained in this message and its content is confidential and 
is strictly for the intended recipient(s).
If you have received this message in error, you are prohibited from 
reading,copying, distributing and using the 
information.  If you have received this message in error, please contact the 
sender immediately by return mail 
and destroy the original message.I use virus scanning software but exclude all 
liability for viruses or similar 
in any attachment.

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [Outreachy kernel] [RESEND PATCH] staging: gasket: Fix lines ending with a '('

2019-10-25 Thread Julia Lawall 



On Fri, 25 Oct 2019, Cristiane Naves wrote:

> Fix lines ending with a '('. Issue found by checkpatch.

You sent another patch on this file (the one I acked) and they are notin a
series, so Greg won't know how to apply them.  Please collect the whole
thing again, and either put both changes in the same patch, or send a
series with the different changes on this file.  You could put v2, so that
Greg knows to ignore your other changes on the file.

julia

>
> Signed-off-by: Cristiane Naves 
> ---
>  drivers/staging/gasket/gasket_ioctl.c | 12 ++--
>  1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/gasket/gasket_ioctl.c 
> b/drivers/staging/gasket/gasket_ioctl.c
> index d1b3e9a..e3047d3 100644
> --- a/drivers/staging/gasket/gasket_ioctl.c
> +++ b/drivers/staging/gasket/gasket_ioctl.c
> @@ -54,9 +54,9 @@ static int gasket_read_page_table_size(struct gasket_dev 
> *gasket_dev,
>   ibuf.size = gasket_page_table_num_entries(
>   gasket_dev->page_table[ibuf.page_table_index]);
>
> - trace_gasket_ioctl_page_table_data(
> - ibuf.page_table_index, ibuf.size, ibuf.host_address,
> - ibuf.device_address);
> + trace_gasket_ioctl_page_table_data(ibuf.page_table_index, ibuf.size,
> +ibuf.host_address,
> +ibuf.device_address);
>
>   if (copy_to_user(argp, &ibuf, sizeof(ibuf)))
>   return -EFAULT;
> @@ -101,9 +101,9 @@ static int gasket_partition_page_table(struct gasket_dev 
> *gasket_dev,
>   if (copy_from_user(&ibuf, argp, sizeof(struct gasket_page_table_ioctl)))
>   return -EFAULT;
>
> - trace_gasket_ioctl_page_table_data(
> - ibuf.page_table_index, ibuf.size, ibuf.host_address,
> - ibuf.device_address);
> + trace_gasket_ioctl_page_table_data(ibuf.page_table_index, ibuf.size,
> +ibuf.host_address,
> +ibuf.device_address);
>
>   if (ibuf.page_table_index >= gasket_dev->num_page_tables)
>   return -EFAULT;
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups 
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to outreachy-kernel+unsubscr...@googlegroups.com.
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/outreachy-kernel/20191025232935.GA813%40cristiane-Inspiron-5420.
>
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [Outreachy kernel] [RESEND PATCH] staging: gasket: Fix line ending with a '('

2019-10-25 Thread Julia Lawall 



On Fri, 25 Oct 2019, Cristiane Naves wrote:

> Fix line ending with a '('
>
> Signed-off-by: Cristiane Naves 

Acked-by: Julia Lawall 


> ---
>  drivers/staging/gasket/gasket_ioctl.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/gasket/gasket_ioctl.c 
> b/drivers/staging/gasket/gasket_ioctl.c
> index 240f9bb..d1b3e9a 100644
> --- a/drivers/staging/gasket/gasket_ioctl.c
> +++ b/drivers/staging/gasket/gasket_ioctl.c
> @@ -34,8 +34,8 @@ static int gasket_set_event_fd(struct gasket_dev 
> *gasket_dev,
>
>   trace_gasket_ioctl_eventfd_data(die.interrupt, die.event_fd);
>
> - return gasket_interrupt_set_eventfd(
> - gasket_dev->interrupt_data, die.interrupt, die.event_fd);
> + return gasket_interrupt_set_eventfd(gasket_dev->interrupt_data,
> + die.interrupt, die.event_fd);
>  }
>
>  /* Read the size of the page table. */
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups 
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to outreachy-kernel+unsubscr...@googlegroups.com.
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/outreachy-kernel/20191025233909.GA1599%40cristiane-Inspiron-5420.
>
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

**SPAM** Please treat as a matter of very urgent importance.

2019-10-25 Thread William Johnson 
Please be informed that all the processes for the smooth transfer into your 
account has been completed hence
 the payment is ready please confirm the receipt of this message immediately 
for more details.

Regards,

William Johnson.
--

The information contained in this message and its content is confidential and 
is strictly for the intended recipient(s).
If you have received this message in error, you are prohibited from 
reading,copying, distributing and using the 
information.  If you have received this message in error, please contact the 
sender immediately by return mail 
and destroy the original message.I use virus scanning software but exclude all 
liability for viruses or similar 
in any attachment.

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

**SPAM** Please treat as a matter of very urgent importance.

2019-10-25 Thread William Johnson 
Please be informed that all the processes for the smooth transfer into your 
account has been completed hence
 the payment is ready please confirm the receipt of this message immediately 
for more details.

Regards,

William Johnson.
--

The information contained in this message and its content is confidential and 
is strictly for the intended recipient(s).
If you have received this message in error, you are prohibited from 
reading,copying, distributing and using the 
information.  If you have received this message in error, please contact the 
sender immediately by return mail 
and destroy the original message.I use virus scanning software but exclude all 
liability for viruses or similar 
in any attachment.

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [RESEND PATCH 1/2] staging: rtl8712: Fix Alignment of open parenthesis

2019-10-25 Thread Joe Perches 
On Fri, 2019-10-25 at 22:09 -0300, Cristiane Naves wrote:
> Fix alignment should match open parenthesis.Issue found by checkpatch.

Beyond doing style cleanups, please always try
to make the code more readable.

> diff --git a/drivers/staging/rtl8712/rtl8712_recv.c 
> b/drivers/staging/rtl8712/rtl8712_recv.c
[]
> @@ -61,13 +61,13 @@ void r8712_init_recv_priv(struct recv_priv *precvpriv,
>   precvbuf->ref_cnt = 0;
>   precvbuf->adapter = padapter;
>   list_add_tail(&precvbuf->list,
> -  &(precvpriv->free_recv_buf_queue.queue));
> +   &(precvpriv->free_recv_buf_queue.queue));

Please remove the unnecessary parentheses too

>   precvbuf++;
>   }
>   precvpriv->free_recv_buf_queue_cnt = NR_RECVBUFF;
>   tasklet_init(&precvpriv->recv_tasklet,
> -  (void(*)(unsigned long))recv_tasklet,
> -  (unsigned long)padapter);
> +  (void(*)(unsigned long))recv_tasklet,
> +  (unsigned long)padapter);

It's probably better to change the recv_tasklet function
declaration to
use the more common style of

static void recv_tasklet(unsigned long priv)

and do the cast in the recv_tasklet function.


___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[RESEND PATCH 2/2] staging: rtl8712: Remove lines before a close brace

2019-10-25 Thread Cristiane Naves 
Fix Blank lines aren't necessary before a close brace '}'. Issue found
by checkpatch.

Signed-off-by: Cristiane Naves 
---
 drivers/staging/rtl8712/rtl8712_recv.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/staging/rtl8712/rtl8712_recv.c 
b/drivers/staging/rtl8712/rtl8712_recv.c
index 12a3c64..09b461c 100644
--- a/drivers/staging/rtl8712/rtl8712_recv.c
+++ b/drivers/staging/rtl8712/rtl8712_recv.c
@@ -289,7 +289,6 @@ union recv_frame *r8712_recvframe_chk_defrag(struct 
_adapter *padapter,
r8712_free_recvframe(precv_frame, pfree_recv_queue);
prtnframe = NULL;
}
-
}
if ((ismfrag == 0) && (fragnum != 0)) {
/* the last fragment frame
@@ -438,7 +437,6 @@ void r8712_rxcmd_event_hdl(struct _adapter *padapter, void 
*prxcmdbuf)
r8712_event_handle(padapter, (__le32 *)poffset);
poffset += (cmd_len + 8);/*8 bytes alignment*/
} while (le32_to_cpu(voffset) & BIT(31));
-
 }
 
 static int check_indicate_seq(struct recv_reorder_ctrl *preorder_ctrl,
-- 
2.7.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[RESEND PATCH 1/2] staging: rtl8712: Fix Alignment of open parenthesis

2019-10-25 Thread Cristiane Naves 
Fix alignment should match open parenthesis.Issue found by checkpatch.

Signed-off-by: Cristiane Naves 
---
 drivers/staging/rtl8712/rtl8712_recv.c | 30 +++---
 1 file changed, 15 insertions(+), 15 deletions(-)

diff --git a/drivers/staging/rtl8712/rtl8712_recv.c 
b/drivers/staging/rtl8712/rtl8712_recv.c
index af12c16..12a3c64 100644
--- a/drivers/staging/rtl8712/rtl8712_recv.c
+++ b/drivers/staging/rtl8712/rtl8712_recv.c
@@ -61,13 +61,13 @@ void r8712_init_recv_priv(struct recv_priv *precvpriv,
precvbuf->ref_cnt = 0;
precvbuf->adapter = padapter;
list_add_tail(&precvbuf->list,
-&(precvpriv->free_recv_buf_queue.queue));
+ &(precvpriv->free_recv_buf_queue.queue));
precvbuf++;
}
precvpriv->free_recv_buf_queue_cnt = NR_RECVBUFF;
tasklet_init(&precvpriv->recv_tasklet,
-(void(*)(unsigned long))recv_tasklet,
-(unsigned long)padapter);
+(void(*)(unsigned long))recv_tasklet,
+(unsigned long)padapter);
skb_queue_head_init(&precvpriv->rx_skb_queue);
 
skb_queue_head_init(&precvpriv->free_recv_skb_queue);
@@ -140,7 +140,7 @@ void r8712_free_recvframe(union recv_frame *precvframe,
 }
 
 static void update_recvframe_attrib_from_recvstat(struct rx_pkt_attrib 
*pattrib,
-  struct recv_stat *prxstat)
+ struct recv_stat *prxstat)
 {
u16 drvinfo_sz;
 
@@ -177,7 +177,7 @@ static void update_recvframe_attrib_from_recvstat(struct 
rx_pkt_attrib *pattrib,
 
 /*perform defrag*/
 static union recv_frame *recvframe_defrag(struct _adapter *adapter,
-  struct  __queue *defrag_q)
+ struct  __queue *defrag_q)
 {
struct list_head *plist, *phead;
u8 wlanhdr_offset;
@@ -379,7 +379,7 @@ static void amsdu_to_msdu(struct _adapter *padapter, union 
recv_frame *prframe)
/* convert hdr + possible LLC headers into Ethernet header */
eth_type = (sub_skb->data[6] << 8) | sub_skb->data[7];
if (sub_skb->len >= 8 &&
-  ((!memcmp(sub_skb->data, rfc1042_header, SNAP_SIZE) &&
+   ((!memcmp(sub_skb->data, rfc1042_header, SNAP_SIZE) &&
   eth_type != ETH_P_AARP && eth_type != ETH_P_IPX) ||
   !memcmp(sub_skb->data, bridge_tunnel_header, SNAP_SIZE))) {
/* remove RFC1042 or Bridge-Tunnel encapsulation and
@@ -387,18 +387,18 @@ static void amsdu_to_msdu(struct _adapter *padapter, 
union recv_frame *prframe)
 */
skb_pull(sub_skb, SNAP_SIZE);
memcpy(skb_push(sub_skb, ETH_ALEN), pattrib->src,
-   ETH_ALEN);
+  ETH_ALEN);
memcpy(skb_push(sub_skb, ETH_ALEN), pattrib->dst,
-   ETH_ALEN);
+  ETH_ALEN);
} else {
__be16 len;
/* Leave Ethernet header part of hdr and full payload */
len = htons(sub_skb->len);
memcpy(skb_push(sub_skb, 2), &len, 2);
memcpy(skb_push(sub_skb, ETH_ALEN), pattrib->src,
-   ETH_ALEN);
+  ETH_ALEN);
memcpy(skb_push(sub_skb, ETH_ALEN), pattrib->dst,
-   ETH_ALEN);
+  ETH_ALEN);
}
/* Indicate the packets to upper layer */
if (sub_skb) {
@@ -472,7 +472,7 @@ static int check_indicate_seq(struct recv_reorder_ctrl 
*preorder_ctrl,
 }
 
 static int enqueue_reorder_recvframe(struct recv_reorder_ctrl *preorder_ctrl,
- union recv_frame *prframe)
+union recv_frame *prframe)
 {
struct list_head *phead, *plist;
union recv_frame *pnextrframe;
@@ -499,8 +499,8 @@ static int enqueue_reorder_recvframe(struct 
recv_reorder_ctrl *preorder_ctrl,
 }
 
 int r8712_recv_indicatepkts_in_order(struct _adapter *padapter,
-  struct recv_reorder_ctrl *preorder_ctrl,
-  int bforced)
+struct recv_reorder_ctrl *preorder_ctrl,
+int bforced)
 {
struct list_head *phead, *plist;
union recv_frame *prframe;
@@ -555,7 +555,7 @@ int r8712_recv_indicatepkts_in_order(struct _adapter 
*padapter,
 }
 
 static int recv_indicatepkt_reorder(struct _adapter *padapter,
-union recv_frame *prframe)
+   union recv_frame *prframe)
 {

[RESEND PATCH 0/2] Cleanup in rtl8712

2019-10-25 Thread Cristiane Naves 
Cleanup in rtl8712

Cristiane Naves (2):
  staging: rtl8712: Fix Alignment of open parenthesis
  staging: rtl8712: Remove lines before a close brace

 drivers/staging/rtl8712/rtl8712_recv.c | 32 +++-
 1 file changed, 15 insertions(+), 17 deletions(-)

-- 
2.7.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[RESEND PATCH] staging: gasket: Fix line ending with a '('

2019-10-25 Thread Cristiane Naves 
Fix line ending with a '('

Signed-off-by: Cristiane Naves 
---
 drivers/staging/gasket/gasket_ioctl.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/gasket/gasket_ioctl.c 
b/drivers/staging/gasket/gasket_ioctl.c
index 240f9bb..d1b3e9a 100644
--- a/drivers/staging/gasket/gasket_ioctl.c
+++ b/drivers/staging/gasket/gasket_ioctl.c
@@ -34,8 +34,8 @@ static int gasket_set_event_fd(struct gasket_dev *gasket_dev,
 
trace_gasket_ioctl_eventfd_data(die.interrupt, die.event_fd);
 
-   return gasket_interrupt_set_eventfd(
-   gasket_dev->interrupt_data, die.interrupt, die.event_fd);
+   return gasket_interrupt_set_eventfd(gasket_dev->interrupt_data,
+   die.interrupt, die.event_fd);
 }
 
 /* Read the size of the page table. */
-- 
2.7.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[RESEND PATCH] staging: gasket: Fix lines ending with a '('

2019-10-25 Thread Cristiane Naves 
Fix lines ending with a '('. Issue found by checkpatch.

Signed-off-by: Cristiane Naves 
---
 drivers/staging/gasket/gasket_ioctl.c | 12 ++--
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/gasket/gasket_ioctl.c 
b/drivers/staging/gasket/gasket_ioctl.c
index d1b3e9a..e3047d3 100644
--- a/drivers/staging/gasket/gasket_ioctl.c
+++ b/drivers/staging/gasket/gasket_ioctl.c
@@ -54,9 +54,9 @@ static int gasket_read_page_table_size(struct gasket_dev 
*gasket_dev,
ibuf.size = gasket_page_table_num_entries(
gasket_dev->page_table[ibuf.page_table_index]);
 
-   trace_gasket_ioctl_page_table_data(
-   ibuf.page_table_index, ibuf.size, ibuf.host_address,
-   ibuf.device_address);
+   trace_gasket_ioctl_page_table_data(ibuf.page_table_index, ibuf.size,
+  ibuf.host_address,
+  ibuf.device_address);
 
if (copy_to_user(argp, &ibuf, sizeof(ibuf)))
return -EFAULT;
@@ -101,9 +101,9 @@ static int gasket_partition_page_table(struct gasket_dev 
*gasket_dev,
if (copy_from_user(&ibuf, argp, sizeof(struct gasket_page_table_ioctl)))
return -EFAULT;
 
-   trace_gasket_ioctl_page_table_data(
-   ibuf.page_table_index, ibuf.size, ibuf.host_address,
-   ibuf.device_address);
+   trace_gasket_ioctl_page_table_data(ibuf.page_table_index, ibuf.size,
+  ibuf.host_address,
+  ibuf.device_address);
 
if (ibuf.page_table_index >= gasket_dev->num_page_tables)
return -EFAULT;
-- 
2.7.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 1/3] Staging: qlge: Rename prefix of a function to qlge

2019-10-25 Thread Dan Carpenter 
On Fri, Oct 25, 2019 at 05:28:42PM +0300, Samuil Ivanov wrote:
> Dan you are correct it is a bit of a hodge podge :)
> I think that it is better to have a bigger patches that will rename
> more functions, but I don't this it is good to have all the
> functions renamed in one patch.
> 
> Just in the header file I counted around 55 function definitions,
> and in the source files there are some more.
> So that will make one huge patch.
> 

I don't really have a problem if you rename everything at once.  Or if
you want to rename all of them in a 55 patch patchset that's also fine
with me...

regards,
dan carpenter

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 1/3] Staging: qlge: Rename prefix of a function to qlge

2019-10-25 Thread Samuil Ivanov 
On Fri, Oct 25, 2019 at 01:19:05PM +0300, Dan Carpenter wrote:
> On Fri, Oct 25, 2019 at 12:29:39AM +0300, Samuil Ivanov wrote:
> > diff --git a/drivers/staging/qlge/qlge.h b/drivers/staging/qlge/qlge.h
> > index 6ec7e3ce3863..e9f1363c5bf2 100644
> > --- a/drivers/staging/qlge/qlge.h
> > +++ b/drivers/staging/qlge/qlge.h
> > @@ -2262,7 +2262,7 @@ int ql_write_mpi_reg(struct ql_adapter *qdev, u32 
> > reg, u32 data);
> >  int ql_unpause_mpi_risc(struct ql_adapter *qdev);
> >  int ql_pause_mpi_risc(struct ql_adapter *qdev);
> >  int ql_hard_reset_mpi_risc(struct ql_adapter *qdev);
> > -int ql_soft_reset_mpi_risc(struct ql_adapter *qdev);
> > +int qlge_soft_reset_mpi_risc(struct ql_adapter *qdev);
> 
> The patch series doesn't change all the functions so now it's hodge
> podge.
> 
> >  int ql_dump_risc_ram_area(struct ql_adapter *qdev, void *buf, u32 ram_addr,
> >   int word_count);
> >  int ql_core_dump(struct ql_adapter *qdev, struct ql_mpi_coredump 
> > *mpi_coredump);
> > diff --git a/drivers/staging/qlge/qlge_dbg.c 
> > b/drivers/staging/qlge/qlge_dbg.c
> > index 019b7e6a1b7a..df5344e113ca 100644
> > --- a/drivers/staging/qlge/qlge_dbg.c
> > +++ b/drivers/staging/qlge/qlge_dbg.c
> > @@ -1312,7 +1312,7 @@ void ql_get_dump(struct ql_adapter *qdev, void *buff)
> >  
> > if (!test_bit(QL_FRC_COREDUMP, &qdev->flags)) {
> > if (!ql_core_dump(qdev, buff))
> > -   ql_soft_reset_mpi_risc(qdev);
> > +   qlge_soft_reset_mpi_risc(qdev);
> > else
> > netif_err(qdev, drv, qdev->ndev, "coredump failed!\n");
> > } else {
> > diff --git a/drivers/staging/qlge/qlge_mpi.c 
> > b/drivers/staging/qlge/qlge_mpi.c
> > index 9e4226ab..efe893935929 100644
> > --- a/drivers/staging/qlge/qlge_mpi.c
> > +++ b/drivers/staging/qlge/qlge_mpi.c
> > @@ -88,9 +88,10 @@ int ql_write_mpi_reg(struct ql_adapter *qdev, u32 reg, 
> > u32 data)
> > return status;
> >  }
> >  
> > -int ql_soft_reset_mpi_risc(struct ql_adapter *qdev)
> > +int qlge_soft_reset_mpi_risc(struct ql_adapter *qdev)
> >  {
> > int status;
> > +
> > status = ql_write_mpi_reg(qdev, 0x1010, 1);
> 
> This white space change is unrelated.
> 
> > return status;
> >  }
> 
> regards,
> dan carpenter
> 

Hello Dan and Greg,

Dan you are correct it is a bit of a hodge podge :)
I think that it is better to have a bigger patches that will rename
more functions, but I don't this it is good to have all the
functions renamed in one patch.

Just in the header file I counted around 55 function definitions,
and in the source files there are some more.
So that will make one huge patch.

And I am not sure if the maintainers will be OK with reviewing it.

So my sugestion is to have a bigger patches.
For example, one patch with 10 to 15 subpatches.
And one subpatch will rename one function and
update the occurrences in the driver.

This way with like 5 iterations all the functions will be renamed.

If you have a better solution please tell.

Grt,
Samuil
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 1/3] Staging: qlge: Rename prefix of a function to qlge

2019-10-25 Thread Dan Carpenter 
On Fri, Oct 25, 2019 at 12:29:39AM +0300, Samuil Ivanov wrote:
> diff --git a/drivers/staging/qlge/qlge.h b/drivers/staging/qlge/qlge.h
> index 6ec7e3ce3863..e9f1363c5bf2 100644
> --- a/drivers/staging/qlge/qlge.h
> +++ b/drivers/staging/qlge/qlge.h
> @@ -2262,7 +2262,7 @@ int ql_write_mpi_reg(struct ql_adapter *qdev, u32 reg, 
> u32 data);
>  int ql_unpause_mpi_risc(struct ql_adapter *qdev);
>  int ql_pause_mpi_risc(struct ql_adapter *qdev);
>  int ql_hard_reset_mpi_risc(struct ql_adapter *qdev);
> -int ql_soft_reset_mpi_risc(struct ql_adapter *qdev);
> +int qlge_soft_reset_mpi_risc(struct ql_adapter *qdev);

The patch series doesn't change all the functions so now it's hodge
podge.

>  int ql_dump_risc_ram_area(struct ql_adapter *qdev, void *buf, u32 ram_addr,
> int word_count);
>  int ql_core_dump(struct ql_adapter *qdev, struct ql_mpi_coredump 
> *mpi_coredump);
> diff --git a/drivers/staging/qlge/qlge_dbg.c b/drivers/staging/qlge/qlge_dbg.c
> index 019b7e6a1b7a..df5344e113ca 100644
> --- a/drivers/staging/qlge/qlge_dbg.c
> +++ b/drivers/staging/qlge/qlge_dbg.c
> @@ -1312,7 +1312,7 @@ void ql_get_dump(struct ql_adapter *qdev, void *buff)
>  
>   if (!test_bit(QL_FRC_COREDUMP, &qdev->flags)) {
>   if (!ql_core_dump(qdev, buff))
> - ql_soft_reset_mpi_risc(qdev);
> + qlge_soft_reset_mpi_risc(qdev);
>   else
>   netif_err(qdev, drv, qdev->ndev, "coredump failed!\n");
>   } else {
> diff --git a/drivers/staging/qlge/qlge_mpi.c b/drivers/staging/qlge/qlge_mpi.c
> index 9e4226ab..efe893935929 100644
> --- a/drivers/staging/qlge/qlge_mpi.c
> +++ b/drivers/staging/qlge/qlge_mpi.c
> @@ -88,9 +88,10 @@ int ql_write_mpi_reg(struct ql_adapter *qdev, u32 reg, u32 
> data)
>   return status;
>  }
>  
> -int ql_soft_reset_mpi_risc(struct ql_adapter *qdev)
> +int qlge_soft_reset_mpi_risc(struct ql_adapter *qdev)
>  {
>   int status;
> +
>   status = ql_write_mpi_reg(qdev, 0x1010, 1);

This white space change is unrelated.

>   return status;
>  }

regards,
dan carpenter

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 04/15] staging: exfat: Clean up return codes - FFS_PERMISSIONERR

2019-10-25 Thread Dan Carpenter 
On Thu, Oct 24, 2019 at 12:27:47PM -0400, Valdis Klētnieks wrote:
> On Thu, 24 Oct 2019 09:23:33 -0700, Joe Perches said:
> > On Thu, 2019-10-24 at 11:53 -0400, Valdis Kletnieks wrote:
> 
> > >   if (err) {
> > > - if (err == FFS_PERMISSIONERR)
> > > + if (err == -EPERM)
> > >   err = -EPERM;
> > >   else if (err == FFS_INVALIDPATH)
> > >   err = -EINVAL;
> >
> > These test and assign to same value blocks look kinda silly.
> 
> One patch, one thing.  Those are getting cleaned up in a subsequent patch.:)

I was just giving an impromptu lecture on this last week  The one
thing per patch means we cleanup the fallout that results from the
change.  So if you rename a function then you have re-indent the
parameters etc.  If you remove a cast from (type)(foo + bar) then
remove all the extra parentheses and so on.

(I don't have strong feelings about this patch, but I have just been
trying to explain the one thing rule recently).

regards,
dan carpenter

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 2/5] staging: wlan-ng: shorten lines over 80 characters in hfa384x.h

2019-10-25 Thread Tim Collier 
Shorten several lines reported as over 80 characters by checkpatch.pl.

Signed-off-by: Tim Collier 
---
 drivers/staging/wlan-ng/hfa384x.h | 14 ++
 1 file changed, 10 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/wlan-ng/hfa384x.h 
b/drivers/staging/wlan-ng/hfa384x.h
index 5ff740a8837d..2d3d8b1e2c1b 100644
--- a/drivers/staging/wlan-ng/hfa384x.h
+++ b/drivers/staging/wlan-ng/hfa384x.h
@@ -1337,7 +1337,9 @@ struct hfa384x {
  * interface
  */
 
-   struct hfa384x_caplevel cap_act_sta_mfi; /* sta f/w to modem interface 
*/
+   struct hfa384x_caplevel cap_act_sta_mfi; /*
+ * sta f/w to modem interface
+ */
 
struct hfa384x_caplevel cap_act_ap_cfi; /*
 * ap f/w to controller
@@ -1359,7 +1361,9 @@ struct hfa384x {
 
struct hfa384x_inf_frame *scanresults;
 
-   struct prism2sta_authlist authlist; /* Authenticated station list. 
*/
+   struct prism2sta_authlist authlist; /*
+* Authenticated station list.
+*/
unsigned int accessmode;/* Access mode. */
struct prism2sta_accesslist allow;  /* Allowed station list. */
struct prism2sta_accesslist deny;   /* Denied station list. */
@@ -1375,7 +1379,8 @@ int hfa384x_drvr_disable(struct hfa384x *hw, u16 macport);
 int hfa384x_drvr_enable(struct hfa384x *hw, u16 macport);
 int hfa384x_drvr_flashdl_enable(struct hfa384x *hw);
 int hfa384x_drvr_flashdl_disable(struct hfa384x *hw);
-int hfa384x_drvr_flashdl_write(struct hfa384x *hw, u32 daddr, void *buf, u32 
len);
+int hfa384x_drvr_flashdl_write(struct hfa384x *hw, u32 daddr, void *buf,
+  u32 len);
 int hfa384x_drvr_getconfig(struct hfa384x *hw, u16 rid, void *buf, u16 len);
 int hfa384x_drvr_ramdl_enable(struct hfa384x *hw, u32 exeaddr);
 int hfa384x_drvr_ramdl_disable(struct hfa384x *hw);
@@ -1383,7 +1388,8 @@ int hfa384x_drvr_ramdl_write(struct hfa384x *hw, u32 
daddr, void *buf, u32 len);
 int hfa384x_drvr_readpda(struct hfa384x *hw, void *buf, unsigned int len);
 int hfa384x_drvr_setconfig(struct hfa384x *hw, u16 rid, void *buf, u16 len);
 
-static inline int hfa384x_drvr_getconfig16(struct hfa384x *hw, u16 rid, void 
*val)
+static inline int
+hfa384x_drvr_getconfig16(struct hfa384x *hw, u16 rid, void *val)
 {
int result = 0;
 
-- 
2.21.0

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 5/5] staging: wlan-ng: remove unused field from struct hfa384x_usbctlx

2019-10-25 Thread Tim Collier 
The variant field in struct hfa384x_usbctlx is not referenced anywhere
in the driver, so remove it.

Signed-off-by: Tim Collier 
---
 drivers/staging/wlan-ng/hfa384x.h | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/staging/wlan-ng/hfa384x.h 
b/drivers/staging/wlan-ng/hfa384x.h
index 86fd3fcd8a36..bdd7f414fdbb 100644
--- a/drivers/staging/wlan-ng/hfa384x.h
+++ b/drivers/staging/wlan-ng/hfa384x.h
@@ -1181,8 +1181,6 @@ struct hfa384x_usbctlx {
ctlx_cmdcb_t cmdcb; /* Async command callback */
ctlx_usercb_t usercb;   /* Async user callback, */
void *usercb_data;  /*  at CTLX completion  */
-
-   int variant;/* Identifies cmd variant */
 };
 
 struct hfa384x_usbctlxq {
-- 
2.21.0

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 4/5] staging: wlan-ng: fix compilation for USB debugging

2019-10-25 Thread Tim Collier 
Fix compilation errors (remove references to 2 undefined fields in the
URB struct) when DEBUG_USB is defined for the wlan-ng driver.

Signed-off-by: Tim Collier 
---
 drivers/staging/wlan-ng/hfa384x_usb.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c 
b/drivers/staging/wlan-ng/hfa384x_usb.c
index 28d372a0663a..b71756ab0394 100644
--- a/drivers/staging/wlan-ng/hfa384x_usb.c
+++ b/drivers/staging/wlan-ng/hfa384x_usb.c
@@ -293,13 +293,11 @@ void dbprint_urb(struct urb *urb)
pr_debug("urb->transfer_buffer_length=0x%08x\n",
 urb->transfer_buffer_length);
pr_debug("urb->actual_length=0x%08x\n", urb->actual_length);
-   pr_debug("urb->bandwidth=0x%08x\n", urb->bandwidth);
pr_debug("urb->setup_packet(ctl)=0x%08x\n",
 (unsigned int)urb->setup_packet);
pr_debug("urb->start_frame(iso/irq)=0x%08x\n", urb->start_frame);
pr_debug("urb->interval(irq)=0x%08x\n", urb->interval);
pr_debug("urb->error_count(iso)=0x%08x\n", urb->error_count);
-   pr_debug("urb->timeout=0x%08x\n", urb->timeout);
pr_debug("urb->context=0x%08x\n", (unsigned int)urb->context);
pr_debug("urb->complete=0x%08x\n", (unsigned int)urb->complete);
 }
-- 
2.21.0

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 0/5] staging: wlang-ng: coding style changes/cleanups

2019-10-25 Thread Tim Collier 
Remove unnecessary casts from void* to structure pointer.

Fix compilation with DEBUG_USB macro defined.

Remove unused field from usb ctlx structure.

Formatting changes suggested by checkpatch.

Tim Collier (5):
  staging: wlan-ng: remove unnecessary casts from prism2usb.c
  staging: wlan-ng: shorten lines over 80 characters in hfa384x.h
  staging: wlan-ng: correct parameter alignment in hfa384x.h
  staging: wlan-ng: fix compilation for USB debugging
  staging: wlan-ng: remove unused field from struct hfa384x_usbctlx

 drivers/staging/wlan-ng/hfa384x.h | 18 +++---
 drivers/staging/wlan-ng/hfa384x_usb.c |  2 --
 drivers/staging/wlan-ng/prism2usb.c   |  6 +++---
 3 files changed, 14 insertions(+), 12 deletions(-)

-- 
2.21.0

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 3/5] staging: wlan-ng: correct parameter alignment in hfa384x.h

2019-10-25 Thread Tim Collier 
Realign parameter in function declaration to fix checkpatch.pl warning
that parameter needed to be aligned with the opening parenthesis of
the declaration.

Signed-off-by: Tim Collier 
---
 drivers/staging/wlan-ng/hfa384x.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/wlan-ng/hfa384x.h 
b/drivers/staging/wlan-ng/hfa384x.h
index 2d3d8b1e2c1b..86fd3fcd8a36 100644
--- a/drivers/staging/wlan-ng/hfa384x.h
+++ b/drivers/staging/wlan-ng/hfa384x.h
@@ -1374,7 +1374,7 @@ void hfa384x_create(struct hfa384x *hw, struct usb_device 
*usb);
 void hfa384x_destroy(struct hfa384x *hw);
 
 int hfa384x_corereset(struct hfa384x *hw, int holdtime, int settletime,
-  int genesis);
+ int genesis);
 int hfa384x_drvr_disable(struct hfa384x *hw, u16 macport);
 int hfa384x_drvr_enable(struct hfa384x *hw, u16 macport);
 int hfa384x_drvr_flashdl_enable(struct hfa384x *hw);
-- 
2.21.0

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 1/5] staging: wlan-ng: remove unnecessary casts from prism2usb.c

2019-10-25 Thread Tim Collier 
usb_get_intfdata returns a void pointer. It is not necessary to
explicitly cast to the desired type and removing the casts is
consistent with most use of usb_get_intfdata.

Signed-off-by: Tim Collier 
---
 drivers/staging/wlan-ng/prism2usb.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/wlan-ng/prism2usb.c 
b/drivers/staging/wlan-ng/prism2usb.c
index b5ba176004c1..352556f6870a 100644
--- a/drivers/staging/wlan-ng/prism2usb.c
+++ b/drivers/staging/wlan-ng/prism2usb.c
@@ -137,7 +137,7 @@ static void prism2sta_disconnect_usb(struct usb_interface 
*interface)
 {
struct wlandevice *wlandev;
 
-   wlandev = (struct wlandevice *)usb_get_intfdata(interface);
+   wlandev = usb_get_intfdata(interface);
if (wlandev) {
LIST_HEAD(cleanlist);
struct hfa384x_usbctlx *ctlx, *temp;
@@ -222,7 +222,7 @@ static int prism2sta_suspend(struct usb_interface 
*interface,
struct hfa384x *hw = NULL;
struct wlandevice *wlandev;
 
-   wlandev = (struct wlandevice *)usb_get_intfdata(interface);
+   wlandev = usb_get_intfdata(interface);
if (!wlandev)
return -ENODEV;
 
@@ -245,7 +245,7 @@ static int prism2sta_resume(struct usb_interface *interface)
struct hfa384x *hw = NULL;
struct wlandevice *wlandev;
 
-   wlandev = (struct wlandevice *)usb_get_intfdata(interface);
+   wlandev = usb_get_intfdata(interface);
if (!wlandev)
return -ENODEV;
 
-- 
2.21.0

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel