[PATCH] hp100: Move 100BaseVG AnyLAN driver to staging
100BaseVG AnyLAN hasn't been useful since 1996 or so and even then
didn't sell many devices. It's unlikely any are still in use.
Move the driver to staging with the intent of removing it altogether
one day.
Signed-off-by: Joe Perches
---
MAINTAINERS | 4 ++--
drivers/net/ethernet/Kconfig | 1 -
drivers/net/ethernet/Makefile | 1 -
drivers/staging/Kconfig | 2 ++
drivers/staging/Makefile | 1 +
drivers/{net/ethernet => staging}/hp/Kconfig | 0
drivers/{net/ethernet => staging}/hp/Makefile | 0
drivers/{net/ethernet => staging}/hp/hp100.c | 0
drivers/{net/ethernet => staging}/hp/hp100.h | 0
9 files changed, 5 insertions(+), 4 deletions(-)
rename drivers/{net/ethernet => staging}/hp/Kconfig (100%)
rename drivers/{net/ethernet => staging}/hp/Makefile (100%)
rename drivers/{net/ethernet => staging}/hp/hp100.c (100%)
rename drivers/{net/ethernet => staging}/hp/hp100.h (100%)
diff --git a/MAINTAINERS b/MAINTAINERS
index c6c34d..bea725 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -7444,8 +7444,8 @@ F:drivers/platform/x86/tc1100-wmi.c
HP100: Driver for HP 10/100 Mbit/s Voice Grade Network Adapter Series
M: Jaroslav Kysela
-S: Maintained
-F: drivers/net/ethernet/hp/hp100.*
+S: Obsolete
+F: drivers/staging/hp/hp100.*
HPET: High Precision Event Timers driver
M: Clemens Ladisch
diff --git a/drivers/net/ethernet/Kconfig b/drivers/net/ethernet/Kconfig
index e8e9c16..4ded81 100644
--- a/drivers/net/ethernet/Kconfig
+++ b/drivers/net/ethernet/Kconfig
@@ -78,7 +78,6 @@ source "drivers/net/ethernet/freescale/Kconfig"
source "drivers/net/ethernet/fujitsu/Kconfig"
source "drivers/net/ethernet/google/Kconfig"
source "drivers/net/ethernet/hisilicon/Kconfig"
-source "drivers/net/ethernet/hp/Kconfig"
source "drivers/net/ethernet/huawei/Kconfig"
source "drivers/net/ethernet/i825xx/Kconfig"
source "drivers/net/ethernet/ibm/Kconfig"
diff --git a/drivers/net/ethernet/Makefile b/drivers/net/ethernet/Makefile
index 05abeb..f8f38d 100644
--- a/drivers/net/ethernet/Makefile
+++ b/drivers/net/ethernet/Makefile
@@ -41,7 +41,6 @@ obj-$(CONFIG_NET_VENDOR_FREESCALE) += freescale/
obj-$(CONFIG_NET_VENDOR_FUJITSU) += fujitsu/
obj-$(CONFIG_NET_VENDOR_GOOGLE) += google/
obj-$(CONFIG_NET_VENDOR_HISILICON) += hisilicon/
-obj-$(CONFIG_NET_VENDOR_HP) += hp/
obj-$(CONFIG_NET_VENDOR_HUAWEI) += huawei/
obj-$(CONFIG_NET_VENDOR_IBM) += ibm/
obj-$(CONFIG_NET_VENDOR_INTEL) += intel/
diff --git a/drivers/staging/Kconfig b/drivers/staging/Kconfig
index 6f1fa4..08 100644
--- a/drivers/staging/Kconfig
+++ b/drivers/staging/Kconfig
@@ -125,4 +125,6 @@ source "drivers/staging/exfat/Kconfig"
source "drivers/staging/qlge/Kconfig"
+source "drivers/staging/hp/Kconfig"
+
endif # STAGING
diff --git a/drivers/staging/Makefile b/drivers/staging/Makefile
index a90f9b3..e4943c 100644
--- a/drivers/staging/Makefile
+++ b/drivers/staging/Makefile
@@ -53,3 +53,4 @@ obj-$(CONFIG_UWB) += uwb/
obj-$(CONFIG_USB_WUSB) += wusbcore/
obj-$(CONFIG_EXFAT_FS) += exfat/
obj-$(CONFIG_QLGE) += qlge/
+obj-$(CONFIG_NET_VENDOR_HP)+= hp/
diff --git a/drivers/net/ethernet/hp/Kconfig b/drivers/staging/hp/Kconfig
similarity index 100%
rename from drivers/net/ethernet/hp/Kconfig
rename to drivers/staging/hp/Kconfig
diff --git a/drivers/net/ethernet/hp/Makefile b/drivers/staging/hp/Makefile
similarity index 100%
rename from drivers/net/ethernet/hp/Makefile
rename to drivers/staging/hp/Makefile
diff --git a/drivers/net/ethernet/hp/hp100.c b/drivers/staging/hp/hp100.c
similarity index 100%
rename from drivers/net/ethernet/hp/hp100.c
rename to drivers/staging/hp/hp100.c
diff --git a/drivers/net/ethernet/hp/hp100.h b/drivers/staging/hp/hp100.h
similarity index 100%
rename from drivers/net/ethernet/hp/hp100.h
rename to drivers/staging/hp/hp100.h
--
2.24.0.rc2
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v3] dt-bindings: iio: accel: add binding documentation for ADIS16240
This patch add device tree binding documentation for ADIS16240.
Signed-off-by: Rodrigo Ribeiro Carvalho
---
V3:
- Remove spi-cpol and spi-cpha field. They don't seem necessary
.../bindings/iio/accel/adi,adis16240.yaml | 51 +++
1 file changed, 51 insertions(+)
create mode 100644
Documentation/devicetree/bindings/iio/accel/adi,adis16240.yaml
diff --git a/Documentation/devicetree/bindings/iio/accel/adi,adis16240.yaml
b/Documentation/devicetree/bindings/iio/accel/adi,adis16240.yaml
new file mode 100644
index ..9a4cd12c4818
--- /dev/null
+++ b/Documentation/devicetree/bindings/iio/accel/adi,adis16240.yaml
@@ -0,0 +1,51 @@
+# SPDX-License-Identifier: GPL-2.0
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/iio/accel/adi,adis16240.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: ADIS16240 Programmable Impact Sensor and Recorder driver
+
+maintainers:
+ - Alexandru Ardelean
+
+description: |
+ ADIS16240 Programmable Impact Sensor and Recorder driver that supports
+ SPI interface.
+https://www.analog.com/en/products/adis16240.html
+
+properties:
+ compatible:
+enum:
+ - adi,adis16240
+
+ reg:
+maxItems: 1
+
+ interrupts:
+maxItems: 1
+
+required:
+ - compatible
+ - reg
+ - interrupts
+
+examples:
+ - |
+#include
+#include
+spi0 {
+#address-cells = <1>;
+#size-cells = <0>;
+
+/* Example for a SPI device node */
+accelerometer@0 {
+compatible = "adi,adis16240";
+reg = <0>;
+spi-max-frequency = <250>;
+spi-cpol;
+spi-cpha;
+interrupt-parent = <>;
+interrupts = <0 IRQ_TYPE_LEVEL_HIGH>;
+};
+};
--
2.23.0
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v4 3/3] staging: rts5208: Eliminate the use of Camel Case in file sd.h
Cleans up checks of "Avoid CamelCase" in file sd.h Even though the constant "DCM_LOW_FREQUENCY_MODE_SET" is defined and never used, it's useful to keep it because it documents the device. Signed-off-by: Gabriela Bittencourt --- Changes in v4: - Explain the reason of keeping a constant that is defined and not used --- drivers/staging/rts5208/sd.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rts5208/sd.h b/drivers/staging/rts5208/sd.h index dc9e8cad7a74..f4ff62653b56 100644 --- a/drivers/staging/rts5208/sd.h +++ b/drivers/staging/rts5208/sd.h @@ -232,7 +232,7 @@ #define DCM_LOW_FREQUENCY_MODE 0x01 #define DCM_HIGH_FREQUENCY_MODE_SET 0x0C -#define DCM_Low_FREQUENCY_MODE_SET 0x00 +#define DCM_LOW_FREQUENCY_MODE_SET 0x00 #define MULTIPLY_BY_10x00 #define MULTIPLY_BY_20x01 -- 2.20.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v4 2/3] staging: rts5208: Eliminate the use of Camel Case in files xd.{h, c}
Cleans up checks of "Avoid CamelCase" in files xd.{h,c}
Acked-by: Julia Lawall
Signed-off-by: Gabriela Bittencourt
---
drivers/staging/rts5208/xd.c | 8
drivers/staging/rts5208/xd.h | 6 +++---
2 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/rts5208/xd.c b/drivers/staging/rts5208/xd.c
index f3dc96a4c59d..0f369935fb6c 100644
--- a/drivers/staging/rts5208/xd.c
+++ b/drivers/staging/rts5208/xd.c
@@ -630,13 +630,13 @@ static int reset_xd(struct rtsx_chip *chip)
xd_card->zone_cnt = 32;
xd_card->capacity = 1024000;
break;
- case xD_1G_X8_512:
+ case XD_1G_X8_512:
XD_PAGE_512(xd_card);
xd_card->addr_cycle = 4;
xd_card->zone_cnt = 64;
xd_card->capacity = 2048000;
break;
- case xD_2G_X8_512:
+ case XD_2G_X8_512:
XD_PAGE_512(xd_card);
xd_card->addr_cycle = 4;
xd_card->zone_cnt = 128;
@@ -669,10 +669,10 @@ static int reset_xd(struct rtsx_chip *chip)
return STATUS_FAIL;
}
- retval = xd_read_id(chip, READ_xD_ID, id_buf, 4);
+ retval = xd_read_id(chip, READ_XD_ID, id_buf, 4);
if (retval != STATUS_SUCCESS)
return STATUS_FAIL;
- dev_dbg(rtsx_dev(chip), "READ_xD_ID: 0x%x 0x%x 0x%x 0x%x\n",
+ dev_dbg(rtsx_dev(chip), "READ_XD_ID: 0x%x 0x%x 0x%x 0x%x\n",
id_buf[0], id_buf[1], id_buf[2], id_buf[3]);
if (id_buf[2] != XD_ID_CODE)
return STATUS_FAIL;
diff --git a/drivers/staging/rts5208/xd.h b/drivers/staging/rts5208/xd.h
index 57b94129b26f..98c00f268e56 100644
--- a/drivers/staging/rts5208/xd.h
+++ b/drivers/staging/rts5208/xd.h
@@ -36,7 +36,7 @@
#defineBLK_ERASE_1 0x60
#defineBLK_ERASE_2 0xD0
#define READ_STS 0x70
-#define READ_xD_ID 0x9A
+#define READ_XD_ID 0x9A
#defineCOPY_BACK_512 0x8A
#defineCOPY_BACK_2K0x85
#defineREAD1_1_2 0x30
@@ -72,8 +72,8 @@
#defineXD_128M_X16_20480xC1
#defineXD_4M_X8_512_1 0xE3
#defineXD_4M_X8_512_2 0xE5
-#definexD_1G_X8_5120xD3
-#definexD_2G_X8_5120xD5
+#defineXD_1G_X8_5120xD3
+#defineXD_2G_X8_5120xD5
#defineXD_ID_CODE 0xB5
--
2.20.1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v4 1/3] staging: rts5208: Eliminate the use of Camel Case in files ms.{h, c}
Cleans up checks of "Avoid CamelCase" in files ms.{h,c}
Signed-off-by: Gabriela Bittencourt
---
Changes in v2:
- substitute variables in lower case to upper case
---
drivers/staging/rts5208/ms.c | 86 ++--
drivers/staging/rts5208/ms.h | 70 ++---
2 files changed, 78 insertions(+), 78 deletions(-)
diff --git a/drivers/staging/rts5208/ms.c b/drivers/staging/rts5208/ms.c
index e853fa9cc950..d53dd138a356 100644
--- a/drivers/staging/rts5208/ms.c
+++ b/drivers/staging/rts5208/ms.c
@@ -590,7 +590,7 @@ static int ms_identify_media_type(struct rtsx_chip *chip,
int switch_8bit_bus)
int retval, i;
u8 val;
- retval = ms_set_rw_reg_addr(chip, Pro_StatusReg, 6, SystemParm, 1);
+ retval = ms_set_rw_reg_addr(chip, PRO_STATUS_REG, 6, SYSTEM_PARAM, 1);
if (retval != STATUS_SUCCESS)
return STATUS_FAIL;
@@ -840,7 +840,7 @@ static int msxc_change_power(struct rtsx_chip *chip, u8
mode)
ms_cleanup_work(chip);
- retval = ms_set_rw_reg_addr(chip, 0, 0, Pro_DataCount1, 6);
+ retval = ms_set_rw_reg_addr(chip, 0, 0, PRO_DATA_COUNT1, 6);
if (retval != STATUS_SUCCESS)
return STATUS_FAIL;
@@ -885,7 +885,7 @@ static int ms_read_attribute_info(struct rtsx_chip *chip)
int found_sys_info = 0, found_model_name = 0;
#endif
- retval = ms_set_rw_reg_addr(chip, Pro_IntReg, 2, Pro_SystemParm, 7);
+ retval = ms_set_rw_reg_addr(chip, PRO_INT_REG, 2, PRO_SYSTEM_PARAM, 7);
if (retval != STATUS_SUCCESS)
return STATUS_FAIL;
@@ -1232,7 +1232,7 @@ static int ms_read_status_reg(struct rtsx_chip *chip)
int retval;
u8 val[2];
- retval = ms_set_rw_reg_addr(chip, StatusReg0, 2, 0, 0);
+ retval = ms_set_rw_reg_addr(chip, STATUS_REG0, 2, 0, 0);
if (retval != STATUS_SUCCESS)
return STATUS_FAIL;
@@ -1255,8 +1255,8 @@ static int ms_read_extra_data(struct rtsx_chip *chip,
int retval, i;
u8 val, data[10];
- retval = ms_set_rw_reg_addr(chip, OverwriteFlag, MS_EXTRA_SIZE,
- SystemParm, 6);
+ retval = ms_set_rw_reg_addr(chip, OVERWRITE_FLAG, MS_EXTRA_SIZE,
+ SYSTEM_PARAM, 6);
if (retval != STATUS_SUCCESS)
return STATUS_FAIL;
@@ -1307,8 +1307,8 @@ static int ms_read_extra_data(struct rtsx_chip *chip,
if (retval != STATUS_SUCCESS)
return STATUS_FAIL;
- retval = ms_set_rw_reg_addr(chip, OverwriteFlag,
- MS_EXTRA_SIZE, SystemParm,
+ retval = ms_set_rw_reg_addr(chip, OVERWRITE_FLAG,
+ MS_EXTRA_SIZE, SYSTEM_PARAM,
6);
if (retval != STATUS_SUCCESS)
return STATUS_FAIL;
@@ -1339,8 +1339,8 @@ static int ms_write_extra_data(struct rtsx_chip *chip,
u16 block_addr,
if (!buf || (buf_len < MS_EXTRA_SIZE))
return STATUS_FAIL;
- retval = ms_set_rw_reg_addr(chip, OverwriteFlag, MS_EXTRA_SIZE,
- SystemParm, 6 + MS_EXTRA_SIZE);
+ retval = ms_set_rw_reg_addr(chip, OVERWRITE_FLAG, MS_EXTRA_SIZE,
+ SYSTEM_PARAM, 6 + MS_EXTRA_SIZE);
if (retval != STATUS_SUCCESS)
return STATUS_FAIL;
@@ -1392,8 +1392,8 @@ static int ms_read_page(struct rtsx_chip *chip, u16
block_addr, u8 page_num)
int retval;
u8 val, data[6];
- retval = ms_set_rw_reg_addr(chip, OverwriteFlag, MS_EXTRA_SIZE,
- SystemParm, 6);
+ retval = ms_set_rw_reg_addr(chip, OVERWRITE_FLAG, MS_EXTRA_SIZE,
+ SYSTEM_PARAM, 6);
if (retval != STATUS_SUCCESS)
return STATUS_FAIL;
@@ -1465,8 +1465,8 @@ static int ms_set_bad_block(struct rtsx_chip *chip, u16
phy_blk)
if (retval != STATUS_SUCCESS)
return STATUS_FAIL;
- retval = ms_set_rw_reg_addr(chip, OverwriteFlag, MS_EXTRA_SIZE,
- SystemParm, 7);
+ retval = ms_set_rw_reg_addr(chip, OVERWRITE_FLAG, MS_EXTRA_SIZE,
+ SYSTEM_PARAM, 7);
if (retval != STATUS_SUCCESS)
return STATUS_FAIL;
@@ -1519,8 +1519,8 @@ static int ms_erase_block(struct rtsx_chip *chip, u16
phy_blk)
int retval, i = 0;
u8 val, data[6];
- retval = ms_set_rw_reg_addr(chip, OverwriteFlag, MS_EXTRA_SIZE,
- SystemParm, 6);
+ retval = ms_set_rw_reg_addr(chip, OVERWRITE_FLAG, MS_EXTRA_SIZE,
+ SYSTEM_PARAM, 6);
if (retval != STATUS_SUCCESS)
[PATCH v4 0/3] staging: rts5208: Eliminate the use of Camel Case
Cleans up checks of "Avoid CamelCase" in tree rts5208
Changes in v4:
- Substitute constants in lower case to upper case
- Explain the reason of keeping a variable that is defined and it's not used
Changes in v3:
- Change the subject line of commits to make it more clear and informative
Changes in v2:
- Place the changes on variable's names in the use and definition in the
same commit
I compile the kernel after each commit of the series to make sure it
doesn't break the compilation.
Gabriela Bittencourt (3):
staging: rts5208: Eliminate the use of Camel Case in files ms.{h,c}
staging: rts5208: Eliminate the use of Camel Case in files xd.{h,c}
staging: rts5208: Eliminate the use of Camel Case in file sd.h
drivers/staging/rts5208/ms.c | 86 ++--
drivers/staging/rts5208/ms.h | 70 ++---
drivers/staging/rts5208/sd.h | 2 +-
drivers/staging/rts5208/xd.c | 8 ++--
drivers/staging/rts5208/xd.h | 6 +--
5 files changed, 86 insertions(+), 86 deletions(-)
--
2.20.1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] hp100: Move 100BaseVG AnyLAN driver to staging
From: Joe Perches Date: Thu, 31 Oct 2019 11:23:37 -0700 > 100BaseVG AnyLAN hasn't been useful since 1996 or so and even then > didn't sell many devices. It's unlikely any are still in use. > > Move the driver to staging with the intent of removing it altogether > one day. > > Signed-off-by: Joe Perches Applied to net-next. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [RFC] errno.h: Provide EFSCORRUPTED for everybody
On Wed, Oct 30, 2019 at 09:07:33PM -0400, Valdis Kletnieks wrote: > Three questions: (a) ACK/NAK on this patch, (b) should it be all in one > patch, or one to add to errno.h and 6 patches for 6 filesystems?), and > (c) if one patch, who gets to shepherd it through? Acked-by: Theodore Ts'o ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] hp100: Move 100BaseVG AnyLAN driver to staging
Dne 31. 10. 19 v 19:23 Joe Perches napsal(a):
100BaseVG AnyLAN hasn't been useful since 1996 or so and even then
didn't sell many devices. It's unlikely any are still in use.
Move the driver to staging with the intent of removing it altogether
one day.
Signed-off-by: Joe Perches
Acked-by: Jaroslav Kysela
---
MAINTAINERS | 4 ++--
drivers/net/ethernet/Kconfig | 1 -
drivers/net/ethernet/Makefile | 1 -
drivers/staging/Kconfig | 2 ++
drivers/staging/Makefile | 1 +
drivers/{net/ethernet => staging}/hp/Kconfig | 0
drivers/{net/ethernet => staging}/hp/Makefile | 0
drivers/{net/ethernet => staging}/hp/hp100.c | 0
drivers/{net/ethernet => staging}/hp/hp100.h | 0
9 files changed, 5 insertions(+), 4 deletions(-)
rename drivers/{net/ethernet => staging}/hp/Kconfig (100%)
rename drivers/{net/ethernet => staging}/hp/Makefile (100%)
rename drivers/{net/ethernet => staging}/hp/hp100.c (100%)
rename drivers/{net/ethernet => staging}/hp/hp100.h (100%)
diff --git a/MAINTAINERS b/MAINTAINERS
index c6c34d..bea725 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -7444,8 +7444,8 @@ F:drivers/platform/x86/tc1100-wmi.c
HP100: Driver for HP 10/100 Mbit/s Voice Grade Network Adapter Series
M:Jaroslav Kysela
-S: Maintained
-F: drivers/net/ethernet/hp/hp100.*
+S: Obsolete
+F: drivers/staging/hp/hp100.*
HPET: High Precision Event Timers driver
M:Clemens Ladisch
diff --git a/drivers/net/ethernet/Kconfig b/drivers/net/ethernet/Kconfig
index e8e9c16..4ded81 100644
--- a/drivers/net/ethernet/Kconfig
+++ b/drivers/net/ethernet/Kconfig
@@ -78,7 +78,6 @@ source "drivers/net/ethernet/freescale/Kconfig"
source "drivers/net/ethernet/fujitsu/Kconfig"
source "drivers/net/ethernet/google/Kconfig"
source "drivers/net/ethernet/hisilicon/Kconfig"
-source "drivers/net/ethernet/hp/Kconfig"
source "drivers/net/ethernet/huawei/Kconfig"
source "drivers/net/ethernet/i825xx/Kconfig"
source "drivers/net/ethernet/ibm/Kconfig"
diff --git a/drivers/net/ethernet/Makefile b/drivers/net/ethernet/Makefile
index 05abeb..f8f38d 100644
--- a/drivers/net/ethernet/Makefile
+++ b/drivers/net/ethernet/Makefile
@@ -41,7 +41,6 @@ obj-$(CONFIG_NET_VENDOR_FREESCALE) += freescale/
obj-$(CONFIG_NET_VENDOR_FUJITSU) += fujitsu/
obj-$(CONFIG_NET_VENDOR_GOOGLE) += google/
obj-$(CONFIG_NET_VENDOR_HISILICON) += hisilicon/
-obj-$(CONFIG_NET_VENDOR_HP) += hp/
obj-$(CONFIG_NET_VENDOR_HUAWEI) += huawei/
obj-$(CONFIG_NET_VENDOR_IBM) += ibm/
obj-$(CONFIG_NET_VENDOR_INTEL) += intel/
diff --git a/drivers/staging/Kconfig b/drivers/staging/Kconfig
index 6f1fa4..08 100644
--- a/drivers/staging/Kconfig
+++ b/drivers/staging/Kconfig
@@ -125,4 +125,6 @@ source "drivers/staging/exfat/Kconfig"
source "drivers/staging/qlge/Kconfig"
+source "drivers/staging/hp/Kconfig"
+
endif # STAGING
diff --git a/drivers/staging/Makefile b/drivers/staging/Makefile
index a90f9b3..e4943c 100644
--- a/drivers/staging/Makefile
+++ b/drivers/staging/Makefile
@@ -53,3 +53,4 @@ obj-$(CONFIG_UWB) += uwb/
obj-$(CONFIG_USB_WUSB)+= wusbcore/
obj-$(CONFIG_EXFAT_FS)+= exfat/
obj-$(CONFIG_QLGE)+= qlge/
+obj-$(CONFIG_NET_VENDOR_HP)+= hp/
diff --git a/drivers/net/ethernet/hp/Kconfig b/drivers/staging/hp/Kconfig
similarity index 100%
rename from drivers/net/ethernet/hp/Kconfig
rename to drivers/staging/hp/Kconfig
diff --git a/drivers/net/ethernet/hp/Makefile b/drivers/staging/hp/Makefile
similarity index 100%
rename from drivers/net/ethernet/hp/Makefile
rename to drivers/staging/hp/Makefile
diff --git a/drivers/net/ethernet/hp/hp100.c b/drivers/staging/hp/hp100.c
similarity index 100%
rename from drivers/net/ethernet/hp/hp100.c
rename to drivers/staging/hp/hp100.c
diff --git a/drivers/net/ethernet/hp/hp100.h b/drivers/staging/hp/hp100.h
similarity index 100%
rename from drivers/net/ethernet/hp/hp100.h
rename to drivers/staging/hp/hp100.h
--
Jaroslav Kysela
Linux Sound Maintainer; ALSA Project; Red Hat, Inc.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [RFC] errno.h: Provide EFSCORRUPTED for everybody
On Wed 30-10-19 21:07:33, Valdis Kletnieks wrote:
> Three questions: (a) ACK/NAK on this patch, (b) should it be all in one
> patch, or one to add to errno.h and 6 patches for 6 filesystems?), and
> (c) if one patch, who gets to shepherd it through?
>
>
> There's currently 6 filesystems that have the same #define. Move it
> into errno.h so it's defined in just one place.
>
> Signed-off-by: Valdis Kletnieks
Looks good to me. You can add:
Reviewed-by: Jan Kara
Honza
> ---
> drivers/staging/exfat/exfat.h| 2 --
> fs/erofs/internal.h | 2 --
> fs/ext4/ext4.h | 1 -
> fs/f2fs/f2fs.h | 1 -
> fs/xfs/xfs_linux.h | 1 -
> include/linux/jbd2.h | 1 -
> include/uapi/asm-generic/errno.h | 1 +
> 7 files changed, 1 insertion(+), 8 deletions(-)
>
> diff --git a/drivers/staging/exfat/exfat.h b/drivers/staging/exfat/exfat.h
> index 84de1123e178..3cf7e54af0b7 100644
> --- a/drivers/staging/exfat/exfat.h
> +++ b/drivers/staging/exfat/exfat.h
> @@ -30,8 +30,6 @@
> #undef DEBUG
> #endif
>
> -#define EFSCORRUPTED EUCLEAN /* Filesystem is corrupted */
> -
> #define DENTRY_SIZE 32 /* dir entry size */
> #define DENTRY_SIZE_BITS 5
>
> diff --git a/fs/erofs/internal.h b/fs/erofs/internal.h
> index 544a453f3076..3980026a8882 100644
> --- a/fs/erofs/internal.h
> +++ b/fs/erofs/internal.h
> @@ -425,7 +425,5 @@ static inline int z_erofs_init_zip_subsystem(void) {
> return 0; }
> static inline void z_erofs_exit_zip_subsystem(void) {}
> #endif /* !CONFIG_EROFS_FS_ZIP */
>
> -#define EFSCORRUPTEDEUCLEAN /* Filesystem is corrupted */
> -
> #endif /* __EROFS_INTERNAL_H */
>
> diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
> index 03db3e71676c..a86c2585457d 100644
> --- a/fs/ext4/ext4.h
> +++ b/fs/ext4/ext4.h
> @@ -3396,6 +3396,5 @@ static inline int ext4_buffer_uptodate(struct
> buffer_head *bh)
> #endif /* __KERNEL__ */
>
> #define EFSBADCRCEBADMSG /* Bad CRC detected */
> -#define EFSCORRUPTED EUCLEAN /* Filesystem is corrupted */
>
> #endif /* _EXT4_H */
> diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
> index 4024790028aa..04ebe77569a3 100644
> --- a/fs/f2fs/f2fs.h
> +++ b/fs/f2fs/f2fs.h
> @@ -3752,6 +3752,5 @@ static inline bool is_journalled_quota(struct
> f2fs_sb_info *sbi)
> }
>
> #define EFSBADCRCEBADMSG /* Bad CRC detected */
> -#define EFSCORRUPTED EUCLEAN /* Filesystem is corrupted */
>
> #endif /* _LINUX_F2FS_H */
> diff --git a/fs/xfs/xfs_linux.h b/fs/xfs/xfs_linux.h
> index ca15105681ca..3409d02a7d21 100644
> --- a/fs/xfs/xfs_linux.h
> +++ b/fs/xfs/xfs_linux.h
> @@ -123,7 +123,6 @@ typedef __u32 xfs_nlink_t;
>
> #define ENOATTR ENODATA /* Attribute not found */
> #define EWRONGFS EINVAL /* Mount with wrong filesystem type */
> -#define EFSCORRUPTED EUCLEAN /* Filesystem is corrupted */
> #define EFSBADCRCEBADMSG /* Bad CRC detected */
>
> #define SYNCHRONIZE()barrier()
> diff --git a/include/linux/jbd2.h b/include/linux/jbd2.h
> index 564793c24d12..1ecd3859d040 100644
> --- a/include/linux/jbd2.h
> +++ b/include/linux/jbd2.h
> @@ -1657,6 +1657,5 @@ static inline tid_t
> jbd2_get_latest_transaction(journal_t *journal)
> #endif /* __KERNEL__ */
>
> #define EFSBADCRCEBADMSG /* Bad CRC detected */
> -#define EFSCORRUPTED EUCLEAN /* Filesystem is corrupted */
>
> #endif /* _LINUX_JBD2_H */
> diff --git a/include/uapi/asm-generic/errno.h
> b/include/uapi/asm-generic/errno.h
> index cf9c51ac49f9..1d5ffdf54cb0 100644
> --- a/include/uapi/asm-generic/errno.h
> +++ b/include/uapi/asm-generic/errno.h
> @@ -98,6 +98,7 @@
> #define EINPROGRESS 115 /* Operation now in progress */
> #define ESTALE 116 /* Stale file handle */
> #define EUCLEAN 117 /* Structure needs cleaning */
> +#define EFSCORRUPTEDEUCLEAN
> #define ENOTNAM 118 /* Not a XENIX named type file */
> #define ENAVAIL 119 /* No XENIX semaphores available */
> #define EISNAM 120 /* Is a named type file */
> --
> 2.24.0.rc1
>
--
Jan Kara
SUSE Labs, CR
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v2 6/6] staging: exfat: replace kmalloc with kmalloc_array
> > diff --git a/drivers/staging/exfat/exfat_core.c > > b/drivers/staging/exfat/exfat_core.c > > index f71235c6a338..f4f82aecc05d 100644 > > --- a/drivers/staging/exfat/exfat_core.c > > +++ b/drivers/staging/exfat/exfat_core.c > > @@ -713,8 +713,8 @@ static s32 __load_upcase_table(struct super_block *sb, > > sector_t sector, > > > > u32 checksum = 0; > > > > - upcase_table = p_fs->vol_utbl = kmalloc(UTBL_COL_COUNT * sizeof(u16 *), > > - GFP_KERNEL); > > + upcase_table = kmalloc_array(UTBL_COL_COUNT, sizeof(u16 *), GFP_KERNEL); > > + p_fs->vol_utbl = upcase_table; > > This patch is fine, but one idea for future patches is that you could > remove the "upcase_table" variable and use "p_fs->vol_utbl" everywhere > instead. Thanks for the suggestion. This is my first contribution and I tried to introduce the minimum number of changes necessary to fix the issues reported by checkpatch.pl. Also, I'm still immersed in getting familiar with the contribution process and the code. Do you think it makes sense to include this change in a future patch series along with other refactoring? Or, should I modify this patch? By the way, upcase_table is sometimes accessed in quite complex ways. For instance: upcase_table[col_index][get_row_index(index)] = uni; Where having an intermediate variable instead of using the struct field directly seems to improve readability a bit. Otherwise: p_fs->vol_utbl[col_index][get_row_index(index)] = uni; I assume, in cases like this, from a coding style perspective, the following approach is preferred: row_index = get_row_index(index); p_fs->vol_utbl[col_index][row_index] = uni; Is that correct? Regards, Roi Martin ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v2 6/6] staging: exfat: replace kmalloc with kmalloc_array
On Thu, Oct 31, 2019 at 01:31:39PM +0100, Roi Martin wrote: > diff --git a/drivers/staging/exfat/exfat_core.c > b/drivers/staging/exfat/exfat_core.c > index f71235c6a338..f4f82aecc05d 100644 > --- a/drivers/staging/exfat/exfat_core.c > +++ b/drivers/staging/exfat/exfat_core.c > @@ -713,8 +713,8 @@ static s32 __load_upcase_table(struct super_block *sb, > sector_t sector, > > u32 checksum = 0; > > - upcase_table = p_fs->vol_utbl = kmalloc(UTBL_COL_COUNT * sizeof(u16 *), > - GFP_KERNEL); > + upcase_table = kmalloc_array(UTBL_COL_COUNT, sizeof(u16 *), GFP_KERNEL); > + p_fs->vol_utbl = upcase_table; This patch is fine, but one idea for future patches is that you could remove the "upcase_table" variable and use "p_fs->vol_utbl" everywhere instead. > if (!upcase_table) > return -ENOMEM; regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 6/6] staging: exfat: replace kmalloc with kmalloc_array
> This patch failed to apply. Please fix it up and resend it as a new > version. I have rebased the patch against the branch "staging-testing" of the tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git And sent the new version. Thanks, Roi Martin ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v2 6/6] staging: exfat: replace kmalloc with kmalloc_array
Replace expressions of the form: kmalloc(count * size, GFP_KERNEL); With: kmalloc_array(count, size, GFP_KERNEL); Signed-off-by: Roi Martin --- v2 changes: This patch has been rebased against the branch "staging-testing" of the tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git drivers/staging/exfat/exfat_core.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/exfat/exfat_core.c b/drivers/staging/exfat/exfat_core.c index f71235c6a338..f4f82aecc05d 100644 --- a/drivers/staging/exfat/exfat_core.c +++ b/drivers/staging/exfat/exfat_core.c @@ -713,8 +713,8 @@ static s32 __load_upcase_table(struct super_block *sb, sector_t sector, u32 checksum = 0; - upcase_table = p_fs->vol_utbl = kmalloc(UTBL_COL_COUNT * sizeof(u16 *), - GFP_KERNEL); + upcase_table = kmalloc_array(UTBL_COL_COUNT, sizeof(u16 *), GFP_KERNEL); + p_fs->vol_utbl = upcase_table; if (!upcase_table) return -ENOMEM; memset(upcase_table, 0, UTBL_COL_COUNT * sizeof(u16 *)); @@ -793,8 +793,8 @@ static s32 __load_default_upcase_table(struct super_block *sb) u16 uni = 0; u16 **upcase_table; - upcase_table = p_fs->vol_utbl = kmalloc(UTBL_COL_COUNT * sizeof(u16 *), - GFP_KERNEL); + upcase_table = kmalloc_array(UTBL_COL_COUNT, sizeof(u16 *), GFP_KERNEL); + p_fs->vol_utbl = upcase_table; if (!upcase_table) return -ENOMEM; memset(upcase_table, 0, UTBL_COL_COUNT * sizeof(u16 *)); -- 2.20.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[RFC PATCH] iio: adc: ad7091r5: ad7091r_remove() can be static
Fixes: 608229aeaa1f ("iio: adc: ad7091r5: Add scale and external VREF support")
Signed-off-by: kbuild test robot
---
ad7091r-base.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/adc/ad7091r-base.c b/drivers/iio/adc/ad7091r-base.c
index fda1112e73760..dc42735680c83 100644
--- a/drivers/iio/adc/ad7091r-base.c
+++ b/drivers/iio/adc/ad7091r-base.c
@@ -204,7 +204,7 @@ static irqreturn_t ad7091r_event_handler(int irq, void
*private)
return IRQ_HANDLED;
}
-void ad7091r_remove(void *data)
+static void ad7091r_remove(void *data)
{
struct ad7091r_state *st;
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v2 2/4] iio: adc: ad7091r5: Add scale and external VREF support
Hi Beniamin, I love your patch! Perhaps something to improve: [auto build test WARNING on iio/togreg] [also build test WARNING on v5.4-rc5 next-20191030] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Beniamin-Bia/iio-adc-Add-support-for-AD7091R5-ADC/20191031-100114 base: https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg reproduce: # apt-get install sparse # sparse version: v0.6.1-dirty make ARCH=x86_64 allmodconfig make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' If you fix the issue, kindly add following tag Reported-by: kbuild test robot sparse warnings: (new ones prefixed by >>) >> drivers/iio/adc/ad7091r-base.c:207:6: sparse: sparse: symbol >> 'ad7091r_remove' was not declared. Should it be static? Please review and possibly fold the followup patch. --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [Outreachy kernel] [PATCH v3 1/3] staging: rts5208: Eliminate the use of Camel Case in files ms.{h,c}
On Wed, 30 Oct 2019, Gabriela Bittencourt wrote:
> Cleans up checks of "Avoid CamelCase" in files ms.{h,c}
I think that these should be converted to all upper case rather than all
lower case.
julia
>
> Signed-off-by: Gabriela Bittencourt
> ---
> drivers/staging/rts5208/ms.c | 86 ++--
> drivers/staging/rts5208/ms.h | 70 ++---
> 2 files changed, 78 insertions(+), 78 deletions(-)
>
> diff --git a/drivers/staging/rts5208/ms.c b/drivers/staging/rts5208/ms.c
> index e853fa9cc950..5c7c13dfefa0 100644
> --- a/drivers/staging/rts5208/ms.c
> +++ b/drivers/staging/rts5208/ms.c
> @@ -590,7 +590,7 @@ static int ms_identify_media_type(struct rtsx_chip *chip,
> int switch_8bit_bus)
> int retval, i;
> u8 val;
>
> - retval = ms_set_rw_reg_addr(chip, Pro_StatusReg, 6, SystemParm, 1);
> + retval = ms_set_rw_reg_addr(chip, pro_status_reg, 6, system_parm, 1);
> if (retval != STATUS_SUCCESS)
> return STATUS_FAIL;
>
> @@ -840,7 +840,7 @@ static int msxc_change_power(struct rtsx_chip *chip, u8
> mode)
>
> ms_cleanup_work(chip);
>
> - retval = ms_set_rw_reg_addr(chip, 0, 0, Pro_DataCount1, 6);
> + retval = ms_set_rw_reg_addr(chip, 0, 0, pro_data_count1, 6);
> if (retval != STATUS_SUCCESS)
> return STATUS_FAIL;
>
> @@ -885,7 +885,7 @@ static int ms_read_attribute_info(struct rtsx_chip *chip)
> int found_sys_info = 0, found_model_name = 0;
> #endif
>
> - retval = ms_set_rw_reg_addr(chip, Pro_IntReg, 2, Pro_SystemParm, 7);
> + retval = ms_set_rw_reg_addr(chip, pro_int_REG, 2, pro_system_parm, 7);
> if (retval != STATUS_SUCCESS)
> return STATUS_FAIL;
>
> @@ -1232,7 +1232,7 @@ static int ms_read_status_reg(struct rtsx_chip *chip)
> int retval;
> u8 val[2];
>
> - retval = ms_set_rw_reg_addr(chip, StatusReg0, 2, 0, 0);
> + retval = ms_set_rw_reg_addr(chip, status_reg0, 2, 0, 0);
> if (retval != STATUS_SUCCESS)
> return STATUS_FAIL;
>
> @@ -1255,8 +1255,8 @@ static int ms_read_extra_data(struct rtsx_chip *chip,
> int retval, i;
> u8 val, data[10];
>
> - retval = ms_set_rw_reg_addr(chip, OverwriteFlag, MS_EXTRA_SIZE,
> - SystemParm, 6);
> + retval = ms_set_rw_reg_addr(chip, overwrite_flag, MS_EXTRA_SIZE,
> + system_parm, 6);
> if (retval != STATUS_SUCCESS)
> return STATUS_FAIL;
>
> @@ -1307,8 +1307,8 @@ static int ms_read_extra_data(struct rtsx_chip *chip,
> if (retval != STATUS_SUCCESS)
> return STATUS_FAIL;
>
> - retval = ms_set_rw_reg_addr(chip, OverwriteFlag,
> - MS_EXTRA_SIZE, SystemParm,
> + retval = ms_set_rw_reg_addr(chip, overwrite_flag,
> + MS_EXTRA_SIZE, system_parm,
> 6);
> if (retval != STATUS_SUCCESS)
> return STATUS_FAIL;
> @@ -1339,8 +1339,8 @@ static int ms_write_extra_data(struct rtsx_chip *chip,
> u16 block_addr,
> if (!buf || (buf_len < MS_EXTRA_SIZE))
> return STATUS_FAIL;
>
> - retval = ms_set_rw_reg_addr(chip, OverwriteFlag, MS_EXTRA_SIZE,
> - SystemParm, 6 + MS_EXTRA_SIZE);
> + retval = ms_set_rw_reg_addr(chip, overwrite_flag, MS_EXTRA_SIZE,
> + system_parm, 6 + MS_EXTRA_SIZE);
> if (retval != STATUS_SUCCESS)
> return STATUS_FAIL;
>
> @@ -1392,8 +1392,8 @@ static int ms_read_page(struct rtsx_chip *chip, u16
> block_addr, u8 page_num)
> int retval;
> u8 val, data[6];
>
> - retval = ms_set_rw_reg_addr(chip, OverwriteFlag, MS_EXTRA_SIZE,
> - SystemParm, 6);
> + retval = ms_set_rw_reg_addr(chip, overwrite_flag, MS_EXTRA_SIZE,
> + system_parm, 6);
> if (retval != STATUS_SUCCESS)
> return STATUS_FAIL;
>
> @@ -1465,8 +1465,8 @@ static int ms_set_bad_block(struct rtsx_chip *chip, u16
> phy_blk)
> if (retval != STATUS_SUCCESS)
> return STATUS_FAIL;
>
> - retval = ms_set_rw_reg_addr(chip, OverwriteFlag, MS_EXTRA_SIZE,
> - SystemParm, 7);
> + retval = ms_set_rw_reg_addr(chip, overwrite_flag, MS_EXTRA_SIZE,
> + system_parm, 7);
> if (retval != STATUS_SUCCESS)
> return STATUS_FAIL;
>
> @@ -1519,8 +1519,8 @@ static int ms_erase_block(struct rtsx_chip *chip, u16
> phy_blk)
> int retval, i = 0;
> u8 val, data[6];
>
> - retval = ms_set_rw_reg_addr(chip, OverwriteFlag, MS_EXTRA_SIZE,
> - SystemParm, 6);
> + retval = ms_set_rw_reg_addr(chip, overwrite_flag,
Re: [Outreachy kernel] [PATCH v3 2/3] staging: rts5208: Eliminate the use of Camel Case in files xd.{h,c}
On Wed, 30 Oct 2019, Gabriela Bittencourt wrote:
> Cleans up checks of "Avoid CamelCase" in files xd.{h,c}
>
> Signed-off-by: Gabriela Bittencourt
Acked-by: Julia Lawall
> ---
> drivers/staging/rts5208/xd.c | 8
> drivers/staging/rts5208/xd.h | 6 +++---
> 2 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/staging/rts5208/xd.c b/drivers/staging/rts5208/xd.c
> index f3dc96a4c59d..0f369935fb6c 100644
> --- a/drivers/staging/rts5208/xd.c
> +++ b/drivers/staging/rts5208/xd.c
> @@ -630,13 +630,13 @@ static int reset_xd(struct rtsx_chip *chip)
> xd_card->zone_cnt = 32;
> xd_card->capacity = 1024000;
> break;
> - case xD_1G_X8_512:
> + case XD_1G_X8_512:
> XD_PAGE_512(xd_card);
> xd_card->addr_cycle = 4;
> xd_card->zone_cnt = 64;
> xd_card->capacity = 2048000;
> break;
> - case xD_2G_X8_512:
> + case XD_2G_X8_512:
> XD_PAGE_512(xd_card);
> xd_card->addr_cycle = 4;
> xd_card->zone_cnt = 128;
> @@ -669,10 +669,10 @@ static int reset_xd(struct rtsx_chip *chip)
> return STATUS_FAIL;
> }
>
> - retval = xd_read_id(chip, READ_xD_ID, id_buf, 4);
> + retval = xd_read_id(chip, READ_XD_ID, id_buf, 4);
> if (retval != STATUS_SUCCESS)
> return STATUS_FAIL;
> - dev_dbg(rtsx_dev(chip), "READ_xD_ID: 0x%x 0x%x 0x%x 0x%x\n",
> + dev_dbg(rtsx_dev(chip), "READ_XD_ID: 0x%x 0x%x 0x%x 0x%x\n",
> id_buf[0], id_buf[1], id_buf[2], id_buf[3]);
> if (id_buf[2] != XD_ID_CODE)
> return STATUS_FAIL;
> diff --git a/drivers/staging/rts5208/xd.h b/drivers/staging/rts5208/xd.h
> index 57b94129b26f..98c00f268e56 100644
> --- a/drivers/staging/rts5208/xd.h
> +++ b/drivers/staging/rts5208/xd.h
> @@ -36,7 +36,7 @@
> #define BLK_ERASE_1 0x60
> #define BLK_ERASE_2 0xD0
> #define READ_STS 0x70
> -#define READ_xD_ID 0x9A
> +#define READ_XD_ID 0x9A
> #define COPY_BACK_512 0x8A
> #define COPY_BACK_2K0x85
> #define READ1_1_2 0x30
> @@ -72,8 +72,8 @@
> #define XD_128M_X16_20480xC1
> #define XD_4M_X8_512_1 0xE3
> #define XD_4M_X8_512_2 0xE5
> -#define xD_1G_X8_5120xD3
> -#define xD_2G_X8_5120xD5
> +#define XD_1G_X8_5120xD3
> +#define XD_2G_X8_5120xD5
>
> #define XD_ID_CODE 0xB5
>
> --
> 2.20.1
>
> --
> You received this message because you are subscribed to the Google Groups
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to outreachy-kernel+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/outreachy-kernel/20191030190514.10011-3-gabrielabittencourt00%40gmail.com.
>
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [Outreachy kernel] [PATCH v3 3/3] staging: rts5208: Eliminate the use of Camel Case in file sd.h
On Wed, 30 Oct 2019, Gabriela Bittencourt wrote: > Cleans up checks of "Avoid CamelCase" in file sd.h > > Signed-off-by: Gabriela Bittencourt > --- > drivers/staging/rts5208/sd.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/rts5208/sd.h b/drivers/staging/rts5208/sd.h > index dc9e8cad7a74..f4ff62653b56 100644 > --- a/drivers/staging/rts5208/sd.h > +++ b/drivers/staging/rts5208/sd.h > @@ -232,7 +232,7 @@ > #define DCM_LOW_FREQUENCY_MODE 0x01 > > #define DCM_HIGH_FREQUENCY_MODE_SET 0x0C > -#define DCM_Low_FREQUENCY_MODE_SET 0x00 > +#define DCM_LOW_FREQUENCY_MODE_SET 0x00 So this is never used in the kernel? In that case, maybe it would still be useful to keep it, because it somehow documents the device. But the log message should say that this is the case. julia > > #define MULTIPLY_BY_10x00 > #define MULTIPLY_BY_20x01 > -- > 2.20.1 > > -- > You received this message because you are subscribed to the Google Groups > "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to outreachy-kernel+unsubscr...@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/outreachy-kernel/20191030190514.10011-4-gabrielabittencourt00%40gmail.com. > ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
