[PATCH] Staging: comedi: comedi_fops: fixed a blank line coding style issue

Fixed a coding style issue. Signed-off-by: Tyler Shetrompf --- drivers/staging/comedi/comedi_fops.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c index e85a99b68f31..3f70e5dfac39 100644 ---

Re: Forest Bond ,Greg Kroah-Hartman , de...@driverdev.osuosl.org, linux-ker...@vger.kernel.org

On Mon, Jun 08, 2020 at 04:33:06PM -0700, Joe Perches wrote: > On Mon, 2020-06-08 at 22:58 +, Rodolfo C Villordo wrote: > > > > How should I move forward with this? > > > > 1 - Update this patch with the changes pointed by Dan Carpenter? > > Keep your changes small until you really know

Re: [PATCH v2 4/6] staging: greybus: audio: Resolve compilation error in topology parser

On Wed, Jun 10, 2020 at 08:45:35PM +0300, Dan Carpenter wrote: > On Wed, Jun 10, 2020 at 10:58:28PM +0530, Vaibhav Agarwal wrote: > > @@ -437,11 +433,12 @@ static int gbcodec_mixer_dapm_ctl_put(struct > > snd_kcontrol *kcontrol, > > struct gbaudio_module_info *module; > > struct

Re: [PATCH v2 0/6] Enable Greybus Audio codec driver

On Wed, Jun 10, 2020 at 06:37:11PM +0100, Mark Brown wrote: > On Wed, Jun 10, 2020 at 10:58:24PM +0530, Vaibhav Agarwal wrote: > > The existing GB Audio codec driver is dependent on MSM8994 Audio driver. > > During the development stage, this dependency was configured due to > > various changes

Re: [PATCH v2 0/6] Enable Greybus Audio codec driver

On 10/06/2020 18:37:11+0100, Mark Brown wrote: > On Wed, Jun 10, 2020 at 10:58:24PM +0530, Vaibhav Agarwal wrote: > > The existing GB Audio codec driver is dependent on MSM8994 Audio driver. > > During the development stage, this dependency was configured due to > > various changes involved in MSM

Re: [PATCH v2 0/6] Enable Greybus Audio codec driver

I love this patchset so much more... Thanks! Reviewed-by: Dan Carpenter regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v2 4/6] staging: greybus: audio: Resolve compilation error in topology parser

On Wed, Jun 10, 2020 at 10:58:28PM +0530, Vaibhav Agarwal wrote: > @@ -437,11 +433,12 @@ static int gbcodec_mixer_dapm_ctl_put(struct > snd_kcontrol *kcontrol, > struct gbaudio_module_info *module; > struct snd_soc_dapm_widget_list *wlist = snd_kcontrol_chip(kcontrol); > struct

[PATCH v2 4/6] staging: greybus: audio: Resolve compilation error in topology parser

Fix compilation errors for GB Audio topology parser code with recent kernel versions. Signed-off-by: Vaibhav Agarwal --- drivers/staging/greybus/audio_topology.c | 128 +++ 1 file changed, 60 insertions(+), 68 deletions(-) diff --git

[PATCH v2 5/6] staging: greybus: audio: Add helper APIs for dynamic audio modules

Greybus Codec driver allows modules to be dynamically added and removed, which further requires updating the DAPM configurations as well. With current snd_soc architecture, dynamic audio modules is not yet supported. This patch provides helper APIs to update DAPM configurations in response to

[PATCH v2 3/6] staging: greybus: audio: Resolve compilation errors for GB codec module

Due to dependencies on ASoC framework changes, GB dummy codec module compilation is currently disabled. This patch updates codec driver as per the latest ASoC APIs. Signed-off-by: Vaibhav Agarwal --- drivers/staging/greybus/audio_codec.c | 88 +--

[PATCH v2 6/6] staging: greybus: audio: Enable GB codec, audio module compilation.

Currently you can't enable the Gey Bus Audio Codec because there is no entry for it in the Kconfig file. Originally the config name was going to be AUDIO_MSM8994 but that's not correct because other types of hardware are supported now. I have chosen the name AUDIO_APB_CODEC instead. Also I had to

Re: [PATCH v2 0/6] Enable Greybus Audio codec driver

On Wed, Jun 10, 2020 at 10:58:24PM +0530, Vaibhav Agarwal wrote: > The existing GB Audio codec driver is dependent on MSM8994 Audio driver. > During the development stage, this dependency was configured due to > various changes involved in MSM Audio driver to enable addtional codec > card and some

[PATCH v2 1/6] staging: greybus: audio: Update snd_jack FW usage as per new APIs

snd_soc_jack APIs are modified in recent kernel versions. This patch updates the codec driver to resolve the compilation errors related to jack framework. Signed-off-by: Vaibhav Agarwal --- drivers/staging/greybus/audio_codec.c | 54 +-- 1 file changed, 42 insertions(+),

[PATCH v2 2/6] staging: greybus: audio: Maintain jack list within GB Audio module

As per the current implementation for GB codec driver, a jack list is maintained for each module. And it expects the list to be populated by the snd_soc_jack structure which would require modifications in mainstream code. However, this is not a necessary requirement and the list can be easily

[PATCH v2 0/6] Enable Greybus Audio codec driver

The existing GB Audio codec driver is dependent on MSM8994 Audio driver. During the development stage, this dependency was configured due to various changes involved in MSM Audio driver to enable addtional codec card and some of the changes proposed in mainline ASoC framework. However, these are

Re: [staging-testing] drivers/staging/wfx/hif_tx.c

On Wednesday 10 June 2020 08:53:13 CEST Mohamed Dawod wrote: > Hello, > > I read this point in staging/wfx/TODO file > > - In wfx_cmd_send(), "async" allow to send command without waiting the reply. > It may help in some situation, but it is not yet used. In add, it may > cause > some