Re: issue with uninitialized value used in a comparison in gbcodec_mixer_dapm_ctl_put

2020-07-30 Thread Vaibhav Agarwal
On Thu, Jul 30, 2020 at 05:02:22PM +0100, Colin Ian King wrote: > Hi, > > Static analysis with Coverity has detected an uninitialized value being > used in a comparison. The error was detected on a recent change to > drivers/staging/greybus/audio_topology.c however the issue actually > dates

Re: [PATCH v1] staging: fieldbus: Use %pM format specifier for MAC addresses

2020-07-30 Thread Sven Van Asbroeck
Hi Andy, thank you for the patch ! See below. On Thu, Jul 30, 2020 at 11:27 AM Andy Shevchenko wrote: > > -struct msg_mac_addr { > - u8 addr[6]; > -}; I would prefer to keep this structure. It's conceptually important, because it describes the binary layout of a message going to a

BUSINESS PROPOSAL

2020-07-30 Thread James kenneth
Hello, Apply for a loan, at a 3% interest rate. Do you need a personal loan? Do you need a business loan? Do you need a consolidation loan? Do you need a secure loan? Do you need an unsecured loan? Do you need a mortgage loan? Do you need a pay off debt loan?

Re: [PATCH 1/1] staging: android: ashmem: Fix lockdep warning for write operation

2020-07-30 Thread Suren Baghdasaryan
On Wed, Jul 29, 2020 at 8:24 PM Joel Fernandes wrote: > > On Wed, Jul 15, 2020 at 10:45 PM Suren Baghdasaryan wrote: > > > > syzbot report [1] describes a deadlock when write operation against an > > ashmem fd executed at the time when ashmem is shrinking its cache results > > in the following

[staging:staging-testing] BUILD SUCCESS d8a0f85d394a0cc5dec2b290ebcf8ed3cfdc1a70

2020-07-30 Thread kernel test robot
allnoconfig x86_64 randconfig-a001-20200730 x86_64 randconfig-a004-20200730 x86_64 randconfig-a002-20200730 x86_64 randconfig-a006-20200730 x86_64 randconfig-a003-20200730 x86_64 randconfig-a005-20200730 i386

Re: [PATCH] sched: Provide USF for the portable equipment.

2020-07-30 Thread Steven Rostedt
On Thu, 30 Jul 2020 21:35:43 +0800 Dongdong Yang wrote: I'll let others decide the value of this, but I have some comments. > > Signed-off-by: Dongdong Yang > Signed-off-by: Jun Tao > Signed-off-by: Qiwu Huang > Signed-off-by: Geliang Tang > Signed-off-by: Peng Wang Why all the

[PATCH v2] staging: atomisp: move null check to earlier point

2020-07-30 Thread Cengiz Can
`find_gmin_subdev` function that returns a pointer to `struct gmin_subdev` can return NULL. In `gmin_v2p8_ctrl` there's a call to this function but the possibility of a NULL was not checked before its being dereferenced. ie: ``` /* Acquired here v */ struct gmin_subdev *gs =

Re: [PATCH v9 08/12] device core: Introduce DMA range map, supplanting dma_pfn_offset

2020-07-30 Thread Jim Quinlan
On Thu, Jul 30, 2020 at 1:05 PM Nicolas Saenz Julienne wrote: > > Hi Jim, > > On Fri, 2020-07-24 at 16:33 -0400, Jim Quinlan wrote: > > static void __init of_unittest_pci_dma_ranges(void) > > diff --git a/drivers/pci/controller/pcie-brcmstb.c > > b/drivers/pci/controller/pcie-brcmstb.c > >

[PATCH] PCI: Rename d3_delay in the pci_dev struct to align with PCI specification

2020-07-30 Thread Krzysztof Wilczyński
Rename PCI-related variable "d3_delay" to "d3hot_delay" in the pci_dev struct to better align with the PCI Firmware specification (see PCI Firmware Specification, Revision 3.2, Section 4.6.9, p. 73). The pci_dev struct already contains variable "d3cold_delay", thus renaming "d3_delay" to

Re: [PATCH v9 08/12] device core: Introduce DMA range map, supplanting dma_pfn_offset

2020-07-30 Thread Jim Quinlan
On Wed, Jul 29, 2020 at 10:28 AM Rob Herring wrote: > > On Wed, Jul 29, 2020 at 12:19 AM Christoph Hellwig wrote: > > > > On Tue, Jul 28, 2020 at 02:24:51PM -0400, Jim Quinlan wrote: > > > I started using devm_kcalloc() but at least two reviewers convinced me > > > to just use kcalloc(). In

Re: [PATCH 0/3] Modernize tasklet callback API

2020-07-30 Thread Kees Cook
[heavily trimmed CC list because I think lkml is ignoring this thread...] On Thu, Jul 30, 2020 at 09:03:55AM +0200, Thomas Gleixner wrote: > Kees, > > Kees Cook writes: > > This is the infrastructure changes to prepare the tasklet API for > > conversion to passing the tasklet struct as the

MY LOVE,

2020-07-30 Thread lina williams
MY LOVE, My name is Lina Williams There is my email ( linawilliams...@yahoo.com ) I pick interest on you. I will like to establish with you. I will introduce myself better and send you my picture as soon as I receive your reply. I am looking to read from you as soon as possible. Thanks.lL

Re: [PATCH v1] staging: fieldbus: Use %pM format specifier for MAC addresses

2020-07-30 Thread kernel test robot
Hi Andy, I love your patch! Yet something to improve: [auto build test ERROR on staging/staging-testing] url: https://github.com/0day-ci/linux/commits/Andy-Shevchenko/staging-fieldbus-Use-pM-format-specifier-for-MAC-addresses/20200730-232835 base: https://git.kernel.org/pub/scm/linux

Re: [PATCH v9 08/12] device core: Introduce DMA range map, supplanting dma_pfn_offset

2020-07-30 Thread Nicolas Saenz Julienne
On Thu, 2020-07-30 at 13:25 -0400, Jim Quinlan wrote: > On Thu, Jul 30, 2020 at 1:05 PM Nicolas Saenz Julienne > wrote: > > Hi Jim, > > > > On Fri, 2020-07-24 at 16:33 -0400, Jim Quinlan wrote: > > > static void __init of_unittest_pci_dma_ranges(void) > > > diff --git

Re: [PATCH v9 08/12] device core: Introduce DMA range map, supplanting dma_pfn_offset

2020-07-30 Thread Nicolas Saenz Julienne
Hi Jim, On Fri, 2020-07-24 at 16:33 -0400, Jim Quinlan wrote: > static void __init of_unittest_pci_dma_ranges(void) > diff --git a/drivers/pci/controller/pcie-brcmstb.c > b/drivers/pci/controller/pcie-brcmstb.c > index bfc2542d54a8..8dacb9d3b7b6 100644 > ---

Re: [PATCH v9 08/12] device core: Introduce DMA range map, supplanting dma_pfn_offset

2020-07-30 Thread Nicolas Saenz Julienne
On Thu, 2020-07-30 at 12:44 -0400, Jim Quinlan wrote: > On Wed, Jul 29, 2020 at 10:28 AM Rob Herring wrote: > > On Wed, Jul 29, 2020 at 12:19 AM Christoph Hellwig wrote: > > > On Tue, Jul 28, 2020 at 02:24:51PM -0400, Jim Quinlan wrote: > > > > I started using devm_kcalloc() but at least two

[PATCH v6] drivers: most: add USB adapter driver

2020-07-30 Thread Christian Gromm
This patch adds the USB driver source file most_usb.c and modifies the Makefile and Kconfig accordingly. Signed-off-by: Christian Gromm --- v2: Reported-by: Greg Kroah-Hartman - don't remove usb driver from staging area - don't touch staging/most/Kconfig - remove

issue with uninitialized value used in a comparison in gbcodec_mixer_dapm_ctl_put

2020-07-30 Thread Colin Ian King
Hi, Static analysis with Coverity has detected an uninitialized value being used in a comparison. The error was detected on a recent change to drivers/staging/greybus/audio_topology.c however the issue actually dates back to the original commit: commit 6339d2322c47f4b8ebabf9daf0130328ed72648b

[PATCH v1] staging: fieldbus: Use %pM format specifier for MAC addresses

2020-07-30 Thread Andy Shevchenko
Convert to %pM instead of using custom code. While here, replace one time use structure by buffer on stack. Signed-off-by: Andy Shevchenko --- drivers/staging/fieldbus/anybuss/hms-profinet.c | 14 +++--- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git

[PATCH v1] staging: ks7010: Use %pM format specifier for MAC addresses

2020-07-30 Thread Andy Shevchenko
Convert to %pM instead of using custom code. Signed-off-by: Andy Shevchenko --- drivers/staging/ks7010/ks_hostif.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c index

[PATCH v1] staging: most: Use %pM format specifier for MAC addresses

2020-07-30 Thread Andy Shevchenko
Convert to %pM instead of using custom code. Signed-off-by: Andy Shevchenko --- drivers/staging/most/net/net.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/most/net/net.c b/drivers/staging/most/net/net.c index 830f089f1a88..b6fecb06a0e6 100644 ---

[PATCH] sched: Provide USF for the portable equipment.

2020-07-30 Thread Dongdong Yang
From: Dongdong Yang The power consumption and UI response are more cared for by the portable equipment users. USF(User Sensitive Feedback factor) auxiliary cpufreq governor is providing more utils adjustment settings to a high level by scenario identification. From the view of portable

[PATCH] sched: Provide USF for the portable equipment.

2020-07-30 Thread Dongdong Yang
From: Dongdong Yang This patch provides USF(User Sensitive Feedback factor) auxiliary cpufreq governor to support high level layer sysfs inodes setting for utils adjustment purpose from the identified scenario on portable equipment. Because the power consumption and UI response are more cared

Re: [PATCH v2] binder: Prevent context manager from incrementing ref 0

2020-07-30 Thread Sasha Levin
Hi [This is an automated email] This commit has been processed because it contains a "Fixes:" tag fixing commit: 457b9a6f09f0 ("Staging: android: add binder driver"). The bot has tested the following trees: v5.7.11, v5.4.54, v4.19.135, v4.14.190, v4.9.231, v4.4.231. v5.7.11: Build OK!

Re: [PATCH] staging: most: usb: rename most_usb.ko

2020-07-30 Thread Christian.Gromm
On Wed, 2020-07-29 at 19:03 +0200, Greg KH wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you > know the content is safe > > On Wed, Jul 29, 2020 at 06:38:48PM +0200, Christian Gromm wrote: > > To avoid a name conflict when adding the usb module to the > > driver's

Hello

2020-07-30 Thread Tony Ray
I sent you a mesaage,did you receive that?Please let me know. Tony ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

KASAN: slab-out-of-bounds Read in prism2sta_probe_usb

2020-07-30 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:e3ee0e74 usb: common: usb-conn-gpio: Register charger git tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing console output: https://syzkaller.appspot.com/x/log.txt?x=14ff152490 kernel config:

Re: [PATCH] staging: atomisp: move null check to earlier point

2020-07-30 Thread Cengiz Can
On July 30, 2020 11:48:06 Dan Carpenter wrote: On Wed, Jul 29, 2020 at 06:13:44PM +0300, Andy Shevchenko wrote: On Wed, Jul 29, 2020 at 5:00 PM Cengiz Can wrote: `find_gmin_subdev` function that returns a pointer to `struct gmin_subdev` can return NULL. In `gmin_v2p8_ctrl` there's a

Re: [PATCH] staging: most: usb: rename most_usb.ko

2020-07-30 Thread Greg KH
On Thu, Jul 30, 2020 at 08:27:29AM +, christian.gr...@microchip.com wrote: > On Wed, 2020-07-29 at 19:03 +0200, Greg KH wrote: > > EXTERNAL EMAIL: Do not click links or open attachments unless you > > know the content is safe > > > > On Wed, Jul 29, 2020 at 06:38:48PM +0200, Christian Gromm

Re: [PATCH] staging: atomisp: move null check to earlier point

2020-07-30 Thread Dan Carpenter
On Wed, Jul 29, 2020 at 06:13:44PM +0300, Andy Shevchenko wrote: > On Wed, Jul 29, 2020 at 5:00 PM Cengiz Can wrote: > > > > `find_gmin_subdev` function that returns a pointer to `struct > > gmin_subdev` can return NULL. > > > > In `gmin_v2p8_ctrl` there's a call to this function but the

Re: [PATCH 0/3] Modernize tasklet callback API

2020-07-30 Thread Thomas Gleixner
Kees, Kees Cook writes: > This is the infrastructure changes to prepare the tasklet API for > conversion to passing the tasklet struct as the callback argument instead > of an arbitrary unsigned long. The first patch details why this is useful > (it's the same rationale as the timer_struct