Re: [PATCH v2 1/3] staging: greybus: fix warnings about endianness detected by sparse
On Tue, Oct 06, 2020 at 12:47:37AM +0530, Vaibhav Agarwal wrote: On Sat, Oct 3, 2020 at 5:01 AM Coiby Xu wrote: This patch fix the following warnings from sparse, $ make C=2 drivers/staging/greybus/ drivers/staging/greybus/audio_module.c:222:25: warning: incorrect type in assignment (different base types) drivers/staging/greybus/audio_module.c:222:25:expected restricted __le16 [usertype] data_cport drivers/staging/greybus/audio_module.c:222:25:got unsigned short [usertype] intf_cport_id drivers/staging/greybus/audio_topology.c:460:40: warning: restricted __le32 degrades to integer drivers/staging/greybus/audio_topology.c:691:41: warning: incorrect type in assignment (different base types) drivers/staging/greybus/audio_topology.c:691:41:expected unsigned int access drivers/staging/greybus/audio_topology.c:691:41:got restricted __le32 [usertype] access drivers/staging/greybus/audio_topology.c:746:44: warning: incorrect type in assignment (different base types) drivers/staging/greybus/audio_topology.c:746:44:expected unsigned int drivers/staging/greybus/audio_topology.c:746:44:got restricted __le32 drivers/staging/greybus/audio_topology.c:748:52: warning: incorrect type in assignment (different base types) drivers/staging/greybus/audio_topology.c:748:52:expected unsigned int drivers/staging/greybus/audio_topology.c:748:52:got restricted __le32 drivers/staging/greybus/audio_topology.c:802:42: warning: restricted __le32 degrades to integer drivers/staging/greybus/audio_topology.c:805:50: warning: incorrect type in assignment (different base types) drivers/staging/greybus/audio_topology.c:805:50:expected restricted __le32 drivers/staging/greybus/audio_topology.c:805:50:got unsigned int drivers/staging/greybus/audio_topology.c:814:50: warning: restricted __le32 degrades to integer drivers/staging/greybus/audio_topology.c:817:58: warning: incorrect type in assignment (different base types) drivers/staging/greybus/audio_topology.c:817:58:expected restricted __le32 drivers/staging/greybus/audio_topology.c:817:58:got unsigned int drivers/staging/greybus/audio_topology.c:889:25: warning: incorrect type in assignment (different base types) drivers/staging/greybus/audio_topology.c:889:25:expected unsigned int access drivers/staging/greybus/audio_topology.c:889:25:got restricted __le32 [usertype] access Suggested-by: Dan Carpenter Reviewed-by: Dan Carpenter Reviewed-by: Alex Elder Signed-off-by: Coiby Xu --- Hi Coiby, Thanks for sharing the patch. Sorry, I could not reply to the v1 series. Now, I have gone through the patches. Looks good (all 3 patches). Reviewed-by: Vaibhav Agarwal -- Thanks, Hi Vaibhav, Thank you for reviewing these patches and giving the credit! -- Best regards, Coiby ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[staging:staging-testing] BUILD SUCCESS 6c75a92a0065a009429cec2c69f922f07cbbcd1e
defconfig alphaallyesconfig xtensa allyesconfig h8300allyesconfig arc defconfig s390 allyesconfig parisc allyesconfig s390defconfig i386 allyesconfig sparcallyesconfig sparc defconfig i386defconfig mips allyesconfig mips allmodconfig powerpc allyesconfig powerpc allnoconfig i386 randconfig-a006-20201005 i386 randconfig-a005-20201005 i386 randconfig-a001-20201005 i386 randconfig-a004-20201005 i386 randconfig-a003-20201005 i386 randconfig-a002-20201005 x86_64 randconfig-a012-20201005 x86_64 randconfig-a015-20201005 x86_64 randconfig-a014-20201005 x86_64 randconfig-a013-20201005 x86_64 randconfig-a011-20201005 x86_64 randconfig-a016-20201005 i386 randconfig-a014-20201005 i386 randconfig-a015-20201005 i386 randconfig-a013-20201005 i386 randconfig-a016-20201005 i386 randconfig-a011-20201005 i386 randconfig-a012-20201005 i386 randconfig-a014-20201004 i386 randconfig-a015-20201004 i386 randconfig-a013-20201004 i386 randconfig-a016-20201004 i386 randconfig-a011-20201004 i386 randconfig-a012-20201004 riscvnommu_k210_defconfig riscvallyesconfig riscvnommu_virt_defconfig riscv allnoconfig riscv defconfig riscvallmodconfig x86_64 rhel x86_64 allyesconfig x86_64rhel-7.6-kselftests x86_64 rhel-8.3 x86_64 kexec clang tested configs: x86_64 randconfig-a004-20201005 x86_64 randconfig-a002-20201005 x86_64 randconfig-a001-20201005 x86_64 randconfig-a003-20201005 x86_64 randconfig-a005-20201005 x86_64 randconfig-a006-20201005 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[staging:staging-next] BUILD SUCCESS a944a1fb9a8286fb9e4bbd0180ebd53353c7f412
defconfig i386 allyesconfig sparcallyesconfig sparc defconfig i386defconfig mips allyesconfig mips allmodconfig powerpc allyesconfig i386 randconfig-a006-20201005 i386 randconfig-a005-20201005 i386 randconfig-a001-20201005 i386 randconfig-a004-20201005 i386 randconfig-a003-20201005 i386 randconfig-a002-20201005 x86_64 randconfig-a012-20201005 x86_64 randconfig-a015-20201005 x86_64 randconfig-a014-20201005 x86_64 randconfig-a013-20201005 x86_64 randconfig-a011-20201005 x86_64 randconfig-a016-20201005 i386 randconfig-a014-20201005 i386 randconfig-a015-20201005 i386 randconfig-a013-20201005 i386 randconfig-a016-20201005 i386 randconfig-a011-20201005 i386 randconfig-a012-20201005 riscvnommu_k210_defconfig riscvallyesconfig riscv allnoconfig riscv defconfig riscvallmodconfig x86_64 rhel x86_64 allyesconfig x86_64rhel-7.6-kselftests x86_64 defconfig x86_64 rhel-8.3 x86_64 kexec clang tested configs: x86_64 randconfig-a004-20201005 x86_64 randconfig-a002-20201005 x86_64 randconfig-a001-20201005 x86_64 randconfig-a003-20201005 x86_64 randconfig-a005-20201005 x86_64 randconfig-a006-20201005 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[staging:ion_removal] BUILD SUCCESS f6ecd19b143570a06987d40b15d78f8ffcbe5d0c
apsh4ad0a_defconfig mips mpc30x_defconfig armspear3xx_defconfig riscvnommu_virt_defconfig armdove_defconfig sh se7619_defconfig mips maltasmvp_eva_defconfig powerpc mpc834x_itxgp_defconfig s390 alldefconfig arm h5000_defconfig arm integrator_defconfig arm orion5x_defconfig ia64 allmodconfig ia64defconfig m68k allmodconfig m68kdefconfig m68k allyesconfig nios2 defconfig arc allyesconfig c6x allyesconfig nios2allyesconfig cskydefconfig alpha defconfig alphaallyesconfig xtensa allyesconfig arc defconfig sh allmodconfig parisc defconfig s390 allyesconfig parisc allyesconfig s390defconfig i386 allyesconfig sparcallyesconfig sparc defconfig i386defconfig mips allyesconfig mips allmodconfig powerpc allyesconfig i386 randconfig-a006-20201005 i386 randconfig-a005-20201005 i386 randconfig-a001-20201005 i386 randconfig-a004-20201005 i386 randconfig-a003-20201005 i386 randconfig-a002-20201005 x86_64 randconfig-a012-20201005 x86_64 randconfig-a015-20201005 x86_64 randconfig-a014-20201005 x86_64 randconfig-a013-20201005 x86_64 randconfig-a011-20201005 x86_64 randconfig-a016-20201005 i386 randconfig-a014-20201005 i386 randconfig-a015-20201005 i386 randconfig-a013-20201005 i386 randconfig-a016-20201005 i386 randconfig-a011-20201005 i386 randconfig-a012-20201005 riscvnommu_k210_defconfig riscvallyesconfig riscv allnoconfig riscv defconfig riscvallmodconfig x86_64 rhel x86_64 allyesconfig x86_64rhel-7.6-kselftests x86_64 defconfig x86_64 rhel-8.3 x86_64 kexec clang tested configs: x86_64 randconfig-a004-20201005 x86_64 randconfig-a002-20201005 x86_64 randconfig-a001-20201005 x86_64 randconfig-a003-20201005 x86_64 randconfig-a005-20201005 x86_64 randconfig-a006-20201005 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v2 1/3] staging: greybus: fix warnings about endianness detected by sparse
On Sat, Oct 3, 2020 at 5:01 AM Coiby Xu wrote: > > This patch fix the following warnings from sparse, > > $ make C=2 drivers/staging/greybus/ > drivers/staging/greybus/audio_module.c:222:25: warning: incorrect type in > assignment (different base types) > drivers/staging/greybus/audio_module.c:222:25:expected restricted __le16 > [usertype] data_cport > drivers/staging/greybus/audio_module.c:222:25:got unsigned short > [usertype] intf_cport_id > drivers/staging/greybus/audio_topology.c:460:40: warning: restricted __le32 > degrades to integer > drivers/staging/greybus/audio_topology.c:691:41: warning: incorrect type in > assignment (different base types) > drivers/staging/greybus/audio_topology.c:691:41:expected unsigned int > access > drivers/staging/greybus/audio_topology.c:691:41:got restricted __le32 > [usertype] access > drivers/staging/greybus/audio_topology.c:746:44: warning: incorrect type in > assignment (different base types) > drivers/staging/greybus/audio_topology.c:746:44:expected unsigned int > drivers/staging/greybus/audio_topology.c:746:44:got restricted __le32 > drivers/staging/greybus/audio_topology.c:748:52: warning: incorrect type in > assignment (different base types) > drivers/staging/greybus/audio_topology.c:748:52:expected unsigned int > drivers/staging/greybus/audio_topology.c:748:52:got restricted __le32 > drivers/staging/greybus/audio_topology.c:802:42: warning: restricted __le32 > degrades to integer > drivers/staging/greybus/audio_topology.c:805:50: warning: incorrect type in > assignment (different base types) > drivers/staging/greybus/audio_topology.c:805:50:expected restricted __le32 > drivers/staging/greybus/audio_topology.c:805:50:got unsigned int > drivers/staging/greybus/audio_topology.c:814:50: warning: restricted __le32 > degrades to integer > drivers/staging/greybus/audio_topology.c:817:58: warning: incorrect type in > assignment (different base types) > drivers/staging/greybus/audio_topology.c:817:58:expected restricted __le32 > drivers/staging/greybus/audio_topology.c:817:58:got unsigned int > drivers/staging/greybus/audio_topology.c:889:25: warning: incorrect type in > assignment (different base types) > drivers/staging/greybus/audio_topology.c:889:25:expected unsigned int > access > drivers/staging/greybus/audio_topology.c:889:25:got restricted __le32 > [usertype] access > > Suggested-by: Dan Carpenter > Reviewed-by: Dan Carpenter > Reviewed-by: Alex Elder > Signed-off-by: Coiby Xu > --- Hi Coiby, Thanks for sharing the patch. Sorry, I could not reply to the v1 series. Now, I have gone through the patches. Looks good (all 3 patches). Reviewed-by: Vaibhav Agarwal -- Thanks, ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH][next] media: zoran: fix spelling mistake and make error message more meaningful
On Fri, Oct 02, 2020 at 11:16:20AM +0100, Colin King wrote:
> From: Colin Ian King
>
> There is a spelling mistake in a pci_err error message. Fix this and
> make the error message a little more meaningful.
>
> Signed-off-by: Colin Ian King
> ---
> drivers/staging/media/zoran/zoran_driver.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/zoran/zoran_driver.c
> b/drivers/staging/media/zoran/zoran_driver.c
> index 808196ea5b81..d9f8b21edf6a 100644
> --- a/drivers/staging/media/zoran/zoran_driver.c
> +++ b/drivers/staging/media/zoran/zoran_driver.c
> @@ -666,7 +666,7 @@ static int zoran_g_selection(struct file *file, void
> *__fh, struct v4l2_selectio
>
> if (sel->type != V4L2_BUF_TYPE_VIDEO_OUTPUT &&
> sel->type != V4L2_BUF_TYPE_VIDEO_CAPTURE) {
> - pci_err(zr->pci_dev, "%s invalid combinaison\n", __func__);
> + pci_err(zr->pci_dev, "%s invalid selection type combination\n",
> __func__);
> return -EINVAL;
> }
>
> --
> 2.27.0
>
Hello
Acked-by: Corentin Labbe
Thanks
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] media: staging: atomisp: Fixed allignment to match open parenthesis
Moved the parameters of the function '__gc0310_write_reg_is_consecutive'
to the right under open parenthesis to fix warning message from
checkpatch.pl: 'CHECK: Alignment should match open parenthesis'.
Signed-off-by: Leonid Kushnir
---
drivers/staging/media/atomisp/i2c/atomisp-gc0310.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/media/atomisp/i2c/atomisp-gc0310.c
b/drivers/staging/media/atomisp/i2c/atomisp-gc0310.c
index 2b71de722ec3..6be3ee1d93a5 100644
--- a/drivers/staging/media/atomisp/i2c/atomisp-gc0310.c
+++ b/drivers/staging/media/atomisp/i2c/atomisp-gc0310.c
@@ -192,8 +192,8 @@ static int __gc0310_buf_reg_array(struct i2c_client *client,
}
static int __gc0310_write_reg_is_consecutive(struct i2c_client *client,
- struct gc0310_write_ctrl *ctrl,
- const struct gc0310_reg *next)
+struct gc0310_write_ctrl *ctrl,
+const struct gc0310_reg *next)
{
if (ctrl->index == 0)
return 1;
--
2.25.1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
