On Thu, Feb 11, 2021 at 12:40:41AM +0530, karthik alapati wrote:
> @@ -867,10 +845,8 @@ static void PHY_HandleSwChnlAndSetBW8723B(
> if (bSetBandWidth)
> pHalData->bSetChnlBW = true;
>
> - if (!pHalData->bSetChnlBW && !pHalData->bSwChnl) {
> - /* DBG_871X("<=
On Thu, Feb 11, 2021 at 12:40:41AM +0530, karthik alapati wrote:
> fix some checkpatch "Block comments use * on subsequent lines"
> warnings and remove obsolete code
>
This isn't the correct commit message. It should say something like:
"There is a bunch of messy, commented out code. Just
On Thu, Feb 11, 2021 at 12:49:30AM +0530, karthek wrote:
> Hey dan,
> check this out too
I have no idea what you're talking about.
Anyway, I just read my inbox in chronological order. That means I tend
to send my replies before reading Greg's comments and before seeing the
v2 patches. Just be
On Thu, Feb 11, 2021 at 11:08:19AM +0530, Amey Narkhede wrote:
> Stack allocated buffers cannot be used for DMA
> on all architectures so allocate hci_packet buffer
> using kmalloc.
>
> Signed-off-by: Amey Narkhede
Looks good.
Reviewed-by: Dan Carpenter
regards,
dan carpenter
On Thu, Feb 11, 2021 at 12:16:45PM +0530, Aakash Hemadri wrote:
> On 21/02/10 06:50PM, Greg Kroah-Hartman wrote:
> > On Wed, Feb 10, 2021 at 06:42:07PM +0800, Yujia Qiao wrote:
> > > Replace camel case variable names with snake case in baseband.c.
> > >
> > > Signed-off-by: Yujia Qiao
> > > ---
>
On Thursday, 11 February 2021 14:46:45 CST Aakash Hemadri wrote:
> When I first encountered the CamelCase check I believed that
> making such changes would only cause trouble for others.
>
> Are such changes to API welcome in the kernel?
I think it's not about changing the API here. A static
On 21/02/11 09:25AM, Fatih YILDIRIM wrote:
> Signed-off-by: Fatih YILDIRIM
> ---
> Hi,
> I have a coding style fix.
> By the way, I'm following the Eudyptula Challenge Linux kernel tasks
> and this is my first patch related to my task no 10.
> I hope I'm doing it the right way.
> Thanks for your
On 21/02/10 06:50PM, Greg Kroah-Hartman wrote:
> On Wed, Feb 10, 2021 at 06:42:07PM +0800, Yujia Qiao wrote:
> > Replace camel case variable names with snake case in baseband.c.
> >
> > Signed-off-by: Yujia Qiao
> > ---
> > drivers/staging/vt6655/baseband.c | 4 ++--
> > 1 file changed, 2
On Thu, Feb 11, 2021 at 09:25:43AM +0300, Fatih YILDIRIM wrote:
> Signed-off-by: Fatih YILDIRIM
> ---
> Hi,
> I have a coding style fix.
> By the way, I'm following the Eudyptula Challenge Linux kernel tasks
> and this is my first patch related to my task no 10.
> I hope I'm doing it the right
On Thu, Feb 11, 2021 at 01:14:39AM +0300, Fatih YILDIRIM wrote:
> Signed-off-by: Fatih YILDIRIM
> ---
> drivers/staging/greybus/loopback.c | 10 ++
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/greybus/loopback.c
>
Signed-off-by: Fatih YILDIRIM
---
Hi,
I have a coding style fix.
By the way, I'm following the Eudyptula Challenge Linux kernel tasks
and this is my first patch related to my task no 10.
I hope I'm doing it the right way.
Thanks for your understanding and kind comments.
Stack allocated buffers cannot be used for DMA
on all architectures so allocate hci_packet buffer
using kmalloc.
Signed-off-by: Amey Narkhede
---
Changes in v4:
- Use struct_size to allocate memory for hci_packet
- Fix memory corruption
drivers/staging/gdm724x/gdm_usb.c | 10
Replace camel case variable names with snake case in baseband.c.
Signed-off-by: Yujia Qiao
---
So I screwed up last two emails too. One with no subject and one with
the wrong commit message. This times...I hope it's the last email for
this patch. Sorry for the bother again.
CamelCase should be avoided for variable naming.
Signed-off-by: Yujia Qiao
---
drivers/staging/vt6655/baseband.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/vt6655/baseband.c
b/drivers/staging/vt6655/baseband.c
index 6b25d75d2501..1aa675241599 100644
Sorry for the bother. Last patch was word-wrapped and thus broken.
I hope this time I've done things right.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Hi Fatih,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on staging/staging-testing]
[also build test ERROR on v5.11-rc7 next-20210125]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as
There is a regular need in the kernel to provide a way to declare having
a dynamically sized set of trailing elements in a structure. Kernel code
should always use “flexible array members”[1] for these cases. The older
style of one-element or zero-length arrays should no longer be used[2].
Signed-off-by: Fatih YILDIRIM
---
drivers/staging/greybus/loopback.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/greybus/loopback.c
b/drivers/staging/greybus/loopback.c
index 2471448ba42a..c88ef3e894fa 100644
---
Hi,
I have a coding style fix in greybus subsystem.
By the way, I'm following the Eudyptula Challenge Linux kernel tasks and
this patch is related to my task no 10. I hope I'm doing it the right way.
Thanks for your understanding and kind comments.
Fatih YILDIRIM (1):
Macros with multiple
> > So I'm in the process of stripping out _dbgdump entirely as per Greg
> > K-H's suggestion - am I to understand raw printk is frowned upon though,
> > even with the correct KERN_x level specified?
>
> Yes. Ideally in drivers everything would use dev_dbg() and dev_err() or
> whatever. But
On Wed, Feb 10, 2021 at 06:55:44PM +, Phillip Potter wrote:
> > > diff --git a/drivers/staging/rtl8723bs/include/rtw_debug.h
> > > b/drivers/staging/rtl8723bs/include/rtw_debug.h
> > > index c90adfb87261..d06ac9540cf7 100644
> > > --- a/drivers/staging/rtl8723bs/include/rtw_debug.h
> > > +++
On Wed, Feb 10, 2021 at 06:55:44PM +, Phillip Potter wrote:
> On Wed, Feb 10, 2021 at 09:40:27PM +0300, Dan Carpenter wrote:
> > On Wed, Feb 10, 2021 at 05:00:03PM +, Phillip Potter wrote:
> > > Remove do/while loops from DBG_871X, MSG_8192C and DBG_8192C.
> >
> > I'm pretty hip to
Hey dan,
check this out too
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
check this out
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
fix some checkpatch "Block comments use * on subsequent lines"
warnings and remove obsolete code
Suggested-by: Dan Carpenter
Signed-off-by: karthik alapati
---
.../staging/rtl8723bs/hal/rtl8723b_phycfg.c | 44 ---
1 file changed, 9 insertions(+), 35 deletions(-)
diff --git
fix checkpatch.pl warning for "block comments should align the
* on each line" and make function comments follow kernel-doc
Signed-off-by: karthik alapati
---
.../staging/rtl8723bs/hal/rtl8723b_phycfg.c | 185 +++---
1 file changed, 73 insertions(+), 112 deletions(-)
diff --git
On Wed, Feb 10, 2021 at 09:40:27PM +0300, Dan Carpenter wrote:
> On Wed, Feb 10, 2021 at 05:00:03PM +, Phillip Potter wrote:
> > Remove do/while loops from DBG_871X, MSG_8192C and DBG_8192C.
>
> I'm pretty hip to checkpatch.pl warnings, but I had forgotten what the
> warning was for this:
>
On Wed, Feb 10, 2021 at 05:00:03PM +, Phillip Potter wrote:
> Remove do/while loops from DBG_871X, MSG_8192C and DBG_8192C.
I'm pretty hip to checkpatch.pl warnings, but I had forgotten what the
warning was for this:
WARNING: Single statement macros should not use a do {} while (0) loop
On Wed, Feb 10, 2021 at 06:42:07PM +0800, Yujia Qiao wrote:
> Replace camel case variable names with snake case in baseband.c.
>
> Signed-off-by: Yujia Qiao
> ---
> drivers/staging/vt6655/baseband.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
This doesn't apply cleanly to my
On Wed, Feb 10, 2021 at 05:34:38PM +, Phillip Potter wrote:
> On Wed, Feb 10, 2021 at 06:12:54PM +0100, Greg KH wrote:
> > On Wed, Feb 10, 2021 at 05:00:03PM +, Phillip Potter wrote:
> > > Remove do/while loops from DBG_871X, MSG_8192C and DBG_8192C. Also
> > > fix opening brace placements
On Wed, Feb 10, 2021 at 06:12:54PM +0100, Greg KH wrote:
> On Wed, Feb 10, 2021 at 05:00:03PM +, Phillip Potter wrote:
> > Remove do/while loops from DBG_871X, MSG_8192C and DBG_8192C. Also
> > fix opening brace placements and trailing single statement layout within
> > RT_PRINT_DATA, as well
On Wed, Feb 10, 2021 at 05:00:03PM +, Phillip Potter wrote:
> Remove do/while loops from DBG_871X, MSG_8192C and DBG_8192C. Also
> fix opening brace placements and trailing single statement layout within
> RT_PRINT_DATA, as well as making newline character placement more
> consistent and
On Wed, Feb 10, 2021 at 03:59:52PM +0100, Mairo Paul Rufus wrote:
> Signed-off-by: Mairo Paul Rufus
> ---
> drivers/staging/wlan-ng/p80211netdev.c | 2 +-
> drivers/staging/wlan-ng/prism2mib.c| 2 +-
> drivers/staging/wlan-ng/prism2sta.c| 4 ++--
> 3 files changed, 4 insertions(+), 4
Remove additional blank line from include/autoconf.h, fixes one
checkpatch check notice.
Signed-off-by: Phillip Potter
---
drivers/staging/rtl8723bs/include/autoconf.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtl8723bs/include/autoconf.h
Remove do/while loops from DBG_871X, MSG_8192C and DBG_8192C. Also
fix opening brace placements and trailing single statement layout within
RT_PRINT_DATA, as well as making newline character placement more
consistent and removing camel case where possible. Finally, add
parentheses for DBG_COUNTER
On 21/02/10 06:19PM, Dan Carpenter wrote:
> On Wed, Feb 10, 2021 at 08:31:33PM +0530, Amey Narkhede wrote:
> > On 21/02/10 03:55PM, Greg KH wrote:
> > > On Wed, Feb 10, 2021 at 07:55:12PM +0530, Amey Narkhede wrote:
> > > > Stack allocated buffers cannot be used for DMA
> > > > on all
On Tue, Feb 09, 2021 at 02:44:19PM +0100, Greg Kroah-Hartman wrote:
On Tue, Feb 09, 2021 at 02:39:41PM +0100, Hans Verkuil wrote:
On 09/02/2021 14:02, Greg Kroah-Hartman wrote:
> On Tue, Feb 09, 2021 at 01:45:35PM +0100, Dafna Hirschfeld wrote:
>>
>>
>> Am 08.02.21 um 21:46 schrieb Hans
On Wed, Feb 10, 2021 at 08:31:33PM +0530, Amey Narkhede wrote:
> On 21/02/10 03:55PM, Greg KH wrote:
> > On Wed, Feb 10, 2021 at 07:55:12PM +0530, Amey Narkhede wrote:
> > > Stack allocated buffers cannot be used for DMA
> > > on all architectures so allocate hci_packet buffer
> > > using kmalloc.
On 21/02/10 03:55PM, Greg KH wrote:
> On Wed, Feb 10, 2021 at 07:55:12PM +0530, Amey Narkhede wrote:
> > Stack allocated buffers cannot be used for DMA
> > on all architectures so allocate hci_packet buffer
> > using kmalloc.
> >
> > Signed-off-by: Amey Narkhede
> > ---
> > Changes in v3:
> >
Signed-off-by: Mairo Paul Rufus
---
drivers/staging/wlan-ng/p80211netdev.c | 2 +-
drivers/staging/wlan-ng/prism2mib.c| 2 +-
drivers/staging/wlan-ng/prism2sta.c| 4 ++--
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/wlan-ng/p80211netdev.c
On Wed, Feb 10, 2021 at 07:55:12PM +0530, Amey Narkhede wrote:
> Stack allocated buffers cannot be used for DMA
> on all architectures so allocate hci_packet buffer
> using kmalloc.
>
> Signed-off-by: Amey Narkhede
> ---
> Changes in v3:
> - Remove superfluous buf pointer
> - Reduce
Stack allocated buffers cannot be used for DMA
on all architectures so allocate hci_packet buffer
using kmalloc.
Signed-off-by: Amey Narkhede
---
Changes in v3:
- Remove superfluous buf pointer
- Reduce size of allocation of hci_packet to match number of
bytes used for
On 21/02/10 03:19PM, Dan Carpenter wrote:
> On Wed, Feb 10, 2021 at 05:33:48PM +0530, Aakash Hemadri wrote:
> > Remove CHECK: Lines should not end with a '('
> >
> > Signed-off-by: Aakash Hemadri
> > ---
> >
> > drivers/staging/ralink-gdma/ralink-gdma.c | 28 ---
> > 1 file
On Wed, Feb 10, 2021 at 05:33:48PM +0530, Aakash Hemadri wrote:
> Remove CHECK: Lines should not end with a '('
>
> Signed-off-by: Aakash Hemadri
> ---
>
> drivers/staging/ralink-gdma/ralink-gdma.c | 28 ---
> 1 file changed, 15 insertions(+), 13 deletions(-)
>
> diff
On Wed, Feb 10, 2021 at 05:33:48PM +0530, Aakash Hemadri wrote:
> Remove CHECK: Lines should not end with a '('
>
> Signed-off-by: Aakash Hemadri
> ---
>
> drivers/staging/ralink-gdma/ralink-gdma.c | 28 ---
> 1 file changed, 15 insertions(+), 13 deletions(-)
>
> diff
On Wed, Feb 10, 2021 at 02:38:28PM +0530, karthek wrote:
> On Wed, Feb 10, 2021, 2:31 PM Dan Carpenter
> wrote:
>
> > On Wed, Feb 10, 2021 at 02:28:31PM +0530, karthek wrote:
> > > On Wed, Feb 10, 2021 at 1:37 PM Dan Carpenter
> > wrote:
> > > > > @@ -789,7 +759,7 @@ static void
Remove CHECK: Lines should not end with a '('
Signed-off-by: Aakash Hemadri
---
drivers/staging/ralink-gdma/ralink-gdma.c | 28 ---
1 file changed, 15 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/ralink-gdma/ralink-gdma.c
On Mon, Feb 08, 2021 at 09:09:20PM +0800, Yicong Yang wrote:
> On 2021/2/8 18:47, Greg KH wrote:
> > On Mon, Feb 08, 2021 at 06:44:52PM +0800, Yicong Yang wrote:
> >> On 2021/2/5 17:53, Greg KH wrote:
> >>> What does this offer in benefit of the existing way? What is it fixing?
> >>> Why do this
On 21/02/10 10:09AM, Greg KH wrote:
> On Wed, Feb 10, 2021 at 02:28:11PM +0530, Amey Narkhede wrote:
> > On 21/02/10 09:06AM, Greg KH wrote:
> > > On Wed, Feb 10, 2021 at 01:31:34PM +0530, Amey Narkhede wrote:
> > > > Stack allocated buffers cannot be used for DMA
> > > > on all architectures so
On 21/02/10 12:04PM, Dan Carpenter wrote:
> On Wed, Feb 10, 2021 at 02:28:11PM +0530, Amey Narkhede wrote:
> > On 21/02/10 09:06AM, Greg KH wrote:
> > > On Wed, Feb 10, 2021 at 01:31:34PM +0530, Amey Narkhede wrote:
> > > > Stack allocated buffers cannot be used for DMA
> > > > on all
Replace camel case variable names with snake case in baseband.c.
Signed-off-by: Yujia Qiao
---
drivers/staging/vt6655/baseband.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/vt6655/baseband.c b/drivers/staging/vt6655/
baseband.c
index
On 2021/2/9 23:06, Guenter Roeck wrote:
> On Tue, Feb 09, 2021 at 07:08:17PM +0800, Yicong Yang wrote:
>> From: Junhao He
>>
>> We use ccflags-$(CONFIG_HWMON_DEBUG_CHIP) for the debug
>> message in drivers/hwmon, but the DEBUG flag will not pass to
>> the subdirectory.
>>
>> Considering
On Wed, Feb 10, 2021 at 02:38:28PM +0530, karthek wrote:
> On Wed, Feb 10, 2021, 2:31 PM Dan Carpenter
> wrote:
>
> > On Wed, Feb 10, 2021 at 02:28:31PM +0530, karthek wrote:
> > > On Wed, Feb 10, 2021 at 1:37 PM Dan Carpenter
> > wrote:
> > > > > @@ -789,7 +759,7 @@ static void
On Wed, Feb 10, 2021 at 02:28:11PM +0530, Amey Narkhede wrote:
> On 21/02/10 09:06AM, Greg KH wrote:
> > On Wed, Feb 10, 2021 at 01:31:34PM +0530, Amey Narkhede wrote:
> > > Stack allocated buffers cannot be used for DMA
> > > on all architectures so allocate hci_packet buffer
> > > using
On Wed, Feb 10, 2021 at 02:28:11PM +0530, Amey Narkhede wrote:
> On 21/02/10 09:06AM, Greg KH wrote:
> > On Wed, Feb 10, 2021 at 01:31:34PM +0530, Amey Narkhede wrote:
> > > Stack allocated buffers cannot be used for DMA
> > > on all architectures so allocate hci_packet buffer
> > > using
On Wed, Feb 10, 2021 at 02:28:31PM +0530, karthek wrote:
> On Wed, Feb 10, 2021 at 1:37 PM Dan Carpenter
> wrote:
> > > @@ -789,7 +759,7 @@ static void phy_PostSetBwMode8723B(struct adapter
> > > *Adapter)
> > >
> > > PHY_SetBBReg(Adapter, rFPGA1_RFMOD, bRFMOD, 0x0);
> > >
> > >
On Wed, Feb 10, 2021 at 1:37 PM Dan Carpenter wrote:
>
> On Wed, Feb 10, 2021 at 02:42:30AM +0530, karthik alapati wrote:
> > fix checkpatch.pl warning for "block comments should align the
> > * on each line" and make function comments follow kernel-doc
> >
> > Signed-off-by: karthik alapati
>
On 21/02/10 09:06AM, Greg KH wrote:
> On Wed, Feb 10, 2021 at 01:31:34PM +0530, Amey Narkhede wrote:
> > Stack allocated buffers cannot be used for DMA
> > on all architectures so allocate hci_packet buffer
> > using kzalloc().
> >
> > Signed-off-by: Amey Narkhede
> > ---
> > Changes in v2:
> >
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
staging-next
branch HEAD: 6953026f21092199a59f2c641a880b1c4025f932 staging: rtl8712: Remove
multiple blank lines
elapsed time: 727m
configs tested: 164
configs skipped: 2
The following configs have been built
On Wed, Feb 10, 2021 at 02:42:30AM +0530, karthik alapati wrote:
> fix checkpatch.pl warning for "block comments should align the
> * on each line" and make function comments follow kernel-doc
>
> Signed-off-by: karthik alapati
> ---
> .../staging/rtl8723bs/hal/rtl8723b_phycfg.c | 209
On Wed, Feb 10, 2021 at 01:31:34PM +0530, Amey Narkhede wrote:
> Stack allocated buffers cannot be used for DMA
> on all architectures so allocate hci_packet buffer
> using kzalloc().
>
> Signed-off-by: Amey Narkhede
> ---
> Changes in v2:
> - Fixed build warning
> - Fixed memory
Stack allocated buffers cannot be used for DMA
on all architectures so allocate hci_packet buffer
using kzalloc().
Signed-off-by: Amey Narkhede
---
Changes in v2:
- Fixed build warning
- Fixed memory leak using kfree
drivers/staging/gdm724x/gdm_usb.c | 9 +++--
1 file
62 matches
Mail list logo
