Re: [PATCH 2/2] staging: rtl8188eu: fix spaces instead of tabs for rtw_recv.c
On Fri, Apr 18, 2014 at 11:31:36PM +0200, Konrad Zapalowicz wrote: From: Konrad M Zapalowicz bergo.tor...@gmail.com This commit fixes the following checkpatch errors: rtl8188eu/core/rtw_recv.c - 1874: ERROR: code indent should use tabs where possible Signed-off-by: Konrad Zapalowicz bergo.torino at gmail.com As Dan pointed out, we need a real address here, use @ please. can you resend these? greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] Staging: crystalhd: Mark local functions as static
On Fri, Apr 18, 2014 at 07:57:51PM +0200, Bojan Prtvar wrote: This fixes the following sparse warnings: drivers/staging/crystalhd/crystalhd_lnx.c:631:5: warning: symbol 'chd_dec_pci_suspend' was not declared. Should it be static? drivers/staging/crystalhd/crystalhd_lnx.c:665:5: warning: symbol 'chd_dec_pci_resume' was not declared. Should it be static? drivers/staging/crystalhd/crystalhd_lnx.c:78:29: warning: symbol 'chd_dec_alloc_iodata' was not declared. Should it be static? drivers/staging/crystalhd/crystalhd_lnx.c:99:6: warning: symbol 'chd_dec_free_iodata' was not declared. Should it be static? Signed-off-by: Bojan Prtvar prtva...@gmail.com --- drivers/staging/crystalhd/crystalhd_lnx.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) This patch doesn't apply to my tree, can you redo it and resend? thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: r8192e_pci driver broken 3.14+
On Sat, Apr 19, 2014 at 02:12:34PM -0400, Sean MacLennan wrote: Fix a sparse error in the htons() call. htons() returns a __be16 not a u16. Signed-off-by: Sean MacLennan se...@seanm.ca --- You sent 2 patches, which should I apply? I've deleted both from my inbox, please resend the proper one, with a subject: that reflects that it is a patch. thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: r8192e_pci driver broken 3.14+
On Sat, Apr 19, 2014 at 03:10:04PM -0400, Sean MacLennan wrote: On Sat, 19 Apr 2014 11:17:23 -0700 Greg KH gre...@linuxfoundation.org wrote: On Sat, Apr 19, 2014 at 02:12:34PM -0400, Sean MacLennan wrote: Fix a sparse error in the htons() call. htons() returns a __be16 not a u16. Signed-off-by: Sean MacLennan se...@seanm.ca --- You sent 2 patches, which should I apply? I've deleted both from my inbox, please resend the proper one, with a subject: that reflects that it is a patch. They where two different patches. Would you prefer one patch? I split it in two since the first one is needed. The second fixes the sparse error. Yes, please put into one patch. thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] Staging:dgap:dgap_tty.c: Upgraded driver to use Mutex instead of semaphore
On Sun, Apr 20, 2014 at 10:19:14AM +0530, Kumar Gaurav wrote: Hi All, Any update on below patch. Do i need to make any modification? Please give an overworked maintainer a chance to catch up on his email. If after a week you haven't heard anything, then ask again. thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] Staging: octeon-usb: fixed a macro coding style issue
On Fri, Apr 25, 2014 at 10:48:22AM -0300, Nicolas Del Piano wrote:
Fixed a coding style error, macros with complex values should be enclosed in
parentheses.
Signed-off-by: Nicolas Del Piano ndel...@gmail.com
---
drivers/staging/octeon-usb/octeon-hcd.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/octeon-usb/octeon-hcd.c
b/drivers/staging/octeon-usb/octeon-hcd.c
index 8b8ce72..ef3a8ce 100644
--- a/drivers/staging/octeon-usb/octeon-hcd.c
+++ b/drivers/staging/octeon-usb/octeon-hcd.c
@@ -246,7 +246,7 @@ enum cvmx_usb_pipe_flags {
};
/* Normal prefetch that use the pref instruction. */
-#define CVMX_PREFETCH(address, offset) asm volatile (pref %[type],
%[off](%[rbase]) : : [rbase] d (address), [off] I (offset), [type] n
(0))
+#define CVMX_PREFETCH(address, offset) (asm volatile (pref %[type],
%[off](%[rbase]) : : [rbase] d (address), [off] I (offset), [type] n
(0)))
/* Maximum number of times to retry failed transactions */
#define MAX_RETRIES 3
Will that actually compile?
Why the heck are we using asm in a define in the first place? Shouldn't
this be an inline function or something?
thanks,
greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: comedi: fix coding style issues in comedi_fops.c
On Fri, Apr 25, 2014 at 11:18:55PM +0530, RAGHAVENDRA GANIGA wrote:
From 7bdc654b12895889a539450528b52328901e6dc0 Mon Sep 17 00:00:00 2001
From: Raghavendra Ganiga ravi23gan...@gmail.com
Date: Fri, 25 Apr 2014 23:11:22 +0530
Subject: [PATCH] staging: comedi: fix coding style issues in comedi_fops.c
Why is all of this in the email? It shouldn't be here, git send-email
should not put it here.
This is a patch to fix coding style
warnings found by the checkpatch.pl tool
Signed-off-by: Raghavendra Chandra Ganiga ravi23gan...@gmail.com
---
drivers/staging/comedi/comedi_fops.c |6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/comedi_fops.c
b/drivers/staging/comedi/comedi_fops.c
index ea6dc36..0cd67d0 100644
--- a/drivers/staging/comedi/comedi_fops.c
+++ b/drivers/staging/comedi/comedi_fops.c
@@ -1435,13 +1435,15 @@ static int __comedi_get_user_cmd(struct comedi_device
*dev,
s = dev-subdevices[cmd-subdev];
if (s-type == COMEDI_SUBD_UNUSED) {
- dev_dbg(dev-class_dev, %d not valid subdevice\n,
cmd-subdev);
+ dev_dbg(dev-class_dev,
+ %d not valid subdevice\n, cmd-subdev);
Why not just indent cmd-subdev instead of the whole string?
thanks,
greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 1/1] staging: android: Fix warning cast removes address space of expression
On Sun, Apr 20, 2014 at 11:10:57AM +0200, Camille Bordignon wrote:
Fix sparse warning cast removes address space of expression
Add lost flag __user due to cast
Signed-off-by: Camille Bordignon camille.bordig...@gmail.com
---
diff --git a/drivers/staging/android/binder.c
b/drivers/staging/android/binder.c
index cfe4bc8..952c4ae 100644
--- a/drivers/staging/android/binder.c
+++ b/drivers/staging/android/binder.c
@@ -2683,16 +2683,21 @@ static long binder_ioctl(struct file *filp, unsigned
int cmd, unsigned long arg)
binder_free_thread(proc, thread);
thread = NULL;
break;
- case BINDER_VERSION:
- if (size != sizeof(struct binder_version)) {
+ case BINDER_VERSION: {
+ struct binder_version __user *bv = ubuf;
+
+ if (size != sizeof(*bv)) {
ret = -EINVAL;
goto err;
}
- if (put_user(BINDER_CURRENT_PROTOCOL_VERSION, ((struct
binder_version *)ubuf)-protocol_version)) {
+
+ if (put_user(BINDER_CURRENT_PROTOCOL_VERSION,
+ bv-protocol_version)) {
ret = -EINVAL;
goto err;
}
break;
+ }
default:
ret = -EINVAL;
goto err;
This does not apply to my tree :(
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 2/2] Staging:keucr:scsiglue.c-no semicolon terminated
On Tue, Apr 08, 2014 at 05:32:45PM +0100, Paul McQuade wrote:
WARNING: do {} while (0) macros should not be semicolon terminated
Signed-off-by: Paul McQuade paulmcq...@gmail.com
---
drivers/staging/keucr/scsiglue.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/keucr/scsiglue.c
b/drivers/staging/keucr/scsiglue.c
index ac3d34d..fce19a4 100644
--- a/drivers/staging/keucr/scsiglue.c
+++ b/drivers/staging/keucr/scsiglue.c
@@ -277,7 +277,7 @@ static int show_info(struct seq_file *m, struct Scsi_Host
*host)
do { \
if (us-fflags value) \
SPRINTF( #name); \
- } while (0);
+ } while (0)
US_DO_ALL_FLAGS
#undef US_FLAG
seq_putc(m, '\n');
Why would you send a patch that you obviously have not at least compile
tested?
Hint, this breaks the build :(
ALWAYS test build your patches, to not do so is rude to others, don't
you agree?
greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 1/4] staging: unisys: detect s-Par firmware
On Thu, Apr 24, 2014 at 01:57:09PM -0500, Ken Cox wrote:
From: Benjamin Romer benjamin.ro...@unisys.com
This patch adds support for detection of s-Par firmware by checking for the
hypervisor bit in the CPU capabilities, and then querying the hypervisor ID
cpuid leaf.
No linewrap?
This functionality will be used by the unisys drivers to determine if
they are being loaded on an s-Par platform and refuse to load if no
s-Par firmware is present.
This fixes a problem reported from upstream where a panic occurs if the
unisys drivers are loaded on a non s-Par system.
Reported-by: Fengguang Wu fengguang...@intel.com
Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com
Tested-by: Benjamin Romer benjamin.ro...@unisys.com
Signed-off-by: Ken Cox j...@redhat.com
Tested-by: Ken Cox j...@redhat.com
---
arch/x86/include/asm/hypervisor.h | 1 +
arch/x86/kernel/cpu/Makefile | 2 +-
arch/x86/kernel/cpu/hypervisor.c | 3 +++
arch/x86/kernel/cpu/unisys_spar.c | 51
+++
4 files changed, 56 insertions(+), 1 deletion(-)
create mode 100644 arch/x86/kernel/cpu/unisys_spar.c
I can't accept code for arch/x86/ files in the staging tree, sorry,
everything there must be stand-alone in your drivers/staging/ directory.
I suggest you submit this to the x86 developers if you need it in the
x86 part of the tree, they are the only ones who can take it, not me.
diff --git a/arch/x86/include/asm/hypervisor.h
b/arch/x86/include/asm/hypervisor.h
index e42f758..3a86e0e 100644
--- a/arch/x86/include/asm/hypervisor.h
+++ b/arch/x86/include/asm/hypervisor.h
@@ -52,6 +52,7 @@ extern const struct hypervisor_x86 x86_hyper_vmware;
extern const struct hypervisor_x86 x86_hyper_ms_hyperv;
extern const struct hypervisor_x86 x86_hyper_xen_hvm;
extern const struct hypervisor_x86 x86_hyper_kvm;
+extern const struct hypervisor_x86 x86_hyper_unisys_spar;
extern void init_hypervisor(struct cpuinfo_x86 *c);
extern void init_hypervisor_platform(void);
diff --git a/arch/x86/kernel/cpu/Makefile b/arch/x86/kernel/cpu/Makefile
index 7fd54f0..a64ee5a 100644
--- a/arch/x86/kernel/cpu/Makefile
+++ b/arch/x86/kernel/cpu/Makefile
@@ -46,7 +46,7 @@ obj-$(CONFIG_MICROCODE) += microcode/
obj-$(CONFIG_X86_LOCAL_APIC) += perfctr-watchdog.o
perf_event_amd_ibs.o
-obj-$(CONFIG_HYPERVISOR_GUEST) += vmware.o hypervisor.o
mshyperv.o
+obj-$(CONFIG_HYPERVISOR_GUEST) += vmware.o hypervisor.o
mshyperv.o unisys_spar.o
quiet_cmd_mkcapflags = MKCAP $@
cmd_mkcapflags = $(CONFIG_SHELL) $(srctree)/$(src)/mkcapflags.sh $ $@
diff --git a/arch/x86/kernel/cpu/hypervisor.c
b/arch/x86/kernel/cpu/hypervisor.c
index 36ce402..ba92d14 100644
--- a/arch/x86/kernel/cpu/hypervisor.c
+++ b/arch/x86/kernel/cpu/hypervisor.c
@@ -35,6 +35,9 @@ static const __initconst struct hypervisor_x86 * const
hypervisors[] =
#ifdef CONFIG_KVM_GUEST
x86_hyper_kvm,
#endif
+#ifdef CONFIG_UNISYSSPAR
+ x86_hyper_unisys_spar,
+#endif
};
const struct hypervisor_x86 *x86_hyper;
diff --git a/arch/x86/kernel/cpu/unisys_spar.c
b/arch/x86/kernel/cpu/unisys_spar.c
new file mode 100644
index 000..264f309
--- /dev/null
+++ b/arch/x86/kernel/cpu/unisys_spar.c
@@ -0,0 +1,51 @@
+/* unisys_spar.c
+ *
+ * Copyright (C) 2014 - 2014 UNISYS CORPORATION
+ * All rights reserved.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or (at
+ * your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful, but
+ * WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY OR FITNESS FOR A PARTICULAR PURPOSE, GOOD TITLE or
+ * NON INFRINGEMENT. See the GNU General Public License for more
+ * details.
+ */
+
+#include asm/hypervisor.h
+
+/* s-Par uses the Intel processor's VT-X features to separate groups of
+ * processors into partitions. The firmware sets the hypervisor bit and
+ * reports an ID in the HV capabilities leaf so that the partition's OS
+ * knows s-Par is present and managing the processors.
+ */
+
+#define UNISYS_SPAR_LEAF_ID 0x4000
+
+/* The s-Par leaf ID returns UnisysSpar64 encoded across ebx, ecx, edx */
+#define UNISYS_SPAR_ID_EBX 0x73696e55
+#define UNISYS_SPAR_ID_ECX 0x70537379
+#define UNISYS_SPAR_ID_EDX 0x34367261
+
+static uint32_t unisys_spar_detect(void)
+{
+ if (cpu_has_hypervisor) {
+ unsigned int eax, ebx, ecx, edx;
+
+ /* check the ID */
+ cpuid(UNISYS_SPAR_LEAF_ID, eax, ebx, ecx, edx);
+ return (ebx == UNISYS_SPAR_ID_EBX)
+ (ecx == UNISYS_SPAR_ID_ECX)
+ (edx == UNISYS_SPAR_ID_EDX);
+ } else
+ return
Re: [PATCH 2/4] Staging: unisys: Added check for s-Par platform in each init function.
On Thu, Apr 24, 2014 at 01:57:10PM -0500, Ken Cox wrote:
This fixes a problem reported from upstream where a panic occurs if the
unisys drivers are loaded on a non s-Par system.
Reported-by: Fengguang Wu fengguang...@intel.com
Signed-off-by: Ken Cox j...@redhat.com
Tested by: Ken Cox j...@redhat.com
---
drivers/staging/unisys/channels/chanstub.c| 5 +
drivers/staging/unisys/uislib/uislib.c| 5 +
drivers/staging/unisys/virthba/virthba.c | 4
drivers/staging/unisys/virtpci/virtpci.c | 4
.../staging/unisys/visorchannel/visorchannel_main.c | 4
.../staging/unisys/visorchipset/visorchipset_main.c | 4
drivers/staging/unisys/visorutil/visorkmodutils.c | 19
+++
7 files changed, 45 insertions(+)
diff --git a/drivers/staging/unisys/channels/chanstub.c
b/drivers/staging/unisys/channels/chanstub.c
index f504f49..cf8242b 100644
--- a/drivers/staging/unisys/channels/chanstub.c
+++ b/drivers/staging/unisys/channels/chanstub.c
@@ -23,6 +23,8 @@
#include linux/slab.h /* for memcpy */
#include linux/types.h
+#include asm/hypervisor.h
+
#include channel.h
#include chanstub.h
#include version.h
@@ -30,6 +32,9 @@
static __init int
channel_mod_init(void)
{
+ if (x86_hyper != x86_hyper_unisys_spar)
+ return -ENODEV;
+
return 0;
}
This will break the build without the previous patch (well, this driver
is already disabled, but you get the idea...) So I can't take it,
sorry.
greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 4/4] Staging: unisys: visorutil: Add MODULE_LICENSE(GPL)
On Thu, Apr 24, 2014 at 01:57:12PM -0500, Ken Cox wrote: The visorutil module was lacking license info. Signed-off-by: Ken Cox j...@redhat.com --- drivers/staging/unisys/visorutil/visorkmodutils.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/unisys/visorutil/visorkmodutils.c b/drivers/staging/unisys/visorutil/visorkmodutils.c index 87ed5bf..1cf11fc 100644 --- a/drivers/staging/unisys/visorutil/visorkmodutils.c +++ b/drivers/staging/unisys/visorutil/visorkmodutils.c @@ -88,3 +88,5 @@ visorutil_mod_exit(void) module_init(visorutil_mod_init); module_exit(visorutil_mod_exit); + +MODULE_LICENSE(GPL); -- 1.8.5.3 This patch doesn't apply at all, what tree are you making it against? ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: silicom: Add appropriate ifdef conditions in bpctl_mod.c
On Mon, Apr 07, 2014 at 12:03:41PM +0900, Daeseok Youn wrote: The bp_proc_create() can be called if BP_PROC_SUPPORT is defined. Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- drivers/staging/silicom/bpctl_mod.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/drivers/staging/silicom/bpctl_mod.c b/drivers/staging/silicom/bpctl_mod.c index 6b9365b..5a3d758 100644 --- a/drivers/staging/silicom/bpctl_mod.c +++ b/drivers/staging/silicom/bpctl_mod.c @@ -119,7 +119,10 @@ static void if_scan_init(void); static int bypass_proc_create_dev_sd(struct bpctl_dev *pbp_device_block); static int bypass_proc_remove_dev_sd(struct bpctl_dev *pbp_device_block); + +#ifdef BP_PROC_SUPPORT static int bp_proc_create(void); +#endif No, this code should just be removed, right? ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: rtl8192u: fix checkpatch braces warning
On Wed, Mar 26, 2014 at 01:08:23AM +, Rui Miguel Silva wrote:
fix some code style related to the use of braces in a one statement block
Signed-off-by: Rui Miguel Silva rmf...@gmail.com
---
drivers/staging/rtl8192u/r8192U_dm.c | 7 +++
drivers/staging/rtl8192u/r8192U_wx.c | 3 +--
drivers/staging/rtl8192u/r819xU_firmware.c | 6 ++
drivers/staging/rtl8192u/r819xU_phy.c | 3 +--
4 files changed, 7 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8192U_dm.c
b/drivers/staging/rtl8192u/r8192U_dm.c
index d97ad7b..0557853 100644
--- a/drivers/staging/rtl8192u/r8192U_dm.c
+++ b/drivers/staging/rtl8192u/r8192U_dm.c
@@ -183,9 +183,9 @@ void dm_CheckRxAggregation(struct net_device *dev) {
curTxOkCnt = priv-stats.txbytesunicast - lastTxOkCnt;
curRxOkCnt = priv-stats.rxbytesunicast - lastRxOkCnt;
- if((curTxOkCnt + curRxOkCnt) 1500) {
+ if
+ ((curTxOkCnt + curRxOkCnt) 1500)
What did you just do there? Does that look right to you?
greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] imx-hdmi: Make checkpatch happy
On Sat, Apr 05, 2014 at 12:50:22PM -0300, Fabio Estevam wrote:
From: Fabio Estevam fabio.este...@freescale.com
Fix the following checkpatch warnings:
WARNING: Missing a blank line after declarations
#162: FILE: drivers/staging/imx-drm/imx-hdmi.c:162:
+ u8 val = hdmi_readb(hdmi, reg) ~mask;
+ val |= data mask;
WARNING: Missing a blank line after declarations
#663: FILE: drivers/staging/imx-drm/imx-hdmi.c:663:
+ unsigned char val = 0;
+ val = hdmi_readb(hdmi, HDMI_IH_I2CMPHY_STAT0) 0x3;
total: 0 errors, 2 warnings, 1773 lines checked
Signed-off-by: Fabio Estevam fabio.este...@freescale.com
---
drivers/staging/imx-drm/imx-hdmi.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/imx-drm/imx-hdmi.c
b/drivers/staging/imx-drm/imx-hdmi.c
index cf21252..f557ea8 100644
--- a/drivers/staging/imx-drm/imx-hdmi.c
+++ b/drivers/staging/imx-drm/imx-hdmi.c
@@ -159,6 +159,7 @@ static inline u8 hdmi_readb(struct imx_hdmi *hdmi, int
offset)
static void hdmi_modb(struct imx_hdmi *hdmi, u8 data, u8 mask, unsigned reg)
{
u8 val = hdmi_readb(hdmi, reg) ~mask;
+
val |= data mask;
hdmi_writeb(hdmi, val, reg);
}
@@ -659,8 +660,8 @@ static inline void hdmi_phy_test_dout(struct imx_hdmi
*hdmi,
static bool hdmi_phy_wait_i2c_done(struct imx_hdmi *hdmi, int msec)
{
- unsigned char val = 0;
- val = hdmi_readb(hdmi, HDMI_IH_I2CMPHY_STAT0) 0x3;
+ unsigned char val = hdmi_readb(hdmi, HDMI_IH_I2CMPHY_STAT0) 0x3;
+
while (!val) {
udelay(1000);
if (msec-- == 0)
This patch doesn't apply for some reason, can you please refresh it and
resend?
thanks,
greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] Staging: xgifb: Coding style cleanup, newline added after declarations
On Wed, Apr 02, 2014 at 11:25:19AM +0200, Martin Berglund wrote: Added newlines after declarations. Signed-off-by: Martin Berglund mar...@rogsta.net --- drivers/staging/xgifb/XGI_main_26.c | 2 ++ drivers/staging/xgifb/vb_init.c | 2 ++ drivers/staging/xgifb/vb_setmode.c | 2 ++ 3 files changed, 6 insertions(+) Someone else sent this right before you did, sorry :( greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH next-20140424] staging/cxt1e1: hwprobe.c sparse warning corrections
On Sat, Apr 26, 2014 at 06:30:33PM +0300, Sami Laine wrote: From: Sami Laine laine.j.s...@gmail.com Sparse warning corrections: - declarations made static where they should be such - changed NULL-pointers as NULL instead of static 0's - added __force to a few casts seemingly safe enough You did 3 different things here, can you split this up into 3 different patches? Especially as someone already sent in the NULL pointer patch... thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[GIT PULL] Staging driver fixes for 3.15-rc3
The following changes since commit a798c10faf62a505d24e5f6213fbaf904a39623f: Linux 3.15-rc2 (2014-04-20 11:08:50 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/ tags/staging-3.15-rc3 for you to fetch changes up to 2704f807f9498054b8153002bafa3e818079e9a5: staging: comedi: usbdux: bug fix for accessing 'ao_chanlist' in private data (2014-04-23 16:20:15 -0700) Staging / IIO driver fixes for 3.15-rc3 Here are some small staging and IIO driver fixes for 3.15-rc3. Nothing major at all, just some assorted issues that people have reported. Signed-off-by: Greg Kroah-Hartman gre...@linuxfoundation.org Alec Berg (1): iio: querying buffer scan_mask should return 0/1 Alexandre Belloni (5): iio: adc: at91_adc: Repair broken platform_data support ARM: at91: at91sam9g45: change at91_adc name ARM: at91: at91sam9260: change at91_adc name iio: adc: at91_adc: correct default shtim value iio: adc: mxs-lradc: fix warning when buidling on avr32 Beomho Seo (1): iio: cm32181: Fix read integration time function Greg Kroah-Hartman (1): Merge tag 'iio-fixes-for-3.15a' of git://git.kernel.org/.../jic23/iio into staging-linus H Hartley Sweeten (1): staging: comedi: usbdux: bug fix for accessing 'ao_chanlist' in private data Jimmy Li (1): staging:iio:ad2s1200 fix a missing break Krzysztof Kozlowski (1): iio: cm36651: Fix i2c client leak and possible NULL pointer dereference arch/arm/mach-at91/at91sam9260_devices.c | 2 +- arch/arm/mach-at91/at91sam9g45_devices.c | 2 +- drivers/iio/adc/at91_adc.c | 33 ++-- drivers/iio/industrialio-buffer.c| 6 -- drivers/iio/light/cm32181.c | 1 + drivers/iio/light/cm36651.c | 22 +++-- drivers/staging/comedi/drivers/usbdux.c | 9 +++-- drivers/staging/iio/adc/mxs-lradc.c | 2 +- drivers/staging/iio/resolver/ad2s1200.c | 1 + 9 files changed, 59 insertions(+), 19 deletions(-) ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: media: parport: Fix format string mismatch in bw-qcam.c
On Wed, Apr 30, 2014 at 07:51:13PM +0900, Masanari Iida wrote: Fix format string mismatch in bw-qcam.c Signed-off-by: Masanari Iida standby2...@gmail.com --- drivers/media/parport/bw-qcam.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/parport/bw-qcam.c b/drivers/media/parport/bw-qcam.c index 8a0e84c..416507a 100644 --- a/drivers/media/parport/bw-qcam.c +++ b/drivers/media/parport/bw-qcam.c This isn't a staging driver, so why is staging in the Subject? ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: android: fix missing a blank line after declarations
On Tue, Apr 29, 2014 at 08:32:21PM +0300, Dan Carpenter wrote: On Wed, Apr 30, 2014 at 01:59:12AM +0900, Seunghun Lee wrote: This patch fixes Missing a blank line after declarations warnings. Signed-off-by: Seunghun Lee way...@gmail.com Quite a few of these are false checkpatch.pl false positives. Just ignore the false positives. Really? It looks good to me, what am I missing? greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 1/6] staging: comedi: addi_apci_1564: remove eeprom support code
On Mon, Apr 28, 2014 at 12:40:05PM +0300, Dan Carpenter wrote: Nice, Chase, you've become an expert on comedi, it seems. I can't say how happy comedi patches make me these days. Ian, you and Hartley are doing a fantastic job. Same here, it's great to see all of this cleanup happening. Maybe someday it can move out of staging... :) thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: rtl8723au: Remove unused pointer in rtw_wdev_free()
On Sat, Apr 26, 2014 at 10:10:29PM +0200, Christian Engelmayer wrote: Pointer 'pwdev_priv' in function rtw_wdev_free() is unused - thus remove it. Signed-off-by: Christian Engelmayer cenge...@gmx.at --- Compile tested and applies against v3.15-rc2 as well as branch staging-next of tree git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git This doesn't seem to apply to my tree at all :( greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: rtl8821ae: mark pointer in pci_iounmap as __iomem
On Sat, May 03, 2014 at 05:10:48PM +0200, Martin Kepplinger wrote: pci_iounmap is used that way in drivers/net/wireless/rtlwifi and this fixes sparse warnings. Signed-off-by: Martin Kepplinger mart...@posteo.de --- drivers/staging/rtl8821ae/pci.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8821ae/pci.c b/drivers/staging/rtl8821ae/pci.c index a562aa6..d934ecb 100644 --- a/drivers/staging/rtl8821ae/pci.c +++ b/drivers/staging/rtl8821ae/pci.c @@ -2416,7 +2416,7 @@ fail3: ieee80211_free_hw(hw); if (rtlpriv-io.pci_mem_start != 0) - pci_iounmap(pdev, (void *)rtlpriv-io.pci_mem_start); + pci_iounmap(pdev, (void __iomem *)rtlpriv-io.pci_mem_start); Shouldn't pci_mem_start be a __iomem pointer instead? thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: rtl8712: fix potential leaks in r8712_set_key()
On Thu, May 01, 2014 at 11:54:02PM +0200, Christian Engelmayer wrote: Fix potential leaks in the error paths of r8712_set_key(). In case the algorithm specific checks fail, the function returns without enqueuing or freeing the already allocated command and parameter structs. Use a centralized exit path and make sure that all memory is freed correctly. Detected by Coverity - CID 144370, 144371. Signed-off-by: Christian Engelmayer cenge...@gmx.at --- Compile tested and applies against branch staging-next of tree git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git This doesn't apply either, and neither does one of your other patches, what is going on? Can you just refresh all of the outstanding patches you have sent me that I have not applied and resend them? thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: vt6655: correct coding style issue
On Sun, May 04, 2014 at 09:52:09PM +0200, Clément Calmels wrote: Remove C99 comment and rewrite lines over 80 characters. Warnings and error found by checkpatch.pl script. Signed-off-by: Clément Calmels clement.calm...@free.fr --- drivers/staging/vt6655/tmacro.h | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/staging/vt6655/tmacro.h b/drivers/staging/vt6655/tmacro.h index 59c6e72..264c6ed 100644 --- a/drivers/staging/vt6655/tmacro.h +++ b/drivers/staging/vt6655/tmacro.h @@ -44,17 +44,22 @@ #define LOWORD(d) ((unsigned short)(d)) #endif #if !defined(HIWORD) -#define HIWORD(d) ((unsigned short)unsigned long)(d)) 16) 0x)) +#define HIWORD(d)\ + ((unsigned short)unsigned long)(d)) 16) 0x)) #endif #define LODWORD(q) ((q).u.dwLowDword) #define HIDWORD(q) ((q).u.dwHighDword) #if !defined(MAKEWORD) -#define MAKEWORD(lb, hb)((unsigned short)(((unsigned char)(lb)) | (((unsigned short)((unsigned char)(hb))) 8))) +#define MAKEWORD(lb, hb)\ + ((unsigned short)(((unsigned char)(lb)) \ + | (((unsigned short)((unsigned char)(hb))) 8))) #endif #if !defined(MAKEDWORD) -#define MAKEDWORD(lw, hw) ((unsigned long)(((unsigned short)(lw)) | (((unsigned long)((unsigned short)(hw))) 16))) +#define MAKEDWORD(lw, hw)\ + ((unsigned long)(((unsigned short)(lw)) \ + | (((unsigned long)((unsigned short)(hw))) 16))) #endif -#endif // __TMACRO_H__ +#endif /* __TMACRO_H__ */ Why not just switch to use the built-in macros the kernel provides for this? greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] [staging/silicom] Fixing missing blank line after declarations
On Mon, May 05, 2014 at 06:40:13PM +0200, Fernando Apesteguia wrote:
Small fix to driver. If these patches are welcomed, more could come in the
future.
Regards
From d8369cba0552c5ea5f4eadc750434e39785e042a Mon Sep 17 00:00:00 2001
From: Fernando Apesteguia fernando.apesteg...@gmail.com
Date: Mon, 5 May 2014 18:16:53 +0200
Subject: [PATCH] [staging/silicom] Fixing missing blank line after
declarations
---
drivers/staging/silicom/bpctl_mod.c |1 +
1 file changed, 1 insertion(+)
They would be welcome if they were in a format I could apply them in :)
See Documentation/SubmittingPatches for the details on how to do this
properly.
diff --git a/drivers/staging/silicom/bpctl_mod.c
b/drivers/staging/silicom/bpctl_mod.c
index 7f3d884..8fb527b 100644
--- a/drivers/staging/silicom/bpctl_mod.c
+++ b/drivers/staging/silicom/bpctl_mod.c
@@ -7450,6 +7450,7 @@ static int bypass_proc_remove_dev_sd(struct bpctl_dev
*pbp_device_block)
{
struct bypass_pfs_sd *current_pfs = pbp_device_block-bypass_pfs_set;
+
Why not also delete the empty line above this statement?
thanks,
greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] [staging/silicom] Fixing missing blank line after declarations
On Mon, May 05, 2014 at 07:10:37PM +0200, Fernando Apesteguia wrote: On Mon, May 05, 2014 at 09:57:48AM -0700, Greg KH wrote: On Mon, May 05, 2014 at 06:40:13PM +0200, Fernando Apesteguia wrote: Small fix to driver. If these patches are welcomed, more could come in the future. Regards From d8369cba0552c5ea5f4eadc750434e39785e042a Mon Sep 17 00:00:00 2001 From: Fernando Apesteguia fernando.apesteg...@gmail.com Date: Mon, 5 May 2014 18:16:53 +0200 Subject: [PATCH] [staging/silicom] Fixing missing blank line after declarations --- drivers/staging/silicom/bpctl_mod.c |1 + 1 file changed, 1 insertion(+) They would be welcome if they were in a format I could apply them in :) See Documentation/SubmittingPatches for the details on how to do this properly. I think this one is good. What one? This email, no, I can't take it. The patch needs to be in a format that I do not need to edit by hand, and you forgot the signed-off-by: line, which is described in the kernel file I pointed you at. Please read that file for what it means, and how to properly format a patch for inclusion. thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: vt6655: correct coding style issue
On Mon, May 05, 2014 at 09:16:03PM +0200, Clément Calmels wrote: On Sun, 4 May 2014 17:26:58 -0400 Greg KH g...@kroah.com wrote: On Sun, May 04, 2014 at 09:52:09PM +0200, Clément Calmels wrote: Remove C99 comment and rewrite lines over 80 characters. Warnings and error found by checkpatch.pl script. Signed-off-by: Clément Calmels clement.calm...@free.fr --- drivers/staging/vt6655/tmacro.h | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/staging/vt6655/tmacro.h b/drivers/staging/vt6655/tmacro.h index 59c6e72..264c6ed 100644 --- a/drivers/staging/vt6655/tmacro.h +++ b/drivers/staging/vt6655/tmacro.h @@ -44,17 +44,22 @@ #define LOWORD(d) ((unsigned short)(d)) #endif #if !defined(HIWORD) -#define HIWORD(d) ((unsigned short)unsigned long)(d)) 16) 0x)) +#define HIWORD(d) \ + ((unsigned short)unsigned long)(d)) 16) 0x)) #endif #define LODWORD(q) ((q).u.dwLowDword) #define HIDWORD(q) ((q).u.dwHighDword) #if !defined(MAKEWORD) -#define MAKEWORD(lb, hb)((unsigned short)(((unsigned char)(lb)) | (((unsigned short)((unsigned char)(hb))) 8))) +#define MAKEWORD(lb, hb)\ + ((unsigned short)(((unsigned char)(lb))\ + | (((unsigned short)((unsigned char)(hb))) 8))) #endif #if !defined(MAKEDWORD) -#define MAKEDWORD(lw, hw) ((unsigned long)(((unsigned short)(lw)) | (((unsigned long)((unsigned short)(hw))) 16))) +#define MAKEDWORD(lw, hw)\ + ((unsigned long)(((unsigned short)(lw)) \ + | (((unsigned long)((unsigned short)(hw))) 16))) #endif -#endif // __TMACRO_H__ +#endif /* __TMACRO_H__ */ Why not just switch to use the built-in macros the kernel provides for this? greg k-h Are you talking about changing types (unsigned char = u8) as used there: http://lxr.free-electrons.com/source/sound/isa/msnd/msnd.h#L182 or there: http://lxr.free-electrons.com/source/include/acpi/actypes.h#L481 ? No, how about get_unaligned_le16() and put_unaligned_le16()? Don't those do what you want here? thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[GIT PULL] Staging driver fixes for 3.15-rc5
The following changes since commit d1db0eea852497762cab43b905b879dfcd3b8987: Linux 3.15-rc3 (2014-04-27 19:29:27 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/ tags/staging-3.15-rc4 for you to fetch changes up to 86281966c7395aa9a13a20c52e26005f5e142451: Merge tag 'iio-fixes-for-3.15b' of git://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio into staging-linus (2014-04-30 14:19:23 -0700) Staging / IIO fixes for 3.15-rc4 Here are some small IIO driver fixes for 3.15-rc4 that resolve some reported issues. Signed-off-by: Greg Kroah-Hartman gre...@linuxfoundation.org Atilla Filiz (1): iio:imu:mpu6050: Fixed segfault in Invensens MPU driver due to null dereference Doug Anderson (1): iio: adc: Nothing in ADC should be a bool CONFIG Greg Kroah-Hartman (1): Merge tag 'iio-fixes-for-3.15b' of git://git.kernel.org/.../jic23/iio into staging-linus Jimmy Li (1): staging:iio:ad2s1200 fix missing parenthesis in a for statment. Naveen Krishna Ch (1): iio: exynos_adc: use indio_dev-dev structure to handle child nodes drivers/iio/adc/Kconfig| 4 ++-- drivers/iio/adc/exynos_adc.c | 6 +++--- drivers/iio/imu/inv_mpu6050/inv_mpu_core.c | 7 +-- drivers/staging/iio/resolver/ad2s1200.c| 3 ++- 4 files changed, 12 insertions(+), 8 deletions(-) ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] Staging: android: fix coding style issue for Eudyptula Challenge in timed_gpio.c
On Wed, May 07, 2014 at 12:44:31AM +0100, John Church wrote: Signed-off-by: John Church j.chu...@ymail.com What coding style issue? You need to be specific in your body of your email, and put a blank line after the signed-off-by and before the patch, otherwise the tools can complain. And drop the Eudyptula challenge line in subject:, it's not needed at all. Can you redo this and resend? thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH]: Staging: gdm72xx Fix minor coding style problems
On Wed, May 07, 2014 at 04:05:27PM +0530, Adithya wrote: Hi All, This is patch for fixing of minor coding style problems. This is part of Eudyptula Challenge. Thanks, Adithya.K Can you please read the Documentation/SubmittingPatches file and then resend this in a format I can apply it in (i.e. a Signed-off-by: line, be sure to read the file for what that means), and in a non-mime-encoded format, and a decent changelog comment. thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH net-next] Add support for netvsc build without CONFIG_SYSFS flag
On Wed, May 07, 2014 at 03:45:04PM -0700, Haiyang Zhang wrote:
This change ensures the driver can be built successfully without the
CONFIG_SYSFS flag.
MS-TFS: 182270
Signed-off-by: Haiyang Zhang haiya...@microsoft.com
Reviewed-by: K. Y. Srinivasan k...@microsoft.com
---
drivers/net/hyperv/hyperv_net.h |2 ++
drivers/net/hyperv/netvsc_drv.c | 12 +++-
drivers/net/hyperv/rndis_filter.c |4 ++--
3 files changed, 15 insertions(+), 3 deletions(-)
diff --git a/drivers/net/hyperv/hyperv_net.h b/drivers/net/hyperv/hyperv_net.h
index 4b7df5a..23b96bc 100644
--- a/drivers/net/hyperv/hyperv_net.h
+++ b/drivers/net/hyperv/hyperv_net.h
@@ -87,6 +87,8 @@ struct ndis_recv_scale_cap { /*
NDIS_RECEIVE_SCALE_CAPABILITIES */
#define HASH_KEYLEN NDIS_RSS_HASH_SECRET_KEY_MAX_SIZE_REVISION_2
extern u8 netvsc_hash_key[];
+extern unsigned int netvsc_num_queue;
+
struct ndis_recv_scale_param { /* NDIS_RECEIVE_SCALE_PARAMETERS */
struct ndis_obj_header hdr;
diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c
index 939e3af..07896f3 100644
--- a/drivers/net/hyperv/netvsc_drv.c
+++ b/drivers/net/hyperv/netvsc_drv.c
@@ -52,6 +52,8 @@ static int ring_size = 128;
module_param(ring_size, int, S_IRUGO);
MODULE_PARM_DESC(ring_size, Ring buffer size (# of pages));
+unsigned int netvsc_num_queue = 1;
+
static void do_set_multicast(struct work_struct *w)
{
struct net_device_context *ndevctx =
@@ -639,9 +641,11 @@ int netvsc_recv_callback(struct hv_device *device_obj,
__vlan_hwaccel_put_tag(skb, htons(ETH_P_8021Q),
packet-vlan_tci);
+#ifdef CONFIG_SYSFS
skb_record_rx_queue(skb, packet-channel-
offermsg.offer.sub_channel_index %
net-real_num_rx_queues);
+#endif
Why is this a sysfs-only function? It should have nothing to do with
sysfs, right? So why would the driver care?
Don't put #ifdef in drivers, it's unmaintainable over time, if this
really is a sysfs-only function, this should already be handled
automatically in a .h file somewhere.
thanks,
greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH net-next, v2] Add support for netvsc build without CONFIG_SYSFS flag
On Thu, May 08, 2014 at 01:41:33PM -0700, Haiyang Zhang wrote:
This change ensures the driver can be built successfully without the
CONFIG_SYSFS flag.
MS-TFS: 182270
Signed-off-by: Haiyang Zhang haiya...@microsoft.com
Reviewed-by: K. Y. Srinivasan k...@microsoft.com
---
drivers/net/hyperv/hyperv_net.h | 28
drivers/net/hyperv/netvsc_drv.c | 13 +++--
drivers/net/hyperv/rndis_filter.c |4 ++--
3 files changed, 37 insertions(+), 8 deletions(-)
diff --git a/drivers/net/hyperv/hyperv_net.h b/drivers/net/hyperv/hyperv_net.h
index 4b7df5a..02358cb 100644
--- a/drivers/net/hyperv/hyperv_net.h
+++ b/drivers/net/hyperv/hyperv_net.h
@@ -87,6 +87,8 @@ struct ndis_recv_scale_cap { /*
NDIS_RECEIVE_SCALE_CAPABILITIES */
#define HASH_KEYLEN NDIS_RSS_HASH_SECRET_KEY_MAX_SIZE_REVISION_2
extern u8 netvsc_hash_key[];
+extern unsigned int netvsc_num_queue;
+
struct ndis_recv_scale_param { /* NDIS_RECEIVE_SCALE_PARAMETERS */
struct ndis_obj_header hdr;
@@ -178,6 +180,32 @@ struct rndis_device {
unsigned char hw_mac_adr[ETH_ALEN];
};
+static inline void netvsc_record_rx_queue(struct sk_buff *skb,
+ struct hv_netvsc_packet *packet,
+ struct net_device *ndev)
+{
+#ifdef CONFIG_SYSFS
+ skb_record_rx_queue(skb, packet-channel-
+ offermsg.offer.sub_channel_index %
+ ndev-real_num_rx_queues);
+#endif
Really? Do all other wireless drivers have this type of #ifdef needed?
+}
+
+static inline void netvsc_show_num_queue(struct device *dev,
+ struct net_device *ndev)
+{
+#ifdef CONFIG_SYSFS
+ dev_info(dev, real num tx,rx queues:%u, %u\n,
+ ndev-real_num_tx_queues, ndev-real_num_rx_queues);
+#endif
Do network drivers really spam the kernel log with this type of thing?
If you have sysfs, why is this needed in the kernel log?
+}
+
+static inline void netvsc_set_num_queue(unsigned int *nq)
+{
+#ifdef CONFIG_SYSFS
+ *nq = num_online_cpus();
+#endif
+}
I really feel that something is odd here...
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] Staging:dgnc:dgnc_driver open/close braces
On Wed, Apr 09, 2014 at 05:30:04PM +0100, Paul McQuade wrote:
ERROR: that open brace { should be on the previous line
ERROR: else should follow close brace '}
ERROR: space required before the open parenthesis '(
ERROR: trailing whitespace
ERROR: open brace '{' following function declarations go on the next line
ERROR: space required after that ',' (ctx:VxV)
ERROR: space required before the open parenthesis '('
Signed-off-by: Paul McQuade paulmcq...@gmail.com
---
drivers/staging/dgnc/dgnc_driver.c | 22 ++
1 file changed, 10 insertions(+), 12 deletions(-)
There is something really odd in this patch that git refuses to apply
it. Can you please refresh it and send it again, after verifying that
it will apply properly on your side?
The error I get is:
Applying: Staging:dgnc:dgnc_driver open/close braces
fatal: patch fragment without header at line 77: @@ -895,7 +893,7 @@ int
dgnc_ms_sleep(ulong ms)
thanks,
greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] Staging: dgnc: Fix smatch warning for redundant null check in dgnc_driver.c
On Wed, May 07, 2014 at 02:41:48PM +0300, Ebru Akagunduz wrote: Fix smatch warning dgnc_cleanup_board() info: redundant null check on brd-flipbuf calling kfree() in dgnc_driver.c Signed-off-by: Ebru Akagunduz ebru.akagun...@gmail.com --- drivers/staging/dgnc/dgnc_driver.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_driver.c b/drivers/staging/dgnc/dgnc_driver.c index b1a39b2..e579ba3 100644 --- a/drivers/staging/dgnc/dgnc_driver.c +++ b/drivers/staging/dgnc/dgnc_driver.c @@ -463,8 +463,7 @@ static void dgnc_cleanup_board(struct dgnc_board *brd) } } - if (brd-flipbuf) - kfree(brd-flipbuf); + kfree(brd-flipbuf); dgnc_Board[brd-boardnum] = NULL; Sorry, someone else sent this same patch before you did :( ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: ft1000: Replace printk with pr_info in ft1000_cs.c
On Wed, May 14, 2014 at 10:12:46AM +0200, Tobias Klauser wrote: On 2014-05-13 at 16:43:57 +0200, Masanari Iida standby2...@gmail.com wrote: This patch replaced printk with pr_info. It would be even better to use dev_err(), since these are error messages and you can use the struct dev from link-dev. You can also drop the ft1000: prefix then. I agree, that's the better fix here. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: wlan-ng: Fix sparse warnings
On Sun, Apr 13, 2014 at 10:09:49PM +0530, c...@slynux.com wrote: From: Sarath Lakshman sarathlaksh...@slynux.com This doesn't match your From: line, why? Fixed missed declarations for few non-static functions. Signed-off-by: Sarath Lakshman sarathlaksh...@slynux.com --- drivers/staging/wlan-ng/cfg80211.c | 1 + drivers/staging/wlan-ng/prism2mgmt.h | 6 ++ 2 files changed, 7 insertions(+) diff --git a/drivers/staging/wlan-ng/cfg80211.c b/drivers/staging/wlan-ng/cfg80211.c index f76f95c..662581c 100644 --- a/drivers/staging/wlan-ng/cfg80211.c +++ b/drivers/staging/wlan-ng/cfg80211.c @@ -1,4 +1,5 @@ /* cfg80211 Interface for prism2_usb module */ +#include prism2mgmt.h /* Prism2 channel/frequency/bitrate declarations */ diff --git a/drivers/staging/wlan-ng/prism2mgmt.h b/drivers/staging/wlan-ng/prism2mgmt.h index 190d390..ad049ad 100644 --- a/drivers/staging/wlan-ng/prism2mgmt.h +++ b/drivers/staging/wlan-ng/prism2mgmt.h @@ -60,6 +60,8 @@ #ifndef _PRISM2MGMT_H #define _PRISM2MGMT_H +#include hfa384x.h + extern int prism2_reset_holdtime; extern int prism2_reset_settletime; @@ -109,4 +111,8 @@ void prism2sta_processing_defer(struct work_struct *data); void prism2sta_commsqual_defer(struct work_struct *data); void prism2sta_commsqual_timer(unsigned long data); +void prism2_connect_result(wlandevice_t *wlandev, u8 failed); +void prism2_disconnected(wlandevice_t *wlandev); +void prism2_roamed(wlandevice_t *wlandev); What about the existing declarations of these functions? Shouldn't they be removed? thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 4/4] staging/wlan-ng: replace printk() with pr_xxx()
On Mon, May 12, 2014 at 05:22:47PM +0200, Denis Pithon wrote:
Fix some coding style issues concerning printk() usage.
Signed-off-by: Denis Pithon denis.pit...@gmail.com
---
drivers/staging/wlan-ng/p80211netdev.c | 17 +
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/wlan-ng/p80211netdev.c
b/drivers/staging/wlan-ng/p80211netdev.c
index 61a3092..3577d20 100644
--- a/drivers/staging/wlan-ng/p80211netdev.c
+++ b/drivers/staging/wlan-ng/p80211netdev.c
@@ -384,8 +384,9 @@ static int p80211knetdev_hard_start_xmit(struct sk_buff
*skb,
*/
if (skb-protocol != ETH_P_80211_RAW) {
netif_start_queue(wlandev-netdev);
- printk(KERN_NOTICE
-Tx attempt prior to association, frame
dropped.\n);
+ pr_notice(
+Tx attempt prior to association, frame dropped\n
+ );
Can't these be netdev messages, or at the least, dev_* messages?
thanks,
greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: sep: fix coding style issue
On Tue, May 06, 2014 at 07:54:41PM +0200, Clément Calmels wrote:
This is a patch to fix coding style issue found by
scripts/checkpatch.pl utility.
Signed-off-by: Clément Calmels clement.calm...@free.fr
---
drivers/staging/sep/sep_dev.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/staging/sep/sep_dev.h b/drivers/staging/sep/sep_dev.h
index 5f6a07f..5faeefa1 100644
--- a/drivers/staging/sep/sep_dev.h
+++ b/drivers/staging/sep/sep_dev.h
@@ -139,12 +139,14 @@ struct sep_queue_info {
static inline void sep_write_reg(struct sep_device *dev, int reg, u32 value)
{
void __iomem *addr = dev-reg_addr + reg;
+
writel(value, addr);
}
static inline u32 sep_read_reg(struct sep_device *dev, int reg)
{
void __iomem *addr = dev-reg_addr + reg;
+
return readl(addr);
}
@@ -152,6 +154,7 @@ static inline u32 sep_read_reg(struct sep_device *dev,
int reg)
static inline void sep_wait_sram_write(struct sep_device *dev)
{
u32 reg_val;
+
do {
reg_val = sep_read_reg(dev, HW_SRAM_DATA_READY_REG_ADDR);
} while (!(reg_val 1));
Someone else already sent in this same patch, sorry.
greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: dgap: implement error handling in dgap_tty_register()
On Fri, May 16, 2014 at 12:52:47PM +0300, Dan Carpenter wrote: On Fri, May 16, 2014 at 06:40:28PM +0900, DaeSeok Youn wrote: Hi, This patch haven't been updated over the past 3 weeks. Will you check for me? Greg was trying to travel around the world in one month like Jackie Chan. http://www.imdb.com/title/tt0327437/ He is back to work since yesterday. Well, I'm home for a day or so before I leave again for a week, so I'm having to prioritize things (patches or laundry) and dealing with a pet vet emergency, so my ability to get to cleanup patches is way down the list... greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] Staging: gdm72xx: gdm_wimax: Fixed coding style issues.
On Mon, Apr 28, 2014 at 01:50:11PM -0500, Junsu Shin wrote:
Fixed following coding style issues.
- No space is necessary after a cast
- Alignment should match open parenthesis
- Braces {} should be used on all arms of this statement
You are doing 3 things, so this should be 3 patches at the least.
Remember, one patch per thing.
Signed-off-by: Junsu Shin jsshin@gmail.comx
What is the trailing 'x' for?
thanks,
greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: dgap: implement error handling in dgap_tty_register()
On Fri, Apr 25, 2014 at 04:04:59PM +0900, Daeseok Youn wrote: - alloc_tty_driver() is deprecated so it is changed to tty_alloc_driver() - Pointers which are allocated by alloc_tty_driver() and kzalloc() can be NULL so it need to check NULL for them. - If one of those is failed, it need to add proper handler for avoiding memory leak. Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- drivers/staging/dgap/dgap.c | 49 +++ 1 files changed, 40 insertions(+), 9 deletions(-) This doesn't apply at all to my tree anymore, please refresh it and resend. thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v2 06/06] staging: crypto: skein: rename files
On Mon, May 19, 2014 at 07:45:10AM -0600, Jake Edge wrote: On Mon, 19 May 2014 12:09:59 +0400 Anton Saraev wrote: --- a/drivers/staging/skein/Makefile +++ b/drivers/staging/skein/Makefile @@ -4,10 +4,10 @@ subdir-ccflags-y := -I$(src)/include/ as part of the rearranging of files, I think you want to get rid of this include directory, move the files up to the main directory and include them as skein.h (rather than skein.h). Then this line can be removed from the Makefile. I agree, I'll not take this last one in the series. thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 2/7] staging: unisys: move uislib/platform proc entry to debugfs
On Mon, May 19, 2014 at 10:57:08PM +0300, Dan Carpenter wrote: On Mon, May 19, 2014 at 09:42:22AM -0500, Romer, Benjamin M wrote: On Sun, 2014-05-18 at 09:49 -0700, Greg KH wrote: Also, why are these entries moving to debugfs at all? Why are they needed? Who will use them? Are tools relying on them to be there? The tuning entries are sometimes used to help adjust the behavior of our IO service partitions for better performance. That sounds like it really belongs in sysfs instead of debugfs. Exactly. debugfs files are for debugging. Consider them files that your driver can work properly if no one ever touches them. tuning files imply something that has to be touched by users. Ideally, you would never need such a thing as no one wants to have to write things to files to make the kernel work better. But if you really need it, they should be sysfs files, with the needed documentation. thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: ozwpan: Change Maintainer
On Mon, May 19, 2014 at 03:17:30PM +0100, Rupesh Gujare wrote: I will be not able to work on ozwpan driver anymore. Remove my name add Tateno as maintainer. Signed-off-by: Rupesh Gujare rupesh.guj...@atmel.com --- MAINTAINERS |2 +- drivers/staging/ozwpan/TODO |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 0de64a5..3a9e4d83 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -8466,7 +8466,7 @@ S: Maintained F: drivers/staging/olpc_dcon/ STAGING - OZMO DEVICES USB OVER WIFI DRIVER -M: Rupesh Gujare rupesh.guj...@atmel.com +M: Shigekatsu Tateno shigekatsu.tat...@atmel.com Can I get an ack from Shigekatsu? I don't like adding someone as a maintainer if they don't know about it... thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: backporting stable fixes to staging after driver graduation
On Tue, May 20, 2014 at 02:17:26PM +0300, Tomas Winkler wrote: I'd like to ask what is the policy for back porting fixes for drivers that already graduated from staging but the fix is needed in kernel version where it is still in the staging. Same as anything else, just provide the backported patch to sta...@vger.kernel.org, and say it has been changed due to the file rename/movement. thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[GIT PULL] Staging driver fixes for 3.15-rc6
The following changes since commit 86281966c7395aa9a13a20c52e26005f5e142451: Merge tag 'iio-fixes-for-3.15b' of git://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio into staging-linus (2014-04-30 14:19:23 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/ staging-3.15-rc6 for you to fetch changes up to bb4e506565cfc0a2f534dfda1fb7ca5c26f7a604: staging: rtl8723au: Do not reset wdev-iftype in netdev_close() (2014-05-16 15:23:11 -0700) Staging driver fixes for 3.15-rc6 Here are 5 staging driver fixes for 3.15-rc6 that resolve some reported issues. They are for the imx and rtl8723au drivers. Signed-off-by: Greg Kroah-Hartman gre...@linuxfoundation.org Greg Kroah-Hartman (1): Merge branch 'imx-drm-fixes-urgent' of git://ftp.arm.linux.org.uk/~rmk/linux-arm into staging-linus Jes Sorensen (2): staging: rtl8723au: Use correct pipe type for USB interrupts staging: rtl8723au: Do not reset wdev-iftype in netdev_close() Philipp Zabel (1): imx-drm: imx-drm-core: fix imx_drm_encoder_get_mux_id Shawn Guo (2): imx-drm: imx-drm-core: skip components whose parent device is disabled imx-drm: imx-tve: correct DDC property name to 'ddc-i2c-bus' arch/arm/boot/dts/imx53-mba53.dts| 2 +- drivers/staging/imx-drm/imx-drm-core.c | 7 ++- drivers/staging/imx-drm/imx-tve.c| 2 +- drivers/staging/rtl8723au/os_dep/os_intfs.c | 2 -- drivers/staging/rtl8723au/os_dep/usb_ops_linux.c | 2 +- 5 files changed, 9 insertions(+), 6 deletions(-) ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: r8192e_pci driver broken 3.14+
On Wed, May 21, 2014 at 10:39:43PM -0400, Sean MacLennan wrote: On Sat, 19 Apr 2014 16:57:45 -0400 Sean MacLennan se...@seanm.ca wrote: A sparse error fixup removed a htons() which is required for the driver to function. This patch puts the htons() back and fixes the sparse warning correctly by changing the left side cast. Signed-off-by: Sean MacLennan se...@seanm.ca --- diff --git a/drivers/staging/rtl8192e/rtllib_tx.c b/drivers/staging/rtl8192e/rtllib_tx.c index 11d0a9d..b7dd153 100644 --- a/drivers/staging/rtl8192e/rtllib_tx.c +++ b/drivers/staging/rtl8192e/rtllib_tx.c @@ -171,7 +171,7 @@ inline int rtllib_put_snap(u8 *data, u16 h_proto) snap-oui[1] = oui[1]; snap-oui[2] = oui[2]; - *(u16 *)(data + SNAP_SIZE) = h_proto; + *(__be16 *)(data + SNAP_SIZE) = htons(h_proto); return SNAP_SIZE + sizeof(u16); } Any status on this patch? Ah, as the subject didn't look like a patch to apply, it got dropped from my patch queue. Care to resend it with a descriptive subject that matches things that we are expecting? thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 00/03] staging: Emma Mobile USB driver and KZM9D board code
On Thu, May 22, 2014 at 06:32:03PM +0900, Magnus Damm wrote: Hi Dan, On Thu, May 22, 2014 at 6:17 PM, Dan Carpenter dan.carpen...@oracle.com wrote: Generally we take things as is into staging so there is no need for a re-work if you don't want to. But we do need a TODO file. Read the TODO files for other staging drivers. Thanks for pointing that out, my apologies for being random and skipping that! I will add a TODO file to v2! Other than the missing TODO file, the idea looks good, I don't have any objections to taking this. thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: slicoss: fix use-after-free in slic_entry_probe
On Thu, May 22, 2014 at 09:25:40PM -0700, David Matlack wrote: Fix a use-after-free bug that can cause a kernel oops. If slic_card_init fails then slic_entry_probe() (the pci probe() function for this device) will return error without cleaning up memory (including the registered netdev struct). Signed-off-by: David Matlack matlackda...@gmail.com --- This patch was originally sent here https://lkml.org/lkml/2014/5/6/10 with my google.com email address. But due to Google's recent change in DMARC policies, that patchset was silently dropped for at least some users (including my personal gmail account). So I'm sending it out now with my gmail.com account. Let me know if this is an issue. Thanks. I think I've already applied all of these, if not, please let me know. Also, you forgot to number these patches to let me know what order to apply them in :( thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 0/6] Staging: unisys: code cleanup patches
On Thu, May 22, 2014 at 12:31:08PM -0500, Ken Cox wrote: This series of patches cleans up the unisys driver code in various ways: -fix sparse warnings related to accessing I/O space -fix sparse warnings related to dereferencing noderef types -add static to function declration -remove unused functions and macros How are you testing any of these given that the driver is still marked BROKEN? ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 4/6] Staging: unisys: Remove unused macros from visorchannel/visorchannel.h
On Thu, May 22, 2014 at 12:31:12PM -0500, Ken Cox wrote: VISORCHANNEL_CHANGE_SERVER_STATE and VISORCHANNEL_CHANGE_CLIENT_STATE are never used in any of the source so they have been removed. VISORCHANNEL_CHANGE_CLIENT_STATE would have caused a broken kernel build after commit a8d7f21d, but since it was never used the kernel continued to build. This whole driver is marked BROKEN, so it's not building no matter what :) ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 2/6] Staging: unisys: Fix sparse warnings in uislib
On Thu, May 22, 2014 at 12:31:10PM -0500, Ken Cox wrote: Added ULTRA_VBUS_IOinit_channel() and modified ULTRA_VBUS_init_channel() function so that it can operate on both memory space and IO space without getting sparse warnings. Signed-off-by: Ken Cox j...@redhat.com Don't add a new function with a name that is going to have to later be cleaned up as it doesn't follow our proper naming conventions. Please do it right the first time. I'm dropping this one. thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 2/2] staging: slicoss: handle errors from slic_config_get
On Thu, May 22, 2014 at 09:38:45PM -0700, David Matlack wrote: slic_config_get() can fail. Change the return type from void to int and handle the error in slic_card_init(). So now, instead of silently failing (and then timing out waiting for the config data), the driver will fail loudly at request time. Signed-off-by: David Matlack matlackda...@gmail.com --- drivers/staging/slicoss/slicoss.c | 28 1 file changed, 16 insertions(+), 12 deletions(-) It looks like I had already applied patch 1/2 here, but not this one, odd. Anyway, I've applied this, and should be synced up with you now. If I have missed applying anything, please resend. thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: lustre: lnet: klnds: Remove prohibited space in socklnd.c
On Wed, May 21, 2014 at 11:23:33PM +0100, Masaru Nomura wrote: Remove prohibited space between function name and open parenthesis to meet kernel coding style. Also, fix indenting due to changes. Signed-off-by: Masaru Nomura massa.nom...@gmail.com --- .../staging/lustre/lnet/klnds/socklnd/socklnd.c| 230 ++-- 1 file changed, 116 insertions(+), 114 deletions(-) This patch doesn't apply either, please refresh and resend. thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v2] staging: lustre: lnet: klnds: Fix coding style in socklnd.c
On Tue, May 20, 2014 at 12:03:23AM +0100, Masaru Nomura wrote: Remove prohibited space between function name and open parenthesis to meet kernel coding style. Also fix indenting due to changes to keep readability. I undid modifications to memset(...) which I made in previous patches as it could be removed based on the fact LIBCFS_ALLOC is executed before memset. With this, others can notice warnings against memset caused by checkpatch.pl and modify it easily. Signed-off-by: Masaru Nomura massa.nom...@gmail.com --- .../staging/lustre/lnet/klnds/socklnd/socklnd.c| 238 ++-- 1 file changed, 119 insertions(+), 119 deletions(-) This patch doesn't apply against my tree anymore. Can you please refresh it and resend? thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: comedi: ii_pci20kc: fix usage of uninit scalar in ii20k_attach()
On Sun, May 04, 2014 at 02:26:09AM +0200, Christian Engelmayer wrote: This driver supports the PCI-20001C-1a and PCI-20001C-2a carrier boards. The -2a version has 32 on-board DIO channels. In case this variant is detected, local variable 'has_dio' is set accordingly. Otherwise it is left uninitialized and the following subdevice instantiation depends on the stack. Detected by Coverity - CID 1077830. Signed-off-by: Christian Engelmayer cenge...@gmx.at Reviewed-by: Ian Abbott abbo...@mev.co.uk --- Compile tested and applies against branch staging-next of tree git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git It doesn't apply there at all for some odd reason, can you refresh it and resend? thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v2] staging: rtl8821ae: mark pci_mem_start (and _end) as __iomem
On Sun, May 04, 2014 at 02:22:19PM +0200, Martin Kepplinger wrote: Shared addresses can be marked as such. Signed-off-by: Martin Kepplinger mart...@posteo.de --- I guess that's what you meant. Thanks for your feedback! Yes, that is correct, but someone beat you to this patch, sorry :( ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: wlags49_h2: fix sparse warning should it be static
On Wed, May 07, 2014 at 06:31:48PM +0200, Luis Ortega wrote:
Fixes the following warning:
drivers/staging/wlags49_h2/sta_h2.c:4471:10: warning: symbol 'fw_image' was
not declared. Should it be static?
Signed-off-by: Luis Ortega luior...@gmail.com
---
drivers/staging/wlags49_h2/sta_h2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wlags49_h2/sta_h2.c
b/drivers/staging/wlags49_h2/sta_h2.c
index 0ba8def..2838faa 100644
--- a/drivers/staging/wlags49_h2/sta_h2.c
+++ b/drivers/staging/wlags49_h2/sta_h2.c
@@ -4468,7 +4468,7 @@ static const CFG_RANGE20_STRCT fw_image_infocompat[] = {
{ , , , , { { , , } } }/* endsentinel
*/
};
-memimage fw_image = {
+static memimage fw_image = {
FUPU7D37dhfwci\001C, /* signature, format number,
C/Bin type */
(CFG_PROG_STRCT *) fw_image_code,
0x000F368E,
ALWAYS test build your patches. This patch breaks the build :(
greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Greg caught up on staging patches
Hi all, Thanks to a trans-pacific flight, I think I'm now caught up on all drivers/staging/* patches that were sent to me before 10 hours ago. If you have sent something that I have not responded to, please consider it lost and please resend, after making sure it still applies on top of my latest tree. thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: slicoss: remove private netdev list
On Fri, May 23, 2014 at 01:11:01PM -0700, David Matlack wrote: Greg, this is one of the two patches that got dropped. It should apply cleanly in any order with respect to all my other patches. As my patch queue is now flushed out, what is this patch? :) Can you please just resend the two missing patches? thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] Staging: Silicom: Bypasslib: Fixed a couple of checkpatch.pl warnings
On Fri, May 23, 2014 at 02:39:43PM -0700, Chaitanya Hazarey wrote: Added a blank line after declarations to fix the following warnings issued by checkpatch.pl: drivers/staging/silicom/bypasslib/bypass.c:138: WARNING: Missing a blank line after declarations drivers/staging/silicom/bypasslib/bypass.c:189: WARNING: Missing a blank line after declarations Signed-off-by: Chaitanya Hazarey c...@24.io --- drivers/staging/silicom/bypasslib/bypass.c |2 ++ 1 file changed, 2 insertions(+) This patch doesn't apply cleanly. Can you please refresh it against my staging-next branch of staging.git on git.kernel.org and resend? thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] Staging: Silicom: bpctl_mod.c: Fixed a lot of checkpatch.pl warnings
On Fri, May 23, 2014 at 02:47:10PM -0700, Chaitanya Hazarey wrote: Added a blank line after declarations in many places to fix the following warning issued by checkpatch.pl: WARNING: Missing a blank line after declarations --- drivers/staging/silicom/bpctl_mod.c | 90 ++- 1 file changed, 88 insertions(+), 2 deletions(-) Something is corrupted in this patch and it doesn't apply properly. Can you resend it to yourself and try to figure out what went wrong? thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] Staging: Silicom: bpctl_mod.c bypass.c: Fixed a lot of checkpatch.pl warnings
On Fri, May 23, 2014 at 10:25:28PM -0700, Chaitanya Hazarey wrote: Added a blank line after declarations in many places to fix the following warning issued by checkpatch.pl: WARNING: Missing a blank line after declarations Thanks Greg K-H and Dan for the patience. Hope it works this time, I did apply it against staging and it was ok. Hm, something is odd, it still doesn't apply properly: $ p1 ../s1 checking file drivers/staging/silicom/bpctl_mod.c Hunk #40 FAILED at 4773. Hunk #41 FAILED at 4821. ... Hunk #89 FAILED at 7534. 3 out of 89 hunks FAILED Can you refresh this against my tree again and resend? I think we are out of sync here still. thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: gdm72xx: use time_before()
On Sun, May 25, 2014 at 03:08:59PM +0200, Manuel Schölling wrote: To be future-proof and for better readability the time comparisons are modified to use time_before() instead of plain, error-prone math. Signed-off-by: Manuel Schölling manuel.schoell...@gmx.de --- drivers/staging/gdm72xx/gdm_usb.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) This patch doesn't apply, can you please refresh it against my latest tree and resend? thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: gdm72xx: use time_before()
On Sun, May 25, 2014 at 08:24:33PM +0200, Manuel Schoelling wrote: On So, 2014-05-25 at 11:14 -0700, Greg KH wrote: On Sun, May 25, 2014 at 03:08:59PM +0200, Manuel Schölling wrote: To be future-proof and for better readability the time comparisons are modified to use time_before() instead of plain, error-prone math. Signed-off-by: Manuel Schölling manuel.schoell...@gmx.de --- drivers/staging/gdm72xx/gdm_usb.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) This patch doesn't apply, can you please refresh it against my latest tree and resend? That's weird. I pulled the lastest master from Linus and rebased the patch, but no modification of my patch was required (latest commit before my patch to that file was 8943a92fc257c439ffe55fb0f9896be57c58c56b according to my repo). Maybe you have a more recent version than Linus? I have a much different version from Linus, with a few thousand patches added, otherwise how would I be able to queue up stuff to go to Linus for the next kernel release? :) For the staging patches, either use the linux-next tree (which you should use for all kernel development), or my staging.git tree, and the staging-next branch on git.kernel.org, which is what gets pulled into linux-next every week-day. If you have more questions about this, take a look at Documentation/development-process/ it should explain how patches move to Linus and why working against Linus's tree isn't going to get you very far. thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] Staging: Silicom: bpctl_mod.c bypass.c: Fixed a lot of checkpatch.pl warnings
On Sun, May 25, 2014 at 11:59:08AM -0700, Chaitanya Hazarey wrote: Added a blank line after declarations in many places to fix the following warning issued by checkpatch.pl: WARNING: Missing a blank line after declarations Lets see if this works now, this patch is prepared against Greg's staging tree. What branch of my staging.git tree are you using? You should use the staging-next branch, this patch still doesn't apply to there :( greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 00/48] staging-next: rtl8723au: More fixes and removal of dead code
On Sun, May 25, 2014 at 10:43:00PM +0200, jes.soren...@redhat.com wrote: From: Jes Sorensen jes.soren...@redhat.com Hi Greg, Please find attached another round of cleanups, removal of dead code, and tidying up most of the #ifdef CONFIG_8723AU_BT_COEXIST mess. Notably patch 10 fixes an OOPS case if a user tries to add a monitor interface - monitor mode still doesn't work, but at least it doesn't wedge the kernel. This one could go for 3.15, but it's not a common use case. Patch 10 doesn't apply to my staging-linus branch, so I can't apply it there, but feel free to send me a version if you think it should go into 3.15-final. thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v3] staging: lustre: lnet: klnds: Fix coding style in socklnd.c
On Sun, May 25, 2014 at 11:24:12PM +0100, Masaru Nomura wrote: Remove prohibited space between function name and open parenthesis to meet kernel coding style. Also fix indenting due to changes to keep readability. -since v2: None. This is the resend of v2 as v2 failed to apply This should be below the --- line. And it still doesn't apply :( What branch did you make it against? greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v3] staging: lustre: lnet: klnds: Fix coding style in socklnd.c
On Sun, May 25, 2014 at 11:50:03PM +0100, Masaru Nomura wrote: 2014-05-25 23:37 GMT+01:00 Greg KH gre...@linuxfoundation.org: On Sun, May 25, 2014 at 11:24:12PM +0100, Masaru Nomura wrote: Remove prohibited space between function name and open parenthesis to meet kernel coding style. Also fix indenting due to changes to keep readability. -since v2: None. This is the resend of v2 as v2 failed to apply This should be below the --- line. I'm sorry for that. Will fix it. And it still doesn't apply :( What branch did you make it against? I'm using[1] which is your staging.git (is it correct?) and downloaded it today. So, there should not be a patch failure... :( What _branch_ of that git tree did you make it against? And please don't send html email, the mailing lists reject it. thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v3] staging: lustre: lnet: klnds: Fix coding style in socklnd.c
On Mon, May 26, 2014 at 12:57:39AM +0100, Masaru Nomura wrote: What _branch_ of that git tree did you make it against? I did my work against commit 4b660a7f5c8099d88d1a43d8ae138965112592c7 That is a commit, not a branch. Please work against the staging-next branch, not master. master reflects Linus's tree. thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] Staging: Silicom: bpctl_mod.c bypass.c: Adding blank lines
On Sun, May 25, 2014 at 05:36:58PM -0700, Chaitanya Hazarey wrote: Added a blank line after declarations in many places to fix the following warning issued by checkpatch.pl: Always wrap your lines at 72 columns, like git asks you to when you type in the commit message. WARNING: Missing a blank line after declarations The reason why it was not applying clean against Greg's tree was that bpctl_mod.c had changed in the functions which are a part of this patch. This doesn't belong as part of the changelog, right? Please resend and put it below the --- line, if you want to. Can you redo this with the changelog fixed up please? thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 1/1] staging: imx-drm: Remove unused variable
On Mon, May 26, 2014 at 02:28:44PM +0530, Sachin Kamat wrote: 'ret' is not used in the function. Remove it. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/staging/imx-drm/imx-tve.c |1 - 1 file changed, 1 deletion(-) This doesn't apply properly to my tree, can you refresh it against the latest staging-next branch of my staging.git tree and resend it? thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 03/15] staging: rtl8188eu:Remove unused macro _init_queue()
On Tue, May 27, 2014 at 09:05:43PM +0530, navin patidar wrote: Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8712/osdep_service.h |6 -- 1 file changed, 6 deletions(-) This is the rtl8712 driver, not the rtl8188eu driver. And this patch causes a build error. Please ALWAYS test your patches before sending them out :( thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 0/6] Staging: unisys: code cleanup patches
On Wed, May 28, 2014 at 06:01:17AM -0500, Ken Cox wrote: On 05/23/2014 06:18 AM, Greg KH wrote: On Thu, May 22, 2014 at 12:31:08PM -0500, Ken Cox wrote: This series of patches cleans up the unisys driver code in various ways: -fix sparse warnings related to accessing I/O space -fix sparse warnings related to dereferencing noderef types -add static to function declration -remove unused functions and macros How are you testing any of these given that the driver is still marked BROKEN? I'll send a patch to remove BROKEN from the Kconfig Are you sure that it is ok now? Are the issues that required that to be added now resolved? And why did I have to ask for this? You didn't answer my original question here... greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: android: fix Missing a blank line after declarations warnings
On Wed, May 28, 2014 at 06:52:51PM +1000, Scott Weir wrote: This patch corrects coding style issue: WARNING: Missing a black line after declarations Signed-off-by: Scott Weir sjw0...@gmail.com --- drivers/staging/android/sync_debug.c | 4 This file isn't in my tree. Always work against linux-next, not Linus's tree for new patches. thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 2/2] Staging: rtl8192u: r8192U_wx.c Added {} braces and newlines
On Wed, May 28, 2014 at 07:32:39AM -0700, Chaitanya Hazarey wrote:
-static int r8192_wx_set_scan_type(struct net_device *dev, struct
iw_request_info *aa, union
- iwreq_data *wrqu, char *p){
+static int r8192_wx_set_scan_type(struct net_device *dev, struct
iw_request_info *aa,
+ union iwreq_data *wrqu, char *p){
The '{' still isn't in the right place, but I'll let you fix that up in
a future patch.
thanks,
greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: r8192e_pci driver broken 3.14+
The Subject: here is not really that descriptive, I've fixed it up when committing it. Try to be a bit better for your next patch. thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 2/2] Staging: rtl8192u: r8192U_wx.c Various Code cleanups and code-style additions
On Wed, May 28, 2014 at 04:23:48PM -0700, Chaitanya Hazarey wrote: Removed dead code Deleted stray newlines Added newlines for better code readability These should all be broken up into individual patches. Remember, each patch should just do _one_ thing. thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: Anybody working on sep?
On Sat, Jul 26, 2014 at 10:55:11AM +0100, Alan Cox wrote: On Fri, 2014-07-25 at 21:54 -0700, Greg KH wrote: On Fri, Jul 25, 2014 at 10:54:47PM +0100, Alan Cox wrote: On Fri, 2014-07-25 at 20:17 +0300, Kristina Martšenko wrote: On 23/06/14 23:32, Kristina Martšenko wrote: Hi Mark, I'm helping Greg do a bit of cleanup in the staging tree. I noticed that nobody seems to have worked towards moving sep out of staging in over a year. Are there any plans to clean it up and move it out soon? No response from Mark here. Alan, Jayant, either of you know what the status of the sep staging driver is? I believe works last time anyone checked. I don't think we have anyone officially working on the early Intel phone cpus for upstream any more. So can we just drop it then? If no one is working on moving it out of staging, it should go. Probably Wonderful. Kristina, care to make up a patch that removes this? thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: vt6655: coding style: Fixed commenting style Few lines were crossing 80 characters limit
On Sun, Jul 27, 2014 at 04:51:43PM +0530, Rahul Garg wrote: Signed-off-by: Rahul Garg rahul.lnm...@gmail.com --- drivers/staging/vt6655/tcrc.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) I know this is a tiny patch, but you are doing two different things here, and your subject is hugely long. Can you break this up into 2 different patches, and provide a valid changelog body for what you are doing? thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: ft1000: fix some checkpatch complaints
On Sun, Jul 27, 2014 at 10:23:53AM -0700, Joe Perches wrote:
On Sun, 2014-07-27 at 19:08 +0200, Nicolas Thery wrote:
This patch fixes the following errors and warnings:
[]
diff --git a/drivers/staging/ft1000/ft1000-pcmcia/ft1000_proc.c
b/drivers/staging/ft1000/ft1000-pcmcia/ft1000_proc.c
[]
@@ -23,34 +23,38 @@
[]
-#define seq_putx(m, message, size, var) \
+#define seq_putx(m, message, size, var) do { \
seq_printf(m, message); \
for (i = 0; i (size - 1); i++) { \
seq_printf(m, %02x:, var[i]); \
} \
- seq_printf(m, %02x\n, var[i])
+ seq_printf(m, %02x\n, var[i]); \
+} while (0)
Ideally, these wouldn't depend on an external
i variable.
Maybe something like:
#define seq_putx(m, message, size, var) \
do { \
int _i; \
seq_printf(m, message); \
for (_i = 0; _i (size - 1); _i++) \
seq_printf(m, %02x:, var[_i]); \
seq_printf(m, %02x\n, var[_i]); \
} while (0)
-#define seq_putd(m, message, size, var) \
+#define seq_putd(m, message, size, var) do { \
seq_printf(m, message); \
for (i = 0; i (size - 1); i++) { \
seq_printf(m, %d., var[i]); \
} \
- seq_printf(m, %d\n, var[i])
+ seq_printf(m, %d\n, var[i]); \
+} while (0)
Maybe later change these to use the recently introduced
seq_hex_dump: https://lkml.org/lkml/2014/7/11/269
How about removing the proc files entirely, as I doubt they are really
needed :)
thanks,
greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 2/2 v4] staging: unisys: move parahotplug to sysfs
On Thu, Jul 24, 2014 at 10:55:09PM -0400, Benjamin Romer wrote:
Move the /proc/visorchipset/parahotplug interface to sysfs under
/sys/devices/platform/visorchipset/parahotplug/deviceenabled and
/sys/devices/platform/visorchipset/parahotplug/devicedisabled.
The parahotplug interface is used to deal with SR-IOV recovery situations on
s-Par guest partitions. The command service partition will send a message to a
guest when an SR-IOV device that guest is using needs to be temporarily
removed.
The message triggers a udev event that will cause a recovery script to run.
When that script has completed its work, it will write to one of the
parahotplug interfaces to send a message back to Command, indicating that the
recovery action has completed.
When a guest that is sharing an SR-IOV device is restarted, that guest will
take down the PF driver on the device, but any guests with VFs will not know
that their device needs to be reset as well. The recovery script makes it so
the device will be shut down fully and then restarted after the sharing guest
comes back up, and ensures that the timing is correct.
Moving this interface to sysfs orphans the visorchipset_proc_read_writeonly()
function, so it is also removed.
Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com
---
v4: this patch is unchanged from v3.
v3: The interface was split in two, so only the ID need be passed as a
parameter
to use the interfaces. Additional documentation was added.
v2: attribute creation was fixed and checks for controlvm_channel pointer were
removed.
.../unisys/visorchipset/visorchipset_main.c| 99
+-
1 file changed, 39 insertions(+), 60 deletions(-)
diff --git a/drivers/staging/unisys/visorchipset/visorchipset_main.c
b/drivers/staging/unisys/visorchipset/visorchipset_main.c
index 13f4da8..7a7f515 100644
--- a/drivers/staging/unisys/visorchipset/visorchipset_main.c
+++ b/drivers/staging/unisys/visorchipset/visorchipset_main.c
@@ -98,19 +98,11 @@ static CONTROLVM_MESSAGE_PACKET g_DeviceChangeStatePacket;
#define is_diagpool_channel(channel_type_guid) \
(uuid_le_cmp(channel_type_guid, UltraDiagPoolChannelProtocolGuid) == 0)
-#define VISORCHIPSET_PARAHOTPLUG_PROC_ENTRY_FN parahotplug
-static struct proc_dir_entry *parahotplug_proc_dir;
-
static LIST_HEAD(BusInfoList);
static LIST_HEAD(DevInfoList);
-static struct proc_dir_entry *ProcDir;
static VISORCHANNEL *ControlVm_channel;
-static ssize_t visorchipset_proc_read_writeonly(struct file *file,
- char __user *buf,
- size_t len, loff_t *offset);
-
typedef struct {
U8 __iomem *ptr;/* pointer to base address of payload pool */
U64 offset; /* offset from beginning of controlvm
@@ -293,6 +285,14 @@ static ssize_t chipsetready_store(struct device *dev,
struct device_attribute *attr, const char *buf, size_t count);
static DEVICE_ATTR_WO(chipsetready);
+static ssize_t devicedisabled_store(struct device *dev,
+ struct device_attribute *attr, const char *buf, size_t count);
+static DEVICE_ATTR_WO(devicedisabled);
+
+static ssize_t deviceenabled_store(struct device *dev,
+ struct device_attribute *attr, const char *buf, size_t count);
+static DEVICE_ATTR_WO(deviceenabled);
+
static struct attribute *visorchipset_install_attrs[] = {
dev_attr_toolaction.attr,
dev_attr_boottotool.attr,
@@ -317,9 +317,21 @@ static struct attribute_group visorchipset_guest_group =
{
.attrs = visorchipset_guest_attrs
};
+static struct attribute *visorchipset_parahotplug_attrs[] = {
+ dev_attr_devicedisabled.attr,
+ dev_attr_deviceenabled.attr,
+ NULL
+};
+
+static struct attribute_group visorchipset_parahotplug_group = {
+ .name = parahotplug,
+ .attrs = visorchipset_parahotplug_attrs
+};
+
static const struct attribute_group *visorchipset_dev_groups[] = {
visorchipset_install_group,
visorchipset_guest_group,
+ visorchipset_parahotplug_group,
NULL
};
@@ -1723,53 +1735,36 @@ parahotplug_process_message(CONTROLVM_MESSAGE *inmsg)
}
}
-/*
- * Gets called when the udev script writes to
- * /proc/visorchipset/parahotplug. Expects input in the form of id
- * active where id is the identifier passed to the script that
- * matches a request on the request list, and active is 0 or 1
- * indicating whether the device is now enabled or not.
+/* The parahotplug/devicedisabled interface gets called by our support script
+ * when an SR-IOV device has been shut down. The ID is passed to the script
+ * and then passed back when the device has been removed.
*/
-static ssize_t
-parahotplug_proc_write(struct file *file, const char __user *buffer,
-size_t count, loff_t *ppos)
+ssize_t devicedisabled_store(struct
Re: [PATCH] Staging: vt6655: removed redundant comments from device.h
On Fri, Jul 25, 2014 at 07:18:37PM +0300, Igor Bezukh wrote: Removed redundant comments from device.h header file. Signed-off-by: Igor Bezukh igb...@gmail.com --- drivers/staging/vt6655/device.h | 82 ++- 1 file changed, 21 insertions(+), 61 deletions(-) Doesn't apply to my tree, can you please refresh and resend? thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] Staging: vt6655: removed redundant comments from key.h
On Fri, Jul 25, 2014 at 07:37:45PM +0300, Igor Bezukh wrote: Removed redundant comments from key.h header file. Signed-off-by: Igor Bezukh igb...@gmail.com --- drivers/staging/vt6655/key.h | 26 +++--- 1 file changed, 7 insertions(+), 19 deletions(-) Also doesn't apply :( ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] Staging: vt6655: removed redundant comments from iwctl.h
On Fri, Jul 25, 2014 at 07:35:12PM +0300, Igor Bezukh wrote: Removed redundant comments from iwctl.h header file. Signed-off-by: Igor Bezukh igb...@gmail.com --- drivers/staging/vt6655/iwctl.h | 12 +--- 1 file changed, 1 insertion(+), 11 deletions(-) Also doesn't apply :( refresh please? thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] Staging: vt6655: removed redundant comments from mac.h
On Fri, Jul 25, 2014 at 07:45:53PM +0300, Igor Bezukh wrote: Removed redundant comments from mac.h header file. Signed-off-by: Igor Bezukh igb...@gmail.com --- drivers/staging/vt6655/mac.h | 388 -- 1 file changed, 188 insertions(+), 200 deletions(-) Also doesn't apply :( ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: Eudyptula Challenge (Task 10)
On Sun, Jul 27, 2014 at 08:56:38PM +0100, Liviu I. wrote: Hello Kernel Developers! I've attached a small patch to fix a coding style problem and make checkpatch happy, as part of challenge 10 of Eudyptula. Thank you --- drivers/staging/lustre/lustre/ldlm/ldlm_extent.c.orig 2014-07-27 20:26:53.714161698 +0100 +++ drivers/staging/lustre/lustre/ldlm/ldlm_extent.c 2014-07-27 20:27:50.410159692 +0100 @@ -151,7 +151,8 @@ static inline int lock_mode_to_index(ldl LASSERT(mode != 0); LASSERT(IS_PO2(mode)); - for (index = -1; mode; index++, mode = 1) ; + for (index = -1; mode; index++, mode = 1) + ; LASSERT(index LCK_MODE_NUM); return index; } Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - Your patch does not have a Signed-off-by: line. Please read the kernel file, Documentation/SubmittingPatches and resend it after adding that line. Note, the line needs to be in the body of the email, before the patch, not at the bottom of the patch or in the email signature. - You did not specify a description of why the patch is needed, or possibly, any description at all, in the email body. Please read the section entitled The canonical patch format in the kernel file, Documentation/SubmittingPatches for what is needed in order to properly describe the change. - You did not write a descriptive Subject: for the patch, allowing Greg, and everyone else, to know what this patch is all about. Please read the section entitled The canonical patch format in the kernel file, Documentation/SubmittingPatches for what a proper Subject: line should look like. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 1/1] drivers: staging: cxt1e1: linux.c - missing __user annotation
On Mon, Jul 28, 2014 at 08:38:29AM +0530, Anil Belur wrote:
From: Anil Belur ask...@gmail.com
- Some of the functions internally call copy_{to,from}_user() but does
not use '__user'. this patch fixes missing __user annotations.
- this patch fixes the following sparse errors:
drivers/staging/cxt1e1/linux.c:488:33: warning: incorrect type in argument 2
(different address spaces)
drivers/staging/cxt1e1/linux.c:488:33:expected void const [noderef]
asn:1*from
drivers/staging/cxt1e1/linux.c:488:33:got void *data
drivers/staging/cxt1e1/linux.c:499:26: warning: incorrect type in argument 1
(different address spaces)
drivers/staging/cxt1e1/linux.c:499:26:expected void [noderef] asn:1*to
drivers/staging/cxt1e1/linux.c:499:26:got void *data
drivers/staging/cxt1e1/linux.c:512:33: warning: incorrect type in argument 2
(different address spaces)
drivers/staging/cxt1e1/linux.c:512:33:expected void const [noderef]
asn:1*from
drivers/staging/cxt1e1/linux.c:512:33:got void *data
drivers/staging/cxt1e1/linux.c:534:33: warning: incorrect type in argument 2
(different address spaces)
drivers/staging/cxt1e1/linux.c:534:33:expected void const [noderef]
asn:1*from
drivers/staging/cxt1e1/linux.c:534:33:got void *data
drivers/staging/cxt1e1/linux.c:550:33: warning: incorrect type in argument 2
(different address spaces)
drivers/staging/cxt1e1/linux.c:550:33:expected void const [noderef]
asn:1*from
drivers/staging/cxt1e1/linux.c:550:33:got void *data
drivers/staging/cxt1e1/linux.c:558:26: warning: incorrect type in argument 1
(different address spaces)
drivers/staging/cxt1e1/linux.c:558:26:expected void [noderef] asn:1*to
drivers/staging/cxt1e1/linux.c:558:26:got void *data
drivers/staging/cxt1e1/linux.c:571:33: warning: incorrect type in argument 2
(different address spaces)
drivers/staging/cxt1e1/linux.c:571:33:expected void const [noderef]
asn:1*from
drivers/staging/cxt1e1/linux.c:571:33:got void *data
drivers/staging/cxt1e1/linux.c:580:26: warning: incorrect type in argument 1
(different address spaces)
drivers/staging/cxt1e1/linux.c:580:26:expected void [noderef] asn:1*to
drivers/staging/cxt1e1/linux.c:580:26:got void *data
drivers/staging/cxt1e1/linux.c:593:33: warning: incorrect type in argument 2
(different address spaces)
drivers/staging/cxt1e1/linux.c:593:33:expected void const [noderef]
asn:1*from
drivers/staging/cxt1e1/linux.c:593:33:got void *data
drivers/staging/cxt1e1/linux.c:601:26: warning: incorrect type in argument 1
(different address spaces)
drivers/staging/cxt1e1/linux.c:601:26:expected void [noderef] asn:1*to
drivers/staging/cxt1e1/linux.c:601:26:got void *data
drivers/staging/cxt1e1/linux.c:612:33: warning: incorrect type in argument 2
(different address spaces)
drivers/staging/cxt1e1/linux.c:612:33:expected void const [noderef]
asn:1*from
drivers/staging/cxt1e1/linux.c:612:33:got void *data
drivers/staging/cxt1e1/linux.c:620:26: warning: incorrect type in argument 1
(different address spaces)
drivers/staging/cxt1e1/linux.c:620:26:expected void [noderef] asn:1*to
drivers/staging/cxt1e1/linux.c:620:26:got void *data
drivers/staging/cxt1e1/linux.c:631:33: warning: incorrect type in argument 2
(different address spaces)
drivers/staging/cxt1e1/linux.c:631:33:expected void const [noderef]
asn:1*from
drivers/staging/cxt1e1/linux.c:631:33:got void *data
drivers/staging/cxt1e1/linux.c:647:33: warning: incorrect type in argument 2
(different address spaces)
drivers/staging/cxt1e1/linux.c:647:33:expected void const [noderef]
asn:1*from
drivers/staging/cxt1e1/linux.c:647:33:got void *data
drivers/staging/cxt1e1/linux.c:673:34: warning: incorrect type in argument 2
(different address spaces)
drivers/staging/cxt1e1/linux.c:673:34:expected void const [noderef]
asn:1*from
drivers/staging/cxt1e1/linux.c:673:34:got void *data
drivers/staging/cxt1e1/linux.c:681:26: warning: incorrect type in argument 1
(different address spaces)
drivers/staging/cxt1e1/linux.c:681:26:expected void [noderef] asn:1*to
drivers/staging/cxt1e1/linux.c:681:26:got void *data
drivers/staging/cxt1e1/linux.c:691:47: warning: incorrect type in argument 2
(different address spaces)
drivers/staging/cxt1e1/linux.c:691:47:expected void const [noderef]
asn:1*from
drivers/staging/cxt1e1/linux.c:691:47:got void *data
drivers/staging/cxt1e1/linux.c:738:33: warning: incorrect type in argument 2
(different address spaces)
drivers/staging/cxt1e1/linux.c:738:33:expected void const [noderef]
asn:1*from
drivers/staging/cxt1e1/linux.c:738:33:got void *data
drivers/staging/cxt1e1/linux.c:785:33: warning: incorrect type in argument 2
(different address spaces)
drivers/staging/cxt1e1/linux.c:785:33:expected void const [noderef]
asn:1*from
drivers/staging/cxt1e1/linux.c:785:33:got void *data
Re: [PATCH] Staging: android: Missing a blank line after declarations in sw_sync.c This is a patch to the sw_sync.c file that fixes up a missing a blank warning found by the checkpatch.pl tool
On Mon, Jul 28, 2014 at 11:07:40PM +0200, adrianremo...@gmail.com wrote: From: Adrian Remonda adrianremo...@gmail.com Your changelog text is up there in the subject, not down here in the body of the email :( ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] Staging: rtl8192u: Staticfy debug method.
On Wed, Jul 30, 2014 at 11:33:41PM +0200, fernando.apesteg...@gmail.com wrote:
From: Fernando Apesteguia fernando.apesteg...@gmail.com
Add static to debug method.
Signed-off-by: Fernando Apesteguia fernando.apesteg...@gmail.com
---
drivers/staging/rtl8192u/r8192U_core.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/r8192U_core.c
b/drivers/staging/rtl8192u/r8192U_core.c
index 7640386..c732a67 100644
--- a/drivers/staging/rtl8192u/r8192U_core.c
+++ b/drivers/staging/rtl8192u/r8192U_core.c
@@ -667,7 +667,7 @@ static void tx_timeout(struct net_device *dev)
/* this is only for debug */
-void dump_eprom(struct net_device *dev)
+static void dump_eprom(struct net_device *dev)
{
int i;
for (i = 0; i 63; i++)
Someone sent this patch just before you :(
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v3] staging: vt6655: ioctl.c - missing __user annotation
On Wed, Jul 30, 2014 at 06:29:57PM +0530, Anil Belur wrote:
- private_ioctl() internally calls copy_{to,from}_user() and does
not use '__user' which gives out several sparse warnings
- these sparse warnings were fixed by adding __user annotation to
the data member of struct tagSCmdRequest:
drivers/staging/vt6655/ioctl.c:78:51: warning: incorrect type in argument 2
(different address spaces)
drivers/staging/vt6655/ioctl.c:78:51:expected void const [noderef]
asn:1*from
drivers/staging/vt6655/ioctl.c:78:51:got void *data
Signed-off-by: Anil Belur ask...@gmail.com
---
v2:
- replaced the 'void __user *' casts by adding '__user' annotation to the
data member of struct
tagSCmdRequest which is much cleaner approach as suggested by
tklau...@distanz.ch
v1:
- added 'void __user *' casts to supress the warnings
drivers/staging/vt6655/iocmd.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/vt6655/iocmd.h b/drivers/staging/vt6655/iocmd.h
index e499f1b..dd12498 100644
--- a/drivers/staging/vt6655/iocmd.h
+++ b/drivers/staging/vt6655/iocmd.h
@@ -100,7 +100,7 @@ typedef enum tagWZONETYPE {
#pragma pack(1)
typedef struct tagSCmdRequest {
u8 name[16];
- void*data;
+ void __user *data;
u16 wResult;
u16 wCmdCode;
} SCmdRequest, *PSCmdRequest;
This patch doesn't apply against my tree at all, what did you make it
against?
Always work against linux-next, or the staging-next branch of my
staging.git tree on git.kernel.org.
thanks,
greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 2/8] staging: unisys: remove U16 type
On Tue, Jul 29, 2014 at 03:09:41PM -0400, Benjamin Romer wrote: This patch switches all use of the U16 typedef to use the kernel's u16 type instead. Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com --- .../include/channels/controlframework.h| 18 .../include/channels/controlvmchannel.h| 24 +++--- .../common-spar/include/channels/diagchannel.h | 8 .../common-spar/include/channels/iochannel.h | 22 ++-- .../unisys/common-spar/include/vmcallinterface.h | 4 ++-- drivers/staging/unisys/include/commontypes.h | 1 - drivers/staging/unisys/include/uisqueue.h | 2 +- .../unisys/visorchipset/visorchipset_main.c| 12 +-- 8 files changed, 45 insertions(+), 46 deletions(-) This patch fails to apply at all, due to your previous patches: checking file drivers/staging/unisys/visorchipset/visorchipset_main.c Hunk #1 succeeded at 757 (offset 12 lines). Hunk #2 succeeded at 1672 (offset 12 lines). Hunk #3 FAILED at 1772. Hunk #4 succeeded at 2028 (offset -35 lines). Hunk #5 succeeded at 2053 (offset -35 lines). 1 out of 5 hunks FAILED Please redo this series (I fuzzed the first one into place, don't resend that.) thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] Staging: android: sw_sync.c: fix missing blank line after declaration
On Mon, Jul 28, 2014 at 07:38:23PM -0300, Murilo Opsfelder Araujo wrote:
Fix coding style issue.
Signed-off-by: Murilo Opsfelder Araujo mopsfel...@gmail.com
---
drivers/staging/android/sw_sync.c |2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/android/sw_sync.c
b/drivers/staging/android/sw_sync.c
index a76db3f..863d4b1 100644
--- a/drivers/staging/android/sw_sync.c
+++ b/drivers/staging/android/sw_sync.c
@@ -97,6 +97,7 @@ static void sw_sync_pt_value_str(struct sync_pt *sync_pt,
char *str, int size)
{
struct sw_sync_pt *pt = (struct sw_sync_pt *)sync_pt;
+
snprintf(str, size, %d, pt-value);
}
@@ -156,6 +157,7 @@ static int sw_sync_open(struct inode *inode, struct file
*file)
static int sw_sync_release(struct inode *inode, struct file *file)
{
struct sw_sync_timeline *obj = file-private_data;
+
sync_timeline_destroy(obj-obj);
return 0;
}
Does not apply to my tree at all :(
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] Staging: android: sync.c: fix missing blank line after declaration
On Mon, Jul 28, 2014 at 08:03:46PM -0300, Murilo Opsfelder Araujo wrote:
Fix coding style issue.
Signed-off-by: Murilo Opsfelder Araujo mopsfel...@gmail.com
---
drivers/staging/android/sync.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/android/sync.c b/drivers/staging/android/sync.c
index e7b2e02..69c16cb 100644
--- a/drivers/staging/android/sync.c
+++ b/drivers/staging/android/sync.c
@@ -705,6 +705,7 @@ static long sync_fence_ioctl(struct file *file, unsigned
int cmd,
unsigned long arg)
{
struct sync_fence *fence = file-private_data;
+
switch (cmd) {
case SYNC_IOC_WAIT:
return sync_fence_ioctl_wait(fence, arg);
@@ -726,4 +727,3 @@ static const struct file_operations sync_fence_fops = {
.unlocked_ioctl = sync_fence_ioctl,
.compat_ioctl = sync_fence_ioctl,
};
-
Also doesn't apply, are you sure you are using the staging-next branch
of staging.git on git.kernel.org?
thanks,
greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging:r8190: coding style: Fixed checkpatch reported Error
On Tue, Jul 29, 2014 at 04:41:53PM +0530, Sanjeev Sharma wrote: This is a patch to the r8190_rtl8256.c file that fixes checkpatch reported space coding style issues. Signed-off-by: Sanjeev Sharmasanjeev_sha...@mentor.com Please use a ' ' character... Please resend all of your patches, they don't have signed-off-by lines, and I don't know what order to apply them in, even if I could do so. greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] Staging: android: sync.c: fix missing blank line after declaration
On Thu, Jul 31, 2014 at 08:47:07AM -0300, Murilo Opsfelder Araujo wrote: On 07/30/2014 09:17 PM, Greg KH wrote: Also doesn't apply, are you sure you are using the staging-next branch of staging.git on git.kernel.org? I was using linux-next, not staging-next. sync.c has no checkpatch.pl warnings in staging-next. Sorry for the false alarm, guys. Ah, this is the fun thing where that code is being changed in two different trees. This sometimes happens, sorry about that. Wait for 3.17-rc1 to be out before touching this code again, as that will have everything merged properly in one tree. Sorry for the confusion. greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 2/2] staging: rlt8192u: conditional compilation in r8192U_core.c
On Tue, Jun 24, 2014 at 02:46:55PM +0200, Antoine Schweitzer-Chaput wrote:
function dump_eprom is only used when DEBUG_EPROM is set.
function txqueue2outpipe is only used when USE_ONE_PIPE is unset.
function GetRxPacketShiftBytes819xUsb is only used when
USB_RX_AGGREGATION_SUPPORT is set.
Compile these functions only when they will actually be used.
Signed-off-by: Antoine Schweitzer-Chaput anto...@schweitzer-chaput.fr
---
drivers/staging/rtl8192u/r8192U_core.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8192U_core.c
b/drivers/staging/rtl8192u/r8192U_core.c
index 4536a87..b6718c0 100644
--- a/drivers/staging/rtl8192u/r8192U_core.c
+++ b/drivers/staging/rtl8192u/r8192U_core.c
@@ -667,12 +667,14 @@ static void tx_timeout(struct net_device *dev)
/* this is only for debug */
+#ifdef DEBUG_EPROM
how can this ever be set? If no one sets it, just remove the code
entirely please.
static void dump_eprom(struct net_device *dev)
{
int i;
for (i = 0; i 63; i++)
RT_TRACE(COMP_EPROM, EEPROM addr %x : %x, i, eprom_read(dev,
i));
}
+#endif
void rtl8192_update_msr(struct net_device *dev)
{
@@ -1553,6 +1555,7 @@ u16 N_DBPSOfRate(u16 DataRate)
return N_DBPS;
}
+#ifndef USE_ONE_PIPE
Same here, if the option can never be selected, just delete the code.
static unsigned int txqueue2outpipe(struct r8192_priv *priv,
unsigned int tx_queue)
{
@@ -1562,6 +1565,7 @@ static unsigned int txqueue2outpipe(struct r8192_priv
*priv,
}
return priv-txqueue_to_outpipemap[tx_queue];
}
+#endif
short rtl819xU_tx_cmd(struct net_device *dev, struct sk_buff *skb)
{
@@ -4874,18 +4878,18 @@ static void query_rxdesc_status(struct sk_buff *skb,
}
+#ifdef USB_RX_AGGREGATION_SUPPORT
Same here.
Care to do this series all over, just delete the functions entirely.
thanks,
greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 1/1] staging: rtl8192u: remove unselectable options DEBUG_*, USE_ONE_PIPE, USB_RX_AGGREGATION_SUPPORT, USB_TX_DRIVER_AGGREGATION_ENABLE
On Tue, Jun 24, 2014 at 03:52:05PM +0200, Antoine Schweitzer-Chaput wrote: The code which was only reachable using these options is also removed. Signed-off-by: Antoine Schweitzer-Chaput anto...@schweitzer-chaput.fr --- drivers/staging/rtl8192u/Makefile | 3 - drivers/staging/rtl8192u/r8192U_core.c | 482 ++--- 2 files changed, 16 insertions(+), 469 deletions(-) diff --git a/drivers/staging/rtl8192u/Makefile b/drivers/staging/rtl8192u/Makefile index eefc657..703c150 100644 --- a/drivers/staging/rtl8192u/Makefile +++ b/drivers/staging/rtl8192u/Makefile @@ -6,9 +6,6 @@ ccflags-y += -O2 ccflags-y += -DCONFIG_FORCE_HARD_FLOAT=y ccflags-y += -DJACKSON_NEW_8187 -DJACKSON_NEW_RX ccflags-y += -DTHOMAS_BEACON -DTHOMAS_TASKLET -DTHOMAS_SKB -DTHOMAS_TURBO -#ccflags-y += -DUSB_TX_DRIVER_AGGREGATION_ENABLE -#ccflags-y += -DUSB_RX_AGGREGATION_SUPPORT -ccflags-y += -DUSE_ONE_PIPE Why delete this last one if it is being set? Did you test this change on hardware? thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 1/1] staging: rtl8192u: remove unselectable options DEBUG_*, USE_ONE_PIPE, USB_RX_AGGREGATION_SUPPORT, USB_TX_DRIVER_AGGREGATION_ENABLE
On Fri, Aug 01, 2014 at 07:31:10PM +0200, Antoine Schweitzer-Chaput wrote: On Fri, Aug 01, 2014 at 08:54:07AM -0700, Greg KH wrote: On Tue, Jun 24, 2014 at 03:52:05PM +0200, Antoine Schweitzer-Chaput wrote: The code which was only reachable using these options is also removed. Signed-off-by: Antoine Schweitzer-Chaput anto...@schweitzer-chaput.fr --- drivers/staging/rtl8192u/Makefile | 3 - drivers/staging/rtl8192u/r8192U_core.c | 482 ++--- 2 files changed, 16 insertions(+), 469 deletions(-) diff --git a/drivers/staging/rtl8192u/Makefile b/drivers/staging/rtl8192u/Makefile index eefc657..703c150 100644 --- a/drivers/staging/rtl8192u/Makefile +++ b/drivers/staging/rtl8192u/Makefile @@ -6,9 +6,6 @@ ccflags-y += -O2 ccflags-y += -DCONFIG_FORCE_HARD_FLOAT=y ccflags-y += -DJACKSON_NEW_8187 -DJACKSON_NEW_RX ccflags-y += -DTHOMAS_BEACON -DTHOMAS_TASKLET -DTHOMAS_SKB -DTHOMAS_TURBO -#ccflags-y += -DUSB_TX_DRIVER_AGGREGATION_ENABLE -#ccflags-y += -DUSB_RX_AGGREGATION_SUPPORT -ccflags-y += -DUSE_ONE_PIPE Why delete this last one if it is being set? Since it is always set, and not modifiable anywhere, it allows removing the code in r8192U_core.c under #ifndef USE_ONE_PIPE Ah, I missed it was ifndef, sorry about that. Actually that points out that this should be broken up into smaller patches to make it easier to review, as I sure got that wrong. Can you do it one-patch-per-define you are removing? thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
