On Thu, Jul 10, 2014 at 11:04:13AM +0200, Luca Ellero wrote:
Signed-off-by: Luca Ellero luca.ell...@brickedbrain.com
Which checkpatch warnings?
Please be specific.
___
devel mailing list
de...@linuxdriverproject.org
On Thu, Jul 10, 2014 at 11:04:15AM +0200, Luca Ellero wrote:
Signed-off-by: Luca Ellero luca.ell...@brickedbrain.com
---
drivers/staging/ced1401/ced_ioc.c | 212
+++--
1 file changed, 131 insertions(+), 81 deletions(-)
That's a lot of changes all in one
On Thu, Jul 10, 2014 at 05:54:57PM +0530, sanjeev sharma wrote:
From: sanjeev sharma sanjeev_sha...@mentor.com
This patch will fix too long lines warning
reported by checkpatch.pl.
Signed-off-by: Sanjeev Sharma sanjeev_sha...@mentor.com
---
drivers/staging/rtl8192u/r819xU_phy.c | 9
On Fri, Jul 11, 2014 at 07:11:45PM -0400, Erik Arfvidson wrote:
This patch adds the virtpci debugfs directory and the info entry
inside of it.
Signed-off-by: Erik Arfvidson erik.arfvid...@unisys.com
Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com
---
v3: Fixed formating and
On Fri, Jul 11, 2014 at 03:39:48PM +0100, Ian Abbott wrote:
On 2014-07-11 15:38, Ian Abbott wrote:
From: Andrey Utkin andrey.krieger.ut...@gmail.com
From: Andrey Utkin andrey.krieger.ut...@gmail.com
Dammit! Greg, do you want to sort that out or should I have another go?
Heh, no worries,
On Fri, Jul 11, 2014 at 06:21:27PM -0700, Joe Perches wrote:
A simple script to run checkpatch --fix for various types of
of cleanups.
This script is useful primarily for staging.
This reformats code to a more CodingStyle conforming style,
compiles it, verifies that the object code hasn't
On Fri, Jul 11, 2014 at 06:21:27PM -0700, Joe Perches wrote:
A simple script to run checkpatch --fix for various types of
of cleanups.
This script is useful primarily for staging.
This reformats code to a more CodingStyle conforming style,
compiles it, verifies that the object code hasn't
On Fri, Jul 11, 2014 at 06:21:27PM -0700, Joe Perches wrote:
A simple script to run checkpatch --fix for various types of
of cleanups.
This script is useful primarily for staging.
This reformats code to a more CodingStyle conforming style,
compiles it, verifies that the object code hasn't
On Fri, Jul 11, 2014 at 06:21:27PM -0700, Joe Perches wrote:
A simple script to run checkpatch --fix for various types of
of cleanups.
This script is useful primarily for staging.
This reformats code to a more CodingStyle conforming style,
compiles it, verifies that the object code hasn't
On Fri, Jul 11, 2014 at 06:46:52PM -0700, Joe Perches wrote:
On Fri, 2014-07-11 at 18:39 -0700, Greg KH wrote:
On Fri, Jul 11, 2014 at 06:21:27PM -0700, Joe Perches wrote:
A simple script to run checkpatch --fix for various types of
of cleanups.
]
drivers/staging/lustre/include/linux
On Fri, Jul 11, 2014 at 07:01:14PM -0700, Greg KH wrote:
On Fri, Jul 11, 2014 at 06:46:52PM -0700, Joe Perches wrote:
On Fri, 2014-07-11 at 18:39 -0700, Greg KH wrote:
On Fri, Jul 11, 2014 at 06:21:27PM -0700, Joe Perches wrote:
A simple script to run checkpatch --fix for various types
On Fri, Jul 11, 2014 at 06:57:24PM -0700, Joe Perches wrote:
On Fri, 2014-07-11 at 18:53 -0700, Greg KH wrote:
On Fri, Jul 11, 2014 at 06:21:27PM -0700, Joe Perches wrote:
A simple script to run checkpatch --fix for various types of
of cleanups.
[]
Anyway, try running this script
On Fri, Jul 11, 2014 at 07:09:30PM -0700, Joe Perches wrote:
There's a useless + use that needs to be removed as perl 5.20
emits a Useless use of greediness modifier '+' message each
time it's hit.
Reported-by: Greg KH gre...@linuxfoundation.org
Signed-off-by: Joe Perches j...@perches.com
On Fri, Jul 11, 2014 at 06:40:16PM -0700, Joe Perches wrote:
On Fri, 2014-07-11 at 18:34 -0700, Greg KH wrote:
On Fri, Jul 11, 2014 at 06:21:27PM -0700, Joe Perches wrote:
A simple script to run checkpatch --fix for various types of
of cleanups.
This script is useful primarily
On Fri, Jul 11, 2014 at 06:57:24PM -0700, Joe Perches wrote:
On Fri, 2014-07-11 at 18:53 -0700, Greg KH wrote:
On Fri, Jul 11, 2014 at 06:21:27PM -0700, Joe Perches wrote:
A simple script to run checkpatch --fix for various types of
of cleanups.
[]
Anyway, try running this script
On Fri, Jul 11, 2014 at 06:21:27PM -0700, Joe Perches wrote:
A simple script to run checkpatch --fix for various types of
of cleanups.
This script is useful primarily for staging.
This reformats code to a more CodingStyle conforming style,
compiles it, verifies that the object code hasn't
On Sat, Jul 12, 2014 at 12:30:43PM +0300, Dan Carpenter wrote:
On Fri, Jul 11, 2014 at 06:40:16PM -0700, Joe Perches wrote:
On Fri, 2014-07-11 at 18:34 -0700, Greg KH wrote:
On Fri, Jul 11, 2014 at 06:21:27PM -0700, Joe Perches wrote:
A simple script to run checkpatch --fix for various
On Sat, Jul 12, 2014 at 11:29:37AM -0700, Joe Perches wrote:
On Sat, 2014-07-12 at 10:55 -0700, Greg KH wrote:
Yes, the warnings are all due to line-length, but Joe, you shouldn't add
a patch that causes more checkpatch warnings than before :)
Yeah, that was intentional though
On Sat, Jul 12, 2014 at 09:55:56PM +0200, Peter Senna Tschudin wrote:
This patch fixes the following checkpatch warnings:
- Remove else after return
- Add space after declaration
Tested by compilation only.
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
On Sat, Jul 12, 2014 at 01:23:10PM -0700, Greg KH wrote:
On Sat, Jul 12, 2014 at 09:55:56PM +0200, Peter Senna Tschudin wrote:
This patch fixes the following checkpatch warnings:
- Remove else after return
- Add space after declaration
Tested by compilation only.
Signed-off
The following changes since commit cd3de83f147601356395b57a8673e9c5ff1e59d1:
Linux 3.16-rc4 (2014-07-06 12:37:51 -0700)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/
tags/staging-3.16-rc5
for you to fetch changes up to
On Fri, Jun 27, 2014 at 05:11:45PM +0200, Luca Ellero wrote:
Hi Greg,
On 27/06/2014 16:55, Greg KH wrote:
On Fri, Jun 27, 2014 at 03:04:43PM +0200, Luca Ellero wrote:
Il 26/06/2014 21:23, Greg KH ha scritto:
On Thu, Jun 26, 2014 at 09:36:17AM +0200, Alois Schloegl wrote:
On 2014-06-18 13
On Sun, Jul 13, 2014 at 05:39:55PM +0200, Peter Senna Tschudin wrote:
This patch cleanup coding style issues reported by checkpatch.
Tested by compilation only.
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
Based on latest staging-next.
You just sent me 4 patches, all
On Sun, Jul 13, 2014 at 09:11:18PM +0200, Peter Senna Tschudin wrote:
This patch cleanup coding style issues reported by checkpatch.
Tested by compilation only.
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
Cahnges from V1:
- Sent all patches in a series
Why did you
On Sun, Jul 13, 2014 at 11:47:57PM +0200, Joerg C. Meyer wrote:
Signed-off-by: Joerg C. Meyer jo...@meyer.homedns.org
Your changelog body ended up in the Subject: line (that happens if you
don't put a blank line after the first line in your git commit.
Also, you don't say _what_ issues you
On Mon, Jul 14, 2014 at 10:59:32AM +0200, Peter Senna Tschudin wrote:
On Sun, Jul 13, 2014 at 12:36:47PM -0700, Greg KH wrote:
On Sun, Jul 13, 2014 at 09:11:18PM +0200, Peter Senna Tschudin wrote:
This patch cleanup coding style issues reported by checkpatch.
Tested by compilation
On Mon, Jul 14, 2014 at 11:42:33AM +0200, Joerg C. Meyer wrote:
This is a patch to the cam.c file that fix a coding style error (do not use
C99 // comments)
Signed-off-by: Joerg C. Meyer jo...@meyer.homedns.org
Minor nit, you need a blank line between these two lines...
---
On Mon, Jul 14, 2014 at 04:09:26PM +0200, Joerg C. Meyer wrote:
This is a patch to the cam.c file that removes some obsolete C99 style
comments
Signed-off-by: Joerg C. Meyer jo...@meyer.homedns.org
4 copies of the same patch?
Anyway, this text doesn't match what the patch actually does
On Mon, Jul 14, 2014 at 07:01:37PM +0200, Peter Senna Tschudin wrote:
note
I'm not trying to push my changes over the rules. I'm trying to
understand the problem, to avoid creating similar noise in the future.
/note
Now I understand that the problem with the series of 4 patches is that
the
On Tue, Jul 15, 2014 at 06:13:19AM +0300, sam-the-6 wrote:
From: Sam Asadi asadi.sam...@gmail.com
Signed-off-by: Sam Asadi asadi.sam...@gmail.com
Where are the other 90 patches in this series, I only received 91, 92,
93, and 94. Wait, 94 out of 93 What is going on here?
On Tue, Jul 15, 2014 at 06:15:44AM +0300, sam-the-6 wrote:
From: Sam Asadi asadi.sam...@gmail.com
fixed a coding style issue.
Your Subject: does not match the body of the patch at all, why not?
Please be descriptive as to what you are doing.
Also, only do one thing per patch, and one thing
On Tue, Jul 15, 2014 at 04:19:22PM +0300, sam-the-6 wrote:
From: Sam Asadi asadi.sam...@gmail.com
3 files in 'staging/comedi/drivers/' revised again
and style issues fixed
Signed-off-by: Sam Asadi asadi.sam...@gmail.com
modified: drivers/staging/comedi/drivers/8253.h
On Tue, Jul 15, 2014 at 10:36:43AM -0400, Erik Arfvidson wrote:
This patch adds the virtpci debugfs directory and the info entry
inside of it.
Signed-off-by: Erik Arfvidson erik.arfvid...@unisys.com
Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com
---
v4: Fixed comments, upper bound
On Mon, Jul 14, 2014 at 09:15:28PM +0200, Peter Senna Tschudin wrote:
This patch cleans up the following checkpatch issues:
- tabs instead of spaces on the beginning of a line
- use correct /* */ comment style
- put { and } on the correct places
- line over 80 chars
- indentation style
On Mon, Jul 14, 2014 at 09:15:31PM +0200, Peter Senna Tschudin wrote:
This patch removes uneeded typedefs reported by chackpatch and removes
one enum. The removed enum from card.h:
typedef enum _CARD_PHY_TYPE {
PHY_TYPE_AUTO = 0,
PHY_TYPE_11B,
PHY_TYPE_11G,
PHY_TYPE_11A
}
On Mon, Jul 14, 2014 at 09:15:33PM +0200, Peter Senna Tschudin wrote:
This patch fixes a checkpatch warning by replacing printk by pr_warn.
Tested by compilation only.
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
Cahnges from V3:
- Splitted the patches by change type
On Tue, Jul 15, 2014 at 06:11:44PM +0900, Daeseok Youn wrote:
The dgap_err() is printing a message with pr_err(),
so all those are replaced.
Use definition pr_fmt and then all of dgap: in
the beginning of print messages are removed.
And also removed out of memory message because
the
On Tue, Jul 15, 2014 at 06:14:25PM +0900, Daeseok Youn wrote:
When a configration file is parsed with dgap_parsefile(),
makes nodes for saving configrations for board.
configuration files should not be parsed in the kernel at all. That
logic should be removed as it should not be needed.
Mark,
On Tue, Jul 15, 2014 at 11:31:03AM -0400, Erik Arfvidson wrote:
On 07/15/2014 10:45 AM, Greg KH wrote:
[SNIP]
+#define MAX_BUF 16384
Lovely magic number, care to explain why this is this size?
Assuming we have the maximum possible configuration:
4 busses, 32 devices per bus, and we
On Tue, Jul 15, 2014 at 11:38:16AM -0400, Erik Arfvidson wrote:
This patch adds the virtpci debugfs directory and the info entry
inside of it.
Signed-off-by: Erik Arfvidson erik.arfvid...@unisys.com
Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com
---
v5: Adjusted comments and
On Tue, Jul 15, 2014 at 07:53:07PM +0300, Sam Asadi wrote:
From: Simon Horman horms+rene...@verge.net.au
There are a number of DT and defconfig files which
are maintained as part of shmobile but have not been
listed as such in the MAINTAINERS file. This creates
confusion from time to time.
On Tue, Jul 15, 2014 at 10:05:30AM -0700, Greg KH wrote:
On Tue, Jul 15, 2014 at 07:53:07PM +0300, Sam Asadi wrote:
From: Simon Horman horms+rene...@verge.net.au
There are a number of DT and defconfig files which
are maintained as part of shmobile but have not been
listed
Patch 95/95? Really? Where are the other 94 patches in this series?
:(
Please look at what you are doing here, does it make sense?
On Tue, Jul 15, 2014 at 08:04:35PM +0300, Sam Asadi wrote:
a revision to the file that previously had several style issues.
It's clean now.
What does this
On Mon, Jul 14, 2014 at 10:56:32PM -0500, Larry Finger wrote:
Commit 4fb6a37c3f94c1cb4b828bfcc4347771e1628f88 by Andrey Utkin
andrey.krieger.ut...@gmail.com and entitled staging: rtl8192ee:
Correct bitmask in comparsion fixed what appeared to be a typo. After
consultation with the Realtek
On Wed, Jul 16, 2014 at 08:21:30AM +0900, DaeSeok Youn wrote:
Hi,
2014-07-16 0:29 GMT+09:00 Greg KH gre...@linuxfoundation.org:
On Tue, Jul 15, 2014 at 06:11:44PM +0900, Daeseok Youn wrote:
The dgap_err() is printing a message with pr_err(),
so all those are replaced.
Use definition
On Tue, Jul 15, 2014 at 10:05:54PM +0200, Peter Senna Tschudin wrote:
On Tue, Jul 15, 2014 at 5:06 PM, Greg KH gre...@linuxfoundation.org wrote:
On Mon, Jul 14, 2014 at 09:15:31PM +0200, Peter Senna Tschudin wrote:
This patch removes uneeded typedefs reported by chackpatch and removes
one
On Tue, Jul 15, 2014 at 01:30:42PM -0400, Benjamin Romer wrote:
Move the proc entry for controlling the toolaction field to sysfs. The field
appears in /sys/devices/platform/visorchipset/install/toolaction.
This field is used to tell s-Par which type of recovery tool action to perform
on the
On Tue, Jul 15, 2014 at 10:46:49PM +0200, Peter Senna Tschudin wrote:
This patch fixes a checkpatch warning by replacing printk
by dev_warn. Tested by compilation only.
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
Changes from V4:
- use dev_warn instead of pr_warn
On Wed, Jul 16, 2014 at 06:26:17PM +0900, DaeSeok Youn wrote:
2014-07-16 8:50 GMT+09:00 Greg KH gre...@linuxfoundation.org:
On Wed, Jul 16, 2014 at 08:21:30AM +0900, DaeSeok Youn wrote:
Hi,
2014-07-16 0:29 GMT+09:00 Greg KH gre...@linuxfoundation.org:
On Tue, Jul 15, 2014 at 06:11:44PM
On Wed, Jul 16, 2014 at 03:24:12PM +0300, Sam Asadi wrote:
'quoted string split across lines' warning in checkpatching fixed
by group whole string in one line.
Signed-off-by: Sam Asadi asadi.sam...@gmail.com
---
drivers/staging/comedi/drivers/adl_pci9118.c |3 +--
1 file changed, 1
On Wed, Jul 16, 2014 at 04:55:23PM +0530, Kiran Padwal wrote:
From: Kiran Padwal kiran.pad...@gmail.com
Checkpatch fix - Add missing blank line after variable declaration
Signed-off-by:Kiran Padwal kiran.padwa...@gmail.com
Minor nit, you need a ' ' after the ':'.
Also, you sent me two
On Wed, Jul 16, 2014 at 06:22:58PM +0300, Sam Asadi wrote:
2 style issues fixed: one misspelling a quoted string split across lines.
Sam Asadi (2):
Staging: comedi: adl_pci9118: a style issue fixed
Staging: comedi: adl_pci9118: fractured spelling fixed
On Wed, Jul 16, 2014 at 10:43:14AM -0700, H Hartley Sweeten wrote:
Fix the checkpatch.pl warning in this file:
WARNING: else is not generally useful after a break or return
Also, for aesthetics, rename the comedi_subdevice parameter from
'subd' to 's' since this is the norm for comedi
On Wed, Jul 16, 2014 at 10:43:13AM -0700, H Hartley Sweeten wrote:
Fix the two checkpatch.pl warnings in this file:
WARNING: else is not generally useful after a break or return
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
---
On Wed, Jul 16, 2014 at 10:43:12AM -0700, H Hartley Sweeten wrote:
Fix the two checkpatch.pl warnings in this file:
WARNING: else is not generally useful after a break or return
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
---
On Wed, Jul 16, 2014 at 09:24:28PM +0100, Michalis Pappas wrote:
Hi,
I'm currently working on bringing the gdm72xx WiMAX driver out of
staging. The driver currently uses two control channels:
1. The SIOCDEVPRIVATE ioctl to send and receive state messages
2. A customly defined netlink
On Wed, Jul 16, 2014 at 09:40:18PM +0100, Michalis Pappas wrote:
On 07/09/2014 07:51 PM, Greg KH wrote:
diff --git a/drivers/staging/gdm72xx/gdm_sdio.c
b/drivers/staging/gdm72xx/gdm_sdio.c
index 9d2de6f..914fd75 100644
--- a/drivers/staging/gdm72xx/gdm_sdio.c
+++ b/drivers/staging
On Wed, Jul 16, 2014 at 09:27:02PM +, Hartley Sweeten wrote:
On Wednesday, July 16, 2014 1:34 PM, Greg KH wrote:
On Wed, Jul 16, 2014 at 10:43:14AM -0700, H Hartley Sweeten wrote:
Fix the checkpatch.pl warning in this file:
WARNING: else is not generally useful after a break
On Wed, Jul 16, 2014 at 11:03:06PM +0100, Michalis Pappas wrote:
On 07/16/2014 09:50 PM, Greg KH wrote:
On Wed, Jul 16, 2014 at 09:40:18PM +0100, Michalis Pappas wrote:
On 07/09/2014 07:51 PM, Greg KH wrote:
diff --git a/drivers/staging/gdm72xx/gdm_sdio.c
b/drivers/staging/gdm72xx
On Wed, Jul 16, 2014 at 03:46:09PM -0700, Joe Perches wrote:
On Wed, 2014-07-16 at 15:10 -0700, Greg KH wrote:
On Wed, Jul 16, 2014 at 11:03:06PM +0100, Michalis Pappas wrote:
[]
Ok, I agree on the ifdef stuff. My question was regarding your
suggestion above to replace print_hex_debug
On Thu, Jul 17, 2014 at 12:27:27PM -0700, H Hartley Sweeten wrote:
Where possible, convert all the pr_{level} messages to dev_{level}.
H Hartley Sweeten (5):
staging: comedi: usbduxfast: convert pr_err() to dev_err()
staging: comedi: usbduxfast: convert pr_warn() to dev_warn()
On Thu, Jul 17, 2014 at 01:26:23AM +0300, Sam Asadi wrote:
a 'quoted string split across lines' fixed while better use of
English applied to the text.
Signed-off-by: Sam Asadi asadi.sam...@gmail.com
---
drivers/staging/comedi/drivers/adl_pci9118.c |3 +--
1 file changed, 1
On Thu, Jul 17, 2014 at 09:30:38AM +0530, Kiran Padwal wrote:
Checkpatch fix - Add missing blank line after variable declaration
Signed-off-by: Kiran Padwal kiran.padwa...@gmail.com
---
drivers/staging/gdm724x/gdm_lte.c |2 ++
1 file changed, 2 insertions(+)
diff --git
On Fri, Jul 18, 2014 at 12:22:13PM -0400, John W. Linville wrote:
On Fri, Jul 18, 2014 at 05:26:47PM +0200, Benoit Taine wrote:
We should prefer `const struct pci_device_id` over
`DEFINE_PCI_DEVICE_TABLE` to meet kernel coding style guidelines.
This issue was reported by checkpatch.
On Fri, Jul 18, 2014 at 09:54:32AM -0700, James Bottomley wrote:
On Fri, 2014-07-18 at 09:43 -0700, Greg KH wrote:
On Fri, Jul 18, 2014 at 12:22:13PM -0400, John W. Linville wrote:
On Fri, Jul 18, 2014 at 05:26:47PM +0200, Benoit Taine wrote:
We should prefer `const struct pci_device_id
On Sat, Jul 19, 2014 at 07:14:12AM +1000, Dave Airlie wrote:
We have almost 1000 more uses of the non-macro version than the macro
version in the kernel today:
$ git grep -w DEFINE_PCI_DEVICE_TABLE | wc -l
262
$ git grep const struct pci_device_id | wc -l
1254
did you check for
On Fri, Jul 18, 2014 at 02:28:09PM -0700, H Hartley Sweeten wrote:
This series fixes most of the checkpatch.pl --strict issues in the comedi
core files.
comedidev.h still has a couple:
CHECK: spinlock_t definition without comment
CHECK: struct mutex definition without comment
CHECK:
On Fri, Jul 18, 2014 at 11:13:07PM +0300, Sam Asadi wrote:
A 'quoted string split across lines' issue fixed, while a better use of
language applied to the comment.
Signed-off-by: Sam Asadi asadi.sam...@gmail.com
---
drivers/staging/comedi/drivers/adl_pci9118.c |3 +--
1 file changed,
On Fri, Jul 18, 2014 at 10:17:54AM +0530, Sanjeev Sharma wrote:
This patch will add an blank line after
declaration reported by checkpatch.pl script.
Signed-off-by: Sanjeev Sharma sanjeev_sha...@mentor.com
---
drivers/staging/android/sw_sync.c | 2 ++
1 file changed, 2 insertions(+)
On Fri, Jul 18, 2014 at 09:35:13PM +0300, Igor Bezukh wrote:
Since there is a lot of stuff that need to be changed in order to meet the
kernel
coding style in wcmd.c file, I've decided to fix function-per-patch.
The following changes were made in vCommandTimerWait function:
- Camel case
On Sat, Jul 19, 2014 at 10:26:54AM -0400, Benjamin Romer wrote:
Move the proc entry for controlling the toolaction field to sysfs. The field
appears in /sys/devices/platform/visorchipset/install/toolaction.
This field is used to tell s-Par which type of recovery tool action to perform
on the
On Sat, Jul 19, 2014 at 02:26:48PM -0400, Ben Romer wrote:
Greg KH gre...@linuxfoundation.org wrote:
What happened to the idea of only creating the sysfs files _if_ it is
needed? You are always creating these files, and then can return
-ENODEV if the device really isn't there, that's
On Sat, Jul 19, 2014 at 10:26:54AM -0400, Benjamin Romer wrote:
+ssize_t show_toolaction(struct device *dev, struct device_attribute *attr,
+ char *buf)
+{
+ if (ControlVm_channel) {
+ U8 toolAction;
+
+ visorchannel_read(ControlVm_channel,
+
On Sun, Jul 20, 2014 at 04:15:50AM +0300, Sam Asadi wrote:
A line over 80 issue fixed, which is a comment.
Signed-off-by: Sam Asadi asadi.sam...@gmail.com
---
drivers/staging/comedi/drivers/adv_pci1710.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git
The following changes since commit 1795cd9b3a91d4b5473c97f491d63892442212ab:
Linux 3.16-rc5 (2014-07-13 14:04:33 -0700)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/
tags/staging-3.16-rc6
for you to fetch changes up to
On Mon, Jul 21, 2014 at 08:36:02AM -0500, Romer, Benjamin M wrote:
On Sat, 2014-07-19 at 09:36 -0700, Greg KH wrote:
/* /sys/devices/platform/visorchipset */
static struct platform_device Visorchipset_platform_device = {
.name = visorchipset,
.id = -1,
+ .dev.groups
On Mon, Jul 21, 2014 at 11:24:40AM +0200, jes.soren...@redhat.com wrote:
From: Jes Sorensen jes.soren...@redhat.com
Greg,
Another set of rtl8723au changes - this was meant to be a 'I'll just
fix this little issue' but snowballed into a fair bit more, as I
realized just how bad the
On Sat, Jul 19, 2014 at 07:34:39PM +0200, LABBE Corentin wrote:
Signed-off-by: LABBE Corentin clabbe.montj...@gmail.com
---
drivers/staging/sep/sep_main.c | 15 ---
1 file changed, 8 insertions(+), 7 deletions(-)
_which_ specific problems are fixed here?
Please be specific and
On Sun, Jul 20, 2014 at 08:41:50AM +0300, Igor Bezukh wrote:
Clean redundant comments in the code.
You also messed with some strings :(
Which would have been fine, in a separate patch. Please break this up
into at least 2 different patches, each only doing one type of thing.
thanks,
greg k-h
On Mon, Jul 21, 2014 at 02:47:42PM -0400, Erik Arfvidson wrote:
This patch removes all proc entries, directories, and functions
A better Subject would be:
staging: unisys: remove virthba proc files
right?
___
devel mailing list
On Mon, Jul 21, 2014 at 02:47:43PM -0400, Erik Arfvidson wrote:
This patch adds virthba debugfs directory and info entry
Signed-off-by: Erik Arfvidson erik.arfvid...@unisys.com
Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com
---
drivers/staging/unisys/virthba/virthba.c | 79
On Mon, Jul 21, 2014 at 02:47:45PM -0400, Erik Arfvidson wrote:
This patch adds enable_ints entry to virthba directory
Signed-off-by: Erik Arfvidson erik.arfvid...@unisys.com
Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com
---
drivers/staging/unisys/virthba/virthba.c | 63
On Tue, Jul 22, 2014 at 02:57:57AM +0200, Guillaume Morin wrote:
Use gfp_t to store GPF_* flags instead of unsigned int.
This was reported by sparse.
Signed-off-by: Guillaume Morin guilla...@morinfr.org
---
drivers/staging/lustre/lustre/llite/rw.c | 2 +-
1 file changed, 1 insertion(+),
On Mon, Jul 21, 2014 at 08:50:26PM -0400, Chris Murphy wrote:
Problem: On Asus TX201LA running 15.6 kernel x86_64, driver repeatedly
disconnects and reconnects. Dual boot same machine on Win 8.1 is very stable.
Behavior starts as soon as Linux is booted and logged in. Saw same behavior on
On Tue, Jul 22, 2014 at 12:26:42PM +0530, Kiran Padwal wrote:
This patch fixes the following checkpatch.pl warnings:
WARNING: Prefer ether_addr_copy() over memcpy() if the Ethernet addresses
are __aligned(2).
Is that true here?
Have you tested this on the hardware to ensure it works
On Tue, Jul 22, 2014 at 04:07:51PM -0400, Jeff Oczek wrote:
Put extern declarations in cxt1e1_common.h to reduce sparse warnings for
linux.c:
drivers/staging/cxt1e1/linux.c:86:13: warning:
symbol 'error_flag' was not declared. Should it be static?
drivers/staging/cxt1e1/linux.c:91:13:
On Tue, Jul 22, 2014 at 04:56:59PM -0400, Jeff Oczek wrote:
On Tue, Jul 22, 2014 at 01:17:22PM -0700, Greg KH wrote:
On Tue, Jul 22, 2014 at 04:07:51PM -0400, Jeff Oczek wrote:
Put extern declarations in cxt1e1_common.h to reduce sparse warnings for
linux.c:
I know you didn't name
On Tue, Jul 22, 2014 at 09:56:32AM -0400, Benjamin Romer wrote:
This patch adds a documentation file for all of the interfaces that were moved
to sysfs by the other patches in this set.
Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com
---
v2: whitespace errors were corrected.
On Tue, Jul 22, 2014 at 09:56:28AM -0400, Benjamin Romer wrote:
Move the chipsetready proc entry to sysfs under a new directory guest. This
entry is used by Unisys application software on the guest to acknowledge
completion of specific events for integration purposes, but these
On Tue, Jul 22, 2014 at 09:56:29AM -0400, Benjamin Romer wrote:
Move the /proc/visorchipset/parahotplug interface to sysfs under
/sys/devices/platform/visorchipset/guest/parahotplug.
The parahotplug interface is used to deal with recovery situations on s-Par
guest partitions. The command
On Wed, Jul 23, 2014 at 10:08:44AM +, Sharma, Sanjeev wrote:
Thanks, so this is also available in next kernel release version.
I don't understand the question. You should have gotten an automated
email when the patch was applied that explained where the patch was now
located, and when it
On Wed, Jul 23, 2014 at 05:06:28AM +0300, Sam Asadi wrote:
A 'Missing a blank line after declarations' warning fixed by inserting
a blank line after struct pointer declaration.
Signed-off-by: Sam Asadi asadi.sam...@gmail.com
---
drivers/staging/comedi/drivers/amplc_pc236.c |1 +
1
On Tue, Jul 22, 2014 at 08:34:55PM -0400, Jeff Oczek wrote:
Changed names of ambiguous sounding variable names as follows
error_flag - cxt1e1_error_flag
max_mtu_default - cxt1e1_max_mtu_default
max_txdesc_used - cxt1e1_max_txdesc_used
max_txdesc_default -
On Thu, Jul 24, 2014 at 06:19:46PM +0530, Sudip Mukherjee wrote:
---
drivers/staging/bcm/DDRInit.c | 59
---
1 file changed, 39 insertions(+), 20 deletions(-)
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him
a patch that
On Thu, Jul 24, 2014 at 02:08:45PM -0400, Benjamin Romer wrote:
Debugging information for the guest's channels was being exposed in proc.
Remove the code that creates these entries, which are no longer needed.
Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com
---
v3: patch location
On Thu, Jul 24, 2014 at 09:50:14PM +0300, Igor Bezukh wrote:
Removed redundant comments from card.h header file.
Signed-off-by: Igor Bezukh igb...@gmail.com
---
drivers/staging/vt6655/80211hdr.h |7 ---
drivers/staging/vt6655/80211mgr.h | 38
On Fri, Jul 25, 2014 at 10:54:47PM +0100, Alan Cox wrote:
On Fri, 2014-07-25 at 20:17 +0300, Kristina Martšenko wrote:
On 23/06/14 23:32, Kristina Martšenko wrote:
Hi Mark,
I'm helping Greg do a bit of cleanup in the staging tree. I noticed that
nobody seems to have worked towards
On Fri, Jul 25, 2014 at 03:37:41PM +0530, Arjun AK wrote:
From 8e7748dd81cf63c62dbef8f102e97da1d4d5d90a Mon Sep 17 00:00:00 2001
From: Arjun AK arjunak...@gmail.com
Date: Fri, 25 Jul 2014 15:09:11 +0530
Subject: [PATCH] Staging: unisys: Fix code style
Why is all of this here in this message?
On Wed, Mar 05, 2014 at 10:36:53PM -0800, Kalyan Kodamagula wrote:
Hi,
Iam new to this ML,I need info regarding Usb device drivers.I had learned
Lnx device drivers and having
knowledge on USB Host driver(highlevel).
I had seen probe/read/write functions of a driver.As there is no
On Wed, Mar 05, 2014 at 11:30:06PM -0800, Andrew Grover wrote:
On Wed, Mar 5, 2014 at 10:14 PM, Valentina Manea
valentina.mane...@gmail.com wrote:
On Tue, Mar 4, 2014 at 9:20 PM, Greg KH gre...@linuxfoundation.org wrote:
On Tue, Mar 04, 2014 at 09:16:39PM +0200, Valentina Manea wrote
501 - 600 of 4692 matches
Mail list logo
