On Fri, Apr 18, 2014 at 11:31:36PM +0200, Konrad Zapalowicz wrote:
From: Konrad M Zapalowicz bergo.tor...@gmail.com
This commit fixes the following checkpatch errors:
rtl8188eu/core/rtw_recv.c
- 1874: ERROR: code indent should use tabs where possible
Signed-off-by: Konrad Zapalowicz
On Fri, Apr 18, 2014 at 07:57:51PM +0200, Bojan Prtvar wrote:
This fixes the following sparse warnings:
drivers/staging/crystalhd/crystalhd_lnx.c:631:5: warning: symbol
'chd_dec_pci_suspend' was not declared. Should it be static?
drivers/staging/crystalhd/crystalhd_lnx.c:665:5: warning:
On Sat, Apr 19, 2014 at 02:12:34PM -0400, Sean MacLennan wrote:
Fix a sparse error in the htons() call. htons() returns a __be16 not a
u16.
Signed-off-by: Sean MacLennan se...@seanm.ca
---
You sent 2 patches, which should I apply?
I've deleted both from my inbox, please resend the proper
On Sat, Apr 19, 2014 at 03:10:04PM -0400, Sean MacLennan wrote:
On Sat, 19 Apr 2014 11:17:23 -0700
Greg KH gre...@linuxfoundation.org wrote:
On Sat, Apr 19, 2014 at 02:12:34PM -0400, Sean MacLennan wrote:
Fix a sparse error in the htons() call. htons() returns a __be16
not a u16
On Sun, Apr 20, 2014 at 10:19:14AM +0530, Kumar Gaurav wrote:
Hi All,
Any update on below patch. Do i need to make any modification?
Please give an overworked maintainer a chance to catch up on his email.
If after a week you haven't heard anything, then ask again.
thanks,
greg k-h
On Fri, Apr 25, 2014 at 10:48:22AM -0300, Nicolas Del Piano wrote:
Fixed a coding style error, macros with complex values should be enclosed in
parentheses.
Signed-off-by: Nicolas Del Piano ndel...@gmail.com
---
drivers/staging/octeon-usb/octeon-hcd.c |2 +-
1 file changed, 1
On Fri, Apr 25, 2014 at 11:18:55PM +0530, RAGHAVENDRA GANIGA wrote:
From 7bdc654b12895889a539450528b52328901e6dc0 Mon Sep 17 00:00:00 2001
From: Raghavendra Ganiga ravi23gan...@gmail.com
Date: Fri, 25 Apr 2014 23:11:22 +0530
Subject: [PATCH] staging: comedi: fix coding style issues in
On Sun, Apr 20, 2014 at 11:10:57AM +0200, Camille Bordignon wrote:
Fix sparse warning cast removes address space of expression
Add lost flag __user due to cast
Signed-off-by: Camille Bordignon camille.bordig...@gmail.com
---
diff --git a/drivers/staging/android/binder.c
On Tue, Apr 08, 2014 at 05:32:45PM +0100, Paul McQuade wrote:
WARNING: do {} while (0) macros should not be semicolon terminated
Signed-off-by: Paul McQuade paulmcq...@gmail.com
---
drivers/staging/keucr/scsiglue.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
On Thu, Apr 24, 2014 at 01:57:09PM -0500, Ken Cox wrote:
From: Benjamin Romer benjamin.ro...@unisys.com
This patch adds support for detection of s-Par firmware by checking for the
hypervisor bit in the CPU capabilities, and then querying the hypervisor ID
cpuid leaf.
No linewrap?
This
On Thu, Apr 24, 2014 at 01:57:10PM -0500, Ken Cox wrote:
This fixes a problem reported from upstream where a panic occurs if the
unisys drivers are loaded on a non s-Par system.
Reported-by: Fengguang Wu fengguang...@intel.com
Signed-off-by: Ken Cox j...@redhat.com
Tested by: Ken Cox
On Thu, Apr 24, 2014 at 01:57:12PM -0500, Ken Cox wrote:
The visorutil module was lacking license info.
Signed-off-by: Ken Cox j...@redhat.com
---
drivers/staging/unisys/visorutil/visorkmodutils.c | 2 ++
1 file changed, 2 insertions(+)
diff --git
On Mon, Apr 07, 2014 at 12:03:41PM +0900, Daeseok Youn wrote:
The bp_proc_create() can be called if BP_PROC_SUPPORT is defined.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/silicom/bpctl_mod.c |5 +
1 files changed, 5 insertions(+), 0 deletions(-)
On Wed, Mar 26, 2014 at 01:08:23AM +, Rui Miguel Silva wrote:
fix some code style related to the use of braces in a one statement block
Signed-off-by: Rui Miguel Silva rmf...@gmail.com
---
drivers/staging/rtl8192u/r8192U_dm.c | 7 +++
drivers/staging/rtl8192u/r8192U_wx.c
On Sat, Apr 05, 2014 at 12:50:22PM -0300, Fabio Estevam wrote:
From: Fabio Estevam fabio.este...@freescale.com
Fix the following checkpatch warnings:
WARNING: Missing a blank line after declarations
#162: FILE: drivers/staging/imx-drm/imx-hdmi.c:162:
+ u8 val = hdmi_readb(hdmi, reg)
On Wed, Apr 02, 2014 at 11:25:19AM +0200, Martin Berglund wrote:
Added newlines after declarations.
Signed-off-by: Martin Berglund mar...@rogsta.net
---
drivers/staging/xgifb/XGI_main_26.c | 2 ++
drivers/staging/xgifb/vb_init.c | 2 ++
drivers/staging/xgifb/vb_setmode.c | 2 ++
3
On Sat, Apr 26, 2014 at 06:30:33PM +0300, Sami Laine wrote:
From: Sami Laine laine.j.s...@gmail.com
Sparse warning corrections:
- declarations made static where they should be such
- changed NULL-pointers as NULL instead of static 0's
- added __force to a few casts seemingly safe enough
The following changes since commit a798c10faf62a505d24e5f6213fbaf904a39623f:
Linux 3.15-rc2 (2014-04-20 11:08:50 -0700)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/
tags/staging-3.15-rc3
for you to fetch changes up to
On Wed, Apr 30, 2014 at 07:51:13PM +0900, Masanari Iida wrote:
Fix format string mismatch in bw-qcam.c
Signed-off-by: Masanari Iida standby2...@gmail.com
---
drivers/media/parport/bw-qcam.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
On Tue, Apr 29, 2014 at 08:32:21PM +0300, Dan Carpenter wrote:
On Wed, Apr 30, 2014 at 01:59:12AM +0900, Seunghun Lee wrote:
This patch fixes Missing a blank line after declarations warnings.
Signed-off-by: Seunghun Lee way...@gmail.com
Quite a few of these are false checkpatch.pl false
On Mon, Apr 28, 2014 at 12:40:05PM +0300, Dan Carpenter wrote:
Nice, Chase, you've become an expert on comedi, it seems.
I can't say how happy comedi patches make me these days. Ian, you and
Hartley are doing a fantastic job.
Same here, it's great to see all of this cleanup happening.
On Sat, Apr 26, 2014 at 10:10:29PM +0200, Christian Engelmayer wrote:
Pointer 'pwdev_priv' in function rtw_wdev_free() is unused - thus remove it.
Signed-off-by: Christian Engelmayer cenge...@gmx.at
---
Compile tested and applies against v3.15-rc2 as well as branch staging-next
of tree
On Sat, May 03, 2014 at 05:10:48PM +0200, Martin Kepplinger wrote:
pci_iounmap is used that way in drivers/net/wireless/rtlwifi and this
fixes sparse warnings.
Signed-off-by: Martin Kepplinger mart...@posteo.de
---
drivers/staging/rtl8821ae/pci.c |4 ++--
1 file changed, 2
On Thu, May 01, 2014 at 11:54:02PM +0200, Christian Engelmayer wrote:
Fix potential leaks in the error paths of r8712_set_key(). In case the
algorithm specific checks fail, the function returns without enqueuing
or freeing the already allocated command and parameter structs. Use a
centralized
On Sun, May 04, 2014 at 09:52:09PM +0200, Clément Calmels wrote:
Remove C99 comment and rewrite lines over 80 characters.
Warnings and error found by checkpatch.pl script.
Signed-off-by: Clément Calmels clement.calm...@free.fr
---
drivers/staging/vt6655/tmacro.h | 13 +
1 file
On Mon, May 05, 2014 at 06:40:13PM +0200, Fernando Apesteguia wrote:
Small fix to driver. If these patches are welcomed, more could come in the
future.
Regards
From d8369cba0552c5ea5f4eadc750434e39785e042a Mon Sep 17 00:00:00 2001
From: Fernando Apesteguia fernando.apesteg...@gmail.com
On Mon, May 05, 2014 at 07:10:37PM +0200, Fernando Apesteguia wrote:
On Mon, May 05, 2014 at 09:57:48AM -0700, Greg KH wrote:
On Mon, May 05, 2014 at 06:40:13PM +0200, Fernando Apesteguia wrote:
Small fix to driver. If these patches are welcomed, more could come in the
future
On Mon, May 05, 2014 at 09:16:03PM +0200, Clément Calmels wrote:
On Sun, 4 May 2014 17:26:58 -0400
Greg KH g...@kroah.com wrote:
On Sun, May 04, 2014 at 09:52:09PM +0200, Clément Calmels wrote:
Remove C99 comment and rewrite lines over 80 characters.
Warnings and error found
The following changes since commit d1db0eea852497762cab43b905b879dfcd3b8987:
Linux 3.15-rc3 (2014-04-27 19:29:27 -0700)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/
tags/staging-3.15-rc4
for you to fetch changes up to
On Wed, May 07, 2014 at 12:44:31AM +0100, John Church wrote:
Signed-off-by: John Church j.chu...@ymail.com
What coding style issue?
You need to be specific in your body of your email, and put a blank line
after the signed-off-by and before the patch, otherwise the tools can
complain.
And
On Wed, May 07, 2014 at 04:05:27PM +0530, Adithya wrote:
Hi All,
This is patch for fixing of minor coding style problems. This is part
of Eudyptula Challenge.
Thanks,
Adithya.K
Can you please read the Documentation/SubmittingPatches file and then
resend this in a format I can apply it
On Wed, May 07, 2014 at 03:45:04PM -0700, Haiyang Zhang wrote:
This change ensures the driver can be built successfully without the
CONFIG_SYSFS flag.
MS-TFS: 182270
Signed-off-by: Haiyang Zhang haiya...@microsoft.com
Reviewed-by: K. Y. Srinivasan k...@microsoft.com
---
On Thu, May 08, 2014 at 01:41:33PM -0700, Haiyang Zhang wrote:
This change ensures the driver can be built successfully without the
CONFIG_SYSFS flag.
MS-TFS: 182270
Signed-off-by: Haiyang Zhang haiya...@microsoft.com
Reviewed-by: K. Y. Srinivasan k...@microsoft.com
---
On Wed, Apr 09, 2014 at 05:30:04PM +0100, Paul McQuade wrote:
ERROR: that open brace { should be on the previous line
ERROR: else should follow close brace '}
ERROR: space required before the open parenthesis '(
ERROR: trailing whitespace
ERROR: open brace '{' following function declarations
On Wed, May 07, 2014 at 02:41:48PM +0300, Ebru Akagunduz wrote:
Fix smatch warning dgnc_cleanup_board() info:
redundant null check on brd-flipbuf calling kfree()
in dgnc_driver.c
Signed-off-by: Ebru Akagunduz ebru.akagun...@gmail.com
---
drivers/staging/dgnc/dgnc_driver.c | 3 +--
1 file
On Wed, May 14, 2014 at 10:12:46AM +0200, Tobias Klauser wrote:
On 2014-05-13 at 16:43:57 +0200, Masanari Iida standby2...@gmail.com wrote:
This patch replaced printk with pr_info.
It would be even better to use dev_err(), since these are error messages
and you can use the struct dev from
On Sun, Apr 13, 2014 at 10:09:49PM +0530, c...@slynux.com wrote:
From: Sarath Lakshman sarathlaksh...@slynux.com
This doesn't match your From: line, why?
Fixed missed declarations for few non-static functions.
Signed-off-by: Sarath Lakshman sarathlaksh...@slynux.com
---
On Mon, May 12, 2014 at 05:22:47PM +0200, Denis Pithon wrote:
Fix some coding style issues concerning printk() usage.
Signed-off-by: Denis Pithon denis.pit...@gmail.com
---
drivers/staging/wlan-ng/p80211netdev.c | 17 +
1 file changed, 9 insertions(+), 8 deletions(-)
On Tue, May 06, 2014 at 07:54:41PM +0200, Clément Calmels wrote:
This is a patch to fix coding style issue found by
scripts/checkpatch.pl utility.
Signed-off-by: Clément Calmels clement.calm...@free.fr
---
drivers/staging/sep/sep_dev.h | 3 +++
1 file changed, 3 insertions(+)
diff
On Fri, May 16, 2014 at 12:52:47PM +0300, Dan Carpenter wrote:
On Fri, May 16, 2014 at 06:40:28PM +0900, DaeSeok Youn wrote:
Hi,
This patch haven't been updated over the past 3 weeks.
Will you check for me?
Greg was trying to travel around the world in one month like Jackie
Chan.
On Mon, Apr 28, 2014 at 01:50:11PM -0500, Junsu Shin wrote:
Fixed following coding style issues.
- No space is necessary after a cast
- Alignment should match open parenthesis
- Braces {} should be used on all arms of this statement
You are doing 3 things, so this should be 3 patches at
On Fri, Apr 25, 2014 at 04:04:59PM +0900, Daeseok Youn wrote:
- alloc_tty_driver() is deprecated so it is changed to
tty_alloc_driver()
- Pointers which are allocated by alloc_tty_driver() and kzalloc()
can be NULL so it need to check NULL for them.
- If one of those is failed, it need to add
On Mon, May 19, 2014 at 07:45:10AM -0600, Jake Edge wrote:
On Mon, 19 May 2014 12:09:59 +0400 Anton Saraev wrote:
--- a/drivers/staging/skein/Makefile
+++ b/drivers/staging/skein/Makefile
@@ -4,10 +4,10 @@
subdir-ccflags-y := -I$(src)/include/
as part of the rearranging of files, I
On Mon, May 19, 2014 at 10:57:08PM +0300, Dan Carpenter wrote:
On Mon, May 19, 2014 at 09:42:22AM -0500, Romer, Benjamin M wrote:
On Sun, 2014-05-18 at 09:49 -0700, Greg KH wrote:
Also, why are these entries moving to debugfs at all? Why are they
needed? Who will use them? Are tools
On Mon, May 19, 2014 at 03:17:30PM +0100, Rupesh Gujare wrote:
I will be not able to work on ozwpan driver anymore.
Remove my name add Tateno as maintainer.
Signed-off-by: Rupesh Gujare rupesh.guj...@atmel.com
---
MAINTAINERS |2 +-
drivers/staging/ozwpan/TODO |2
On Tue, May 20, 2014 at 02:17:26PM +0300, Tomas Winkler wrote:
I'd like to ask what is the policy for back porting fixes for drivers
that already graduated from staging but the fix is needed in kernel
version where it is still in the staging.
Same as anything else, just provide the backported
The following changes since commit 86281966c7395aa9a13a20c52e26005f5e142451:
Merge tag 'iio-fixes-for-3.15b' of
git://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio into staging-linus
(2014-04-30 14:19:23 -0700)
are available in the git repository at:
On Wed, May 21, 2014 at 10:39:43PM -0400, Sean MacLennan wrote:
On Sat, 19 Apr 2014 16:57:45 -0400
Sean MacLennan se...@seanm.ca wrote:
A sparse error fixup removed a htons() which is required for the
driver to function. This patch puts the htons() back and fixes the
sparse warning
On Thu, May 22, 2014 at 06:32:03PM +0900, Magnus Damm wrote:
Hi Dan,
On Thu, May 22, 2014 at 6:17 PM, Dan Carpenter dan.carpen...@oracle.com
wrote:
Generally we take things as is into staging so there is no need for a
re-work if you don't want to. But we do need a TODO file. Read the
On Thu, May 22, 2014 at 09:25:40PM -0700, David Matlack wrote:
Fix a use-after-free bug that can cause a kernel oops. If
slic_card_init fails then slic_entry_probe() (the pci probe()
function for this device) will return error without cleaning
up memory (including the registered netdev
On Thu, May 22, 2014 at 12:31:08PM -0500, Ken Cox wrote:
This series of patches cleans up the unisys driver code in various ways:
-fix sparse warnings related to accessing I/O space
-fix sparse warnings related to dereferencing noderef types
-add static to function
On Thu, May 22, 2014 at 12:31:12PM -0500, Ken Cox wrote:
VISORCHANNEL_CHANGE_SERVER_STATE and VISORCHANNEL_CHANGE_CLIENT_STATE
are never used in any of the source so they have been removed.
VISORCHANNEL_CHANGE_CLIENT_STATE would have caused a broken kernel build
after commit a8d7f21d, but
On Thu, May 22, 2014 at 12:31:10PM -0500, Ken Cox wrote:
Added ULTRA_VBUS_IOinit_channel() and modified ULTRA_VBUS_init_channel()
function so that it can operate on both memory space and IO space
without getting sparse warnings.
Signed-off-by: Ken Cox j...@redhat.com
Don't add a new
On Thu, May 22, 2014 at 09:38:45PM -0700, David Matlack wrote:
slic_config_get() can fail. Change the return type from void to
int and handle the error in slic_card_init(). So now, instead of
silently failing (and then timing out waiting for the config data),
the driver will fail loudly at
On Wed, May 21, 2014 at 11:23:33PM +0100, Masaru Nomura wrote:
Remove prohibited space between function name and open parenthesis
to meet kernel coding style. Also, fix indenting due to changes.
Signed-off-by: Masaru Nomura massa.nom...@gmail.com
---
On Tue, May 20, 2014 at 12:03:23AM +0100, Masaru Nomura wrote:
Remove prohibited space between function name and
open parenthesis to meet kernel coding style.
Also fix indenting due to changes to keep readability.
I undid modifications to memset(...) which I made in
previous patches as it
On Sun, May 04, 2014 at 02:26:09AM +0200, Christian Engelmayer wrote:
This driver supports the PCI-20001C-1a and PCI-20001C-2a carrier boards.
The -2a version has 32 on-board DIO channels. In case this variant is
detected, local variable 'has_dio' is set accordingly. Otherwise it is
left
On Sun, May 04, 2014 at 02:22:19PM +0200, Martin Kepplinger wrote:
Shared addresses can be marked as such.
Signed-off-by: Martin Kepplinger mart...@posteo.de
---
I guess that's what you meant. Thanks for your feedback!
Yes, that is correct, but someone beat you to this patch, sorry :(
On Wed, May 07, 2014 at 06:31:48PM +0200, Luis Ortega wrote:
Fixes the following warning:
drivers/staging/wlags49_h2/sta_h2.c:4471:10: warning: symbol 'fw_image' was
not declared. Should it be static?
Signed-off-by: Luis Ortega luior...@gmail.com
---
drivers/staging/wlags49_h2/sta_h2.c |
Hi all,
Thanks to a trans-pacific flight, I think I'm now caught up on all
drivers/staging/* patches that were sent to me before 10 hours ago. If
you have sent something that I have not responded to, please consider it
lost and please resend, after making sure it still applies on top of my
On Fri, May 23, 2014 at 01:11:01PM -0700, David Matlack wrote:
Greg, this is one of the two patches that got dropped. It should apply cleanly
in any order with respect to all my other patches.
As my patch queue is now flushed out, what is this patch? :)
Can you please just resend the two
On Fri, May 23, 2014 at 02:39:43PM -0700, Chaitanya Hazarey wrote:
Added a blank line after declarations to fix the following warnings issued by
checkpatch.pl:
drivers/staging/silicom/bypasslib/bypass.c:138: WARNING: Missing a blank line
after declarations
On Fri, May 23, 2014 at 02:47:10PM -0700, Chaitanya Hazarey wrote:
Added a blank line after declarations in many places to fix the following
warning issued by checkpatch.pl:
WARNING: Missing a blank line after declarations
---
drivers/staging/silicom/bpctl_mod.c | 90
On Fri, May 23, 2014 at 10:25:28PM -0700, Chaitanya Hazarey wrote:
Added a blank line after declarations in many places to fix the
following warning issued by checkpatch.pl:
WARNING: Missing a blank line after declarations
Thanks Greg K-H and Dan for the patience. Hope it works this time,
On Sun, May 25, 2014 at 03:08:59PM +0200, Manuel Schölling wrote:
To be future-proof and for better readability the time comparisons are
modified to use time_before() instead of plain, error-prone math.
Signed-off-by: Manuel Schölling manuel.schoell...@gmx.de
---
On Sun, May 25, 2014 at 08:24:33PM +0200, Manuel Schoelling wrote:
On So, 2014-05-25 at 11:14 -0700, Greg KH wrote:
On Sun, May 25, 2014 at 03:08:59PM +0200, Manuel Schölling wrote:
To be future-proof and for better readability the time comparisons are
modified to use time_before
On Sun, May 25, 2014 at 11:59:08AM -0700, Chaitanya Hazarey wrote:
Added a blank line after declarations in many places to fix the following
warning issued by checkpatch.pl:
WARNING: Missing a blank line after declarations
Lets see if this works now, this patch is prepared against Greg's
On Sun, May 25, 2014 at 10:43:00PM +0200, jes.soren...@redhat.com wrote:
From: Jes Sorensen jes.soren...@redhat.com
Hi Greg,
Please find attached another round of cleanups, removal of dead code,
and tidying up most of the #ifdef CONFIG_8723AU_BT_COEXIST mess.
Notably patch 10 fixes an
On Sun, May 25, 2014 at 11:24:12PM +0100, Masaru Nomura wrote:
Remove prohibited space between function name and
open parenthesis to meet kernel coding style.
Also fix indenting due to changes to keep readability.
-since v2:
None. This is the resend of v2 as v2 failed to apply
This should
On Sun, May 25, 2014 at 11:50:03PM +0100, Masaru Nomura wrote:
2014-05-25 23:37 GMT+01:00 Greg KH gre...@linuxfoundation.org:
On Sun, May 25, 2014 at 11:24:12PM +0100, Masaru Nomura wrote:
Remove prohibited space between function name and
open parenthesis to meet kernel
On Mon, May 26, 2014 at 12:57:39AM +0100, Masaru Nomura wrote:
What _branch_ of that git tree did you make it against?
I did my work against
commit 4b660a7f5c8099d88d1a43d8ae138965112592c7
That is a commit, not a branch.
Please work against the staging-next branch, not master. master
On Sun, May 25, 2014 at 05:36:58PM -0700, Chaitanya Hazarey wrote:
Added a blank line after declarations in many places to fix the following
warning issued by checkpatch.pl:
Always wrap your lines at 72 columns, like git asks you to when you type
in the commit message.
WARNING: Missing a
On Mon, May 26, 2014 at 02:28:44PM +0530, Sachin Kamat wrote:
'ret' is not used in the function. Remove it.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/staging/imx-drm/imx-tve.c |1 -
1 file changed, 1 deletion(-)
This doesn't apply properly to my tree, can you
On Tue, May 27, 2014 at 09:05:43PM +0530, navin patidar wrote:
Signed-off-by: navin patidar navin.pati...@gmail.com
---
drivers/staging/rtl8712/osdep_service.h |6 --
1 file changed, 6 deletions(-)
This is the rtl8712 driver, not the rtl8188eu driver.
And this patch causes a build
On Wed, May 28, 2014 at 06:01:17AM -0500, Ken Cox wrote:
On 05/23/2014 06:18 AM, Greg KH wrote:
On Thu, May 22, 2014 at 12:31:08PM -0500, Ken Cox wrote:
This series of patches cleans up the unisys driver code in various ways:
-fix sparse warnings related to accessing I/O space
On Wed, May 28, 2014 at 06:52:51PM +1000, Scott Weir wrote:
This patch corrects coding style issue:
WARNING: Missing a black line after declarations
Signed-off-by: Scott Weir sjw0...@gmail.com
---
drivers/staging/android/sync_debug.c | 4
This file isn't in my tree. Always work
On Wed, May 28, 2014 at 07:32:39AM -0700, Chaitanya Hazarey wrote:
-static int r8192_wx_set_scan_type(struct net_device *dev, struct
iw_request_info *aa, union
- iwreq_data *wrqu, char *p){
+static int r8192_wx_set_scan_type(struct net_device *dev, struct
The Subject: here is not really that descriptive, I've fixed it up when
committing it. Try to be a bit better for your next patch.
thanks,
greg k-h
___
devel mailing list
de...@linuxdriverproject.org
On Wed, May 28, 2014 at 04:23:48PM -0700, Chaitanya Hazarey wrote:
Removed dead code
Deleted stray newlines
Added newlines for better code readability
These should all be broken up into individual patches.
Remember, each patch should just do _one_ thing.
thanks,
greg k-h
On Sat, Jul 26, 2014 at 10:55:11AM +0100, Alan Cox wrote:
On Fri, 2014-07-25 at 21:54 -0700, Greg KH wrote:
On Fri, Jul 25, 2014 at 10:54:47PM +0100, Alan Cox wrote:
On Fri, 2014-07-25 at 20:17 +0300, Kristina Martšenko wrote:
On 23/06/14 23:32, Kristina Martšenko wrote:
Hi Mark
On Sun, Jul 27, 2014 at 04:51:43PM +0530, Rahul Garg wrote:
Signed-off-by: Rahul Garg rahul.lnm...@gmail.com
---
drivers/staging/vt6655/tcrc.c | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
I know this is a tiny patch, but you are doing two different things
here, and
On Sun, Jul 27, 2014 at 10:23:53AM -0700, Joe Perches wrote:
On Sun, 2014-07-27 at 19:08 +0200, Nicolas Thery wrote:
This patch fixes the following errors and warnings:
[]
diff --git a/drivers/staging/ft1000/ft1000-pcmcia/ft1000_proc.c
b/drivers/staging/ft1000/ft1000-pcmcia/ft1000_proc.c
On Thu, Jul 24, 2014 at 10:55:09PM -0400, Benjamin Romer wrote:
Move the /proc/visorchipset/parahotplug interface to sysfs under
/sys/devices/platform/visorchipset/parahotplug/deviceenabled and
/sys/devices/platform/visorchipset/parahotplug/devicedisabled.
The parahotplug interface is used
On Fri, Jul 25, 2014 at 07:18:37PM +0300, Igor Bezukh wrote:
Removed redundant comments from device.h header file.
Signed-off-by: Igor Bezukh igb...@gmail.com
---
drivers/staging/vt6655/device.h | 82
++-
1 file changed, 21 insertions(+), 61
On Fri, Jul 25, 2014 at 07:37:45PM +0300, Igor Bezukh wrote:
Removed redundant comments from key.h header file.
Signed-off-by: Igor Bezukh igb...@gmail.com
---
drivers/staging/vt6655/key.h | 26 +++---
1 file changed, 7 insertions(+), 19 deletions(-)
Also doesn't
On Fri, Jul 25, 2014 at 07:35:12PM +0300, Igor Bezukh wrote:
Removed redundant comments from iwctl.h header file.
Signed-off-by: Igor Bezukh igb...@gmail.com
---
drivers/staging/vt6655/iwctl.h | 12 +---
1 file changed, 1 insertion(+), 11 deletions(-)
Also doesn't apply :(
On Fri, Jul 25, 2014 at 07:45:53PM +0300, Igor Bezukh wrote:
Removed redundant comments from mac.h header file.
Signed-off-by: Igor Bezukh igb...@gmail.com
---
drivers/staging/vt6655/mac.h | 388
--
1 file changed, 188 insertions(+), 200
On Sun, Jul 27, 2014 at 08:56:38PM +0100, Liviu I. wrote:
Hello Kernel Developers!
I've attached a small patch to fix a coding style problem and make checkpatch
happy, as part of challenge 10 of Eudyptula.
Thank you
--- drivers/staging/lustre/lustre/ldlm/ldlm_extent.c.orig
On Mon, Jul 28, 2014 at 08:38:29AM +0530, Anil Belur wrote:
From: Anil Belur ask...@gmail.com
- Some of the functions internally call copy_{to,from}_user() but does
not use '__user'. this patch fixes missing __user annotations.
- this patch fixes the following sparse errors:
On Mon, Jul 28, 2014 at 11:07:40PM +0200, adrianremo...@gmail.com wrote:
From: Adrian Remonda adrianremo...@gmail.com
Your changelog text is up there in the subject, not down here in the
body of the email :(
___
devel mailing list
On Wed, Jul 30, 2014 at 11:33:41PM +0200, fernando.apesteg...@gmail.com wrote:
From: Fernando Apesteguia fernando.apesteg...@gmail.com
Add static to debug method.
Signed-off-by: Fernando Apesteguia fernando.apesteg...@gmail.com
---
drivers/staging/rtl8192u/r8192U_core.c |2 +-
1
On Wed, Jul 30, 2014 at 06:29:57PM +0530, Anil Belur wrote:
- private_ioctl() internally calls copy_{to,from}_user() and does
not use '__user' which gives out several sparse warnings
- these sparse warnings were fixed by adding __user annotation to
the data member of struct tagSCmdRequest:
On Tue, Jul 29, 2014 at 03:09:41PM -0400, Benjamin Romer wrote:
This patch switches all use of the U16 typedef to use the kernel's u16 type
instead.
Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com
---
.../include/channels/controlframework.h| 18
On Mon, Jul 28, 2014 at 07:38:23PM -0300, Murilo Opsfelder Araujo wrote:
Fix coding style issue.
Signed-off-by: Murilo Opsfelder Araujo mopsfel...@gmail.com
---
drivers/staging/android/sw_sync.c |2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/android/sw_sync.c
On Mon, Jul 28, 2014 at 08:03:46PM -0300, Murilo Opsfelder Araujo wrote:
Fix coding style issue.
Signed-off-by: Murilo Opsfelder Araujo mopsfel...@gmail.com
---
drivers/staging/android/sync.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
On Tue, Jul 29, 2014 at 04:41:53PM +0530, Sanjeev Sharma wrote:
This is a patch to the r8190_rtl8256.c file that fixes
checkpatch reported space coding style issues.
Signed-off-by: Sanjeev Sharmasanjeev_sha...@mentor.com
Please use a ' ' character...
Please resend all of your patches, they
On Thu, Jul 31, 2014 at 08:47:07AM -0300, Murilo Opsfelder Araujo wrote:
On 07/30/2014 09:17 PM, Greg KH wrote:
Also doesn't apply, are you sure you are using the staging-next branch
of staging.git on git.kernel.org?
I was using linux-next, not staging-next. sync.c has no checkpatch.pl
On Tue, Jun 24, 2014 at 02:46:55PM +0200, Antoine Schweitzer-Chaput wrote:
function dump_eprom is only used when DEBUG_EPROM is set.
function txqueue2outpipe is only used when USE_ONE_PIPE is unset.
function GetRxPacketShiftBytes819xUsb is only used when
USB_RX_AGGREGATION_SUPPORT is set.
On Tue, Jun 24, 2014 at 03:52:05PM +0200, Antoine Schweitzer-Chaput wrote:
The code which was only reachable using these options is also removed.
Signed-off-by: Antoine Schweitzer-Chaput anto...@schweitzer-chaput.fr
---
drivers/staging/rtl8192u/Makefile | 3 -
On Fri, Aug 01, 2014 at 07:31:10PM +0200, Antoine Schweitzer-Chaput wrote:
On Fri, Aug 01, 2014 at 08:54:07AM -0700, Greg KH wrote:
On Tue, Jun 24, 2014 at 03:52:05PM +0200, Antoine Schweitzer-Chaput wrote:
The code which was only reachable using these options is also removed.
Signed
701 - 800 of 4692 matches
Mail list logo
