[GIT PULL] Staging driver fixes for 3.16-rc8

2014-08-01 Thread Greg KH
The following changes since commit 9a3c4145af32125c5ee39c0272662b47307a8323: Linux 3.16-rc6 (2014-07-20 21:04:16 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/ tags/staging-3.16-rc8 for you to fetch changes up to

Re: [PATCH V2] staging: dgap: introduce dgap_cleanup_nodes()

2014-08-04 Thread Greg KH
On Tue, Aug 05, 2014 at 08:33:16AM +0900, DaeSeok Youn wrote: Hi, Mark and Greg. Thanks for testing. :-) Greg, is this patch possible to merge to your staging tree? Please check for me. patch : https://lkml.org/lkml/2014/7/31/2 It's the middle of the merge window, I can't do anything

Re: [GIT PULL] Staging driver patches for 3.17-rc1

2014-08-04 Thread Greg KH
On Tue, Aug 05, 2014 at 06:13:25AM +0200, Andreas Mohr wrote: Lots of things in here, over 2000 patches, but the best part is this: 1480 files changed, 39070 insertions(+), 254659 deletions(-) Thanks to the great work of Kristina Martšenko, 14 different staging drivers have been removed

Re: [PATCH] Staging: comedi: comedidev.h: fix checkpatch code style issue

2014-08-05 Thread Greg KH
On Wed, Aug 06, 2014 at 02:29:45AM +0300, Dzonatans Melgalvis wrote: Fixing checkpatch warning - blank line missing after declaration. Signed-off-by: Dzonatans Melgalvis dz.melgal...@gmail.com --- drivers/staging/comedi/comedidev.h | 6 ++ 1 file changed, 6 insertions(+) diff --git

Re: [PATCH 0/5] staging: dgnc: Fix checkpath issues in dgnc_neo.c

2014-08-06 Thread Greg KH
On Wed, Aug 06, 2014 at 09:01:21PM +0200, Konrad Zapalowicz wrote: This series of patches deals with the checkpatch error and warnings, other than 'line length over 80 chars', found in dgnc_neo.c file. All except of patch 5/5 do not change the behavior. Konrad Zapalowicz (5): staging:

Re: [PATCH] Staging: speakup: Insert blank lines after declarations in speakup_soft.c

2014-08-06 Thread Greg KH
On Wed, Aug 06, 2014 at 06:03:42PM +1000, Artemiy Volkov wrote: This patch fixes the checkpatch.pl 'Missing a blank line after declarations' warning in speakup_soft.c. Signed-off-by: Artemiy Volkov artem...@acm.org --- drivers/staging/speakup/speakup_soft.c | 3 +++ 1 file changed, 3

Re: [PATCH] staging: rtl8192u: fix sparse warnings in r8192U_core.c

2014-08-06 Thread Greg KH
On Wed, Aug 06, 2014 at 02:14:16PM +0530, A Raghavendra Rao wrote: Fix the following sparse warnings: drivers/staging/rtl8192u/r8192U_core.c:670:6: warning: symbol 'dump_eprom' was not declared. Should it be static? drivers/staging/rtl8192u/r8192U_core.c:1556:14: warning: symbol

Re: [PATCH] staging:r819xU: coding style: Fixed commenting style

2014-08-07 Thread Greg KH
On Thu, Aug 07, 2014 at 12:15:57PM +0530, Sanjeev Sharma wrote: This is a patch to the r819xU_phyreg.h file that fixes commenting style warning Signed-off-by: Sanjeev Sharma sanjeev_sha...@mentor.com --- drivers/staging/rtl8192u/r819xU_phyreg.h | 188 --- 1

Re: [PATCH] Hyperv: Trigger DHCP renew after host hibernation

2014-08-07 Thread Greg KH
...@linuxdriverproject.org; LKML; Greg KH; jasow...@redhat.com; Haiyang Zhang; KY Srinivasan; Thomas Shao; Dexuan Cui Subject: Re: [PATCH] Hyperv: Trigger DHCP renew after host hibernation On Mon, Jul 21, 2014 at 11:32 PM, David Miller da...@davemloft.net wrote: From: Olaf Hering o

Re: [PATCH] Hyperv: Trigger DHCP renew after host hibernation

2014-08-08 Thread Greg KH
On Fri, Aug 08, 2014 at 08:11:20AM +, Dexuan Cui wrote: From: Greg KH [mailto:gre...@linuxfoundation.org] Sent: Friday, August 8, 2014 11:32 AM Hi Richard and all, IMO the most feasible and need-the-least-change solution may be: the hyperv network VSC driver passes the event

Re: [PATCH 07/13] staging: comedi: amplc_dio200: tidy up comedi_driver declaration

2014-08-10 Thread Greg KH
On Fri, Aug 01, 2014 at 01:07:05PM -0700, H Hartley Sweeten wrote: For aesthetics, add some whitespace to the declaration. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Reviewed-by: Ian Abbott abbo...@mev.co.uk --- drivers/staging/comedi/drivers/amplc_dio200.c | 14

Re: [PATCH] staging: dgnc: remove some unused code

2014-08-10 Thread Greg KH
On Sat, Aug 02, 2014 at 08:06:38PM +0900, Seunghun Lee wrote: Remove some unused code. CC: Lidza Louina lidza.lou...@gmail.com CC: Mark Hounschell ma...@compro.net Signed-off-by: Seunghun Lee way...@gmail.com --- drivers/staging/dgnc/dgnc_cls.c| 72 +-

Re: [PATCH 01/12] staging: lustre: remove space between function name and and open parenthesis

2014-08-10 Thread Greg KH
On Wed, Aug 06, 2014 at 10:42:51PM +0530, Srikrishan Malik wrote: Fixes following checkpatch warning: WARNING: space prohibited between function name and open parenthesis '(' Signed-off-by: Srikrishan Malik srikrishanma...@gmail.com Can you redo this whole series, based on the comments you

Re: [PATCH] staging: rtl8188eu: HalPhyRf_8188e: Fix static symbol sparse warning

2014-08-10 Thread Greg KH
On Tue, Aug 05, 2014 at 09:03:48PM +0100, Miguel Oliveira wrote: Fix sparse warning: drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c:25:4: warning: symbol 'ODM_GetRightChnlPlaceforIQK' was not declared. Should it be static? by making it static since it's only used once. Signed-off-by:

Re: [PATCH] staging: rtl8192u: checkpatch: do not use C99 // comments

2014-08-10 Thread Greg KH
On Sun, Aug 03, 2014 at 09:28:20PM +0200, Martin Kepplinger wrote: Use the common kernel coding style, so don't use C99 // comments. If too long, where reasonable, they are shortened as well. Some old internal comments about date and author of changes are removed. This provides a more

Re: [PATCHv2 2/2] Staging: rtl8188eu: Removed unnecessarry code.

2014-08-10 Thread Greg KH
On Fri, Aug 08, 2014 at 12:05:38PM +0300, Dan Carpenter wrote: On Thu, Aug 07, 2014 at 11:37:51PM +0200, Adrian Remonda wrote: This patch clear some code that was not doing any help. Pointed out by Larry.Finger The patch is fine but the changelog doesn't inpsire confidence. It should

Re: [PATCH 00/15] staging: comedi: 8255: tidy up the (*io) operations

2014-08-10 Thread Greg KH
On Mon, Aug 04, 2014 at 02:18:43PM +0100, Ian Abbott wrote: On 2014-08-01 22:18, H Hartley Sweeten wrote: Now that the comedi_device has a 'mmio' and a 'iobase' member, this module can detect if the (*io) operations need to use readb/writeb for memory mapped I/O or inb/outb for port I/O. This

Re: [PATCH 02/10] staging: ozwpan: Fix typo in typedef

2014-08-10 Thread Greg KH
On Mon, Aug 04, 2014 at 02:54:48PM +0200, Christoph Jaeger wrote: Signed-off-by: Christoph Jaeger em...@christophjaeger.info --- drivers/staging/ozwpan/ozproto.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/ozwpan/ozproto.h

Re: [PATCH 1/3] Staging: Netlogic: Fix compilation error

2014-08-10 Thread Greg KH
On Tue, Aug 05, 2014 at 07:44:23PM +0530, ganes...@broadcom.com wrote: From: Ganesan Ramalingam ganes...@broadcom.com Cop2 save and restore function names are changed, added that change I can't understand this sentance, what does it mean? What compilation error? Where is it broken, in

Re: [PATCH] staging: et131x: Fix errors caused by phydev-addr accesses before initialisation

2014-08-10 Thread Greg KH
On Tue, Aug 05, 2014 at 11:57:06PM +0100, Mark Einon wrote: Fix two reported bugs, caused by et131x_adapter-phydev-addr being accessed before it is initialised, by: - letting et131x_mii_write() take a phydev address, instead of using the one stored in adapter by default. This is so

Re: [PATCH v2] Staging: speakup: Insert blank lines after declarations in speakup_soft.c

2014-08-10 Thread Greg KH
On Thu, Aug 07, 2014 at 01:21:25PM +1000, Artemiy Volkov wrote: This patch fixes the checkpatch.pl 'Missing a blank line after declarations' warning in speakup_soft.c. Signed-off-by: Artemiy Volkov artem...@acm.org --- drivers/staging/speakup/speakup_soft.c | 3 +++ 1 file changed, 3

Re: [PATCH] staging: dgnc: Encapsulate global variables in a structure

2014-08-10 Thread Greg KH
On Sat, Aug 09, 2014 at 08:16:37PM +0200, Konrad Zapalowicz wrote: This commit binds global variables of dgnc driver in a structure so that it is logically consistent. The structure is accessed via getter function and as a result the externing of globals is removed. The names of the variables

Re: [PATCH] staging: dgnc: Encapsulate global variables in a structure

2014-08-10 Thread Greg KH
On Sun, Aug 10, 2014 at 09:19:15PM +0200, Konrad Zapalowicz wrote: On 08/10, Greg KH wrote: On Sat, Aug 09, 2014 at 08:16:37PM +0200, Konrad Zapalowicz wrote: This commit binds global variables of dgnc driver in a structure so that it is logically consistent. The structure is accessed via

Re: [PATCH] staging: wlan-ng: prism2mgmt.c Fix break not useful

2014-08-10 Thread Greg KH
On Mon, Aug 11, 2014 at 12:10:37AM +0530, Jeshwanth Kumar N K wrote: This is the part of eudyptula task-10.This is a patch to the prism2mgmt.c file that fixes up warning break is not useful after a goto or return found in checkpatch.pl tool. That's a really long single line, please fix it

Re: [PATCH] drivers: staging: vt6655: wpactl.c checkpatch clean-up

2014-08-10 Thread Greg KH
On Sun, Aug 10, 2014 at 11:28:55PM +0530, Avinash kumar wrote: Cleaned all C99 comments related warnings Signed-off-by :Avinash Kumar avi.kp@gmail.com Signed-off-by: Avinash kumar avi.kp@gmail.com Why is this line twice in here, the first one has the ':' in the wrong place. Please

Re: [PATCH v2] Staging: speakup: Insert blank lines after declarations in speakup_soft.c

2014-08-10 Thread Greg KH
On Sun, Aug 10, 2014 at 10:56:38PM +1000, Artemiy Volkov wrote: On Sat, 9 Aug 2014, Greg KH wrote: On Thu, Aug 07, 2014 at 01:21:25PM +1000, Artemiy Volkov wrote: This patch fixes the checkpatch.pl 'Missing a blank line after declarations' warning in speakup_soft.c. Signed-off

Re: [PATCH 1/3] Staging: Netlogic: Fix compilation error

2014-08-11 Thread Greg KH
it? The patch [PATCH 1/3] Staging: Netlogic: Fix compilation error is to address the above issue. Sorry that the commit message is not clear, I will submit a new patchset with a appropriate message. And wrap your line-ends, it's nicer that way :) thanks, greg kh

Re: [PATCH 07/13] staging: comedi: amplc_dio200: tidy up comedi_driver declaration

2014-08-11 Thread Greg KH
On Mon, Aug 11, 2014 at 05:09:49PM +, Hartley Sweeten wrote: On Saturday, August 09, 2014 9:15 PM, Greg KH wrote: On Fri, Aug 01, 2014 at 01:07:05PM -0700, H Hartley Sweeten wrote: For aesthetics, add some whitespace to the declaration. Signed-off-by: H Hartley Sweeten hswee

Re: [PATCH] drivers: staging: vt6655: wpactl.h: corrected comment format

2014-08-11 Thread Greg KH
On Mon, Aug 11, 2014 at 11:26:32PM +0530, Avinash kumar wrote: corrected C99 style comment format related error Signed-off-by: Avinash Kumar avi.kp@gmail.com --- drivers/staging/vt6655/wpactl.h |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [PATCH] Input: serio: make HYPERV_KEYBOARD depend on SERIO_I8042=y

2014-08-11 Thread Greg KH
On Mon, Aug 11, 2014 at 08:30:40PM -0700, Dexuan Cui wrote: hyperv_keyboard invokes serio_interrupt(), which needs a valid serio driver like atkbd.c. atkbd.c depends on libps2.c because it invokes ps2_command(). libps2.c depends on i8042.c because it invokes i8042_check_port_owner(). As a

Re: [PATCH] Input: serio: make HYPERV_KEYBOARD depend on SERIO_I8042=y

2014-08-12 Thread Greg KH
On Tue, Aug 12, 2014 at 05:51:28AM +, Dexuan Cui wrote: -Original Message- From: Greg KH [mailto:gre...@linuxfoundation.org] Decoupling the dependency between hyperv_keyboard and i8042 needs non-trivial efforts and is hence a long term goal. For now, let's make

Re: [PATCH] Staging: bmc: fix coding style warning

2014-08-13 Thread Greg KH
On Wed, Aug 13, 2014 at 11:36:59AM -0400, rbasukala wrote: This a a patch to the vendorspecificextn.c that fixes coding style warning found by checkpatch.pl script. I am submitting this patch as required by Eudyptula Challenge. That's a very long line for a changelog entry, please wrap them

Re: [PATCH] Staging: bmc: fix coding style warning

2014-08-13 Thread Greg KH
On Wed, Aug 13, 2014 at 08:53:59PM -0400, Ramesh Basukala wrote: From: rbasukala basukalaram...@gmail.com This doesn't match up with your signed-off-by: line, or your name up there in the mail header. Please fix this up and resend. thanks, greg k-h

Re: [PATCH] staging: dgnc: remove DPR Macros and related codes.

2014-08-15 Thread Greg KH
On Tue, Aug 12, 2014 at 10:30:14PM +0900, Seunghun Lee wrote: In dgnc_drivers.h, DPR macro and DPR_* macros are defined but do nothing. So remove them and related codes. CC: Lidza Louina lidza.lou...@gmail.com CC: Mark Hounschell ma...@compro.net Signed-off-by: Seunghun Lee

Re: [PATCH] Staging: bmc: fix coding style warning

2014-08-15 Thread Greg KH
On Thu, Aug 14, 2014 at 10:11:44AM -0400, Ramesh Basukala wrote: This is a patch to the vendorspecificextn.c that fixes coding style warning message line over 80 characters found by checkpatch.pl script. I am submitting this patch as required by Eudyptula Challenge. Minor nit, your subject is

Re: [PATCH 1/1] staging: dgnc: brace checkpatch fixes

2014-08-15 Thread Greg KH
On Thu, Aug 14, 2014 at 05:53:10PM -0700, Aaron Brice wrote: Bring braces in line with CodingStyle Signed-off-by: Aaron Brice aa...@tastycactus.com --- Applies to next-20140814 drivers/staging/dgnc/dgnc_neo.c | 10 -- drivers/staging/dgnc/dgnc_sysfs.c | 6 ++

Re: [PATCH] drivers: staging: vt6655: wpactl.c checkpatch clean-up

2014-08-15 Thread Greg KH
On Mon, Aug 11, 2014 at 11:32:58AM +0530, Avinash kumar wrote: Cleaned all C99 comments related warnings Signed-off-by: Avinash kumar avi.kp@gmail.com --- drivers/staging/vt6655/wpactl.c | 40 +++ 1 file changed, 20 insertions(+), 20

Re: [PATCH] staging: lustre: lustre: libcfs: pr_warn instead printk

2014-08-15 Thread Greg KH
On Fri, Aug 15, 2014 at 11:48:05PM +0530, Hema Prathaban wrote: This patch fixes the following warning using checkpatch.pl WARNING: Prefer [subsystem eg: netdev]_warn([subsystem]dev, ... then dev_warn(dev, ... then pr_warn(... to printk(KERN_WARNING ... Signed-off-by: Hema Prathaban

Re: Archive

2014-08-17 Thread Greg KH
On Sun, Aug 17, 2014 at 09:46:34AM -0300, Raphael Philipe wrote: Where is the archive for this list? I cannot find it. Thank you. ___ devel mailing list de...@linuxdriverproject.org

Re: Archive

2014-08-17 Thread Greg KH
A: No. Q: Should I include quotations after my reply? http://daringfireball.net/2007/07/on_top On Sun, Aug 17, 2014 at 10:01:59AM -0300, Raphael Philipe wrote: I suspected that, but since the domain name is different (de...@linuxdriverproject.org and de...@driverdev.osuosl.org) , I thought

Re: [PATCHv2] staging: rtl8192u: checkpatch: do not use C99 // comments

2014-08-17 Thread Greg KH
On Sun, Aug 10, 2014 at 03:15:10PM +0200, Martin Kepplinger wrote: Use the common kernel coding style, so don't use C99 // comments in r8192U_core.c If too long, where reasonable, they are shortened as well. Some old internal comments about date and author of changes are removed. This

Re: [PATCH] staging: rtl8192ee: fix %d confusingly prefixed with 0x in format strings

2014-08-17 Thread Greg KH
On Sun, Aug 10, 2014 at 08:28:42PM -0700, Hans Wennborg wrote: Signed-off-by: Hans Wennborg h...@hanshq.net --- drivers/staging/rtl8192ee/pci.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) This patch doesn't apply at all to my tree, can you please refresh it against the next

Re: [PATCH] Staging: bcm: fix coding style warning

2014-08-17 Thread Greg KH
On Fri, Aug 15, 2014 at 11:50:53AM -0400, Ramesh Basukala wrote: This is a patch to the vendorspecificextn.c that fixes coding style warning message line over 80 characters found by checkpatch.pl script. I am submitting this patch as required by Eudyptula Challenge. Signed-off-by: Ramesh

Re: [PATCH] staging: gs_fpgaboot: add bus_width module parameter

2014-08-22 Thread Greg KH
On Fri, Aug 22, 2014 at 02:16:02PM +0300, Cihangir Akturk wrote: This parameter allows the program bus width to be specified at module insertion time. Why? Who would set this? Why is it a module option and not a device option? Adding module options is frowned apon if at all possible.

Re: [PATCH] staging:lustre:lnet: lib-md.c fix checkpath warnings and errors.

2014-08-26 Thread Greg KH
On Mon, Aug 25, 2014 at 01:18:54AM +0800, Janet Liu wrote: Sliences the following warning and error: WARNING: line over 80 characters WARNING: space prohibited between function name and open parenthesis '(' ERROR: do not use C99 // comments ERROR: trailing statements should be on

Re: Fwd: Re: [PATCH] staging:lustre:lnet: lib-md.c fix checkpath warnings and errors.

2014-08-28 Thread Greg KH
On Thu, Aug 28, 2014 at 10:23:05AM +0800, Janet Liu wrote: On 08/28/2014 10:20 AM, Janet Liu wrote: Original Message Subject: Re: [PATCH] staging:lustre:lnet: lib-md.c fix checkpath warnings and errors. Date: Tue, 26 Aug 2014 18:22:45 -0700 From: Greg KH gre

[GIT PULL] Staging driver fixes for 3.17-rc3

2014-08-29 Thread Greg KH
The following changes since commit 7d1311b93e58ed55f3a31cc8f94c4b8fe988a2b9: Linux 3.17-rc1 (2014-08-16 10:40:26 -0600) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/ tags/staging-3.17-rc3 for you to fetch changes up to

Re: [PATCH] staging: lustre: lustre: ptlrpc: Fix space required

2014-08-30 Thread Greg KH
On Thu, Aug 21, 2014 at 06:59:07PM +0530, Hema Prathaban wrote: This patch fixes the checkpatch.pl issue Error: Required space after '+' ',' '=' '(' ' if' Signed-off-by: Hema Prathaban hemakl...@gmail.com --- drivers/staging/lustre/lustre/ptlrpc/client.c | 2 +-

Re: [PATCH 1/2] jsm: add support for additional Neo cards

2014-08-30 Thread Greg KH
On Sat, Aug 30, 2014 at 02:54:36PM -0400, wf...@worldbroken.com wrote: From: Bill Pemberton wf...@worldbroken.com Add device ids for additional Neo cards. The ids come from the dgnc driver. Signed-off-by: Bill Pemberton wf...@worldbroken.com --- drivers/tty/serial/jsm/jsm_driver.c | 38

Re: [PATCH] staging: fix style in lustre_import.h

2014-08-30 Thread Greg KH
On Fri, Aug 22, 2014 at 07:57:40PM -0400, Spencer Baugh wrote: This patch fixes style errors and warnings reported by scripts/checkpatch.pl Which errors and warnings does it fix? Please always be specific. And only do one type of fix per patch, you do a few different ones here, right? Can

Re: [PATCHv1 2/4] staging:lustre:lnet: lib-md.c delete space before '(' for code style

2014-08-30 Thread Greg KH
On Sat, Aug 30, 2014 at 02:56:09PM +0800, Janet Liu wrote: Silences the following checkpatch warning: WARNING: space prohibited between function name and open parenthesis '(' Signed-off-by: Janet Liu jianhua@gmail.com --- drivers/staging/lustre/lnet/lnet/lib-md.c | 18

Re: [PATCHv1 3/4] staging:lustre:lnet: lib-md.c erase C99 // comments

2014-08-30 Thread Greg KH
On Sat, Aug 30, 2014 at 02:57:33PM +0800, Janet Liu wrote: After changing the comments format, the other error disappears. So silences two checkpatch errors: ERROR: do not use C99 // comments ERROR: trailing statements should be on next line Signed-off-by: Janet Liu

Re: [PATCH 01/57] Staging: bcm: CmHost.c: Renamed variable: Adapter - ad

2014-08-30 Thread Greg KH
On Wed, Aug 27, 2014 at 01:11:19PM +0200, Matthias Beyer wrote: -int FreeAdapterDsxBuffer(struct bcm_mini_adapter *Adapter) +int FreeadDsxBuffer(struct bcm_mini_adapter *ad) This change breaks the build: ERROR: FreeAdapterDsxBuffer [drivers/staging/bcm/bcm_wimax.ko] undefined! _PLEASE_

Re: [PATCH 3/8] staging: et131x: Use for loop to initialise contiguous registers to zero

2014-08-30 Thread Greg KH
On Wed, Aug 20, 2014 at 11:17:53PM +0100, Mark Einon wrote: Replace a long list of contiguous writel() calls with a for loop iterating over the same values. Signed-off-by: Mark Einon mark.ei...@gmail.com --- drivers/staging/et131x/et131x.c | 27 +++ 1 file changed,

Re: [PATCH 1/4] staging: rtl8188eu: os_intfs.c

2014-08-30 Thread Greg KH
Your subject does not say what is going on in this patch, only the file being modified :( On Fri, Aug 22, 2014 at 11:32:38AM +0100, Miguel Oliveira wrote: void rtw_proc_remove_one(struct net_device *dev) { } void rtw_proc_init_one(struct net_device *dev) /* TODO: Convert these to /sys */

Re: [PATCH 3/4] staging: rtl8188eu: osdep_intf.h and usb_intf.c

2014-08-30 Thread Greg KH
On Fri, Aug 22, 2014 at 11:33:37AM +0100, Miguel Oliveira wrote: Convert all rtw_proc_xxx references to rtw_sys_xxx in files include/osdep_intf.h and os_dep/usb_intf.c Same comments as the previous ones, please redo all of these patches. greg k-h ___

Re: [PATCH 2/4] staging: rtl8188eu: rtw_debug.c

2014-08-30 Thread Greg KH
On Fri, Aug 22, 2014 at 11:33:20AM +0100, Miguel Oliveira wrote: Convert all rtw_proc_xxx references to rtw_sys_xxx Again, your subject: is not understandable. And what are you doing here? Code with 62 WARNING: line over 80 characters, I'll write another patch to clean the whole file. What

Re: [PATCH 4/4] staging: rtl8188eu: rtw_debug.h

2014-08-30 Thread Greg KH
On Fri, Aug 22, 2014 at 11:33:52AM +0100, Miguel Oliveira wrote: Convert all rtw_proc_xxx references to rtw_sys_xxx in file include/rtw_debug.h That's interesting, but: Signed-off-by: Miguel Oliveira cmro...@gmail.com --- drivers/staging/rtl8188eu/include/rtw_debug.h | 227

Re: [PATCH] rtl8188eu: Replace rcu_dereference() with rcu_access_pointer()

2014-08-30 Thread Greg KH
On Sun, Aug 17, 2014 at 02:43:37PM +0300, Andreea-Cristina Bernat wrote: The rcu_dereference() call is used directly in a condition. Since its return value is never dereferenced it is recommended to use rcu_access_pointer() instead of rcu_dereference(). Therefore, this patch makes the

Re: [PATCH 03/20] staging: rtl8188eu: Rework function PHY_QueryBBReg()

2014-08-30 Thread Greg KH
On Sat, Aug 23, 2014 at 07:48:24PM +0530, navin patidar wrote: Rename CamelCase variables and function name. Signed-off-by: navin patidar navin.pati...@gmail.com This patch fails to apply: checking file drivers/staging/rtl8188eu/hal/HalHWImg8188E_RF.c checking file

Re: [PATCH] staging: rtl8723au: type casting corrections

2014-08-30 Thread Greg KH
On Sun, Aug 17, 2014 at 10:19:28AM -0300, Raphael Silva wrote: Type casting corrections in order to solve warnings of the sparce static analyser. Signed-off-by: Raphael Silva rapp...@gmail.com --- drivers/staging/rtl8723au/hal/usb_halinit.c | 4 ++--

Re: [PATCH] staging:r8190_rtl8256: coding style: Fixed commenting style

2014-08-30 Thread Greg KH
On Mon, Aug 25, 2014 at 12:55:27PM +0530, Sanjeev Sharma wrote: This is a patch to the r8190_rtl8256.c file that fixes commenting style Error Signed-off-by: Sanjeev Sharma sanjeev_sha...@mentor.com --- drivers/staging/rtl8192u/r8190_rtl8256.c | 59 +--- 1

Re: [PATCH] Staging: rtl8821ae: hal_bt_coexist: fix coding style issue

2014-08-30 Thread Greg KH
On Sat, Aug 30, 2014 at 02:10:52PM -0400, An Ha wrote: Fix coding style issues, these changes include: -Add space between if and brackets -Add space after comma in an argument -Add space between equal sign to separate the variable and the assignment -Remove unnecessary curly braces around

Re: [PATCH] os_dep: Replace rcu_dereference() with rcu_access_pointer()

2014-08-30 Thread Greg KH
On Sun, Aug 17, 2014 at 04:39:16PM +0300, Andreea-Cristina Bernat wrote: The rcu_dereference() call is used directly in a condition. Since its return value is never dereferenced it is recommended to use rcu_access_pointer() instead of rcu_dereference(). Therefore, this patch makes the

Re: [PATCH] staging: android: Add blank line after declaration

2014-08-30 Thread Greg KH
On Wed, Aug 20, 2014 at 04:19:19PM +0100, Purnendu Kapadia wrote: Signed-off-by: Purnendu Kapadia pro8li...@gmail.com --- drivers/staging/android/sync.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/android/sync.c b/drivers/staging/android/sync.c index

Re: [PATCH] staging: android: sw_sync.c: fix new line style issues

2014-08-30 Thread Greg KH
On Mon, Aug 25, 2014 at 08:35:31PM +0100, Koray Gulcu wrote: Add two new lines that are missing after declerations as detected by checkpatch.pl Signed-off-by: Koray Gulcu koray.gu...@ozu.edu.tr --- drivers/staging/android/sw_sync.c |2 ++ 1 file changed, 2 insertions(+) 2 other

Re: [PATCH 3/4] staging: rtl8188eu: osdep_intf.h and usb_intf.c

2014-08-30 Thread Greg KH
On Sat, Aug 30, 2014 at 11:22:56PM +0200, Miguel Oliveira wrote: Same comments as the previous ones, please redo all of these patches. Should all the alterations be in one big single patch, insted of small ones? I don't know, I don't remember what this patch even contained given that it was

Re: [PATCH 3/8] staging: et131x: Use for loop to initialise contiguous registers to zero

2014-08-31 Thread Greg KH
On Sun, Aug 31, 2014 at 03:25:03PM +0100, Mark Einon wrote: On Sat, Aug 30, 2014 at 01:32:16PM -0700, Greg KH wrote: On Wed, Aug 20, 2014 at 11:17:53PM +0100, Mark Einon wrote: Replace a long list of contiguous writel() calls with a for loop iterating over the same values. Signed

Re: [PATCH] staging: xillybus: Move out of staging

2014-09-01 Thread Greg KH
On Mon, Sep 01, 2014 at 10:01:38PM +0300, Eli Billauer wrote: Hello Tobias, Thanks for that heads-up. I'll make a separate patch for MAINTAINERS if and when the driver goes out of staging. No point risking the failure to apply the major patch because of a clash on MAINTAINERS. You can send

Re: [PATCH] staging: android: add a blank line after declarations

2014-09-01 Thread Greg KH
On Sun, Aug 31, 2014 at 09:43:15PM +0100, Grzegorz Swirski wrote: Signed-off-by: Grzegorz Swirski grzeg...@swirski.name --- drivers/staging/android/sync.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/android/sync.c b/drivers/staging/android/sync.c index

Re: [PATCH] staging: comedi: usbduxsigma: fix more sparse endianness warnings

2014-09-02 Thread Greg KH
On Mon, Sep 01, 2014 at 10:24:40AM +0100, Ian Abbott wrote: On 2014-09-01 10:23, Ian Abbott wrote: On 2014-08-31 20:45, Chase Southwood wrote: Sparse shows a couple of warnings like: drivers/staging/comedi/drivers/usbduxsigma.c:787:23: warning: cast to restricted __be32 Looking at the

Re: [PATCH 1/2] staging: dgnc: Make the struct dgnc_board possible to use list facility

2014-09-02 Thread Greg KH
On Sun, Aug 31, 2014 at 11:23:57PM +0200, Konrad Zapalowicz wrote: This commit adds the struct list_head to the struct dgnc_board so that it is now possible to use it with the Linux list facility. Signed-off-by: Konrad Zapalowicz bergo.torino+ker...@gmail.com ---

Re: staging: android: uapi: binder.h: Used __packed instead of __attribute__((packed))

2014-09-02 Thread Greg KH
On Mon, Sep 01, 2014 at 08:47:12AM -0400, Dipak Zope wrote: Signed-off-by: Dipak Zope dipakzope.kernel@gmail.com --- drivers/staging/android/uapi/binder.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/android/uapi/binder.h

Re: [PATCH 1/2] staging: dgnc: Make the struct dgnc_board possible to use list facility

2014-09-02 Thread Greg KH
On Tue, Sep 02, 2014 at 07:55:49PM +0200, Konrad Zapalowicz wrote: On 09/02, Greg KH wrote: On Sun, Aug 31, 2014 at 11:23:57PM +0200, Konrad Zapalowicz wrote: This commit adds the struct list_head to the struct dgnc_board so that it is now possible to use it with the Linux list facility

Re: [PATCH] Staging: rtl8192u: fix brace style coding issue in r819xU_firmware.c

2014-09-04 Thread Greg KH
On Thu, Sep 04, 2014 at 07:39:11PM +0530, Chaitra Ramaiah wrote: *** BLURB HERE *** No blurb??? :) ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] Staging: rtl8192u: fix brace style coding issue in r819xU_firmware.c This is a patch to the file r819xU_firmware.c that fixes a brace warning found by checkpatch.pl tool

2014-09-04 Thread Greg KH
On Thu, Sep 04, 2014 at 07:39:12PM +0530, Chaitra Ramaiah wrote: From: root root@admin1-Lenovo-IdeaPad-Y510P.(none) I don't think that is your email address... ALso, look at your subject, something went wrong here :( Care to try again? thanks, greg k-h

Re: [PATCH] rtl8188eu: Replace rcu_dereference() with rcu_access_pointer()

2014-09-04 Thread Greg KH
On Thu, Sep 04, 2014 at 11:58:36PM +0300, Andreea Bernat wrote: Hello, I cloned this: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git and after moved to staging-next branch, but in both cases, in those files I don't find any use of rcu_dereference() call (the call which

Re: [GIT PULL] Staging driver patches for 3.15-rc1

2014-09-04 Thread Greg KH
On Fri, Sep 05, 2014 at 01:13:55AM +0200, Paul Bolle wrote: On Wed, 2014-04-02 at 16:08 -0700, Greg KH wrote: On Wed, Apr 02, 2014 at 08:52:18PM +, Insop Song wrote: On Wed, April 02, 2014 1:04 PM, Greg KH wrote: On Wed, Apr 02, 2014 at 10:24:03AM +0200, Paul Bolle wrote: On Tue

Re: [PATCH 1/1] Drivers: hv: vmbus: Enable interrupt driven flow control

2014-09-05 Thread Greg KH
On Fri, Sep 05, 2014 at 11:23:22AM -0700, K. Y. Srinivasan wrote: This is a win8 feature that has been implemented. Turn on the feature bit to enable the feature. What does those two sentances even mean? With this feature turned on, What is this? when the host is waiting for space to

Re: [PATCH 1/1] Drivers: hv: vmbus: Enable interrupt driven flow control

2014-09-05 Thread Greg KH
On Fri, Sep 05, 2014 at 08:53:01PM +, KY Srinivasan wrote: -Original Message- From: Greg KH [mailto:gre...@linuxfoundation.org] Sent: Friday, September 5, 2014 12:12 PM To: KY Srinivasan Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; o...@aepfle.de

Re: [PATCH] staging: ozwpan: Fix coding style warnings

2014-09-06 Thread Greg KH
On Fri, Sep 05, 2014 at 10:08:23PM -0400, anicoara wrote: The warnings addressed: 1. Missing a blank line after declarations. 2. else is not generally useful after a break or return Please break this up into 2 patches, each patch should only do one thing at a time. thanks, greg k-h

Re: [PATCH] Staging: octeon-hcd: removed unwanted return from void functions

2014-09-08 Thread Greg KH
On Mon, Sep 08, 2014 at 09:59:23PM +0300, Aaro Koskinen wrote: On Mon, Sep 08, 2014 at 07:13:15PM +0200, Nitin Kuppelur wrote: This is a patch to the octeon-hcd.c file that fixes checkpatch.pl warning by removing return statement from void functions. Please format line length to = 76

Re: [PATCH 1/3] staging: lustre: fix function definition style

2014-09-08 Thread Greg KH
On Sat, Sep 06, 2014 at 01:38:27PM -0400, Spencer Baugh wrote: Fix errors reported by checkpatch of this kind: ERROR: open brace '{' following function declarations go on the next line Signed-off-by: Spencer Baugh sba...@andrew.cmu.edu ---

Re: [Patch v2 0/2] Move Digi Neo card support from dgnc to jsm

2014-09-08 Thread Greg KH
On Sat, Aug 30, 2014 at 04:35:56PM -0400, wf...@worldbroken.com wrote: From: Bill Pemberton wf...@worldbroken.com The jsm driver (drivers/tty/serial/jsm) already supports the Digi Neo cards that dgnc (staging) supports. In fact, it appears that jsm was based on dgnc. The dgnc driver has

Re: [PATCH] unisys: Fix sparse error - accessing __iomem directly

2014-09-08 Thread Greg KH
On Mon, Sep 08, 2014 at 01:44:49PM +0100, Luke Hart wrote: Copy the channel type into a temporary buffer so that code will work for architectures that don't support MMIO. This now works in same way as other tests in same function. Can you please line-wrap your changelog lines? Re-sent

Re: staging: android: uapi: binder.h: Used __packed instead of __attribute__((packed))

2014-09-08 Thread Greg KH
On Mon, Sep 01, 2014 at 08:47:12AM -0400, Dipak Zope wrote: Signed-off-by: Dipak Zope dipakzope.kernel@gmail.com --- drivers/staging/android/uapi/binder.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/android/uapi/binder.h

Re: [PATCH] rtl8188eu: rtw_xmit: Replace rcu_dereference() with rcu_access_pointer()

2014-09-08 Thread Greg KH
On Thu, Sep 04, 2014 at 08:15:48PM +0300, Andreea-Cristina Bernat wrote: The br_port local variables obtained through the rcu_dereference() calls are not dereferenced in the rest of their function. Therefore, it is recommended to use rcu_access_pointer() instead of rcu_dereference(). This

Re: [PATCH 1/4] staging: lustre: fix coding style issues

2014-09-08 Thread Greg KH
On Tue, Sep 09, 2014 at 12:04:43AM +0200, Hugues wrote: Fix coding style issues: * limit the length of changed lines to 80 columns. Why isn't this in the body of the changelog? From a244d32aa34d0b13ac40dd014b88d0ff5ed10817 Mon Sep 17 00:00:00 2001 From: Hugues Morisset

Re: UART driver development

2014-09-10 Thread Greg KH
On Wed, Sep 10, 2014 at 04:20:27PM +0200, Adrien PEYROUTY wrote: Hello all, I am currently working on a UART driver for linux. For what specific UART and platform? I am developping a new architecture on which I have 3 uart ports. 3 different uarts on what type of bus? In this

Re: [PATCH] staging: unisys: Fix sparse error - accessing __iomem directly

2014-09-11 Thread Greg KH
On Mon, Sep 08, 2014 at 03:27:35PM +0100, Luke Hart wrote: Copy the channel type into a temporary buffer so that code will work for architectures that don't support MMIO. This now works in same way as other tests in same function. Signed-off-by: Luke Hart luke.h...@birchleys.eu ---

Re: [PATCH] staging: android: checkpatch fixes for sw_sync files

2014-09-11 Thread Greg KH
On Wed, Sep 10, 2014 at 10:10:49PM +0100, Purnendu Kapadia wrote: - add line after declaration - allignment should match open parenthesis - remove unnecessary new line Signed-off-by: Purnendu Kapadia pro8li...@gmail.com --- drivers/staging/android/sw_sync.c | 9 +

Re: My RTL8188SU usb stick sucks :(

2014-09-12 Thread Greg KH
On Fri, Sep 12, 2014 at 09:47:56AM -0400, Weedy wrote: How do I make this stick suck less? I was sitting in the same room as my AP when I ran the scan. My atheros card picks up 2 strong APs plus my own, and 4-7 others of varying strengths. Not even a directional antenna lists more networks.

Re: [PATCH 4/8] staging: et131x: Remove ununsed statistics

2014-09-13 Thread Greg KH
On Sat, Sep 13, 2014 at 12:37:46PM +0300, Dan Carpenter wrote: On Thu, Sep 11, 2014 at 10:59:42PM +0100, Mark Einon wrote: From struct ce_stats; unicast_pkts_rcvd, unicast_pkts_xmtd, multicast_pkts_xmtd, broadcast_pkts_rcvd and broadcast_pkts_xmtd For some reason something adds a '' to the

Re: [PATCH] Staging: android: ion: fix coding style

2014-09-14 Thread Greg KH
First off, thanks for the patches. But, they need some tweaks before I can accept them. You sent a bunch of patches, all with the same exact subject, with no hint of which order they should be applied in, or what exactly they do. On Sat, Sep 13, 2014 at 04:46:10PM -0700, Sorin Facaoaru wrote:

Re: Staging: unisys: base drivers complete

2014-09-15 Thread Greg KH
On Mon, Sep 15, 2014 at 10:56:07AM -0500, Ken Cox wrote: Greg and other reviewers, Ben Romer and I believe that the Unisys drivers in staging-next are now complete. Are there any other changes that you are aware of that we need to make to these drivers? Have you actually ran the

Re: Staging: unisys: base drivers complete

2014-09-15 Thread Greg KH
On Mon, Sep 15, 2014 at 12:14:49PM -0500, Romer, Benjamin M wrote: Have you actually ran the checkpatch.pl tool on this code? You still have a lot of cleanup to do (hint, typedefs for drivers are not allowed...) Yes, I've been using checkpatch.pl a lot, though admittedly I did not know

Re: [PATCH 07/12] staging: et131x: Fix indenting using mixed tabs and spaces

2014-09-19 Thread Greg KH
On Sun, Sep 14, 2014 at 04:59:03PM +0100, Mark Einon wrote: Fix two lines where mixed tabs and spaces were used for indenting. Signed-off-by: Mark Einon mark.ei...@gmail.com --- drivers/staging/et131x/et131x.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[GIT PULL] Staging driver fixes for 3.17-rc6

2014-09-20 Thread Greg KH
The following changes since commit 9e82bf014195d6f0054982c463575cdce24292be: Linux 3.17-rc5 (2014-09-14 17:50:12 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/ tags/staging-3.17-rc6 for you to fetch changes up to

Re: [PATCH] Fix the issue that lowmemkiller fell into a cycle that try to kill a task

2014-09-22 Thread Greg KH
On Tue, Sep 23, 2014 at 10:57:09AM +0800, Hui Zhu wrote: The cause of this issue is when free memroy size is low and a lot of task is trying to shrink the memory, the task that is killed by lowmemkiller cannot get CPU to exit itself. Fix this issue with change the scheduling policy to

Re: [PATCH v2] Tools: hv: vssdaemon: ignore the EBUSY on multiple freezing the same partition

2014-09-24 Thread Greg KH
On Mon, Sep 22, 2014 at 10:00:55PM -0700, Dexuan Cui wrote: v2: I added errno = 0; in the ioctl() That does not belong in the changelog, put it below the --- line. Also, you need a changelog description here, it can't be empty. greg k-h ___ devel

<    4   5   6   7   8   9   10   11   12   13   >