From: Ajay Singh
We would like to update the maintainer email id's for wilc1000 driver.
Signed-off-by: Ajay Singh
Signed-off-by: Adham Abozaeid
---
MAINTAINERS | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 7c7af53..9647ec7 100644
---
From: Ajay Singh
Refactor wilc_parse_assoc_resp_info() function by removing the use of
get_asoc_status() API. For parsing assoc response use the struct and
avoided the use of offset macros to extract the ies information.
Signed-off-by: Ajay Singh
---
From: Ajay Singh
Refactor get_bssid() by making use of 'ieee80211_mgmt' struct. Instead
of passing the memory offset now using structure element to fetch the
bssid information.
Returning the pointer to bssid from get_bssid() instead of filing the
input argument.
Signed-off-by: Ajay Singh
---
From: Ajay Singh
This series mainly contains the changes to make use of cfg80211 and
framework provided API's instead of having own implementation.
After refactoring of coreconfigurator functions, most of the redundant code
is removed, hence deleted the extra file.
Ajay Singh (8):
staging:
From: Ajay Singh
Refactor wilc_parse_network_info() by making use of cfg80211.h provided
API.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/coreconfigurator.c | 90 ++---
1 file changed, 55 insertions(+), 35 deletions(-)
diff --git
From: Ajay Singh
Remove the coreconfigurator header file, as its source file is deleted
after code refactor. Moved the required structure and prototypes to
hostinterface header.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/coreconfigurator.h | 70 -
From: Ajay Singh
After use of framework API's most of the redundant functions are removed
in coreconfigurator.c file. Now moved left over function to
host_interface file and deleted the coreconfigurator.c file.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/Makefile | 3 +-
From: Ajay Singh
After refactoring of wilc_parse_network_info(), some of the functions and
macro are not required, so removed the unused code.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/coreconfigurator.c | 157
From: Ajay Singh
Use shorter name for 'network_info' variable to avoid line over 80 chars
issue.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/coreconfigurator.c | 53 ++---
1 file changed, 26 insertions(+), 27 deletions(-)
diff --git
From: Ajay Singh
Cleanup patch to remove the use of unnecessary 'MAX_STRING_LEN' macro.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/coreconfigurator.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/wilc1000/coreconfigurator.h
Hi Joe,
On 11/5/2018 4:27 PM, Joe Perches wrote:
> On Thu, 2018-11-01 at 16:45 +, ajay.kat...@microchip.com wrote:
>> From: Ajay Singh
>>
>> Use shorter name for 'network_info' variable to avoid line over 80 chars
>> issue.
>
> I suppose this is OK, though perhaps unnecessary.
>
> As well,
From: Ajay Singh
For better namespace added 'WILC_' prefix for driver specific constants.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/host_interface.c | 162 +++---
drivers/staging/wilc1000/host_interface.h | 59
From: Ajay Singh
Cleanup patch to remove the unused macros and struct members in
host_interface.h header file.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/host_interface.h | 11 ---
1 file changed, 11 deletions(-)
diff --git a/drivers/staging/wilc1000/host_interface.h
From: Ajay Singh
Moved sdio_cmd52 & sdio_cmd53 struct from wilc_wlan_if.h, as its used in
wilc_sdio.cfile.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/wilc_sdio.c| 19 +++
drivers/staging/wilc1000/wilc_wlan_if.h | 19 ---
2 files changed, 19
From: Ajay Singh
Rename the macros defined in wilc_wlan_if.h header to have clear
namespace. As convention used 'WILC_FW_' prefix for constants defined for
firmware and 'WILC_' prefix for driver constants.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/host_interface.c | 6
From: Ajay Singh
Make use of ieee80211.h provided macros and removed the extra macro
defined for the same purpose.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/host_interface.c | 4 ++--
drivers/staging/wilc1000/host_interface.h | 3 ---
From: Ajay Singh
Rename 'tsf_hi' element in network_info struct as it's not used to store
only the higher 32-bit value but the complete 64-bit tsf value.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/host_interface.c | 8
drivers/staging/wilc1000/host_interface.h
From: Ajay Singh
Rename the firmware related macro by prefix with 'WILC_FW_' prefix for
a better namespace. Also, move them to wilc_wlan_if.h file along with other
FW related macros.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/host_interface.c | 4 ++--
From: Ajay Singh
Make use of 'ENOBUFS' instead of WILC_TX_ERR_NO_BUF macro. The value of
WILC_TX_ERR_NO_BUF is -2, which is confusing with ENOENT error code.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/linux_wlan.c | 2 +-
drivers/staging/wilc1000/wilc_wlan.c| 2 +-
From: Ajay Singh
Clubbed mac status constants inside the enum constant and also added
'WILC_' prefix to have better namespace.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/host_interface.c | 15 ---
drivers/staging/wilc1000/linux_wlan.c | 4 ++--
From: Ajay Singh
Restructure the code to have a proper namespace for macro defined to
handle the security types. Move them as part of wilc_wlan_if.h header as
along with other macro defined for firmware.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/linux_wlan.c | 2 +-
From: Ajay Singh
Move 'current_tx_rate' enum to wilc_wlan_if.h, to have it along with the
other FW related to constants. Also added prefix to have a better
namespace.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/host_interface.h | 16
From: Ajay Singh
Make use of WLAN_PMKID_LEN macro provided by ieee80211.h header instead
of PMKID_LEN.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/host_interface.c | 4 ++--
drivers/staging/wilc1000/host_interface.h | 3 +--
From: Ajay Singh
This patch series contains changes to address the review feedback
comments [1]. It mainly contains the changes to have clear names for
the constants. Most of the constants names are taken care, few are left
unchanged in hope with another cleanup those macros might be deleted.
From: Ajay Singh
We would like to update the maintainer email id's for wilc1000 driver.
Signed-off-by: Aditya Shankar
Signed-off-by: Ganesh Krishna
Signed-off-by: Adham Abozaeid
Signed-off-by: Ajay Singh
---
Changes in v2:
- added sob of current wilc1000 maintainers
---
MAINTAINERS
Hi Greg,
On 11/5/2018 7:46 PM, Greg KH wrote:
> On Tue, Oct 30, 2018 at 05:53:40AM +, ajay.kat...@microchip.com wrote:
>> From: Ajay Singh
>>
>> We would like to update the maintainer email id's for wilc1000 driver.
>>
>> Signed-off-by: Ajay Singh
>> Signed-off-by: Adham Abozaeid
> It
On 11/5/2018 9:27 PM, Joe Perches wrote:
> On Mon, 2018-11-05 at 12:18 +, ajay.kat...@microchip.com wrote:
>> Hi Joe,
>>
>> On 11/5/2018 4:27 PM, Joe Perches wrote:
>>> On Thu, 2018-11-01 at 16:45 +, ajay.kat...@microchip.com wrote:
From: Ajay Singh
Use shorter name for
Hi Joe,
On 11/5/2018 12:47 AM, Joe Perches wrote:
> On Thu, 2018-11-01 at 16:45 +, ajay.kat...@microchip.com wrote:
>> From: Ajay Singh
>>
>> Use shorter name for 'network_info' variable to avoid line over 80 chars
>> issue.
> This seems completely unnecessary as patch 7/8 and 8/8
> removes
From: Ajay Singh
Refactor code to avoid maintaining an unnecessary buffer to keep the
information type message ('I' msg type).
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/host_interface.c | 66 ---
1 file changed, 16 insertions(+), 50 deletions(-)
diff
From: Ajay Singh
Modified packing order for join param as expected by firmware.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/host_interface.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/staging/wilc1000/host_interface.c
From: Ajay Singh
Make use of get_unaligned_le16/le32 framework api's to pack data.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/host_interface.c | 15 +++
drivers/staging/wilc1000/wilc_wlan_cfg.c | 27 +--
2 files changed, 16 insertions(+), 26
From: Ajay Singh
Use single structure to store the connect request and response
information. It helped in avoiding unnecessary buffer allocation to
handle request and response flow.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/host_interface.c | 217 ++
From: Ajay Singh
Use cfg80211_inform_bss_frame() api instead of cfg80211_inform_bss() to
inform cfg80211 about the BSS frame, to avoid unnecessary parsing of
frame in driver.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/host_interface.c | 144 +-
From: Ajay Singh
Remove scan shadow buffer, which is used to store a copy of scan
results. Instead, use cfg80211 provided API's to retrieve required
info. Remove the helper functions which are operating on shadow buffer,
as it's not require now.
Signed-off-by: Ajay Singh
---
From: Ajay Singh
Remove typedef for function pointers.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/host_interface.c | 13 +++--
drivers/staging/wilc1000/host_interface.h | 24 ++--
drivers/staging/wilc1000/wilc_wlan.c | 10 ++
From: Ajay Singh
Rename hidden_network related data structure to have more appropriate
names, as it's used to keep search network SSID details.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/host_interface.c | 40 +++
From: Ajay Singh
Refactor code to use struct to construct the join parameters. Avoid use
of extra buffer before sending to FW instead directly pass the struct
pointer.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/host_interface.c | 404 --
From: Ajay Singh
Remove 'disconnect_info' struct use because its passed values are not
required in cfg_connect_result().
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/host_interface.c | 24 +--
drivers/staging/wilc1000/host_interface.h | 9
From: Ajay Singh
This series contains changes to address few of the review comments[1].
It mainly has the modification to remove the use of scan shadow
buffer, make use of kernel provided API, avoid typedef's and few
changes to simplify the logic.
[1].
From: Ajay Singh
Refactor handle_set_mcast_filter() by making use of put_unaligned32() to
pack the data instead of byte operation.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/host_interface.c | 37 +--
drivers/staging/wilc1000/host_interface.h | 2 +-
From: Ajay Singh
Refactor code by making use of eth_zero_addr() to clear the mac address
value in wilc_wlan_set_bssid().
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/linux_wlan.c | 6 +-
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 16 +---
2
From: Ajay Singh
Make use of 'struct' to pack cfg header in wilc_wlan_cfg_commit()
instead of byte by byte filling.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/wilc_wfi_netdevice.h | 2 +-
drivers/staging/wilc1000/wilc_wlan.c | 25 ++---
From: Ajay Singh
Added NULL check before accessing 'hidden_net' pointer inside
wilc_scan() to fix the issue found by static code checker.
Fixes: 8f1a0ac1eba7 ("staging: wilc1000: handle scan operation callback from
cfg80211 context")
Reported-by: Dan Carpenter
Signed-off-by: Ajay Singh
---
From: Ajay Singh
Refactor the code to handle delete beacon cfg operation from cfg80211
context.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/host_interface.c | 39 ---
1 file changed, 10 insertions(+), 29 deletions(-)
diff --git
From: Ajay Singh
Refactor the code to handle delete/delete_all station operation callback
from cfg80211 context.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/host_interface.c | 147 +++---
1 file changed, 33 insertions(+), 114 deletions(-)
diff --git
From: Ajay Singh
Refactor add/change beacon cfg80211 operation callback to handle from
cfg context. Also avoided extra copy of information by packing directly
in firmware expected format.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/host_interface.c | 128
From: Ajay Singh
Refactor the code to handle the power management cfg operation from the
caller context.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/host_interface.c | 56 +++
1 file changed, 13 insertions(+), 43 deletions(-)
diff --git
From: Ajay Singh
Change the return type from u32 to void for wilc_hif_pack_sta_param() as
its value is not used. Also remove the use of extra pointer as it's not
required now.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/host_interface.c | 14 --
1 file changed, 4
From: Ajay Singh
Avoid the use of internal work queue to defer the handling of tx power
related cfg operations callback. Now issuing the wid command to firmware
directly from the caller context.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/host_interface.c | 85
From: Ajay Singh
This patch series mainly contains the change to handle the cfg80211
operation from its context. Now the WID commands are sent to firmware
directly from the caller context.
Also added few more patches to address the review comment received
earlier in series[1].
[1].
From: Ajay Singh
Avoid handling of WID_CURRENT_CHANNEL wid command in deferred approach.
Instead of posting the wid to work queue now handle directly from the
caller context. Use structure to fill in the firmware specific format.
Signed-off-by: Ajay Singh
---
From: Ajay Singh
Refactor add/delete key operation to handle directly from cfg80211
context. Also, avoid an extra copy of the information in hif layer and
directly fill the buffer in firmware format.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/host_interface.c | 691
On 1/7/2019 8:13 PM, Július Milan wrote:
> Fixes the following sparse warnings:
>
> drivers/staging/wilc1000/host_interface.c:2360:30: warning:
> incorrect type in assignment (different base types)
> expected restricted __le32 [addressable] [assigned] [usertype] frame_type
> got
Hi Julius,
On 1/6/2019 12:48 PM, Július Milan wrote:
>> Before you send V3, are you sure this is the correct fix? As "frame_type" is
>> input as u16, it seems to me that the frame_type member of struct
>> wilc_reg_frame
>> should be __le16, not __le32.
>
> Yes, I am confident about it.
> The
From: Ajay Singh
Remove unnecessary 'if' check in wilc_mac_close() as those conditions
will not happen.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/linux_wlan.c | 22 +-
1 file changed, 1 insertion(+), 21 deletions(-)
diff --git
From: Ajay Singh
Refactor code to avoid the use of static variables to configure the
'wiphy' structure. Now move static variables as part of 'priv' data so
it helped to maintain this information per interface.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c |
From: Ajay Singh
Use mutex lock to protect the issuing of wid cmd to the firmware.
Currently the wid commands are synchronized by use of hif_workqueue work
queue.
Now, these changes are required to synchronize the access to wid
command, so the commands can be issued directly from cfg80211
From: Ajay Singh
Refactor the code to avoid handling of add/edit stations using work
queue and now set the wid value from caller context.
Avoid making an extra copy of buffer and directly copy the data in
firmware expected format.
Signed-off-by: Ajay Singh
---
From: Ajay Singh
Avoid handling of WID_CURRENT_CHANNEL wid command in deferred approach.
Instead of posting the wid to workqueue now handle directly from the
caller context.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/host_interface.c | 46 ++-
1 file
From: Ajay Singh
Use is_zero_ether_addr() API to check if mac address value is zero.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/host_interface.c | 3 +--
drivers/staging/wilc1000/linux_wlan.c | 3 +--
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git
From: Ajay Singh
Make use of put_unaligned_le32() function to pack the wid command buffer
for firmware.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/host_interface.c | 10 ++
drivers/staging/wilc1000/host_interface.h | 1 -
2 files changed, 2 insertions(+), 9 deletions(-)
From: Ajay Singh
Avoid handling of WID_MAC_ADDR wid command in deferred approach. Instead
of posting the wid to workqueue now handle directly from the caller
context.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/host_interface.c | 43 ++-
From: Ajay Singh
Refactor the connect related cfg callback to be called from cfg80211
context. No need to post connect command internally in case scan is in
progress instead simply return the error status in connect ops callback.
Signed-off-by: Ajay Singh
---
From: Ajay Singh
Use the correct reference to remain_ch variable in scan complete.
Passing 'msg->body.remain_on_ch' to handle_remain_on_chan is not
correct. So used the correct reference used to store roc related
information during the scan.
Signed-off-by: Ajay Singh
---
From: Ajay Singh
After code refactor some of the macro and variables are not required any
more, so deleted the unused code.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/host_interface.c | 31 ---
drivers/staging/wilc1000/host_interface.h | 27
From: Ajay Singh
Refactor wilc_remain_on_channel() to handle remain_on_channel callback
from cfg80211 context.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/host_interface.c | 36 ++-
1 file changed, 11 insertions(+), 25 deletions(-)
diff --git
From: Ajay Singh
Refactor code to handle the get_station() callback from cfg80211
context. Provided different API's to fetch the station statistics
information in sync or async call. From cfg80211 get_station() ops
callback calls the sync version of API.
Signed-off-by: Ajay Singh
---
From: Ajay Singh
Avoid handling of inactive time related wid command in deferred manner.
Instead of posting the wid to workqueue now handle directly from the
caller context.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/host_interface.c | 91 ---
1 file
From: Ajay Singh
Refactor code to handle dump_station() callback from cfg80211 context.
Instead of deferring issue of wid command now send it directly from cfg
context. Also making use of wilc_get_rssi() error status in case there
is a failure to post the wid command to the firmware.
From: Ajay Singh
Avoid handling of mgmt_frame_register operation callback in a deferred
manner. Now set the wid command to firmware directly from caller
context.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/host_interface.c | 70 ++-
From: Ajay Singh
Avoid handling of WID_SET_DRV_HANDLER wid command in deferred approach.
Instead of posting the wid to work queue now handle directly from the
caller context. Remove 'is_sync' parameter from the API as it's not
required anymore.
Signed-off-by: Ajay Singh
---
From: Ajay Singh
Avoid handling configuration params wid command in deferred approach.
Instead of posting to workqueue now handle directly from the caller
context. Reduce the size of wid array from 32 to 4 as maximum only 4 wid
used at a time.
Signed-off-by: Ajay Singh
---
From: Ajay Singh
Refactor disconnect operation callback to handle from the cfg80211
context. The reason code is not required to pass as parameter to the
function, so remove it.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/host_interface.c | 39 +++
From: Ajay Singh
Refactor code to handle scan operation callback from cfg80211 context.
No need to maintain 'scan_attr' struct as the wid command is directly
sent to firmware from cfg80211 context.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/host_interface.c | 143
From: Ajay Singh
Refactor the code to avoid the use of an extra buffer to store the
connection related parameter. No need to call cfg80211_disconnected in
case of failure to send the wid command to firmware, an error status is
directly returned in cfg80211 connect callback.
Signed-off-by: Ajay
On 12/19/2018 10:00 PM, Colin King wrote:
> From: Colin Ian King
>
> Currently the cmd.read_write setting is not initialized so it contains
> garbage from the stack. Fix this by setting it to 0 to indicate a
> read is required.
>
> Detected by CoverityScan, CID#1357925 ("Uninitialized
Thanks.
On 2/26/2019 12:55 PM, Bo YU wrote:
> Fix sparse warning:
>
> drivers/staging/wilc1000/host_interface.c:450:30: warning: incorrect type in
> assignment (different base types)
> drivers/staging/wilc1000/host_interface.c:450:30:expected restricted
> __le16 [usertype] beacon_period
>
On 2/26/2019 8:58 AM, Bo YU wrote:
> The patch fixes following sparse warning:
>
> drivers/staging/wilc1000/host_interface.c:450:30: warning: incorrect type in
> assignment (different base types)
> drivers/staging/wilc1000/host_interface.c:450:30:expected restricted
> __le16 [usertype]
On 2/7/2019 6:21 PM, Claudiu Beznea - M18063 wrote:
>
>
> On 07.02.2019 13:29, ajay.kat...@microchip.com wrote:
>> From: Ajay Singh
>>
>> Move data structure and function prototype from 'wilc_wlan_if.h file.
>> Now, this file contains constant specific to the firmware.
>>
>> Signed-off-by: Ajay
Hi Dan,
On 2/7/2019 1:42 PM, Dan Carpenter wrote:
> This patch was very confusing to review...
Apologies for the confusion.
> From a process perspective, you really should fold patches 1 and 2
> together. Otherwise we're re-introducing a bug.
Patch 1 and Patch 2 both are required if commit
From: Ajay Singh
This series contains the following changes:
- fix to set 'vif_num' value correctly.
- use 'wilc_' prefix for variables and function names.
- avoid use of unnecessary 'linux_' prefix from file names.
Changes since v1:
- merged patch 1 & 2 and added modification as
From: Ajay Singh
Cleanup patch to avoid function forward declaration by reordering the
function.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/wilc_sdio.c | 91 +---
1 file changed, 43 insertions(+), 48 deletions(-)
diff --git
From: Ajay Singh
Cleanup patch to rename data structure and function name to have 'wilc_'
prefix.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/host_interface.c | 54 +++
drivers/staging/wilc1000/host_interface.h | 12 ++---
From: Ajay Singh
Rename linux_wlan.c and linux_mon.c to wilc_netdev.c and wilc_mon.c to
include 'wilc_' prefix.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/Makefile| 2 +-
drivers/staging/wilc1000/{linux_mon.c => wilc_mon.c} | 0
From: Ajay Singh
Rename wilc_frmw_to_linux() to wilc_frmw_to_host() to be remove the _linux
suffix.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/linux_wlan.c | 3 ++-
drivers/staging/wilc1000/wilc_wfi_netdevice.h | 2 +-
drivers/staging/wilc1000/wilc_wlan.c | 5
From: Ajay Singh
Remove 'linux_' prefix and replace it with 'wilc_' namespace.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/linux_wlan.c | 17 -
drivers/staging/wilc1000/wilc_sdio.c | 10 +-
2 files changed, 13 insertions(+), 14 deletions(-)
diff --git
From: Ajay Singh
Cleanup patch to have proper follow clear namespace in wilc_sdio.c file.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/wilc_sdio.c | 92 ++--
1 file changed, 46 insertions(+), 46 deletions(-)
diff --git
From: Ajay Singh
Move data structure and function prototype from 'wilc_wlan_if.h file.
Now, this file contains constant specific to the firmware.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/host_interface.c | 1 +
drivers/staging/wilc1000/host_interface.h | 11 ++
From: Ajay Singh
Set correct value in '->vif_num' for the total number of interfaces and
set '->idx' value using 'i'.
Fixes: 735bb39ca3be ("staging: wilc1000: simplify vif[i]->ndev accesses")
Fixes: 0e490657c721 ("staging: wilc1000: Fix problem with wrong vif index")
Cc:
Suggested-by: Dan
From: Ajay Singh
Rename wilc_frmw_to_linux() to wilc_frmw_to_host() to be remove the _linux
suffix.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/linux_wlan.c | 3 ++-
drivers/staging/wilc1000/wilc_wfi_netdevice.h | 2 +-
drivers/staging/wilc1000/wilc_wlan.c | 5
From: Ajay Singh
Cleanup patch to have proper follow clear namespace in wilc_sdio.c file.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/wilc_sdio.c | 92 ++--
1 file changed, 46 insertions(+), 46 deletions(-)
diff --git
From: Ajay Singh
Rename linux_wlan.c and linux_mon.c to wilc_netdev.c and wilc_mon.c to
include 'wilc_' prefix.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/Makefile| 2 +-
drivers/staging/wilc1000/{linux_mon.c => wilc_mon.c} | 0
From: Ajay Singh
Remove 'linux_' prefix and replace it with 'wilc_' namespace.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/linux_wlan.c | 17 -
drivers/staging/wilc1000/wilc_sdio.c | 10 +-
2 files changed, 13 insertions(+), 14 deletions(-)
diff --git
From: Ajay Singh
This series contains the following changes:
- fix to set 'vif_num' value correctly. The previous Fixes patch
for vif count had not fixed the issue completely, so reverted it
and added a new patch to fix the issue.
- use 'wilc_' prefix for variables and function names.
-
From: Ajay Singh
Cleanup patch to rename data structure and function name to have 'wilc_'
prefix.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/host_interface.c | 54 +++
drivers/staging/wilc1000/host_interface.h | 12 ++---
From: Ajay Singh
Set correct interface count value in '->vif_num'.
'vif_num' was incorrectly set one less than total number of interfaces
because 'i' is used to set its value, which starts from 0.
Fixes: 735bb39ca3be ("staging: wilc1000: simplify vif[i]->ndev accesses")
Cc: # v4.10
From: Ajay Singh
Cleanup patch to avoid function forward declaration by reordering the
function.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/wilc_sdio.c | 91 +---
1 file changed, 43 insertions(+), 48 deletions(-)
diff --git
From: Ajay Singh
This patch reverts 0e490657c721 ("staging: wilc1000: Fix problem with
wrong vif index") commit.
The issue was not completely fixed with the above commit.
After 'for' loop completion, '->idx' value is correct but '->vif_num'
still contains incorrect interface count.
Fixes:
From: Ajay Singh
Move data structure and function prototype from 'wilc_wlan_if.h file.
Now, this file contains constant specific to the firmware.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/host_interface.c | 1 +
drivers/staging/wilc1000/host_interface.h | 11 ++
From: Ajay Singh
The value of 'vif_num'(interface count) starts with 0, so modified the
loop conditions to execute for all interface.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/host_interface.c | 2 +-
drivers/staging/wilc1000/linux_wlan.c | 8
2 files changed, 5
1 - 100 of 311 matches
Mail list logo