Re: [PATCH 2/2] move imx-hdmi to bridge/dw-hdmi

2014-11-04 Thread Andy Yan
Hi ZubairLK: On 2014年11月04日 21:50, Zubair Lutfullah Kakakhel wrote: Hi, On 04/11/14 13:39, Andy Yan wrote: From: Andy yan the original imx hdmi driver is under staging/imx-drm, which depends on imx-drm, so move the imx hdmi drvier out to drm/bridge and rename imx-hdmi to dw-hdmi Change-Id

Re: [PATCH 0/2] make imx hdmi publicly used by dw hdmi compatible platform

2014-11-04 Thread Andy Yan
On 2014年11月04日 22:29, Russell King - ARM Linux wrote: On Tue, Nov 04, 2014 at 09:33:10PM +0800, Andy Yan wrote: From: Andy yan We found freescale imx6 and rockchip rk3288 and Ingenic JZ4780 (Xburst/MIPS) use the interface compatible Designware HDMI IP, but they also have some lightly

[PATCH 1/2] imx-drm: imx-hdmi: split imx soc specific code from imx-hdmi

2014-11-05 Thread Andy Yan
, but rk3288 does), clk useage,and the crtc mux configuration is also platform specific. To reuse the imx hdmi driver, split the platform specific code out to dw_hdmi-imx.c. Signed-off-by: Andy Yan --- drivers/staging/imx-drm/Makefile | 2 +- drivers/staging/imx-drm/dw_hdmi-imx.c

[PATCH V2 0/2] make imx hdmi publicly used by dw hdmi compatible platform

2014-11-05 Thread Andy Yan
l add rockchip platform specific code dw_hdmi-rockchip.c later, this is depend on drm-rockchip. Changes in V2: - use git format-patch -M to generate these patch - remove change-id - remove from Andy Yan (2): imx-drm: imx-hdmi: split imx soc specific code from imx-hdmi move imx-hdmi to bridge/dw

[PATCH V2 2/2] move imx-hdmi to bridge/dw-hdmi

2014-11-05 Thread Andy Yan
the original imx hdmi driver is under staging/imx-drm, which depends on imx-drm, so move the imx hdmi drvier out to drm/bridge and rename imx-hdmi to dw-hdmi Signed-off-by: Andy Yan --- drivers/gpu/drm/bridge/Kconfig | 5 + drivers/gpu/drm/bridge/Makefile

[PATCH V2 1/2] imx-drm: imx-hdmi: split imx soc specific code from imx-hdmi

2014-11-05 Thread Andy Yan
, but rk3288 does), clk useage,and the crtc mux configuration is also platform specific. To reuse the imx hdmi driver, split the platform specific code out to dw_hdmi-imx.c. Signed-off-by: Andy Yan --- drivers/staging/imx-drm/Makefile | 2 +- drivers/staging/imx-drm/dw_hdmi-imx.c

[PATCH V3 0/4] dw-hdmi: make imx hdmi publicly used by dw hdmi compatible platform

2014-11-06 Thread Andy Yan
ormat-patch -M to generate these patch - remove change-id - remove from Andy Yan (3): imx-drm: imx-hdmi: split imx soc specific code from imx-hdmi dw-hdmi: move imx-hdmi to bridge/dw-hdmi dw-hdmi: add support for multi byte register width access ykk (1): dw-hdmi: convert dw-hdmi to drm_bridge

[PATCH V3 1/4] imx-drm: imx-hdmi: split imx soc specific code from imx-hdmi

2014-11-06 Thread Andy Yan
hdmi driver, split the platform specific code out to dw_hdmi-imx.c. Signed-off-by: Andy Yan --- drivers/staging/imx-drm/Makefile | 2 +- drivers/staging/imx-drm/dw_hdmi-imx.c | 214 drivers/staging/imx-drm/imx-hdmi.c| 257

[PATCH V3 2/4] dw-hdmi: move imx-hdmi to bridge/dw-hdmi

2014-11-06 Thread Andy Yan
the original imx hdmi driver is under staging/imx-drm, which depends on imx-drm, so move the imx hdmi drvier out to drm/bridge and rename imx-hdmi to dw-hdmi Signed-off-by: Andy Yan --- drivers/gpu/drm/bridge/Kconfig | 5 + drivers/gpu/drm/bridge/Makefile

[PATCH V3 3/4] dw-hdmi: add support for multi byte register width access

2014-11-06 Thread Andy Yan
On rockchip rk3288, only word(32-bit) accesses are permitted for hdmi registers. Byte width access (writeb, readb) generate an imprecise external abort. Signed-off-by: Andy Yan --- drivers/gpu/drm/bridge/dw_hdmi.c | 53 1 file changed, 48 insertions

[PATCH V3 4/4] dw-hdmi: convert dw-hdmi to drm_bridge mode

2014-11-06 Thread Andy Yan
From: ykk dw-hdmi is under drm/bridge, so it should be the bridge mode. hange off the encoder to dw_hdmi-imx.c, keep the connector & birdge in dw_hdmi.c Signed-off-by: ykk Signed-off-by: Andy Yan --- drivers/gpu/drm/bridge/dw_hdmi.c | 228 +++--- dri

Re: [PATCH V3 4/4] dw-hdmi: convert dw-hdmi to drm_bridge mode

2014-11-06 Thread Andy Yan
On 2014年11月06日 23:54, Greg Kroah-Hartman wrote: On Thu, Nov 06, 2014 at 07:26:16PM +0800, Andy Yan wrote: From: ykk We need a "real" name here, sorry. dw-hdmi is under drm/bridge, so it should be the bridge mode. hange off the encoder to dw_hdmi-imx.c, keep the connector &

Re: [PATCH 1/2] imx-drm: imx-hdmi: split imx soc specific code from imx-hdmi

2014-11-06 Thread Andy Yan
On 2014年11月05日 21:41, Philipp Zabel wrote: Hi Andy, I think separating the core from the SoC specific part is a good step into the right direction. Am Mittwoch, den 05.11.2014, 20:55 +0800 schrieb Andy Yan: imx6 and rockchip rk3288 and JZ4780 (Ingenic Xburst/MIPS) use the interface

Re: [PATCH V2 1/2] imx-drm: imx-hdmi: split imx soc specific code from imx-hdmi

2014-11-06 Thread Andy Yan
tel), byte access will causes an imprecise external abort. I have refactor the register access in PATCH V3, if you have any futher suggestion ,please tell me. Cheers, ZubairLK On 05/11/14 12:59, Andy Yan wrote: imx6 and rockchip rk3288 and JZ4780 (Ingenic Xburst/MIPS) use the interface

[PATCH V4 0/6] dw-hdmi: make imx hdmi publicly used by dw hdmi compatible platform

2014-11-07 Thread Andy Yan
dge driver Changes in V2: - use git format-patch -M to generate these patch - remove change-id - remove from Andy Yan (5): imx-drm: imx-hdmi: split imx soc specific code from imx-hdmi dw-hdmi: move imx-hdmi to bridge/dw-hdmi dw-hdmi: make checkpatch happy dw-hdmi: return defer if can

[PATCH V4 1/6] imx-drm: imx-hdmi: split imx soc specific code from imx-hdmi

2014-11-07 Thread Andy Yan
hdmi driver, split the platform specific code out to dw_hdmi-imx.c. Signed-off-by: Andy Yan --- drivers/staging/imx-drm/Makefile | 2 +- drivers/staging/imx-drm/dw_hdmi-imx.c | 214 drivers/staging/imx-drm/imx-hdmi.c| 257

[PATCH V4 2/6] dw-hdmi: move imx-hdmi to bridge/dw-hdmi

2014-11-07 Thread Andy Yan
the original imx hdmi driver is under staging/imx-drm, which depends on imx-drm, so move the imx hdmi drvier out to drm/bridge and rename imx-hdmi to dw-hdmi Signed-off-by: Andy Yan --- drivers/gpu/drm/bridge/Kconfig | 5 + drivers/gpu/drm/bridge/Makefile

[PATCH V4 3/6] dw-hdmi: make checkpatch happy

2014-11-07 Thread Andy Yan
.] + else { [...] Signed-off-by: Andy Yan --- drivers/gpu/drm/bridge/dw_hdmi.c | 99 1 file changed, 49 insertions(+), 50 deletions(-) diff --git a/drivers/gpu/drm/bridge/dw_hdmi.c b/drivers/gpu/drm/bridge/dw_hdmi.c index e561286..693a379 100644 --- a/drivers

[PATCH V4 4/6] dw-hdmi: return defer if can't get ddc i2c adapter

2014-11-07 Thread Andy Yan
drm driver may probe before the i2c bus, so the driver should defer probing untill it is avaliable Signed-off-by: Andy Yan --- drivers/gpu/drm/bridge/dw_hdmi.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/dw_hdmi.c b/drivers/gpu/drm/bridge

[PATCH V4 5/6] dw-hdmi: add support for multi byte register width access

2014-11-07 Thread Andy Yan
On rockchip rk3288, only word(32-bit) accesses are permitted for hdmi registers. Byte width access (writeb, readb) generates an imprecise external abort. Signed-off-by: Andy Yan --- drivers/gpu/drm/bridge/dw_hdmi.c | 49 +--- 1 file changed, 46 insertions

[PATCH V4 6/6] dw-hdmi: convert dw-hdmi to drm_bridge mode

2014-11-07 Thread Andy Yan
From: Yakir Yang dw-hdmi is under drm/bridge, so it should be the bridge mode. hange off the encoder to dw_hdmi-imx.c, keep the connector & birdge in dw_hdmi.c Signed-off-by: Andy Yan Signed-off-by: Yakir Yang --- drivers/gpu/drm/bridge/dw_hdmi.c |

Re: [PATCH V4 5/6] dw-hdmi: add support for multi byte register width access

2014-11-07 Thread Andy Yan
On 2014年11月07日 19:45, Lucas Stach wrote: Am Freitag, den 07.11.2014, 19:35 +0800 schrieb Andy Yan: On rockchip rk3288, only word(32-bit) accesses are permitted for hdmi registers. Byte width access (writeb, readb) generates an imprecise external abort. Signed-off-by: Andy Yan --- drivers

[PATCH V5 0/7]dw-hdmi: convert imx hdmi to bridge/dw-hdmi

2014-11-07 Thread Andy Yan
and split it to one indepent patch - convert it to a drm_bridge driver Changes in V2: - use git format-patch -M to generate these patch - remove change-id - remove from Andy Yan (6): imx-drm: imx-hdmi: split imx soc specific code from imx-hdmi dw-hdmi: move imx-hdmi to bridge/dw-hdmi dw-

[PATCH V5 1/7] imx-drm: imx-hdmi: split imx soc specific code from imx-hdmi

2014-11-07 Thread Andy Yan
hdmi driver, split the platform specific code out to dw_hdmi-imx.c. Signed-off-by: Andy Yan --- drivers/staging/imx-drm/Makefile | 2 +- drivers/staging/imx-drm/dw_hdmi-imx.c | 214 drivers/staging/imx-drm/imx-hdmi.c| 257

[PATCH V5 2/7] dw-hdmi: move imx-hdmi to bridge/dw-hdmi

2014-11-07 Thread Andy Yan
the original imx hdmi driver is under staging/imx-drm, which depends on imx-drm, so move the imx hdmi drvier out to drm/bridge and rename imx-hdmi to dw-hdmi Signed-off-by: Andy Yan --- drivers/gpu/drm/bridge/Kconfig | 5 + drivers/gpu/drm/bridge/Makefile

[PATCH V5 3/7] dw-hdmi: make checkpatch happy

2014-11-07 Thread Andy Yan
.] + else { [...] Signed-off-by: Andy Yan --- drivers/gpu/drm/bridge/dw_hdmi.c | 97 1 file changed, 48 insertions(+), 49 deletions(-) diff --git a/drivers/gpu/drm/bridge/dw_hdmi.c b/drivers/gpu/drm/bridge/dw_hdmi.c index 527014b..df52921 100644 --- a/drivers

[PATCH V5 4/7] dw-hdmi: return defer if can't get ddc i2c adapter

2014-11-07 Thread Andy Yan
drm driver may probe before the i2c bus, so the driver should defer probing untill it is avaliable Signed-off-by: Andy Yan --- drivers/gpu/drm/bridge/dw_hdmi.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/dw_hdmi.c b/drivers/gpu/drm/bridge

[PATCH V5 5/7] dw-hdmi: add support for multi byte register width access

2014-11-07 Thread Andy Yan
On rockchip rk3288, only word(32-bit) accesses are permitted for hdmi registers. Byte width accesses (writeb, readb) generate an imprecise external abort. Signed-off-by: Andy Yan --- drivers/gpu/drm/bridge/dw_hdmi.c | 57 ++-- 1 file changed, 55 insertions

[PATCH V5 6/7] dw-hdmi: convert dw-hdmi to drm_bridge mode

2014-11-07 Thread Andy Yan
From: Yakir Yang dw-hdmi is under drm/bridge, so it should be the bridge mode. hange off the encoder to dw_hdmi-imx.c, keep the connector & birdge in dw_hdmi.c Signed-off-by: Andy Yan Signed-off-by: Yakir Yang --- drivers/gpu/drm/bridge/dw_hdmi.c |

[PATCH V5 7/7] dt-bindings: add document for dw-hdmi

2014-11-07 Thread Andy Yan
Signed-off-by: Andy Yan --- .../devicetree/bindings/drm/bridge/dw-hdmi.txt | 38 ++ 1 file changed, 38 insertions(+) create mode 100644 Documentation/devicetree/bindings/drm/bridge/dw-hdmi.txt diff --git a/Documentation/devicetree/bindings/drm/bridge/dw-hdmi.txt b

Re: [PATCH V5 3/7] dw-hdmi: make checkpatch happy

2014-11-10 Thread Andy Yan
checkpatch error and then fix it in a later patch. Regards ZubairLK i use checkpatch with --subjective On 08/11/14 05:29, Andy Yan wrote: CHECK: Alignment should match open parenthesis + if ((hdmi->vic == 10) || (hdmi->vic == 11) || + (hdmi->vic == 12) || (hdmi-&

Re: [PATCH V5 3/7] dw-hdmi: make checkpatch happy

2014-11-10 Thread Andy Yan
checkpatch error and then fix it in a later patch. Regards ZubairLK I use checkpatch with --subjective On 08/11/14 05:29, Andy Yan wrote: CHECK: Alignment should match open parenthesis + if ((hdmi->vic == 10) || (hdmi->vic == 11) || + (hdmi->vic == 12) || (hdmi-&

Re: [PATCH V5 7/7] dt-bindings: add document for dw-hdmi

2014-11-10 Thread Andy Yan
On 2014年11月10日 17:53, Zubair Lutfullah Kakakhel wrote: On 10/11/14 09:44, Andy Yan wrote: Hi ZubairLK On 2014年11月10日 17:17, Zubair Lutfullah Kakakhel wrote: Nice work. This patch should move the binding from Documentation/devicetree/bindings/staging/imx-drm/hdmi.txt to the location instead

Re: [PATCH V5 7/7] dt-bindings: add document for dw-hdmi

2014-11-10 Thread Andy Yan
and described in platform specific dt binds like /imx-drm/hdmi.txt On 08/11/14 05:32, Andy Yan wrote: Signed-off-by: Andy Yan --- .../devicetree/bindings/drm/bridge/dw-hdmi.txt | 38 ++ 1 file changed, 38 insertions(+) create mode 100644 Documentation/devicetree

[PATCH v6 2/7] staging: imx-drm: imx-hdmi: return defer if can't get ddc i2c adapter

2014-11-10 Thread Andy Yan
drm driver may probe before the i2c bus, so the driver should defer probing until it is available Signed-off-by: Andy Yan --- Changes in v6: None Changes in v5: None Changes in v4: - defer probe ddc i2c adapter Changes in v3: None Changes in v2: None drivers/staging/imx-drm/imx-hdmi.c | 5

[PATCH v6 3/7] staging: imx-drm: imx-hdmi: split imx soc specific code from imx-hdmi

2014-11-10 Thread Andy Yan
hdmi driver, split the platform specific code out to dw_hdmi-imx.c. Signed-off-by: Andy Yan --- Changes in v6: None Changes in v5: None Changes in v4: None Changes in v3: None Changes in v2: None drivers/staging/imx-drm/Makefile | 2 +- drivers/staging/imx-drm/dw_hdmi-imx.c | 214

[PATCH v6 1/7] staging: imx-drm: imx-hdmi: make checkpatch happy

2014-11-10 Thread Andy Yan
.] + else { [...] Signed-off-by: Andy Yan --- Changes in v5: None Changes in v4: - fix checkpatch CHECK Changes in v3: None Changes in v2: None drivers/staging/imx-drm/imx-hdmi.c | 97 +++--- 1 file changed, 48 insertions(+), 49 deletions(-) diff --git a/drivers/stag

[PATCH v6 0/7] dw-hdmi: convert imx hdmi to bridge/dw-hdmi

2014-11-10 Thread Andy Yan
width Changes in v4: - fix checkpatch CHECK - defer probe ddc i2c adapter Changes in v3: - split multi register access to one indepent patch Changes in v2: - use git format -M to generate these patch Andy Yan (6): staging: imx-drm: imx-hdmi: make checkpatch happy staging: imx-drm: imx-hdmi: return

[PATCH v6 4/7] staging: imx-drm: imx-hdmi: move imx-hdmi to bridge/dw-hdmi

2014-11-10 Thread Andy Yan
the original imx hdmi driver is under staging/imx-drm, which depends on imx-drm, so move the imx hdmi drvier out to drm/bridge and rename imx-hdmi to dw-hdmi Signed-off-by: Andy Yan --- Changes in v6: None Changes in v5: None Changes in v4: None Changes in v3: None Changes in v2: - use git

[PATCH v6 6/7] drm: bridge/dw-hdmi: convert dw-hdmi to drm_bridge mode

2014-11-10 Thread Andy Yan
From: Yakir Yang handle encoder in dw_hdmi-imx.c, keep the connector & birdge in dw_hdmi.c Signed-off-by: Andy Yan Signed-off-by: Yakir Yang --- Changes in v6: - move some modification from patch#5 Changes in v5: None Changes in v4: None Changes in v3: None Changes in v2: None dri

Re: [PATCH V5 1/7] imx-drm: imx-hdmi: split imx soc specific code from imx-hdmi

2014-11-10 Thread Andy Yan
Hi Zubair: thanks very much for your comments. On 2014年11月10日 18:51, Zubair Lutfullah Kakakhel wrote: Hi Andy, A few comments inline. On 08/11/14 05:28, Andy Yan wrote: imx6 and rockchip rk3288 and JZ4780 (Ingenic Xburst/MIPS) use the interface compatible Designware HDMI IP, but they also

[PATCH v7 0/7] dw-hdmi: convert imx hdmi to bridge/dw-hdmi

2014-11-11 Thread Andy Yan
es in v2: - use git format -M to generate these patch Andy Yan (6): staging: imx-drm: imx-hdmi: make checkpatch happy staging: imx-drm: imx-hdmi: return defer if can't get ddc i2c adapter staging: imx-drm: imx-hdmi: split imx soc specific code from imx-hdmi staging: imx-drm: imx-hdmi

[PATCH v7 1/7] staging: imx-drm: imx-hdmi: make checkpatch happy

2014-11-11 Thread Andy Yan
.] + else { [...] Signed-off-by: Andy Yan --- Changes in v7: None Changes in v6: - rearrange the patch order Changes in v5: None Changes in v4: - fix checkpatch CHECK Changes in v3: None Changes in v2: None drivers/staging/imx-drm/imx-hdmi.c | 97 +++--- 1 f

[PATCH v7 2/7] staging: imx-drm: imx-hdmi: return defer if can't get ddc i2c adapter

2014-11-11 Thread Andy Yan
drm driver may probe before the i2c bus, so the driver should defer probing until it is available Signed-off-by: Andy Yan --- Changes in v7: None Changes in v6: None Changes in v5: None Changes in v4: - defer probe ddc i2c adapter Changes in v3: None Changes in v2: None drivers/staging/imx

[PATCH v7 3/7] staging: imx-drm: imx-hdmi: split imx soc specific code from imx-hdmi

2014-11-11 Thread Andy Yan
hdmi driver, split the platform specific code out to dw_hdmi-imx.c. Signed-off-by: Andy Yan --- Changes in v7: - remove unused variables from structure dw_hdmi - remove a wrong modification - add copyrights for dw_hdmi-imx.c Changes in v6: None Changes in v5: None Changes in v4: None Changes

[PATCH v7 6/7] drm: bridge/dw-hdmi: convert dw-hdmi to drm_bridge mode

2014-11-11 Thread Andy Yan
From: Yakir Yang keep the connector & birdge in dw_hdmi.c, handle encoder in dw_hdmi-imx.c Signed-off-by: Andy Yan Signed-off-by: Yakir Yang --- Changes in v7: None Changes in v6: - move some modification from patch#5 Changes in v5: None Changes in v4: None Changes in v3: None Change

[PATCH v7 0/7] dw-hdmi: convert imx hdmi to bridge/dw-hdmi

2014-11-11 Thread Andy Yan
es in v2: - use git format -M to generate these patch Andy Yan (6): staging: imx-drm: imx-hdmi: make checkpatch happy staging: imx-drm: imx-hdmi: return defer if can't get ddc i2c adapter staging: imx-drm: imx-hdmi: split imx soc specific code from imx-hdmi staging: imx-drm: imx-hdmi

[PATCH v7 1/7] staging: imx-drm: imx-hdmi: make checkpatch happy

2014-11-11 Thread Andy Yan
.] + else { [...] Signed-off-by: Andy Yan --- Changes in v7: None Changes in v6: - rearrange the patch order Changes in v5: None Changes in v4: - fix checkpatch CHECK Changes in v3: None Changes in v2: None drivers/staging/imx-drm/imx-hdmi.c | 97 +++--- 1 f

[PATCH v7 2/7] staging: imx-drm: imx-hdmi: return defer if can't get ddc i2c adapter

2014-11-11 Thread Andy Yan
drm driver may probe before the i2c bus, so the driver should defer probing until it is available Signed-off-by: Andy Yan --- Changes in v7: None Changes in v6: None Changes in v5: None Changes in v4: - defer probe ddc i2c adapter Changes in v3: None Changes in v2: None drivers/staging/imx

[PATCH v7 3/7] staging: imx-drm: imx-hdmi: split imx soc specific code from imx-hdmi

2014-11-11 Thread Andy Yan
hdmi driver, split the platform specific code out to dw_hdmi-imx.c. Signed-off-by: Andy Yan --- Changes in v7: - remove unused variables from structure dw_hdmi - remove a wrong modification - add copyrights for dw_hdmi-imx.c Changes in v6: None Changes in v5: None Changes in v4: None Changes

[PATCH v7 4/7] staging: imx-drm: imx-hdmi: move imx-hdmi to bridge/dw-hdmi

2014-11-11 Thread Andy Yan
the original imx hdmi driver is under staging/imx-drm, which depends on imx-drm, so move the imx hdmi drvier out to drm/bridge and rename imx-hdmi to dw-hdmi Signed-off-by: Andy Yan --- Changes in v7: None Changes in v6: None Changes in v5: None Changes in v4: None Changes in v3: None Changes

[PATCH v7 5/7] drm: bridge/dw-hdmi: add support for multi byte register width access

2014-11-11 Thread Andy Yan
On rockchip rk3288, only word(32-bit) accesses are permitted for hdmi registers. Byte width accesses (writeb, readb) generate an imprecise external abort. Signed-off-by: Andy Yan --- Changes in v7: None Changes in v6: - move some modification to patch#6 - refactor register access without

[PATCH v7 6/7] drm: bridge/dw-hdmi: convert dw-hdmi to drm_bridge mode

2014-11-11 Thread Andy Yan
From: Yakir Yang keep the connector & birdge in dw_hdmi.c, handle encoder in dw_hdmi-imx.c Signed-off-by: Andy Yan Signed-off-by: Yakir Yang --- Changes in v7: None Changes in v6: - move some modification from patch#5 Changes in v5: None Changes in v4: None Changes in v3: None Change

[PATCH v7 7/7] dt-bindings: add document for dw-hdmi

2014-11-11 Thread Andy Yan
Signed-off-by: Andy Yan --- Changes in v7: None Changes in v6: None Changes in v5: None Changes in v4: None Changes in v3: None Changes in v2: None .../devicetree/bindings/drm/bridge/dw-hdmi.txt | 38 ++ 1 file changed, 38 insertions(+) create mode 100644 Documentation

Re: [PATCH v7 4/7] staging: imx-drm: imx-hdmi: move imx-hdmi to bridge/dw-hdmi

2014-11-11 Thread Andy Yan
On 2014年11月11日 22:16, Zubair Lutfullah Kakakhel wrote: Hi Andy, On 11/11/14 12:53, Andy Yan wrote: the original imx hdmi driver is under staging/imx-drm, which depends on imx-drm, so move the imx hdmi drvier out Spelling mistake. ^'driver' to drm/

Re: [PATCH v7 5/7] drm: bridge/dw-hdmi: add support for multi byte register width access

2014-11-11 Thread Andy Yan
On 2014年11月11日 22:20, Zubair Lutfullah Kakakhel wrote: Hi Andy, This patch adds the reg-io-width binding. Hence the binding patch should come before it. do you mean that I should put dts binding patch before this patch? On 11/11/14 12:53, Andy Yan wrote: On rockchip rk3288, only

Re: [PATCH v7 6/7] drm: bridge/dw-hdmi: convert dw-hdmi to drm_bridge mode

2014-11-11 Thread Andy Yan
Hi ZubairLK: On 2014年11月11日 22:36, Zubair Lutfullah Kakakhel wrote: Hi Andy, On 11/11/14 12:54, Andy Yan wrote: From: Yakir Yang keep the connector & birdge in dw_hdmi.c, handle encoder in dw_hdmi-imx.c Is there a reason for this separation? Keeping encoder in platform files? If yes,

Re: [PATCH v7 7/7] dt-bindings: add document for dw-hdmi

2014-11-11 Thread Andy Yan
On 2014年11月11日 22:40, Zubair Lutfullah Kakakhel wrote: Hi Andy, Some minor comments inline. On 11/11/14 12:54, Andy Yan wrote: Signed-off-by: Andy Yan --- Changes in v7: None Changes in v6: None Changes in v5: None Changes in v4: None Changes in v3: None Changes in v2: None

[PATCH v8 0/9] dw-hdmi: convert imx hdmi to bridge/dw_hdmi

2014-11-12 Thread Andy Yan
es in v4: - fix checkpatch CHECK - defer probe ddc i2c adapter Changes in v3: - split multi register access to one indepent patch Changes in v2: - use git format -M to generate these patch Andy Yan (8): staging: imx-drm: imx-hdmi: make checkpatch happy staging: imx-drm: imx-hdmi: return def

[PATCH v8 2/9] staging: imx-drm: imx-hdmi: return defer if can't get ddc i2c adapter

2014-11-12 Thread Andy Yan
drm driver may probe before the i2c bus, so the driver should defer probing until it is available Signed-off-by: Andy Yan --- Changes in v8: None Changes in v7: None Changes in v6: None Changes in v5: None Changes in v4: - defer probe ddc i2c adapter Changes in v3: None Changes in v2: None

[PATCH v8 1/9] staging: imx-drm: imx-hdmi: make checkpatch happy

2014-11-12 Thread Andy Yan
.] + else { [...] Signed-off-by: Andy Yan --- Changes in v8: None Changes in v7: None Changes in v6: - rearrange the patch order Changes in v5: None Changes in v4: - fix checkpatch CHECK Changes in v3: None Changes in v2: None drivers/staging/imx-drm/imx-hdmi.c | 97 +++

[PATCH v8 3/9] staging: imx-drm: imx-hdmi: split imx soc specific code from imx-hdmi

2014-11-12 Thread Andy Yan
hdmi driver, split the platform specific code out to dw_hdmi-imx.c. Signed-off-by: Andy Yan --- Changes in v8: None Changes in v7: - remove unused variables from structure dw_hdmi - remove a wrong modification - add copyrights for dw_hdmi-imx.c Changes in v6: None Changes in v5: None Changes

[PATCH v8 4/9] staging: imx-drm: imx-hdmi: move imx-hdmi to bridge/dw_hdmi

2014-11-12 Thread Andy Yan
the original imx hdmi driver is under staging/imx-drm, which depends on imx-drm, so move the imx hdmi driver out to drm/bridge and rename imx-hdmi to dw_hdmi Signed-off-by: Andy Yan --- Changes in v8: None Changes in v7: None Changes in v6: None Changes in v5: None Changes in v4: None Changes

[PATCH v8 5/9] dt-bindings: add document for dw_hdmi

2014-11-12 Thread Andy Yan
Signed-off-by: Andy Yan --- Changes in v8: - correct some spelling mistake - modify ddc-i2c-bus and interrupt description Changes in v7: None Changes in v6: None Changes in v5: None Changes in v4: None Changes in v3: None Changes in v2: None .../devicetree/bindings/drm/bridge/dw_hdmi.txt

[PATCH v8 6/9] drm: bridge/dw_hdmi: add support for multi byte register width access

2014-11-12 Thread Andy Yan
On rockchip rk3288, only word(32-bit) accesses are permitted for hdmi registers. Byte width accesses (writeb, readb) generate an imprecise external abort. Signed-off-by: Andy Yan --- Changes in v8: None Changes in v7: None Changes in v6: - move some modification to patch#6 - refactor

[PATCH v8 7/9] drm: bridge/dw_hdmi: convert dw-hdmi to drm_bridge mode

2014-11-12 Thread Andy Yan
From: Yakir Yang keep the connector & birdge in dw_hdmi.c, handle encoder in dw_hdmi-imx.c, as most of the encoder operation are platform specific such as crtc select and panel format set Signed-off-by: Andy Yan Signed-off-by: Yakir Yang --- Changes in v8: None Changes in v7: None Cha

[PATCH v8 8/9] dt-bindings: Add documentation for rockchip dw hdmi

2014-11-12 Thread Andy Yan
Signed-off-by: Andy Yan --- Changes in v8: - Add documentation for rockchip dw hdmi Changes in v7: None Changes in v6: None Changes in v5: None Changes in v4: None Changes in v3: None Changes in v2: None .../devicetree/bindings/video/dw_hdmi-rockchip.txt | 43 ++ 1 file

[PATCH v8 9/9] drm: bridge/dw_hdmi: add rockchip rk3288 support

2014-11-12 Thread Andy Yan
rk3288 hdmi is compatible with Designware hdmi this patch is depend on patch by Mark Yao Add drm driver for Rockchip Socs see https://lkml.org/lkml/2014/10/8/201 Signed-off-by: Andy Yan Signed-off-by: Yakir Yang --- Changes in v8: - add support for rockchip rk3288 hdmi Changes in v7: None

[PATCH v9 0/9] dw-hdmi: convert imx hdmi to bridge/dw_hdmi

2014-11-13 Thread Andy Yan
shift - move some modification from patch#5 Changes in v5: - refactor reg-io-width Changes in v4: - fix checkpatch CHECK - defer probe ddc i2c adapter Changes in v3: - split multi register access to one indepent patch Changes in v2: - use git format -M to generate these patch Andy Yan (8): st

[PATCH v9 1/9] staging: imx-drm: imx-hdmi: make checkpatch happy

2014-11-13 Thread Andy Yan
.] + else { [...] Signed-off-by: Andy Yan --- Changes in v9: None Changes in v8: None Changes in v7: None Changes in v6: - rearrange the patch order Changes in v5: None Changes in v4: - fix checkpatch CHECK Changes in v3: None Changes in v2: None drivers/staging/imx-drm/

[PATCH v9 2/9] staging: imx-drm: imx-hdmi: return defer if can't get ddc i2c adapter

2014-11-13 Thread Andy Yan
drm driver may probe before the i2c bus, so the driver should defer probing until it is available Signed-off-by: Andy Yan --- Changes in v9: None Changes in v8: None Changes in v7: None Changes in v6: None Changes in v5: None Changes in v4: - defer probe ddc i2c adapter Changes in v3: None

[PATCH v9 5/9] dt-bindings: add document for dw_hdmi

2014-11-13 Thread Andy Yan
Signed-off-by: Andy Yan --- Changes in v9: None Changes in v8: - correct some spelling mistake - modify ddc-i2c-bus and interrupt description Changes in v7: None Changes in v6: None Changes in v5: None Changes in v4: None Changes in v3: None Changes in v2: None .../devicetree/bindings/drm

[PATCH v9 4/9] staging: imx-drm: imx-hdmi: move imx-hdmi to bridge/dw_hdmi

2014-11-13 Thread Andy Yan
the original imx hdmi driver is under staging/imx-drm, which depends on imx-drm, so move the imx hdmi driver out to drm/bridge and rename imx-hdmi to dw_hdmi Signed-off-by: Andy Yan --- Changes in v9: None Changes in v8: None Changes in v7: None Changes in v6: None Changes in v5: None Changes

[PATCH v9 3/9] staging: imx-drm: imx-hdmi: split imx soc specific code from imx-hdmi

2014-11-13 Thread Andy Yan
hdmi driver, split the platform specific code out to dw_hdmi-imx.c. Signed-off-by: Andy Yan --- Changes in v9: None Changes in v8: None Changes in v7: - remove unused variables from structure dw_hdmi - remove a wrong modification - add copyrights for dw_hdmi-imx.c Changes in v6: None Changes

[PATCH v9 6/9] drm: bridge/dw_hdmi: add support for multi byte register width access

2014-11-13 Thread Andy Yan
On rockchip rk3288, only word(32-bit) accesses are permitted for hdmi registers. Byte width accesses (writeb, readb) generate an imprecise external abort. Signed-off-by: Andy Yan --- Changes in v9: None Changes in v8: None Changes in v7: None Changes in v6: - move some modification to patch

[PATCH v9 7/9] drm: bridge/dw_hdmi: convert dw-hdmi to drm_bridge mode

2014-11-13 Thread Andy Yan
From: Yakir Yang keep the connector & birdge in dw_hdmi.c, handle encoder in dw_hdmi-imx.c, as most of the encoder operation are platform specific such as crtc select and panel format set Signed-off-by: Andy Yan Signed-off-by: Yakir Yang --- Changes in v9: None Changes in v8: None Cha

[PATCH v9 8/9] dt-bindings: Add documentation for rockchip dw hdmi

2014-11-13 Thread Andy Yan
Signed-off-by: Andy Yan --- Changes in v9: None Changes in v8: - Add documentation for rockchip dw hdmi Changes in v7: None Changes in v6: None Changes in v5: None Changes in v4: None Changes in v3: None Changes in v2: None .../devicetree/bindings/video/dw_hdmi-rockchip.txt | 43

[PATCH v9 9/9] drm: bridge/dw_hdmi: add rockchip rk3288 support

2014-11-13 Thread Andy Yan
rk3288 hdmi is compatible with Designware hdmi this patch is depend on patch by Mark Yao Add drm driver for Rockchip Socs see https://lkml.org/lkml/2014/10/8/201 Signed-off-by: Andy Yan Signed-off-by: Yakir Yang --- Changes in v9: - move some phy configuration to platform driver Changes in

Re: [PATCH v9 9/9] drm: bridge/dw_hdmi: add rockchip rk3288 support

2014-11-13 Thread Andy Yan
Hi ZubairLK: thanks for your review. On 2014年11月13日 21:09, Zubair Lutfullah Kakakhel wrote: On 13/11/14 12:57, Andy Yan wrote: rk3288 hdmi is compatible with Designware hdmi this patch is depend on patch by Mark Yao Add drm driver for Rockchip Socs see https://lkml.org/lkml/2014/10/8/201

[PATCH v10 0/11] dw-hdmi: convert imx hdmi to bridge/dw_hdmi

2014-11-13 Thread Andy Yan
ister access to one indepent patch Changes in v2: - use git format -M to generate these patch Andy Yan (10): staging: imx-drm: imx-hdmi: make checkpatch happy staging: imx-drm: imx-hdmi: return defer if can't get ddc i2c adapter staging: imx-drm: imx-hdmi: split imx soc specific code fro

[PATCH v10 01/11] staging: imx-drm: imx-hdmi: make checkpatch happy

2014-11-13 Thread Andy Yan
.] + else { [...] Signed-off-by: Andy Yan --- Changes in v10: None Changes in v9: None Changes in v8: None Changes in v7: None Changes in v6: - rearrange the patch order Changes in v5: None Changes in v4: - fix checkpatch CHECK Changes in v3: None Changes in v2: None drivers/staging/imx-drm/

[PATCH v10 02/11] staging: imx-drm: imx-hdmi: return defer if can't get ddc i2c adapter

2014-11-13 Thread Andy Yan
drm driver may probe before the i2c bus, so the driver should defer probing until it is available Signed-off-by: Andy Yan --- Changes in v10: None Changes in v9: None Changes in v8: None Changes in v7: None Changes in v6: None Changes in v5: None Changes in v4: - defer probe ddc i2c adapter

[PATCH v10 03/11] staging: imx-drm: imx-hdmi: split imx soc specific code from imx-hdmi

2014-11-13 Thread Andy Yan
hdmi driver, split the platform specific code out to dw_hdmi-imx.c. Signed-off-by: Andy Yan --- Changes in v10: None Changes in v9: None Changes in v8: None Changes in v7: - remove unused variables from structure dw_hdmi - remove a wrong modification - add copyrights for dw_hdmi-imx.c Changes

[PATCH v10 04/11] staging: imx-drm: imx-hdmi: move imx-hdmi to bridge/dw_hdmi

2014-11-13 Thread Andy Yan
the original imx hdmi driver is under staging/imx-drm, which depends on imx-drm, so move the imx hdmi driver out to drm/bridge and rename imx-hdmi to dw_hdmi Signed-off-by: Andy Yan --- Changes in v10: None Changes in v9: None Changes in v8: None Changes in v7: None Changes in v6: None Changes

[PATCH v10 05/11] drm: bridge/dw_hdmi:split some phy configuration to platform driver

2014-11-13 Thread Andy Yan
hdmi phy clock symbol and transmission termination value can adjust platform specific to get the best SI also add mode_valid interface for some platform may not support all the display mode Signed-off-by: Andy Yan --- Changes in v10: - split generic dw_hdmi.c improvements from patch#11 (add

[PATCH v10 07/11] dt-bindings: add document for dw_hdmi

2014-11-13 Thread Andy Yan
Signed-off-by: Andy Yan --- Changes in v10: None Changes in v9: None Changes in v8: - correct some spelling mistake - modify ddc-i2c-bus and interrupt description Changes in v7: None Changes in v6: None Changes in v5: None Changes in v4: None Changes in v3: None Changes in v2: None

[PATCH v10 06/11] drm: bridge/dw_hdmi: clear i2cmphy_stat0 reg in hdmi_phy_wait_i2c_done

2014-11-13 Thread Andy Yan
corresponding bit will hold on forever, this may give a wrong signal for next check. Signed-off-by: Andy Yan --- Changes in v10: None Changes in v9: None Changes in v8: None Changes in v7: None Changes in v6: None Changes in v5: None Changes in v4: None Changes in v3: None Changes in v2: None

[PATCH v10 08/11] drm: bridge/dw_hdmi: add support for multi byte register width access

2014-11-13 Thread Andy Yan
On rockchip rk3288, only word(32-bit) accesses are permitted for hdmi registers. Byte width accesses (writeb, readb) generate an imprecise external abort. Signed-off-by: Andy Yan --- Changes in v10: None Changes in v9: None Changes in v8: None Changes in v7: None Changes in v6: - move some

[PATCH v10 09/11] drm: bridge/dw_hdmi: convert dw-hdmi to drm_bridge mode

2014-11-13 Thread Andy Yan
From: Yakir Yang keep the connector & birdge in dw_hdmi.c, handle encoder in dw_hdmi-imx.c, as most of the encoder operation are platform specific such as crtc select and panel format set Signed-off-by: Andy Yan Signed-off-by: Yakir Yang --- Changes in v10: None Changes in v9: None Cha

[PATCH v10 10/11] dt-bindings: Add documentation for rockchip dw hdmi

2014-11-13 Thread Andy Yan
Signed-off-by: Andy Yan --- Changes in v10: None Changes in v9: None Changes in v8: - Add documentation for rockchip dw hdmi Changes in v7: None Changes in v6: None Changes in v5: None Changes in v4: None Changes in v3: None Changes in v2: None .../devicetree/bindings/video/dw_hdmi

[PATCH v10 11/11] drm: bridge/dw_hdmi: add rockchip rk3288 support

2014-11-13 Thread Andy Yan
Rockchip RK3288 hdmi is compatible with dw_hdmi Signed-off-by: Andy Yan --- Changes in v10: - add more display mode support mpll configuration for rk3288 Changes in v9: - move some phy configuration to platform driver Changes in v8: None Changes in v7: None Changes in v6: None Changes in v5

Re: [PATCH v10 11/11] drm: bridge/dw_hdmi: add rockchip rk3288 support

2014-11-14 Thread Andy Yan
On 2014年11月14日 18:23, Zubair Lutfullah Kakakhel wrote: Hi Andy On 14/11/14 03:31, Andy Yan wrote: Rockchip RK3288 hdmi is compatible with dw_hdmi Signed-off-by: Andy Yan --- Changes in v10: - add more display mode support mpll configuration for rk3288 Changes in v9: - move some phy

Re: [PATCH v10 05/11] drm: bridge/dw_hdmi:split some phy configuration to platform driver

2014-11-14 Thread Andy Yan
Hi ZubairLK: Thanks for your review. On 2014年11月14日 18:19, Zubair Lutfullah Kakakhel wrote: Hi Andy, Nice work on this patch series. Its getting better and better :). On 14/11/14 03:27, Andy Yan wrote: hdmi phy clock symbol and transmission termination value can adjust platform specific to

Re: [PATCH v10 05/11] drm: bridge/dw_hdmi:split some phy configuration to platform driver

2014-11-14 Thread Andy Yan
On 2014年11月14日 18:55, Zubair Lutfullah Kakakhel wrote: On 14/11/14 10:53, Andy Yan wrote: Hi ZubairLK: Thanks for your review. On 2014年11月14日 18:19, Zubair Lutfullah Kakakhel wrote: Hi Andy, Nice work on this patch series. Its getting better and better :). On 14/11/14 03:27, Andy Yan

Re: [PATCH v10 11/11] drm: bridge/dw_hdmi: add rockchip rk3288 support

2014-11-14 Thread Andy Yan
On 2014年11月14日 18:53, Zubair Lutfullah Kakakhel wrote: On 14/11/14 10:37, Andy Yan wrote: On 2014年11月14日 18:23, Zubair Lutfullah Kakakhel wrote: Hi Andy On 14/11/14 03:31, Andy Yan wrote: Rockchip RK3288 hdmi is compatible with dw_hdmi Signed-off-by: Andy Yan --- Changes in v10: - add

Re: [PATCH v10 11/11] drm: bridge/dw_hdmi: add rockchip rk3288 support

2014-11-14 Thread Andy Yan
On 2014年11月14日 19:16, Zubair Lutfullah Kakakhel wrote: On 14/11/14 11:13, Andy Yan wrote: On 2014年11月14日 18:53, Zubair Lutfullah Kakakhel wrote: On 14/11/14 10:37, Andy Yan wrote: On 2014年11月14日 18:23, Zubair Lutfullah Kakakhel wrote: Hi Andy On 14/11/14 03:31, Andy Yan wrote: Rockchip

[PATCH v11 0/12] dw-hdmi: convert imx hdmi to bridge/dw_hdmi

2014-11-14 Thread Andy Yan
width Changes in v4: - fix checkpatch CHECK - defer probe ddc i2c adapter Changes in v3: - split multi-register access to one indepent patch Changes in v2: - use git format -M to generate these patch Andy Yan (11): staging: imx-drm: imx-hdmi: make checkpatch happy staging: imx-drm: imx-hdmi: return

[PATCH v11 01/12] staging: imx-drm: imx-hdmi: make checkpatch happy

2014-11-14 Thread Andy Yan
.] + else { [...] Signed-off-by: Andy Yan --- Changes in v11: None Changes in v10: None Changes in v9: None Changes in v8: None Changes in v7: None Changes in v6: - rearrange the patch order Changes in v5: None Changes in v4: - fix checkpatch CHECK Changes in v3: None Changes in v2: None drivers/

[PATCH v11 02/12] staging: imx-drm: imx-hdmi: return defer if can't get ddc i2c adapter

2014-11-14 Thread Andy Yan
drm driver may probe before the i2c bus, so the driver should defer probing until it is available Signed-off-by: Andy Yan --- Changes in v11: None Changes in v10: None Changes in v9: None Changes in v8: None Changes in v7: None Changes in v6: None Changes in v5: None Changes in v4: - defer

[PATCH v11 03/12] staging: imx-drm: imx-hdmi: split imx soc specific code from imx-hdmi

2014-11-14 Thread Andy Yan
hdmi driver, split the platform specific code out to dw_hdmi-imx.c. Signed-off-by: Andy Yan --- Changes in v11: - squash patch Changes in v10: - split generic dw_hdmi.c improvements from patch#11 (add rk3288 support) Changes in v9: None Changes in v8: None Changes in v7: - remove unused

  1   2   3   >