Align #define macro.
Signed-off-by: Chaehyun Lim chaehyun@gmail.com
---
drivers/staging/wilc1000/host_interface.c | 93 +++
1 file changed, 46 insertions(+), 47 deletions(-)
diff --git a/drivers/staging/wilc1000/host_interface.c
b/drivers/staging/wilc1000
Remove unnecessary typecast in #define macro.
Signed-off-by: Chaehyun Lim chaehyun@gmail.com
---
drivers/staging/wilc1000/host_interface.c | 78 +++
1 file changed, 39 insertions(+), 39 deletions(-)
diff --git a/drivers/staging/wilc1000/host_interface.c
b
Remove commented codes.
Signed-off-by: Chaehyun Lim chaehyun@gmail.com
---
drivers/staging/wilc1000/wilc_wfi_netdevice.c | 21 -
1 file changed, 21 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_wfi_netdevice.c
b/drivers/staging/wilc1000/wilc_wfi_netdevice.c
Remove variable that is defined but never used.
Signed-off-by: Chaehyun Lim chaehyun@gmail.com
---
drivers/staging/wilc1000/wilc_wfi_netdevice.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/wilc1000/wilc_wfi_netdevice.c
b/drivers/staging/wilc1000/wilc_wfi_netdevice.c
Remove multiple blank lines.
Signed-off-by: Chaehyun Lim chaehyun@gmail.com
---
drivers/staging/wilc1000/wilc_wfi_netdevice.c | 19 ---
1 file changed, 19 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_wfi_netdevice.c
b/drivers/staging/wilc1000/wilc_wfi_netdevice.c
Remove if statement that has no any codes.
Signed-off-by: Chaehyun Lim chaehyun@gmail.com
---
drivers/staging/wilc1000/wilc_wfi_netdevice.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_wfi_netdevice.c
b/drivers/staging/wilc1000/wilc_wfi_netdevice.c
Fix checkpatch warning found by checkpatch.pl
WARNING: space prohibited between function name and open parenthesis '('
Signed-off-by: Chaehyun Lim chaehyun@gmail.com
---
drivers/staging/wilc1000/wilc_wfi_netdevice.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
Fix checkpatch warning found by checkpatch.pl
WARNING: braces {} are not necessary for single statement blocks
Signed-off-by: Chaehyun Lim chaehyun@gmail.com
---
drivers/staging/wilc1000/wilc_wfi_netdevice.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers
Fix checkpatch warning found by checkpatch.pl
WARNING: Missing a blank line after declarations
Signed-off-by: Chaehyun Lim chaehyun@gmail.com
---
drivers/staging/wilc1000/wilc_wfi_netdevice.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/wilc1000
Fix checkpatch warning found by checkpatch.pl
WARNING: Missing a blank line after declarations
Signed-off-by: Chaehyun Lim chaehyun@gmail.com
---
drivers/staging/wilc1000/wilc_wfi_netdevice.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/staging/wilc1000/wilc_wfi_netdevice.c
Fix checkpatch warning found by checkpatch.pl
WARNING: space prohibited before semicolon
Signed-off-by: Chaehyun Lim chaehyun@gmail.com
---
drivers/staging/wilc1000/wilc_wfi_netdevice.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wilc1000
Fix warning founded by checkpatch.pl.
WARNING: __func__ should be used instead of gcc specific __FUNCTION__
Signed-off-by: Chaehyun Lim chaehyun@gmail.com
---
drivers/staging/wilc1000/linux_wlan.c| 2 +-
drivers/staging/wilc1000/linux_wlan_common.h | 16
drivers
Remove the commented codes using #if 0.
Signed-off-by: Chaehyun Lim chaehyun@gmail.com
---
V2: revert commented code using typedef and rebase latest staging-testing.
drivers/staging/wilc1000/coreconfigurator.c | 30 ---
drivers/staging/wilc1000/coreconfigurator.h | 300
Remove itypes.h that is not needed.
Signed-off-by: Chaehyun Lim chaehyun@gmail.com
---
drivers/staging/wilc1000/coreconfigurator.c | 1 -
drivers/staging/wilc1000/host_interface.c | 1 -
drivers/staging/wilc1000/itypes.h | 39 -
3 files changed, 41
Remove BOOL_T typedef.
Signed-off-by: Chaehyun Lim chaehyun@gmail.com
---
drivers/staging/wilc1000/host_interface.c | 6 +++---
drivers/staging/wilc1000/itypes.h | 9 -
2 files changed, 3 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/wilc1000/host_interface.c
The macros in wilc_log.h are not referenced anywhere, so just delete it.
Signed-off-by: Chaehyun Lim chaehyun@gmail.com
---
drivers/staging/wilc1000/wilc_log.h | 47 ---
drivers/staging/wilc1000/wilc_oswrapper.h | 2 --
2 files changed, 49 deletions
This patch uses -EINVAL for invalid argument checking instead of using
WILC_ERRORREPORT with WILC_INVALID_ARGUMENT.
Signed-off-by: Chaehyun Lim chaehyun@gmail.com
---
drivers/staging/wilc1000/wilc_msgqueue.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers
The macros inside wilc_osconfig.h are not referenced anywhere,
so just delete it.
Signed-off-by: Chaehyun Lim chaehyun@gmail.com
---
drivers/staging/wilc1000/wilc_osconfig.h | 9 -
drivers/staging/wilc1000/wilc_oswrapper.h | 1 -
2 files changed, 10 deletions(-)
delete mode 100644
WILC_ErrNo is replaced by s32, then WILC_ErrNo typedef is removed.
Signed-off-by: Chaehyun Lim chaehyun@gmail.com
---
drivers/staging/wilc1000/wilc_errorsupport.h | 2 --
drivers/staging/wilc1000/wilc_msgqueue.c | 12 ++--
drivers/staging/wilc1000/wilc_msgqueue.h | 8
This patch replaces WILC_MsgQueueRecv with wilc_mq_recv
to shorten function name and avoid CamelCase.
Signed-off-by: Chaehyun Lim chaehyun@gmail.com
---
drivers/staging/wilc1000/host_interface.c | 2 +-
drivers/staging/wilc1000/wilc_msgqueue.c | 2 +-
drivers/staging/wilc1000
This patch replaces WILC_MsgQueueDestroy to wilc_mq_destroy to
shorten function name and avoid CamelCase.
Signed-off-by: Chaehyun Lim chaehyun@gmail.com
---
drivers/staging/wilc1000/host_interface.c | 4 ++--
drivers/staging/wilc1000/wilc_msgqueue.c | 2 +-
drivers/staging/wilc1000
This patch removes kfree NULL check.
WARNING: kfree(NULL) is safe and this check is probably not required.
Signed-off-by: Chaehyun Lim chaehyun@gmail.com
---
drivers/staging/wilc1000/wilc_msgqueue.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging
This patch replaces WILC_ErrNo with int type.
WILC_ErrNo typedef is also removed.
Signed-off-by: Chaehyun Lim chaehyun@gmail.com
---
drivers/staging/wilc1000/wilc_errorsupport.h | 2 --
drivers/staging/wilc1000/wilc_msgqueue.c | 12 ++--
drivers/staging/wilc1000/wilc_msgqueue.h
This patch changes bool comparison style found by checkpatch.pl
CHECK: Using comparison to true is error prone
Signed-off-by: Chaehyun Lim chaehyun@gmail.com
---
drivers/staging/wilc1000/wilc_msgqueue.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging
This patch replaces WILC_MsgQueueCreate with wilc_mq_create to
shorten function name and avoid CamelCase.
Signed-off-by: Chaehyun Lim chaehyun@gmail.com
---
drivers/staging/wilc1000/host_interface.c | 2 +-
drivers/staging/wilc1000/wilc_msgqueue.c | 2 +-
drivers/staging/wilc1000
This patch uses ! operator instead of NULL comparison.
Signed-off-by: Chaehyun Lim chaehyun@gmail.com
---
drivers/staging/wilc1000/wilc_msgqueue.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_msgqueue.c
b/drivers
This patch replaces WILC_MsgQueueSend with wilc_mq_send to
shorten function name and avoid CamelCase.
Signed-off-by: Chaehyun Lim chaehyun@gmail.com
---
drivers/staging/wilc1000/host_interface.c | 98 +++
drivers/staging/wilc1000/wilc_msgqueue.c | 2 +-
drivers
This patch removes braces for single statement blocks.
WARNING: braces {} are not necessary for single statement blocks
Signed-off-by: Chaehyun Lim chaehyun@gmail.com
---
drivers/staging/wilc1000/wilc_msgqueue.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git
This patch remove unnecessary parentheses found by checkpatch.pl
CHECK: Unnecessary parentheses around pHandle-hSem
Signed-off-by: Chaehyun Lim chaehyun@gmail.com
---
drivers/staging/wilc1000/wilc_msgqueue.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers
This patch removes multiple blank lines.
CHECK: Please don't use multiple blank lines
Signed-off-by: Chaehyun Lim chaehyun@gmail.com
---
drivers/staging/wilc1000/wilc_msgqueue.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_msgqueue.c
b/drivers/staging
This patch removes blank line before a close brace }
CHECK: Blank lines aren't necessary before a close brace '}'
Signed-off-by: Chaehyun Lim chaehyun@gmail.com
---
drivers/staging/wilc1000/wilc_msgqueue.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/wilc1000
This patch adds a blank line after declaration found by checkpatch.pl
WARNING: Missing a blank line after declarations.
Signed-off-by: Chaehyun Lim chaehyun@gmail.com
---
drivers/staging/wilc1000/coreconfigurator.c | 8
drivers/staging/wilc1000/linux_wlan.c | 18
This patch removes unused codes of gps8ConfigPacket declared by global variable.
It is allocated and freed memory within CoreConfiguratorInit and
CoreConfiguratorDeInit.
There is no used anywhere except within two functions.
Signed-off-by: Chaehyun Lim chaehyun@gmail.com
---
drivers/staging
The kmalloc is used to handle host interface message within kernel thread.
The manipulation of host interface message is not called on IRQ context
and I could not find any spinlock inside function.
Signed-off-by: Chaehyun Lim chaehyun@gmail.com
---
drivers/staging/wilc1000/coreconfigurator.c
This patch removes unnecessary void pointer cast of WILC_MALLOC.
Signed-off-by: Chaehyun Lim chaehyun@gmail.com
---
drivers/staging/wilc1000/coreconfigurator.c | 12 ++--
drivers/staging/wilc1000/host_interface.c | 78 +++
drivers/staging/wilc1000
WILC_NEW is replaced by kmallo with GFP_ATOMIC.
This kmalloc is inside a spin_lock_irqsave region.
Signed-off-by: Chaehyun Lim chaehyun@gmail.com
---
drivers/staging/wilc1000/wilc_msgqueue.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wilc1000
This patch removes WILC_NEW and WILC_NEW_EX defines that are not used anywhere.
Signed-off-by: Chaehyun Lim chaehyun@gmail.com
---
drivers/staging/wilc1000/wilc_memory.h | 15 ---
1 file changed, 15 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_memory.h
b/drivers
Return -ENOMEM if memory allocation is failed.
Signed-off-by: Chaehyun Lim chaehyun@gmail.com
---
drivers/staging/wilc1000/coreconfigurator.c | 13 -
1 file changed, 4 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/wilc1000/coreconfigurator.c
b/drivers/staging
Use kmalloc and kmalloc_array instead of WILC_MALLOC.
Signed-off-by: Chaehyun Lim chaehyun@gmail.com
---
drivers/staging/wilc1000/coreconfigurator.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/wilc1000/coreconfigurator.c
b/drivers
is not called on IRQ context and I
could not
find any spin lock inside function.
If this patches are accepted, I will try to continue to change WILC_MALLOC
macro as kmalloc.
I always appreciate your comment and advice.
Thanks
Chaehyun Lim
Chaehyun Lim (3):
staging: wilc1000: coreconfigurator.c
Add error check if memory allocation is failed.
Signed-off-by: Chaehyun Lim chaehyun@gmail.com
---
drivers/staging/wilc1000/coreconfigurator.c | 12
1 file changed, 12 insertions(+)
diff --git a/drivers/staging/wilc1000/coreconfigurator.c
b/drivers/staging/wilc1000
I'm sorry that I have mistake the number of kmalloc changes. The total
change is 6, not 4.
On Thu, Jul 30, 2015 at 8:41 PM, Chaehyun Lim chaehyun@gmail.com wrote:
Hi, Greg
I'm sorry that I did not say whether GFP_ATOMIC should be used or not.
This is my review on it. If it's not correct
Remove WILC_memset function because it is changed to memset.
Signed-off-by: Chaehyun Lim chaehyun@gmail.com
---
drivers/staging/wilc1000/wilc_strutils.c | 9 -
drivers/staging/wilc1000/wilc_strutils.h | 12
2 files changed, 21 deletions(-)
diff --git a/drivers/staging
Use memset instead of WILC_memset.
Signed-off-by: Chaehyun Lim chaehyun@gmail.com
---
drivers/staging/wilc1000/coreconfigurator.c | 16 +--
drivers/staging/wilc1000/host_interface.c | 134 +++---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 16 +--
3
Use memcmp instead of WILC_memcmp.
Signed-off-by: Chaehyun Lim chaehyun@gmail.com
---
drivers/staging/wilc1000/host_interface.c | 20 +++---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 32 +++
2 files changed, 26 insertions(+), 26 deletions
Remove WILC_memcmp function because it is changed to memcmp.
Signed-off-by: Chaehyun Lim chaehyun@gmail.com
---
drivers/staging/wilc1000/wilc_strutils.c | 9 -
drivers/staging/wilc1000/wilc_strutils.h | 13 -
2 files changed, 22 deletions(-)
diff --git a/drivers/staging
Insert blank line after struct declaration found by checkpatch.pl.
CHECK: use a blank line after function/struct/union/enum declarations
Signed-off-by: Chaehyun Lim chaehyun@gmail.com
---
drivers/staging/most/aim-cdev/cdev.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging
Remove unnecessary pr_info found by checkpatch.pl.
WARNING: Possible unnecessary 'out of memory' message
Signed-off-by: Chaehyun Lim chaehyun@gmail.com
---
drivers/staging/most/aim-cdev/cdev.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/most/aim-cdev/cdev.c
b/drivers
Move logical operator to previous line found by checkpatch.pl.
CHECK: Logical continuations should be on the previous line
Signed-off-by: Chaehyun Lim chaehyun@gmail.com
---
drivers/staging/most/aim-cdev/cdev.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git
Use ! operator instead of NULL comparison found by checkpatch.pl.
Signed-off-by: Chaehyun Lim chaehyun@gmail.com
---
drivers/staging/most/aim-cdev/cdev.c | 13 ++---
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/most/aim-cdev/cdev.c
b/drivers/staging
Move assignment out of if condition found by checkpatch.pl.
ERROR: do not use assignment in if condition
Signed-off-by: Chaehyun Lim chaehyun@gmail.com
---
drivers/staging/most/aim-cdev/cdev.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/most/aim
Remove boolean comparison found by checkpatch.pl.
CHECK: Using comparison to true is error prone
Signed-off-by: Chaehyun Lim chaehyun@gmail.com
---
drivers/staging/most/aim-cdev/cdev.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/most/aim-cdev
Remove multiple blank line found by checkpatch.pl.
CHECK: Please don't use multiple blank lines
Signed-off-by: Chaehyun Lim chaehyun@gmail.com
---
drivers/staging/most/aim-cdev/cdev.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/most/aim-cdev/cdev.c
b/drivers/staging
This patch remove unused memory functions because some macros with this
memory function are deleted.
Signed-off-by: Chaehyun Lim chaehyun@gmail.com
---
drivers/staging/wilc1000/wilc_memory.c | 28 ---
drivers/staging/wilc1000/wilc_memory.h | 50
Use kfree instead of WILC_FREE.
Signed-off-by: Chaehyun Lim chaehyun@gmail.com
---
drivers/staging/wilc1000/coreconfigurator.c | 12 +--
drivers/staging/wilc1000/host_interface.c | 112 +++---
drivers/staging/wilc1000/linux_wlan.c | 2 +-
drivers
Remove unused define macro that is never used.
Signed-off-by: Chaehyun Lim chaehyun@gmail.com
---
drivers/staging/wilc1000/wilc_memory.h | 51 --
1 file changed, 51 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_memory.h
b/drivers/staging/wilc1000
Remove WILC_FREE that is replaced by kfree.
Signed-off-by: Chaehyun Lim chaehyun@gmail.com
---
drivers/staging/wilc1000/wilc_memory.h | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_memory.h
b/drivers/staging/wilc1000/wilc_memory.h
index 1c0cb82
Use strlen instead of WILC_strlen that is a custom function.
Signed-off-by: Chaehyun Lim chaehyun@gmail.com
---
drivers/staging/wilc1000/coreconfigurator.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/wilc1000/coreconfigurator.c
b/drivers/staging
Use memcpy instead of WILC_memcpy that is a custom function.
Signed-off-by: Chaehyun Lim chaehyun@gmail.com
---
drivers/staging/wilc1000/coreconfigurator.c | 22 +--
drivers/staging/wilc1000/host_interface.c | 200 +++---
drivers/staging/wilc1000/linux_wlan.c
Remove WILC_strncpy function that is changed to strncpy.
Signed-off-by: Chaehyun Lim chaehyun@gmail.com
---
drivers/staging/wilc1000/wilc_strutils.c | 10 --
drivers/staging/wilc1000/wilc_strutils.h | 14 --
2 files changed, 24 deletions(-)
diff --git a/drivers/staging
Remove WILC_strlen function that is changed to strlen.
Signed-off-by: Chaehyun Lim chaehyun@gmail.com
---
drivers/staging/wilc1000/wilc_strutils.c | 9 -
drivers/staging/wilc1000/wilc_strutils.h | 10 --
2 files changed, 19 deletions(-)
diff --git a/drivers/staging/wilc1000
Remove commented code that is not used.
Signed-off-by: Chaehyun Lim chaehyun@gmail.com
---
drivers/staging/wilc1000/coreconfigurator.c | 1 -
drivers/staging/wilc1000/host_interface.c | 2 --
2 files changed, 3 deletions(-)
diff --git a/drivers/staging/wilc1000/coreconfigurator.c
b
Use strncmp instead of WILC_strncmp.
Signed-off-by: Chaehyun Lim chaehyun@gmail.com
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
b/drivers/staging/wilc1000
Use strncpy instead of WILC_strncpy that is a custom function
Signed-off-by: Chaehyun Lim chaehyun@gmail.com
---
drivers/staging/wilc1000/coreconfigurator.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wilc1000/coreconfigurator.c
b/drivers/staging
Remove WILC_memcpy_INTERNAL that is used in the WILC_memcpy
because WILC_memcpy is replaced by memcpy.
Signed-off-by: Chaehyun Lim chaehyun@gmail.com
---
drivers/staging/wilc1000/wilc_strutils.c | 9 -
drivers/staging/wilc1000/wilc_strutils.h | 11 ---
2 files changed, 20
Remove WILC_memcpy function that is changed to memcpy.
Signed-off-by: Chaehyun Lim chaehyun@gmail.com
---
drivers/staging/wilc1000/wilc_strutils.h | 30 --
1 file changed, 30 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_strutils.h
b/drivers/staging
Remove WILC_strncmp function that is changed to strncmp.
Signed-off-by: Chaehyun Lim chaehyun@gmail.com
---
drivers/staging/wilc1000/wilc_strutils.c | 21 -
drivers/staging/wilc1000/wilc_strutils.h | 20
2 files changed, 41 deletions(-)
diff --git
Remove wilc_strutils.c and wilc_strutils.h that are not needed.
wilc_strutils.o is also removed in Makefile.
Signed-off-by: Chaehyun Lim chaehyun@gmail.com
---
drivers/staging/wilc1000/Makefile | 2 +-
drivers/staging/wilc1000/wilc_msgqueue.h | 1 -
drivers/staging/wilc1000
Return -ENOMEM if memory allocation is failed.
Signed-off-by: Chaehyun Lim chaehyun@gmail.com
---
V2: Use ! operator instead of NULL comparison
V3: this patch is rebased by previous modification
drivers/staging/wilc1000/coreconfigurator.c | 13 -
1 file changed, 4 insertions
Use kmalloc and kmalloc_array instead of WILC_MALLOC.
Signed-off-by: Chaehyun Lim chaehyun@gmail.com
---
V2: Use GFP_KERNEL flag instead of GFP_ATOMIC
drivers/staging/wilc1000/coreconfigurator.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/drivers
Add error check if memory allocation is failed.
Signed-off-by: Chaehyun Lim chaehyun@gmail.com
---
V2: use ! operator instead of NULL comparison
V3: this patch is rebased by previous modification
drivers/staging/wilc1000/coreconfigurator.c | 12
1 file changed, 12 insertions
Use kmalloc and kmalloc_array instead of WILC_MALLOC.
Signed-off-by: Chaehyun Lim chaehyun@gmail.com
---
drivers/staging/wilc1000/coreconfigurator.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/wilc1000/coreconfigurator.c
b/drivers
Add error check if memory allocation is failed.
Signed-off-by: Chaehyun Lim chaehyun@gmail.com
---
drivers/staging/wilc1000/coreconfigurator.c | 12
1 file changed, 12 insertions(+)
diff --git a/drivers/staging/wilc1000/coreconfigurator.c
b/drivers/staging/wilc1000
Return -ENOMEM if memory allocation is failed.
Signed-off-by: Chaehyun Lim chaehyun@gmail.com
---
drivers/staging/wilc1000/coreconfigurator.c | 13 -
1 file changed, 4 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/wilc1000/coreconfigurator.c
b/drivers/staging
Return -ENOMEM if memory allocation is failed.
Signed-off-by: Chaehyun Lim chaehyun@gmail.com
---
V2: use ! operator instead of NULL comparison.
drivers/staging/wilc1000/coreconfigurator.c | 13 -
1 file changed, 4 insertions(+), 9 deletions(-)
diff --git a/drivers/staging
Add error check if memory allocation is failed.
Signed-off-by: Chaehyun Lim chaehyun@gmail.com
---
V2: use ! operator instead of NULL comparison
drivers/staging/wilc1000/coreconfigurator.c | 12
1 file changed, 12 insertions(+)
diff --git a/drivers/staging/wilc1000
Move static specifier into MOST_INST_ATTR to fix checkpatch error.
ERROR: Macros with complex values should be enclosed in parentheses
Signed-off-by: Chaehyun Lim chaehyun@gmail.com
---
drivers/staging/most/mostcore/core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
Move static specifier into MOST_CHNL_ATTR to fix checkpatch error.
ERROR: Macros with complex values should be enclosed in parentheses
Signed-off-by: Chaehyun Lim chaehyun@gmail.com
---
drivers/staging/most/mostcore/core.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff
Remove semicolon at the end of define statement to fix checkpatch warning.
WARNING: macros should not use a trailing semicolon
Signed-off-by: Chaehyun Lim chaehyun@gmail.com
---
drivers/staging/most/mostcore/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers
On Wed, Jul 15, 2015 at 6:16 AM, Greg KH gre...@linuxfoundation.org wrote:
On Tue, Jul 14, 2015 at 10:48:41AM +0900, Chaehyun Lim wrote:
Remove WILC_ERRORREPORT macro. If memory allocation is failed,
jump to a label to return this function with WILC_NO_MEM.
Signed-off-by: Chaehyun Lim
Remove WILC_ERRORREPORT macro. If memory allocation is failed,
jump to a label to return this function with WILC_NO_MEM.
Signed-off-by: Chaehyun Lim chaehyun@gmail.com
---
drivers/staging/wilc1000/host_interface.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git
When building this driver, I got a warning as below:
host_interface.c: In function ‘host_int_add_beacon’:
host_interface.c:7116:16: warning: ‘*((void *)strHostIFmsg+8).pu8Head’ may be
used
uninitialized in this function [-Wmaybe-uninitialized]
Signed-off-by: Chaehyun Lim chaehyun@gmail.com
This patch changes return type of host_int_set_WEPDefaultKeyID from s32
to int. The result variable gets return value from wilc_mq_send that has
return type of int. It should be changed return type int as well as data
type of result variable.
Signed-off-by: Chaehyun Lim <chaehyun@gmail.
This patch replaces host_int_set_WEPDefaultKeyID with
host_int_set_wep_default_key to avoid camelcase.
Signed-off-by: Chaehyun Lim <chaehyun@gmail.com>
---
drivers/staging/wilc1000/host_interface.c | 2 +-
drivers/staging/wilc1000/host_interface.h | 2 +-
drivers/s
This patch changes second parameter of host_int_set_WEPDefaultKeyID from
u8Index to index to avoid camelcase.
Signed-off-by: Chaehyun Lim <chaehyun@gmail.com>
---
drivers/staging/wilc1000/host_interface.c | 4 ++--
drivers/staging/wilc1000/host_interface.h | 2 +-
2 files chan
This patch changes struct host_if_drv of host_int_set_WEPDefaultKeyID
function declaration from hWFIDrv to hif_drv in host_interface.h
With this change, first parameter name of this function declaration and
definition has same name as hif_drv.
Signed-off-by: Chaehyun Lim <chaehyun@gmail.
This patch fixes line over 80 characters found by checkpatch.
WARNING: line over 80 characters
FILE: drivers/staging/wilc1000/host_interface.h:408:
Signed-off-by: Chaehyun Lim <chaehyun@gmail.com>
---
drivers/staging/wilc1000/host_interface.h | 3 ++-
1 file changed, 2 insertions
This patch replaces kmalloc followed by memcpy with kmemdup.
It is also added error checking of kmemdup.
Signed-off-by: Chaehyun Lim <chaehyun@gmail.com>
---
drivers/staging/wilc1000/host_interface.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/s
This patch changes u8Keyidx to index that is fourth argument of
host_int_add_wep_key_bss_sta to avoid camelcase.
Signed-off-by: Chaehyun Lim <chaehyun@gmail.com>
---
drivers/staging/wilc1000/host_interface.c | 4 ++--
drivers/staging/wilc1000/host_interface.h | 2 +-
2 files chan
This patch removes multiple blank lines found by checkpatch.
CHECK: Please don't use multiple blank lines
FILE: drivers/staging/wilc1000/host_interface.c:3175:
Signed-off-by: Chaehyun Lim <chaehyun@gmail.com>
---
drivers/staging/wilc1000/host_interface.c | 1 -
1 file changed, 1 de
This patch changes u8WepKeylen to len that is third argument of
host_int_add_wep_key_bss_sta to avoid camelcase.
Signed-off-by: Chaehyun Lim <chaehyun@gmail.com>
---
drivers/staging/wilc1000/host_interface.c | 8
drivers/staging/wilc1000/host_interface.h | 2 +-
2 files chan
This patch changes return type of host_int_add_wep_key_bss_sta from s32
to int. The result variable gets return value from wilc_mq_send that has
return type of int. It should be changed return type of this function
as well as data type of result variable.
Signed-off-by: Chaehyun Lim <chaeh
This patch changes pu8WepKey to key that is second argument of
host_int_add_wep_key_bss_sta to avoid camelcase.
Signed-off-by: Chaehyun Lim <chaehyun@gmail.com>
---
drivers/staging/wilc1000/host_interface.c | 4 ++--
drivers/staging/wilc1000/host_interface.h | 2 +-
2 files chan
This patch changes struct host_if_drv of host_int_add_wep_key_bss_sta
function declaration from hWFIDrv to hif_drv.
With this change, first parameter name of this function declaration and
definition has same name as hif_drv.
Signed-off-by: Chaehyun Lim <chaehyun@gmail.com>
---
d
This patch changes return type of host_int_del_beacon from s32 to int.
The result variable gets return value from wilc_mq_send that has return
type of int. It should be changed return type of this function as well
as data type of result variable.
Signed-off-by: Chaehyun Lim <chaeh
This patch changes struct host_if_drv of host_int_del_station function
declaration from hWFIDrv to hif_drv.
With this change, first parameter name of this function declaration and
definition has same name as hif_drv.
Signed-off-by: Chaehyun Lim <chaehyun@gmail.com>
---
drivers/s
This patch changes struct host_if_drv of host_int_del_beacon function
declaration from hWFIDrv to hif_drv.
With this change, first parameter name of this function declaration and
definition has same name as hif_drv.
Signed-off-by: Chaehyun Lim <chaehyun@gmail.com>
---
drivers/s
This patch changes return type of host_int_del_station from s32 to int.
The result variable gets return value from wilc_mq_send that has return
type of int. It should be changed return type of this function as well
as data type of result variable.
Signed-off-by: Chaehyun Lim <chaeh
This patch replaces kmalloc followed by memcpy with kmemdup.
Signed-off-by: Chaehyun Lim <chaehyun@gmail.com>
---
drivers/staging/wilc1000/host_interface.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/wilc1000/host_interface.c
b/drivers/s
This patch renames pstrStaParams to sta_param to avoid camelcase.
Signed-off-by: Chaehyun Lim <chaehyun@gmail.com>
---
drivers/staging/wilc1000/host_interface.c | 6 +++---
drivers/staging/wilc1000/host_interface.h | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff
1 - 100 of 695 matches
Mail list logo