[PATCH] staging: wilc1000: Remove 'if' statement, which is always false

- 'if' which is always false is removed - variable associated with this 'if' is deleted Signed-off-by: Chandra S Gorentla --- drivers/staging/wilc1000/wilc_msgqueue.c | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_m

[PATCH] staging: comedi: drivers: pcl816.c remove leading space

Checkpatch.pl warning - suspect code indent for conditional statements - is corrected Signed-off-by: Chandra S Gorentla --- drivers/staging/comedi/drivers/pcl816.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/comedi/drivers/pcl816.c b/drivers/staging

[PATCH] staging: wilc1000: host_interface.c: Fix build warning

Fixed - warning: ‘*((void *)&strHostIFmsg+4).pu8Head’ may be used uninitialized Signed-off-by: Chandra S Gorentla --- drivers/staging/wilc1000/host_interface.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/sta

drivers: staging: wilc1000: Fix a few style erros

These patches fixes a few style errors reported by checkpatch.pl. PATCH 3/3 should be applied after PATCH 2/3. ___ devel mailing list [email protected] http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 1/3] drivers: staging: wilc1000: use 'void' for no arguments functions

Added 'void' keyword in the paranthesis of function definitions, when there are no arguments to the functions. This fixes the checkpatch.pl error - "Bad function definition 'function()' should probably be function(void)". Signed-off-by: Chandra S Gorentla

[PATCH 3/3] drivers: staging: wilc1000: remove space after '('

The character ' ' is removed after the character '('. This fixes the checkpatch.pl error - "space prohibited after that open parenthesis '('". Signed-off-by: Chandra S Gorentla --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 2 +- 1 file chan

[PATCH 2/3] drivers: staging: wilc1000: move { to previous line

Moved the opening brace of code blocks to the previous lines. This fixes the checkpatch.pl error - "that open brace { should be on the previous line". Signed-off-by: Chandra S Gorentla --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 9 +++-- 1 file changed, 3 insert

[PATCH v2 0/3] drivers: staging: wilc1000: Fix a few style errors

v2 - Resending as v1 patch series did not apply cleanly. These patches fixes a few style errors reported by checkpatch.pl. PATCH 3/3 should be applied after PATCH 2/3. ___ devel mailing list [email protected] http://driverdev.linuxdriverproje

[PATCH v2 3/3] drivers: staging: wilc1000: remove space after '('

The character ' ' is removed after the character '('. This fixes the checkpatch.pl error - "space prohibited after that open parenthesis '('". --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wilc1000/wilc_w

[PATCH v2 1/3] drivers: staging: wilc1000: use 'void' for no arguments functions

Added 'void' keyword in the paranthesis of function definitions, when there are no arguments to the functions. This fixes the checkpatch.pl error - "Bad function definition 'function()' should probably be function(void)". --- drivers/staging/wilc1000/linux_mon.c | 2 +- drivers/staging/wilc1000

[PATCH v2 2/3] drivers: staging: wilc1000: move { to previous line

Moved the opening brace of code blocks to the previous lines. This fixes the checkpatch.pl error - "that open brace { should be on the previous line". --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/stagin

[PATCH v3 1/3] drivers: staging: wilc1000: use 'void' for no arguments functions

Added 'void' keyword in the paranthesis of function definitions, when there are no arguments to the functions. This fixes the checkpatch.pl error - "Bad function definition 'function()' should probably be function(void)". Signed-off-by: Chandra S Gorentla

[PATCH v3 0/3] drivers: staging: wilc1000: Fix a few style errors

v3 - Resending as v2 patch was series missing signedoff line. Corrected now. v2 - Resending as v1 patch series did not apply cleanly. These patches fixes a few style errors reported by checkpatch.pl. PATCH 3/3 should be applied after PATCH 2/3. ___ dev

[PATCH v3 2/3] drivers: staging: wilc1000: move { to previous line

Moved the opening brace of code blocks to the previous lines. This fixes the checkpatch.pl error - "that open brace { should be on the previous line". Signed-off-by: Chandra S Gorentla --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 9 +++-- 1 file changed, 3 insert

[PATCH v3 3/3] drivers: staging: wilc1000: remove space after '('

The character ' ' is removed after the character '('. This fixes the checkpatch.pl error - "space prohibited after that open parenthesis '('". Signed-off-by: Chandra S Gorentla --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 2 +- 1 file chan

[PATCH 1/2] drivers: staging: wilc1000: Replace message queue with standard Linux lists

- The message queue is replaced with standard Linux linked list - kmem_cache is used for list members - A check for return value of receive method is added - GFP_ATOMIC is changed to GFP_KERNEL - A few other related minor changes Signed-off-by: Chandra S Gorentla --- - Comments of Dan

[PATCH 2/2] drivers: staging: wilc1000: wilc_msgqueue.c: Remove ineffective code

Signed-off-by: Chandra S Gorentla --- drivers/staging/wilc1000/wilc_msgqueue.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_msgqueue.c b/drivers/staging/wilc1000/wilc_msgqueue.c index a01ada4..1a411d3 100644 --- a/drivers/staging/wilc1000/wilc_msgqueue.c

[PATCH 2/2] drivers: staging: wilc1000: wilc_msgqueue.c: Remove code that no effect

Signed-off-by: Chandra S Gorentla --- drivers/staging/wilc1000/wilc_msgqueue.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_msgqueue.c b/drivers/staging/wilc1000/wilc_msgqueue.c index a01ada4..1a411d3 100644 --- a/drivers/staging/wilc1000/wilc_msgqueue.c

[PATCH 2/3] drivers: staging: wilc1000: Remove ineffective code

The value of 'result' is not modified from 0 after initialization. Hence no need to check it. Signed-off-by: Chandra S Gorentla --- drivers/staging/wilc1000/wilc_msgqueue.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_msgqueue.c b/drive

[PATCH 3/3] drivers: staging: wilc1000: Do not return from function with lock is on

There are a couple of return statements before unlock. Lock is moved to a location just before queue manipulation. Signed-off-by: Chandra S Gorentla --- drivers/staging/wilc1000/wilc_msgqueue.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wilc1000

[PATCH 1/3] drivers: staging: wilc1000: Check for errors before kfree

During the clean-up of the function, it is need to check if errors occurred, not the memory pointer. Signed-off-by: Chandra S Gorentla --- drivers/staging/wilc1000/wilc_msgqueue.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wilc1000/wilc_msgqueue.c b

[PATCH 1/2] drivers: staging: wilc1000: Move spin lock to the start of critical section

The spin_lock_irqsave is moved to just beginning of critical section. This change moves a couple of return statements out of the lock. Signed-off-by: Chandra S Gorentla --- drivers/staging/wilc1000/wilc_msgqueue.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers

[PATCH 2/2] drivers: staging: wilc1000: Call kfree only for error cases

for target block of goto statement; hence it is removed Signed-off-by: Chandra S Gorentla --- drivers/staging/wilc1000/wilc_msgqueue.c | 22 ++ 1 file changed, 6 insertions(+), 16 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_msgqueue.c b/drivers/staging/wilc1000

[PATCH 2/4] staging: wilc1000: Remove unused extern declarations

'extern' declarations which are not referenced within the file are removed. Signed-off-by: Chandra S Gorentla --- drivers/staging/wilc1000/host_interface.c | 1 - drivers/staging/wilc1000/linux_wlan_sdio.c| 1 - drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 2 -

[PATCH 1/4] staging: wilc1000: Add space between the braces

Inserted space between nested braces. This fixes the checkpatch.pl error - space required after that close brace '}'. Signed-off-by: Chandra S Gorentla --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drive

[PATCH 4/4] staging: wilc1000: Remove braces for single statement 'if' and 'else'

Fixes the checkpatch.pl warning - braces {} are not necessary for any arm of this statement Signed-off-by: Chandra S Gorentla --- drivers/staging/wilc1000/coreconfigurator.c | 10 - drivers/staging/wilc1000/host_interface.c | 19 - drivers/staging/wilc1000

staging: wilc1000 Fixes for style errors/warnings

This series fix some of the errors and warnings found using checkpatch.pl. ___ devel mailing list [email protected] http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 3/4] staging: wilc1000: Remove ' ' before quoted '\n'

Fixes the checkpatch.pl warning - 'unnecessary whitespace before a quoted newline'. Signed-off-by: Chandra S Gorentla --- drivers/staging/wilc1000/linux_wlan.c | 20 +-- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 42 +++ drivers/stagin

[PATCH] staging: wilc100: Remove pointer and integer comparision

Removed pointer check with integer; this fixes 'sparse' error - error: incompatible types for operation (>) left side has type unsigned char [usertype] *[usertype] pu8Tail right side has type int Signed-off-by: Chandra S Gorentla --- drivers/staging/wilc1000/host_interfac

[PATCH v2] staging: wilc1000: Remove pointer and integer comparision

Removed pointer check with integer; this fixes 'sparse' error - error: incompatible types for operation (>) left side has type unsigned char [usertype] *[usertype] pu8Tail right side has type int Signed-off-by: Chandra S Gorentla --- Changes in v2: Subject line corr

[PATCH] staging: wilc1000: Process WARN, INFO options of debug levels from user

default option ERR. As a side effect, this patch removes the 'sparse' warning - 'warning: incorrect type in argument 2 (different address spaces)'. Signed-off-by: Chandra S Gorentla --- drivers/staging/wilc1000/wilc_debugfs.c | 26 -- 1 file chan

[PATCH v2] staging: wilc1000: Process WARN, INFO options of debug levels from user

default option ERR. As a side effect, this patch removes the 'sparse' warning - 'warning: incorrect type in argument 2 (different address spaces)'. Signed-off-by: Chandra S Gorentla --- drivers/staging/wilc1000/wilc_debugfs.c | 28 +--- 1 file cha

[PATCH v3] staging: wilc1000: Process WARN, INFO options of debug levels from user

option that is enabled by default is ERR. As a side effect, this patch removes the 'sparse' warning - 'warning: incorrect type in argument 2 (different address spaces)'. Signed-off-by: Chandra S Gorentla --- Changes in v3: Added back a printk that was removed from v1 Cha

[PATCH] staging: wilc1000: Set all options in region debugfs file

gions on which logging is enabled. The DBG_REGION_ALL now includes 3 additional regions TCP_ENH, SPIN_DEBUG and FIRM_DBG. Before this change, the region flag FIRM_DBG is enabled during initialization but cleared after a write to the debugfs file. Signed-off-by: Chandra S Gorentla --- It is verifie

[PATCH] drivers: stating: wilc1000: Add a check for SPI availability

NULL pointer deference is observed in the wilc1000.ko module with bus type SPI and when SPI is not ready. Signed-off-by: Chandra S Gorentla --- Following are the steps to reproduce. $ sudo insmod drivers/staging/wilc1000/wilc1000.ko $ sudo ifconfig wlan1 up wlan1 in the above command is the

[PATCH v2] drivers: staging: wilc1000: Add check for SPI availability

NULL pointer deference is observed in the wilc1000.ko module with bus type SPI and when SPI is not ready. Signed-off-by: Chandra S Gorentla --- v2 - Subject corrected 'stating:' -> 'staging:' Following are the steps to reproduce. $ sudo insmod drivers/staging/wilc

[PATCH] drivers: staging: wilc1000: Replace message queue with standard Linux lists

The message queue is replaced with standard Linux linked list. A check for return value of receive method is added. Signed-off-by: Chandra S Gorentla --- drivers/staging/wilc1000/host_interface.c | 7 +++- drivers/staging/wilc1000/wilc_msgqueue.c | 62 ++- drivers