[PATCH 0/8] staging: erofs: fix some issues and clean up codes

From: Chao Yu This patchset mainly adds error handing code for erofs xattr subsystem. In addition, some code cleanups are also included in this patchset. P.S. Some other patches are still previewing in the linux-erofs mailing list, which will be posted in the 2nd part later. Gao Xiang (8

[PATCH 3/8] staging: erofs: add error handling for xattr submodule

From: Gao Xiang This patch enhances the missing error handling code for xattr submodule, which improves the stability for the rare cases. Signed-off-by: Gao Xiang Reviewed-by: Chao Yu Signed-off-by: Chao Yu --- drivers/staging/erofs/internal.h | 6 +- drivers/staging/erofs/xattr.c

[PATCH 7/8] staging: erofs: fix integer overflow on 32-bit platform

From: Gao Xiang This patch fixes integer overflow on multiplication of 32-bit `lcn' in z_erofs_map_blocks_iter. Signed-off-by: Gao Xiang Reviewed-by: Chao Yu Signed-off-by: Chao Yu --- drivers/staging/erofs/unzip_vle.c | 8 1 file changed, 4 insertions(+), 4 deletions(-)

[PATCH 4/8] staging: erofs: cleanup z_erofs_vle_work_{lookup, register}

From: Gao Xiang This patch introduces 'struct z_erofs_vle_work_finder' to clean up arguments of z_erofs_vle_work_lookup and z_erofs_vle_work_register. Signed-off-by: Gao Xiang Reviewed-by: Chao Yu Signed-off-by: Chao Yu --- drivers/staging/erofs/unzip_

[PATCH 8/8] staging: erofs: fix compression mapping beyond EOF

From: Gao Xiang Logical address of EOF LTP mapping should start at `inode->i_size' rather than `inode->i_size - 1' to `m_la(in)', fix it. Signed-off-by: Gao Xiang Reviewed-by: Chao Yu Signed-off-by: Chao Yu --- drivers/staging/erofs/unzip_vle.c | 2 +- 1 file chang

[PATCH 5/8] staging: erofs: rearrange vle clustertype definitions

From: Gao Xiang This patch moves vle clustertype definitions to erofs_fs.h since they are part of on-disk format. It also adds compile time check for Z_EROFS_VLE_DI_CLUSTER_TYPE_BITS Signed-off-by: Gao Xiang Reviewed-by: Chao Yu Signed-off-by: Chao Yu --- drivers/staging/erofs/erofs_fs.h

[PATCH 2/8] staging: erofs: separate erofs_get_meta_page

riables in order to fulfill 80 character limit. Signed-off-by: Gao Xiang Reviewed-by: Chao Yu Signed-off-by: Chao Yu --- drivers/staging/erofs/Kconfig | 9 ++ drivers/staging/erofs/data.c | 52 --- drivers/staging/erofs/internal.h | 30 +++

[PATCH 1/8] staging: erofs: introduce erofs_grab_bio

From: Gao Xiang this patch renames prepare_bio to erofs_grab_bio, and adds a nofail option in order to retry in the bio allocator under memory pressure. Signed-off-by: Gao Xiang Reviewed-by: Chao Yu Signed-off-by: Chao Yu --- drivers/staging/erofs/data.c | 12 +-- drivers

[PATCH 6/8] staging: erofs: fix vle_decompressed_index_clusterofs

From: Gao Xiang This patch adds error handing code, and fixes a missing endian conversion in vle_decompressed_index_clusterofs. Signed-off-by: Gao Xiang Reviewed-by: Chao Yu Signed-off-by: Chao Yu --- drivers/staging/erofs/unzip_vle.c | 26 +++--- 1 file changed, 15

Re: [PATCH 3/8] staging: erofs: add error handling for xattr submodule

On 2018/8/12 22:01, Chao Yu wrote: > From: Gao Xiang > > This patch enhances the missing error handling code for > xattr submodule, which improves the stability for the rare cases. > > Signed-off-by: Gao Xiang > Reviewed-by: Chao Yu > Signed-off-by: Chao Yu > -

Re: [PATCH 3/8] staging: erofs: add error handling for xattr submodule

Hi Xiang, On 2018/8/13 10:36, Gao Xiang wrote: > Hi Chao, > > On 2018/8/13 10:00, Chao Yu wrote: >> On 2018/8/12 22:01, Chao Yu wrote: >>> From: Gao Xiang >>> >>> This patch enhances the missing error handling code for >>> xattr submodu

Re: [PATCH 2/8] staging: erofs: separate erofs_get_meta_page

On 2018/8/13 19:04, Dan Carpenter wrote: > On Sun, Aug 12, 2018 at 10:01:44PM +0800, Chao Yu wrote: >> --- a/drivers/staging/erofs/data.c >> +++ b/drivers/staging/erofs/data.c >> @@ -39,31 +39,44 @@ static inline void read_endio(struct bio *bio) >> } >> &g

Re: [PATCH 3/8] staging: erofs: add error handling for xattr submodule

On 2018/8/13 20:17, Gao Xiang wrote: >> Generally the rule on likely/unlikely is that they hurt readability so >> we should only add them if it makes a difference in benchmarking. >> > > In my opinion, return values other than 0 and ENOATTR(ENODATA) rarely happens, > it should be in the slow path.

Re: [PATCH] staging: erofs: change 'unsigned' to 'unsigned int'

On 2018/8/13 23:20, Leon Imhof wrote: > Fix coding style issue "Prefer 'unsigned int' to bare use of 'unsigned'" > detected by checkpatch.pl > > Signed-off-by: Leon Imhof Reviewed-by: Chao Yu > --- It would be better to indicate this patch

[PATCH 3/9] staging: erofs: add error handling for xattr submodule

From: Gao Xiang This patch enhances the missing error handling code for xattr submodule, which improves the stability for the rare cases. Signed-off-by: Gao Xiang Reviewed-by: Chao Yu Signed-off-by: Chao Yu --- drivers/staging/erofs/internal.h | 6 +- drivers/staging/erofs/xattr.c

[PATCH 5/9] staging: erofs: rearrange vle clustertype definitions

From: Gao Xiang This patch moves vle clustertype definitions to erofs_fs.h since they are part of on-disk format. It also adds compile time check for Z_EROFS_VLE_DI_CLUSTER_TYPE_BITS Signed-off-by: Gao Xiang Reviewed-by: Chao Yu Signed-off-by: Chao Yu --- drivers/staging/erofs/erofs_fs.h

[PATCH 1/9] staging: erofs: introduce erofs_grab_bio

From: Gao Xiang this patch renames prepare_bio to erofs_grab_bio, and adds a nofail option in order to retry in the bio allocator under memory pressure. Signed-off-by: Gao Xiang Reviewed-by: Chao Yu Signed-off-by: Chao Yu --- drivers/staging/erofs/data.c | 12 +-- drivers

[PATCH 6/9] staging: erofs: fix vle_decompressed_index_clusterofs

From: Gao Xiang This patch adds error handing code, and fixes a missing endian conversion in vle_decompressed_index_clusterofs. Signed-off-by: Gao Xiang Reviewed-by: Chao Yu Signed-off-by: Chao Yu --- drivers/staging/erofs/unzip_vle.c | 26 +++--- 1 file changed, 15

[PATCH 9/9] staging: erofs: fix potential overflow in erofs_grab_bio()

From: Chao Yu As Dan reported in LKP's mailing list: https://lists.01.org/pipermail/kbuild-all/2018-August/051419.html New smatch warnings: drivers/staging/erofs/internal.h:446 erofs_grab_bio() warn: should 'blkaddr << (12 - 9)' be a 64 bit type? drivers/st

[PATCH 7/9] staging: erofs: fix integer overflow on 32-bit platform

From: Gao Xiang This patch fixes integer overflow on multiplication of 32-bit `lcn' in z_erofs_map_blocks_iter. Signed-off-by: Gao Xiang Reviewed-by: Chao Yu Signed-off-by: Chao Yu --- drivers/staging/erofs/unzip_vle.c | 8 1 file changed, 4 insertions(+), 4 deletions(-)

[PATCH 4/9] staging: erofs: cleanup z_erofs_vle_work_{lookup, register}

From: Gao Xiang This patch introduces 'struct z_erofs_vle_work_finder' to clean up arguments of z_erofs_vle_work_lookup and z_erofs_vle_work_register. Signed-off-by: Gao Xiang Reviewed-by: Chao Yu Signed-off-by: Chao Yu --- drivers/staging/erofs/unzip_

[PATCH v2 0/9] staging: erofs: fix some issues and clean up codes

From: Chao Yu This patchset mainly adds error handing code for erofs xattr subsystem. In addition, some code cleanups are also included in this patchset. P.S. Some other patches are still previewing in the linux-erofs mailing list, which will be posted in the 2nd part later. [changelog] v1

[PATCH 8/9] staging: erofs: fix compression mapping beyond EOF

From: Gao Xiang Logical address of EOF LTP mapping should start at `inode->i_size' rather than `inode->i_size - 1' to `m_la(in)', fix it. Signed-off-by: Gao Xiang Reviewed-by: Chao Yu Signed-off-by: Chao Yu --- drivers/staging/erofs/unzip_vle.c | 2 +- 1 file chang

[PATCH 2/9] staging: erofs: separate erofs_get_meta_page

riables in order to fulfill 80 character limit. Signed-off-by: Gao Xiang Reviewed-by: Chao Yu Signed-off-by: Chao Yu --- drivers/staging/erofs/Kconfig | 9 + drivers/staging/erofs/data.c | 58 --- drivers/staging/erofs/internal.h | 30 +

Re: [PATCH] Revert "staging: erofs: disable compiling temporarile"

ay and the new mount apis aren't merged in 4.19-rc1 >>> merge window, the BROKEN mark can be reverted directly without >>> any problems. >>> >>> Fixes: 156c3df8d4db ("staging: erofs: disable compiling temporarile") >>> Cc: Matthew Wilcox

Re: [PATCH] Revert "staging: erofs: disable compiling temporarile"

On 2018/8/28 21:05, Greg Kroah-Hartman wrote: > On Tue, Aug 28, 2018 at 04:56:43PM +0800, Chao Yu wrote: >> Hi Greg, >> >> On 2018/8/28 14:28, Gao Xiang wrote: >>> Hi Greg, >>> >>> On 2018/8/28 13:44, Greg Kroah-Hartman wrote: >>>&g

Re: [PATCH 2/6] staging: erofs: formatting fix to NULL comparison

On 2018/8/31 0:32, Gao Xiang via Linux-erofs wrote: > > > On 2018/8/31 0:09, Gao Xiang via Linux-erofs wrote: >> Hi Pavel, >> >> On 2018/8/30 23:13, Pavel Zemlyanoy wrote: >>> This patch does not change the logic, it only >>> corrects the formatting and checkpatch checks by >>> to NULL comparison

Re: [PATCH 1/6] staging: erofs: formatting fix in unzip_vle_lz4.c

27;unsigned int' to bare use of 'unsigned'" > > Signed-off-by: Pavel Zemlyanoy Reviewed-by: Chao Yu Thanks, ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 2/6] staging: erofs: formatting fix to NULL comparison

-by: Pavel Zemlyanoy Reviewed-by: Chao Yu Thanks, ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 3/6] staging: erofs: formatting spaces around '-'

#x27;". > > Signed-off-by: Pavel Zemlyanoy Reviewed-by: Chao Yu Thanks, ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 5/6] staging: erofs: formatting alignment parenthesis

is". > > Signed-off-by: Pavel Zemlyanoy Reviewed-by: Chao Yu Thanks, ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 4/6] staging: erofs: formatting add spaces arround '*'

. > > Signed-off-by: Pavel Zemlyanoy Reviewed-by: Chao Yu Thanks, ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 6/6] staging: erofs: fix 1 warning and 9 checks

necessary for any arm of this statement". > > Signed-off-by: Pavel Zemlyanoy Reviewed-by: Chao Yu Thanks, ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: erofs: use explicit unsigned int type

Hi, It looks like there is another patch from Pavel Zemlyanoy changing the same place, I think it needs to rebase this patch on that one. [PATCH 1/6] staging: erofs: formatting fix in unzip_vle_lz4.c On 2018/8/31 4:56, Thomas Weißschuh wrote: > Signed-off-by: Thomas Weißschuh > --- > drivers/s

Re: [PATCH 2/6] staging: erofs: formatting fix to NULL comparison

On 2018/8/31 17:41, Dan Carpenter wrote: > On Fri, Aug 31, 2018 at 11:29:03AM +0800, Chao Yu wrote: >> >> Hi Xiang, >> >> I'm not against this change which follows checkpatch's rule, since I think >> this >> can help to unify coding style in

Re: [PATCH 2/2 dhowells/mount-api] staging: erofs: update .mount and .remount_sb

ed-off-by: Gao Xiang Reviewed-by: Chao Yu Thanks, ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

<    1   2   3