Re: [PATCH] staging/most: fix return value for DIM_GetChannelState

2015-08-11 Thread Christian Gromm
On Sun, 9 Aug 2015 17:08:41 +0300 Tomas Melin tomas.me...@iki.fi wrote: Return NULL instead of 0 for invalid input. Signed-off-by: Tomas Melin tomas.me...@iki.fi Acked-by: Christian Gromm christian.gr...@microchip.com --- drivers/staging/most/hdm-dim2/dim2_hal.c | 2 +- 1 file changed, 1

Re: [PATCHv7 1/5] Staging: most: mostcore/core.c. Fix missing static keyword warnings

2015-08-19 Thread Christian Gromm
On Fri, 14 Aug 2015 12:18:00 +0200 Adrian Remonda adrianremo...@gmail.com wrote: This is a patch to the mostcore/core.c file. It makes several local functions and structures static to prevent global visibility. Signed-off-by: Adrian Remonda adrianremo...@gmail.com Acked-by: Christian Gromm

Re: [PATCHv7 4/5] Staging: most: hdm-dim2/dim2_hal.c. Fix Using plain integer as NULL pointer warnings

2015-08-19 Thread Christian Gromm
On Fri, 14 Aug 2015 12:18:03 +0200 Adrian Remonda adrianremo...@gmail.com wrote: This patch fixes the warning generated by sparse: Using plain integer as NULL pointer by replacing the offending 0 with NULL. Signed-off-by: Adrian Remonda adrianremo...@gmail.com ---

Re: [PATCHv7 5/5] Staging: most: aim-cdev/cdev.c. Fix missing static keyword warnings

2015-08-19 Thread Christian Gromm
On Fri, 14 Aug 2015 12:18:04 +0200 Adrian Remonda adrianremo...@gmail.com wrote: This is a patch to the most/aim_cdev.c file. It makes several local functions and structures static to prevent global visibility. Signed-off-by: Adrian Remonda adrianremo...@gmail.com Acked-by: Christian Gromm

Re: [PATCH] Staging: most: Use NULL instead of zero

2015-08-19 Thread Christian Gromm
On Wed, 19 Aug 2015 11:17:09 +0530 Ronit Halder ronit@gmail.com wrote: This patch fixes the warning generated by sparse Using plain integer as NULL pointer by using NULL instead of zero. Signed-off-by: Ronit halder ronit@gmail.com Acked-by: Christian Gromm christian.gr

Re: [PATCHv7 2/5] Staging: most: mostcore/core.c. Fix Using plain integer as NULL pointer warnings

2015-08-19 Thread Christian Gromm
-by: Christian Gromm christian.gr...@microchip.com --- drivers/staging/most/mostcore/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/most/mostcore/core.c b/drivers/staging/most/mostcore/core.c index fa9c19b65a5c..7bb16db42893 100644 --- a/drivers

Re: [PATCHv7 3/5] Staging: most: hdm-usb/hdm_usb.c. Fix missing static keyword warnings

2015-08-19 Thread Christian Gromm
On Fri, 14 Aug 2015 12:18:02 +0200 Adrian Remonda adrianremo...@gmail.com wrote: This is a patch to the most/hdm-usb/hdm_usb.c file. It makes several local functions and structures static to prevent global visibility. Signed-off-by: Adrian Remonda adrianremo...@gmail.com Acked-by: Christian

Re: [PATCH 2/3] staging: most: core.c: remove semicolon at the end of define statement

2015-07-28 Thread Christian Gromm
On Mon, 27 Jul 2015 10:31:09 +0900 Chaehyun Lim chaehyun@gmail.com wrote: Remove semicolon at the end of define statement to fix checkpatch warning. WARNING: macros should not use a trailing semicolon Signed-off-by: Chaehyun Lim chaehyun@gmail.com Acked-by: Christian Gromm

Re: [staging:staging-testing 413/420] drivers/staging/most/aim-cdev/cdev.c:128 aim_close() error: dereferencing freed memory 'channel'

2015-07-28 Thread Christian Gromm
://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git git remote update staging git checkout 9bc79bbcd0c526e3ec7b98e08c5d34648bb3c158 vim +/channel +128 drivers/staging/most/aim-cdev/cdev.c 9bc79bbcd Christian Gromm 2015-07-24 122 atomic_dec(channel-access_ref); 9bc79bbcd

Re: [PATCH -next] staging: most: fix aim-network build errors

2015-07-29 Thread Christian Gromm
: eth_mac_addr [drivers/staging/most/aim-network/aim_network.ko] undefined! Signed-off-by: Randy Dunlap rdun...@infradead.org Acked-by: Christian Gromm christian.gr...@microchip.com Cc: Andrey Shvetsov andrey.shvet...@k2l.de To: Christian Gromm christian.gr...@microchip.com Cc: Michael Fabry

[PATCH 3/3] Staging: most: replace min() by min_t()

2015-07-30 Thread Christian Gromm
This patch fixes wrong casting. Reported-by: Dan Carpenter dan.carpen...@oracle.com Signed-off-by: Christian Gromm christian.gr...@microchip.com --- drivers/staging/most/mostcore/core.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/most/mostcore

[PATCH 2/3] Staging: most: fix doing DMA on stack

2015-07-30 Thread Christian Gromm
This patch fixes error doing DMA on the stack by using kzalloc for buffer allocation. Reported-by: Dan Carpenter dan.carpen...@oracle.com Signed-off-by: Christian Gromm christian.gr...@microchip.com --- drivers/staging/most/hdm-usb/hdm_usb.c | 39 +--- 1 file

[PATCH 1/3] Staging: most: fix double unlock

2015-07-30 Thread Christian Gromm
This patch fixes double unlocking of a spinlock the aim-v4l2 module. Reported-by: Dan Carpenter dan.carpen...@oracle.com Signed-off-by: Christian Gromm christian.gr...@microchip.com Signed-off-by: Andrey Shvetsov andrey.shvet...@k2l.de --- drivers/staging/most/aim-v4l2/video.c |1 + 1 file

Re: [PATCH] Staging: most: replace pr_*() functions by dev_*()

2015-08-01 Thread Christian Gromm
On Fri, 31 Jul 2015 17:14:32 +0530 Sudip Mukherjee sudipm.mukher...@gmail.com wrote: On Thu, Jul 30, 2015 at 06:19:41PM +0200, Christian Gromm wrote: This patch replaces pr_*() functions with dev_*(). Reported-by: Greg Kroah-Hartman gre...@linuxfoundation.org Signed-off-by: Christian

[PATCH 3/4] Staging: most: fix dereferencing freed memory

2015-07-28 Thread Christian Gromm
This patch fixes the dereferencing of freed memory. Reported-by: Dan Carpenter dan.carpen...@oracle.com Signed-off-by: Christian Gromm christian.gr...@microchip.com --- drivers/staging/most/aim-cdev/cdev.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging

[PATCH 1/4] Staging: most: fix bad min() casting

2015-07-28 Thread Christian Gromm
This patch fixes wrong casting. A high value of len is casted to negative and thus the minimum resulting in memory corruption. Reported-by: Dan Carpenter dan.carpen...@oracle.com Signed-off-by: Christian Gromm christian.gr...@microchip.com --- drivers/staging/most/mostcore/core.c |4 ++-- 1

[PATCH 4/4] Staging: most: fix passing a potential null pointer

2015-07-28 Thread Christian Gromm
This patch fixes passing of a potential null pointer. Reported-by: Dan Carpenter dan.carpen...@oracle.com Signed-off-by: Christian Gromm christian.gr...@microchip.com --- drivers/staging/most/aim-cdev/cdev.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging

Re: [PATCHv5 3/5] Staging: most: hdm-usb/hdm_usb.c. Fix missing static keyword warnings

2015-08-05 Thread Christian Gromm
On Tue, 4 Aug 2015 20:44:53 +0200 Adrian Remonda adrianremo...@gmail.com wrote: This is a patch to the most/hdm-usb/hdm_usb.c file. It makes several local functions and structures static to prevent global visibility. Signed-off-by: Adrian Remonda adrianremo...@gmail.com ---

Re: [PATCHv3 3/6] Staging: most: Fix missing static keyword warnings

2015-08-03 Thread Christian Gromm
On Mon, 3 Aug 2015 09:40:24 +0200 Adrian Remonda adrianremo...@gmail.com wrote: This is a patch to the most/hdm-usb/hdm_usb.c file. It makes several local functions and structures static to prevent global visibility. Signed-off-by: Adrian Remonda adrianremo...@gmail.com ---

Re: [PATCH 1/1] linux-next: drivers: staging: most: Fix return value

2015-08-01 Thread Christian Gromm
On Fri, 31 Jul 2015 22:18:17 +0200 Michael Hornung mhornung.li...@gmail.com wrote: * Fix sparse warning Using plain integer as NULL pointer Signed-off-by: Michael Hornung mhornung.li...@gmail.com Acked-by: Christian Gromm christian.gr...@microchip.com --- drivers/staging/most/aim-network

Re: [PATCH -next] staging: most: fix aim-sound build errors

2015-08-03 Thread Christian Gromm
to `snd_pcm_set_ops' drivers/built-in.o:(.data+0x952d0): undefined reference to `snd_pcm_lib_ioctl' drivers/built-in.o:(.data+0x95318): undefined reference to `snd_pcm_lib_get_vmalloc_page' Signed-off-by: Randy Dunlap rdun...@infradead.org Acked-by: Christian Gromm christian.gr...@microchip.com Cc

[PATCH] Staging: most: avoid possible integer overflow

2015-08-03 Thread Christian Gromm
This patch prevents a potential integer overlow. Reported-by: Dan Carpenter dan.carpen...@oracle.com Signed-off-by: Christian Gromm christian.gr...@microchip.com --- drivers/staging/most/mostcore/core.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/most

Re: [PATCH 2/4] Staging: most: fix snprintf() is printing too much

2015-07-30 Thread Christian Gromm
On Wed, 29 Jul 2015 11:53:34 +0530 Sudip Mukherjee sudipm.mukher...@gmail.com wrote: On Tue, Jul 28, 2015 at 05:16:09PM +0200, Christian Gromm wrote: This patch prevents snprintf from exceeding a given buffer size. Reported-by: Dan Carpenter dan.carpen...@oracle.com Signed-off

Re: [PATCH 2/4] Staging: most: fix snprintf() is printing too much

2015-07-30 Thread Christian Gromm
On Thu, 30 Jul 2015 11:28:43 +0300 Dan Carpenter dan.carpen...@oracle.com wrote: On Thu, Jul 30, 2015 at 09:05:39AM +0200, Christian Gromm wrote: On Wed, 29 Jul 2015 11:53:34 +0530 Sudip Mukherjee sudipm.mukher...@gmail.com wrote: On Tue, Jul 28, 2015 at 05:16:09PM +0200, Christian

[PATCH] Staging: most: replace pr_*() functions by dev_*()

2015-07-30 Thread Christian Gromm
This patch replaces pr_*() functions with dev_*(). Reported-by: Greg Kroah-Hartman gre...@linuxfoundation.org Signed-off-by: Christian Gromm christian.gr...@microchip.com --- drivers/staging/most/hdm-usb/hdm_usb.c | 116 1 file changed, 59 insertions(+), 57

[PATCH v2] Staging: most: fix doing DMA on stack

2015-07-30 Thread Christian Gromm
This patch fixes error doing DMA on the stack by using kzalloc for buffer allocation. Reported-by: Dan Carpenter dan.carpen...@oracle.com Signed-off-by: Christian Gromm christian.gr...@microchip.com --- drivers/staging/most/hdm-usb/hdm_usb.c | 36 1 file

Re: [PATCHv6 3/5] Staging: most: hdm-usb/hdm_usb.c. Fix missing static keyword warnings

2015-08-06 Thread Christian Gromm
On Thu, 6 Aug 2015 19:34:58 +0200 Adrian Remonda adrianremo...@gmail.com wrote: This is a patch to the most/hdm-usb/hdm_usb.c file. It makes several local functions and structures static to prevent global visibility. v6: fixed alignment with parameter list of a function. Signed-off-by:

Re: [PATCHv6 3/5] Staging: most: hdm-usb/hdm_usb.c. Fix missing static keyword warnings

2015-08-07 Thread Christian Gromm
On Fri, 7 Aug 2015 09:40:03 +0200 AdrianRemonda adrianremo...@gmail.com wrote: On Thu, Aug 06, 2015 at 11:57:28PM +0200, Christian Gromm wrote: On Thu, 6 Aug 2015 19:34:58 +0200 Adrian Remonda adrianremo...@gmail.com wrote: This is a patch to the most/hdm-usb/hdm_usb.c file

[PATCH 8/9] Staging: most: add MOST driver's hdm-usb module

2015-07-24 Thread Christian Gromm
controller. Signed-off-by: Christian Gromm christian.gr...@microchip.com --- drivers/staging/most/Kconfig |2 + drivers/staging/most/Makefile |1 + drivers/staging/most/hdm-usb/Kconfig | 14 + drivers/staging/most/hdm-usb/Makefile |4 + drivers/staging/most/hdm-usb

[PATCH 7/9] Staging: most: add MOST driver's hdm-i2c module

2015-07-24 Thread Christian Gromm
controller. Signed-off-by: Christian Gromm christian.gr...@microchip.com --- drivers/staging/most/Kconfig |2 + drivers/staging/most/Makefile |1 + drivers/staging/most/hdm-i2c/Kconfig | 12 + drivers/staging/most/hdm-i2c/Makefile |3 + drivers/staging/most/hdm-i2c

[PATCH 6/9] Staging: most: add MOST driver's hdm-dim2 module

2015-07-24 Thread Christian Gromm
interface controller. Signed-off-by: Christian Gromm christian.gr...@microchip.com --- drivers/staging/most/Kconfig|2 + drivers/staging/most/Makefile |1 + drivers/staging/most/hdm-dim2/Kconfig | 15 + drivers/staging/most/hdm-dim2/Makefile |5

[PATCH 0/9] Staging: most: Patchset to add Microchip's MOST driver to kernel 4.1.2

2015-07-24 Thread Christian Gromm
Interface Controller (INIC) is needed. For more information on available controllers visit: www.microchip.com Christian Gromm (9): Staging: most: add MOST driver's core module Staging: most: add MOST driver's aim-cdev module Staging: most: add MOST driver's aim-network module Staging: most: add

[PATCH 1/9] Staging: most: add MOST driver's core module

2015-07-24 Thread Christian Gromm
This patch adds the core module of the MOST driver to the kernel's driver staging area. This module is part of the MOST driver and handles the configuration interface in sysfs, the buffer management and the data routing. Signed-off-by: Christian Gromm christian.gr...@microchip.com

[PATCH 4/9] Staging: most: add MOST driver's aim-sound module

2015-07-24 Thread Christian Gromm
-by: Christian Gromm christian.gr...@microchip.com --- drivers/staging/most/Kconfig|2 + drivers/staging/most/Makefile |1 + drivers/staging/most/aim-sound/Kconfig | 12 + drivers/staging/most/aim-sound/Makefile |4 + drivers/staging/most/aim-sound/sound.c

[PATCH 2/9] Staging: most: add MOST driver's aim-cdev module

2015-07-24 Thread Christian Gromm
-by: Christian Gromm christian.gr...@microchip.com --- drivers/staging/most/Kconfig |2 + drivers/staging/most/Makefile |1 + drivers/staging/most/aim-cdev/Kconfig | 12 + drivers/staging/most/aim-cdev/Makefile |4 + drivers/staging/most/aim-cdev/cdev.c | 527

[PATCH 5/9] Staging: most: add MOST driver's aim-v4l2 module

2015-07-24 Thread Christian Gromm
-by: Christian Gromm christian.gr...@microchip.com --- drivers/staging/most/Kconfig |2 + drivers/staging/most/Makefile |1 + drivers/staging/most/aim-v4l2/Kconfig | 12 + drivers/staging/most/aim-v4l2/Makefile |6 + drivers/staging/most/aim-v4l2/video.c | 634

[PATCH 3/9] Staging: most: add MOST driver's aim-network module

2015-07-24 Thread Christian Gromm
device. Signed-off-by: Christian Gromm christian.gr...@microchip.com --- drivers/staging/most/Kconfig |2 + drivers/staging/most/Makefile |1 + drivers/staging/most/aim-network/Kconfig | 12 + drivers/staging/most/aim-network/Makefile |4

[PATCH 04/13] staging: most: remove multiple assignment

2015-10-21 Thread Christian Gromm
This patch removes multiple assignments as specified in coding style. Signed-off-by: Christian Gromm <christian.gr...@microchip.com> --- drivers/staging/most/hdm-dim2/dim2_hal.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/most/hdm-dim2/dim2_ha

[PATCH 11/13] staging: most: use preferred kernel types

2015-10-21 Thread Christian Gromm
This patch makes use of the preferred kernel types such as u16, u32. Signed-off-by: Christian Gromm <christian.gr...@microchip.com> --- drivers/staging/most/aim-network/networking.c |2 +- drivers/staging/most/hdm-i2c/hdm_i2c.c|2 +- drivers/staging/most/mostcore/

[PATCH 01/13] staging: most: remove multiple blank lines

2015-10-21 Thread Christian Gromm
This patch removes the usage of multiple blank lines from driver modules. Signed-off-by: Christian Gromm <christian.gr...@microchip.com> --- drivers/staging/most/aim-network/networking.c |4 drivers/staging/most/aim-sound/sound.c|1 - drivers/staging/most/aim-v4l2/v

[PATCH 00/13] staging: most: remove coding style violations

2015-10-21 Thread Christian Gromm
This patchset removes warnings generated by checkpatch. Christian Gromm (13): staging: most: remove multiple blank lines staging: most: put spaces around operator staging: most: removed redundant code staging: most: remove multiple assignment staging: most: make alignment match open

[PATCH 09/13] staging: most: remove unnecessary parentheses

2015-10-21 Thread Christian Gromm
This patch simply removes unnecessary parentheses. Signed-off-by: Christian Gromm <christian.gr...@microchip.com> --- drivers/staging/most/hdm-dim2/dim2_hdm.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/most/hdm-dim2/dim2_hdm.c b/drivers/stagin

[PATCH 03/13] staging: most: removed redundant code

2015-10-21 Thread Christian Gromm
This patch removes redundant code. Signed-off-by: Christian Gromm <christian.gr...@microchip.com> --- drivers/staging/most/aim-v4l2/video.c| 22 -- drivers/staging/most/hdm-dim2/dim2_hal.c | 16 2 files changed, 38 deletions(-) diff --git a/d

[PATCH 13/13] staging: most: remove comparison to NULL

2015-10-21 Thread Christian Gromm
Signed-off-by: Christian Gromm <christian.gr...@microchip.com> --- drivers/staging/most/hdm-usb/hdm_usb.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/most/hdm-usb/hdm_usb.c b/drivers/staging/most/hdm-usb/hdm_usb.c index 747d22e..b5fb1a7

[PATCH 05/13] staging: most: make alignment match open parenthesis

2015-10-21 Thread Christian Gromm
This patch fixes coding style violations by making alignments match open parenthesis. Signed-off-by: Christian Gromm <christian.gr...@microchip.com> --- drivers/staging/most/aim-cdev/cdev.c |2 +- drivers/staging/most/hdm-dim2/dim2_hal.c |2 +- drivers/staging/most/hd

[PATCH 08/13] staging: most: remove blank lines

2015-10-21 Thread Christian Gromm
This patch removes blank lines after an open brace as specified in coding style. Signed-off-by: Christian Gromm <christian.gr...@microchip.com> --- drivers/staging/most/hdm-dim2/dim2_hdm.c |2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/most/hdm-dim2/dim2_hdm.c b/d

[PATCH 10/13] staging: most: fix logical operator position

2015-10-21 Thread Christian Gromm
This patch puts logical continuations on the previous line to meet coding style. Signed-off-by: Christian Gromm <christian.gr...@microchip.com> --- drivers/staging/most/aim-cdev/cdev.c |7 +++ drivers/staging/most/mostcore/core.c |4 ++-- 2 files changed, 5 insertions(+), 6 del

[PATCH 12/13] staging: most: use preferred kzalloc parameters

2015-10-21 Thread Christian Gromm
This patch uses the preferred call to kzalloc. It replaces kzalloc(sizeof(struct aim_fh)...) by kzalloc(sizeof(*fh)...). Signed-off-by: Christian Gromm <christian.gr...@microchip.com> --- drivers/staging/most/aim-v4l2/video.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH 06/13] staging: most: use braces on all arms of statement

2015-10-21 Thread Christian Gromm
This patch fixes style issues regarding braces on all arms of a statement. Signed-off-by: Christian Gromm <christian.gr...@microchip.com> --- drivers/staging/most/hdm-dim2/dim2_hdm.c |4 ++-- drivers/staging/most/hdm-i2c/hdm_i2c.c |3 ++- drivers/staging/most/hdm-usb/hdm_usb.c

[PATCH 07/13] staging: most: use blank line after declarations

2015-10-21 Thread Christian Gromm
This patch fixes style violation regarding blank lines after function/struct/union/enum declarations. Signed-off-by: Christian Gromm <christian.gr...@microchip.com> --- drivers/staging/most/aim-cdev/cdev.c |1 + drivers/staging/most/hdm-usb/hdm_usb.c |4 drivers/stagin

[PATCH] staging: most: hdm-dim2: use min_t()

2015-10-28 Thread Christian Gromm
This patch replaces the usage of min() by min_t(). Signed-off-by: Christian Gromm <christian.gr...@microchip.com> --- drivers/staging/most/hdm-dim2/dim2_hdm.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/most/hdm-dim2/dim2_hdm.c b/drivers/stagin

[PATCH] staging: most: remove exclusive wait_queue

2015-10-28 Thread Christian Gromm
This patch removes the unnecessary wait_queue that has exclusively been used for the poll function and its poll_table. Instead, an already existing one is used. Signed-off-by: Christian Gromm <christian.gr...@microchip.com> --- drivers/staging/most/aim-cdev/cdev.c |4 +--- 1 file chan

Re: [PATCH] staging: most: hdm-usb: Use setup_timer

2015-10-28 Thread Christian Gromm
er(); > +setup_timer(, fn_ptr, e2); > ... when != fn_ptr = e3 > -e1.function = fn_ptr; > -e1.data = e2; > > > > Signed-off-by: Muhammad Falak R Wani <falakre...@gmail.com> Acked-by: Christian Gromm <christian.gr...@microchip.com> > --- > drivers/sta

[PATCH 05/10] staging: most: fix checkpatch issues of hdm i2c

2015-10-15 Thread Christian Gromm
This patch fixes the issues of HDM module i2c found by checkpatch.pl Signed-off-by: Christian Gromm <christian.gr...@microchip.com> --- drivers/staging/most/hdm-i2c/hdm_i2c.c |9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/staging/most/hdm-i2c/hdm_i2

[PATCH 06/10] staging: most: make hdm-usb follow the coding style

2015-10-15 Thread Christian Gromm
This patch fixes a couple of issues of the hdm-usb module found by checkpatch.pl. Signed-off-by: Christian Gromm <christian.gr...@microchip.com> --- drivers/staging/most/hdm-usb/hdm_usb.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/stagin

[PATCH 00/10] staging: most: fix checkpatch issues

2015-10-15 Thread Christian Gromm
This patchset is needed to remove warnings generated by checkpatch. Christian Gromm (9): staging: most: correct coding style breaches staging: most: fix usage of false data type staging: most: remove constants from comparisons staging: most: fix checkpatch issues of hdm i2c staging

[PATCH 09/10] staging: most: change parameter description

2015-10-15 Thread Christian Gromm
This patch changes the description of a function parameter for a better understanding. Signed-off-by: Christian Gromm <christian.gr...@microchip.com> --- drivers/staging/most/mostcore/mostcore.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/most/mo

[PATCH 04/10] staging: most: remove constants from comparisons

2015-10-15 Thread Christian Gromm
This patch removes constants from comparisons and fixes checkpatch warnings about constants being put in the wrong place inside a comparison. Signed-off-by: Christian Gromm <christian.gr...@microchip.com> --- drivers/staging/most/aim-cdev/cdev.c |4 ++-- 1 file changed, 2 insertions

[PATCH 07/10] staging: most: fix misplaced constants in comparisons

2015-10-15 Thread Christian Gromm
This patch removes and fixes constants being misplaced in comparisons. Signed-off-by: Christian Gromm <christian.gr...@microchip.com> --- drivers/staging/most/mostcore/core.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/most/mostcore/cor

[PATCH 10/10] staging: most: fix line-over-80-characters violations

2015-10-15 Thread Christian Gromm
This patch prevents code from crossing the 80 character margin. Signed-off-by: Christian Gromm <christian.gr...@microchip.com> --- drivers/staging/most/aim-network/networking.c |3 ++- drivers/staging/most/hdm-dim2/dim2_hdm.h |3 ++- drivers/staging/most/mostcore/

[PATCH 08/10] staging: most: replace memcpy by ether_addr_copy

2015-10-15 Thread Christian Gromm
This patch replaces memcpy() by the preferred function ether_addr_copy(). Signed-off-by: Christian Gromm <christian.gr...@microchip.com> --- drivers/staging/most/aim-network/networking.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/most/aim-n

[PATCH 03/10] staging: most: fix style issue in aim-cdev/cdev.c

2015-10-15 Thread Christian Gromm
From: Gavin Thomas Claugus <gclau...@gmail.com> Fix 80+ character line in cdev.c to stop checkpatch.pl from raising a warning. Signed-off-by: Gavin Thomas Claugus <gclau...@gmail.com> Signed-off-by: Christian Gromm <christian.gr...@microchip.com> --- drivers/staging/most/aim-

[PATCH 02/10] staging: most: fix usage of false data type

2015-10-15 Thread Christian Gromm
This patch changes the data type from u32 to u16 used for temporary variable. It is needed to stay in the correct range and get rid of the unnecessary cast. Signed-off-by: Christian Gromm <christian.gr...@microchip.com> --- drivers/staging/most/hdm-dim2/dim2_hdm.c |6 +++--- 1 file c

[PATCH 01/10] staging: most: correct coding style breaches

2015-10-15 Thread Christian Gromm
This patch fixes line-over-80-characters violation and removes the splitting of quoted strings. Signed-off-by: Christian Gromm <christian.gr...@microchip.com> --- drivers/staging/most/hdm-dim2/dim2_hal.c | 21 - drivers/staging/most/hdm-dim2/dim2_hdm.c

Re: [PATCH] Staging: most: MOST and MOSTCORE should depend on HAS_DMA

2015-09-07 Thread Christian Gromm
re/mostcore.ko] > undefined! > > As all MOST sub drivers use DMA functionality, add a dependency on > HAS_DMA to MOSTCORE, and to MOST, which selects MOSTCORE. > > Signed-off-by: Geert Uytterhoeven <ge...@linux-m68k.org> Acked-by: Christian Gromm <christian.gr.

[PATCH] staging: most: Add dependency to HAS_IOMEM

2015-09-16 Thread Christian Gromm
This patch prevents the module hdm_dim2 from breaking the build in case HAS_IOMEM is not configured. Reported-by: <fengguang...@intel.com> Signed-off-by: Christian Gromm <christian.gr...@microchip.com> --- drivers/staging/most/hdm-dim2/Kconfig |1 + 1 file changed, 1 insertion(+)

[PATCH 27/29] staging: most: remove audio resolution format check

2015-09-28 Thread Christian Gromm
This patch removes the audio format cross-check, because the definitions are not compatible. Signed-off-by: Christian Gromm <christian.gr...@microchip.com> --- drivers/staging/most/aim-sound/sound.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/mo

[PATCH 24/29] staging: most: rename function

2015-09-28 Thread Christian Gromm
This patch renames the function audio_set_pcm_format(). Since the function doesn't only set the PCM format anymore and to guard against misunderstandings, its name needs to be changed. Signed-off-by: Christian Gromm <christian.gr...@microchip.com> --- drivers/staging/most/aim-sound/s

[PATCH 21/29] staging: most: squash AIM sound

2015-09-28 Thread Christian Gromm
This patch removes debug messages and prevents the sound AIM from being noisy in kernel log. Signed-off-by: Christian Gromm <christian.gr...@microchip.com> --- drivers/staging/most/aim-sound/sound.c | 14 -- 1 file changed, 14 deletions(-) diff --git a/drivers/staging/mo

[PATCH 13/29] staging: most: simplify code

2015-09-28 Thread Christian Gromm
This patch simply rearranges code for better readability. Signed-off-by: Andrey Shvetsov <andrey.shvet...@k2l.de> Signed-off-by: Christian Gromm <christian.gr...@microchip.com> --- drivers/staging/most/hdm-usb/hdm_usb.c | 17 - 1 file changed, 8 insertions(+),

[PATCH 19/29] staging: most: include vendor in audio card's shortname

2015-09-28 Thread Christian Gromm
This patch adds Microchip as vendor to the audio card's shortname to be displayed, when playback and capture devices are queried. Signed-off-by: Christian Gromm <christian.gr...@microchip.com> --- drivers/staging/most/aim-sound/sound.c |2 +- 1 file changed, 1 insertion(+), 1 de

[PATCH 29/29] staging: most: fix pcm_write input/output error

2015-09-28 Thread Christian Gromm
This patch keeps the process from sleeping after the PCM middle layer has stopped playback by calling the pcm trigger callback. The patch is needed to prevent aplay from causing a pcm_write Input/Output error. Signed-off-by: Christian Gromm <christian.gr...@microchip.com> --- drivers/s

[PATCH 25/29] staging: most: move initialization code

2015-09-28 Thread Christian Gromm
This pathch moves the initialization of the PCM middle layer hardware parameters to function audio_set_hw_params(). Signed-off-by: Christian Gromm <christian.gr...@microchip.com> --- drivers/staging/most/aim-sound/sound.c | 28 ++-- 1 file changed, 10 insertions(

[PATCH 18/29] staging: most: add multi channel support to sound AIM

2015-09-28 Thread Christian Gromm
This patch adds 5.1 surround configuration with subbuffer cross-check, when establishing a link to the core. For the sake of simplicity, only one specific channel configuration is allowed. Signed-off-by: Christian Gromm <christian.gr...@microchip.com> --- drivers/staging/most/aim-sound/s

[PATCH 26/29] staging: most: fix style problems

2015-09-28 Thread Christian Gromm
This patch simply corrects style violations. Signed-off-by: Christian Gromm <christian.gr...@microchip.com> --- drivers/staging/most/aim-sound/sound.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/most/aim-sound/sound.c b/drivers/staging/mo

[PATCH 17/29] staging: most: refactor channel structure

2015-09-28 Thread Christian Gromm
The struct most_c_obj has the same set of attributes for each of two AIMs. This patch cleans up the code by introducing the new struct most_c_aim_obj hat contains those fields. Signed-off-by: Christian Gromm <christian.gr...@microchip.com> --- drivers/staging/most/mostcore/core.c

[PATCH 05/29] staging: most: fix USB babble on IN pipe

2015-09-28 Thread Christian Gromm
This patch prevents the HDM USB from submitting an URB with a buffer size unaligned to 512 bytes to the USB subsystem. Signed-off-by: Andrey Shvetsov <andrey.shvet...@k2l.de> Signed-off-by: Christian Gromm <christian.gr...@microchip.com> --- drivers/staging/most/hdm-usb/hdm_usb.c |

[PATCH 20/29] staging: most: make hardware parameters channel exclusive

2015-09-28 Thread Christian Gromm
Since the PCM interface's hardware parameters are channel/substream exclusive, the struct snd_pcm_hardware needs to be embedded in the channel structure. Signed-off-by: Christian Gromm <christian.gr...@microchip.com> --- drivers/staging/most/aim-sound/sound.c

[PATCH 28/29] staging: most: add poll syscall to AIM cdev

2015-09-28 Thread Christian Gromm
This patch adds the implementation of the poll syscall to the AIM cdev. To have the full functionality, a helper function is needed in the core module to retrieve the instantaneous availability of tx buffers. Signed-off-by: Christian Gromm <christian.gr...@microchip.com> --- drivers/stagin

[PATCH 23/29] staging: most: add missing channel initialization

2015-09-28 Thread Christian Gromm
This patch adds missing initialization of channel count for 8-bit mono audio resolution. Signed-off-by: Christian Gromm <christian.gr...@microchip.com> --- drivers/staging/most/aim-sound/sound.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/most/aim-sound/soun

[PATCH 14/29] staging: most: prevent DMA on stack

2015-09-28 Thread Christian Gromm
This patch is needed to avoid having DMA on the stack. Signed-off-by: Andrey Shvetsov <andrey.shvet...@k2l.de> Signed-off-by: Christian Gromm <christian.gr...@microchip.com> --- drivers/staging/most/hdm-usb/hdm_usb.c | 26 -- 1 file changed, 16 inser

[PATCH 22/29] staging: most: purge unecessary variable

2015-09-28 Thread Christian Gromm
This patch purges a temp. variable to store the functions return value. Since the content is never being evaluated, it can safely be removed. Signed-off-by: Christian Gromm <christian.gr...@microchip.com> --- drivers/staging/most/aim-sound/sound.c |5 + 1 file changed, 1 insertion

[PATCH 06/29] staging: most: fix channel operation in multi-aim context

2015-09-28 Thread Christian Gromm
This patch fixes the opening and closing process of a physical channel when used by different AIMs. Signed-off-by: Andrey Shvetsov <andrey.shvet...@k2l.de> Signed-off-by: Christian Gromm <christian.gr...@microchip.com> --- drivers/staging/most/aim-cdev/cdev.c |5 +- dri

[PATCH 12/29] staging: most: fix MAC address representation

2015-09-28 Thread Christian Gromm
This patch fixes the representation of the MAC address within the HDM USB module. Signed-off-by: Andrey Shvetsov <andrey.shvet...@k2l.de> Signed-off-by: Christian Gromm <christian.gr...@microchip.com> --- drivers/staging/most/hdm-usb/hdm_usb.c | 24 1 file

[PATCH 15/29] staging: most: consolidate code

2015-09-28 Thread Christian Gromm
<andrey.shvet...@k2l.de> Signed-off-by: Christian Gromm <christian.gr...@microchip.com> --- drivers/staging/most/hdm-usb/hdm_usb.c |8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/staging/most/hdm-usb/hdm_usb.c b/drivers/staging/most/hdm-usb/hdm_usb.c i

[PATCH 00/29] staging: most: update driver

2015-09-28 Thread Christian Gromm
This patchset is needed to pull Microchip's latest driver changes into the staging tree. The patches include bug fixes, feature updates and coding style changes. Christian Gromm (29): staging: most: change structure initialization staging: most: remove aim reset staging: most: fix race

[PATCH 04/29] staging: most: remove shared IRQ request

2015-09-28 Thread Christian Gromm
Since there is no way find out whether the INIC has generated an interrupt, the I2C interrupt must not be registered as a shared interrupt. Reported-by: PrasannaKumar Muralidharan <prasannakumar.muraidha...@microchip.com> Signed-off-by: Christian Gromm <christian.gr...@micr

[PATCH 03/29] staging: most: fix race condition in AIM networking

2015-09-28 Thread Christian Gromm
-off-by: Andrey Shvetsov <andrey.shvet...@k2l.de> Signed-off-by: Christian Gromm <christian.gr...@microchip.com> --- drivers/staging/most/aim-network/networking.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/staging/most/aim-network/networking.c b/drivers/staging/most

[PATCH 07/29] staging: most: remove unnecessary field initialization

2015-09-28 Thread Christian Gromm
Since conf->extra_len has already been reset in most_start_channel() when function hdm_configure_channel() gets called, it can safely be removed here. Signed-off-by: Christian Gromm <christian.gr...@microchip.com> --- drivers/staging/most/hdm-usb/hdm_usb.c |1 - 1 file changed, 1

[PATCH 09/29] staging: most: fix buffer synchronization request

2015-09-28 Thread Christian Gromm
Revision D of OS81118 network interface controller have the internal buffer synchronization mechanism changed. This patch adapts the driver to this. Signed-off-by: Christian Gromm <christian.gr...@microchip.com> --- drivers/staging/most/hdm-usb/hdm_usb.c

[PATCH 10/29] staging: most: remove macro cpu_to_le16

2015-09-28 Thread Christian Gromm
This patch removes the wrongly used macros cpu_to_le16 Signed-off-by: Christian Gromm <christian.gr...@microchip.com> --- drivers/staging/most/hdm-usb/hdm_usb.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/most/hdm-usb/hdm_usb.c b/d

[PATCH 08/29] staging: most: remove dead code

2015-09-28 Thread Christian Gromm
The case where the channel type is neither synchronous nor isochronous is already covered by a previous condition. Signed-off-by: Christian Gromm <christian.gr...@microchip.com> --- drivers/staging/most/hdm-usb/hdm_usb.c |6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/s

[PATCH 11/29] staging: most: fix buffer size for DIM2

2015-09-28 Thread Christian Gromm
This patch reduces the DBR buffer size to prevent an overflow in the DIM2 module. It is needed, because the MediaLB hardware has problems with DBR buffers that exceed the size of 255 messages. Signed-off-by: Andrey Shvetsov <andrey.shvet...@k2l.de> Signed-off-by: Christian Gromm <chr

[PATCH 01/29] staging: most: change structure initialization

2015-09-28 Thread Christian Gromm
By applying this patch the initialization of the most_aim structure is performed at compile time. Signed-off-by: Andrey Shvetsov <andrey.shvet...@k2l.de> Signed-off-by: Christian Gromm <christian.gr...@microchip.com> --- drivers/staging/most/aim-network/network

[PATCH 16/29] staging: most: add fair buffer distribution

2015-09-28 Thread Christian Gromm
-by: Andrey Shvetsov <andrey.shvet...@k2l.de> Signed-off-by: Christian Gromm <christian.gr...@microchip.com> --- drivers/staging/most/aim-cdev/cdev.c |5 +++-- drivers/staging/most/aim-network/networking.c |2 +- drivers/staging/most/aim-sound/sound.c|3

[PATCH 02/29] staging: most: remove aim reset

2015-09-28 Thread Christian Gromm
Shvetsov <andrey.shvet...@k2l.de> Signed-off-by: Christian Gromm <christian.gr...@microchip.com> --- drivers/staging/most/mostcore/core.c |5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/most/mostcore/core.c b/drivers/staging/most/mostcore/core.c index eb4e

[PATCH 15/28] staging: most: remove tainted flag

2015-12-22 Thread Christian Gromm
This patch removes the atomic tainted flag. It is needed to get rid of logical overhead. Signed-off-by: Christian Gromm <christian.gr...@microchip.com> --- This patch has been resent on behalf of Greg Kroah-Hartman <gre...@linuxfoundation.org> drivers/staging/most/mostcore/c

[PATCH 18/28] staging: most: remove redundant mutexes

2015-12-22 Thread Christian Gromm
This patch removes the mutexes stop_task_mutex and deregister mutex, since they can safely be left out. Signed-off-by: Christian Gromm <christian.gr...@microchip.com> --- This patch has been resent on behalf of Greg Kroah-Hartman <gre...@linuxfoundation.org> drivers/staging/m

[PATCH 25/28] staging: most: remove stacked_mbo

2015-12-22 Thread Christian Gromm
This patch makes use of kfifo_peek and kfifo_skip, which renders the variable stacked_mbo useless. It is therefore removed. Signed-off-by: Christian Gromm <christian.gr...@microchip.com> --- This patch has been resent on behalf of Greg Kroah-Hartman <gre...@linuxfoundation.org> dri

[PATCH 21/28] staging: most: fix retrieval of buffer availability

2015-12-22 Thread Christian Gromm
This patch fixes the function channel_has_mbo that delivers the false information in case two AIMs are using the same tx channel. Signed-off-by: Christian Gromm <christian.gr...@microchip.com> --- This patch has been resent on behalf of Greg Kroah-Hartman <gre...@linuxfoundation.org&g

  1   2   3   4   5   6   7   8   >