that, although
documented in the kernel source tree, cannot be changed in incompatible
ways as time progresses.
David Daney
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
altogether as it has issues
like packet reordering and potential problems with CPU offlining/onlining.
There are packet ordering issues with the current code, it does however
give fairly high packet forwarding rates. Probably better than with RPS.
So removing this may decrease performance.
David
On 11/07/2014 02:32 PM, Aaro Koskinen wrote:
Hi,
On Fri, Nov 07, 2014 at 01:17:23PM -0800, David Daney wrote:
On 11/07/2014 12:44 PM, Aaro Koskinen wrote:
Octeon Ethernet driver is currently trying to wake up multiple
CPU cores for parallel NAPI processing when needed, to cope
with the fact
driver have
been fixed, I have no problem with making OCTEON work with that driver.
Otherwise, to say that octeon-usb has shortcomings is a bit disingenuous.
I haven't been following DWC2 driver development, so I don't really know
its current status.
David Daney
This seems fine.
Acked-by: David Daney david.da...@cavium.com
---
drivers/staging/octeon/ethernet-mem.c | 7 +--
drivers/staging/octeon/ethernet-rx.c | 3 ---
2 files changed, 1 insertion(+), 9 deletions(-)
diff --git a/drivers/staging/octeon/ethernet-mem.c
b/drivers/staging/octeon
On 09/05/2013 11:43 AM, Aaro Koskinen wrote:
We should count also dropped packets, otherwise the NAPI handler may
end up running too long.
Is this actually a problem?
If so ... the patch looks sane and you and add Acked-by me.
Signed-off-by: Aaro Koskinen aaro.koski...@iki.fi
---
() is unnecessary, or you broke the logic for
enabling NAPI on more than one CPU.
I am not sure which is the case, but I think it would be best if you
supplied a fixed patch set that corrects whichever happens to be the case.
David Daney
}
void cvm_oct_rx_shutdown(void
On 09/30/2013 12:56 PM, Aaro Koskinen wrote:
Hi,
On Mon, Sep 30, 2013 at 12:41:59PM -0700, David Daney wrote:
On 09/30/2013 12:35 PM, Aaro Koskinen wrote:
No, the original logic was already broken. The code assumed that the
NAPI scheduled by the driver init gets executed always on CPU 0
On 10/28/2013 06:24 PM, Luka Perkov wrote:
Checking if MAC address is valid using is_valid_ether_addr() is already done in
of_get_mac_address().
Signed-off-by: Luka Perkov l...@openwrt.org
Acked-by: David Daney david.da...@cavium.com
---
drivers/staging/octeon/ethernet.c | 2 +-
1 file
On 05/29/2014 02:54 PM, abdoulaye berthe wrote:
Did you forget a changelog explaining why this is either needed, or even
a good idea? I joined the conversation late and don't know why you are
doing this.
Thanks,
David Daney
Signed-off-by: abdoulaye berthe berthe...@gmail.com
---
arch
with gpios still
requested\n);
panic?
NACK to the patch for this reason. The strongest thing you should do
here is WARN.
That said, I am not sure why we need this whole patch set in the first
place.
David Daney
Is this likely to happen?
Gr{oetje,eeting}s
On 04/25/2014 07:21 AM, Greg KH wrote:
On Fri, Apr 25, 2014 at 10:48:22AM -0300, Nicolas Del Piano wrote:
Fixed a coding style error, macros with complex values should be enclosed in
parentheses.
Signed-off-by: Nicolas Del Piano ndel...@gmail.com
---
drivers/staging/octeon-usb/octeon-hcd.c
and OCTEON II networking continue to function?
There is no SSO provisioning, so there will be limited buffering on
packet ingress. For low packet rates, it should be fine though.
David Daney
A.
Aaro Koskinen (2):
MIPS/staging: OCTEON: properly enable/disable SSO WQE interrupts
MIPS
On 08/10/2015 02:51 PM, Joe Perches wrote:
Using 'extern' is not necessary for function prototypes.
Signed-off-by: Joe Perches j...@perches.com
Acked-by: David Daney david.da...@cavium.com
---
drivers/staging/octeon/ethernet-mdio.h | 2 +-
drivers/staging/octeon/octeon-ethernet.h | 22
On 08/14/2015 06:09 AM, Aaro Koskinen wrote:
Hi,
On Thu, Aug 13, 2015 at 12:16:43PM -0700, David Daney wrote:
On 08/13/2015 06:21 AM, Aaro Koskinen wrote:
Currently mainline Linux is unusable on OCTEON II CN68XX SOCs due to
issues in Ethernet driver initialization. Some boards are hanging
remove them
from the patch.
They are valid, and I have seen no good reason presented to change them.
If you want to churn up the code with white space changes, I cannot
prevent it, but at least accurately describe what you are doing, and
make sure you don't break the driver.
David Daney
s not true.
On Oct 14, 2015 9:17 PM, "David Daney" <dda...@caviumnetworks.com
<mailto:dda...@caviumnetworks.com>> wrote:
On 10/14/2015 07:06 AM, Sakshi Bansal wrote:
Fixed allignment issues and line over 80 characters
Use spell checking on 'allignmen
On 10/14/2015 01:58 PM, Arnd Bergmann wrote:
On Wednesday 14 October 2015 08:47:44 David Daney wrote:
On 10/14/2015 07:06 AM, Sakshi Bansal wrote:
Fixed allignment issues and line over 80 characters
Use spell checking on 'allignment'
But that is not the main problem with the patch...
You
On 10/15/2015 06:40 AM, Dan Carpenter wrote:
On Wed, Oct 14, 2015 at 09:09:04AM -0700, David Daney wrote:
and make sure you don't break the driver.
I'm not seeing how this patch breaks anything? What am I missing?
Did you apply it and then compile the result? If not, then how can you
On 02/18/2016 02:20 PM, Aaro Koskinen wrote:
Use atomic_long_t, so that we can avoid some 32 vs. 64-bit ifdeffery.
Signed-off-by: Aaro Koskinen <aaro.koski...@iki.fi>
OCTEON doesn't even support a 32-bit kernel. This is really old legacy
B.S. that should be removed...
Acked-by:
. There is
still the possibility of whatever is reading the statistics racing with
the update, but perhaps that doesn't matter.
David Daney
thanks,
greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org
<aaro.koski...@iki.fi>
Acked-by: David Daney <david.da...@cavium.com>
---
Replaces this patch: http://marc.info/?t=14558340838=1=2
drivers/staging/octeon/ethernet-rx.c | 23 +++
drivers/staging/octeon/ethernet.c| 13 +
2 files changed,
On 07/14/2016 10:06 AM, Javier Martinez Canillas wrote:
The IS_ENABLED() macro checks if a Kconfig symbol has been enabled either
built-in or as a module, use that macro instead of open coding the same.
Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com>
Acked-by: David
On 08/31/2016 08:06 AM, Aaro Koskinen wrote:
Hi,
On Tue, Aug 30, 2016 at 06:12:17PM -0700, Ed Swierk wrote:
On Tue, Aug 30, 2016 at 11:47 AM, Aaro Koskinen wrote:
This series implements multiple RX group support that should improve
the networking performance on
built-in and module enable details.
Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com>
Acked-by: David Daney <david.da...@cavium.com>
---
Changes since first post:
- Added David Daney Acked-by tag.
- Rebased on top of latest master.
You changed something abo
On 08/25/2016 11:22 AM, Aaro Koskinen wrote:
Hi,
On Thu, Aug 25, 2016 at 09:50:15AM -0700, David Daney wrote:
Ideally we would configure the packet classifiers on the RX side to create
multiple RX queues based on a hash of the TCP 5-tuple, and handle each queue
with a single NAPI instance
On 08/25/2016 02:18 PM, Aaro Koskinen wrote:
Hi,
On Thu, Aug 25, 2016 at 01:11:45PM -0700, David Daney wrote:
On 08/25/2016 11:22 AM, Aaro Koskinen wrote:
On Thu, Aug 25, 2016 at 09:50:15AM -0700, David Daney wrote:
Ideally we would configure the packet classifiers on the RX side to create
On 03/01/2017 11:21 AM, Arushi Singhal wrote:
Fixed coding style for null comparisons in speakup driver to be more
consistant with the rest of the kernel coding style.
Signed-off-by: Arushi Singhal
---
drivers/staging/speakup/fakekey.c | 2 +-
On 11/15/2017 11:18 AM, Rob Herring wrote:
On Thu, Nov 09, 2017 at 11:29:08AM -0800, David Daney wrote:
From: Carlos Munoz <cmu...@cavium.com>
Add bindings for Common Ethernet Interface (BGX) block.
Signed-off-by: Carlos Munoz <cmu...@cavium.com>
Signed-off-by: Steven J. Hi
On 11/28/2017 06:01 PM, Andrew Lunn wrote:
On Tue, Nov 28, 2017 at 04:55:33PM -0800, David Daney wrote:
From: Carlos Munoz <cmu...@cavium.com>
Add bindings for Common Ethernet Interface (BGX) block.
Acked-by: Rob Herring <r...@kernel.org>
Signed-off-by: Carlos Munoz <cmu...@cav
On 11/29/2017 08:07 AM, Souptick Joarder wrote:
On Wed, Nov 29, 2017 at 4:00 PM, Souptick Joarder <jrdr.li...@gmail.com> wrote:
On Wed, Nov 29, 2017 at 6:25 AM, David Daney <david.da...@cavium.com> wrote:
From: Carlos Munoz <cmu...@cavium.com>
The Cavium OCTEON cn78xx an
On 11/30/2017 01:36 PM, James Hogan wrote:
On Tue, Nov 28, 2017 at 04:55:34PM -0800, David Daney wrote:
From: Carlos Munoz <cmu...@cavium.com>
LMTDMA/LMTST operations move data between cores and I/O devices:
* LMTST operations can send an address and a variable length
(up to 128
On 11/30/2017 02:56 PM, James Hogan wrote:
On Thu, Nov 30, 2017 at 01:49:43PM -0800, David Daney wrote:
On 11/30/2017 01:36 PM, James Hogan wrote:
On Tue, Nov 28, 2017 at 04:55:34PM -0800, David Daney wrote:
Signed-off-by: Carlos Munoz <cmu...@cavium.com>
Signed-off-by: Steven J
On 11/30/2017 02:53 PM, James Hogan wrote:
On Tue, Nov 28, 2017 at 04:55:35PM -0800, David Daney wrote:
From: Carlos Munoz <cmu...@cavium.com>
Add a global resource manager to manage tagged pointers within
bootmem allocated memory. This is used by various functional
blocks in the Octeo
On 11/29/2017 02:56 PM, Andrew Lunn wrote:
On Tue, Nov 28, 2017 at 04:55:39PM -0800, David Daney wrote:
+static int bgx_probe(struct platform_device *pdev)
+{
+ struct mac_platform_data platform_data;
+ const __be32 *reg;
+ u32 port;
+ u64 addr;
+ struct
by: Steven J. Hill <steven.h...@cavium.com>
Signed-off-by: David Daney <david.da...@cavium.com>
---
arch/mips/cavium-octeon/Makefile | 3 +-
arch/mips/cavium-octeon/resource-mgr.c | 371 +
arch/mips/include/asm/octeon/octeon.h | 18 ++
3 files
additional lines, defaults to zero.
Signed-off-by: David Daney <david.da...@cavium.com>
Signed-off-by: Carlos Munoz <cmu...@caviumnetworks.com>
---
arch/mips/cavium-octeon/Kconfig| 27
arch/mips/cavium-octeon/setup.c
Previous patch sets USE_ASYNC_IOBDMA to 1 unconditionally. Remove
USE_ASYNC_IOBDMA from all if statements. Remove dead code caused by
the change.
Signed-off-by: David Daney <david.da...@cavium.com>
---
drivers/staging/octeon/ethernet-defines.h | 6 ---
drivers/staging/octeon/etherne
Interface.
MIPS: Octeon: Enable LMTDMA/LMTST operations.
MIPS: Octeon: Add a global resource manager.
MIPS: Octeon: Add Free Pointer Unit (FPA) support.
netdev: octeon-ethernet: Add Cavium Octeon III support.
David Daney (3):
MIPS: Octeon: Automatically provision CVMSEG space.
staging
."
Signed-off-by: Carlos Munoz <cmu...@cavium.com>
Signed-off-by: Steven J. Hill <steven.h...@cavium.com>
Signed-off-by: David Daney <david.da...@cavium.com>
---
arch/mips/cavium-octeon/Kconfig | 8 +
arch/mips/cavium-octeon/Makefile | 1 +
arch/m
f data to the I/O device and then return a
variable length (up to 128 bytes) response from the IOI device.
Signed-off-by: Carlos Munoz <cmu...@cavium.com>
Signed-off-by: Steven J. Hill <steven.h...@cavium.com>
Signed-off-by: David Daney <david.da...@cavium.com>
---
arch/mi
From: Carlos Munoz <cmu...@cavium.com>
Add bindings for Common Ethernet Interface (BGX) block.
Acked-by: Rob Herring <r...@kernel.org>
Signed-off-by: Carlos Munoz <cmu...@cavium.com>
Signed-off-by: Steven J. Hill <steven.h...@cavium.com>
Signed-off-by: David Daney
Signed-off-by: David Daney <david.da...@cavium.com>
---
MAINTAINERS | 6 ++
1 file changed, 6 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index aa71ab52fd76..e9239ff3cf05 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -3249,6 +3249,12 @@ W: http://www.cavium.
On 12/01/2017 11:49 AM, Philippe Ombredanne wrote:
David, Greg,
On Fri, Dec 1, 2017 at 6:42 PM, David Daney <dda...@caviumnetworks.com> wrote:
On 11/30/2017 11:53 PM, Philippe Ombredanne wrote:
[...]
--- /dev/null
+++ b/arch/mips/cavium-octeon/resource-mgr.c
@@ -0,0 +1,371 @@
+/
On 12/01/2017 12:41 PM, Philippe Ombredanne wrote:
David,
On Fri, Dec 1, 2017 at 9:01 PM, David Daney <dda...@caviumnetworks.com> wrote:
On 12/01/2017 11:49 AM, Philippe Ombredanne wrote:
David, Greg,
On Fri, Dec 1, 2017 at 6:42 PM, David Daney <dda...@caviumnetworks.com>
wrote
From: Carlos Munoz <cmu...@cavium.com>
Add bindings for Common Ethernet Interface (BGX) block.
Signed-off-by: Carlos Munoz <cmu...@cavium.com>
Signed-off-by: Steven J. Hill <steven.h...@cavium.com>
Signed-off-by: David Daney <david.da...@cavium.com>
---
.../device
.
netdev: octeon-ethernet: Add Cavium Octeon III support.
David Daney (3):
MIPS: Octeon: Automatically provision CVMSEG space.
staging: octeon: Remove USE_ASYNC_IOBDMA macro.
MAINTAINERS: Add entry for
drivers/net/ethernet/cavium/octeon/octeon3-*
.../devicetree/bindings/net/cavium-bgx.txt
f data to the I/O device and then return a
variable length (up to 128 bytes) response from the IOI device.
Signed-off-by: Carlos Munoz <cmu...@cavium.com>
Signed-off-by: Steven J. Hill <steven.h...@cavium.com>
Signed-off-by: David Daney <david.da...@cavium.com>
---
arch/mi
by: Steven J. Hill <steven.h...@cavium.com>
Signed-off-by: David Daney <david.da...@cavium.com>
---
arch/mips/cavium-octeon/Makefile | 3 +-
arch/mips/cavium-octeon/resource-mgr.c | 371 +
arch/mips/include/asm/octeon/octeon.h | 18 ++
3 files
Previous patch sets USE_ASYNC_IOBDMA to 1 unconditionally. Remove
USE_ASYNC_IOBDMA from all if statements. Remove dead code caused by
the change.
Signed-off-by: David Daney <david.da...@cavium.com>
---
drivers/staging/octeon/ethernet-defines.h | 6 ---
drivers/staging/octeon/etherne
additional lines, defaults to zero.
Signed-off-by: David Daney <david.da...@cavium.com>
Signed-off-by: Carlos Munoz <cmu...@caviumnetworks.com>
---
arch/mips/cavium-octeon/Kconfig| 27
arch/mips/cavium-octeon/setup.c
."
Signed-off-by: Carlos Munoz <cmu...@cavium.com>
Signed-off-by: Steven J. Hill <steven.h...@cavium.com>
Signed-off-by: David Daney <david.da...@cavium.com>
---
arch/mips/cavium-octeon/Kconfig | 8 +
arch/mips/cavium-octeon/Makefile | 1 +
arch/m
Signed-off-by: David Daney <david.da...@cavium.com>
---
MAINTAINERS | 6 ++
1 file changed, 6 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 9a24f56e0451..142af33adc35 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -3212,6 +3212,12 @@ W: http://www.cavium.
I need to send v3. With this v2 set, there is a small bug in the RX
initialization that causes failure on little-endian kernels.
David.
On 11/08/2017 04:51 PM, David Daney wrote:
We are adding the Cavium OCTEON-III network driver. But since
interacting with the input and output queues
-bindings: Add Cavium Octeon Common Ethernet Interface.
MIPS: Octeon: Enable LMTDMA/LMTST operations.
MIPS: Octeon: Add a global resource manager.
MIPS: Octeon: Add Free Pointer Unit (FPA) support.
netdev: octeon-ethernet: Add Cavium Octeon III support.
David Daney (3):
MIPS: Octeon
by: Steven J. Hill <steven.h...@cavium.com>
Signed-off-by: David Daney <david.da...@cavium.com>
---
arch/mips/cavium-octeon/Makefile | 3 +-
arch/mips/cavium-octeon/resource-mgr.c | 371 +
arch/mips/include/asm/octeon/octeon.h | 18 ++
3 files
Previous patch sets USE_ASYNC_IOBDMA to 1 unconditionally. Remove
USE_ASYNC_IOBDMA from all if statements. Remove dead code caused by
the change.
Signed-off-by: David Daney <david.da...@cavium.com>
---
drivers/staging/octeon/ethernet-defines.h | 6 ---
drivers/staging/octeon/etherne
Signed-off-by: David Daney <david.da...@cavium.com>
---
MAINTAINERS | 6 ++
1 file changed, 6 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 9a24f56e0451..142af33adc35 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -3212,6 +3212,12 @@ W: http://www.cavium.
From: Carlos Munoz <cmu...@cavium.com>
Add bindings for Common Ethernet Interface (BGX) block.
Signed-off-by: Carlos Munoz <cmu...@cavium.com>
Signed-off-by: Steven J. Hill <steven.h...@cavium.com>
Signed-off-by: David Daney <david.da...@cavium.com>
---
.../device
additional lines, defaults to zero.
Signed-off-by: David Daney <david.da...@cavium.com>
Signed-off-by: Carlos Munoz <cmu...@caviumnetworks.com>
---
arch/mips/cavium-octeon/Kconfig| 27
arch/mips/cavium-octeon/setup.c
."
Signed-off-by: Carlos Munoz <cmu...@cavium.com>
Signed-off-by: Steven J. Hill <steven.h...@cavium.com>
Signed-off-by: David Daney <david.da...@cavium.com>
---
arch/mips/cavium-octeon/Kconfig | 8 +
arch/mips/cavium-octeon/Makefile | 1 +
arch/m
f data to the I/O device and then return a
variable length (up to 128 bytes) response from the IOI device.
Signed-off-by: Carlos Munoz <cmu...@cavium.com>
Signed-off-by: Steven J. Hill <steven.h...@cavium.com>
Signed-off-by: David Daney <david.da...@cavium.com>
---
arch/mi
On 11/30/2017 11:53 PM, Philippe Ombredanne wrote:
Carlos,
On Thu, Nov 30, 2017 at 11:53 PM, James Hogan <james.ho...@mips.com> wrote:
On Tue, Nov 28, 2017 at 04:55:35PM -0800, David Daney wrote:
From: Carlos Munoz <cmu...@cavium.com>
Add a global resource manager to manage tag
63 matches
Mail list logo