Re: [PATCH] MAINTAINERS: Add maintainer section for hfi1

and get this patch into your repo? I can certainly add this to the hfi1 branch in my tree. I answered why I put this in staging in my previous email. — Doug Ledford dledf...@redhat.com GPG Key ID: 0E572FDD signature.asc Description: Message signed with OpenPGP using GPGMail

Re: [PATCH] Kconfig: add temporary PCI dependency

an RDMA transfer engine library) will take a lot of work, so putting it in staging and requiring that to be complete before putting it in the regular tree is a decent carrot for getting that large bit of work done. — Doug Ledford dledf...@redhat.com GPG Key ID: 0E572FDD signature.asc

Re: [PATCH] Kconfig: add temporary PCI dependency

for the directory and redirect it to linux-rdma, and delete it when this work has passed. That sounds like a good plan to me. I’ll rebase my tree and fix it up. — Doug Ledford dledf...@redhat.com GPG Key ID: 0E572FDD signature.asc Description: Message signed with OpenPGP using GPGMail

Re: [PATCH] Kconfig: add temporary PCI dependency

On Aug 18, 2015, at 7:49 PM, Greg KH g...@kroah.com wrote: On Tue, Aug 18, 2015 at 06:24:40PM -0700, Doug Ledford wrote: Are you going to be responsible for all of the patches sent to it and you just want me to ignore them, or will you send patches to me for me to apply? I expect

Re: [PATCH] Kconfig: add temporary PCI dependency

On Aug 18, 2015, at 4:11 PM, Greg KH g...@kroah.com wrote: On Tue, Aug 18, 2015 at 10:00:39AM -0700, Doug Ledford wrote: On Aug 18, 2015, at 9:50 AM, Greg KH g...@kroah.com wrote: On Tue, Aug 18, 2015 at 04:29:50PM +, Marciniszyn, Mike wrote: Subject: Re: [PATCH] Kconfig: add

Re: [PATCH] Kconfig: add temporary PCI dependency

INIBAND > + depends on X86_64 && INFINIBAND && PCI > default m > ---help--- > This is a low-level driver for Intel OPA Gen1 adapter. > -- Doug Ledford <dledf...@redhat.com> GPG KeyID: 0E572FDD signature.asc

Re: [PATCH] drivers:staging:hfi1: Fix coding style issues

ad_pkey_index) > + u8 port, const struct ib_wc *in_wc, > + const struct ib_grh *in_grh, > + const struct opa_mad *in_mad, > + struct opa_mad *out_mad, size_t *out_mad_size, > +

Re: [PATCH] MAINTAINERS: Add maintainer section for hfi1

l.org > +L: de...@driverdev.osuosl.org > +S: Supported > +F: drivers/staging/hfi1 > + > STARFIRE/DURALAN NETWORK DRIVER > M: Ion Badulescu <io...@badula.org> > S: Odd Fixes > -- Doug Ledford <dledf...@redhat

Re: [PATCH] staging: ipath: fix build failure

is a driver for the deprecated QLogic Hyper-Transport > IB host channel adapter (model QHT7140), > The ipath driver was moved to staging/rdma/ipath and has proper protection against being built without the InfiniBand subsystem. Where are you seeing this tree? I'm curious because I

Re: [PATCH 04/38] IB/ehca: fix handling idr_alloc result

76 > > Signed-off-by: Andrzej Hajda <a.ha...@samsung.com> Patch looks fine to me. Acked-by: Doug Ledford <dledf...@redhat.com> > --- > drivers/staging/rdma/ehca/ehca_cq.c | 13 +++-- > 1 file changed, 7 insertions(+), 6 deletions(-) > > diff --git a/drive

Re: [patch] IB/hfi1: checking for NULL instead of IS_ERR

On 09/18/2015 11:01 PM, Greg Kroah-Hartman wrote: > On Fri, Sep 18, 2015 at 11:51:09AM -0400, Doug Ledford wrote: >> On 09/16/2015 02:22 AM, Dan Carpenter wrote: >>> __get_txreq() returns an ERR_PTR() but this checks for NULL so it would >>> oops on failure. >>&

Re: [patch] IB/hfi1: fix a locking bug

On 09/16/2015 02:22 AM, Dan Carpenter wrote: > mutex_trylock() returns zero on failure, not EBUSY. > > Signed-off-by: Dan Carpenter <dan.carpen...@oracle.com> Thanks, applied. -- Doug Ledford <dledf...@redhat.com> GPG KeyID: 0E572FDD signature.asc

Re: [patch] IB/hfi1: checking for NULL instead of IS_ERR

t; as people will continue to send stuff to me. As you wish. I pulled in a number of patches related to hfi1, but I've already sent the pull request to Linus and they made it as of 4.1-rc2. So, just start from there and you will have all the patches I've taken. -- Doug Ledford <dled

Re: [patch] IB/hfi1: fix copy_to/from_user() error handling

o fill /var/log/messages with spam. > > Signed-off-by: Dan Carpenter <dan.carpen...@oracle.com> Thanks, applied. -- Doug Ledford <dledf...@redhat.com> GPG KeyID: 0E572FDD signature.asc Description: OpenPGP digital signature

Re: [patch] IB/hfi1: checking for NULL instead of IS_ERR

On 09/16/2015 02:22 AM, Dan Carpenter wrote: > __get_txreq() returns an ERR_PTR() but this checks for NULL so it would > oops on failure. > > Signed-off-by: Dan Carpenter <dan.carpen...@oracle.com> Thanks, applied. -- Doug Ledford <dledf...@redhat.com>

Re: [PATCH] IB/hfi1: fix sdma_descq_cnt parameter parsing

On 09/15/2015 10:19 AM, Mike Marciniszyn wrote: > The boolean tests should have been or-ed. > > Reported-by: David Binderman <dcb...@hotmail.com> > Reviewed-by: Jubin John <jubin.j...@intel.com> > Signed-off-by: Mike Marciniszyn <mike.marcinis...@intel.com> Th

Re: [patch v2] IB/hfi1: info leak in get_ctxt_info()

On 09/16/2015 02:42 AM, Dan Carpenter wrote: > The cinfo struct has a hole after the last struct member so we need to > zero it out. Otherwise we disclose some uninitialized stack data. > > Signed-off-by: Dan Carpenter <dan.carpen...@oracle.com> Thanks, applied. -- D

Re: HFI1 code duplication todo

On 11/20/2015 11:39 AM, Greg KH wrote: > On Fri, Nov 20, 2015 at 10:41:16AM -0500, Doug Ledford wrote: >> To that end, I've opened my 4.4-rc branch and deleted the three >> deprecated drivers from staging and moved hfi1 to the rdma tree. I've >> sent an email to Linus to

Re: HFI1 code duplication todo

've sent an email to Linus to see if he's ok taking those changes, and if so, I'll get them submitted and then open up my for-4.5 branch early to be able to start taking for-next patches. -- Doug Ledford <dledf...@redhat.com> GPG KeyID: 0E572FDD signature.asc Description: Op

Re: HFI1 code duplication todo

>> to rc1. > > It's not a problem, life happens (congratulations by the way), Thanks :-) > but don't > rush things now, why not just wait until the next merge window, there > are no deadlines here that require this to happen for 4.4-final. I'm actually not in a rush to

Re: [PATCH] staging: amso1100: fix format string for 64-bit phys_addr

gt;flags); > pr_debug(" status: 0x%x\n", rxp_hdr->status); > pr_debug("len : %u\n", rxp_hdr->len); > I've sent off a deletion of this file to Linus already, sorry. -- Doug Ledford <dledf...@redhat.com> GPG Key

Re: [PATCH] rdma: amso1100: c2_provider: Use netdev_dbg()

quot;adding...\n"); > for_ifa(ind) { > #ifdef DEBUG > u8 *ip = (u8 *) & ifa->ifa_address; > @@ -684,7 +684,7 @@ static int c2_pseudo_down(struct net_device *netdev) > if (!ind) > return 0; > > - pr_debug("deleting...

Re: [patch] staging: rdma: shift wrapping bug in c2_get_dma_mr()

On 01/08/2016 08:29 AM, Christoph Hellwig wrote: > Looks fine. > > Doug: what's the status of the staged out drivers? I thought we were > going to delete them for 4.5? > I am. They will be going away shortly. -- Doug Ledford <dledf...@redhat.com>

Re: [PATCH] IB/rxe: fix compare_const_fl.cocci warnings

On 2/18/2016 8:06 AM, Julia Lawall wrote: > Move constants to the right of binary operators. > > Generated by: scripts/coccinelle/misc/compare_const_fl.cocci > > CC: Kamal Heib > Signed-off-by: Fengguang Wu > Signed-off-by: Julia Lawall

Re: [PATCH RESEND v3 5/6] staging/rdma/hfi1: adding per SDMA engine stats to hfistats

Would you like us to do a cleanup of this code > in a follow-on patch or rework this patch and resend the series? > > Jubin > Thanks, the code is confusing to read, so a cleanup would be nice. Just send me something I can squash into this patch is good enough. -- Doug Ledford <dledf...@redhat.com> GPG KeyID: 0E572FDD signature.asc Description: OpenPGP digital signature ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH RESEND v3 5/6] staging/rdma/hfi1: adding per SDMA engine stats to hfistats

; > + else if (status & sde->progress_mask) > + sde->progress_int_cnt++; > + else if (status & sde->int_mask) > + sde->sdma_int_cnt++; > sdma_make_progress(sde, status); > write_sequnlock(>head_lock); > } > diff --git a/drivers/staging/rdma/hfi1/sdma.h > b/drivers/staging/rdma/hfi1/sdma.h > index da89e64..757017a 100644 > --- a/drivers/staging/rdma/hfi1/sdma.h > +++ b/drivers/staging/rdma/hfi1/sdma.h > @@ -409,6 +409,7 @@ struct sdma_engine { > u64 imask; /* clear interrupt mask */ > u64 idle_mask; > u64 progress_mask; > + u64 int_mask; > /* private: */ > volatile __le64 *head_dma; /* DMA'ed by chip */ > /* private: */ > @@ -465,6 +466,12 @@ struct sdma_engine { > u16 tx_head; > /* private: */ > u64 last_status; > + /* private */ > + u64 err_cnt; > + /* private */ > + u64 sdma_int_cnt; > + u64 idle_int_cnt; > + u64 progress_int_cnt; > > /* private: */ > struct list_head dmawait; > -- Doug Ledford <dledf...@redhat.com> GPG KeyID: 0E572FDD signature.asc Description: OpenPGP digital signature ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH net-next 4/5] treewide: replace dev->trans_start update with helper

| 2 +- > drivers/infiniband/ulp/ipoib/ipoib_cm.c | 2 +- > drivers/infiniband/ulp/ipoib/ipoib_ib.c| 2 +- For InfiniBand bits, Acked-by: Doug Ledford <dledf...@redhat.com> -- Doug Ledford <dledf...@redhat.com> GPG KeyID: 0

Re: [PATCH] staging/rdma/hfi1: use RCU_INIT_POINTER() when NULLing.

POINTER(ppd->cc_state, NULL); > spin_unlock(>cc_state_lock); > > if (cc_state) > Thanks, applied. -- Doug Ledford <dledf...@redhat.com> GPG KeyID: 0E572FDD signature.asc Description: OpenPGP digital signature