Re: [PATCH] staging: android: ion: Fix compilation warning

2018-09-08 Thread Fabio Estevam
On Sat, Sep 8, 2018 at 1:33 PM, Alexey Skidanov wrote: > Label unlock is defined but not used You are also removing the variable 'ret', which is a different change. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.

Re: [PATCH v2] staging: iio: adt7316: fix parenthesis alignment

2018-10-08 Thread Fabio Estevam
Hi Renato, On Mon, Oct 8, 2018 at 7:02 PM Renato Lui Geh wrote: > > This patch fixes most "Alignment should match open parenthesis" check > warnings found by checkpatch.pl in the addac/adt7316 driver. > --- You missed your Signed-off-by tag, which is also reported by checkpatch.pl :-) __

Re: [PATCH 5/6] staging:iio:ad2s90: Add SPDX license identifier

2018-11-09 Thread Fabio Estevam
Hi Matheus, On Fri, Nov 9, 2018 at 8:01 PM Matheus Tavares wrote: > > This patch adds the SPDX GPL-2.0-only license identifier to ad2s90.c, > which solves the checkpatch.pl warning: > "WARNING: Missing or malformed SPDX-License-Identifier tag in line 1". > > Signed-off-by: Matheus Tavares > ---

Re: [PATCH 5/6] staging:iio:ad2s90: Add SPDX license identifier

2018-11-10 Thread Fabio Estevam
Hi Matheus, On Fri, Nov 9, 2018 at 10:27 PM Matheus Tavares Bernardino wrote: > Got it, thanks for the explanation! I'll correct this in v2. One more suggestion: in v2 you could also consider to remove the legal text that says GPL v2, as you are adding the SPDX tag.

Re: [PATCH 1/2] media: imx: csi: Disable CSI immediately after last EOF

2019-01-17 Thread Fabio Estevam
Hi Steve, On Thu, Jan 17, 2019 at 6:15 PM Steve Longerbeam wrote: > > Disable the CSI immediately after receiving the last EOF before stream > off (and thus before disabling the IDMA channel). > > This fixes a complete system hard lockup on the SabreAuto when streaming > from the ADV7180, by repe

Re: [PATCH v2] media: imx-csi: Input connections to CSI should be optional

2019-01-17 Thread Fabio Estevam
imx-ipuv3 280.ipu: driver could not parse port@0/endpoint@0 (-22) [3.472120] imx-ipuv3-csi: probe of imx-ipuv3-csi.4 failed with error -22 Tested-by: Fabio Estevam ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v9 00/13] media: staging/imx7: add i.MX7 media driver

2019-01-18 Thread Fabio Estevam
Hi Rui, On Fri, Dec 7, 2018 at 10:44 AM Hans Verkuil wrote: > I got a few checkpatch warnings about coding style: > > CHECK: Alignment should match open parenthesis > #953: FILE: drivers/staging/media/imx/imx7-media-csi.c:911: > +static struct v4l2_mbus_framefmt *imx7_csi_get_format(struct imx7_

Re: [PATCH v3 2/3] media: imx7-media-csi: add i.MX6UL support

2019-08-01 Thread Fabio Estevam
On Wed, Jul 31, 2019 at 1:33 PM Sébastien Szymanski wrote: > > i.MX7 and i.MX6UL/L have the same CSI controller. So add i.MX6UL/L support > to imx7-media-csi driver. > > Signed-off-by: Sébastien Szymanski Reviewed-by: Fabio Estevam __

Re: [PATCH v3 3/3] media: dt-bindings: imx7-csi: add i.MX6UL/L support

2019-08-01 Thread Fabio Estevam
On Wed, Jul 31, 2019 at 1:34 PM Sébastien Szymanski wrote: > > Document "fsl,imx6ul-csi" entry. > > Reviewed-by: Rob Herring > Signed-off-by: Sébastien Szymanski Reviewed-by: Fabio Estevam ___ devel mailing list de...@li

Re: Patch for applying pixelclk-active in ipuv3-crtc.c

2014-11-14 Thread Fabio Estevam
c.c and another one for parallel-display.c. Then follow Documentation/SubmittingPatches for the correct process. You need to add your Signed-off-by and do not send it as attachment. Send it via git send-email and also Cc Phillip Zabel. Regards,

Re: [PATCH v12 0/11] dw-hdmi: convert imx hdmi to bridge/dw_hdmi

2014-11-25 Thread Fabio Estevam
Hi Andy, On Mon, Nov 17, 2014 at 8:53 AM, Andy Yan wrote: > Andy Yan (11): > staging: imx-drm: imx-hdmi: make checkpatch happy > staging: imx-drm: imx-hdmi: return defer if can't get ddc i2c adapter > staging: imx-drm: imx-hdmi: convert imx-hdmi to drm_bridge mode > staging: imx-drm: imx

Re: [PATCH v2 4/9] staging: panel: Use defined value or checking module params state

2014-11-27 Thread Fabio Estevam
On Thu, Nov 27, 2014 at 7:05 PM, Willy Tarreau wrote: > Mariusz, for people who have to parse hundreds to thousands of e-mails > a day, dealing with non-trivial operation modes like this is never easy. > > I think (I'll let Greg suggest what he prefers) that the most reliable > thing to do *right

Re: [PATCH 2/2] media: imx7-media-csi: add i.MX6UL support

2019-05-02 Thread Fabio Estevam
Hi Sébastien, On Tue, Apr 30, 2019 at 4:49 AM Sébastien Szymanski wrote: > +static const struct of_device_id imx7_csi_of_match[] = { > + { .compatible = "fsl,imx7-csi", .data = (void *)IMX7 }, > + { .compatible = "fsl,imx6ul-csi", .data = (void *)IMX6UL }, Please add the new "fsl,im

Re: [PATCH] staging: media: imx: fix Unneeded variable: "ret". Return "0"

2019-05-18 Thread Fabio Estevam
On Sat, May 18, 2019 at 2:38 PM Hariprasad Kelam wrote: > > fix below warning reported by coccichec > > drivers/staging/media/imx/imx-media-capture.c:617:5-8: Unneeded > variable: "ret". Return "0" on line 630 > > Signed-off-by: Hariprasad Ke

Re: [PATCH] staging: iio: adis16240: add device to module device table

2019-05-18 Thread Fabio Estevam
Hi Lucas, On Sat, May 18, 2019 at 6:01 PM Lucas Oshiro wrote: > > Add a of_device_id struct and MODULE_DEVICE_TABLE call. Please provide an explanation as to why you are doing this. Thanks ___ devel mailing list de...@linuxdriverproject.org http://dri

[PATCH 2/2] staging: kpc2000: Use '%zu' for printing 'size_t' type

2019-06-05 Thread Fabio Estevam
rgument 8 has type 'size_t {aka unsigned int}' [-Wformat=] Reported-by: Build bot for Mark Brown Signed-off-by: Fabio Estevam --- drivers/staging/kpc2000/kpc_dma/fileops.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/kpc2000/kpc_dma/fileops.c

[PATCH 1/2] staging: kpc2000: Use '%llx' for printing 'long long int' type

2019-06-05 Thread Fabio Estevam
x27;, but argument 4 has type 'long long int' [-Wformat=] Reported-by: Build bot for Mark Brown Signed-off-by: Fabio Estevam --- drivers/staging/kpc2000/kpc2000/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/kpc2000/kpc2000/core.c b/drivers

Re: [PATCH 1/2] staging: kpc2000: Use '%llx' for printing 'long long int' type

2019-06-05 Thread Fabio Estevam
Hi Greg, On Wed, Jun 5, 2019 at 6:37 PM Fabio Estevam wrote: > > In order to print a 'long long int' type the 'llx' specifier needs to be > used. > > Change it accordingly in order to fix the following build warning: > > drivers/staging/kpc2000/kpc2000/co

[PATCH v2 1/2] staging: kpc2000: Use '%llx' for printing 'long long int' type

2019-06-05 Thread Fabio Estevam
x27;, but argument 4 has type 'long long int' [-Wformat=] Reported-by: Build bot for Mark Brown Signed-off-by: Fabio Estevam --- Changes since v1: - Mark KP2000_MAGIC_VALUE to avoid build warnings in ARM32 drivers/staging/kpc2000/kpc2000/core.c | 2 +- drivers/staging/kpc2000/kpc2000/

[PATCH v2 2/2] staging: kpc2000: Use '%zu' for printing 'size_t' type

2019-06-05 Thread Fabio Estevam
rgument 8 has type 'size_t {aka unsigned int}' [-Wformat=] Reported-by: Build bot for Mark Brown Signed-off-by: Fabio Estevam --- Changes since v1: - None drivers/staging/kpc2000/kpc_dma/fileops.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/kp

[PATCH] staging: iio: adt7316: Fix build errors when GPIOLIB is not set

2019-06-05 Thread Fabio Estevam
function 'irqd_get_trigger_type' [-Werror=implicit-function-declaration] These functions are provided by the and headers, so include them to fix these build errors. Reported-by: Randy Dunlap Signed-off-by: Fabio Estevam --- drivers/staging/iio/addac/adt7316.c | 2 ++ 1 file c

[PATCH v2] staging: iio: adt7316: Fix build errors when GPIOLIB is not set

2019-06-05 Thread Fabio Estevam
function 'irqd_get_trigger_type' [-Werror=implicit-function-declaration] These functions are provided by the and headers, so include them to fix these build errors. While at it, remove as this driver is a GPIO consumer and not a GPIO driver. Reported-by: Randy Dunlap Signed-o

Re: [PATCH] staging: iio: adt7316: Fix build errors when GPIOLIB is not set

2019-06-05 Thread Fabio Estevam
Hi Phil, On Wed, Jun 5, 2019 at 10:59 PM Phil Reid wrote: > > #include > This should be removed as well. > See comment at top of linux/gpio.h Good catch! Just sent a v2. Thanks ___ devel mailing list de...@linuxdriverproject.org http://driverdev.l

Re: [PATCH v4 07/36] ARM: dts: imx6-sabresd: add OV5642 and OV5640 camera sensors

2017-02-16 Thread Fabio Estevam
Hi Steve, On Thu, Feb 16, 2017 at 12:19 AM, Steve Longerbeam wrote: > Enables the OV5642 parallel-bus sensor, and the OV5640 MIPI CSI-2 sensor. > > The OV5642 connects to the parallel-bus mux input port on ipu1_csi0_mux. > > The OV5640 connects to the input port on the MIPI CSI-2 receiver on > mi

Re: [PATCH v5 07/39] ARM: dts: imx6qdl-sabrelite: remove erratum ERR006687 workaround

2017-03-10 Thread Fabio Estevam
On Fri, Mar 10, 2017 at 3:59 PM, Troy Kisky wrote: > On 3/9/2017 8:52 PM, Steve Longerbeam wrote: >> There is a pin conflict with GPIO_6. This pin functions as a power >> input pin to the OV5642 camera sensor, but ENET uses it as the h/w >> workaround for erratum ERR006687, to wake-up the ARM core

Re: [PATCH v5 07/39] ARM: dts: imx6qdl-sabrelite: remove erratum ERR006687 workaround

2017-03-10 Thread Fabio Estevam
On Fri, Mar 10, 2017 at 6:57 PM, Pavel Machek wrote: > And it should not depend on configuration. Hardware vendor should be > able to ship board with working device tree... We are talking about pin conflict here. Please read the commit log of this patch for details. _

Re: [PATCH v3 12/14] ARM: dts: imx7s-warp: add ov2680 sensor node

2018-05-08 Thread Fabio Estevam
Hi Rui, On Mon, May 7, 2018 at 1:21 PM, Rui Miguel Silva wrote: > + reg_peri_3p15v: regulator-peri-3p15v { > + compatible = "regulator-fixed"; > + regulator-name = "peri_3p15v_reg"; > + regulator-min-microvolt = <315>; > + regulat

Re: commit reverted in staging/sm750fb

2015-04-07 Thread Fabio Estevam
ms I am not able to > find that in my personal mails nor in lkml. can you please let me know > when it was sent.. Just run 'git show 6ad6b5ed3e247' in linux-next and you can see such commit. Regards, Fabio Estevam ___ devel

Re: commit reverted in staging/sm750fb

2015-04-07 Thread Fabio Estevam
in a patch. > So i was trying to search for that patch in my mails and also in lkml, > but i could not find it, so thought of mailing and asking. :( The problem with commit 6ad6b5ed3e247 is this hunk: diff --git a/ret.ou b/ret.ou new file mode 100644 index 000..e69d

Re: [PATCH] staging: gdm72xx: remove unneeded test

2015-05-27 Thread Fabio Estevam
On Wed, May 27, 2015 at 5:25 PM, Laurent Navet wrote: > The same code is executed regardless ret value, so this test can be > removed. > > Signed-off-by: Laurent Navet > --- > drivers/staging/gdm72xx/usb_boot.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/staging/gdm72xx/usb

[PATCH] imx-drm: imx-drm-core: Remove unused 'imxdrm' variable

2014-02-08 Thread Fabio Estevam
From: Fabio Estevam Since commit 020a9ea7c2 (imx-drm: imx-drm-core: avoid going the long route round for drm_device) the 'imxdrm' variable is not used anymore, which causes the following build warning: drivers/staging/imx-drm/imx-drm-core.c:87:25: warning: unused variable 'imx

Re: [PATCH RFC v2 00/35] Second preview of imx-drm cleanup series

2014-02-12 Thread Fabio Estevam
or the next merge window sooner > rather than later, preferably getting most of this ready for that > window too. Series looks good: Reviewed-by: Fabio Estevam Patch 04/35 will not be needed in the final submission, as there is already a fix for the build issue in Greg's tree. Reg

[PATCH] staging: ion: ion_cma_heap: Remove '0x' when using %pa format

2014-02-18 Thread Fabio Estevam
%pa format already prints in hexadecimal format, so remove the '0x' annotation to avoid a double '0x0x' pattern. Signed-off-by: Fabio Estevam --- drivers/staging/android/ion/ion_cma_heap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

Re: [RFC PATCH v4 4/8] staging: imx-drm: Document imx-hdmi device tree bindings

2014-02-25 Thread Fabio Estevam
On Tue, Feb 25, 2014 at 11:23 AM, Philipp Zabel wrote: > This patch adds device tree binding documentation for the HDMI transmitter > on i.MX6. > > Signed-off-by: Philipp Zabel > --- > .../devicetree/bindings/staging/imx-drm/hdmi.txt | 53 > ++ > 1 file changed, 53 inserti

Re: [RFC PATCH v4 4/8] staging: imx-drm: Document imx-hdmi device tree bindings

2014-02-25 Thread Fabio Estevam
On Tue, Feb 25, 2014 at 11:23 AM, Philipp Zabel wrote: > +Required properties: > + - #address-cells : should be <1> > + - #size-cells : should be <0> > + - compatible : should be "fsl,imx6q-hdmi" or "fsl,imx6dl-hdmi". > + - gpr : should be <&gpr>. > + The phandle points to the iomuxc-gpr region

[PATCH 4/6] imx-drm: parallel-display: Check 'dmfc' pointer first

2014-02-26 Thread Fabio Estevam
From: Fabio Estevam Fix the following static checker warnings: drivers/staging/imx-drm/parallel-display.c:64 imx_pd_connector_get_modes() error: potential null dereference 'mode'. (drm_mode_create returns null) drivers/staging/imx-drm/parallel-display.c:73 imx_pd_connector_get_mode

[PATCH 1/6] imx-drm: ipu-dmfc: Check 'dmfc' pointer first

2014-02-26 Thread Fabio Estevam
From: Fabio Estevam Fix the following static checker warning: drivers/staging/imx-drm/ipu-v3/ipu-dmfc.c:164 ipu_dmfc_setup_channel() warn: variable dereferenced before check 'dmfc' (see line 157) Reported-by: Dan Carpenter Signed-off-by: Fabio Estevam --- drivers/staging/imx-drm/

[PATCH 2/6] imx-drm: imx-ldb: Check 'mode' pointer first

2014-02-26 Thread Fabio Estevam
From: Fabio Estevam Fix the following static checker warning: drivers/staging/imx-drm/imx-ldb.c:109 imx_ldb_connector_get_modes() error: potential null dereference 'mode'. (drm_mode_create returns null) Reported-by: Dan Carpenter Signed-off-by: Fabio Estevam --- drivers/stagi

[PATCH 6/6] imx-drm: imx-drm-core: Staticize imx_drm_find_crtc()

2014-02-26 Thread Fabio Estevam
From: Fabio Estevam Fix the following static checker warning: drivers/staging/imx-drm/imx-drm-core.c:89:21: warning: symbol 'imx_drm_find_crtc' was not declared. Should it be static? Reported-by: Dan Carpenter Signed-off-by: Fabio Estevam --- drivers/staging/imx-drm/imx-drm-

[PATCH 3/6] imx-drm: imx-ldb: Fix array length

2014-02-26 Thread Fabio Estevam
From: Fabio Estevam Fix the following static checker warning: drivers/staging/imx-drm/imx-ldb.c:340 imx_ldb_get_clk() error: format string overflow. buf_size: 16 length: 18 probably 18 is theory and not real life, but 16 is based on theory as well. Reported-by: Dan Carpenter

[PATCH 5/6] imx-drm: ipuv3-plane: Use %pad to print 'dma_addr_t'

2014-02-26 Thread Fabio Estevam
From: Fabio Estevam Fix the following static checker warning: drivers/staging/imx-drm/ipuv3-plane.c:75:2: warning: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'dma_addr_t' [-Wformat] Use %pad to print 'dma_addr_t'. R

[PATCH v2 1/6] imx-drm: ipu-dmfc: Check 'dmfc' pointer first

2014-02-26 Thread Fabio Estevam
From: Fabio Estevam Fix the following static checker warning: drivers/staging/imx-drm/ipu-v3/ipu-dmfc.c:164 ipu_dmfc_setup_channel() warn: variable dereferenced before check 'dmfc' (see line 157) Reported-by: Dan Carpenter Signed-off-by: Fabio Estevam --- Changes since v1: - C

[PATCH v2 2/6] imx-drm: imx-ldb: Check 'mode' pointer first

2014-02-26 Thread Fabio Estevam
From: Fabio Estevam Fix the following static checker warning: drivers/staging/imx-drm/imx-ldb.c:109 imx_ldb_connector_get_modes() error: potential null dereference 'mode'. (drm_mode_create returns null) Reported-by: Dan Carpenter Signed-off-by: Fabio Estevam --- Changes since

[PATCH v2 4/6] imx-drm: parallel-display: Check 'mode' pointer first

2014-02-26 Thread Fabio Estevam
From: Fabio Estevam Fix the following static checker warnings: drivers/staging/imx-drm/parallel-display.c:64 imx_pd_connector_get_modes() error: potential null dereference 'mode'. (drm_mode_create returns null) drivers/staging/imx-drm/parallel-display.c:73 imx_pd_connector_get_mode

[PATCH v2 3/6] imx-drm: imx-ldb: Fix array length

2014-02-26 Thread Fabio Estevam
From: Fabio Estevam Fix the following static checker warning: drivers/staging/imx-drm/imx-ldb.c:340 imx_ldb_get_clk() error: format string overflow. buf_size: 16 length: 18 probably 18 is theory and not real life, but 16 is based on theory as well. Reported-by: Dan Carpenter

[PATCH v2 6/6] imx-drm: imx-drm-core: Staticize imx_drm_find_crtc()

2014-02-26 Thread Fabio Estevam
From: Fabio Estevam Fix the following static checker warning: drivers/staging/imx-drm/imx-drm-core.c:89:21: warning: symbol 'imx_drm_find_crtc' was not declared. Should it be static? Reported-by: Dan Carpenter Signed-off-by: Fabio Estevam --- Changes since v1: - None drivers/s

[PATCH v2 5/6] imx-drm: ipuv3-plane: Use %pad to print 'dma_addr_t'

2014-02-26 Thread Fabio Estevam
From: Fabio Estevam Fix the following static checker warning: drivers/staging/imx-drm/ipuv3-plane.c:75:2: warning: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'dma_addr_t' [-Wformat] Use %pad to print 'dma_addr_t'. R

[PATCH v3 1/6] imx-drm: ipu-dmfc: Check 'dmfc' pointer first

2014-02-26 Thread Fabio Estevam
From: Fabio Estevam Fix the following static checker warning: drivers/staging/imx-drm/ipu-v3/ipu-dmfc.c:164 ipu_dmfc_setup_channel() warn: variable dereferenced before check 'dmfc' (see line 157) Reported-by: Dan Carpenter Signed-off-by: Fabio Estevam --- Changes since v2: - No

[PATCH v3 2/6] imx-drm: imx-ldb: Check 'mode' pointer first

2014-02-26 Thread Fabio Estevam
From: Fabio Estevam Fix the following static checker warning: drivers/staging/imx-drm/imx-ldb.c:109 imx_ldb_connector_get_modes() error: potential null dereference 'mode'. (drm_mode_create returns null) Reported-by: Dan Carpenter Signed-off-by: Fabio Estevam --- Changes since

[PATCH v3 4/6] imx-drm: parallel-display: Check 'mode' pointer first

2014-02-26 Thread Fabio Estevam
From: Fabio Estevam Fix the following static checker warnings: drivers/staging/imx-drm/parallel-display.c:64 imx_pd_connector_get_modes() error: potential null dereference 'mode'. (drm_mode_create returns null) drivers/staging/imx-drm/parallel-display.c:73 imx_pd_connector_get_mode

[PATCH v3 5/6] imx-drm: ipuv3-plane: Use %pad to print 'dma_addr_t'

2014-02-26 Thread Fabio Estevam
From: Fabio Estevam Fix the following static checker warning: drivers/staging/imx-drm/ipuv3-plane.c:75:2: warning: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'dma_addr_t' [-Wformat] Use %pad to print 'dma_addr_t'. R

[PATCH v3 6/6] imx-drm: imx-drm-core: Staticize imx_drm_find_crtc()

2014-02-26 Thread Fabio Estevam
From: Fabio Estevam Fix the following static checker warning: drivers/staging/imx-drm/imx-drm-core.c:89:21: warning: symbol 'imx_drm_find_crtc' was not declared. Should it be static? Reported-by: Dan Carpenter Signed-off-by: Fabio Estevam --- Changes since v2: - None Change

[PATCH v3 3/6] imx-drm: imx-ldb: Fix array length

2014-02-26 Thread Fabio Estevam
From: Fabio Estevam Fix the following static checker warning: drivers/staging/imx-drm/imx-ldb.c:340 imx_ldb_get_clk() error: format string overflow. buf_size: 16 length: 18 probably 18 is theory and not real life, but 16 is based on theory as well. Reported-by: Dan Carpenter Signed-off-by

Re: [PATCH v3 3/6] imx-drm: imx-ldb: Fix array length

2014-02-26 Thread Fabio Estevam
On Wed, Feb 26, 2014 at 7:44 PM, Fabio Estevam wrote: > From: Fabio Estevam > > Fix the following static checker warning: > > drivers/staging/imx-drm/imx-ldb.c:340 imx_ldb_get_clk() error: format string > overflow. buf_size: 16 length: 18 > probably 18 is theory and not

[PATCH v4 4/6] imx-drm: parallel-display: Check 'mode' pointer first

2014-02-26 Thread Fabio Estevam
From: Fabio Estevam Fix the following static checker warnings: drivers/staging/imx-drm/parallel-display.c:64 imx_pd_connector_get_modes() error: potential null dereference 'mode'. (drm_mode_create returns null) drivers/staging/imx-drm/parallel-display.c:73 imx_pd_connector_get_mode

[PATCH v4 1/6] imx-drm: ipu-dmfc: Check 'dmfc' pointer first

2014-02-26 Thread Fabio Estevam
From: Fabio Estevam Fix the following static checker warning: drivers/staging/imx-drm/ipu-v3/ipu-dmfc.c:164 ipu_dmfc_setup_channel() warn: variable dereferenced before check 'dmfc' (see line 157) Reported-by: Dan Carpenter Signed-off-by: Fabio Estevam --- Changes since v3: - No

[PATCH v4 2/6] imx-drm: imx-ldb: Check 'mode' pointer first

2014-02-26 Thread Fabio Estevam
From: Fabio Estevam Fix the following static checker warning: drivers/staging/imx-drm/imx-ldb.c:109 imx_ldb_connector_get_modes() error: potential null dereference 'mode'. (drm_mode_create returns null) Reported-by: Dan Carpenter Signed-off-by: Fabio Estevam --- Changes since

[PATCH v4 3/6] imx-drm: imx-ldb: Use snprintf()

2014-02-26 Thread Fabio Estevam
From: Fabio Estevam Use snprintf() in order to fix the following static checker warning: drivers/staging/imx-drm/imx-ldb.c:340 imx_ldb_get_clk() error: format string overflow. buf_size: 16 length: 18 probably 18 is theory and not real life, but 16 is based on theory as well. Reported-by: Dan

[PATCH v4 6/6] imx-drm: imx-drm-core: Staticize imx_drm_find_crtc()

2014-02-26 Thread Fabio Estevam
From: Fabio Estevam Fix the following static checker warning: drivers/staging/imx-drm/imx-drm-core.c:89:21: warning: symbol 'imx_drm_find_crtc' was not declared. Should it be static? Reported-by: Dan Carpenter Signed-off-by: Fabio Estevam --- Changes since v3: - None Change

[PATCH v4 5/6] imx-drm: ipuv3-plane: Use %pad to print 'dma_addr_t'

2014-02-26 Thread Fabio Estevam
From: Fabio Estevam Fix the following static checker warning: drivers/staging/imx-drm/ipuv3-plane.c:75:2: warning: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'dma_addr_t' [-Wformat] Use %pad to print 'dma_addr_t'. R

[PATCH v5 1/2] imx-drm: ipu-dmfc: Remove unneeded 'dmfc' check

2014-02-28 Thread Fabio Estevam
From: Fabio Estevam Fix the following static checker warning: drivers/staging/imx-drm/ipu-v3/ipu-dmfc.c:164 ipu_dmfc_setup_channel() warn: variable dereferenced before check 'dmfc' (see line 157) As 'dmfc' could never be null, there is no need to do such check. Report

[PATCH v5 2/2] imx-drm: imx-ldb: Use snprintf()

2014-02-28 Thread Fabio Estevam
From: Fabio Estevam Use snprintf() in order to fix the following static checker warning: drivers/staging/imx-drm/imx-ldb.c:340 imx_ldb_get_clk() error: format string overflow. buf_size: 16 length: 18 probably 18 is theory and not real life, but 16 is based on theory as well. Reported-by: Dan

Re: [RFC PATCH] staging: imx-drm: add suspend / resume

2014-03-20 Thread Fabio Estevam
e moment since I don't > really know the hardware or driver code well enough to be > sure this is the "right" way of doing it. Does this patch still cause the visual artifacts you mentioned earlier? Regards, Fabio Estevam > > Signed-off-by

[PATCH] imx-hdmi: Propagate the real error code on platform_get_irq() failure

2014-04-05 Thread Fabio Estevam
From: Fabio Estevam No need to return a 'fake' return value on platform_get_irq() failure. Signed-off-by: Fabio Estevam --- drivers/staging/imx-drm/imx-hdmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/imx-drm/imx-hdmi.c b/drivers/staging/i

[PATCH] imx-hdmi: Make checkpatch happy

2014-04-05 Thread Fabio Estevam
From: Fabio Estevam Fix the following checkpatch warnings: WARNING: Missing a blank line after declarations #162: FILE: drivers/staging/imx-drm/imx-hdmi.c:162: + u8 val = hdmi_readb(hdmi, reg) & ~mask; + val |= data & mask; WARNING: Missing a blank line after declarati

[PATCH v2] imx-hdmi: Make checkpatch happy

2014-04-28 Thread Fabio Estevam
From: Fabio Estevam WARNING: Missing a blank line after declarations #160: FILE: drivers/staging/imx-drm/imx-hdmi.c:160: + u8 val = hdmi_readb(hdmi, reg) & ~mask; + val |= data & mask; WARNING: Missing a blank line after declarations #1609: FILE: drivers/staging/imx-drm/im

Re: Shawn Guo: your attetion is needed here Re: [PATCH v8 00/34] i.MX Media Driver

2017-06-20 Thread Fabio Estevam
On Tue, Jun 20, 2017 at 5:29 AM, Pavel Machek wrote: > Hmm. I changed the subject to grab Shawn's attetion. > > But his acks should not be needed for forward progress. Yes, it would > be good, but he does not react -- so just reorder the series so that > dts changes come last, then apply the part

Re: [PATCH] comedi: cb_pcidda: Fix coding style - use BIT macro

2015-11-12 Thread Fabio Estevam
On Wed, Nov 11, 2015 at 2:27 PM, Ranjith Thangavel wrote: > BIT macro is used for defining BIT location instead of > shifting operator - coding style issue I would not call it a coding style issue. ___ devel mailing list de...@linuxdriverproject.org htt

Re: [PATCH v2] staging: nvec: Avoid the use of BUG_ON

2016-02-24 Thread Fabio Estevam
On Tue, Feb 23, 2016 at 5:59 PM, Laura Garcia Liebana wrote: > Prevent a kernel panic by avoiding the use of the BUG_ON macro. > Checkpatch detected this issue. > > Signed-off-by: Laura Garcia Liebana > --- > Changes in v2: > - According to Marc Dietrich, module creator, the WARN_ON macro

Re: [PATCH v4 0/7] staging: fsl-mc: New functionality to the MC bus driver

2015-06-09 Thread Fabio Estevam
Hi German, On Tue, Jun 9, 2015 at 6:59 PM, J. German Rivera wrote: > This patch series includes new functionality for the Freescale fsl-mc > bus driver. > > Patch 1: MC bus IRQ support > Patch 2: add device binding path 'driver_override' > Patch 3: Propagate driver_override for a child DPRC's chi

Re: [PATCH] Drivers: hv: vmbus: fix typo in hv_port_info struct

2015-06-29 Thread Fabio Estevam
On Mon, Jun 29, 2015 at 5:55 PM, Nik Nyby wrote: > This fixes a typo: base_flag_bumber to base_flag_number > > Signed-off-by: Nik Nyby > --- > drivers/hv/hyperv_vmbus.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/hv/hyperv_vmbus.h b/drivers/hv/hyperv_vmbus.h

Re: [PATCH 00/20] i.MX Media Driver

2017-01-02 Thread Fabio Estevam
et includes the OF graph layout as proposed by Philipp Zabel, > with only minor changes which are enumerated in the patch header. Patches 13, 14 and 19 miss your Signed-off-by tag. Tested the whole series on a mx6qsabresd: Tested-by: Fabio Estevam _

Re: [PATCH v2 00/19] i.MX Media Driver

2017-01-03 Thread Fabio Estevam
off-by's. Tested the series on a mx6qsabresd, so: Tested-by: Fabio Estevam ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v2 05/19] ARM: dts: imx6-sabresd: add OV5642 and OV5640 camera sensors

2017-01-04 Thread Fabio Estevam
On Tue, Jan 3, 2017 at 6:57 PM, Steve Longerbeam wrote: > + camera: ov5642@3c { > + compatible = "ovti,ov5642"; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_ov5642>; > + clocks = <&clks IMX6QDL_CLK_CKO>; > + c

[PATCH 1/2] staging: fbtft: fbtft-core: Use '%zu' to print 'size_t' format

2015-02-19 Thread Fabio Estevam
When building for ARM64 the following build warning is seen: drivers/staging/fbtft/fbtft-core.c:1004:4: warning: format '%d' expects argument of type 'int', but argument 3 has type 'size_t' [-Wformat=] Use '%zu' to print 'size_t' format. Signed

[PATCH 2/2] staging: fbtft: fbtft-io: Use '%zu' to print 'size_t' format

2015-02-19 Thread Fabio Estevam
ize_t' [-Wformat=] drivers/staging/fbtft/fbtft-io.c: In function 'fbtft_read_spi': drivers/staging/fbtft/fbtft-io.c:110:5: warning: format '%d' expects argument of type 'int', but argument 4 has type 'size_t' [-Wformat=] Use '%zu' to print 's

[PATCH] staging: dgap: Avoid name collision

2015-03-03 Thread Fabio Estevam
odule.h:10, from drivers/staging/dgap/dgap.c:47: ./arch/arm64/include/asm/memory.h:39:0: note: this is the location of the previous definition #define PCI_IO_SIZE SZ_16M ^ Use PCI_IO_SIZE_DGAP to avoid the name collision. Reported-by: Olof's autobuilder Signed-off-by: Fabio Esteva

[PATCH 3/3] ARM: dts: imx6qdl-sabresd: Add HDMI support

2013-10-02 Thread Fabio Estevam
Signed-off-by: Fabio Estevam --- arch/arm/boot/dts/imx6qdl-sabresd.dtsi | 14 ++ 1 file changed, 14 insertions(+) diff --git a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi index 64e454b..55f261c 100644 --- a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi

[PATCH 2/3] ARM: dts: imx6qdl-wandboard: Add HDMI support

2013-10-02 Thread Fabio Estevam
Signed-off-by: Fabio Estevam --- arch/arm/boot/dts/imx6dl.dtsi| 4 arch/arm/boot/dts/imx6q.dtsi | 4 arch/arm/boot/dts/imx6qdl-wandboard.dtsi | 13 + arch/arm/boot/dts/imx6qdl.dtsi | 10 ++ 4 files changed, 31 insertions(+) diff

Re: [PATCH 1/3] imx-drm: Add mx6 hdmi transmitter support

2013-10-03 Thread Fabio Estevam
927 to test these patches, and I can rebase it against 3.12-rc3 if needed. Will wait for some comments/feedbacks first though. Regards, Fabio Estevam ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH v2 3/3] ARM: dts: imx6qdl-sabresd: Add HDMI support

2013-10-03 Thread Fabio Estevam
Signed-off-by: Fabio Estevam --- Changes since v1: - Put the dt entries in alphabetical order arch/arm/boot/dts/imx6qdl-sabresd.dtsi | 12 1 file changed, 12 insertions(+) diff --git a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi index 39eafc2

[PATCH v2 2/3] ARM: dts: imx6qdl-wandboard: Add HDMI support

2013-10-03 Thread Fabio Estevam
Signed-off-by: Fabio Estevam --- Changes since v1: - None arch/arm/boot/dts/imx6dl.dtsi| 4 arch/arm/boot/dts/imx6q.dtsi | 4 arch/arm/boot/dts/imx6qdl-wandboard.dtsi | 13 + arch/arm/boot/dts/imx6qdl.dtsi | 10 ++ 4 files

[PATCH] imx-drm: imx-drm-core: Fix circular locking dependency

2013-10-09 Thread Fabio Estevam
From: Fabio Estevam Booting a mx6 with CONFIG_PROVE_LOCKING we get: == [ INFO: possible circular locking dependency detected ] 3.12.0-rc4-next-20131009+ #34 Not tainted --- swapper/0/1 is

[PATCH v2] imx-drm: imx-drm-core: Fix circular locking dependency

2013-10-09 Thread Fabio Estevam
From: Fabio Estevam Booting a mx6 with CONFIG_PROVE_LOCKING we get: == [ INFO: possible circular locking dependency detected ] 3.12.0-rc4-next-20131009+ #34 Not tainted --- swapper/0/1 is

Re: [PATCH v2 2/3] ARM: dts: imx6qdl-wandboard: Add HDMI support

2013-10-14 Thread Fabio Estevam
. Will address your comments in v3. Philipp Zabel mentioned that he will move imx-drm out of staging, so will send v3 after Philipp's patch gets into linux-next. Regards, Fabio Estevam ___ devel mailing list de...@lin

Re: [PATCH v2 2/3] ARM: dts: imx6qdl-wandboard: Add HDMI support

2013-10-14 Thread Fabio Estevam
Will run a video test pattern via gstreamer videotestsrc plugin to see how it behaves. I am travelling tomorrow, so it will be at last in 2 weeks that I will be able to access a mx6 hardware. In the meantime, maybe one of the folks in Cc could share some ideas. Regards,

Re: [PATCH v2 1/3] imx-drm: Add mx6 hdmi transmitter support

2013-10-15 Thread Fabio Estevam
gt; > You may wish to combine this patch with patch 1 to sort all that out. > For the patch below: > > Signed-off-by: Russell King > Tested-by: Russell King Thanks, Russell. Will submit v3 when I am back to the office. Regards, Fabio Estevam

Re: [PATCH v3] imx-drm: Add mx6 hdmi transmitter support

2013-10-29 Thread Fabio Estevam
On Mon, Oct 28, 2013 at 7:19 PM, Russell King - ARM Linux wrote: > On Mon, Oct 28, 2013 at 06:26:49PM -0200, Fabio Estevam wrote: >> From: Fabio Estevam >> >> This is based on the initial work done by Sascha Hauer and Tony Prisk. > > It looks like you've also ta

Re: [PATCH v3] imx-drm: Add mx6 hdmi transmitter support

2013-10-29 Thread Fabio Estevam
On Tue, Oct 29, 2013 at 1:00 PM, Fabio Estevam wrote: > Today I was able to get access to a wandboard solo and the HDMI image > does look different compared to a wandboard quad board: > > - The Linux logo penguins are steady on mx6q, but on mx6solo the > contour lines look li

[PATCH] imx-drm: ipuv3-crtc: Invert IPU DI0 clock polarity

2013-10-29 Thread Fabio Estevam
From: Fabio Estevam sig_cfg.clk_pol controls the 'di0_polarity_disp_clk' bit of register IPUx_DI0_GENERAL through the following code in imx-drm/ipu-v3/ipu-di.c: if (!sig->clk_pol) di_gen |= DI_GEN_POLARITY_DISP_CLK; With 'di0_polarity_disp_clk'

Re: [PATCH v3] imx-drm: Add mx6 hdmi transmitter support

2013-10-29 Thread Fabio Estevam
Hi Greg, On Mon, Oct 28, 2013 at 7:03 PM, Greg KH wrote: > On Mon, Oct 28, 2013 at 06:26:49PM -0200, Fabio Estevam wrote: >> From: Fabio Estevam >> >> This is based on the initial work done by Sascha Hauer and Tony Prisk. > > What is "this"? Ok, I will impr

Re: [PATCH] imx-drm: ipuv3-crtc: Invert IPU DI0 clock polarity

2013-10-29 Thread Fabio Estevam
this is only used at: arch/arm/mach-mx6/board-mx6sl_arm2.c: arch/arm/mach-mx6/board-mx6sl_evk.c: arch/arm/mach-mx6/board-mx6sl_evk.c: ,which are all mx6sl boards and mx6sl does not have IPU. Also tested on all the IPUv3 hardware I have access to and all of them work fine with di0_polarity_disp_cl

Re: [PATCH v3] imx-drm: Add mx6 hdmi transmitter support

2013-10-29 Thread Fabio Estevam
On Tue, Oct 29, 2013 at 9:47 PM, Russell King - ARM Linux wrote: > The issues surrounding DT and DRM were given an airing last week at > kernel summit in a session chaired by David Airlie. > > The Kernel Summit session was to discuss issues surrounding DT and DRM, > or more specifically DT and co

Re: [PATCH v4] imx-drm: Add mx6 hdmi transmitter support

2013-10-31 Thread Fabio Estevam
fails > 6 works > Very strange. Interesting. With the monitor I have tested I am not able to see this magenta line. As the erratum says to write 3 or 4 times to the register, then I will use 4 as per your results. Regards, Fabio Estevam ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v4] imx-drm: Add mx6 hdmi transmitter support

2013-10-31 Thread Fabio Estevam
4 as the number of loops according to Troy's results. Regards, Fabio Estevam ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v4] imx-drm: Add mx6 hdmi transmitter support

2013-11-04 Thread Fabio Estevam
tes comes from the following erratum: ERR005173 HDMI: Clarification on HDMI programming procedure to avoid FIFO overflow Regards, Fabio Estevam ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/

Re: [PATCH v4] imx-drm: Add mx6 hdmi transmitter support

2013-11-05 Thread Fabio Estevam
On Tue, Nov 5, 2013 at 9:29 PM, Matt Sealey wrote: > I know about that one. BTW this isn't in the MX6SDL errata > documentation, but it is in the MX6QD errata. If this actually affects > the Solo etc. as Russell dictates, isn't the errata document missing > some info here? If you read the code y

Re: [PATCHv3 3/8] staging: imx-drm: ipuv3-crtc: don't harcode some mode flags.

2013-11-12 Thread Fabio Estevam
Hi Denis, On Tue, Nov 12, 2013 at 2:49 PM, Denis Carikli wrote: > This change is needed for making the eukrea-cpuimx51 > QVGA display work. > > Greg Kroah-Hartman > Cc: driverdev-devel@linuxdriverproject.org > Cc: Philipp Zabel > Cc: Sascha Hauer > Cc: Shawn Guo > Cc: linux-arm-ker...@lists

Re: [PATCH 1/1] staging: imx-drm: Fix build error

2014-01-28 Thread Fabio Estevam
:6: note: originally defined here > > Signed-off-by: Sachin Kamat > Cc: Guennadi Liakhovetski > Cc: Fabio Estevam Reviewed-by: Fabio Estevam ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: imx-hdmi fails to build with v3.13-10094-g9b0cd30

2014-01-30 Thread Fabio Estevam
ev.linuxdriverproject.org/pipermail/driverdev-devel/2014-January/045167.html Regards, Fabio Estevam ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

  1   2   >