Re: [PATCH] Hyperv: Trigger DHCP renew after host hibernation

Le 10/08/2014 20:23, Dexuan Cui a écrit : -Original Message- From: Greg KH [mailto:gre...@linuxfoundation.org] IMO the most feasible and need-the-least-change solution may be: the hyperv network VSC driver passes the event RNDIS_STATUS_NETWORK_CHANGE to the udev daemon? No, don't do

Re: [RFCv2][PATCH 2/5] arm: Implement ARCH_HAS_FORCE_CACHE

On 08/09/2016 05:13 PM, Laura Abbott wrote: > On 08/09/2016 02:56 PM, Florian Fainelli wrote: >> On 08/08/2016 10:49 AM, Laura Abbott wrote: >>> arm may need the kernel_force_cache APIs to guarantee data consistency. >>> Implement versions of these APIs based on the D

Re: [RFCv2][PATCH 2/5] arm: Implement ARCH_HAS_FORCE_CACHE

On 08/08/2016 10:49 AM, Laura Abbott wrote: > arm may need the kernel_force_cache APIs to guarantee data consistency. > Implement versions of these APIs based on the DMA APIs. > > Signed-off-by: Laura Abbott > --- > arch/arm/include/asm/cacheflush.h | 4 ++ >

Re: Is it time to move drivers/staging/netlogic/ out of staging?

On 02/03/2017 12:36 PM, Greg KH wrote: > On Fri, Feb 03, 2017 at 10:57:16AM -0800, Joe Perches wrote: >> On Fri, 2017-02-03 at 10:50 -0800, Florian Fainelli wrote: >>> (with JC's other email) >> >> And now with Greg's proper email too >> >>> On 02/03/

Re: Is it time to move drivers/staging/netlogic/ out of staging?

(with JC's other email) On 02/03/2017 10:47 AM, Joe Perches wrote: > 64 bit stats isn't implemented, but is that really necessary? > Anything else? Joe, do you have such hardware that you are interested in getting supported, or was that just to reduce the amount of drivers in staging? I am

Re: Is it time to move drivers/staging/netlogic/ out of staging?

On 02/03/2017 12:44 PM, Greg KH wrote: > On Fri, Feb 03, 2017 at 12:38:45PM -0800, Florian Fainelli wrote: >> On 02/03/2017 12:36 PM, Greg KH wrote: >>> On Fri, Feb 03, 2017 at 10:57:16AM -0800, Joe Perches wrote: >>>> On Fri, 2017-02-03 at 10:50 -0800, Florian Fa

Re: [PATCH v2] somedriver: remove the initialization of static pointers.

On 02/07/2017 01:55 PM, AbdAllah-MEZITI wrote: > In C a static pointer will be initialized to NULL. > The §6.7.8 of the ISO/IEC 9899:1999 (E) document says that: > If an object that has static storage duration is not initialized > explicitly, then: > __ if it has pointer type, it is initialized

Re: Is it time to move drivers/staging/netlogic/ out of staging?

Le 02/04/17 à 00:08, Greg KH a écrit : > On Fri, Feb 03, 2017 at 06:37:02PM -0800, Florian Fainelli wrote: >> >> >> On 02/03/2017 12:44 PM, Greg KH wrote: >>> On Fri, Feb 03, 2017 at 12:38:45PM -0800, Florian Fainelli wrote: >>>> On 02/03/2017 12:36 PM,

Re: [RFC 3/3] phy,leds: add support for led triggers on phy link state change

On 09/14/2016 02:55 PM, Zach Brown wrote: > From: Josh Cartwright > > Create an option CONFIG_LED_TRIGGER_PHY (default n), which will > create a set of led triggers for each instantiated PHY device. There is > one LED trigger per link-speed, per-phy. > > This allows for

Re: [PATCH v3 net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver

On 11/26/2016 04:20 AM, Lino Sanfilippo wrote: > Add driver for Alacritech gigabit ethernet cards with SLIC (session-layer > interface control) technology. The driver provides basic support without > SLIC for the following devices: > > - Mojave cards (single port PCI Gigabit) both copper and

Re: [net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver

On 11/15/2016 02:34 PM, Lino Sanfilippo wrote: > On 15.11.2016 22:59, Andrew Lunn wrote: >>> The link state is retrieved by a command to the application processor that >>> is running >>> on the network card. Also the register to set the phy configuration is >>> write-only, so >>> it is not even

Re: [net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver

On 11/15/2016 12:46 PM, Lino Sanfilippo wrote: >> Could this be pulled out into a standard PHY driver? All the SLIC >> SLIC_PCR_ defines seems to be the same as those in mii.h. This could >> be a standard PHY hidden behind a single register. >> >>Andrew > > You are right, the driver should

Re: [RFC v3 3/3] phy,leds: add support for led triggers on phy link state change

s is net: phy: foo Other than that: Reviewed-by: Florian Fainelli <f.faine...@gmail.com> Andrew, are you happy with this implementation? [snip] > + > +#ifdef CONFIG_LED_TRIGGER_PHY > + > +#include > +#include > + > +#define PHY_LINK_LED_MAX_TRIGGERS5 > +#define PHY_LED_T

[PATCH] staging: octeon: Call SET_NETDEV_DEV()

n <aaro.koski...@iki.fi> Signed-off-by: Florian Fainelli <f.faine...@gmail.com> --- drivers/staging/octeon/ethernet.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/octeon/ethernet.c b/drivers/staging/octeon/ethernet.c index 8130dfe89745..4971aa54756a 100644 ---

Re: [PATCH v3 net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver

On 11/28/2016 01:41 PM, Lino Sanfilippo wrote: > The problem is that the HW does not provide a tx completion index. Instead we > have to > iterate the status descriptors until we get an invalid idx which indicates > that there > are no further tx descriptors done for now. I am afraid that if

Re: [PATCH] staging: octeon: Call SET_NETDEV_DEV()

On 12/14/2016 05:13 PM, Florian Fainelli wrote: > The Octeon driver calls into PHYLIB which now checks for > net_device->dev.parent, so make sure we do set it before calling into > any MDIO/PHYLIB related function. > > Fixes: ec988ad78ed6 ("phy: Don't increment MDIO b

Re: [PATCH] staging: octeon: Call SET_NETDEV_DEV()

On 12/20/2016 07:20 PM, David Miller wrote: > From: Florian Fainelli <f.faine...@gmail.com> > Date: Tue, 20 Dec 2016 17:02:37 -0800 > >> On 12/14/2016 05:13 PM, Florian Fainelli wrote: >>> The Octeon driver calls into PHYLIB which now checks for >>> net_dev

Re: outreachy

On 03/09/2017 01:20 PM, Greg KH wrote: > On Thu, Mar 09, 2017 at 01:56:49PM -0700, Stephen Warren wrote: >> On 03/09/2017 01:51 PM, Scott Branden wrote: >>> Hi Julia, >>> >>> On 17-03-09 12:36 PM, Julia Lawall wrote: Hello, I discussed the issue of outreachy patches for bcm with

[PATCH net 6/7] netvsc: Initialize 64-bit stats seqcount

pen-coding the 64-bits statistics, except that u64_stats_init() was missed. Fixes: 6c80f3fc2398 ("netvsc: report per-channel stats in ethtool statistics") Signed-off-by: Florian Fainelli <f.faine...@gmail.com> --- drivers/net/hyperv/netvsc.c | 2 ++ 1 file changed, 2 insertions(+)

[PATCH net 6/7] netvsc: Initialize 64-bit stats seqcount

pen-coding the 64-bits statistics, except that u64_stats_init() was missed. Fixes: 6c80f3fc2398 ("netvsc: report per-channel stats in ethtool statistics") Signed-off-by: Florian Fainelli <f.faine...@gmail.com> --- drivers/net/hyperv/netvsc.c | 2 ++ 1 file changed, 2 insertions(+)

Re: [OpenWrt-Devel] [PATCH v3 0/6] staging: Introduce DPAA2 Ethernet Switch driver

On October 14, 2017 2:59:22 PM PDT, Linus Walleij <linus.wall...@linaro.org> wrote: >On Sat, Oct 14, 2017 at 8:52 PM, Florian Fainelli ><f.faine...@gmail.com> wrote: > >> The most deployed switch device drivers have been converted to DSA >> already: b53, qca8k (ar

Re: [OpenWrt-Devel] [PATCH v3 0/6] staging: Introduce DPAA2 Ethernet Switch driver

Hi, On 10/14/2017 04:09 AM, Linus Walleij wrote: > Top posting and resending since net...@vger.kernel.org > is the right mail address for this. Mea culpa. > > Linus Walleij > > On Sat, Oct 14, 2017 at 11:35 AM, Linus Walleij > wrote: >> On Thu, Oct 5, 2017 at 11:16

RE: [RESEND PATCH 2/6] staging: fsl-dpaa2/ethsw: Add Freescale DPAA2 Ethernet Switch driver

On September 29, 2017 6:59:18 AM PDT, Razvan Stefanescu wrote: > > >> -Original Message- >> From: Bogdan Purcareata >> Sent: Friday, September 29, 2017 16:36 >> To: Razvan Stefanescu ; >> gre...@linuxfoundation.org >> Cc:

Re: [PATCH net-next 0/7] net: bridge: Notify about bridge VLANs

Hi Petr, On 05/24/2018 08:09 AM, Petr Machata wrote: > In commit 946a11e7408e ("mlxsw: spectrum_span: Allow bridge for gretap > mirror"), mlxsw got support for offloading mirror-to-gretap such that > the underlay packet path involves a bridge. In that case, the offload is > also influenced by

Re: [PATCH net-next 0/7] net: bridge: Notify about bridge VLANs

On 05/24/2018 10:20 AM, Florian Fainelli wrote: > Hi Petr, > > On 05/24/2018 08:09 AM, Petr Machata wrote: >> In commit 946a11e7408e ("mlxsw: spectrum_span: Allow bridge for gretap >> mirror"), mlxsw got support for offloading mirror-to-gretap such that >&

Re: [PATCH net-next 0/7] net: bridge: Notify about bridge VLANs

port. Correspondingly, all > switchdev drivers have been updated to return -EOPNOTSUPP for bridge > VLAN notifications. This is great, see the other two emails about why I like it so much: Reviewed-by: Florian Fainelli <f.faine...@gmail.com> Tested-by: Florian Fainelli <f.faine...@g

Re: [PATCH net-next v4 5/8] dsa: port: Ignore bridge VLAN events

pecific support for these VLANs, just ignore the > notifications to maintain the current behavior. > > Signed-off-by: Petr Machata > Reviewed-by: Vivien Didelot Reviewed-by: Florian Fainelli -- Florian ___ devel mailing list de...@

Re: [PATCH v3 2/2] dt-bindings: net: dsa: ksz9477: add sample of switch bindings managed in i2c mode

On 12/17/18 12:44 PM, Sergio Paracuellos wrote: > Add device-tree binding example of the ksz9477 switch managed in i2c mode. > > Cc: devicet...@vger.kernel.org > Signed-off-by: Sergio Paracuellos This looks good, although it looks like you have 2x the amount of tabs necessary. -- Florian

Re: [PATCH] dt-bindings: net: dsa: ksz9477: fix indentation for switch spi bindings

Le 12/21/18 à 11:39 PM, Sergio Paracuellos a écrit : > Switch bindings for spi managed mode are using spaces instead of tabs. > Fix them to get a file with a proper kernel indentation style. > > Signed-off-by: Sergio Paracuellos Reviewed-by: Florian Fainelli

Re: [PATCH v2 1/4] staging/vc04_services: Use correct cache line size

On 09/14/2018 06:22 AM, Phil Elwell wrote: > Use the compatible string in the DTB to select the correct cache line > size for the SoC - 32 for BCM2835, and 64 for BCM2836 and BCM2837. > > Signed-off-by: Phil Elwell > --- [snip] > @@ -170,6 +170,14 @@ static struct device *vchiq_dev; > static

Re: [PATCH v2 4/4] ARM: dts: bcm283x: Correct mailbox register sizes

On 09/14/2018 06:22 AM, Phil Elwell wrote: > The size field in a Device Tree "reg" property is encoded in bytes, not > words. > > Signed-off-by: Phil Elwell This should probably have a: Fixes: 614fa22119d6 ("ARM: dts: bcm2835: Add VCHIQ node to the Raspberry Pi boards. (v3)") as well? > ---

Re: [PATCH v3 0/4] Improve VCHIQ cache line size handling

On 09/17/2018 04:47 AM, Phil Elwell wrote: > Hi Stefan, > > On 17/09/2018 12:39, Stefan Wahren wrote: >> Hi Phil, >> >> Am 17.09.2018 um 10:22 schrieb Phil Elwell: >>> Both sides of the VCHIQ communications mechanism need to agree on the cache >>> line size. Using an incorrect value can lead to

Re: [PATCH v3 2/2] dt-bindings: net: dsa: ksz9477: add sample of switch bindings managed in i2c mode

On 12/18/18 10:23 PM, Sergio Paracuellos wrote: > Hi Rob, > > On Tue, Dec 18, 2018 at 4:10 PM Rob Herring wrote: >> >> On Mon, Dec 17, 2018 at 09:44:23PM +0100, Sergio Paracuellos wrote: >>> Add device-tree binding example of the ksz9477 switch managed in i2c mode. >>> >>> Cc:

Re: [PATCH net-next 7/8] net: switchdev: Replace port attr set SDO with a notification

On 2/25/19 1:49 AM, Ido Schimmel wrote: > On Sun, Feb 24, 2019 at 08:47:27AM -0800, Florian Fainelli wrote: >> Le 2/23/19 à 2:32 AM, Ido Schimmel a écrit : >>> On Fri, Feb 22, 2019 at 03:59:25PM -0800, Florian Fainelli wrote: >>>> - if (attr->flags & SWI

Re: [PATCH net] staging: fsl-dpaa2: ethsw: Add missing netdevice check

Le 2/23/19 à 12:45 AM, Ioana Ciornei a écrit : > >> Subject: [PATCH net] staging: fsl-dpaa2: ethsw: Add missing netdevice check >> >> port_switchdev_event() does not check that the target network device is >> actually backed by the ethsw driver, this could be problematic in a stacked >>

Re: [PATCH net-next 7/8] net: switchdev: Replace port attr set SDO with a notification

Le 2/23/19 à 2:32 AM, Ido Schimmel a écrit : > On Fri, Feb 22, 2019 at 03:59:25PM -0800, Florian Fainelli wrote: >> Drop switchdev_ops.switchdev_port_attr_set. Drop the uses of this field >> from all clients, which were migrated to use switchdev notification in >> the previo

[PATCH net-next v3 8/8] net: Remove switchdev_ops

Now that we have converted all possible callers to using a switchdev notifier for attributes we do not have a need for implementing switchdev_ops anymore, and this can be removed from all drivers the net_device structure. Signed-off-by: Florian Fainelli --- drivers/net/ethernet/mellanox/mlxsw

[PATCH net-next v3 6/8] staging: fsl-dpaa2: ethsw: Handle SWITCHDEV_PORT_ATTR_SET

-off-by: Florian Fainelli --- drivers/staging/fsl-dpaa2/ethsw/ethsw.c | 21 + 1 file changed, 21 insertions(+) diff --git a/drivers/staging/fsl-dpaa2/ethsw/ethsw.c b/drivers/staging/fsl-dpaa2/ethsw/ethsw.c index 018399ee8731..b0d2d9bf2532 100644 --- a/drivers/staging/fsl-dpaa2

[PATCH net-next v3 7/8] net: switchdev: Replace port attr set SDO with a notification

switchdev_port_attr_set() likewise. Signed-off-by: Florian Fainelli --- net/bridge/br_switchdev.c | 8 +- net/switchdev/switchdev.c | 53 ++- 2 files changed, 31 insertions(+), 30 deletions(-) diff --git a/net/bridge/br_switchdev.c b/net/bridge/br_switchdev.c index

[PATCH net-next v3 5/8] net: mscc: ocelot: Handle SWITCHDEV_PORT_ATTR_SET

events. Signed-off-by: Florian Fainelli --- drivers/net/ethernet/mscc/ocelot.c | 27 drivers/net/ethernet/mscc/ocelot.h | 1 + drivers/net/ethernet/mscc/ocelot_board.c | 2 ++ 3 files changed, 30 insertions(+) diff --git a/drivers/net/ethernet/mscc/ocelot.c b

[PATCH net-next v3 4/8] mlxsw: spectrum_switchdev: Handle SWITCHDEV_PORT_ATTR_SET

-by: Ido Schimmel Signed-off-by: Florian Fainelli --- .../net/ethernet/mellanox/mlxsw/spectrum_switchdev.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c index

[PATCH net-next v3 0/8] net: Remove switchdev_ops

this is required Florian Fainelli (8): switchdev: Add SWITCHDEV_PORT_ATTR_SET rocker: Handle SWITCHDEV_PORT_ATTR_SET net: dsa: Handle SWITCHDEV_PORT_ATTR_SET mlxsw: spectrum_switchdev: Handle SWITCHDEV_PORT_ATTR_SET net: mscc: ocelot: Handle SWITCHDEV_PORT_ATTR_SET staging: fsl-dpaa2: ethsw

[PATCH net-next v3 2/8] rocker: Handle SWITCHDEV_PORT_ATTR_SET

into something that rocker_port_attr_set() can process. Signed-off-by: Florian Fainelli --- drivers/net/ethernet/rocker/rocker_main.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/drivers/net/ethernet/rocker/rocker_main.c b/drivers/net/ethernet/rocker/rocker_main.c index

[PATCH net-next v3 3/8] net: dsa: Handle SWITCHDEV_PORT_ATTR_SET

into something that dsa_slave_port_attr_set() can process. Signed-off-by: Florian Fainelli --- net/dsa/slave.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/net/dsa/slave.c b/net/dsa/slave.c index 7274499293c9..b089b43120e1 100644 --- a/net/dsa/slave.c +++ b/net/dsa/slave.c

[PATCH net-next v3 1/8] switchdev: Add SWITCHDEV_PORT_ATTR_SET

In preparation for allowing switchdev enabled drivers to veto specific attribute settings from within the context of the caller, introduce a new switchdev notifier type for port attributes. Suggested-by: Ido Schimmel Reviewed-by: Ido Schimmel Signed-off-by: Florian Fainelli --- include/net

[PATCH net] staging: fsl-dpaa2: ethsw: Add missing netdevice check

port_switchdev_event() does not check that the target network device is actually backed by the ethsw driver, this could be problematic in a stacked environment case. Fixes: 44baaa43d7cc ("staging: fsl-dpaa2/ethsw: Add Freescale DPAA2 Ethernet Switch driver") Signed-off-by: Floria

[PATCH net-next 3/8] net: dsa: Handle SWITCHDEV_PORT_ATTR_SET

into something that dsa_slave_port_attr_set() can process. Signed-off-by: Florian Fainelli --- net/dsa/slave.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/net/dsa/slave.c b/net/dsa/slave.c index a78b2bba0332..49a5b29fe884 100644 --- a/net/dsa/slave.c +++ b/net/dsa/slave.c

[PATCH net-next 8/8] net: Remove switchdev_ops

Now that we have converted all possible callers to using a switchdev notifier for attributes we do not have a need for implementing switchdev_ops anymore, and this can be removed from all drivers the net_device structure. Signed-off-by: Florian Fainelli --- .../net/ethernet/mellanox/mlxsw

[PATCH net-next 6/8] staging: fsl-dpaa2: ethsw: Handle SWITCHDEV_PORT_ATTR_SET

-off-by: Florian Fainelli --- drivers/staging/fsl-dpaa2/ethsw/ethsw.c | 21 + 1 file changed, 21 insertions(+) diff --git a/drivers/staging/fsl-dpaa2/ethsw/ethsw.c b/drivers/staging/fsl-dpaa2/ethsw/ethsw.c index 018399ee8731..73efc2a5fd91 100644 --- a/drivers/staging/fsl-dpaa2

[PATCH net-next 5/8] net: mscc: ocelot: Handle SWITCHDEV_PORT_ATTR_SET

events. Signed-off-by: Florian Fainelli --- drivers/net/ethernet/mscc/ocelot.c | 27 drivers/net/ethernet/mscc/ocelot.h | 1 + drivers/net/ethernet/mscc/ocelot_board.c | 2 ++ 3 files changed, 30 insertions(+) diff --git a/drivers/net/ethernet/mscc/ocelot.c b

[PATCH net-next 0/8] net: Remove switchdev_ops

with the forwarding selftests and DSA hardware. Ido, Jiri, please review :) Florian Fainelli (8): switchdev: Add SWITCHDEV_PORT_ATTR_SET rocker: Handle SWITCHDEV_PORT_ATTR_SET net: dsa: Handle SWITCHDEV_PORT_ATTR_SET mlxsw: spectrum_switchdev: Handle SWITCHDEV_PORT_ATTR_SET net: mscc

[PATCH net-next 4/8] mlxsw: spectrum_switchdev: Handle SWITCHDEV_PORT_ATTR_SET

-off-by: Florian Fainelli --- .../net/ethernet/mellanox/mlxsw/spectrum_switchdev.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c index 766f5b5f1cf5..c1aedfea3a31

[PATCH net-next 2/8] rocker: Handle SWITCHDEV_PORT_ATTR_SET

into something that rocker_port_attr_set() can process. Signed-off-by: Florian Fainelli --- drivers/net/ethernet/rocker/rocker_main.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/drivers/net/ethernet/rocker/rocker_main.c b/drivers/net/ethernet/rocker/rocker_main.c index

[PATCH 1/8] switchdev: Add SWITCHDEV_PORT_ATTR_SET

In preparation for allowing switchdev enabled drivers to veto specific attribute settings from within the context of the caller, introduce a new switchdev notifier type for port attributes. Suggested-by: Ido Schimmel Signed-off-by: Florian Fainelli --- include/net/switchdev.h | 27

[PATCH net-next 1/8] switchdev: Add SWITCHDEV_PORT_ATTR_SET

In preparation for allowing switchdev enabled drivers to veto specific attribute settings from within the context of the caller, introduce a new switchdev notifier type for port attributes. Suggested-by: Ido Schimmel Signed-off-by: Florian Fainelli --- include/net/switchdev.h | 27

[PATCH net-next 7/8] net: switchdev: Replace port attr set SDO with a notification

, depending on SWITCHDEV_F_DEFER to call the blocking (process) or non-blocking (atomic) notifier chain accordingly. Drop __switchdev_port_attr_set() and update switchdev_port_attr_set() likewise. Signed-off-by: Florian Fainelli --- net/switchdev/switchdev.c | 96

[PATCH net-next] switchdev: Remove unused transaction item queue

ccordingly since. Signed-off-by: Florian Fainelli --- Documentation/networking/switchdev.txt | 19 - include/net/switchdev.h| 12 --- net/switchdev/switchdev.c | 100 + 3 files changed, 2 insertions(+), 129 deletions(-) diff --git a/Doc

[PATCH net-next v2 8/8] net: Remove switchdev_ops

Now that we have converted all possible callers to using a switchdev notifier for attributes we do not have a need for implementing switchdev_ops anymore, and this can be removed from all drivers the net_device structure. Signed-off-by: Florian Fainelli --- drivers/net/ethernet/mellanox/mlxsw

[PATCH net-next v2 6/8] staging: fsl-dpaa2: ethsw: Handle SWITCHDEV_PORT_ATTR_SET

-off-by: Florian Fainelli --- drivers/staging/fsl-dpaa2/ethsw/ethsw.c | 21 + 1 file changed, 21 insertions(+) diff --git a/drivers/staging/fsl-dpaa2/ethsw/ethsw.c b/drivers/staging/fsl-dpaa2/ethsw/ethsw.c index 018399ee8731..b0d2d9bf2532 100644 --- a/drivers/staging/fsl-dpaa2

[PATCH net-next v2 5/8] net: mscc: ocelot: Handle SWITCHDEV_PORT_ATTR_SET

events. Signed-off-by: Florian Fainelli --- drivers/net/ethernet/mscc/ocelot.c | 27 drivers/net/ethernet/mscc/ocelot.h | 1 + drivers/net/ethernet/mscc/ocelot_board.c | 2 ++ 3 files changed, 30 insertions(+) diff --git a/drivers/net/ethernet/mscc/ocelot.c b

[PATCH net-next v2 7/8] net: switchdev: Replace port attr set SDO with a notification

switchdev_port_attr_set() likewise. Signed-off-by: Florian Fainelli --- net/bridge/br_switchdev.c | 7 +- net/switchdev/switchdev.c | 53 ++- 2 files changed, 30 insertions(+), 30 deletions(-) diff --git a/net/bridge/br_switchdev.c b/net/bridge/br_switchdev.c index

[PATCH net-next v2 1/8] switchdev: Add SWITCHDEV_PORT_ATTR_SET

In preparation for allowing switchdev enabled drivers to veto specific attribute settings from within the context of the caller, introduce a new switchdev notifier type for port attributes. Suggested-by: Ido Schimmel Signed-off-by: Florian Fainelli --- include/net/switchdev.h | 27

[PATCH net-next v2 2/8] rocker: Handle SWITCHDEV_PORT_ATTR_SET

into something that rocker_port_attr_set() can process. Signed-off-by: Florian Fainelli --- drivers/net/ethernet/rocker/rocker_main.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/drivers/net/ethernet/rocker/rocker_main.c b/drivers/net/ethernet/rocker/rocker_main.c index

[PATCH net-next v2 0/8] net: Remove switchdev_ops

directly call the atomic notifier from the single location where this is required Florian Fainelli (8): switchdev: Add SWITCHDEV_PORT_ATTR_SET rocker: Handle SWITCHDEV_PORT_ATTR_SET net: dsa: Handle SWITCHDEV_PORT_ATTR_SET mlxsw: spectrum_switchdev: Handle SWITCHDEV_PORT_ATTR_SET net: mscc

[PATCH net-next v2 3/8] net: dsa: Handle SWITCHDEV_PORT_ATTR_SET

into something that dsa_slave_port_attr_set() can process. Signed-off-by: Florian Fainelli --- net/dsa/slave.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/net/dsa/slave.c b/net/dsa/slave.c index 7274499293c9..b089b43120e1 100644 --- a/net/dsa/slave.c +++ b/net/dsa/slave.c

[PATCH net-next v2 4/8] mlxsw: spectrum_switchdev: Handle SWITCHDEV_PORT_ATTR_SET

-off-by: Florian Fainelli --- .../net/ethernet/mellanox/mlxsw/spectrum_switchdev.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c index 766f5b5f1cf5..c1aedfea3a31

[PATCH net-next v3 4/8] net: dsa: Add setter for SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS

toggling those bridge port attributes (yet). Signed-off-by: Florian Fainelli --- net/dsa/dsa_priv.h | 2 ++ net/dsa/port.c | 12 net/dsa/slave.c| 4 3 files changed, 18 insertions(+) diff --git a/net/dsa/dsa_priv.h b/net/dsa/dsa_priv.h index f4f99ec29f5d..47a1d1379d15 100644

[PATCH net-next v3 2/8] mlxsw: spectrum: Handle PORT_PRE_BRIDGE_FLAGS

In preparation for getting rid of switchdev_port_attr_get(), have mlxsw check for the bridge flags being set through switchdev_port_attr_set() when the SWITCHDEV_ATTR_ID_PORT_PRE_BRIDGE_FLAGS attribute identifier is used. Signed-off-by: Florian Fainelli --- .../ethernet/mellanox/mlxsw

[PATCH net-next v3 1/8] net: switchdev: Add PORT_PRE_BRIDGE_FLAGS

or not. This is entirely analoguous to how the BRIDGE_FLAGS_SUPPORT works, except it goes through a set() instead of get(). Signed-off-by: Florian Fainelli --- include/net/switchdev.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/net/switchdev.h b/include/net/switchdev.h

[PATCH net-next v3 3/8] staging: fsl-dpaa2: ethsw: Handle PORT_PRE_BRIDGE_FLAGS

In preparation for removing SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS_SUPPORT, handle the SWITCHDEV_ATTR_ID_PORT_PRE_BRIDGE_FLAGS attribute and check that the bridge port flags being configured are supported. Signed-off-by: Florian Fainelli --- drivers/staging/fsl-dpaa2/ethsw/ethsw.c | 14

[PATCH net-next v3 0/8] net: Get rid of switchdev_port_attr_get()

t;mask" instead of "flags" for the PRE_BRIDGE_FLAGS check - skip prepare phase for PRE_BRIDGE_FLAGS - corrected documentation a bit more - tested bridge_vlan_aware.sh with veth/VRF Florian Fainelli (8): net: switchdev: Add PORT_PRE_BRIDGE_FLAGS mlxsw: spectrum: Handle PORT_P

[PATCH net-next v3 7/8] net: Remove SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS_SUPPORT

off-by: Florian Fainelli --- Documentation/networking/switchdev.txt | 6 ++ .../ethernet/mellanox/mlxsw/spectrum_switchdev.c | 11 +-- drivers/net/ethernet/rocker/rocker_main.c| 14 +- drivers/staging/fsl-dpaa2/ethsw/ethsw.c | 10 +- include/

[PATCH net-next v3 6/8] net: bridge: Stop calling switchdev_port_attr_get()

-by: Florian Fainelli --- net/bridge/br_switchdev.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/net/bridge/br_switchdev.c b/net/bridge/br_switchdev.c index db9e8ab96d48..af57c4a2b78a 100644 --- a/net/bridge/br_switchdev.c +++ b/net/bridge/br_switchdev.c @@ -64,21

[PATCH net-next v3 5/8] rocker: Check Handle PORT_PRE_BRIDGE_FLAGS

In preparation for getting rid of switchdev_port_attr_get(), have rocker check for the bridge flags being set through switchdev_port_attr_set() with the SWITCHDEV_ATTR_ID_PORT_PRE_BRIDGE_FLAGS attribute identifier. Signed-off-by: Florian Fainelli --- drivers/net/ethernet/rocker/rocker_main.c

[PATCH net-next v3 8/8] net: Get rid of switchdev_port_attr_get()

since this was the only place where it was called. Signed-off-by: Florian Fainelli --- Documentation/networking/switchdev.txt | 2 +- drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c | 7 --- drivers/net/ethernet/rocker/rocker_main.c| 7

[PATCH net-next v4 10/12] staging: fsl-dpaa2: ethsw: Implement ndo_get_port_parent_id()

ethsw implements SWITCHDEV_ATTR_ID_PORT_PARENT_ID and we want to get rid of switchdev_ops eventually, ease that migration by implementing a ndo_get_port_parent_id() function which returns what switchdev_port_attr_get() would do. Signed-off-by: Florian Fainelli --- drivers/staging/fsl-dpaa2

[PATCH net-next v4 11/12] net: dsa: Implement ndo_get_port_parent_id()

DSA implements SWITCHDEV_ATTR_ID_PORT_PARENT_ID and we want to get rid of switchdev_ops eventually, ease that migration by implementing a ndo_get_port_parent_id() function which returns what switchdev_port_attr_get() would do. Acked-by: Jiri Pirko Signed-off-by: Florian Fainelli --- net/dsa

[PATCH net-next v4 03/12] liquidio: Implement ndo_get_port_parent_id()

Liquidio only supports SWITCHDEV_ATTR_ID_PORT_PARENT_ID, which makes it a great candidate to be converted to use the ndo_get_port_parent_id() NDO instead of implementing switchdev_port_attr_get(). Acked-by: Jiri Pirko Signed-off-by: Florian Fainelli --- .../net/ethernet/cavium/liquidio

[PATCH net-next v4 04/12] net/mlx5e: Implement ndo_get_port_parent_id()

(). Acked-by: Jiri Pirko Signed-off-by: Florian Fainelli --- .../ethernet/mellanox/mlx5/core/en/tc_tun.c | 2 +- .../net/ethernet/mellanox/mlx5/core/en_rep.c | 31 +++ .../net/ethernet/mellanox/mlx5/core/en_tc.c | 5 ++- 3 files changed, 14 insertions(+), 24 deletions(-) diff

[PATCH net-next v4 08/12] rocker: Implement ndo_get_port_parent_id()

mlxsw implements SWITCHDEV_ATTR_ID_PORT_PARENT_ID and we want to get rid of switchdev_ops eventually, ease that migration by implementing a ndo_get_port_parent_id() function which returns what switchdev_port_attr_get() would do. Acked-by: Jiri Pirko Signed-off-by: Florian Fainelli --- drivers

[PATCH net-next v4 06/12] mscc: ocelot: Implement ndo_get_port_parent_id()

Ocelot only supports SWITCHDEV_ATTR_ID_PORT_PARENT_ID as a valid switchdev attribute getter, convert it to use ndo_get_port_parent_id() and get rid of the switchdev_ops::switchdev_port_attr_get altogether. Acked-by: Jiri Pirko Signed-off-by: Florian Fainelli --- drivers/net/ethernet/mscc

[PATCH net-next v4 09/12] netdevsim: Implement ndo_get_port_parent_id()

netdevsim only supports SWITCHDEV_ATTR_ID_PORT_PARENT_ID, which makes it a great candidate to be converted to use the ndo_get_port_parent_id() NDO instead of implementing switchdev_port_attr_get(). Acked-by: Jiri Pirko Signed-off-by: Florian Fainelli --- drivers/net/netdevsim/netdev.c | 23

[PATCH net-next v4 07/12] nfp: Implement ndo_get_port_parent_id()

-by: Jiri Pirko Signed-off-by: Florian Fainelli --- .../ethernet/netronome/nfp/flower/action.c| 3 +-- .../ethernet/netronome/nfp/nfp_net_common.c | 4 +--- .../net/ethernet/netronome/nfp/nfp_net_repr.c | 4 +--- drivers/net/ethernet/netronome/nfp/nfp_port.c | 22 +-- drivers

[PATCH net-next v4 05/12] mlxsw: Implement ndo_get_port_parent_id()

mlxsw implements SWITCHDEV_ATTR_ID_PORT_PARENT_ID and we want to get rid of switchdev_ops eventually, ease that migration by implementing a ndo_get_port_parent_id() function which returns what switchdev_port_attr_get() would do. Acked-by: Jiri Pirko Signed-off-by: Florian Fainelli --- .../net

[PATCH net-next v4 12/12] net: Get rid of SWITCHDEV_ATTR_ID_PORT_PARENT_ID

Now that we have a dedicated NDO for getting a port's parent ID, get rid of SWITCHDEV_ATTR_ID_PORT_PARENT_ID and convert all callers to use the NDO exclusively. This is a preliminary change to getting rid of switchdev_ops eventually. Signed-off-by: Florian Fainelli --- include/net/switchdev.h

[PATCH net-next v4 02/12] bnxt: Implement ndo_get_port_parent_id()

uses of switchdev_port_same_parent_id() convert it to use netdev_port_same_parent_id(). Acked-by: Jiri Pirko Signed-off-by: Florian Fainelli --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 28 ++- drivers/net/ethernet/broadcom/bnxt/bnxt.h | 4 +-- drivers/net/ethernet

[PATCH net-next v4 01/12] net: Introduce ndo_get_port_parent_id()

Signed-off-by: Florian Fainelli --- include/linux/netdevice.h | 9 +++ net/bridge/br_switchdev.c | 9 +-- net/core/dev.c| 57 +++ net/core/net-sysfs.c | 7 - net/core/rtnetlink.c | 6 - net/ipv4/ipmr.c | 8

[PATCH net-next v4 00/12] net: Introduce ndo_get_port_parent_id()

relevant drivers to use it - get rid of SWITCHDEV_ATTR_ID_PORT_PARENT_ID A subsequent set of patches will convert switchdev_port_attr_set() to use a blocking notifier call, and still get rid of switchdev_port_attr_get() altogether. Florian Fainelli (12): net: Introduce ndo_get_port_parent_id

Re: [PATCH net-next 15/16] net: switchdev: Replace port attr set SDO with a notification

On 2/8/19 4:32 PM, Florian Fainelli wrote: > Drop switchdev_ops.switchdev_port_attr_set. Drop the uses of this field > from all clients, which were migrated to use switchdev notification in > the previous patches. > > Add a new function switchdev_port_attr_notify() that send

[PATCH net-next 15/16] net: switchdev: Replace port attr set SDO with a notification

__switchdev_port_attr_set() and update switchdev_port_attr_set() likewise. Signed-off-by: Florian Fainelli --- include/net/switchdev.h | 18 net/switchdev/switchdev.c | 92 ++- 2 files changed, 22 insertions(+), 88 deletions(-) diff --git a/include/net

[PATCH net-next 11/16] net: dsa: Handle SWITCHDEV_PORT_ATTR_SET

() call. Signed-off-by: Florian Fainelli --- net/dsa/slave.c | 20 1 file changed, 20 insertions(+) diff --git a/net/dsa/slave.c b/net/dsa/slave.c index ae34be949d79..f8c7c1b2cd2f 100644 --- a/net/dsa/slave.c +++ b/net/dsa/slave.c @@ -1544,6 +1544,24

[PATCH net-next 16/16] net: Remove switchdev_ops

Now that we have converted all possible callers to using a switchdev notifier for attributes we do not have a need for implementing switchdev_ops anymore, and this can be removed from all drivers the net_device structure. Signed-off-by: Florian Fainelli --- drivers/net/ethernet/mellanox/mlxsw

[PATCH net-next 01/16] Documentation: networking: switchdev: Update port parent ID section

ot;net: Get rid of SWITCHDEV_ATTR_ID_PORT_PARENT_ID") Signed-off-by: Florian Fainelli --- Documentation/networking/switchdev.txt | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/Documentation/networking/switchdev.txt b/Documentation/networking/switchdev.txt index f3244d

[PATCH net-next 14/16] staging: fsl-dpaa2: ethsw: Handle SWITCHDEV_PORT_ATTR_SET

() call. Signed-off-by: Florian Fainelli --- drivers/staging/fsl-dpaa2/ethsw/ethsw.c | 20 1 file changed, 20 insertions(+) diff --git a/drivers/staging/fsl-dpaa2/ethsw/ethsw.c b/drivers/staging/fsl-dpaa2/ethsw/ethsw.c index b195b09e0d1d..d40bdcadd569 100644 --- a/drivers/staging

[PATCH net-next 07/16] net: Remove SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS_SUPPORT

Now that we have converted the bridge code and the drivers to check for bridge port(s) flags at the time we try to set them, there is no need for a get() -> set() sequence anymore and SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS_SUPPORT therefore becomes unused. Signed-off-by: Florian Faine

[PATCH net-next 12/16] mlxsw: spectrum_switchdev: Handle SWITCHDEV_PORT_ATTR_SET

() call. Signed-off-by: Florian Fainelli --- .../mellanox/mlxsw/spectrum_switchdev.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c index 6b09d68671cf

[PATCH net-next 10/16] rocker: Handle SWITCHDEV_PORT_ATTR_SET

call. Signed-off-by: Florian Fainelli --- drivers/net/ethernet/rocker/rocker_main.c | 20 1 file changed, 20 insertions(+) diff --git a/drivers/net/ethernet/rocker/rocker_main.c b/drivers/net/ethernet/rocker/rocker_main.c index ff3f14504f4f..f10e4888ecff 100644 --- a/drivers

[PATCH net-next 13/16] net: mscc: ocelot: Handle SWITCHDEV_PORT_ATTR_SET

() call. Signed-off-by: Florian Fainelli --- drivers/net/ethernet/mscc/ocelot.c | 24 1 file changed, 20 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/mscc/ocelot.c b/drivers/net/ethernet/mscc/ocelot.c index 195306d05bcd..adab478d36f1 100644 --- a/drivers

[PATCH net-next 08/16] net: Get rid of switchdev_port_attr_get()

since this was the only place where it was called. Signed-off-by: Florian Fainelli --- Documentation/networking/switchdev.txt| 5 ++- .../mellanox/mlxsw/spectrum_switchdev.c | 32 --- drivers/net/ethernet/rocker/rocker_main.c | 30 - drivers

[PATCH net-next 04/16] net: dsa: Add setter for SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS

-off-by: Florian Fainelli --- net/dsa/dsa_priv.h | 3 +++ net/dsa/port.c | 10 ++ net/dsa/slave.c| 4 3 files changed, 17 insertions(+) diff --git a/net/dsa/dsa_priv.h b/net/dsa/dsa_priv.h index 1f4972dab9f2..97594f0b6efb 100644 --- a/net/dsa/dsa_priv.h +++ b/net/dsa

  1   2   3   >