Re: [PATCH 04/44] m68k: Replace mach_power_off with pm_power_off

2014-10-07 Thread Geert Uytterhoeven
On Tue, Oct 7, 2014 at 7:28 AM, Guenter Roeck li...@roeck-us.net wrote: Replace mach_power_off with pm_power_off to simplify the subsequent move of pm_power_off to generic code. Thanks! Cc: Geert Uytterhoeven ge...@linux-m68k.org Cc: Greg Ungerer g...@uclinux.org Cc: Joshua Thompson fun

Re: [PATCH 08/44] kernel: Move pm_power_off to common code

2014-10-07 Thread Geert Uytterhoeven
do_kernel_poweroff from machine_power_off instead. arch/m68k/kernel/process.c | 6 +- Acked-by: Geert Uytterhoeven ge...@linux-m68k.org Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal

Re: [PATCH 35/44] m68k: Register with kernel poweroff handler

2014-10-07 Thread Geert Uytterhoeven
On Tue, Oct 7, 2014 at 7:28 AM, Guenter Roeck li...@roeck-us.net wrote: Register with kernel poweroff handler instead of setting pm_power_off directly. Cc: Geert Uytterhoeven ge...@linux-m68k.org Cc: Joshua Thompson fun...@jurai.org Signed-off-by: Guenter Roeck li...@roeck-us.net As someone

Re: [PATCH 01/44] kernel: Add support for poweroff handler call chain

2014-10-09 Thread Geert Uytterhoeven
to look up symbols? pr_warn(Poweroff function already registered (%ps), cannot register %ps\n, poweroff_handler_data.handler, handler); + return -EBUSY; + } Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge

[PATCH 08/12] staging: usbip: Remove superfluous name cast

2013-11-12 Thread Geert Uytterhoeven
platform_device.name is const char * Signed-off-by: Geert Uytterhoeven ge...@linux-m68k.org Cc: Greg Kroah-Hartman gre...@linuxfoundation.org Cc: de...@driverdev.osuosl.org --- drivers/staging/usbip/vhci_hcd.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging

[PATCH 07/12] staging: r8188eu: Remove superfluous name cast

2013-11-12 Thread Geert Uytterhoeven
usb_driver.name is const char * Signed-off-by: Geert Uytterhoeven ge...@linux-m68k.org Cc: Greg Kroah-Hartman gre...@linuxfoundation.org Cc: de...@driverdev.osuosl.org --- drivers/staging/rtl8188eu/os_dep/usb_intf.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[PATCH 06/12] staging: Remove superfluous name casts

2013-11-12 Thread Geert Uytterhoeven
device_driver.name is const char * Signed-off-by: Geert Uytterhoeven ge...@linux-m68k.org Cc: Greg Kroah-Hartman gre...@linuxfoundation.org Cc: de...@driverdev.osuosl.org --- drivers/staging/dwc2/platform.c |2 +- drivers/staging/usbip/vhci_hcd.c |2 +- 2 files changed, 2 insertions

[PATCH] Staging: btmtk_usb: Add hdev parameter to hdev-send driver callback

2013-11-15 Thread Geert Uytterhoeven
callback). Signed-off-by: Geert Uytterhoeven ge...@linux-m68k.org --- drivers/staging/btmtk_usb/btmtk_usb.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/btmtk_usb/btmtk_usb.c b/drivers/staging/btmtk_usb/btmtk_usb.c index 7a9bf3b57810..9a5ebd6cc512

[PATCH -v2 09/10] mfd: staging: Constify struct mfd_cell where possible

2013-11-18 Thread Geert Uytterhoeven
As of commit 03e361b25ee8dfb1fd9b890072c23c4aae01c6c7 (mfd: Stop setting refcounting pointers in original mfd_cell arrays), the cell parameter of mfd_add_devices() is const again. Hence make all cell data passed to mfd_add_devices() const where possible. Signed-off-by: Geert Uytterhoeven ge

Re: [RFC PATCH 1/5] gpu: ipu-v3: Move i.MX IPUv3 core driver out of staging

2013-12-21 Thread Geert Uytterhoeven
. diff against /dev/null). If yes, please ignore my comments. Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking

Re: [PATCH 5/5] lustre: add myself to list of people to CC on lustre patches

2014-01-24 Thread Geert Uytterhoeven
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say programmer or something like that. -- Linus Torvalds

Re: [PATCH 5/5] lustre: add myself to list of people to CC on lustre patches

2014-01-28 Thread Geert Uytterhoeven
On Sat, Jan 25, 2014 at 4:23 AM, Oleg Drokin gr...@linuxhacker.ru wrote: On Jan 24, 2014, at 3:55 AM, Geert Uytterhoeven wrote: On Fri, Jan 24, 2014 at 6:51 AM, Oleg Drokin gr...@linuxhacker.ru wrote: +STAGING - LUSTRE +M: Andreas Dilger andreas.dil...@intel.com +M: Oleg Drokin oleg.dro

[PATCH -next] staging: comedi: Add missing #include linux/slab.h

2013-07-25 Thread Geert Uytterhoeven
-by: Geert Uytterhoeven ge...@linux-m68k.org --- http://kisskb.ellerman.id.au/kisskb/buildresult/9187516/ http://kisskb.ellerman.id.au/kisskb/buildresult/9186576/ drivers/staging/comedi/drivers/addi_apci_2032.c |1 + drivers/staging/comedi/drivers/amplc_pci224.c |1 + 2 files changed, 2

[PATCH -next] staging: dgnc: driver.c: Add missing #include linux/slab.h

2013-08-23 Thread Geert Uytterhoeven
: error: implicit declaration of function ‘kmalloc’ drivers/staging/dgnc/dgnc_driver.c:905: warning: initialization makes pointer from integer without a cast Signed-off-by: Geert Uytterhoeven ge...@linux-m68k.org --- http://kisskb.ellerman.id.au/kisskb/buildresult/9356764/ http

Re: [PATCH V8 11/33] dio: Convert direct_IO to use iov_iter

2013-08-23 Thread Geert Uytterhoeven
memory is being passed to the function. Lustre in -next also needs to be updated: drivers/staging/lustre/lustre/llite/rw26.c:549: warning: initialization from incompatible pointer type Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge

[PATCH -next] staging: lustre: Use proper constant types for L*_POISON values

2013-08-23 Thread Geert Uytterhoeven
On 32-bit m68k, I get lots of warnings like: warning: integer constant is too large for ‘long’ type Switch the L*_POISON definitions from too-large constants and casts to the proper constant types to fix this. Signed-off-by: Geert Uytterhoeven ge...@linux-m68k.org --- The values in drivers

[PATCH -next] staging: dgap: Add missing #include linux/slab.h

2013-08-29 Thread Geert Uytterhoeven
declaration of function ‘kmalloc’ drivers/staging/dgap/dgap_driver.c:940: warning: initialization makes pointer from integer without a cast Signed-off-by: Geert Uytterhoeven ge...@linux-m68k.org --- http://kisskb.ellerman.id.au/kisskb/buildresult/9422860/ http://kisskb.ellerman.id.au/kisskb/buildresult

[PATCH] staging: r8188eu: Fix uninitialized variable change_inx

2013-09-06 Thread Geert Uytterhoeven
drivers/staging/rtl8188eu/core/rtw_wlan_util.c: In function ‘WMMOnAssocRsp’: drivers/staging/rtl8188eu/core/rtw_wlan_util.c:634: warning: ‘change_inx’ may be used uninitialized in this function And the compiler is right: change_inx should be initialized to false. Signed-off-by: Geert

Re: [PATCH] staging: r8188eu: Fix uninitialized variable change_inx

2013-09-06 Thread Geert Uytterhoeven
On Fri, Sep 6, 2013 at 4:42 PM, Larry Finger larry.fin...@lwfinger.net wrote: On 09/06/2013 07:45 AM, Geert Uytterhoeven wrote: drivers/staging/rtl8188eu/core/rtw_wlan_util.c: In function ‘WMMOnAssocRsp’: drivers/staging/rtl8188eu/core/rtw_wlan_util.c:634: warning: ‘change_inx’ may be used

Re: [PATCH] staging: Disable lustre file system for MIPS, SH, and XTENSA

2013-09-10 Thread Geert Uytterhoeven
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say programmer or something like that. -- Linus Torvalds

Re: [PATCH] staging: Disable lustre file system for MIPS, SH, and XTENSA

2013-09-10 Thread Geert Uytterhoeven
flush_icache_user_range(), which is not exported. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say

Re: [PATCH 29/51] DMA-API: ata: pata_octeon_cf: convert to use dma_coerce_mask_and_coherent()

2013-10-30 Thread Geert Uytterhoeven
) + return ret; return rv; http://kisskb.ellerman.id.au/kisskb/buildresult/9959184/ Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself

Re: [PATCH 2/4] Staging: rtl8192u: r8192U_wx.c Removed all C99 comments

2014-06-03 Thread Geert Uytterhoeven
= ieee80211_wlan_frequencies[i] * 100 What do other people think? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I

Re: [PATCH 0/10] use safer test on the result of find_first_zero_bit

2014-06-04 Thread Geert Uytterhoeven
in find_first_zero_bit() instead? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say programmer

Re: [PATCH 0/10] use safer test on the result of find_first_zero_bit

2014-06-04 Thread Geert Uytterhoeven
larger than @size. | */ | extern unsigned long find_first_zero_bit(const unsigned long *addr, | unsigned long size); Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

Re: [PATCH 0/10] use safer test on the result of find_first_zero_bit

2014-06-04 Thread Geert Uytterhoeven
function entry and this line. So you have to store it in a temporary. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking

Re: [PATCH] staging: lustre: Use %ld to format long

2014-06-16 Thread Geert Uytterhoeven
Hi Greg, On Wed, Jun 11, 2014 at 7:00 PM, Geert Uytterhoeven ge...@linux-m68k.org wrote: drivers/staging/lustre/lustre/llite/rw26.c: In function ‘ll_direct_IO_26’: drivers/staging/lustre/lustre/llite/rw26.c:388: warning: format ‘%zd’ expects type ‘signed size_t’, but argument 6 has type ‘long

[-next] comedi I/O accessor name clashes

2014-06-20 Thread Geert Uytterhoeven
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say programmer or something like that. -- Linus Torvalds

Re: [-next] comedi I/O accessor name clashes

2014-06-20 Thread Geert Uytterhoeven
it's merry way to linux-next in the not-too-distant future. Thanks, good to hear that! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker

[PATCH] [media] staging/solo6x10: SOLO6X10 should select BITREVERSE

2014-07-06 Thread Geert Uytterhoeven
If CONFIG_SOLO6X10=y, but CONFIG_BITREVERSE=m: drivers/built-in.o: In function `solo_osd_print': (.text+0x1c7a1f): undefined reference to `byte_rev_table' make: *** [vmlinux] Error 1 Reported-by: kbuild test robot fengguang...@intel.com Signed-off-by: Geert Uytterhoeven ge...@linux

Re: [PATCH] [media] staging/solo6x10: SOLO6X10 should select BITREVERSE

2014-07-06 Thread Geert Uytterhoeven
CC kbuild test robot fengguang...@intel.com On Sun, Jul 6, 2014 at 10:58 AM, Geert Uytterhoeven ge...@linux-m68k.org wrote: If CONFIG_SOLO6X10=y, but CONFIG_BITREVERSE=m: drivers/built-in.o: In function `solo_osd_print': (.text+0x1c7a1f): undefined reference to `byte_rev_table

Re: [PATCH] [media] staging/solo6x10: SOLO6X10 should select BITREVERSE

2014-07-06 Thread Geert Uytterhoeven
On Sun, Jul 6, 2014 at 10:59 AM, Geert Uytterhoeven ge...@linux-m68k.org wrote: CC kbuild test robot fengguang...@intel.com Doh, this time for real... On Sun, Jul 6, 2014 at 10:58 AM, Geert Uytterhoeven ge...@linux-m68k.org wrote: If CONFIG_SOLO6X10=y, but CONFIG_BITREVERSE=m: drivers

[PATCH] staging: rts5139: Make variables inside #ifdef CONFIG_PM

2014-04-06 Thread Geert Uytterhoeven
at it. Signed-off-by: Geert Uytterhoeven ge...@linux-m68k.org --- drivers/staging/rts5139/rts51x_transport.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rts5139/rts51x_transport.c b/drivers/staging/rts5139/rts51x_transport.c index 74588d249b32

[PATCH] staging: r8723au: Add missing initialization of change_inx in sort algorithm

2014-04-10 Thread Geert Uytterhoeven
-off-by: Geert Uytterhoeven ge...@linux-m68k.org --- drivers/staging/rtl8723au/core/rtw_wlan_util.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723au/core/rtw_wlan_util.c b/drivers/staging/rtl8723au/core/rtw_wlan_util.c index 0dfcfbce3b52..a4361bb93865

Re: [PATCH] staging: r8723au: Add missing initialization of change_inx in sort algorithm

2014-04-10 Thread Geert Uytterhoeven
Hi Larry, On Thu, Apr 10, 2014 at 8:01 PM, Larry Finger larry.fin...@lwfinger.net wrote: On 04/10/2014 12:46 PM, Geert Uytterhoeven wrote: drivers/staging/rtl8723au/core/rtw_wlan_util.c: In function ‘WMMOnAssocRsp23a’: drivers/staging/rtl8723au/core/rtw_wlan_util.c:684: warning: ‘change_inx

[PATCH 2/3] staging: lustre: Use %zd to format ssize_t

2014-05-02 Thread Geert Uytterhoeven
: format '%lu' expects argument of type 'long unsigned int', but argument 10 has type 'ssize_t' [-Wformat] Join the quoted string split across lines to fix a checkpatch warning while we're at it. Signed-off-by: Geert Uytterhoeven ge...@linux-m68k.org --- drivers/staging/lustre/lustre/llite/rw26

[PATCH 3/3] staging/lustre/llite: Fix unused variable warning if !CONFIG_FS_POSIX_ACL

2014-05-02 Thread Geert Uytterhoeven
If CONFIG_FS_POSIX_ACL=n: drivers/staging/lustre/lustre/llite/xattr.c: In function 'll_setxattr_common': drivers/staging/lustre/lustre/llite/xattr.c:115:27: warning: unused variable 'rce' [-Wunused-variable] Signed-off-by: Geert Uytterhoeven ge...@linux-m68k.org --- drivers/staging/lustre

[PATCH 1/3] staging/lustre/libcfs: Fix build errors for !CONFIG_SMP

2014-05-02 Thread Geert Uytterhoeven
/libcfs_cpu.h:109:1: note: previous definition of 'cfs_cpt_table_print' was here Signed-off-by: Geert Uytterhoeven ge...@linux-m68k.org --- http://kisskb.ellerman.id.au/kisskb/buildresult/11054360/ --- .../lustre/include/linux/libcfs/linux/linux-mem.h |2 +- drivers/staging/lustre/lustre

Re: [PATCH 00/03] staging: Emma Mobile USB driver and KZM9D board code

2014-05-22 Thread Geert Uytterhoeven
defconfig nor Kconfig definitions for the KZM9D board (emev2-kzm9d.dts). Although there's no KZM9D-specific defconfig anymore, support for it is included in shmobile_defconfig, right? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge

[PATCH] staging: lustre: Move proc_*() functions inside #ifdef CONFIG_SYSCTL

2015-02-12 Thread Geert Uytterhoeven
CONFIG_SYSCTL cover all sysctl-related functions to fix this. Signed-off-by: Geert Uytterhoeven ge...@linux-m68k.org --- drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c

[PATCH] staging: fbtft: Do not use binary constants

2015-03-20 Thread Geert Uytterhoeven
use hexadecimal constants (0x*) instead. Signed-off-by: Geert Uytterhoeven ge...@linux-m68k.org --- Against next-20150320 drivers/staging/fbtft/fb_hx8340bn.c | 8 drivers/staging/fbtft/fb_hx8347d.c | 7 +++ drivers/staging/fbtft/fb_ili9320.c | 7 +++ drivers/staging

Re: [PATCH] staging: fbtft: Do not use binary constants

2015-03-20 Thread Geert Uytterhoeven
Hi Greg, On Fri, Mar 20, 2015 at 1:54 PM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Tue, Mar 10, 2015 at 10:34:43PM +0100, Geert Uytterhoeven wrote: Gcc 4.3 doesn't understand binary constants (0b*): drivers/staging/fbtft/fbtft-sysfs.c:156:19: error: invalid suffix b111

[PATCH] staging: fbtft: Do not use binary constants

2015-03-10 Thread Geert Uytterhoeven
use hexadecimal constants (0x*) instead. Signed-off-by: Geert Uytterhoeven ge...@linux-m68k.org --- This is against v4.0-rc3. In next-20150310 there are two whitespace differences. --- drivers/staging/fbtft/fb_hx8340bn.c | 8 drivers/staging/fbtft/fb_hx8347d.c | 7 +++ drivers

Re: [PATCH] staging: fbtft: Do not use binary constants

2015-03-10 Thread Geert Uytterhoeven
Hi Joe, On Tue, Mar 10, 2015 at 10:50 PM, Joe Perches j...@perches.com wrote: On Tue, 2015-03-10 at 22:34 +0100, Geert Uytterhoeven wrote: Gcc 4.3 doesn't understand binary constants (0b*): trivia: diff --git a/drivers/staging/fbtft/fb_hx8340bn.c b/drivers/staging/fbtft/fb_hx8340bn.c

[PATCH/RFC 3/6] staging: board: Add support for translating hwirq to virq numbers

2015-04-03 Thread Geert Uytterhoeven
with hardcoded IRQ numbers. Add a copyright header, including the original author. Signed-off-by: Geert Uytterhoeven geert+rene...@glider.be --- drivers/staging/board/board.c | 66 +++ drivers/staging/board/board.h | 5 2 files changed, 71 insertions(+) diff

[PATCH/RFC 6/6] staging: board: armadillo800eva: Board staging for sh_mobile_lcdc_fb

2015-04-03 Thread Geert Uytterhoeven
easily be removed. Until then we use platform devices to continuously improve the driver and integrate code. Added platform devices: - sh_mobile_lcdc_fb for the on-board LCD. Signed-off-by: Geert Uytterhoeven geert+rene...@glider.be --- What other devices do we want to add? --- drivers/staging

[PATCH/RFC 0/6] staging: board: armadillo800eva: Board staging for sh_mobile_lcdc_fb

2015-04-03 Thread Geert Uytterhoeven
(kzm9g, bockw, marzen)? This was tested on r8a7740/armadillo. This was not tested on emev2/kzm9d, due to lack of hardware. Thanks for your comments! Geert Uytterhoeven (6): Revert staging: board: disable as it breaks the build [RFC] staging: board: Initialize staging board code earlier

[PATCH/RFC 5/6] staging: board: Add support for devices with complex dependencies

2015-04-03 Thread Geert Uytterhoeven
Add support for easy registering of one ore more platform devices that may: - need clocks that are described in DT, - need pin control configuration, - rely on a configured GPIO, - be part of a PM Domain. All these dependencies are optional. Signed-off-by: Geert Uytterhoeven geert+rene

Re: [PATCH] staging: fbtft: Disable DMA support if DMA is not available

2015-04-23 Thread Geert Uytterhoeven
On Thu, Apr 23, 2015 at 8:27 PM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Thu, Apr 23, 2015 at 08:06:52PM +0200, Geert Uytterhoeven wrote: If NO_DMA=y: drivers/built-in.o: In function `fbtft_framebuffer_alloc': (.text+0xb53cae): undefined reference

[PATCH] staging: fbtft: Disable DMA support if DMA is not available

2015-04-23 Thread Geert Uytterhoeven
If NO_DMA=y: drivers/built-in.o: In function `fbtft_framebuffer_alloc': (.text+0xb53cae): undefined reference to `dmam_alloc_coherent' As DMA support is already optional, make it depend on HAS_DMA. Signed-off-by: Geert Uytterhoeven ge...@linux-m68k.org --- drivers/staging/fbtft/fbtft

[PATCH v2] staging: fbtft: Disable DMA support if DMA is not available

2015-04-23 Thread Geert Uytterhoeven
to dmam_alloc_coherent(). Signed-off-by: Geert Uytterhoeven ge...@linux-m68k.org --- v2: - Explain better how it works, - Keep the = false to avoid breakage (seen not only with gcc 4.1.2, but also with 4.6.3 and 4.9.0). --- drivers/staging/fbtft/fbtft-core.c | 5 + 1 file changed, 5

Re: [PATCH v2] staging: fbtft: Disable DMA support if DMA is not available

2015-04-24 Thread Geert Uytterhoeven
On Thu, Apr 23, 2015 at 9:17 PM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Thu, Apr 23, 2015 at 08:47:15PM +0200, Geert Uytterhoeven wrote: If NO_DMA=y: drivers/built-in.o: In function `fbtft_framebuffer_alloc': (.text+0xb53cae): undefined reference

[PATCH v3] staging: fbtft: Disable DMA support if DMA is not available

2015-04-24 Thread Geert Uytterhoeven
If NO_DMA=y: drivers/built-in.o: In function `fbtft_framebuffer_alloc': (.text+0xb53cae): undefined reference to `dmam_alloc_coherent' As DMA support is already optional, make it depend on HAS_DMA. Signed-off-by: Geert Uytterhoeven ge...@linux-m68k.org --- v3: - Use an #ifdef instead

[PATCH 19/27] staging: fbtft: Allow compile test of GPIO consumers if !GPIOLIB

2015-05-05 Thread Geert Uytterhoeven
. Signed-off-by: Geert Uytterhoeven ge...@linux-m68k.org Cc: Thomas Petazzoni thomas.petazz...@free-electrons.com Cc: Noralf Trønnes nor...@tronnes.org Cc: de...@driverdev.osuosl.org --- drivers/staging/fbtft/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging

[PATCH 18/27] staging: android: Allow compile test of GPIO consumers if !GPIOLIB

2015-05-05 Thread Geert Uytterhoeven
. Signed-off-by: Geert Uytterhoeven ge...@linux-m68k.org Cc: Greg Kroah-Hartman gre...@linuxfoundation.org Cc: de...@driverdev.osuosl.org --- drivers/staging/android/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/android/Kconfig b/drivers/staging/android

Re: [PATCH V4] Fix pointer cast for 32 bits arch

2015-04-16 Thread Geert Uytterhoeven
+ GOLDFISH_TTY_DATA_PTR_HIGH); writel(count, base + GOLDFISH_TTY_DATA_LEN); writel(GOLDFISH_TTY_CMD_READ_BUFFER, base + GOLDFISH_TTY_CMD); spin_unlock_irqrestore(qtty-lock, irq_flags); Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond

Re: [PATCH] Fix pointer cast for 32 bits arch

2015-04-13 Thread Geert Uytterhoeven
. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say programmer or something like

Re: [PATCH] Fix pointer cast for 32 bits arch

2015-04-12 Thread Geert Uytterhoeven
if CONFIG_X86_PAE=y, which makes resource_size_t u64? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say

Re: [PATCH] Fix pointer cast for 32 bits arch

2015-04-12 Thread Geert Uytterhoeven
On Sun, Apr 12, 2015 at 3:48 PM, Peter Senna Tschudin peter.se...@gmail.com wrote: On Sun, Apr 12, 2015 at 3:05 PM, Geert Uytterhoeven ge...@linux-m68k.org wrote: On Sun, Apr 12, 2015 at 11:26 AM, Peter Senna Tschudin peter.se...@gmail.com wrote: Sparse compalins about casting void * to u64

Re: [PATCH/RFC 0/6] staging: board: armadillo800eva: Board staging for sh_mobile_lcdc_fb

2015-04-03 Thread Geert Uytterhoeven
Hi Laurent, On Fri, Apr 3, 2015 at 6:24 PM, Laurent Pinchart laurent.pinch...@ideasonboard.com wrote: On Friday 03 April 2015 14:41:57 Geert Uytterhoeven wrote: This RFC patch series adds board staging support for r8a7740/armadillo. For now this supports only the frame buffer device

Re: [PATCH/RFC 5/6] staging: board: Add support for devices with complex dependencies

2015-04-05 Thread Geert Uytterhoeven
Hi Russell, On Fri, Apr 3, 2015 at 7:04 PM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Fri, Apr 03, 2015 at 03:57:27PM +0300, Dan Carpenter wrote: On Fri, Apr 03, 2015 at 02:42:02PM +0200, Geert Uytterhoeven wrote: +int __init board_staging_register_clock(const struct

Re: [PATCH/RFC 5/6] staging: board: Add support for devices with complex dependencies

2015-04-05 Thread Geert Uytterhoeven
configuration, as it affects multiple devices (the comment says DBGMD/LCDC0/FSIA MUX). I guess I could use a gpio-hog subnode in DT instead, but then we're already implementing the conversion to DT ;-) Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond

Re: [PATCH/RFC 5/6] staging: board: Add support for devices with complex dependencies

2015-04-03 Thread Geert Uytterhoeven
); + return 0; Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say programmer or something

Re: [PATCH v4 4/9] staging:lustre: merge socklnd_lib-linux.h into socklnd.h

2015-06-25 Thread Geert Uytterhoeven
(at least) three more includes. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say programmer

Re: [PATCH] staging:lustre: remove irq.h from socklnd.h

2015-06-26 Thread Geert Uytterhoeven
-by: James Simmons jsimm...@infradead.org Thanks, works fine on next-20150625! Tested-by: by: Geert Uytterhoeven ge...@linux-m68k.org Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations

Re: [PATCH v4 4/9] staging:lustre: merge socklnd_lib-linux.h into socklnd.h

2015-06-24 Thread Geert Uytterhoeven
'atomic_t' http://kisskb.ellerman.id.au/kisskb/buildresult/12448922/ Fixing it inside arch/m68k/include/asm/irq.h might cause Include Hell, so perhaps you can just move the asm/* include below all linux/* includes? Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven

Re: [PATCH] staging/lustre/lnet: Move asm/irq.h include after linux includes

2015-06-24 Thread Geert Uytterhoeven
. Thanks to Geert Uytterhoeven for getting to the root of it. Signed-off-by: Oleg Drokin gr...@linuxhacker.ru Compile-Tested-by: Geert Uytterhoeven ge...@linux-m68k.org --- Geert, it would be great if you can make sure it actually builds with this too. Thanks! Thanks, builds fine! Gr{oetje

Re: [PATCH] staging: board: Add dependency on CLKDEV_LOOKUP

2015-06-27 Thread Geert Uytterhoeven
`.board_staging_register_clock': (.init.text+0x1d8e0): undefined reference to `.clk_add_alias' Fixes: 225d68d852f1 (staging: board: Add support for devices with complex dependencies) Cc: Geert Uytterhoeven geert+rene...@glider.be Signed-off-by: Guenter Roeck li...@roeck-us.net See also [PATCH v2

[PATCH v2 4/7] staging: board: kzm9d: Translate hwirq numbers to virq numbers

2015-06-17 Thread Geert Uytterhoeven
As of commit 9a1091ef0017c40a (irqchip: gic: Support hierarchy irq domain.), GIC IRQ numbers are virtual, breaking hardcoded hardware IRQ numbers in platform device resources. Translate the hardware IRQ numbers to virtual IRQ numbers to fix this. Signed-off-by: Geert Uytterhoeven geert+rene

[PATCH v2 1/7] Revert staging: board: disable as it breaks the build

2015-06-17 Thread Geert Uytterhoeven
This reverts commit d13778d537a0ed6115d2a79a942af999cfb8eec6. Commit 13c11072536f2613 (staging:board: remove unnecessary function) fixed the build of drivers/staging/board/board.c. Signed-off-by: Geert Uytterhoeven geert+rene...@glider.be Reviewed-by: Simon Horman horms+rene...@verge.net.au

[PATCH v2 6/7] staging: board: armadillo800eva: Board staging for sh_mobile_lcdc_fb

2015-06-17 Thread Geert Uytterhoeven
easily be removed. Until then we use platform devices to continuously improve the driver and integrate code. Added platform devices: - sh_mobile_lcdc_fb for the on-board LCD. Signed-off-by: Geert Uytterhoeven geert+rene...@glider.be --- v2: - Drop pinctrl and configured GPIOs, these are now

[PATCH v2 0/7] staging: board: armadillo800eva: Board staging for sh_mobile_lcdc_fb

2015-06-17 Thread Geert Uytterhoeven
. This was tested on r8a7740/armadillo. This was not tested on emev2/kzm9d, due to lack of hardware. Thanks for applying! Geert Uytterhoeven (7): Revert staging: board: disable as it breaks the build staging: board: Initialize staging board code earlier staging: board: Add support for translating

[PATCH v2 3/7] staging: board: Add support for translating hwirq to virq numbers

2015-06-17 Thread Geert Uytterhoeven
with hardcoded IRQ numbers. Add a copyright header, including the original author. Signed-off-by: Geert Uytterhoeven geert+rene...@glider.be --- v2: - Change the function names to include gic, as the 3-parameter interrupt specifiers are GIC-specific, - Warn if board_staging_gic_setup_xlate

[PATCH v2 2/7] staging: board: Initialize staging board code earlier

2015-06-17 Thread Geert Uytterhoeven
-off-by: Geert Uytterhoeven geert+rene...@glider.be --- v2: - Drop RFC status. --- drivers/staging/board/board.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/board/board.h b/drivers/staging/board/board.h index 2390ed6c31a42f2f..e9c914985d4acb36 100644

[PATCH v2 7/7] ARM: shmobile: armadillo800eva dts: Add pinctrl and gpio-hog for lcdc0

2015-06-17 Thread Geert Uytterhoeven
Configure pinctrl and a GPIO-controller board mux for LCD use. This allows the armadillo800eva board staging code to enable lcdc0. Signed-off-by: Geert Uytterhoeven geert+rene...@glider.be --- v2: - New. --- arch/arm/boot/dts/r8a7740-armadillo800eva.dts | 13 + 1 file changed, 13

[PATCH v2 5/7] staging: board: Add support for devices with complex dependencies

2015-06-17 Thread Geert Uytterhoeven
Add support for easy registering of one ore more platform devices that may: - need clocks that are described in DT, - be part of a PM Domain. All these dependencies are optional. Signed-off-by: Geert Uytterhoeven geert+rene...@glider.be --- v2: - Drop support for pinctrl, use standard

Re: [PATCH] staging: board: Kconfig: Let STAGING_BOARD depend on CLKDEV_LOOKUP

2015-07-05 Thread Geert Uytterhoeven
...@gmail.com Fix available for the last 15 days: https://lkml.org/lkml/2015/6/20/215 Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when

[PATCH trivial] staging: comedi: Grammar s/Enable support a/Enable support for a/

2015-07-06 Thread Geert Uytterhoeven
Signed-off-by: Geert Uytterhoeven ge...@linux-m68k.org --- drivers/staging/comedi/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/comedi/Kconfig b/drivers/staging/comedi/Kconfig index 7dee73dfbf88ff09..57e71f9f14a2385b 100644 --- a/drivers/staging

Re: [PATCH] staging: board: Kconfig: Let STAGING_BOARD depend on CLKDEV_LOOKUP

2015-07-06 Thread Geert Uytterhoeven
for. Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say programmer or something like

[PATCH v2 07/11] staging: fbtft: Allow compile test of GPIO consumers if !GPIOLIB

2015-08-02 Thread Geert Uytterhoeven
. Signed-off-by: Geert Uytterhoeven ge...@linux-m68k.org Acked-by: Linus Walleij linus.wall...@linaro.org --- v2: - Add Acked-by. --- drivers/staging/fbtft/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/fbtft/Kconfig b/drivers/staging/fbtft/Kconfig index

[PATCH v2 06/11] staging: android: Allow compile test of GPIO consumers if !GPIOLIB

2015-08-02 Thread Geert Uytterhoeven
. Signed-off-by: Geert Uytterhoeven ge...@linux-m68k.org Acked-by: Linus Walleij linus.wall...@linaro.org --- v2: - Add Acked-by. --- drivers/staging/android/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/android/Kconfig b/drivers/staging/android/Kconfig

Re: [PATCH] staging: board: Set PM domain before probe

2015-10-27 Thread Geert Uytterhoeven
r that > will WARN if the device has been probed already. > > Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> > Cc: Geert Uytterhoeven <geert+rene...@glider.be> Tested-by: Geert Uytterhoeven <geert+rene...@glider.be> Gr{oetje,eeting}s, Geert

Re: [PATCH] staging: board: Set PM domain before probe

2015-11-10 Thread Geert Uytterhoeven
Hi Tomeu, On Tue, Oct 27, 2015 at 3:55 PM, Geert Uytterhoeven <ge...@linux-m68k.org> wrote: > On Tue, Oct 27, 2015 at 3:27 PM, Tomeu Vizoso > <tomeu.viz...@collabora.com> wrote: >> PM domains shouldn't be modified after a device is probed, so set it >> before

[PATCH] Staging: most: MOST and MOSTCORE should depend on HAS_DMA

2015-09-01 Thread Geert Uytterhoeven
, and to MOST, which selects MOSTCORE. Signed-off-by: Geert Uytterhoeven <ge...@linux-m68k.org> --- drivers/staging/most/Kconfig | 1 + drivers/staging/most/mostcore/Kconfig | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/staging/most/Kconfig b/drivers/staging/most/Kcon

Re: [PATCH v2 5/7] staging: board: Add support for devices with complex dependencies

2015-09-04 Thread Geert Uytterhoeven
Hi Ulf, On Fri, 4 Sep 2015, Ulf Hansson wrote: > On 3 September 2015 at 15:35, Geert Uytterhoeven <ge...@linux-m68k.org> wrote: > > On Thu, Sep 3, 2015 at 2:53 PM, Ulf Hansson <ulf.hans...@linaro.org> wrote: > >> On 17 June 2015 at 10:38, Geert Uytterh

Re: [PATCH v2 5/7] staging: board: Add support for devices with complex dependencies

2015-09-07 Thread Geert Uytterhoeven
Hi Ulf, On Mon, Sep 7, 2015 at 1:45 PM, Ulf Hansson <ulf.hans...@linaro.org> wrote: > On 4 September 2015 at 17:03, Geert Uytterhoeven <ge...@linux-m68k.org> wrote: >> On Fri, 4 Sep 2015, Ulf Hansson wrote: >>> On 3 September 2015 at 15:35, Geert Uytterhoeven <

Re: [PATCH v2 5/7] staging: board: Add support for devices with complex dependencies

2015-09-03 Thread Geert Uytterhoeven
Hi Ulf, On Thu, Sep 3, 2015 at 2:53 PM, Ulf Hansson <ulf.hans...@linaro.org> wrote: > On 17 June 2015 at 10:38, Geert Uytterhoeven <geert+rene...@glider.be> wrote: >> Add support for easy registering of one ore more platform devices that >> may: >> - nee

[PATCH v2] staging: board: Migrate away from __pm_genpd_name_add_device()

2015-09-08 Thread Geert Uytterhoeven
The named genpd APIs are deprecated. Hence convert the board staging code from using genpd names to DT node paths. For now this supports PM domains with "#power-domain-cells = <0>" only. Signed-off-by: Geert Uytterhoeven <geert+rene...@glider.be> Reviewed-by: Ulf Hansson &

Re: [PATCH] staging: iio: fix ad7606_spi regression

2016-05-30 Thread Geert Uytterhoeven
On Mon, May 30, 2016 at 3:50 PM, Arnd Bergmann <a...@arndb.de> wrote: > As pointed out by Geert Uytterhoeven, the patch was incorrect > and breaks the driver, which was fortunately pointed out by > this gcc warning: > > drivers/staging/iio/adc/ad7606_spi.c: In function ‘

Re: [PATCH] Staging: speakup: Fix allyesconfig build on mn10300

2016-02-07 Thread Geert Uytterhoeven
nfig > @@ -1,7 +1,7 @@ > menu "Speakup console speech" > > config SPEAKUP > - depends on VT > + depends on VT && !MN10300 > tristate "Speakup core" > ---help--- > This is the Speakup screen reader. Think

Re: [PATCH 04/22] staging: iio: Fix dependencies for !HAS_IOMEM archs

2016-01-26 Thread Geert Uytterhoeven
On Mon, Jan 25, 2016 at 11:24 PM, Richard Weinberger <rich...@nod.at> wrote: > Not every arch has io memory. > So, unbreak the build by fixing the dependencies. > > Signed-off-by: Richard Weinberger <rich...@nod.at> Acked-by: Geert Uytterhoeven <ge...@linux-m

staging: most: warning: ‘mbo’ may be used uninitialized in this function

2016-03-19 Thread Geert Uytterhoeven
the kfifo? Other callers initialize the pointer to NULL, and check the returned length. > mutex_unlock(>io_mutex); > if (filp->f_flags & O_NONBLOCK) > return -EAGAIN; Gr{oetje,eeting}s, Geert --

Re: [RFC 08/15] rtc: at91sam9: Add missing MFD_SYSCON dependency on HAS_IOMEM

2016-03-03 Thread Geert Uytterhoeven
did, all other RTC drivers would also fail. So UML has no RTC. Should/can it use RTC_DRV_GENERIC? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with te

Re: [RFC 09/15] media: platform: Add missing MFD_SYSCON dependency on HAS_IOMEM

2016-03-03 Thread Geert Uytterhoeven
es HAS_IOMEM afaik. No systems around with HV-based DMA? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. B

Re: [PATCH] Staging: iio: Fix sparse endian warning

2016-05-22 Thread Geert Uytterhoeven
version of sparse didn't complain about the original, neither does the one I've just cloned from the master repository (v0.5.0-44-g40791b94c56b1a6d)? Hence I have no idea if fixing this by keeping the assignment of buf to data is warned about Gr{oetje,eeting}s, Geert -

[PATCH 01/54] MAINTAINERS: Add file patterns for ion device tree bindings

2016-05-22 Thread Geert Uytterhoeven
Submitters of device tree binding documentation may forget to CC the subsystem maintainer if this is missing. Signed-off-by: Geert Uytterhoeven <ge...@linux-m68k.org> Cc: Laura Abbott <labb...@redhat.com> Cc: Sumit Semwal <sumit.sem...@linaro.org> Cc: de...@driverdev.osuosl.or

Re: [PATCH] staging: fwserial: replace 'a' with '(a)' to avoid precedence issues

2017-02-15 Thread Geert Uytterhoeven
a->b) >> +#define to_device((a), b)(a->b) > > Really? Actually compiling files should be a requirement for submitting patches, cfr. the response from kbuild test report. The parentheses should be added to the second "a" instead ;-) > Why do we eve

Re: [PATCH 00/26] constify local structures

2016-09-12 Thread Geert Uytterhoeven
build-testing is really all you need. Any > problems caused by adding 'const' to a definition will be seen by build > errors or warnings. Unfortunately in this particular case they could lead to failures that can only be detected at runtime, when failing o write to a read-only piece of m

Re: [PATCH] Staging:board:board: fix implicit declaration of function

2016-10-24 Thread Geert Uytterhoeven
ead. drivers/staging/board/board.c already includes , which provides the prototype, but only if CONFIG_OF=y. However, STAGING_BOARD depends on OF_ADDRESS and OF_IRQ, which both depend on OF. So how can this happen?? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There'

[PATCH] [media] s5p_cec: Mark runtime suspend/resume as __maybe_unused

2016-10-13 Thread Geert Uytterhoeven
introducing an #ifdef. Fixes: 57b978ada073106d ("[media] s5p-cec: fix system and runtime PM integration") Signed-off-by: Geert Uytterhoeven <ge...@linux-m68k.org> --- The above commit didn't take into account Arnd's previous fix... drivers/staging/media/s5p-cec/s5p_cec.c | 4 ++-- 1

  1   2   3   >