Re: [RESEND] staging: rtlwifi: convert to DEFINE_SHOW_ATTRIBUTE

2018-12-17 Thread Greg KH
On Sat, Dec 15, 2018 at 03:56:35AM -0500, Yangtao Li wrote: > Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. > > Signed-off-by: Yangtao Li > --- > drivers/staging/rtlwifi/debug.c | 23 ++- > 1 file changed, 6 insertions(+), 17 deletions(-) Always test build your patch

Re: [PATCH] staging: rtlwifi: Fix one line with over 80 chars.

2018-12-18 Thread Greg KH
On Tue, Dec 18, 2018 at 10:30:05AM -0500, Lei Zhou wrote: > Add local temporary variable used as buffer to pass caller pointer into > function ieee80211_connection_loss() to avoid over 80 characters on one > line. > > Signed-off-by: Lei Zhou > --- > drivers/staging/rtlwifi/base.c | 4 +++- > 1 f

Re: [PATCH v2 14/17] staging: rtl8188eu: simplify null array initializations

2018-12-18 Thread Greg KH
On Tue, Dec 18, 2018 at 07:34:48PM +0100, Michael Straube wrote: > Simplfy initialization of null arrays to improve readability > and save some lines. > > Signed-off-by: Michael Straube > --- > drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 4 ++-- > drivers/staging/rtl8188eu/core/rtw_xmit.c

Re: [PATCH v3] binder: implement binderfs

2018-12-19 Thread Greg KH
On Fri, Dec 14, 2018 at 01:11:14PM +0100, Christian Brauner wrote: > As discussed at Linux Plumbers Conference 2018 in Vancouver [1] this is the > implementation of binderfs. Looks good to me, thanks so much for doing this, now queued up! greg k-h ___

Re: [PATCH] mt7621-mmc/sd.c: Fix some coding style issues

2018-12-19 Thread Greg KH
On Thu, Dec 13, 2018 at 03:54:07PM +0100, Jona Crasselt wrote: > Fix some "bigger" issues reported by checkpatch.pl: > - Block comments use * on subsequent lines > - Blank lines aren't necessary before a close brace > - Block comments use a trailing */ on a separate line > - Alignment should match

Re: [PATCH v2 6/7] mt7621-mmc: printk() should include KERN_ facility level

2018-12-20 Thread Greg KH
On Wed, Dec 19, 2018 at 05:07:06PM +0100, Jona Crasselt wrote: > Issue reported by checkpatch.pl. > Replace printk() with pr_debug() to include facility level. > > Signed-off-by: Jona Crasselt > Signed-off-by: Felix Windsheimer > --- > drivers/staging/mt7621-mmc/sd.c | 8 > 1 file chan

Re: [PATCH v2 7/7] mt7621-mmc: Correct spelling mistakes in comments

2018-12-20 Thread Greg KH
On Wed, Dec 19, 2018 at 05:07:07PM +0100, Jona Crasselt wrote: > Signed-off-by: Jona Crasselt > Signed-off-by: Felix Windsheimer > --- > drivers/staging/mt7621-mmc/sd.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) I can't take patches without any changelog comments at all :(

Re: [PATCH v2 1/7] mt7621-mmc: Fix some coding style issues

2018-12-20 Thread Greg KH
On Wed, Dec 19, 2018 at 05:07:01PM +0100, Jona Crasselt wrote: > Fix some comment-related issues reported by checkpatch.pl: > - Block comments use * on subsequent lines > - Block comments use a trailing */ on a separate line > > Signed-off-by: Jona Crasselt > Signed-off-by: Felix Windsheimer > -

Re: [PATCH v3] staging: mt7621-mmc: Correct spelling mistakes in comments

2018-12-20 Thread Greg KH
On Thu, Dec 20, 2018 at 05:57:37PM +0100, Jona Crasselt wrote: > Changed "avaiable" to "available" and "interupt" to "interrupt". > > Signed-off-by: Jona Crasselt > Signed-off-by: Felix Windsheimer > --- > drivers/staging/mt7621-mmc/sd.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(

Re: [PATCH] binderfs: implement sysctls

2018-12-21 Thread Greg KH
On Fri, Dec 21, 2018 at 02:39:09PM +0100, Christian Brauner wrote: > This implements three sysctls that have very specific goals: Ick, why? What are these going to be used for? Who will "control" them? As you are putting them in the "global" namespace, that feels like something that binderfs wa

Re: [PATCH] binderfs: implement sysctls

2018-12-21 Thread Greg KH
On Fri, Dec 21, 2018 at 03:12:42PM +0100, Christian Brauner wrote: > On Fri, Dec 21, 2018 at 02:55:09PM +0100, Greg KH wrote: > > On Fri, Dec 21, 2018 at 02:39:09PM +0100, Christian Brauner wrote: > > > This implements three sysctls that have very specific goals: > > >

Re: [PATCH] binderfs: implement sysctls

2018-12-21 Thread Greg KH
On Fri, Dec 21, 2018 at 04:59:19PM +0100, Christian Brauner wrote: > On Fri, Dec 21, 2018 at 04:37:58PM +0100, Greg KH wrote: > > On Fri, Dec 21, 2018 at 03:12:42PM +0100, Christian Brauner wrote: > > > On Fri, Dec 21, 2018 at 02:55:09PM +0100, Greg KH wrote: > > > >

Re: [PATCH] binderfs: implement "max" mount option

2018-12-23 Thread Greg KH
On Sat, Dec 22, 2018 at 10:18:06PM +0100, Christian Brauner wrote: > Since binderfs can be mounted by userns root in non-initial user namespaces > some precautions are in order. First, a way to set a maximum on the number > of binder devices that can be allocated per binderfs instance and second, a

Re: [PATCH v1 1/2] binderfs: implement "max" mount option

2018-12-24 Thread Greg KH
On Mon, Dec 24, 2018 at 12:09:37PM +0100, Christian Brauner wrote: > On Sun, Dec 23, 2018 at 03:35:49PM +0100, Christian Brauner wrote: > > Since binderfs can be mounted by userns root in non-initial user namespaces > > some precautions are in order. First, a way to set a maximum on the number > >

[GIT PULL] Staging/IIO driver patches for 4.21-rc1

2018-12-28 Thread Greg KH
The following changes since commit 40e020c129cfc991e8ab4736d2665351ffd1468d: Linux 4.20-rc6 (2018-12-09 15:31:00 -0800) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git tags/staging-4.21-rc1 for you to fetch changes up to 215852f4b8bb

Re: [GIT PULL] Staging/IIO driver patches for 4.21-rc1

2018-12-28 Thread Greg KH
On Fri, Dec 28, 2018 at 04:35:31PM +0100, Greg KH wrote: > The following changes since commit 40e020c129cfc991e8ab4736d2665351ffd1468d: > > Linux 4.20-rc6 (2018-12-09 15:31:00 -0800) > > are available in the Git repository at: > > git://git.kernel.org/pub/scm/li

Re: [PATCH 0/2] staging: mt7621-pinctrl: use pinconf-generic in some driver ops

2019-01-04 Thread Greg KH
On Thu, Jan 03, 2019 at 09:23:57AM +0100, Sergio Paracuellos wrote: > On Thu, Jan 3, 2019 at 3:02 AM NeilBrown wrote: > > > > On Mon, Dec 31 2018, Sergio Paracuellos wrote: > > > > > dt_node_to_map and dt_free_map operations can use pinconf-generic API's > > > instead of redefine operations in the

Re: [PATCH] staging: wilc1000: define wilc_get_stats_async as static

2019-01-04 Thread Greg KH
On Thu, Jan 03, 2019 at 05:18:05PM +0100, Juan Manuel Torres Palma wrote: > Declare wilc_get_stats_async as static since it's only > used within the definition file scope. > > Signed-off-by: Juan Manuel Torres Palma > --- > drivers/staging/wilc1000/host_interface.c | 2 +- > 1 file changed, 1 in

Re: [PATCH] staging: mt29f_spinand: add SPDX identifiers

2019-01-04 Thread Greg KH
On Sun, Dec 23, 2018 at 10:57:02AM +0100, Michael Straube wrote: > This satisfies a checkpatch warning and is the preferred > method for notating the license. > > The SPDX identifier is a legally binding shorthand, which > can be used instead of the full boiler plate text. > > Signed-off-by: Mich

Re: [PATCH 0/2] staging: mt7621-pinctrl: use pinconf-generic in some driver ops

2019-01-04 Thread Greg KH
On Fri, Jan 04, 2019 at 09:55:02AM +0100, Sergio Paracuellos wrote: > Hi Greg, > > On Fri, Jan 4, 2019 at 9:32 AM Greg KH wrote: > > > > On Thu, Jan 03, 2019 at 09:23:57AM +0100, Sergio Paracuellos wrote: > > > On Thu, Jan 3, 2019 at 3:02 AM NeilBrown wrote: >

Re: [PATCH] staging: wilc1000: fix cast to restricted __le32

2019-01-05 Thread Greg KH
On Sat, Jan 05, 2019 at 09:32:56AM +0100, Július Milan wrote: > sorry, bad mail, see the next one please Properly version your patches so I know what "next one" really means. I've dropped all of these patches from my queue now, please resend with a v2 added to the patch as the documentation says

Re: [PATCH v2] staging: wilc1000: fix cast to restricted __le32

2019-01-05 Thread Greg KH
On Sat, Jan 05, 2019 at 10:10:25AM +0100, Július Milan wrote: > Fixes the following sparse warnings: > > drivers/staging/wilc1000/host_interface.c:2360:30: warning: > incorrect type in assignment (different base types) > expected restricted __le32 [addressable] [assigned] [usertype] frame_typ

Re: rtl8192e: need help with variable naming convention

2019-01-07 Thread Greg KH
On Mon, Jan 07, 2019 at 04:04:46PM +0530, Himadri Pandya wrote: > Hello, > > I'm getting started with device drivers. And as a starter, I'm working on > some clean-up patches. I'm particularly targeting to rename a structure > array "ChannelPlan"(in file dot11d.c) to fix a checkpatch.pl warning "

Re: [PATCH] hv_balloon: avoid touching uninitialized struct page during tail onlining

2019-01-07 Thread Greg KH
On Mon, Jan 07, 2019 at 07:38:20PM +0100, Vitaly Kuznetsov wrote: > (I remember Greg disliked when people were tagging patches for stable@ > themselves, he prefered maintainers deciding if the particular commit > deserves stable@ or not - but as you have a tree now we may as well have > different r

Re: general protection fault in spk_ttyio_ldisc_close

2019-01-08 Thread Greg KH
On Tue, Jan 08, 2019 at 08:37:37AM -0500, Kyungtae Kim wrote: > We report a bug in linux-4.20: "general protection fault in > spk_ttyio_ldisc_close" > > kernel config: https://kt0755.github.io/etc/config_v4.20_stable > repro: https://kt0755.github.io/etc/repro.a670e.c > > This occurs when the fun

Re: general protection fault in spk_ttyio_ldisc_close

2019-01-08 Thread Greg KH
On Tue, Jan 08, 2019 at 09:15:02AM -0500, Kyungtae Kim wrote: > On Tue, Jan 8, 2019 at 8:50 AM Greg KH wrote: > > > > On Tue, Jan 08, 2019 at 08:37:37AM -0500, Kyungtae Kim wrote: > > > We report a bug in linux-4.20: "general protection fault in > > > spk

Re: [PATCH] staging: rtl8723bs: Mark ACPI table declaration as used

2019-01-09 Thread Greg KH
On Wed, Jan 09, 2019 at 04:19:30PM -0800, Nick Desaulniers wrote: > Digging up an old thread to point out I was wrong: > > On Thu, Sep 27, 2018 at 1:08 PM Nick Desaulniers > wrote: > > > This is not a million-little-commits problem; more like 2 drivers in > > > the whole tree have this problem. >

Re: [PATCH] Mediatek staging: Use individual config flags in Makefile

2019-01-09 Thread Greg KH
On Thu, Jan 10, 2019 at 12:26:28AM -0700, thirtythreefo...@gmail.com wrote: > From: George Hilliard > > These drivers are useful on other MT76xx SoCs, which have compatible > peripherals. The drivers are selectable in Kconfig, but they were > quietly excluded from the build because the SOC_MT762

Re: [PATCH] binder: create node flag to request sender's security context

2019-01-11 Thread Greg KH
On Thu, Jan 10, 2019 at 10:21:00AM -0800, Todd Kjos wrote: > To allow servers to verify client identity, allow a node > flag to be set that causes the sender's security context > to be delivered with the transaction. The BR_TRANSACTION > command is extended in BR_TRANSACTION_SEC_CTX to > contain a

Re: [PATCH v2 2/2] binderfs: reserve devices for initial mount

2019-01-11 Thread Greg KH
On Wed, Jan 02, 2019 at 12:32:19PM +0100, Christian Brauner wrote: > The binderfs instance in the initial ipc namespace will always have a > reserve of 4 binder devices unless explicitly capped by specifying a lower > value via the "max" mount option. > This ensures when binder devices are removed

Re: [RESEND PATCH] binderfs: reserve devices for initial mount

2019-01-11 Thread Greg KH
On Fri, Jan 11, 2019 at 11:20:56AM +0100, Christian Brauner wrote: > On Fri, Jan 11, 2019 at 11:19:40AM +0100, Christian Brauner wrote: > > The binderfs instance in the initial ipc namespace will always have a > > reserve of 4 binder devices unless explicitly capped by specifying a lower > > value

[GIT PULL] Staging driver fixes for 5.0-rc2

2019-01-13 Thread Greg KH
The following changes since commit bfeffd155283772bbe78c6a05dec7c0128ee500c: Linux 5.0-rc1 (2019-01-06 17:08:20 -0800) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git tags/staging-5.0-rc2 for you to fetch changes up to 06382deac2b8a4

Re: [PATCH] staging/android/vsoc: Remove duplicate header

2019-01-15 Thread Greg KH
On Wed, Jan 09, 2019 at 08:55:59PM +0530, Brajeswar Ghosh wrote: > Remove linux/mutex.h.h which is included more than once I think you have one too many ".h" in that line :) I'll go fix it up... ___ devel mailing list de...@linuxdriverproject.org http:

Re: [PATCH] staging/android/vsoc: Remove duplicate header

2019-01-15 Thread Greg KH
On Wed, Jan 09, 2019 at 08:55:59PM +0530, Brajeswar Ghosh wrote: > Remove linux/mutex.h which is included more than once > > Signed-off-by: Brajeswar Ghosh > Acked-by: Souptick Joarder > --- > drivers/staging/android/vsoc.c | 1 - > 1 file changed, 1 deletion(-) This does not apply as it is al

Re: [PATCH] staging/android/vsoc: Remove duplicate header

2019-01-15 Thread Greg KH
On Tue, Jan 15, 2019 at 03:59:42PM +0100, Greg KH wrote: > On Wed, Jan 09, 2019 at 08:55:59PM +0530, Brajeswar Ghosh wrote: > > Remove linux/mutex.h which is included more than once > > > > Signed-off-by: Brajeswar Ghosh > > Acked-by: Souptick Joarder > > --- &g

Re: [PATCH] staging: comedi: Removed not necessary braces for single block

2019-01-15 Thread Greg KH
On Tue, Jan 15, 2019 at 08:21:08PM +0530, root wrote: > This patch is used to remove not necessary braces for single if block. > > Signed-off-by: Jitendra Kumar Khasdev > --- > drivers/staging/comedi/comedi_fops.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) "interesting" email nam

Re: [PATCH 2/3] staging: rtl8188eu: cleanup declarations in os_intfs.c

2019-01-15 Thread Greg KH
On Tue, Jan 15, 2019 at 09:24:01AM +0100, Michael Straube wrote: > Replace tabs with spaces and/or remove extra spaces in declarations. > --- > drivers/staging/rtl8188eu/os_dep/os_intfs.c | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) No signed off by :(

Re: [PATCH 3/3] staging: rtl8188eu: add spaces around operators in os_intfs.c

2019-01-15 Thread Greg KH
On Tue, Jan 15, 2019 at 09:24:02AM +0100, Michael Straube wrote: > Add spaces around '+', '<<' and '*' to follow kernel coding style. > Reported by checkpatch. > --- > drivers/staging/rtl8188eu/os_dep/os_intfs.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) No signed-off-by :( ___

Re: [PATCH -next] binderfs: fix error return code in binderfs_fill_super()

2019-01-15 Thread Greg KH
On Wed, Jan 16, 2019 at 07:28:26AM +0100, Christian Brauner wrote: > On Wed, Jan 16, 2019 at 07:25:46AM +0100, Christian Brauner wrote: > > On Wed, Jan 16, 2019 at 03:01:04AM +, Wei Yongjun wrote: > > > Fix to return a negative error code -ENOMEM from the new_inode() and > > > d_make_root() err

Re: [PATCH] selftests: add binderfs selftests

2019-01-16 Thread Greg KH
On Wed, Jan 16, 2019 at 02:19:03PM +0100, Christian Brauner wrote: > This adds the promised selftest for binderfs. It will verify the following > things: > - binderfs mounting works > - binder device allocation works > - performing a binder ioctl() request through a binderfs device works > - binder

Re: [PATCH] selftests: add binderfs selftests

2019-01-16 Thread Greg KH
On Wed, Jan 16, 2019 at 06:21:12PM +0200, Christian Brauner wrote: > On January 16, 2019 5:54:50 PM GMT+02:00, Greg KH > wrote: > >On Wed, Jan 16, 2019 at 02:19:03PM +0100, Christian Brauner wrote: > >> This adds the promised selftest for binderfs. It will verify the >

Re: [PATCH v1] selftests: add binderfs selftests

2019-01-16 Thread Greg KH
On Wed, Jan 16, 2019 at 11:27:45PM +0100, Christian Brauner wrote: > This adds the promised selftest for binderfs. It will verify the following > things: > - binderfs mounting works > - binder device allocation works > - performing a binder ioctl() request through a binderfs device works > - binder

Re: [PATCH v2] selftests: add binderfs selftests

2019-01-17 Thread Greg KH
On Thu, Jan 17, 2019 at 11:28:21AM +0100, Christian Brauner wrote: > This adds the promised selftest for binderfs. It will verify the following > things: > - binderfs mounting works > - binder device allocation works > - performing a binder ioctl() request through a binderfs device works > - binder

Re: [PATCH 0/3] PCI: hv: Use vPCI protocol version 1.2 for v4.9

2019-01-17 Thread Greg KH
On Fri, Jan 18, 2019 at 02:17:15AM +0530, Ajay Kaher wrote: > For now, please consider these patches for review and suggest if these can be > merged to mainline kernel v4.9. > > These patches add support for vPCI protocol version 1.2, by baqkpotring from > v4.14 to v4.9. Individual patches are s

Re: [PATCH 00/13] staging: wilc1000: address few mainline review

2019-01-18 Thread Greg KH
On Thu, Jan 17, 2019 at 01:21:06PM +, ajay.kat...@microchip.com wrote: > From: Ajay Singh > > This series contains changes to address few of the review comments[1]. > It mainly has the modification to remove the use of scan shadow > buffer, make use of kernel provided API, avoid typedef's and

Re: [PATCH] staging: netlogic: replace ---help--- with help in Kconfig

2019-01-22 Thread Greg KH
On Sun, Jan 20, 2019 at 09:40:39PM +0530, Bharath Vedartham wrote: > This patch fixes the checkpatch.pl warning: > > WARNING: prefer 'help' over '---help---' for new help texts > > Signed-off-by: Bharath Vedartham > --- > drivers/staging/netlogic/Kconfig | 2 +- > 1 file changed, 1 insertion(+)

Re: [PATCH v3] selftests: add binderfs selftests

2019-01-23 Thread Greg KH
On Wed, Jan 23, 2019 at 11:54:58AM +0100, Christian Brauner wrote: > On Thu, Jan 17, 2019 at 12:48:54PM +0100, Christian Brauner wrote: > > This adds the promised selftest for binderfs. It will verify the following > > things: > > - binderfs mounting works > > - binder device allocation works > > -

Re: [PATCH] Revert "media: cedrus: Allow using the current dst buffer as reference"

2019-01-24 Thread Greg KH
On Thu, Jan 24, 2019 at 10:55:42AM +0100, Paul Kocialkowski wrote: > This reverts commit cf20ae1535eb690a87c29b9cc7af51881384e967. > > The vb2_find_timestamp helper was modified to allow finding buffers > regardless of their current state in the queue. This means that we > no longer have to take p

[GIT PULL] Staging driver fixes for 5.0-rc4

2019-01-25 Thread Greg KH
The following changes since commit 1c7fc5cbc33980acd13d668f1c8f0313d6ae9fd8: Linux 5.0-rc2 (2019-01-14 10:41:12 +1200) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git tags/staging-5.0-rc4 for you to fetch changes up to 31eb79db420a3f

Re: Tails live usb Realtek rtlxxxau

2019-01-26 Thread Greg KH
On Fri, Jan 25, 2019 at 07:24:37PM +, Gareth Wiggins wrote: > > Hi there > > I would really appreciate some help in getting this driver onto my tails usb > it has persistence enabled. > > I have just spent the last 24 hours getting my new WiFi adapter working with > kali Linux usb. I cou

Re: Tails live usb Realtek rtlxxxau

2019-01-26 Thread Greg KH
On Sat, Jan 26, 2019 at 02:25:28PM +, Gareth Wiggins wrote: > Thanks for the reply i was told to get in touch here. is this even possible? I do not know, you did not give us much, if any, information to understand what your problem is. First off, what hardware is not working with Linux? What

Re: [PATCH 2/2] binderfs: remove separate device_initcall()

2019-01-30 Thread Greg KH
On Wed, Jan 23, 2019 at 12:41:16PM +0100, Christian Brauner wrote: > binderfs should not have a separate device_initcall(). When a kernel is > compiled with CONFIG_ANDROID_BINDERFS register the filesystem alongside > CONFIG_ANDROID_IPC. This use-case is especially sensible when users specify > CONF

Re: patch "staging: erofs: keep corrupted fs from crashing kernel in" added to staging-linus

2019-01-30 Thread Greg KH
On Wed, Jan 30, 2019 at 11:42:41PM +0800, Gao Xiang wrote: > > > On 2019/1/30 23:05, Gao Xiang wrote: > > > > Hi Greg, > > > > Dan raised some suggestions to me. And I want to get some review ideas from > > Chao... > > Current EROFS works good for the normal image, this patch is used for > >

Re: [PATCH] staging:rtlwifi:base.c Fixed line more than 80 characters

2019-01-30 Thread Greg KH
On Wed, Jan 30, 2019 at 07:42:03PM +0100, SandeshKa07 wrote: > From: Sandesh Kenjana Ashok > > Lines over 80 characters are adjusted according to standards. > > Signed-off-by: Sandesh Kenjana Ashok > --- > drivers/staging/rtlwifi/base.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-)

Re: [PATCH] nfit: Collect shutdown status for NVDIMM_FAMILY_HYPERV

2019-01-30 Thread Greg KH
On Wed, Jan 30, 2019 at 06:48:40PM +, Dexuan Cui wrote: > > See http://www.uefi.org/RFIC_LIST ("Virtual NVDIMM 0x1901"): > "Get Unsafe Shutdown Count (Function Index 2)". > > Let's expose the info to the userspace (e.g. ntctl) via sysfs. If you add a new sysfs file, you need to add a new Doc

Re: [PATCH 2/2] binderfs: remove separate device_initcall()

2019-01-30 Thread Greg KH
On Wed, Jan 30, 2019 at 06:01:02PM +0100, Christian Brauner wrote: > On Wed, Jan 30, 2019 at 03:24:12PM +0100, Greg KH wrote: > > On Wed, Jan 23, 2019 at 12:41:16PM +0100, Christian Brauner wrote: > > > binderfs should not have a separate device_initcall(). When a kernel is &

Re: [PATCH 1/3] x86/Hyper-V: Set x2apic destination mode to physical when x2apic is available

2019-01-31 Thread Greg KH
On Thu, Jan 31, 2019 at 06:17:31PM +0800, lantianyu1...@gmail.com wrote: > From: Lan Tianyu > > Hyper-V doesn't provide irq remapping for IO-APIC. To enable x2apic, > set x2apic destination mode to physcial mode when x2apic is available > and Hyper-V IOMMU driver makes sure cpus assigned with IO-

Re: [PATCH 08/15] staging: wilc1000: use correct condition in loops for 'vif_num' count

2019-02-04 Thread Greg KH
On Mon, Feb 04, 2019 at 12:47:23PM +0300, Dan Carpenter wrote: > On Mon, Feb 04, 2019 at 09:42:36AM +, ajay.kat...@microchip.com wrote: > > > > > > On 2/4/2019 1:43 PM, Dan Carpenter wrote: > > > On Sat, Feb 02, 2019 at 07:17:13PM +, ajay.kat...@microchip.com wrote: > > >> From: Ajay Sing

Re: [PATCH 1/6] staging: rtl8192e: rename structure members to avoid camel case - style

2019-02-04 Thread Greg KH
On Mon, Feb 04, 2019 at 04:25:43AM -0800, Himadri Pandya wrote: > struct rt_dot11d_info { > - bool bEnabled; > + bool b_enabled; Please think about _what_ you are renaming. Does your new name make any sense? Why was the "b" there in the first place? Why keep it? These are not to be ju

Re: [PATCH 1/3] staging: rtl8192e: rename members of struct chnl_txpow_triple - style

2019-02-05 Thread Greg KH
On Tue, Feb 05, 2019 at 09:42:37AM -0800, Himadri Pandya wrote: > Rename following members of struct chnl_txpow_triple to avoid > checkpatch warning: Avoid CamelCase > > FirstChnl -> first_chnl > NumChnls -> num_chnls We do have vowels, how about "first_channel" and "num_channels"? M

Re: [PATCH 3/3] staging: rtl8192e: rename members of struct rtllib_device - style

2019-02-05 Thread Greg KH
On Tue, Feb 05, 2019 at 09:42:39AM -0800, Himadri Pandya wrote: > Rename following members of struct rtllib_device to fix checkpatch > warning: Avoid CamelCase > > pDot11dInfo -> dot11d_info > bGlobalDomain -> global_domain > IbssStartChnl -> ibss_start_chnl Why the use of t

Re: [PATCH 3/3] staging: rtl8192e: rename members of struct rtllib_device - style

2019-02-05 Thread Greg KH
On Tue, Feb 05, 2019 at 07:22:11PM +0100, Greg KH wrote: > On Tue, Feb 05, 2019 at 09:42:39AM -0800, Himadri Pandya wrote: > > Rename following members of struct rtllib_device to fix checkpatch > > warning: Avoid CamelCase > > > > pDot11dInfo -> dot11d_

Re: [PATCH 2/3] staging: rtl8192e: rename members of struct rt_dot11d_info - style

2019-02-05 Thread Greg KH
On Tue, Feb 05, 2019 at 09:42:38AM -0800, Himadri Pandya wrote: > Rename following members of struct rt_dot11d_info to avoid checkpatch > warning: Avoid CamelCase > > bEnabled -> enabled > CountryIelen -> country_len > CountryIeBuf -> country_buffer > CountryIeSrcAddr

Re: [PATCH] staging: android: formatting change in ashmem.c

2019-02-07 Thread Greg KH
On Tue, Feb 05, 2019 at 11:53:54PM -0500, K Hodges wrote: > Resolved "Line over 80 characters" warning from checkpatch > > Signed-off-by: K Hodges We need a "full" name here, unless you really do sign legal documents with just "K"? thanks, greg k-h _

Re: [PATCH] staging: wlan-ng: formatting change in cfg80211.c

2019-02-07 Thread Greg KH
On Tue, Feb 05, 2019 at 05:49:03AM -0500, K Hodges wrote: > Resolve "Line over 80 characters" warning from checkpatch > > Signed-off-by: K Hodges Same name question here. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriver

[GIT PULL] Staging/IIO driver fixes for 5.0-rc6

2019-02-08 Thread Greg KH
The following changes since commit f17b5f06cb92ef2250513a1e154c47b78df07d40: Linux 5.0-rc4 (2019-01-27 15:18:05 -0800) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git tags/staging-5.0-rc6 for you to fetch changes up to 6d923f8fe821c0

Re: [PATCH v2 0/7] binder: eliminate use of vmalloc space for binder buffers

2019-02-08 Thread Greg KH
On Wed, Jan 30, 2019 at 02:46:48PM -0800, Todd Kjos wrote: > Binder buffers have always been mapped into kernel space > via map_kernel_range_noflush() to allow the binder driver > to modify the buffer before posting to userspace for > processing. > > In recent Android releases, the number of long-

Re: [PATCH 1/8] staging: rtl8192e: rename function cpMacAddr to copy_mac_addr - style

2019-02-11 Thread Greg KH
On Sun, Feb 10, 2019 at 02:13:12PM +0530, Himadri Pandya wrote: > Rename function cpMacAddr to copy_mac_addr in order to fix checkpatch > warning:Avoid CamelCase and make the function name more readable, > understandable. Please properly wrap your changelog comments at 72 columns. Please fix up

Re: [PATCH] staging: android: vsoc: Remove VSOC_WAIT_FOR_INCOMING_INTERRUPT

2019-02-11 Thread Greg KH
On Mon, Feb 11, 2019 at 08:56:02PM +0530, Souptick Joarder wrote: > As mentioned in TODO list, Removed VSOC_WAIT_FOR_INCOMING_INTERRUPT > ioctl. This functionality has been superseded by the futex and is > there for legacy reasons. > > Signed-off-by: Souptick Joarder > --- > drivers/staging/andr

Re: [PATCH] staging: android: vsoc: Remove VSOC_WAIT_FOR_INCOMING_INTERRUPT

2019-02-11 Thread Greg KH
On Mon, Feb 11, 2019 at 09:21:19PM +0530, Souptick Joarder wrote: > On Mon, Feb 11, 2019 at 9:10 PM Greg KH wrote: > > > > On Mon, Feb 11, 2019 at 08:56:02PM +0530, Souptick Joarder wrote: > > > As mentioned in TODO list, Removed VSOC_WAIT_FOR_INCOMING_INTERRUPT > &g

Re: [PATCH] staging: android: vsoc: Remove VSOC_WAIT_FOR_INCOMING_INTERRUPT

2019-02-11 Thread Greg KH
On Mon, Feb 11, 2019 at 10:15:18PM +0530, Souptick Joarder wrote: > On Mon, Feb 11, 2019 at 9:27 PM Greg KH wrote: > > > > On Mon, Feb 11, 2019 at 09:21:19PM +0530, Souptick Joarder wrote: > > > On Mon, Feb 11, 2019 at 9:10 PM Greg KH > > > wrote: > > &g

Re: [PATCH net-next 3/3] staging: fsl-dpaa2: ethsw: Remove getting PORT_BRIDGE_FLAGS

2019-02-11 Thread Greg KH
On Mon, Feb 11, 2019 at 01:17:49PM -0800, Florian Fainelli wrote: > There is no code that tries to get the attribute > SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS, remove support for doing that. > > Signed-off-by: Florian Fainelli > --- > drivers/staging/fsl-dpaa2/ethsw/ethsw.c | 5 - > 1 file chang

Re: [PATCH 8/8] staging: rtl8192e: rename macro arguments to avoid camel case - style

2019-02-13 Thread Greg KH
A: http://en.wikipedia.org/wiki/Top_post Q: Were do I find info about this thing called top-posting? A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? A: No. Q: Should I includ

Re: [PATCH] binder: fix handling of misaligned binder object

2019-02-14 Thread Greg KH
On Thu, Feb 14, 2019 at 03:22:57PM -0800, Todd Kjos wrote: > Fixes crash found by syzbot: > kernel BUG at drivers/android/binder_alloc.c:LINE! (2) > > Reported-by: syzbot+55de1eb4975dec156...@syzkaller.appspotmail.com As the bot asked, this should be: Reported-and-tested-by: syzbot+55de1

Re: [PATCH] MAINTAINERS: Add mailing list for Hyper-V CORE AND DRIVERS

2019-02-20 Thread Greg KH
On Wed, Feb 20, 2019 at 07:48:23PM +, Haiyang Zhang wrote: > From: Haiyang Zhang > > The new mailing list is: linux-hyp...@vger.kernel.org > > Signed-off-by: Haiyang Zhang > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 86aa22

Re: [PATCH] x86/Hyper-V: Fix definition HV_MAX_FLUSH_REP_COUNT

2019-02-22 Thread Greg KH
On Fri, Feb 22, 2019 at 06:48:44PM +0800, lantianyu1...@gmail.com wrote: > From: Lan Tianyu > > The max flush rep count of HvFlushGuestPhysicalAddressList hypercall > is equal with how many entries of union hv_gpa_page_range can be populated > into the input parameter page. The origin code lacks

Re: [PATCH] staging/ks7070: Removed unused varibale

2019-02-22 Thread Greg KH
On Sat, Feb 23, 2019 at 01:39:39AM -0500, Bo YU wrote: > From: Bo Yu > > Compiling the kernel with W=1 results in the following warning: > > drivers/staging/ks7010/ks_hostif.c:465:6: warning: variable ‘mib_val_type’ > set but not used [-Wunused-but-set-variable] > u16 mib_val_type; > > driver

Re: [PATCH] staging/ks7070: Removed unused varibale

2019-02-23 Thread Greg KH
On Sat, Feb 23, 2019 at 03:09:42AM -0500, YU Bo wrote: > On Sat, Feb 23, 2019 at 08:43:20AM +0100, Greg KH wrote: > > On Sat, Feb 23, 2019 at 01:39:39AM -0500, Bo YU wrote: > > > From: Bo Yu > > > > > > Compiling the kernel with W=1 results in the following w

Re: [PATCH] staging: Note that simple_strtoul can't simply be replaced by kstrtoul

2019-02-23 Thread Greg KH
On Sat, Feb 23, 2019 at 08:42:19PM +0100, Samuel Thibault wrote: > We often receive patches which erroneously try to use kstrtoul in these > places. > > Signed-off-by: Samuel Thibault Awe, it's fun to try to see people do this and not really think about the consequences :) Anyway, seriously, th

Re: [Update PATCH] x86/Hyper-V: Fix definition HV_MAX_FLUSH_REP_COUNT

2019-02-25 Thread Greg KH
On Mon, Feb 25, 2019 at 10:12:14PM +0800, lantianyu1...@gmail.com wrote: > From: Lan Tianyu > > The max flush rep count of HvFlushGuestPhysicalAddressList hypercall > is equal with how many entries of union hv_gpa_page_range can be populated > into the input parameter page. The origin code lacks

Re: [PATCH] staging: rtl8712: fix indentation issues

2019-02-27 Thread Greg KH
On Wed, Feb 27, 2019 at 08:37:51PM +0530, Prashanth Kumar KR wrote: > Fix indentation warnings reported by checkpatch > > Signed-off-by: Prashanth Kumar KR > --- > drivers/staging/rtl8712/ieee80211.c| 3 ++- > drivers/staging/rtl8712/rtl871x_recv.c | 2 +- > 2 files changed, 3 insertions(+),

Re: [PATCH] staging: rtl8712: assign initial value to a static variable in r8712_efuse_pg_packet_write()

2019-02-28 Thread Greg KH
On Wed, Feb 27, 2019 at 11:33:22AM +0800, Mao Wenan wrote: > repeat_times is a static variable, but each time when it enters > r8712_efuse_pg_packet_write(), it is set to zero, > this value is not consistent with last calling, so next behavior > is not our expect. > > Signed-off-by: Mao Wenan > -

Re: [PATCH] Coding style fixes on vme_user.c trivial

2019-03-01 Thread Greg KH
On Fri, Mar 01, 2019 at 04:27:25PM +0200, Oryan Perlmutter wrote: > drivers/staging/devices: Coding style fixes found at file vme_user.c. Your subject line, and this changelog text, need a lot of work. Please look at the other patches that have been accepted for this driver as examples of how to

Re: [PATCH] binder: fix race between munmap() and direct reclaim

2019-03-01 Thread Greg KH
On Fri, Mar 01, 2019 at 03:06:06PM -0800, Todd Kjos wrote: > An munmap() on a binder device causes binder_vma_close() to be called > which clears the alloc->vma pointer. > > If direct reclaim causes binder_alloc_free_page() to be called, there > is a race where alloc->vma is read into a local vma

[GIT PULL] Staging/IIO driver patches for 5.1-rc1

2019-03-06 Thread Greg KH
The following changes since commit d13937116f1e82bf508a6325111b322c30c85eb9: Linux 5.0-rc6 (2019-02-10 14:42:20 -0800) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git tags/staging-5.1-rc1 for you to fetch changes up to 1f08c4a54b7cb6

Re: [PATCH net] staging: rtl8188eu: use is_zero_ether_addr() instead of memcmp()

2019-03-12 Thread Greg KH
On Tue, Mar 12, 2019 at 02:29:29PM +0800, maowenan wrote: > ping... > > On 2019/3/9 11:26, Mao Wenan wrote: What? You got an automated email from my patch system saying that I can not do anything with this patch until after 5.1-rc1 is out, due to the merge window. Why did that not answer the qu

Re: WARNING in rcu_check_gp_start_stall

2019-03-17 Thread Greg KH
On Sun, Mar 17, 2019 at 03:43:01AM -0700, syzbot wrote: > syzbot has bisected this bug to: > > commit f1e3e92135202ff3d95195393ee62808c109208c > Author: Malcolm Priestley > Date: Wed Jul 22 18:16:42 2015 + > > staging: vt6655: fix tagSRxDesc -> next_desc type > > bisection log: https

Re: [PATCH 0/5] Fix several coding style errors

2019-03-17 Thread Greg KH
On Sat, Mar 09, 2019 at 03:30:42PM -0300, Guilherme Tadashi Maeoka wrote: > Fix space around operators, pointer definition, constant on the right > side, assignment outside of if condition and else to follow close brace > at staging: rtl8723bs: os_dep. > > Guilherme Tadashi Maeoka (5): > Staging

Re: [PATCH] [PATCH 1/1] staging: erofs: Add function comment for erofs/super.c

2019-03-17 Thread Greg KH
On Wed, Mar 13, 2019 at 02:36:40AM +0530, Arshad Hussain wrote: > This patch adds functions comment for file erofs/super.c in > sphinx format. > > Signed-off-by: Arshad Hussain > --- > drivers/staging/erofs/super.c | 135 > -- > 1 file changed, 131 insert

Re: [PATCH v2] staging: erofs: Add whitespace after declaration

2019-03-17 Thread Greg KH
On Sat, Mar 16, 2019 at 04:59:58PM +0530, Bharath Vedartham wrote: > Fix the checkpatch.pl warning to add a whitespace after declaration > statements. > > Signed-off-by: Bharath Vedartham > --- > Changes since v2 > - Mutt was giving me a few problems. I apologise for the > previous

Re: [PATCH] staging: gdm724x: Fix alignment in gdm_mux

2019-03-17 Thread Greg KH
On Sat, Mar 09, 2019 at 02:56:14PM -0300, Ignacio Losiggio wrote: > This patch modifies the alignment and linebreaks in gdm_mux in order to make > the code more concise. "concise"? For some of these, there is no real change needed, it's all up to the author's "taste", so they are not needed. >

Re: [PATCH] staging: rtl8723bs: Clean up comments and code

2019-03-17 Thread Greg KH
On Sat, Mar 09, 2019 at 03:08:11PM -0300, Ariel Torti wrote: > From: Ariel Torti > > Header and function comment style fixed. > Remove commented code. > Fix lines longer than 80 characters. You are doing multiple things in the same patch. Please break this up into a patch series, each one only

Re: [PATCH net] staging: rtl8188eu: use is_zero_ether_addr() instead of memcmp()

2019-03-17 Thread Greg KH
On Sat, Mar 09, 2019 at 11:26:00AM +0800, Mao Wenan wrote: > Using is_zero_ether_addr() instead of directly use > memcmp() to determine if the ethernet address is all > zeros. > > Signed-off-by: Mao Wenan > --- > drivers/staging/rtl8188eu/core/rtw_mlme.c | 3 +-- > 1 file changed, 1 insertion(+)

Re: [PATCH 1/5] Staging: rtl8723bs: os_dep: Fix assignment in if condition

2019-03-17 Thread Greg KH
On Sat, Mar 09, 2019 at 03:30:43PM -0300, Guilherme Tadashi Maeoka wrote: > Fix an assignment in if condition. > > Signed-off-by: Guilherme Tadashi Maeoka > --- > drivers/staging/rtl8723bs/os_dep/osdep_service.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) Not all of these could b

Re: [PATCH v2 1/2] staging: gdm724x: Clean long function calls

2019-03-17 Thread Greg KH
On Sun, Mar 17, 2019 at 10:15:34PM -0300, Ignacio Losiggio wrote: > Signed-off-by: Ignacio Losiggio > --- > drivers/staging/gdm724x/gdm_mux.c | 28 ++-- > 1 file changed, 6 insertions(+), 22 deletions(-) I can not take patches without any changelog text, sorry. greg k-h

Re: [PATCH v3] staging: erofs: Add whitespace after declaration

2019-03-18 Thread Greg KH
On Mon, Mar 18, 2019 at 09:02:24PM +0530, Bharath Vedartham wrote: > Add whitespace after declaration. Fixed the checkpatch.pl warning. > > --- No signed-off-by? > changes since v2 > - mutt gave me a lot of problems. Hence 3 patches for a really > small problem. > - Fixed the

Re: custom driver adding into yocto

2019-03-19 Thread Greg KH
On Tue, Mar 19, 2019 at 12:36:10PM +0530, sateesh m wrote: > Hi Sir, > >I am trying to add my own custom driver inside the yocto. how > can I add driver and how to add already available driver .can you please > share readme file. Thanking you in advance. Please read the Yocto document

Re: [PATCH] staging: erofs: fix parenthesis alignment

2019-03-19 Thread Greg KH
On Mon, Mar 18, 2019 at 08:58:41PM -0300, Julian Merida wrote: > Fix all checkpatch issues: "CHECK: Alignment should match open parenthesis" > > Signed-off-by: Julian Merida > Reviewed-by: Gao Xiang Was this really reviewed by Gao? Offline or on-list? I missed it if it was on-list :( thanks,

Re: [PATCH 1/4] Fix comment style in header and functions

2019-03-19 Thread Greg KH
On Tue, Mar 19, 2019 at 12:47:02PM -0300, Ariel Torti wrote: > From: Ariel Torti > > Signed-off-by: Ariel Torti > --- > drivers/staging/rtl8723bs/core/rtw_io.c | 50 > +++-- > 1 file changed, 23 insertions(+), 27 deletions(-) Hi, This is the friendly patch-bot of

Re: [PATCH] staging: ralink-gdma: Prefer u32 over uint32_t

2019-03-21 Thread Greg KH
On Fri, Mar 22, 2019 at 12:07:10AM +0530, Bharath Vedartham wrote: > Change uint32_t to u32 That says _what_ you did, but _why_ are you doing this? That's the main content a changelog text should have in it. thanks, greg k-h ___ devel mailing list de.

<    1   2   3   4   5   6   7   8   9   10   >