Re: [PATCH 4/4] [media] solo6x10: don't turn off/on encoder interrupt in processing loop

Hi Andrey, On 10/29/2014 05:03 PM, Andrey Utkin wrote: The used approach actually cannot prevent new encoder interrupt to appear, because interrupt handler can execute in different thread, and in current implementation there is still race condition regarding this. I don't understand what you

Re: [PATCH 01/15] [media] Move mediabus format definition to a more standard place

On 11/04/14 11:20, Hans Verkuil wrote: Hi Boris, On 11/04/14 10:54, Boris Brezillon wrote: Rename mediabus formats and move the enum into a separate header file so that it can be used by DRM/KMS subsystem without any reference to the V4L2 subsystem. Old V4L2_MBUS_FMT_ definitions

Re: [PATCH 01/15] [media] Move mediabus format definition to a more standard place

Well, I gave two alternatives :-) Both are fine as far as I am concerned, but it would be nice to hear what others think. Regards, Hans On 11/04/14 11:45, Boris Brezillon wrote: Hi Hans, On Tue, 04 Nov 2014 11:20:40 +0100 Hans Verkuil hansv...@cisco.com wrote: Hi Boris, On 11

Re: [PATCH 11/15] [media] Deprecate v4l2_mbus_pixelcode

On 11/05/14 16:15, Boris Brezillon wrote: On Wed, 5 Nov 2014 17:08:15 +0200 Sakari Ailus sakari.ai...@iki.fi wrote: Hi Boris, On Tue, Nov 04, 2014 at 10:55:06AM +0100, Boris Brezillon wrote: The v4l2_mbus_pixelcode enum (or its values) should be replaced by the media_bus_format enum.

Re: [PATCH 11/15] [media] Deprecate v4l2_mbus_pixelcode

On 11/05/14 16:30, Boris Brezillon wrote: On Wed, 05 Nov 2014 16:19:56 +0100 Hans Verkuil hansv...@cisco.com wrote: On 11/05/14 16:15, Boris Brezillon wrote: On Wed, 5 Nov 2014 17:08:15 +0200 Sakari Ailus sakari.ai...@iki.fi wrote: Hi Boris, On Tue, Nov 04, 2014 at 10:55:06AM +0100

Re: [PATCH v2 01/10] [media] Move mediabus format definition to a more standard place

On 11/07/14 12:43, Sakari Ailus wrote: Hi Boris, Thank you for the update. On Thu, Nov 06, 2014 at 10:56:59AM +0100, Boris Brezillon wrote: Rename mediabus formats and move the enum into a separate header file so that it can be used by DRM/KMS subsystem without any reference to the V4L2

Re: [PATCH v3 10/10] [media] v4l: Forbid usage of V4L2_MBUS_FMT definitions inside the kernel

Nitpicks: On 11/07/14 15:07, Boris Brezillon wrote: Place v4l2_mbus_pixelcode in a #ifndef __KERNEL__ section so that kernel users don't have access to these definitions. We have to keep this definition for user-space users even though they're encouraged to move to the new media_bus_format

Re: [PATCH v3 00/10] [media] Make mediabus format subsystem neutral

defines MEDIA_BUS_FMT_ macros, and then replace all references to the v4l2_mbus_pixelcode enum and its values within the kernel. Looks good! For patches 1-9: Acked-by: Hans Verkuil hans.verk...@cisco.com Patch 10 needs a bit more work, see my reply to that patch. If I get a v4 for that patch

Re: [PATCH v5 10/10] [media] v4l: Forbid usage of V4L2_MBUS_FMT definitions inside the kernel

On 11/08/2014 04:47 PM, Boris Brezillon wrote: Place v4l2_mbus_pixelcode in a #ifndef __KERNEL__ section so that kernel users don't have access to these definitions. We have to keep this definition for user-space users even though they're encouraged to move to the new media_bus_format enum.

Re: [PATCH] drivers:staging:media:omap24xx:v4l2-int-device.h: Added a '*' before ')'--(parenthesis closing)

On 11/30/2014 11:58 AM, Anjana Sasindran wrote: This patch fix a checkpatch.pl error: ERROR: space prohibited before ')' parenthesis closing Signed-off-by: Anjana Sasindran anjanasasindran...@gmail.com Thanks for the patch, but this driver is removed in kernel 3.19. So there is no point in

Re: [PATCH] drivers:staging:media:omap24xx:v4l2-int-device.h: Added a '*' before ')'--(parenthesis closing)

On 12/01/2014 02:01 PM, anjana s wrote: Should I do anything on this further? No. The driver will disappear in 3.19, so there is no point to this patch. BTW, always check the Kconfig to see if a staging driver is marked deprecated. If so, then patches are pointless. Regards, Hans

Re: [PATCH] media: davinci_vpfe: fix build error

I just made a patch myself that I added to the pull request I just posted. You didn't CC me or CC the linux-media list when you posted your patch, so I never saw it. Regards, Hans On 12/20/2013 01:47 PM, Prabhakar Lad wrote: Hi Hans, On Tue, Dec 17, 2013 at 8:55 PM, Lad, Prabhakar

Re: [PATCH] media: davinci_vpfe: fix build error

Hi Prabhakar, On 12/20/2013 02:02 PM, Prabhakar Lad wrote: Hi Hans, On Fri, Dec 20, 2013 at 6:23 PM, Hans Verkuil hverk...@xs4all.nl wrote: I just made a patch myself that I added to the pull request I just posted. You didn't CC me or CC the linux-media list when you posted your patch, so

Re: [PATCH 19/51] DMA-API: media: dt3155v4l: replace dma_set_mask()+dma_set_coherent_mask() with new helper

On 09/19/2013 11:44 PM, Russell King wrote: Replace the following sequence: dma_set_mask(dev, mask); dma_set_coherent_mask(dev, mask); with a call to the new helper dma_set_mask_and_coherent(). Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk Acked-by: Hans Verkuil

Re: [PATCH 1/6] v4l: omap4iss: Add support for OMAP4 camera interface - Core

A few small comments below... On 10/03/2013 01:55 AM, Laurent Pinchart wrote: From: Sergio Aguirre sergio.a.agui...@gmail.com This adds a very simplistic driver to utilize the CSI2A interface inside the ISS subsystem in OMAP4, and dump the data to memory. Check

Re: [PATCH 2/6] v4l: omap4iss: Add support for OMAP4 camera interface - Video devices

On 10/03/2013 01:55 AM, Laurent Pinchart wrote: From: Sergio Aguirre sergio.a.agui...@gmail.com This adds a very simplistic driver to utilize the CSI2A interface inside the ISS subsystem in OMAP4, and dump the data to memory. Check Documentation/video4linux/omap4_camera.txt for details.

Re: [PATCH] Staging: Media: sn9c102: Fixed a pointer declaration coding style issue

On 05/23/2014 06:59 PM, Chaitanya Hazarey wrote: Hey Dan, Sorry my bad, will resubmit the patch in a proper manner with the required corrections. Don't bother. This patch: http://comments.gmane.org/gmane.linux.drivers.driver-project.devel/48570 has just been merged and that has the same

Re: [PATCH] Staging: media: Added semicolon.

On 10/04/2014 08:43 PM, Stevean Raja Kumar wrote: Added semicolon for the line usleep_range(1, 11000); Against which kernel is this patch? I don't see a usleep_range in either the mainline kernel or the media_tree.git kernel. Regards, Hans Signed-off-by: Stevean Raja Kumar

Re: [PATCH 2/2] tlg2300: Fix media dependencies

Acked-by: Hans Verkuil hans.verk...@cisco.com On 12/23/2014 06:02 PM, Mauro Carvalho Chehab wrote: Changeset ea2e813e8cc3 moved the driver to staging, but it forgot to preserve the existing dependency. Fixes: ea2e813e8cc3 ([media] tlg2300: move to staging in preparation for removal) Cc

Re: [PATCH 1/2] vino: Fix media dependencies

Acked-by: Hans Verkuil hans.verk...@cisco.com On 12/23/2014 06:02 PM, Mauro Carvalho Chehab wrote: Changeset c1d9e03d4ef4 moved the driver to staging, but it forgot to preserve the existing dependency. fixes: c1d9e03d4ef4 ([media] vino/saa7191: move to staging in preparation for removal

Re: [PATCH] staging: media: vino: vino: Removed variables that is never used

On 01/28/2015 11:47 PM, Rickard Strandqvist wrote: Variable ar assigned a value that is never used. I have also removed all the code that thereby serves no purpose. This was found using a static code analysis program called cppcheck FYI: I've dropped this patch since the vino driver will be

Re: [PATCH 10/18] media controller: use macros to check for V4L2 subdev entities

On 05/08/2015 03:12 AM, Mauro Carvalho Chehab wrote: Instead of relying on media subtype, use the new macros to detect if an entity is a subdev or an A/V DMA entity. Please note that most drivers assume that there's just AV_DMA or V4L2 subdevs. This is not true anymore, as we've added MC

Re: [PATCH] Clarify expression which uses both multiplication and pointer dereference

On 05/18/2015 10:06 AM, Lad, Prabhakar wrote: On Mon, May 18, 2015 at 7:51 AM, Michal Kubecek mkube...@suse.cz wrote: On Sun, May 17, 2015 at 07:18:42PM +0200, Alex Dowad wrote: This fixes a checkpatch style error in vpfe_buffer_queue_setup. Signed-off-by: Alex Dowad alexinbeij...@gmail.com

Re: [PATCH RFC v3 10/16] media: rename link source/sink to pad0_source/pad1_sink

On 08/12/15 22:14, Mauro Carvalho Chehab wrote: Change the internal namespace for links between two pads to have the pad there. We're also numbering it, as a common constructor is to do things like: if (link-port1.type != MEDIA_GRAPH_PAD) continue; if

Re: [PATCH 0/4] [media] Media entity cleanups and build fixes

this particular change (patch 3/8), otherwise it would break git bisect. Anyway, Acked-by: Hans Verkuil hans.verk...@cisco.com for the changes in patch 1 and 2, as long as they are added to Mauro's patch 3/8. Regards, Hans The series depend on Mauro's [PATCH v6 0/8] MC preparation patches

Re: [PATCH 3/4] [media] media: use entity.graph_obj.mdev instead of .parent

-by: Mauro Carvalho Chehab mche...@osg.samsung.com Signed-off-by: Javier Martinez Canillas jav...@osg.samsung.com Acked-by: Hans Verkuil hans.verk...@cisco.com Regards, Hans ___ devel mailing list de...@linuxdriverproject.org http

Re: [PATCH 1/4] [media] staging: omap4iss: get entity ID using media_entity_id()

On 08/21/2015 02:15 AM, Laurent Pinchart wrote: Hi Javier, On Friday 21 August 2015 02:14:05 Javier Martinez Canillas wrote: On 08/20/2015 08:37 PM, Laurent Pinchart wrote: On Wednesday 19 August 2015 17:35:19 Javier Martinez Canillas wrote: The struct media_entity does not have an .id

Re: [PATCH RFC v5 8/8] [media] media: rename the function that create pad links

-by: Mauro Carvalho Chehab mche...@osg.samsung.com Acked-by: Hans Verkuil hans.verk...@cisco.com Thanks! Hans ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH RFC v2 09/16] media: use media_graph_obj for link endpoints

Hi Mauro, Thanks for posting the missing patches. On 08/11/15 14:09, Mauro Carvalho Chehab wrote: As we'll need to create links between entities and interfaces, we need to identify the link endpoints by the media_graph_obj. Most of the changes here was done by this small script: for i in

Re: [PATCH RFC v2 09/16] media: use media_graph_obj for link endpoints

diff --git a/include/media/media-entity.h b/include/media/media-entity.h index 403019035424..f6e2136480f1 100644 --- a/include/media/media-entity.h +++ b/include/media/media-entity.h @@ -43,6 +43,17 @@ enum media_graph_type { MEDIA_GRAPH_LINK, }; +/** + * enum media_graph_link_dir

Re: [PATCH v4 1/6] media: get rid of unused extra_links param on media_entity_init()

sakari.ai...@linux.intel.com Acked-by: Hans Verkuil hans.verk...@cisco.com Thanks! Hans ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v7 02/44] [media] staging: omap4iss: get entity ID using media_entity_id()

by using the media_entity_id() macro to obtain the entity ID. This commit log is now a bit misleading since with the new position in this patch series this change is here to *prevent* a build failure once the id field is removed, and not to fix a build failure. After fixing this: Acked-by: Hans

Re: [PATCH v7 11/44] [media] media: use entity.graph_obj.mdev instead of .parent

-vdev.entity.parent + ve-vdev.entity.graph_obj.mdev Suggested-by: Mauro Carvalho Chehab mche...@osg.samsung.com Signed-off-by: Javier Martinez Canillas jav...@osg.samsung.com Signed-off-by: Mauro Carvalho Chehab mche...@osg.samsung.com Acked-by: Hans Verkuil hans.verk...@cisco.com

Re: [RFC PATCH v0] Add tw5864 driver

Hi Andrey, On 01/03/2016 02:41 AM, Andrey Utkin wrote: > (Disclaimer up to scissors mark) > > Please be so kind to take a look at a new driver. > We aim to follow high standards of kernel development and possibly to get > this driver in mainline kernel. > The device is multichannel video and

Re: [RFC] [PATCH 0/3] media: an attempt to refresh omap1_camera driver

Hi Janusz, On 06/16/2016 07:21 PM, Janusz Krzysztofik wrote: > As requested by media subsystem maintainers, here is an attempt to > convert the omap1_camera driver to the vb2 framework. Also, conversion > to the dmaengine framework, long awaited by ARM/OMAP maintainers, is > done. > > Next,

Re: [RFC PATCH v0] Add tw5864 driver

Hi Andrey, Hmm, it looks like I forgot to reply. Sorry about that. On 01/15/2016 03:13 AM, Andrey Utkin wrote: > On Mon, Jan 11, 2016 at 12:52 PM, Hans Verkuil <hverk...@xs4all.nl> wrote: >> Did you also test with v4l2-compliance? Before I accept the driver I want to >&

Re: [RFC PATCH v0] Add tw5864 driver

On 02/08/2016 11:23 AM, Andrey Utkin wrote: > On Mon, Feb 8, 2016 at 11:58 AM, Hans Verkuil <hverk...@xs4all.nl> wrote: >> Hi Andrey, >> >> Hmm, it looks like I forgot to reply. Sorry about that. > > Thank you very much anyway. > >> I wouldn't chan

Re: [RFC PATCH v0] Add tw5864 driver

On 03/11/2016 09:40 AM, Andrey Utkin wrote: > On Fri, 11 Mar 2016 09:00:18 +0100 > Hans Verkuil <hverk...@xs4all.nl> wrote: >> The reason is likely to be the tw5864_queue_setup function which has >> not been updated to handle CREATE_BUFS support correctly. It should >>

Re: [RFC PATCH v0] Add tw5864 driver

On 03/09/2016 03:29 PM, Andrey Utkin wrote: > Hi Hans! > > Some improvements took place on the driver, including cleaner > v4l2-compliance tests passing. But there's a single test failure I > don't understand. > > In the code of v4l2-compliance, it seems like an API > call CREATE_BUFS is

Re: [PATCH] Add tw5864 driver

Hi Andrey, See below for a quick review of the code. I agree with Greg's comment why this is added to staging instead of drivers/media/pci? When you post the v2 patch, can you add the output of 'v4l2-compliance -s' to the cover letter? Please use the latest v4l2-compliance version from the

Re: [PATCH] dma-buf: Update docs for SYNC ioctl

Hi Daniel, Two small comments: On 03/21/2016 08:30 AM, Daniel Vetter wrote: > Just a bit of wording polish plus mentioning that it can fail and must > be restarted. > > Requested by Sumit. > > Cc: Chris Wilson > Cc: Tiago Vignatti > Cc:

Re: [PATCH] dma-buf: Update docs for SYNC ioctl

dri-de...@lists.freedesktop.org > Cc: linaro-mm-...@lists.linaro.org > Cc: intel-...@lists.freedesktop.org > Cc: de...@driverdev.osuosl.org > Cc: Hans Verkuil <hverk...@xs4all.nl> > Acked-by: Sumit Semwal <sumit.sem...@linaro.org> > Signed-off-by: Daniel Vetter <

Re: [PATCH v4] [media] pci: Add tw5864 driver - fixed few style nits, going to resubmit soon

On 07/13/2016 04:05 AM, Andrey Utkin wrote: > Found and fixed few very minor coding style nits, will resubmit in few days, > now still waiting for comments to v4. Can you resubmit now? I plan to review it on Friday or Monday, and I'd rather review the latest version. Regards, Hans > >

Re: [PATCH 2/2] [media] cec: add RC_CORE dependency

On 07/19/16 10:10, Arnd Bergmann wrote: > We cannot build the cec driver when the RC core is a module > and cec is built-in: > > drivers/staging/built-in.o: In function `cec_allocate_adapter': > :(.text+0x134): undefined reference to `rc_allocate_device' > drivers/staging/built-in.o: In function

Re: [PATCH v6] [media] pci: Add tw5864 driver

On 07/20/2016 03:42 AM, Andrey Utkin wrote: > Changes since v5: > - Rework known issues notice as suggested by Hans Verkuil (and previously > Joe Perches) > > I am leaving for a vacation in a day and won't respond before 3rd of August. > I wish to all of you to enjoy your time

Re: [PATCH v5] [media] pci: Add tw5864 driver

drivers/media/pci/tw5864/tw5864-util.c > create mode 100644 drivers/media/pci/tw5864/tw5864-video.c > create mode 100644 drivers/media/pci/tw5864/tw5864.h > > diff --git a/MAINTAINERS b/MAINTAINERS > index a975b8e..46daa99 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @

Re: [PATCH v3] Add tw5864 driver

/tw5864/tw5864-video.c > create mode 100644 drivers/media/pci/tw5864/tw5864.h > > diff --git a/MAINTAINERS b/MAINTAINERS > index a975b8e..46daa99 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -11598,6 +11598,14 @@ T: git git://linuxtv.org/media_tree.gi

Re: [PATCH v3] Add tw5864 driver

On 07/11/2016 01:48 PM, Andrey Utkin wrote: > Thanks for review Hans! > > On Mon, Jul 11, 2016 at 07:58:38AM +0200, Hans Verkuil wrote: >>> +" v4l2-ctl --device $dev --set-ctrl=video_gop_size=1; done\n" >> >> Replace $dev by /dev/videoX >

Re: [PATCH] Staging: media: timblogiw: File cleanup.

This driver will be removed in 4.8, so I won't take this patch. Regards, Hans On 07/20/2016 08:47 PM, Jeremiah Goerdt wrote: > Cleaned up checkpatch.pl warnings and checks. > > Signed-off-by: Jeremiah Goerdt > --- > drivers/staging/media/timb/timblogiw.c |

Re: [RFC] [PATCH 0/3] media: an attempt to refresh omap1_camera driver

On 06/17/2016 09:04 AM, Hans Verkuil wrote: > Hi Janusz, > > On 06/16/2016 07:21 PM, Janusz Krzysztofik wrote: >> As requested by media subsystem maintainers, here is an attempt to >> convert the omap1_camera driver to the vb2 framework. Also, conversion >> to th

Re: [PATCH v2] Add tw5864 driver

On 06/10/2016 12:11 AM, Andrey Utkin wrote: > Fixed most of issues discovered by v1 and RFCv0 reviewers. Refactored a lot. > > The only thing from previous review I haven't got my head around yet is > framerate control - Hans Verkuil has told to support 1001/3 frame > inter

Re: [RFC] [PATCH 0/3] media: an attempt to refresh omap1_camera driver

On 07/04/2016 01:32 AM, Aaro Koskinen wrote: > Hi, > > On Fri, Jun 17, 2016 at 09:04:52AM +0200, Hans Verkuil wrote: >> Out of curiosity: is supporting the Amstrad Delta something you do as a hobby >> or are there other reasons? > > Out of curiousity, why should thi

Re: [PATCH 1/6] staging: Import the BCM2835 MMAL-based V4L2 camera driver.

On 01/27/2017 10:54 PM, Eric Anholt wrote: > - Supports raw YUV capture, preview, JPEG and H264. > - Uses videobuf2 for data transfer, using dma_buf. > - Uses 3.6.10 timestamping > - Camera power based on use > - Uses immutable input mode on video encoder > > This code comes from the Raspberry Pi

Re: [PATCH 1/6] staging: Import the BCM2835 MMAL-based V4L2 camera driver.

On 02/06/2017 12:37 PM, Dave Stevenson wrote: > Hi Hans. > > On 06/02/17 09:08, Hans Verkuil wrote: >> Hi Eric, >> >> Great to see this driver appearing for upstream merging! >> >> See below for my review comments, focusing mostly on V4L2 specifics. >>

Re: [PATCH 1/6] staging: Import the BCM2835 MMAL-based V4L2 camera driver.

On 02/06/2017 04:21 PM, Dave Stevenson wrote: > Hi Hans. > > On 06/02/17 12:58, Hans Verkuil wrote: >> On 02/06/2017 12:37 PM, Dave Stevenson wrote: >>> Hi Hans. >>> >>> On 06/02/17 09:08, Hans Verkuil wrote: >>>> Hi Eric, >>>

Re: [PATCH 1/6] staging: Import the BCM2835 MMAL-based V4L2 camera driver.

Hi Eric, Great to see this driver appearing for upstream merging! See below for my review comments, focusing mostly on V4L2 specifics. On 01/27/2017 10:54 PM, Eric Anholt wrote: > - Supports raw YUV capture, preview, JPEG and H264. > - Uses videobuf2 for data transfer, using dma_buf. > - Uses

Re: [PATCH v3 13/24] platform: add video-multiplexer subdevice driver

On 02/05/2017 04:48 PM, Laurent Pinchart wrote: > Hi Steve, > > On Tuesday 24 Jan 2017 18:07:55 Steve Longerbeam wrote: >> On 01/24/2017 04:02 AM, Philipp Zabel wrote: >>> On Fri, 2017-01-20 at 15:03 +0100, Hans Verkuil wrote: >>>>> + >>>>> +

Re: [PATCH v3 00/24] i.MX Media Driver

On 01/23/2017 12:00 PM, Philipp Zabel wrote: > On Fri, 2017-01-20 at 21:39 +0100, Hans Verkuil wrote: > [...] >>> There is a VDIC entity in the i.MX IPU that performs de-interlacing with >>> hardware filters for motion compensation. Some of the motion compensation >

Re: [PATCH v3 00/24] i.MX Media Driver

Hi Steve, Philipp, On 01/07/2017 03:11 AM, Steve Longerbeam wrote: > In version 3: > > Changes suggested by Rob Herring : > > - prepended FIM node properties with vendor prefix "fsl,". > > - make mipi csi-2 receiver compatible string SoC specific: >

Re: [PATCH v3 19/24] media: imx: Add IC subdev drivers

On 01/07/2017 03:11 AM, Steve Longerbeam wrote: > This is a set of three media entity subdevice drivers for the i.MX > Image Converter. The i.MX IC module contains three independent > "tasks": > > - Pre-processing Encode task: video frames are routed directly from > the CSI and can be scaled,

Re: [PATCH v3 13/24] platform: add video-multiplexer subdevice driver

On 01/07/2017 03:11 AM, Steve Longerbeam wrote: > From: Philipp Zabel > > This driver can handle SoC internal and external video bus multiplexers, > controlled either by register bit fields or by a GPIO. The subdevice > passes through frame interval and mbus configuration

Re: [PATCH v3 20/24] media: imx: Add Camera Interface subdev driver

On 01/07/2017 03:11 AM, Steve Longerbeam wrote: > This is the camera interface driver that provides the v4l2 > user interface. Frames can be received from various sources: > > - directly from SMFC for capturing unconverted images directly from > camera sensors. > > - from the IC pre-process

Re: [PATCH v3 12/24] add mux and video interface bridge entity functions

On 01/07/2017 03:11 AM, Steve Longerbeam wrote: > From: Philipp Zabel > > Signed-off-by: Philipp Zabel > --- > Documentation/media/uapi/mediactl/media-types.rst | 22 ++ > include/uapi/linux/media.h| 6

Re: [PATCH v3 22/24] media: imx: Add MIPI CSI-2 OV5640 sensor subdev driver

On 01/07/2017 03:11 AM, Steve Longerbeam wrote: > This driver is based on ov5640_mipi.c from Freescale imx_3.10.17_1.0.0_beta > branch, modified heavily to bring forward to latest interfaces and code > cleanup. > > Signed-off-by: Steve Longerbeam > --- >

Re: [PATCH v3 00/24] i.MX Media Driver

On 01/20/2017 07:40 PM, Steve Longerbeam wrote: > Hi Hans, Philipp, > > > On 01/20/2017 08:31 AM, Philipp Zabel wrote: >> Hi Hans, >> >> On Fri, 2017-01-20 at 14:52 +0100, Hans Verkuil wrote: >>> Hi Steve, Philipp, >>> >>> On 01/07

Re: [PATCH] Staging: media: bcm2048: Fixed coding style issue.

On 02/12/2017 10:45 PM, Ran Algawi wrote: > Fixed a coding style issue, where an octal value was needed insted of decimal. > > Signed-off-by: Ran Algawi > --- > drivers/staging/media/bcm2048/radio-bcm2048.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff

Re: [PATCH 1/6] staging: Import the BCM2835 MMAL-based V4L2 camera driver.

On 02/06/2017 05:00 PM, Hans Verkuil wrote: > On 02/06/2017 04:21 PM, Dave Stevenson wrote: >> Hi Hans. >> >> On 06/02/17 12:58, Hans Verkuil wrote: >>> On 02/06/2017 12:37 PM, Dave Stevenson wrote: >>>> Hi Hans. >>>> >>>> On 06

Re: [PATCH v5 00/39] i.MX Media Driver

On 03/21/17 11:42, Niklas Söderlund wrote: > On 2017-03-20 16:57:54 +0100, Hans Verkuil wrote: >> On 03/20/2017 03:11 PM, Russell King - ARM Linux wrote: >>> On Mon, Mar 20, 2017 at 02:57:03PM +0100, Hans Verkuil wrote: >>>> On 03/20/2017 02:29 PM, Russell King - ARM

Re: [PATCH v5 00/39] i.MX Media Driver

On 03/19/2017 06:54 PM, Steve Longerbeam wrote: > > > On 03/19/2017 03:38 AM, Russell King - ARM Linux wrote: >> On Sat, Mar 18, 2017 at 12:58:27PM -0700, Steve Longerbeam wrote: >>> Right, imx-media-capture.c (the "standard" v4l2 user interface module) >>> is not implementing

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

On 03/17/2017 03:37 PM, Russell King - ARM Linux wrote: > On Fri, Mar 17, 2017 at 02:51:10PM +0100, Philipp Zabel wrote: >> On Fri, 2017-03-17 at 10:24 -0300, Mauro Carvalho Chehab wrote: >> [...] >>> The big question, waiting for an answer on the last 8 years is >>> who would do that? Such person

Re: [PATCH v5 00/39] i.MX Media Driver

On 03/19/2017 01:14 PM, Russell King - ARM Linux wrote: > On Sat, Mar 18, 2017 at 12:58:27PM -0700, Steve Longerbeam wrote: >> On 03/18/2017 12:22 PM, Russell King - ARM Linux wrote: >>> 0:00:01.955927879 20954 0x15ffe90 INFOv4l2 >>>

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

On 03/17/2017 12:55 PM, Sakari Ailus wrote: > Hi Russell, > > On 03/17/17 13:42, Russell King - ARM Linux wrote: >> On Tue, Mar 14, 2017 at 08:55:36AM +0100, Hans Verkuil wrote: >>> We're all very driver-development-driven, and userspace gets very little >>> att

Re: [PATCH v5 00/39] i.MX Media Driver

On 03/20/2017 03:11 PM, Russell King - ARM Linux wrote: > On Mon, Mar 20, 2017 at 02:57:03PM +0100, Hans Verkuil wrote: >> On 03/20/2017 02:29 PM, Russell King - ARM Linux wrote: >>> It's what I have - remember, not everyone is happy to constantly replace >>> their dist

Re: [PATCH v5 00/39] i.MX Media Driver

On 03/20/2017 02:29 PM, Russell King - ARM Linux wrote: > On Mon, Mar 20, 2017 at 02:01:58PM +0100, Hans Verkuil wrote: >> On 03/19/2017 06:54 PM, Steve Longerbeam wrote: >>> >>> >>> On 03/19/2017 03:38 AM, Russell King - ARM Linux wrote: >>

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

On 03/14/2017 11:21 AM, Mauro Carvalho Chehab wrote: > Em Tue, 14 Mar 2017 08:55:36 +0100 > Hans Verkuil <hverk...@xs4all.nl> escreveu: > >> On 03/14/2017 04:45 AM, Mauro Carvalho Chehab wrote: >>> Hi Sakari, >>> >>> I started preparin

Re: [PATCH] [media] imx: csi: retain current field order and colorimetry setting as default

On 04/06/2017 06:01 PM, Philipp Zabel wrote: > On Thu, 2017-04-06 at 17:43 +0200, Hans Verkuil wrote: >> On 04/06/2017 04:54 PM, Philipp Zabel wrote: >>> On Thu, 2017-04-06 at 16:20 +0200, Hans Verkuil wrote: >>>> On 04/06/2017 03:55 PM, Philipp Zabel wrote: >&

Re: [PATCH] [media] imx: csi: retain current field order and colorimetry setting as default

On 04/06/2017 03:55 PM, Philipp Zabel wrote: > If the the field order is set to ANY in set_fmt, choose the currently > set field order. If the colorspace is set to DEFAULT, choose the current > colorspace. If any of xfer_func, ycbcr_enc or quantization are set to > DEFAULT, either choose the

Re: [PATCH] [media] imx: csi: retain current field order and colorimetry setting as default

On 04/06/2017 04:54 PM, Philipp Zabel wrote: > On Thu, 2017-04-06 at 16:20 +0200, Hans Verkuil wrote: >> On 04/06/2017 03:55 PM, Philipp Zabel wrote: >>> If the the field order is set to ANY in set_fmt, choose the currently >>> set field order. If the colorspac

Re: [PATCH v5 15/39] [media] v4l2: add a frame interval error event

On 03/13/2017 11:45 AM, Russell King - ARM Linux wrote: > On Mon, Mar 13, 2017 at 11:02:34AM +0100, Hans Verkuil wrote: >> On 03/11/2017 07:14 PM, Steve Longerbeam wrote: >>> The event must be user visible, otherwise the user has no indication >>> the error, and can't c

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

On 03/12/2017 06:56 PM, Steve Longerbeam wrote: > > > On 03/11/2017 11:37 PM, Russell King - ARM Linux wrote: >> On Sat, Mar 11, 2017 at 07:31:18PM -0800, Steve Longerbeam wrote: >>> >>> >>> On 03/11/2017 10:59 AM, Russell King - ARM Linux wrote: On Sat, Mar 11, 2017 at 10:54:55AM -0800,

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

On 03/13/2017 11:58 AM, Russell King - ARM Linux wrote: > On Mon, Mar 13, 2017 at 11:44:50AM +0100, Hans Verkuil wrote: >> On 03/12/2017 06:56 PM, Steve Longerbeam wrote: >>> In summary, I do like the media framework, it's a good abstraction of >>> hardware pipel

Re: [PATCH v5 15/39] [media] v4l2: add a frame interval error event

On 03/13/2017 06:06 PM, Steve Longerbeam wrote: > > > On 03/13/2017 03:53 AM, Hans Verkuil wrote: >> On 03/13/2017 11:45 AM, Russell King - ARM Linux wrote: >>> On Mon, Mar 13, 2017 at 11:02:34AM +0100, Hans Verkuil wrote: >>>> On 03/11/2017 07:14 PM, Steve Lo

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

On 10/03/17 14:07, Russell King - ARM Linux wrote: > On Fri, Mar 10, 2017 at 01:54:28PM +0100, Hans Verkuil wrote: >> But there was always meant to be a layer (libv4l plugin) that could be >> used to setup a 'default scenario' that existing applications could use, >> but th

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

On 04/03/17 14:13, Sakari Ailus wrote: > Hi Russell, > > On Fri, Mar 03, 2017 at 11:06:45PM +, Russell King - ARM Linux wrote: >> On Thu, Mar 02, 2017 at 06:02:57PM +0200, Sakari Ailus wrote: >>> Hi Steve, >>> >>> On Wed, Feb 15, 2017 at 06:19:16PM -0800, Steve Longerbeam wrote:

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

On 10/03/17 15:01, Russell King - ARM Linux wrote: > On Fri, Mar 10, 2017 at 02:22:29PM +0100, Hans Verkuil wrote: >> And nobody of the media core developers has the time to work on the docs, >> utilities and libraries you need to make this all work cleanly and reliably. > >

Re: [PATCH v5 21/39] UAPI: Add media UAPI Kbuild file

On 03/11/2017 07:20 PM, Steve Longerbeam wrote: > > > On 03/11/2017 05:49 AM, Sakari Ailus wrote: >> Hi Steve, >> >> On Thu, Mar 09, 2017 at 08:53:01PM -0800, Steve Longerbeam wrote: >>> Add an empty UAPI Kbuild file for media UAPI headers. >>> >>> Signed-off-by: Steve Longerbeam

Re: [PATCH v5 15/39] [media] v4l2: add a frame interval error event

On 03/11/2017 07:14 PM, Steve Longerbeam wrote: > > > On 03/11/2017 03:39 AM, Hans Verkuil wrote: >> On 10/03/17 19:37, Steve Longerbeam wrote: >>> Hi Hans, >>> >>> On 03/10/2017 04:03 AM, Hans Verkuil wrote: >>>> On 10/03/17 05:52, Steve

Re: [PATCH v5 15/39] [media] v4l2: add a frame interval error event

On 10/03/17 05:52, Steve Longerbeam wrote: > Add a new FRAME_INTERVAL_ERROR event to signal that a video capture or > output device has measured an interval between the reception or transmit > completion of two consecutive frames of video that is outside the nominal > frame interval by some

Re: [PATCH v5 16/39] [media] v4l2: add a new-frame before end-of-frame event

On 10/03/17 05:52, Steve Longerbeam wrote: > Add a NEW_FRAME_BEFORE_EOF event to signal that a video capture or > output device has signaled a new frame is ready before a previous > frame has completed reception or transmission. This usually indicates > a DMA read/write channel is having trouble

Re: [PATCH v5 17/39] [media] v4l2-mc: add a function to inherit controls from a pipeline

On 10/03/17 05:52, Steve Longerbeam wrote: > v4l2_pipeline_inherit_controls() will add the v4l2 controls from > all subdev entities in a pipeline to a given video device. > > Signed-off-by: Steve Longerbeam > --- > drivers/media/v4l2-core/v4l2-mc.c | 48 >

Re: [PATCH v5 22/39] media: Add userspace header file for i.MX

On 10/03/17 05:53, Steve Longerbeam wrote: > This adds a header file for use by userspace programs wanting to interact > with the i.MX media driver. It defines custom v4l2 controls for the > i.MX v4l2 subdevices. > > Signed-off-by: Steve Longerbeam I would not

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

On 10/03/17 16:09, Mauro Carvalho Chehab wrote: > Em Fri, 10 Mar 2017 13:54:28 +0100 > Hans Verkuil <hverk...@xs4all.nl> escreveu: > >>> Devices that have complex pipeline that do essentially require using the >>> Media controller interface to con

Re: [PATCH v5 15/39] [media] v4l2: add a frame interval error event

On 10/03/17 19:37, Steve Longerbeam wrote: > Hi Hans, > > On 03/10/2017 04:03 AM, Hans Verkuil wrote: >> On 10/03/17 05:52, Steve Longerbeam wrote: >>> Add a new FRAME_INTERVAL_ERROR event to signal that a video capture or >>> output device has measured

Re: [PATCH v4 29/36] media: imx: mipi-csi2: enable setting and getting of frame rates

On 03/13/2017 10:03 PM, Sakari Ailus wrote: > Hi Steve, > > On Mon, Mar 13, 2017 at 11:06:22AM -0700, Steve Longerbeam wrote: >> >> >> On 03/13/2017 06:55 AM, Philipp Zabel wrote: >>> On Mon, 2017-03-13 at 13:27 +, Russell King - ARM Linux wrote: On Mon, Mar 13, 2017 at 03:16:48PM +0200,

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

On 03/14/2017 04:45 AM, Mauro Carvalho Chehab wrote: > Hi Sakari, > > I started preparing a long argument about it, but gave up in favor of a > simpler one. > > Em Mon, 13 Mar 2017 14:46:22 +0200 > Sakari Ailus escreveu: > >> Drivers are written to support hardware, not

Re: [PATCH v2 1/3] staging: greybus: light: fix memory leak in v4l2 register

On 10/08/17 15:02, Hans Verkuil wrote: > On 09/08/17 13:15, Sakari Ailus wrote: >> From: Rui Miguel Silva <rmf...@gmail.com> >> >> We are allocating memory for the v4l2 flash configuration structure and >> leak it in the normal path. Just use the stack for th

Re: [PATCH v2 3/3] v4l2-flash-led-class: Document v4l2_flash_init() references

On 09/08/17 13:15, Sakari Ailus wrote: > The v4l2_flash_init() keeps a reference to the ops struct but not to the > config struct (nor anything it contains). Document this. > > Signed-off-by: Sakari Ailus <sakari.ai...@linux.intel.com> > Acked-by: Pavel Machek <pa...

Re: [PATCH v2 2/3] v4l2-flash-led-class: Create separate sub-devices for indicators

1/3 patch. After updating that you can add my: Acked-by: Hans Verkuil <hans.verk...@cisco.com> Regards, Hans > --- > drivers/leds/leds-aat1290.c| 4 +- > drivers/leds/leds-max77693.c | 4 +- > drivers/media/v4l2-core/v4l2

Re: [PATCH v2 1/3] staging: greybus: light: fix memory leak in v4l2 register

lash); > - goto out_free; > - } > + _flash_ops, _cfg); > + if (IS_ERR_OR_NULL(light->v4l2_flash)) Just IS_ERR since v4l2_flash_init() never returns NULL. > + return PTR_ERR(light->v4l2_flash); > > -

Re: [PATCH 14/14] [media] fix warning on v4l2_subdev_call() result interpreted as bool

On 14/07/17 11:36, Arnd Bergmann wrote: > v4l2_subdev_call is a macro returning whatever the callback return > type is, usually 'int'. With gcc-7 and ccache, this can lead to > many wanings like: > > media/platform/pxa_camera.c: In function 'pxa_mbus_build_fmts_xlate': >

  1   2   3   >