Re: [PATCH] staging: greybus: operation: add generic timeout support

On Mon, Jan 23, 2017 at 01:04:14PM +0100, Johan Hovold wrote: > Add a struct timer_list to struct gb_operation and use that to implement > generic operation timeouts. > > This simplifies the synchronous operation handling somewhat while also > providing a generic timeout mechani

Re: [PATCH] staging: greybus: operation: add generic timeout support

On Tue, Feb 07, 2017 at 02:31:04PM +, Bryan O'Donoghue wrote: > On 07/02/17 14:19, Johan Hovold wrote: > > On Mon, Jan 23, 2017 at 01:04:14PM +0100, Johan Hovold wrote: > >> Add a struct timer_list to struct gb_operation and use that to implement > >>

Re: [PATCH] staging: greybus: operation: add generic timeout support

On Wed, Feb 08, 2017 at 11:43:57AM +, Bryan O'Donoghue wrote: > On 08/02/17 09:43, Johan Hovold wrote: > > On Tue, Feb 07, 2017 at 02:31:04PM +, Bryan O'Donoghue wrote: > >> On 07/02/17 14:19, Johan Hovold wrote: > >>> On Mon, Jan 23, 2017 at 01:04:

Re: [PATCH] staging: greybus: operation: add generic timeout support

On Wed, Feb 08, 2017 at 02:05:15PM +, Bryan O'Donoghue wrote: > On 08/02/17 11:55, Johan Hovold wrote: > > On Wed, Feb 08, 2017 at 11:43:57AM +, Bryan O'Donoghue wrote: > >> On 08/02/17 09:43, Johan Hovold wrote: > >>> On Tue, Feb 07, 2017 at 02:31:04PM

[PATCH] staging: greybus: operation: add generic timeout support

Add a struct timer_list to struct gb_operation and use that to implement generic operation timeouts. This simplifies the synchronous operation handling somewhat while also providing a generic timeout mechanism that drivers can use for asynchronous operations. Signed-off-by: Johan Hovold <

Re: [PATCH v3 2/4] staging: greybus: operation: add private data with get/set accessors

et/set s/operation.h/struct gb_operation/ > methods to access that pointer. > > Signed-off-by: Bryan O'Donoghue <pure.lo...@nexus-software.ie> Reviewed-by: Johan Hovold <jo...@kernel.org> > --- > drivers/staging/greybus/operation.h | 13 + > 1 file changed, 13

Re: [PATCH v3 3/4] staging: greybus: loopback: convert loopback to use generic async operations

On Wed, Jan 04, 2017 at 12:11:20AM +, Bryan O'Donoghue wrote: > Loopback has its own internal method for tracking and timing out > asynchronous operations however previous patches make it possible to use > functionality provided by operation.c to do this instead. Using the code in >

Re: [PATCH v3 4/4] staging: greybus: loopback: convert to use msecs internally

microseconds-to-milliseconds. The new minimum timeout will be one > millisecond as opposed to one jiffy. You also reduced the maximum in a similar way (1 ms <= 1 jiffie). You could mention that here as well. > Signed-off-by: Bryan O'Donoghue <pure.lo...@nexus-software.ie> Re

Re: [PATCH v3 1/4] staging: greybus: operation: add generic asynchronous timeout operation support

On Wed, Jan 04, 2017 at 12:11:18AM +, Bryan O'Donoghue wrote: > This patch adds a generic mechanism for handling timeouts of asynchronous > operations to operation.c. After doing a gb_operation_request_send() it > schedules a delayed worker. When the delayed worker's timer expires the > worker

Re: [PATCH v2] staging: greybus: timesync: validate platform state callback

_work+0x3b0/0x3b0 > kthread+0xc4/0xe0 > ? kthread_park+0xb0/0xb0 > ret_from_fork+0x22/0x30 > > So, fix that by adding checks before use the callback. > > Fixes: 970dc85bd95d ("greybus: timesync: Add timesync core driver") > Cc: <sta...@vger.kernel.org>

Re: [PATCH] staging: greybus: operation: add generic timeout support

On Mon, Jan 23, 2017 at 03:39:43PM +, Bryan O'Donoghue wrote: > On 23/01/17 15:13, Johan Hovold wrote: > > On Mon, Jan 23, 2017 at 02:32:48PM +, Bryan O'Donoghue wrote: > >> On 23/01/17 12:04, Johan Hovold wrote: > >> > >>> +static void

Re: [PATCH] staging: greybus: timesync: validate platform state callback

On Mon, Jan 23, 2017 at 02:22:44PM +, Rui Miguel Silva wrote: > When tearingdown timesync, and not in arche platform, the state platform > callback is not initialized. That will trigger the following NULL > dereferencing. > CallTrace: > > ? gb_timesync_platform_unlock_bus+0x11/0x20 [greybus]

Re: [PATCH] staging: greybus: operation: add generic timeout support

On Mon, Jan 23, 2017 at 02:32:48PM +, Bryan O'Donoghue wrote: > On 23/01/17 12:04, Johan Hovold wrote: > > > +static void gb_operation_timeout(unsigned long arg) > > +{ > > + struct gb_operation *operation = (void *)arg; > > + > > + if (gb_operat

[PATCH] staging: greybus: loopback: fix broken udelay

oseconds") Signed-off-by: Johan Hovold <jo...@kernel.org> --- drivers/staging/greybus/loopback.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/staging/greybus/loopback.c b/drivers/staging/greybus/loopback.c index 6c2a41c638c3..a8329daf1e57 100644 --

[PATCH] staging: greybus: uart: fix TIOCGSERIAL flags

This driver does not have a low-latency mode and should not report anything else. Also drop the skip-test flag which isn't used either. Signed-off-by: Johan Hovold <jo...@kernel.org> --- drivers/staging/greybus/uart.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/g

Re: [PATCH] greybus: Fix coding stye error

On Fri, Jan 27, 2017 at 03:29:30PM +0300, Dan Carpenter wrote: > On Fri, Jan 27, 2017 at 11:11:21AM +0100, mrossibel...@gmail.com wrote: > > From: Maxime Rossi Bellom > > > > Split line before funtion argument. > > > > Error was reported by checkpatch.pl as > > WARNING:

Re: [PATCH] greybus: Fix coding stye error

On Fri, Jan 27, 2017 at 03:47:21PM +0300, Dan Carpenter wrote: > The name sucks is what I'm saying. Please fix it eventually. I disagree. The name uses a common prefix that reflects the object it is working on. This should not be changed. As it is currently named, the function is also

Re: [PATCH] greybus: Fix coding stye error

On Fri, Jan 27, 2017 at 04:24:47PM +0300, Dan Carpenter wrote: > On Fri, Jan 27, 2017 at 02:08:06PM +0100, Johan Hovold wrote: > > On Fri, Jan 27, 2017 at 03:47:21PM +0300, Dan Carpenter wrote: > > > The name sucks is what I'm saying. Please fix it eventually. > > >

Re: [PATCH] staging: greybus: arpc.h: remove duplicate line.

On Fri, Feb 10, 2017 at 11:16:37PM -0500, Nathan Howard wrote: > Fix checkpatch.pl issue of the form: > "CHECK: Please don't use multiple blank lines". Don't take checkpatch too seriously. Using double blank lines as a separator is perfectly fine. Thanks, Johan

Re: [PATCH 2/2] staging: greybus: fix symbolic permission coding style issues

On Thu, Feb 09, 2017 at 05:30:12PM +0100, Gioh Kim wrote: > Fix "Octal permissions are preffered than symbolic ones" issues. > > Signed-off-by: Gioh Kim <gi-oh@profitbricks.com> Acked-by: Johan Hovold <jo...@kernel.org> __

Re: [PATCH 1/2] staging: greybus: fix "line over 80 characters" coding style issues

On Thu, Feb 09, 2017 at 05:30:11PM +0100, Gioh Kim wrote: > This patch fixes only obvious lines. > There are still more issues. Please make this commit message self-contained (e.g. mention what you are doing here and why). > Signed-off-by: Gioh Kim > --- >

Re: [PATCH] staging: greybus: uart: fix uninitialized newline.flow_control

On Thu, Feb 09, 2017 at 01:01:18PM +, Colin King wrote: > From: Colin Ian King > > Currently newline.flow_control is uninitialized, so it can contain > any garbage from the stack. I believe it should be initialized with > GB_SERIAL_AUTO_RTSCTS_EN enabled if the

Re: [PATCH] staging: greybus: operation: add generic timeout support

On Mon, Jan 23, 2017 at 05:50:23PM +0100, Johan Hovold wrote: > On Mon, Jan 23, 2017 at 03:39:43PM +, Bryan O'Donoghue wrote: > > Have you run this through loopback without any # of in-flight operations > > constrained ? > > No, not yet as that would require also your ch

Re: [greybus-dev] [PATCH] staging: greybus: loopback_test: use octal permissions instead of symbolic

On Wed, Jan 18, 2017 at 06:21:23PM -0800, Igor Pylypiv wrote: > checkpatch.pl warning: > Symbolic permissions are not preferred. Consider using octal permissions. > > Signed-off-by: Igor Pylypiv <igor.pyly...@gmail.com> Reviewed-by: Johan Hovold

Re: [PATCH v3 0/4] drivers/staging/greybus: add async operations

On Thu, Jan 19, 2017 at 10:07:42AM +0100, Greg Kroah-Hartman wrote: > On Wed, Jan 04, 2017 at 12:11:17AM +, Bryan O'Donoghue wrote: > > V3: > > Picard: "Let's make sure history never forgets the name ... Enterprise." > > Drop gb_operation_cancel_async. The sync version works just as well -

Re: [PATCH] staging: greybus: fix checkpatch unsigned warnings

yer <christian.bewerme...@fau.de> > Signed-off-by: Roman Sommer <roman.som...@fau.de> Reviewed-by: Johan Hovold <jo...@kernel.org> Thanks, Johan ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: fixed style in greybus/tools/loopback_test.c

On Mon, Feb 27, 2017 at 12:52:17PM -0800, Jonathan Bowie wrote: > fixed a simple style issue in tools/loopback_test.c Please mention what kind of style issue you're addressing. Also make sure your patch summary (Subject) is on the format staging: greybus: loopback_test: add missing

Re: [PATCH] staging: greybus: fix block comment

rything > + * and then enter FW flashing state > + */ > poweroff_seq(pdev); > ret = fw_flashing_seq(pdev); > } else { Patch looks fine, but note that someone just sent a patch for this second chunk the other d

Re: [PATCH v4] staging: greybus: Fix a commit coding style issue.

On Mon, Oct 03, 2016 at 04:21:09PM +0530, Sidhant Gupta wrote: > Fixes a comment coding style warning by adding 2 blank lines. Issue > found by checkpatch. > > Signed-off-by: Sidhant Gupta <guptasidhant...@gmail.com> Acked-by: Johan Hovold <jo...@kerne

[PATCH 1/2] staging: greybus: uart: fix invalid user-pointer check

Drop invalid user-pointer check from TIOCGSERIAL handler. A NULL-pointer can be valid in user space and copy_to_user() takes care of sanity checking. Signed-off-by: Johan Hovold <jo...@kernel.org> --- drivers/staging/greybus/uart.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/d

[PATCH 2/2] staging: greybus: use get_icount tty operation

Use the tty get_icount operation instead of implementing TIOCGICOUNT directly. Signed-off-by: Johan Hovold <jo...@kernel.org> --- drivers/staging/greybus/uart.c | 31 --- 1 file changed, 12 insertions(+), 19 deletions(-) diff --git a/drivers/staging/greybus/ua

Re: [PATCH] staging: greybus: es2: fix arpc request size

checks. Reviewed-by: Johan Hovold <jo...@kernel.org> Thanks, Johan ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [patch] greybus: fix a leak on error in gb_module_create()

On Fri, Oct 14, 2016 at 10:18:21PM +0300, Dan Carpenter wrote: > We should release ->interfaces[0] as well. Indeed. Thanks for the fix. > Fixes: b15d97d77017 ("greybus: core: add module abstraction") > Signed-off-by: Dan Carpenter <dan.carpen...@oracle.com>

Re: [PATCH] Staging: greybus: uart: constify tty_port_operations structure

82142016 drivers/staging/greybus/uart.o > > File size after: >text data bss dec hex filename >7710 448 5682142016 drivers/staging/greybus/uart.o > > Signed-off-by: Bhumika Goyal <bhumi...@gmail.com> Acked-by: Johan Hovold

Re: [PATCH v2] RFC: staging: greybus: shape up greybus GPIO

c: Axel Haslam <haslam_a...@projectara.com> > Cc: Johan Hovold <jo...@hovoldconsulting.com> > Cc: Sandeep Patil <patil_sand...@projectara.com> > Cc: Rui Miguel Silva <rui.si...@linaro.org> > Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> > Signed-off-

Re: [PATCH 1/2] Staging: greybus: gpio: Use gbphy_dev->dev instead of bundle->dev

On Wed, Oct 12, 2016 at 08:02:21AM +0530, Viresh Kumar wrote: > Some of the print messages are using the incorrect device pointer, fix > them. > > Signed-off-by: Viresh Kumar <viresh.ku...@linaro.org> Acked-by: Johan Hovold <jo...@kernel.org> _

Re: [PATCH 2/2] Staging: greybus: uart: Use gbphy_dev->dev instead of bundle->dev

On Wed, Oct 12, 2016 at 08:02:22AM +0530, Viresh Kumar wrote: > Some of the print messages are using the incorrect device pointer, fix > them. > > Signed-off-by: Viresh Kumar <viresh.ku...@linaro.org> Acked-by: Johan Hovold <jo...@kernel.org> _

Re: [PATCH -next] greybus: es2: fix error return code in ap_probe()

a9db ("greybus: es2: Add a new bulk in endpoint for > APBridgeA RPC") > Signed-off-by: Wei Yongjun <weiyongj...@huawei.com> Thanks for the fix. This was clearly broken and would have led to havoc on disconnect as well. Reviewed-by:

Re: [PATCH 0/6] drivers/staging/greybus: add async operations

On Tue, Nov 22, 2016 at 01:18:21PM +, Bryan O'Donoghue wrote: > On Tue, 2016-11-22 at 13:17 +0100, Johan Hovold wrote: > > [ Resend with Greg's address fixed. ] > > > > On Mon, Nov 21, 2016 at 05:22:13PM +, Bryan O'Donoghue wrote: > > > > > > McC

Re: [PATCH 0/6] drivers/staging/greybus: add async operations

[ Resend with Greg's address fixed. ] On Mon, Nov 21, 2016 at 05:22:13PM +, Bryan O'Donoghue wrote: > McCOY: You've got him, Jim! You've got him where you want him. Hey, I ended up watching this one last night. Funny coincidence. > This patchset adds async operations to greybus-core. Rather

Re: [PATCH 0/6] drivers/staging/greybus: add async operations

On Mon, Nov 21, 2016 at 05:22:13PM +, Bryan O'Donoghue wrote: > McCOY: You've got him, Jim! You've got him where you want him. Hey, I ended up watching this one last night. Funny coincidence. > This patchset adds async operations to greybus-core. Rather than have > different drivers do

Re: [PATCHv2]: staging: Greybus: Remove unnecessary braces for single statement block

On Fri, Nov 18, 2016 at 07:04:20PM +0530, Rahul Krishnan wrote: > This patch fixes the following checkpath.pl warning > WARNING: braces {} are not necessary for single statement blocks > > Fixed indentation error, noted by Dan Carpenter > > Signed-off-by: Rahul Krishnan

[PATCH] staging: greybus: arche-platform: fix device reference leak

Signed-off-by: Johan Hovold <jo...@kernel.org> --- drivers/staging/greybus/arche-platform.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/greybus/arche-platform.c b/drivers/staging/greybus/arche-platform.c index 34307ac3f255..d33d6fe078ad 100644 --- a/drivers/stagi

Re: Greybus Future

On Mon, Oct 31, 2016 at 08:50:53AM -0500, Alex Elder wrote: > I'm proposing below a few things, which I'll implement this week > unless I hear people express strong opposition (or clearly better > suggestions). If you have comments, please say something. > > Git repositories. Public git

Re: [PATCH] staging: greybus: es2: Use kmemdup instead of kmalloc and memcpy

[+CC: staging list ] On Sun, Oct 16, 2016 at 02:19:48PM +0530, sayli karnik wrote: > This patch replaces kmalloc and memcpy with kmemdup for duplication of > memory. > > Signed-off-by: sayli karnik <karniksayli1...@gmail.com> Acked-by: Johan Hovold <jo...@kernel.org>

Re: [PATCH] staging: greybus: audio: Rename cport with intf_id

On Sun, Oct 16, 2016 at 03:29:14PM +0530, Pankaj Bharadiya wrote: > gb_audio_manager_module_descriptor's cport field is actually used to > manage and pass interface id to user space. > > Thus rename gb_audio_manager_module_descriptor's 'cport' field and > few other things to avoid confusion.

Re: [PATCH -next] greybus: arche-platform: Add missing of_node_put() in arche_platform_change_state()

> > This is detected by Coccinelle semantic patch. > > Signed-off-by: Wei Yongjun <weiyongj...@huawei.com> This code is going away eventually, but still. Acked-by: Johan Hovold <jo...@kernel.org> Thanks, Johan ___ devel m

Re: [PATCH v2] staging: greybus: audio_module: remove redundant OOM message

On Tue, Dec 06, 2016 at 07:39:36PM +0530, Srikant Ritolia wrote: > All kmalloc-based functions print enough information on failure > > Signed-off-by: Srikant Ritolia <s.rito...@samsung.com> Acked-by: Johan Hovold <jo...@kernel.org> > --- > Changes in v2: > - Ad

Re: [PATCH] greybus: checkpatch: Change parameter type unsigned to unsigned int

On Tue, Jan 10, 2017 at 05:21:24PM +0100, Roman Sommer wrote: > From: Christian Bewermeyer > > Note that this patch does not fix all checkpatch warnings for > gpio.c Fair enough, but you are fixing all of these new "unsigned int" warnings in that driver, right? How

Re: [PATCH v3] staging: greybus: checkpatch: Change parameter type unsigned to unsigned int

t; Next time I suggest you drop "checkpatch: " from your subject since that's not a (greybus) component. You could have rephrased the summary as "fix checkpatch unsigned warnings" or similar instead. Reviewed-by: Johan Hovold <jo...@kernel.org> Thanks, Johan _

Re: [PATCH v2] greybus: checkpatch: Change parameter type unsigned to unsigned int

On Wed, Jan 11, 2017 at 02:48:38PM +0100, Roman Sommer wrote: > Note that this patch does not fix all checkpatch warnings for the > affected files. > > Signed-off-by: Christian Bewermeyer > Signed-off-by: Roman Sommer You forgot to fix the

Re: [PATCH RESEND] Staging: greybus: style fix, permissions as octal

On Thu, Jan 12, 2017 at 05:59:40PM +1300, Derek Robson wrote: > Changed permissions to be in octal style. > Found by checkpatch. > > Signed-off-by: Derek Robson <robso...@gmail.com> > --- Acked-by: Johan Hovold <jo...@kernel.org> Next time, please include a module

Re: [PATCH v3] staging: greybus: checkpatch: Change parameter type unsigned to unsigned int

On Thu, Jan 12, 2017 at 10:05:10AM +0300, Dan Carpenter wrote: > On Wed, Jan 11, 2017 at 04:00:35PM +0100, Roman Sommer wrote: > > Note that this patch does not fix all checkpatch warnings for the > > affected files. > > > > A lot of ways that display git commits put the changelog and the

Re: [PATCH] staging: greybus: loopback_test: fix checkpatch bad function definition error

On Wed, Jan 11, 2017 at 01:29:36AM +, Abdul Rauf wrote: > Fix the following Errors: > Bad function definition - void abort() should probably be void abort(void) > > Signed-off-by: Abdul Rauf <abdulraufmuja...@gmail.com> Acked-by: Johan Hovold

Re: [PATCH] staging: greybus: don't print on ENOMEM

g. use "staging: greybus: audio_module: remove redundant OOM message"). Fix that up and you can add my Acked-by: Johan Hovold <jo...@kernel.org> Thanks, Johan ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdri

Re: [PATCH v2 1/5] staging: greybus: operation: add asynchronous gb_operation_cancel

On Tue, Jan 03, 2017 at 09:23:29AM +, Bryan O'Donoghue wrote: > On 02/01/17 16:16, Johan Hovold wrote: > > On Tue, Dec 27, 2016 at 01:01:35PM +, Bryan O'Donoghue wrote: > >> Later patches don't want or need to serialize the cancellation of an > >>

Re: [PATCH v2] staging: greybus: svc_watchdog: Fix spaces on a single definition statement

zi.eman...@gmail.com> Acked-by: Johan Hovold <jo...@kernel.org> > --- > v2: Add svc_watchdog to the subject line > > drivers/staging/greybus/svc_watchdog.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/greybus/svc_watc

Re: [PATCH v2] staging: greybus: svc_watchdog: replace printk() with pr_err()

o printk(KERN_ERR ." > > Signed-off-by: Emmanuil Chatzipetru <chatzi.eman...@gmail.com> > --- > v2: Add svc_watchdog to the subject line Thanks for the update. Acked-by: Johan Hovold <jo...@kernel.org> > drivers/staging/greybus/svc_watchdog.c | 2 +- > 1 file ch

Re: [PATCH] staging: greybus: add host device function pointer checks

arious other function pointers. Yeah, I allowed for some inconsistency here given that these callbacks are mandatory on our current platform. No harm in checking this way though (well, at least as long as we remember to set the pointers). > Signed-off-by: Jason Hrycay <jhry...@gmail.com> A

Re: [PATCH v2 1/2] staging: greybus: loopback: use gb_loopback_async_wait_all don't spin

bad manners. Use the existing gb_loopback_async_wait_all() function to gate > continuing when the send_count == iteration_max and go to sleep until > there's something worthwhile to-do. > > Signed-off-by: Bryan O'Donoghue <pure.lo...@nexus-software.ie> Reviewed-by:

Re: [PATCH 02/14] staging: greybus: arche-apb-ctrl: Fix open parenthesis alignment.

On Tue, Jan 03, 2017 at 03:33:04PM +0100, chatzi.eman...@gmail.com wrote: > From: Emmanuil Chatzipetru > > Fix coding style issue caught by checkpatch.pl related to the following > warning: > - CHECK: Alignment should match open parenthesis This is not even a

Re: [PATCH 10/14] staging: greybus: connection: Remove multiple blank lines

On Tue, Jan 03, 2017 at 03:33:12PM +0100, chatzi.eman...@gmail.com wrote: > From: Emmanuil Chatzipetru > > Fix coding style issue caught by checkpatch.pl related to the following > warning: > - CHECK: Please don't use multiple blank lines Again not a warning, and

Re: [PATCH 01/14] staging: greybus: arche-apb-ctrl: Remove multiple blank lines.

On Tue, Jan 03, 2017 at 03:33:03PM +0100, chatzi.eman...@gmail.com wrote: > From: Emmanuil Chatzipetru > > Fix coding style issue caught by checkpatch.pl related to the following > warning: > - CHECK: Please don't use multiple blank lines > > Signed-off-by:

Re: [PATCH 08/14] staging: greybus: camera: Fix NULL comparison to preferred style.

On Tue, Jan 03, 2017 at 03:33:10PM +0100, chatzi.eman...@gmail.com wrote: > From: Emmanuil Chatzipetru > > Fix coding style issue caught by checkpatch.pl related to the following > warning: > - CHECK: Comparison to NULL could be written "!token" Again, not a

Re: [PATCH 14/14] staging: greybus: core: Fix NULL comparison to preferred style.

On Tue, Jan 03, 2017 at 03:33:16PM +0100, chatzi.eman...@gmail.com wrote: > From: Emmanuil Chatzipetru > > Fix coding style issue caught by checkpatch.pl related to the following > warning: > - CHECK: Comparison to NULL could be written "!id" Current code is

Re: [PATCH 03/14] staging: greybus: arche-platform: Fix typo in the comments.

Chatzipetru <chatzi.eman...@gmail.com> Acked-by: Johan Hovold <jo...@kernel.org> ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 06/14] staging: greybus: bootrom: Fix line over 80 characters warning.

gt; Signed-off-by: Emmanuil Chatzipetru <chatzi.eman...@gmail.com> Acked-by: Johan Hovold <jo...@kernel.org> ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 1/2] staging: greybus: audio_topology: Fix spaces between operator and string

zi.eman...@gmail.com> Acked-by: Johan Hovold <jo...@kernel.org> > --- > drivers/staging/greybus/audio_topology.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/greybus/audio_topology.c > b/drivers/staging/greybus/audio_topology.c &g

Re: [PATCH 2/2] staging: greybus: log: Fix line over 80 characters.

On Wed, Jan 04, 2017 at 03:07:32PM +0100, Emmanuil Chatzipetru wrote: > Fix coding style issue caught by checkpatch.pl related to the following > warning: > - CHECK: WARNING: line over 80 characters > > Signed-off-by: Emmanuil Chatzipetru > --- >

Re: [PATCH v2] staging: greybus: log: Fix line over 80 characters.

On Wed, Jan 04, 2017 at 04:14:45PM +0100, Emmanuil Chatzipetru wrote: > Fix coding style issue caught by checkpatch.pl related to the following > warning: > - CHECK: WARNING: line over 80 characters This commit message should be expanded to explain how this is done (e.g. "by dropping a

Re: [PATCH v3 1/2] staging: greybus: audio_topology: Fix spaces between operator and string

zi.eman...@gmail.com> Acked-by: Johan Hovold <jo...@kernel.org> > --- > drivers/staging/greybus/audio_topology.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/greybus/audio_topology.c > b/drivers/staging/greybus/audio_topology.c &g

Re: [PATCH v3 2/2] staging: greybus: log: Fix line over 80 characters.

> specifier > in dev_err(); to "%zu" instead of "%d", in order to silence the warnings of > the > compiler. > > Also, while at it, drop the redundant cast in the comparison as well to > maintain > consistency. > > Signed-off-by: Emmanuil Chat

Re: [PATCH 1/2] staging: greybus: loopback: fix gb_pm_runtime_get_sync error handling

On Sun, Jan 08, 2017 at 03:27:18PM +, Bryan O'Donoghue wrote: > commit e854ff58ed70 ("greybus: loopback: add runtime pm support") > introduces pm runtime support to the loopback code. If a > gb_pm_runtime_get_sync() fails, currently we immediately return from the > loopback thread. > >

Re: [PATCH 1/2] staging: greybus: loopback: fix gb_pm_runtime_get_sync error handling

On Mon, Jan 09, 2017 at 11:29:50AM +, Bryan O'Donoghue wrote: > On January 9, 2017 11:19:09 AM GMT+00:00, Johan Hovold <jo...@kernel.org> > wrote: > >On Sun, Jan 08, 2017 at 03:27:18PM +, Bryan O'Donoghue wrote: > >> commit e854ff58ed70 ("greybus:

Re: [PATCH v2] Staging: greybus: style fix, permissions as octal

On Fri, Jan 06, 2017 at 08:43:57PM +1300, Derek Robson wrote: > Changed permissions to be in octal style. > Found by checkpatch. > > Signed-off-by: Derek Robson > --- > > This version of patch also make the file type part of the mask with the > permissions, as per

Re: [PATCH 2/2] staging: greybus: loopback: fix oops on rmmod gb_loopback

On Sun, Jan 08, 2017 at 03:27:19PM +, Bryan O'Donoghue wrote: > Doing an rmmod gb_loopback will cause an oops with the following backtrace. > > Call Trace: > debugfs_remove+0xaf/0x180 > gb_loopback_disconnect+0x36/0x160 [gb_loopback] > greybus_remove+0x87/0x1a0 [greybus] >

Re: [PATCH v2 2/2] staging: greybus: loopback_test: Fix race preventing test completion

Adding Axel on CC. On Thu, Dec 22, 2016 at 12:37:29AM +, Bryan O'Donoghue wrote: > commit 9250c0ee2626 ("greybus: Loopback_test: use poll instead of > inotify") changes the flow of determining when to break out of a loop > polling for loopback test completion. > > The clause is_complete()

Re: [PATCH v2 1/5] staging: greybus: operation: add asynchronous gb_operation_cancel

On Tue, Dec 27, 2016 at 01:01:35PM +, Bryan O'Donoghue wrote: > Later patches don't want or need to serialize the cancellation of an > operation. This patch adds gb_operation_cancel_async() as a simple subset > of the existing gb_operation_cancel() sans the synchronous wait on the >

Re: [PATCH] staging: greybus: add host device function pointer checks

On Tue, Jan 03, 2017 at 01:46:09PM -0600, Jason Hrycay wrote: > On Mon, Jan 02, 2017 at 02:54:37PM +0100, Johan Hovold wrote: > > On Tue, Dec 20, 2016 at 02:49:27PM -0600, Jason Hrycay wrote: > > > Add sanity checks for cport_quiesce and cport_clear before invoking t

Re: [PATCH] staging: greybus: remove timesync protocol support

; a great place to start from. > > Signed-off-by: Greg Kroah-Hartman <gre...@linuxfoundation.org> Reviewed-by: Johan Hovold <jo...@kernel.org> > Note, there are some remants in the arche-platform driver, but that's > probably next on the chopping block, so I didn't unwind

Re: [PATCH] MAINTAINERS: add greybus subsystem mailing list

igned-off-by: Greg Kroah-Hartman <gre...@linuxfoundation.org> Acked-by: Johan Hovold <jo...@kernel.org> ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [greybus-dev] [PATCH 1/2] staging: greybus: loopback: use gb_loopback_async_wait_all don't spin

On Tue, Dec 20, 2016 at 01:12:08AM +, Bryan O'Donoghue wrote: > Currently the greybus-loopback thread logic spins around waiting for > send_count == iteration_max which on real hardware doesn't make a > difference to us but in simulation is excruciatingly slow, anti-social and > bad manners.

Re: [PATCH] staging: greybus: Fix static array of pointers declaration as static const.

On Wed, Dec 21, 2016 at 04:38:26PM +0100, Emmanuil Chatzipetru wrote: > Fix coding style issue caught by checkpatch.pl related to the following > warning: > - "WARNING: char * array declaration might be better as static const" > > Signed-off-by: Emmanuil Chatzipetru

Re: [PATCH v4] staging: greybus: loop_backtest: fixed consistent spacing style issue

On Wed, Mar 01, 2017 at 02:30:02AM -0800, Jonathan Bowie wrote: > Fixed incosistent spacing around arithmetic operator. > > v2 > -fixed subject, added changelog > v3 > -CC:ed linux-next incorrectly, added proper summary > v4 > -CC:ed staging mailing list, moved changelog to summary body As I

Re: [PATCH v5] staging: greybus: loop_backtest: fixed consistent spacing style issue

ly, added proper summary > v4 > -CC:ed correct mailing list, moved changelog to summary body > v5 > -correctly placed changelog All good now! Thanks for sticking to it (and nevermind the changelog typo ;) ). Reviewed-by: Johan Hovold <jo...@kernel.org> Johan __

Re: [PATCH] staging: greybus: loopback: Enclose multiple macro statements in do-while loop

On Tue, Jul 18, 2017 at 04:26:40PM +0530, kart...@techveda.org wrote: > From: Karthik Tummala > > Enclosed multiple macro statements in a do - while loop as per kernel > coding standard, pointed by checkpatch.

Re: [PATCH 1/2] staging: greybus: light: Don't leak memory for no gain

[ +CC: Rui and Greg ] On Tue, Jul 18, 2017 at 09:41:06PM +0300, Sakari Ailus wrote: > Memory for struct v4l2_flash_config is allocated in > gb_lights_light_v4l2_register() for no gain and yet the allocated memory is > leaked; the struct isn't used outside the function. Fix this. > >

Re: [PATCH] Staging: greybus: Match alignment with open parenthesis.

On Sun, Jul 23, 2017 at 03:10:53PM +0300, Dan Carpenter wrote: > On Sun, Jul 23, 2017 at 10:47:43AM +0200, Johan Hovold wrote: > > On Sun, Jul 23, 2017 at 02:09:57PM +0530, Shreeya Patel wrote: > > > Alignment should match with open parenthesis. > > > This f

Re: [PATCH] Staging: greybus: Match alignment with open parenthesis.

On Sun, Jul 23, 2017 at 02:09:57PM +0530, Shreeya Patel wrote: > Alignment should match with open parenthesis. > This fixes the coding style issue. No, it need not. This is a choice left up to the author, even if checkpatch happens to complain about it with the --strict option. Thanks, Johan

Re: [PATCH] Staging: greybus: Match alignment with open parenthesis.

On Thu, Jul 27, 2017 at 09:49:32PM -0700, Greg KH wrote: > On Mon, Jul 24, 2017 at 10:08:37AM +0300, Dan Carpenter wrote: > > I don't understand why greybus has to be special instead of the same as > > everything else. Who cares about this stuff really? Just do whatever > > is easiest and most

Re: [greybus-dev] [PATCH v2] staging: greybus: loopback_test: fix comment style issues

vices. If > > + /* > > +* Cancel any running tests on enabled devices. If > > * stop_all option is given, stop test on all devices. > > */ > > for (i = 0; i < t->device_count; i++) > > Reviewed-by: Viresh Kumar <viresh.ku...@linaro.org> Acked-by: Johan Hovold <jo...@kernel.org> Thanks, Johan ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [greybus-dev] [PATCH] staging: greybus: loopback_test: fix comment style issue

On Fri, Jun 30, 2017 at 09:43:44PM +0500, Aleksey Rybalkin wrote: > According to checkpatch warning, block comments should align the * on > each line. How about "fixing" the other multi-line comment ("Cancel any running..."), which isn't on the normal kernel format either while at it? /*

Re: [greybus-dev] [PATCH v2] staging: greybus: loopback_test: fix comment style issues

On Wed, Jul 05, 2017 at 10:01:09AM +0500, Aleksey Rybalkin wrote: > On Tue, Jul 04, 2017 at 10:28:10AM +0200, Johan Hovold wrote: > > On Tue, Jul 04, 2017 at 11:47:51AM +0530, Viresh Kumar wrote: > > > + Greg > > > > > > On 03-07-17, 23:27, Aleksey Rybalkin wr

[PATCH] staging: gdm724x: gdm_mux: fix use-after-free on module unload

: Won Kang <wkan...@gmail.com> Signed-off-by: Johan Hovold <jo...@kernel.org> --- drivers/staging/gdm724x/gdm_mux.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/gdm724x/gdm_mux.c b/drivers/staging/gdm724x/gdm_mux.c index 400969170d1c..f03e4

Re: [PATCH 10/11] greybus: usb: constify hc_driver structures

-off-by: Julia Lawall <julia.law...@lip6.fr> Acked-by: Johan Hovold <jo...@kernel.org> Thanks, Johan ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 2/2] staging: greybus: enable compile testing of arche driver

Add Arche platform-driver config option and allow the driver to be compile tested also without the usb3613 driver. Signed-off-by: Johan Hovold <jo...@kernel.org> --- drivers/staging/greybus/Kconfig | 10 ++ drivers/staging/greybus/Makefile | 2 +- drivers/s

[PATCH 1/2] staging: greybus: arche: remove timesync remains

Remove the remaining timesync bits that were left in the arche platform driver and which prevented the driver from being compiled. Fixes: bdfb95c4baab ("staging: greybus: remove timesync protocol support") Signed-off-by: Johan Hovold <jo...@kernel.org> --- drivers/staging/g

[PATCH 0/2] staging: greybus: fix arche driver compilation

breakage. Johan Johan Hovold (2): staging: greybus: arche: remove timesync remains staging: greybus: enable compile testing of arche driver drivers/staging/greybus/Kconfig | 10 +++ drivers/staging/greybus/Makefile | 2 +- drivers/staging/greybus/arche-apb-ctrl.c | 11

Re: [PATCH 1/2] staging: greybus: arche: remove timesync remains

On Mon, May 15, 2017 at 04:17:55PM +0100, Bryan O'Donoghue wrote: > On 15/05/17 15:26, Johan Hovold wrote: > > Remove the remaining timesync bits that were left in the arche platform > > driver and which prevented the driver from being compiled. > > > > Fixes: bdfb

Re: [PATCH 2/2] staging: greybus: enable compile testing of arche driver

On Mon, May 15, 2017 at 09:49:51AM -0700, Randy Dunlap wrote: > On 05/15/17 07:26, Johan Hovold wrote: > > Add Arche platform-driver config option and allow the driver to be > > compile tested also without the usb3613 driver. > > > > Signed-off-by: Joh

  1   2   3   >