Rewrite macro function with the GNU extension typeof
to remove a possible side-effects of MACRO argument reuse "x".
- Problem could rise if arguments have different types
and different use though.
Signed-off-by: Jules Irenge
---
v1 - had no full commit log message, with changes no
Rewrite macro function with GNU extension __auto_type
to remove issue detected by checkpatch tool.
CHECK: MACRO argument reuse - possible side-effects?
Signed-off-by: Jules Irenge
---
drivers/staging/rts5208/rtsx_chip.h | 92 +
1 file changed, 55 insertions(+), 37
Add gcc extension __force and __le32 cast to fix warning issued by Sparse
tool."warning: cast to restricted __le32"
Signed-off-by: Jules Irenge
---
drivers/staging/wfx/debug.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wfx/debug.c b/drivers/s
On Sat, 9 Nov 2019, Al Viro wrote:
> On Fri, Nov 08, 2019 at 11:38:37PM +0000, Jules Irenge wrote:
> > Add gcc extension __force and __le32 cast to fix warning issued by Sparse
> > tool."warning: cast to restricted __le32"
> >
> > Signed-off-by: Jules Ire
Wrap characters to fix line of over 80 characters.
Issue detected by Checkpatch tool
Signed-off-by: Jules Irenge
---
v2 includes more of this type of errors
drivers/staging/wfx/bus_sdio.c | 4 +-
drivers/staging/wfx/data_rx.c| 6 +-
drivers/staging/wfx/data_rx.h| 3 +-
drivers
Replace u32 by __le32 to fix warning of cast from restricted __le32.
Issue detected by sparse tool.
Signed-off-by: Jules Irenge
---
v1 uses casting to fix the warnings
v2 replace the declaration type of the variables
drivers/staging/wfx/hif_api_mib.h | 48 +++
1
Replace uint8_t to u8, uint16_t to u16, uint32_t to u32
int8_t to s8,int16_t to s16 and int32_t to s32
As per recommendation of checkpatch tool.
Signed-off-by: Jules Irenge
---
Changes
v1 had a spacing error
v2 fixes the error and includes all the changes related to this patch in
the driver
Align to fix multiple warnings of line over 80 characters.
Issue detected by checkpatch tool.
Signed-off-by: Jules Irenge
---
drivers/staging/wfx/bus_sdio.c | 4 +-
drivers/staging/wfx/data_rx.h| 3 +-
drivers/staging/wfx/debug.c | 15 ++--
drivers/staging/wfx/fwio.c | 65
On Mon, 4 Nov 2019, Greg KH wrote:
> On Mon, Nov 04, 2019 at 04:33:31PM +0000, Jules Irenge wrote:
> > Rewrite macro function with the GNU extension typeof
> > to remove a possible side-effects of MACRO argument reuse "x".
> > - Problem could rise if
On Mon, 4 Nov 2019, Ian Abbott wrote:
> On 04/11/2019 16:33, Jules Irenge wrote:
> > Rewrite macro function with the GNU extension typeof
> > to remove a possible side-effects of MACRO argument reuse "x".
> > - Problem could rise if arguments have different typ
On Mon, 4 Nov 2019, Greg KH wrote:
> On Mon, Nov 04, 2019 at 04:44:00PM +0000, Jules Irenge wrote:
> > Rewrite macro function with GNU extension __auto_type
> > to remove issue detected by checkpatch tool.
> > CHECK: MACRO argument reuse - possible side-effects?
> >
On Wed, 16 Oct 2019, Julia Lawall wrote:
> > #ifndef VCHI_BULK_GRANULARITY
> > # if __VCCOREVER__ >= 0x0400
> > -# define VCHI_BULK_GRANULARITY 32 // Allows for the need to do cache
> > cleans
> > +# define VCHI_BULK_GRANULARITY 32 // Allows for the need of cache cleans
> > #
Remove unnecessary void pointers.
Issue detected and solved by coccinelle tool.
semantic use
@@expression e ;@@
-(void*)(e)
+e
Signed-off-by: Jules Irenge
---
drivers/staging/wfx/bh.c | 2 +-
drivers/staging/wfx/bus_sdio.c | 2 +-
drivers/staging/wfx/bus_spi.c | 2 +-
drivers/staging/wfx
Remove unnecessary void pointers.
Issue detected and solved by coccinelle tool.
semantic use
@@expression e ;@@
-(void*)(e)
+e
Signed-off-by: Jules Irenge
---
drivers/staging/wfx/bh.c | 2 +-
drivers/staging/wfx/bus_sdio.c | 2 +-
drivers/staging/wfx/bus_spi.c | 2 +-
drivers/staging/wfx
On Mon, 21 Oct 2019, Jerome Pouiller wrote:
> On Monday 21 October 2019 14:24:49 CEST Jules Irenge wrote:
> > Remove unnecessary void pointers.
> > Issue detected and solved by coccinelle tool.
> > semantic use
> > @@expression e ;@@
> > -(void*)(e)
> >
Fix "alignment should mactch open parenthesis" check.
Issue detected by checkpatch tool
Signed-off-by: Jules Irenge
---
drivers/staging/media/meson/vdec/codec_mpeg12.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/meson/vdec/codec_mpeg12.c
Add space betwen operator to fix check warning.
Issue detected by checkpatch tool.
Signed-off-by: Jules Irenge
---
drivers/staging/vc04_services/interface/vchi/vchi_cfg.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/vc04_services/interface/vchi
Fix line over 80 characters checks warning.
Issue detected by checkpatch tool.
Signed-off-by: Jules Irenge
---
.../vc04_services/interface/vchi/vchi_cfg.h | 150 ++
1 file changed, 88 insertions(+), 62 deletions(-)
diff --git a/drivers/staging/vc04_services/interface/vchi
Fix warning of lines over 80 characters.
Issue detected by checkpatch tool.
Signed-off-by: Jules Irenge
---
drivers/staging/wfx/bh.c | 17 --
drivers/staging/wfx/bus.h | 6 +-
drivers/staging/wfx/bus_sdio.c | 3 +-
drivers/staging/wfx/bus_spi.c | 9 ++-
drivers/staging
Fix warnings of no space is necessary after a cast.
Issue detected by checkpatch tool.
Signed-off-by: Jules Irenge
---
drivers/staging/wfx/bh.c | 8
drivers/staging/wfx/bus_sdio.c | 6 +++---
drivers/staging/wfx/bus_spi.c | 2 +-
drivers/staging/wfx/data_rx.c | 8
Correct misspelled words: retrieved and auxiliary.
Issue detected by checkpatch tool.
Signed-off-by: Jules Irenge
---
drivers/staging/wfx/data_tx.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/wfx/data_tx.c b/drivers/staging/wfx/data_tx.c
index
Fix checkpatch warnings.
Jules Irenge (5):
staging: wfx: fix warnings of no space is necessary
staging: wfx: fix warning of line over 80 characters
staging: wfx: fix warnings of logical continuation
staging: wfx: correct misspelled words
staging: wfx: fix warnings of alignment should
: Fix warnings of alignment should match open parenthesis.
Issue detected by checkpatch tool.
Signed-off-by: Jules Irenge
---
drivers/staging/wfx/data_rx.c | 2 +-
drivers/staging/wfx/data_tx.c | 2 +-
drivers/staging/wfx/debug.c | 14 --
3 files changed, 10 insertions(+), 8
Fix check warnings of logical continuations
should be on the previous line.
Issue detected by checkpatch tool.
Signed-off-by: Jules Irenge
---
drivers/staging/wfx/data_rx.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/wfx/data_rx.c b/drivers
On Sat, 19 Oct 2019, Dan Carpenter wrote:
> On Sat, Oct 19, 2019 at 03:07:15PM +0100, Jules Irenge wrote:
> > diff --git a/drivers/staging/wfx/bh.c b/drivers/staging/wfx/bh.c
> > index 3355183fc86c..573216b08042 100644
> > --- a/drivers/staging/wfx/bh.c
> > +++
Add comment to spinlock declaration to fix warning issued by checkpatch.pl
"CHECK: spinlock_t definition without comment".
Signed-off-by: Jules Irenge
---
drivers/staging/rtl8712/drv_types.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8712/d
On Mon, 7 Oct 2019, Julia Lawall wrote:
On Mon, 7 Oct 2019, Jules Irenge wrote:
Add comment to spinlock declaration to fix warning issued by checkpatch.pl
"CHECK: spinlock_t definition without comment".
Since it is not apparent from the shown code, it would be helpful to
des
Correct misspelled word " check
issued by checkpatch.pl tool:
"CHECK: serveral may be misspelled - perhaps several?".
Signed-off-by: Jules Irenge
---
drivers/staging/qlge/qlge_dbg.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/qlge/qlge_
Correct misspelled word " check
issued by checkpatch.pl tool:
"CHECK: serveral may be misspelled - perhaps several?".
Signed-off-by: Jules Irenge
---
drivers/staging/qlge/qlge_dbg.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/qlge/qlge_
Fix "alignment should mactch open parenthesis" checks
issued by checkpatch.pl tool:
"CHECK: Alignment should match open parenthesis".
Signed-off-by: Jules Irenge
---
drivers/staging/qlge/qlge_dbg.c | 127
1 file changed, 64 insertions(+), 6
Fix multiple assignments warning " check
issued by checkpatch.pl tool:
"CHECK: multiple assignments should be avoided".
Signed-off-by: Jules Irenge
---
drivers/staging/qlge/qlge_dbg.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/ql
Fix "alignment should mactch open parenthesis" checks
issued by checkpatch.pl tool:
"CHECK: Alignment should match open parenthesis".
Signed-off-by: Jules Irenge
---
drivers/staging/qlge/qlge_dbg.c | 127
1 file changed, 64 insertions(+), 6
Fix multiple assignments warning " check
issued by checkpatch.pl tool:
"CHECK: multiple assignments should be avoided".
Signed-off-by: Jules Irenge
---
drivers/staging/qlge/qlge_dbg.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/ql
Fix a misspelling of "several" detected by checkpatch
Signed-off-by: Jules Irenge
---
drivers/staging/qlge/qlge_dbg.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/qlge/qlge_dbg.c b/drivers/staging/qlge/qlge_dbg.c
index 5599525a19d5..28fc974ce
Capitalize RANGE_mA to fix camelcase check warning.
Issue reported by checkpatch.pl
Signed-off-by: Jules Irenge
---
drivers/staging/comedi/comedidev.h | 2 +-
drivers/staging/comedi/drivers/adv_pci1724.c | 4 ++--
drivers/staging/comedi/drivers/dac02.c | 2 +-
drivers/staging
Capitalize unit_ma to fix camelcase check warning.
Signed-off-by: Jules Irenge
---
drivers/staging/comedi/comedi.h| 4 ++--
drivers/staging/comedi/comedidev.h | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/comedi/comedi.h b/drivers/staging/comedi
Capitalize RANGE_mA to fix camelcase check warning.
Issue reported by checkpatch.pl
Signed-off-by: Jules Irenge
---
drivers/staging/comedi/comedidev.h | 2 +-
drivers/staging/comedi/drivers/adv_pci1724.c | 4 ++--
drivers/staging/comedi/drivers/dac02.c | 2 +-
drivers/staging
Capitalize RANGE_mA to fix camelcase check warning.
Issue reported by checkpatch.pl
Signed-off-by: Jules Irenge
---
drivers/staging/comedi/comedidev.h | 2 +-
drivers/staging/comedi/drivers/adv_pci1724.c | 4 ++--
drivers/staging/comedi/drivers/dac02.c | 2 +-
drivers/staging
Fix warning of logical continuations should be on the previous line.
Issue detected by checkpatch tool.
Signed-off-by: Jules Irenge
---
.../bcm2835-camera/bcm2835-camera.c | 41 ---
1 file changed, 17 insertions(+), 24 deletions(-)
diff --git a/drivers/staging
Fix warning of lines should not end with open parenthesis.
Issue detected by checkpatch tool.
Signed-off-by: Jules Irenge
---
.../bcm2835-camera/bcm2835-camera.c | 38 ---
1 file changed, 16 insertions(+), 22 deletions(-)
diff --git a/drivers/staging/vc04_services
On Fri, 11 Oct 2019, Julia Lawall wrote:
On Fri, 11 Oct 2019, Jules Irenge wrote:
Fix warning of logical continuations should be on the previous line.
Issue detected by checkpatch tool.
There seem to be several changes mixed together in this patch.
Don't have a subject line
Place the AND logical operator at the end of the previous line;
to fix warning of "Logical continuations should be on the previous line".
Issue detected by checkpatch tool.
Signed-off-by: Jules Irenge
---
drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c | 4 ++--
1 file
vchiq_mmal_component_enable to vm_cmpnt_enable
Signed-off-by: Jules Irenge
---
.../bcm2835-camera/bcm2835-camera.c | 191 --
1 file changed, 89 insertions(+), 102 deletions(-)
diff --git a/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c
b/drivers/staging
On Sun, 13 Oct 2019, Julia Lawall wrote:
>
>
> On Sun, 13 Oct 2019, Jules Irenge wrote:
>
> > Fix lines ending with open parenthesis. Issue detected by checkpatch tool.
> > In the process, change driver functions name in the multiple files from:
> >
Fix lines ending with open parenthesis. Issue detected by checkpatch tool.
Within "controls.c", "mmal-vchiq.c" and" mmal-vchiq.h" files.
Signed-off-by: Jules Irenge
---
.../vc04_services/bcm2835-camera/controls.c | 208 +-
.../vc04_services/bcm
45 matches
Mail list logo
