Re: [PATCH 3/7] staging: ft1000: space required after that ','

2014-10-19 Thread Konrad Zapalowicz
On 10/19, Chen Weixiang wrote: Remove code style error from ft1000/ft1000-usb/ft1000_debug.c: ERROR: space required after that ',' (ctx:VxV) Signed-off-by: Chen Weixiang weixiang.c...@gmail.com --- drivers/staging/ft1000/ft1000-usb/ft1000_debug.c | 18 +- 1 file changed, 9

Re: [PATCH] Remove outdated TODO tasks

2014-10-31 Thread Konrad Zapalowicz
On 10/31, Mariusz Gorski wrote: Remove Lindent and checkpatch.pl tasks from TODO file as the first one is obsolete and the other one is already done. Great however your topic is ill formated. It should contain the staging: panel: prefix. thanks, konrad Signed-off-by: Mariusz Gorski

Re: [PATCH v2] staging: panel: Remove outdated TODO tasks

2014-10-31 Thread Konrad Zapalowicz
On 10/31, Mariusz Gorski wrote: Remove Lindent and checkpatch.pl tasks from TODO file as the first one is obsolete and the other one is already done. v2: Fixed commit summary This is something that should not be a part of the commit message. This kind of extra information shall be placed

Re: [PATCH v3] staging: panel: Remove outdated TODO tasks

2014-10-31 Thread Konrad Zapalowicz
On 10/31, Mariusz Gorski wrote: Remove Lindent and checkpatch.pl tasks from TODO file as the first one is obsolete and the other one is already done. Signed-off-by: Mariusz Gorski marius.gor...@gmail.com --- v3: Fixed commit summary Great. Thanks. regards, konrad

Re: [PATCH] staging: media: lirc: lirc_zilog.c: adjust debug messages

2014-11-02 Thread Konrad Zapalowicz
On 11/01, Aya Mahfouz wrote: This patch removes one debug message and replaces a dev_err call by pr_err. Usually you would like to send this as two separate patches because replacing a debug message is way different than removing some code. It should look like: PATCH 0/2 staging:

[PATCH 0/5] serial: jsm: Add support for the Digi Classic adapters

2014-11-02 Thread Konrad Zapalowicz
it is highly recommended that someone tests it. Konrad Zapalowicz (5): drivers: serial: jsm: Add Classic board UART structure drivers: serial: jsm: Add the Classic board implementation drivers: serial: jsm: Enable support for Digi Classic adapters staging: dgnc: Remove driver in favor

[PATCH 1/5] drivers: serial: jsm: Add Classic board UART structure

2014-11-02 Thread Konrad Zapalowicz
This commit adds the UART structure for the Digi Classic cards. This code comes from the staging/dgnc driver. Signed-off-by: Konrad Zapalowicz bergo.tor...@gmail.com --- drivers/tty/serial/jsm/jsm.h | 59 +++- 1 file changed, 58 insertions(+), 1 deletion

[PATCH 2/5] drivers: serial: jsm: Add the Classic board implementation

2014-11-02 Thread Konrad Zapalowicz
with the inspiration coming from the diff between staging/dgnc and serial/jsm as well as the LKML history for the jsm_neo.c The code compiles now and has no sparse and checkpatch errors or warnings. Signed-off-by: Konrad Zapalowicz bergo.tor...@gmail.com --- drivers/tty/serial/jsm/Makefile | 2 +- drivers/tty

[PATCH 3/5] drivers: serial: jsm: Enable support for Digi Classic adapters

2014-11-02 Thread Konrad Zapalowicz
This commit enables support for the Digi Classic adapters line in the jsm driver. This means changes in: - device probing code - device cleanup code - driver description (Kconfig) The init/cleanup code is based on the staging/dgnc driver. Signed-off-by: Konrad Zapalowicz

[PATCH 5/5] drivers: serial: jsm: Remove FSF address from the file documentation/header

2014-11-02 Thread Konrad Zapalowicz
This commit removes the address of Free Software Foundation from each of the mentioned file in order to suppress the checkpatch warning. Signed-off-by: Konrad Zapalowicz bergo.tor...@gmail.com --- drivers/tty/serial/jsm/jsm.h| 5 - drivers/tty/serial/jsm/jsm_cls.c| 5

[PATCH 2/5] drivers: serial: jsm: Add the Classic board implementation

2014-11-03 Thread Konrad Zapalowicz
with the inspiration coming from the diff between staging/dgnc and serial/jsm as well as the LKML history for the jsm_neo.c The code compiles now and has no sparse and checkpatch errors or warnings. Signed-off-by: Konrad Zapalowicz bergo.tor...@gmail.com --- drivers/tty/serial/jsm/Makefile | 2 +- drivers/tty

[PATCH 1/5] drivers: serial: jsm: Add Classic board UART structure

2014-11-03 Thread Konrad Zapalowicz
This commit adds the UART structure for the Digi Classic cards. This code comes from the staging/dgnc driver. Signed-off-by: Konrad Zapalowicz bergo.tor...@gmail.com --- drivers/tty/serial/jsm/jsm.h | 59 +++- 1 file changed, 58 insertions(+), 1 deletion

[PATCH v2 0/4] serial: jsm: Add support for the Digi Classic adapters

2014-11-06 Thread Konrad Zapalowicz
of the series. since Greg has already merged the patch 01 from the first series this time it is not attached therefore this series has only 4 patches in it (previously was 5). Konrad Zapalowicz (4): drivers: serial: jsm: Add the Classic

[PATCH v2 2/4] drivers: serial: jsm: Enable support for Digi Classic adapters

2014-11-06 Thread Konrad Zapalowicz
This commit enables support for the Digi Classic adapters line in the jsm driver. This means changes in: - device probing code - device cleanup code - driver description (Kconfig) The init/cleanup code is based on the staging/dgnc driver. Signed-off-by: Konrad Zapalowicz

[PATCH v2 1/4] drivers: serial: jsm: Add the Classic board implementation

2014-11-06 Thread Konrad Zapalowicz
with the inspiration coming from the diff between staging/dgnc and serial/jsm as well as the LKML history for the jsm_neo.c The code compiles now and has no sparse and checkpatch errors or warnings. Signed-off-by: Konrad Zapalowicz bergo.tor...@gmail.com --- drivers/tty/serial/jsm/Makefile | 2 +- drivers/tty

[PATCH v2 4/4] drivers: serial: jsm: Remove FSF address from the file documentation/header

2014-11-06 Thread Konrad Zapalowicz
This commit removes the address of Free Software Foundation from each of the mentioned file in order to suppress the checkpatch warning. Signed-off-by: Konrad Zapalowicz bergo.tor...@gmail.com --- drivers/tty/serial/jsm/jsm.h| 5 - drivers/tty/serial/jsm/jsm_cls.c| 5

Re: [PATCH 2/5] drivers: serial: jsm: Add the Classic board implementation

2014-11-06 Thread Konrad Zapalowicz
On 11/06, Greg KH wrote: On Mon, Nov 03, 2014 at 07:52:38PM +0100, Konrad Zapalowicz wrote: This commit adds the Digi Classic board implementation to the staging/jsm driver. The code here is taken from the staging/dgnc driver and modified to match the serial/jsm state. This work

Re: [PATCH v2 3/4] staging: dgnc: Remove driver in favor of serial/jsm driver

2014-11-06 Thread Konrad Zapalowicz
On 11/06, Greg KH wrote: On Fri, Nov 07, 2014 at 12:05:34AM +0100, Konrad Zapalowicz wrote: This commit removes the staging/dgnc driver in favor of the serial/jsm driver. This is because the serial/jsm driver now supports all of the hardware that has been supported by the staging/dgnc

Re: [PATCH] staging: media: bcm2048: fix coding style error

2014-11-15 Thread Konrad Zapalowicz
On 11/15, Christian Resell wrote: Simple style fix (checkpatch.pl: space prohibited before that ','). For the eudyptula challenge (http://eudyptula-challenge.org/). Nice, however we do not need the information about the 'eudyptula challenge' in the commit message. If you want to include extra

Re: [PATCH] staging: media: bcm2048: fix coding style error

2014-11-15 Thread Konrad Zapalowicz
On 11/15, Pavel Machek wrote: On Sat 2014-11-15 21:12:18, Konrad Zapalowicz wrote: On 11/15, Christian Resell wrote: Simple style fix (checkpatch.pl: space prohibited before that ','). For the eudyptula challenge (http://eudyptula-challenge.org/). Nice, however we do not need

Re: [PATCH] drivers:staging:octeon:ethernet-rx.c: Added blank line after declarations

2014-11-30 Thread Konrad Zapalowicz
On 11/30, Anjana Sasindran wrote: This patch fixes the checkpatch.pl warnings: Your subject line is somewhat broken as it does not really follow the canonical patch format. You can read up on it here (section 15) https://www.kernel.org/doc/Documentation/SubmittingPatches and this is the short

Re: rtl8821ae: patch for mac80211 regulatory changes

2014-07-15 Thread Konrad Zapalowicz
On 07/15, Kevin Folz wrote: Hello, I noticed you two have worked on the staging rtl8821ae driver. I wrote to the mailing list last month, but have yet to receive a response. http://permalink.gmane.org/gmane.linux.kernel.wireless.general/125235 I downloaded the latest

[PATCH 0/2] staging: rtl8188eu: fix checkpatch errors.

2014-04-18 Thread Konrad Zapalowicz
From: Konrad M Zapalowicz bergo.tor...@gmail.com This patch removes the following checkpatch errors: rtl8188eu/core/rtw_p2p.c: - 1508: ERROR: code indent should use tabs where possible - 1509: ERROR: code indent should use tabs where possible - 1510: ERROR: code indent should use

[PATCH 1/2] staging: rtl8188eu: fix spaces instead of tabs for rtw_p2p.c

2014-04-18 Thread Konrad Zapalowicz
where possible Signed-off-by: Konrad Zapalowicz bergo.torino at gmail.com --- drivers/staging/rtl8188eu/core/rtw_p2p.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_p2p.c b/drivers/staging/rtl8188eu/core/rtw_p2p.c index 9425c49

[PATCH 2/2] staging: rtl8188eu: fix spaces instead of tabs for rtw_recv.c

2014-04-18 Thread Konrad Zapalowicz
From: Konrad M Zapalowicz bergo.tor...@gmail.com This commit fixes the following checkpatch errors: rtl8188eu/core/rtw_recv.c - 1874: ERROR: code indent should use tabs where possible Signed-off-by: Konrad Zapalowicz bergo.torino at gmail.com --- drivers/staging/rtl8188eu/core/rtw_recv.c

[PATCH v2 0/2] staging: rtl8188eu: fix checkpatch errors.

2014-04-19 Thread Konrad Zapalowicz
This patch removes the following checkpatch errors: rtl8188eu/core/rtw_p2p.c: - 1508: ERROR: code indent should use tabs where possible - 1509: ERROR: code indent should use tabs where possible - 1510: ERROR: code indent should use tabs where possible rtl8188eu/core/rtw_recv.c -

[PATCH v2 1/2] staging: rtl8188eu: fix spaces instead of tabs for rtw_p2p.c

2014-04-19 Thread Konrad Zapalowicz
This commit fixes the following checkpatch errors: rtl8188eu/core/rtw_p2p.c - 1508: ERROR: code indent should use tabs where possible - 1509: ERROR: code indent should use tabs where possible - 1510: ERROR: code indent should use tabs where possible Signed-off-by: Konrad Zapalowicz

[PATCH v2 2/2] staging: rtl8188eu: fix spaces instead of tabs for rtw_recv.c

2014-04-19 Thread Konrad Zapalowicz
This commit fixes the following checkpatch errors: rtl8188eu/core/rtw_recv.c - 1874: ERROR: code indent should use tabs where possible Signed-off-by: Konrad Zapalowicz bergo.tor...@gmail.com --- drivers/staging/rtl8188eu/core/rtw_recv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH] staging/rtl8723au fix sparse warning in os_initfs.c

2014-05-15 Thread Konrad Zapalowicz
This commit fixes the following sparse warning: drivers/staging/rtl8723au/os_dep/os_intfs.c: - 322:14: warning: restricted __be16 degrades to integer Signed-off-by: Konrad Zapalowicz bergo.tor...@gmail.com --- drivers/staging/rtl8723au/os_dep/os_intfs.c | 2 +- 1 file changed, 1 insertion

[PATCH 0/2] staging: rtl8821ae: fix sparse warnings in sw.c

2014-05-17 Thread Konrad Zapalowicz
This patch set fixes sparse warnings in sw.c file of rtl8821ae driver. In particular it deals with: 1) double const definition 2) missing 'static' for a few local symbols Konrad Zapalowicz (2): staging: rtl8821ae: fix double const in sw.c staging: rtl8821ae: fix not declared symbols

[PATCH 1/2] staging: rtl8821ae: fix double const in sw.c

2014-05-17 Thread Konrad Zapalowicz
This commit fixes the following sparse warning: drivers/staging/rtl8821ae/rtl8821ae/sw.c: - 449:14: warning: duplicate const Signed-off-by: Konrad Zapalowicz bergo.tor...@gmail.com --- drivers/staging/rtl8821ae/rtl8821ae/sw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 2/2] staging: rtl8821ae: fix not declared symbols should be static in sw.c

2014-05-17 Thread Konrad Zapalowicz
of this symbols are local, that is there are no references to them in the other files from this driver. Signed-off-by: Konrad Zapalowicz bergo.tor...@gmail.com --- drivers/staging/rtl8821ae/rtl8821ae/sw.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging

[PATCH 0/7] staging: rtl8821ae: fix warnings in btcoexist module

2014-05-24 Thread Konrad Zapalowicz
This commit fixes the sparse warnings and compiler warnings in drivers/staging/rtl8821ae/btcoexist module of rtl8821ae driver. The most of the changes adds 'static' for local symbols plus the -Wunused-function compiler warnings are fixed too. Konrad Zapalowicz (7): staging: rtl8821ae: add

[PATCH 3/7] staging: rtl8821ae: add static for local symbols in halbtc8723b2ant.c

2014-05-24 Thread Konrad Zapalowicz
halbtc8723b2ant_run_coexist_mechanism halbtc8723b2ant_wifioff_hwcfg Signed-off-by: Konrad Zapalowicz bergo.tor...@gmail.com --- .../staging/rtl8821ae/btcoexist/halbtc8723b2ant.c | 141 +++-- 1 file changed, 75 insertions(+), 66 deletions(-) diff --git a/drivers/staging

[PATCH 7/7] staging: rtl8821ae: add static for local symbols in rtl_btc.c

2014-05-24 Thread Konrad Zapalowicz
This commit fixes the sparse warning: warning: symbol 'X' was not declared. Should it be static? Where the X is one of the following rtl_btc_operation Signed-off-by: Konrad Zapalowicz bergo.tor...@gmail.com --- drivers/staging/rtl8821ae/btcoexist/rtl_btc.c | 2 +- 1 file changed, 1

[PATCH 6/7] staging: rtl8821ae: deal with unused functions in halbtcoutsrc.c

2014-05-24 Thread Konrad Zapalowicz
This commit fixes the compiler -Wunused-function warning. Several functions had to be removed. Removed symbols halbtc_is_hw_mailbox_exist halbtc_set_macreg halbtc_get_macreg halbtc_under_ips Signed-off-by: Konrad Zapalowicz bergo.tor...@gmail.com --- drivers/staging/rtl8821ae

[PATCH 4/7] staging: rtl8821ae: deal with unused functions in halbtc8723b2ant.c

2014-05-24 Thread Konrad Zapalowicz
halbtc8723b2ant_monitor_bt_enable_disable halbtc8723b2ant_set_bt_auto_report halbtc8723b2ant_bt_auto_report Disabled symbols halbtc8723b2ant_adc_backoff halbtc8723b2ant_set_adc_backoff Signed-off-by: Konrad Zapalowicz bergo.tor...@gmail.com --- drivers/staging/rtl8821ae

[PATCH 1/7] staging: rtl8821ae: add static for local symbols in halbtc8723b1ant.c

2014-05-24 Thread Konrad Zapalowicz
halbtc8723b2ant_run_coexist_mechanism halbtc8723b2ant_wifioff_hwcfg Signed-off-by: Konrad Zapalowicz bergo.tor...@gmail.com --- .../staging/rtl8821ae/btcoexist/halbtc8723b1ant.c | 203 +++-- 1 file changed, 109 insertions(+), 94 deletions(-) diff --git a/drivers/staging

[PATCH 2/7] staging: rtl8821ae: deal with unused functions in halbtc8723b1ant.c

2014-05-24 Thread Konrad Zapalowicz
Conditionally compiled symbols: halbtc8723b1ant_bt_auto_report halbtc8723b1ant_set_bt_auto_report halbtc8723b1ant_action_wifi_only halbtc8723b1ant_monitor_bt_enable_disable Signed-off-by: Konrad Zapalowicz bergo.tor...@gmail.com --- .../staging/rtl8821ae/btcoexist/halbtc8723b1ant.c | 235

[PATCH 5/7] staging: rtl8821ae: add static for local symbols in halbtcoutsrc.c

2014-05-24 Thread Konrad Zapalowicz
halbtc_display_dbg_msg halbtc_under_ips Signed-off-by: Konrad Zapalowicz bergo.tor...@gmail.com --- drivers/staging/rtl8821ae/btcoexist/halbtcoutsrc.c | 93 +++--- 1 file changed, 48 insertions(+), 45 deletions(-) diff --git a/drivers/staging/rtl8821ae/btcoexist/halbtcoutsrc.c b/drivers

[PATCH] staging: vt6655: refactor iwctl_giwaplist() to avoid -Wframe-larger-than warn.

2014-05-26 Thread Konrad Zapalowicz
. Luckily, this is no issue. Signed-off-by: Konrad Zapalowicz bergo.tor...@gmail.com --- drivers/staging/vt6655/iwctl.c | 79 +- 1 file changed, 55 insertions(+), 24 deletions(-) diff --git a/drivers/staging/vt6655/iwctl.c b/drivers/staging/vt6655/iwctl.c index

[PATCH v2] staging: vt6655: refactor iwctl_giwaplist() to avoid -Wframe-larger-than warn.

2014-05-27 Thread Konrad Zapalowicz
. Luckily, this is no issue. Signed-off-by: Konrad Zapalowicz bergo.tor...@gmail.com --- v2: - fix after the review: - remove unnecessary comments - remove unnecessary assignment - fix pointer arithmetic drivers/staging/vt6655/iwctl.c | 72 -- 1

[PATCH 1/7] staging: dgnc: Fix externs should be avoided in the .c files

2014-08-06 Thread Konrad Zapalowicz
to be put first. Signed-off-by: Konrad Zapalowicz bergo.tor...@gmail.com --- drivers/staging/dgnc/dgnc_driver.c | 84 ++ 1 file changed, 39 insertions(+), 45 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_driver.c b/drivers/staging/dgnc/dgnc_driver.c index

[PATCH 3/7] staging: dgnc: Fix frame size is larger than 1024B

2014-08-06 Thread Konrad Zapalowicz
-off-by: Konrad Zapalowicz bergo.tor...@gmail.com --- drivers/staging/dgnc/dgnc_tty.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c index c712b43..2dc78f7 100644 --- a/drivers/staging/dgnc

[PATCH 0/7] staging: dgnc: cleanup of the dgnc_driver.c

2014-08-06 Thread Konrad Zapalowicz
(except on line over 80 chars warnings). Because the TODO file for this driver was not valid the bullet list in it has been updated with the current status. The update is based on what I have found in the driver devel mailing list archives for this driver. Konrad Zapalowicz (7): staging: dgnc: Fix

[PATCH 2/7] staging: dgnc: Fix no spaces before tabs checkpath warning

2014-08-06 Thread Konrad Zapalowicz
This commit corrects the 'no space before tabs' checkpath warning. Signed-off-by: Konrad Zapalowicz bergo.tor...@gmail.com --- drivers/staging/dgnc/dgnc_driver.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_driver.c b/drivers/staging/dgnc

[PATCH 4/7] staging: dgnc: Remove unnecessary functions from dgnc_driver.c

2014-08-06 Thread Konrad Zapalowicz
This commit slightly cleans up the dgnc_driver.c file. The changes include removing one-line proxy functions as they were not needed. Additionaly the pci 'remove' function is deleted because it was no need for it. Signed-off-by: Konrad Zapalowicz bergo.tor...@gmail.com --- drivers/staging/dgnc

[PATCH 5/7] staging: dgnc: Move utility functions out of dgnc_driver.c

2014-08-06 Thread Konrad Zapalowicz
This commit moves the utility functions out of dgnc_driver.c file and puts them in the new dgnc_utils.{c,h} files. The accompanying changes adjust the existing code to work with this design. Signed-off-by: Konrad Zapalowicz bergo.tor...@gmail.com --- drivers/staging/dgnc/Makefile | 3

[PATCH 6/7] staging: dgnc: Siplify the dgnc_start function

2014-08-06 Thread Konrad Zapalowicz
This commit slightly simplifies the sgnc_start() function by rearranging it. As a result the indentation level is reduced. This is not the functional change. Signed-off-by: Konrad Zapalowicz bergo.tor...@gmail.com --- drivers/staging/dgnc/dgnc_driver.c | 93

[PATCH 7/7] staging: dgnc: Update the TODO file

2014-08-06 Thread Konrad Zapalowicz
It turned out that the TODO file contained the invalid information as some of the work has already been done. This commit updates it with the current status of what is left to be done. Signed-off-by: Konrad Zapalowicz bergo.tor...@gmail.com --- drivers/staging/dgnc/TODO | 5 - 1 file changed

[PATCH v2 6/7] staging: dgnc: Siplify the dgnc_start function

2014-08-06 Thread Konrad Zapalowicz
This commit slightly simplifies the sgnc_start() function by rearranging it. As a result the indentation level is reduced. This is not the functional change. Signed-off-by: Konrad Zapalowicz bergo.tor...@gmail.com --- drivers/staging/dgnc/dgnc_driver.c | 93

[PATCH v3 6/7] staging: dgnc: Siplify the dgnc_start function

2014-08-06 Thread Konrad Zapalowicz
This commit slightly simplifies the sgnc_start() function by rearranging it. As a result the indentation level is reduced. This is not the functional change. Signed-off-by: Konrad Zapalowicz bergo.tor...@gmail.com --- drivers/staging/dgnc/dgnc_driver.c | 91

[PATCH 1/5] staging: dgnc: Fix included header from 'asm'

2014-08-06 Thread Konrad Zapalowicz
This commit fixes the checkpatch warning: drivers/staging/dgnc/dgnc_neo.c:37: WARNING: Use #include linux/io.h instead of asm/io.h Signed-off-by: Konrad Zapalowicz bergo.tor...@gmail.com --- drivers/staging/dgnc/dgnc_neo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 0/5] staging: dgnc: Fix checkpath issues in dgnc_neo.c

2014-08-06 Thread Konrad Zapalowicz
This series of patches deals with the checkpatch error and warnings, other than 'line length over 80 chars', found in dgnc_neo.c file. All except of patch 5/5 do not change the behavior. Konrad Zapalowicz (5): staging: dgnc: Fix included header from 'asm' staging: dgnc: Fix missing blank line

[PATCH 2/5] staging: dgnc: Fix missing blank line after declarations

2014-08-06 Thread Konrad Zapalowicz
This commit deals with the checkapth warnings 'missing line after declarations' in the dgnc_neo.c file. Signed-off-by: Konrad Zapalowicz bergo.tor...@gmail.com --- drivers/staging/dgnc/dgnc_neo.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/staging/dgnc/dgnc_neo.c b/drivers

[PATCH 4/5] staging: dgnc: Fix braces {} are not necessary for single statement blocks

2014-08-06 Thread Konrad Zapalowicz
This commit fixes the following checkpath warning in dgnc_neo.c file: 'braces {} are not necessary for single statement blocks' Signed-off-by: Konrad Zapalowicz bergo.tor...@gmail.com --- drivers/staging/dgnc/dgnc_neo.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

[PATCH 5/5] staging: dgnc: Remove 'volatile' modifier where it is not needed

2014-08-06 Thread Konrad Zapalowicz
This commit fixes the checkpath warning about misused 'volatile' modifier. In this case the 'volatile' was not needed as it was used for regular automatic variable. Thos commit removes the 'volatile'. Signed-off-by: Konrad Zapalowicz bergo.tor...@gmail.com --- drivers/staging/dgnc/dgnc_neo.c | 2

[PATCH 3/5] staging: dgnc: Fix that open brace { should be on the previous line

2014-08-06 Thread Konrad Zapalowicz
This commit fixes the following checkpath error in dgnc_neo.c file: 'that open brace { should be on the previous line' Signed-off-by: Konrad Zapalowicz bergo.tor...@gmail.com --- drivers/staging/dgnc/dgnc_neo.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers

[PATCH 0/2] staging: dgnc: Fix checkpatch warnings in dgnc_cls.c

2014-08-06 Thread Konrad Zapalowicz
This series of patches fixes the checkpatch issues found in dgnc_cls.c file: - missing blank line after declaration - void function return statements are not generally useful Konrad Zapalowicz (2): staging: dgnc: Fix missing blank line after declarations staging: dgnc: Remove

[PATCH 1/2] staging: dgnc: Fix missing blank line after declarations

2014-08-06 Thread Konrad Zapalowicz
This commit fixes the missing blank lines after declarations checkpath warnings found in dgnc_cls.c file. Signed-off-by: Konrad Zapalowicz bergo.tor...@gmail.com --- drivers/staging/dgnc/dgnc_cls.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/staging/dgnc/dgnc_cls.c b

[PATCH 2/2] staging: dgnc: Remove unnecessary 'return' statement

2014-08-06 Thread Konrad Zapalowicz
This commit fixes the checkpath warning 'void function return statements are not generally useful' caused by the 'return' at the end of 'void' function. Signed-off-by: Konrad Zapalowicz bergo.tor...@gmail.com --- drivers/staging/dgnc/dgnc_cls.c | 2 -- 1 file changed, 2 deletions(-) diff --git

Re: [PATCH 3/5] staging: dgnc: Fix that open brace { should be on the previous line

2014-08-06 Thread Konrad Zapalowicz
On 08/06, Dan Carpenter wrote: On Wed, Aug 06, 2014 at 09:01:24PM +0200, Konrad Zapalowicz wrote: @@ -1935,8 +1935,8 @@ static void neo_vpd(struct dgnc_board *brd) if (((brd-vpd[0x08] != 0x82) /* long resource name tag */ (brd-vpd[0x10] != 0x82)) /* long

[PATCH] staging: dgnc: Encapsulate global variables in a structure

2014-08-09 Thread Konrad Zapalowicz
This commit binds global variables of dgnc driver in a structure so that it is logically consistent. The structure is accessed via getter function and as a result the externing of globals is removed. The names of the variables are also changed to be more eye friendly. Signed-off-by: Konrad

Re: [PATCH] staging: dgnc: Encapsulate global variables in a structure

2014-08-10 Thread Konrad Zapalowicz
On 08/10, Greg KH wrote: On Sat, Aug 09, 2014 at 08:16:37PM +0200, Konrad Zapalowicz wrote: This commit binds global variables of dgnc driver in a structure so that it is logically consistent. The structure is accessed via getter function and as a result the externing of globals is removed

Re: [PATCH] staging: dgnc: Encapsulate global variables in a structure

2014-08-11 Thread Konrad Zapalowicz
On 08/11, Greg KH wrote: On Sun, Aug 10, 2014 at 09:19:15PM +0200, Konrad Zapalowicz wrote: On 08/10, Greg KH wrote: On Sat, Aug 09, 2014 at 08:16:37PM +0200, Konrad Zapalowicz wrote: This commit binds global variables of dgnc driver in a structure so that it is logically consistent

[PATCH v2 1/7] staging: dgnc: Fix externs should be avoided in the .c files

2014-08-12 Thread Konrad Zapalowicz
to be put first. Signed-off-by: Konrad Zapalowicz bergo.tor...@gmail.com --- v2: - remove the __exit annotation for the cleanup function as it caused the test-bot unhappy. drivers/staging/dgnc/dgnc_driver.c | 84 ++ 1 file changed, 39 insertions(+), 45

Re: [PATCH 1/1] staging: dgnc: brace checkpatch fixes

2014-08-15 Thread Konrad Zapalowicz
On 08/15, Greg KH wrote: On Thu, Aug 14, 2014 at 05:53:10PM -0700, Aaron Brice wrote: Bring braces in line with CodingStyle Signed-off-by: Aaron Brice aa...@tastycactus.com --- Applies to next-20140814 drivers/staging/dgnc/dgnc_neo.c | 10 --

[PATCH 0/4] staging: dgnc: Reduce the number of static variables

2014-08-16 Thread Konrad Zapalowicz
This is the fist stage of removal of unnecessary static, global variables of this driver. Konrad Zapalowicz (4): staging: dgnc: Remove driver-wide state variable staging: dgnc: Remove driver-wide polling counter variable staging: dgnc: Remove not needed dgnc_driver_start variable staging

[PATCH 1/4] staging: dgnc: Remove driver-wide state variable

2014-08-16 Thread Konrad Zapalowicz
This commit removes the driver's global state variable. This is ok because the state was changed only once at the end of init phase thus the future usage of this variable is pointless. Signed-off-by: Konrad Zapalowicz bergo.tor...@gmail.com --- drivers/staging/dgnc/dgnc_driver.c | 19

[PATCH 2/4] staging: dgnc: Remove driver-wide polling counter variable

2014-08-16 Thread Konrad Zapalowicz
The polling counter variable is only exposed via sysfs and has no other purpose. Now, since the polling shall be implemented as a board specific feature rather than being global in the driver this counter is obsolete. Signed-off-by: Konrad Zapalowicz bergo.tor...@gmail.com --- drivers/staging

[PATCH 3/4] staging: dgnc: Remove not needed dgnc_driver_start variable

2014-08-16 Thread Konrad Zapalowicz
The dgnc_driver_start variable purpose was to indicate if the driver 'start' routine has been called. Now, because the 'start' routine can only be called once this variable is not needed thus this commit removes it. Signed-off-by: Konrad Zapalowicz bergo.tor...@gmail.com --- drivers/staging/dgnc

[PATCH 4/4] staging: dgnc: Remove unnecessary dgnc_Major_Control_Registered variable

2014-08-16 Thread Konrad Zapalowicz
,class}_destroy and unregister_chrdev functions may be called with 'invalid' data perfectly fine. This means that this variable is not needed and can safely be removed which is what this commit does. Signed-off-by: Konrad Zapalowicz bergo.tor...@gmail.com --- drivers/staging/dgnc/dgnc_driver.c | 38

Re: staging: dgnc: Fix frame size is larger than 1024B

2014-08-25 Thread Konrad Zapalowicz
On 08/25, Dan Carpenter wrote: Hello Konrad Zapalowicz, The patch ea6e9dea2e72: staging: dgnc: Fix frame size is larger than 1024B from Aug 6, 2014, leads to the following static checker warning: drivers/staging/dgnc/dgnc_tty.c:479 dgnc_sniff_nowait_nolock() error: scheduling

[PATCH] staging: dgnc: Fix sleeping under spinlock bug

2014-08-31 Thread Konrad Zapalowicz
From: Konrad Zapalowicz bergo.torino+ker...@gmail.com This commit changes the memory allocation flags to ATOMIC in order to avoid sleeping in the nowait/nolock code. Signed-off-by: Konrad Zapalowicz bergo.torino+ker...@gmail.com --- drivers/staging/dgnc/dgnc_tty.c | 2 +- 1 file changed, 1

[PATCH 1/2] staging: dgnc: Make the struct dgnc_board possible to use list facility

2014-08-31 Thread Konrad Zapalowicz
This commit adds the struct list_head to the struct dgnc_board so that it is now possible to use it with the Linux list facility. Signed-off-by: Konrad Zapalowicz bergo.torino+ker...@gmail.com --- drivers/staging/dgnc/dgnc_driver.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers

[PATCH 2/2] staging: dgnc: Replace fixed-size board array with list

2014-08-31 Thread Konrad Zapalowicz
Each registered board is asigned a data structure to keep it's state. So far this was implemented using the static array of fixed-size. This commit changes the implementation by replacing the array with dynamic solution based on the kernel list. Signed-off-by: Konrad Zapalowicz bergo.torino+ker

[RFC PATCH 0/2] Replace the static array with the list

2014-08-31 Thread Konrad Zapalowicz
These patches replace the fixed-size, static array used to keep track of board structures with dynamic solution based on the list. I marked this series as RFC since I need input on if this can be done better. Konrad Zapalowicz (2): staging: dgnc: Make the struct dgnc_board possible to use list

Re: [PATCH 2/2] staging: dgnc: Replace fixed-size board array with list

2014-09-01 Thread Konrad Zapalowicz
On 09/01, Dan Carpenter wrote: On Sun, Aug 31, 2014 at 11:23:58PM +0200, Konrad Zapalowicz wrote: Each registered board is asigned a data structure to keep it's state. So far this was implemented using the static array of fixed-size. This commit changes the implementation by replacing

[PATCH v2] staging: dgnc: Replace fixed-size board array with list

2014-09-02 Thread Konrad Zapalowicz
one or two boards the gain here is smaller amount of memory (stack) being used by the driver. Signed-off-by: Konrad Zapalowicz bergo.torino+ker...@gmail.com --- Changelog: v2: - merge previous two patches on this subject into this one - use list_for_each_entry where it makes sense

Re: [PATCH 1/2] staging: dgnc: Make the struct dgnc_board possible to use list facility

2014-09-02 Thread Konrad Zapalowicz
On 09/02, Greg KH wrote: On Sun, Aug 31, 2014 at 11:23:57PM +0200, Konrad Zapalowicz wrote: This commit adds the struct list_head to the struct dgnc_board so that it is now possible to use it with the Linux list facility. Signed-off-by: Konrad Zapalowicz bergo.torino+ker...@gmail.com

Re: [PATCH 1/2] staging: dgnc: Make the struct dgnc_board possible to use list facility

2014-09-06 Thread Konrad Zapalowicz
On 09/02, Greg KH wrote: On Tue, Sep 02, 2014 at 07:55:49PM +0200, Konrad Zapalowicz wrote: On 09/02, Greg KH wrote: On Sun, Aug 31, 2014 at 11:23:57PM +0200, Konrad Zapalowicz wrote: This commit adds the struct list_head to the struct dgnc_board so that it is now possible to use

Re: [Patch v2 0/2] Move Digi Neo card support from dgnc to jsm

2014-09-09 Thread Konrad Zapalowicz
On 09/08, Bill Pemberton wrote: On 09/08/2014 04:17 PM, Greg KH wrote: On Sat, Aug 30, 2014 at 04:35:56PM -0400, wf...@worldbroken.com wrote: From: Bill Pemberton wf...@worldbroken.com The jsm driver (drivers/tty/serial/jsm) already supports the Digi Neo cards that dgnc (staging) supports.

Re: [PATCH v2] staging: lustre: linux-prim.c: fix sparse warnings about static declaration

2014-12-31 Thread Konrad Zapalowicz
On 12/31, Serguey Parkhomovsky wrote: Fixes the following sparse warnings: drivers/staging/lustre/lustre/libcfs/linux/linux-prim.c:198:1: warning: symbol 'libcfs_arch_init' was not declared. Should it be static? drivers/staging/lustre/lustre/libcfs/linux/linux-prim.c:204:1: warning:

Re: [PATCH 1/4] staging: rtl8192u: fix comments

2014-12-31 Thread Konrad Zapalowicz
On 12/31, Lorenzo Stoakes wrote: This patch fixes errors raised by checkpatch.pl relating to use of C99 comments in r8192U_dm.c. Signed-off-by: Lorenzo Stoakes lstoa...@gmail.com --- drivers/staging/rtl8192u/r8192U_dm.c | 841 ++- 1 file changed, 432

Re: [PATCH 1/4] staging: rtl8192u: fix comments

2014-12-31 Thread Konrad Zapalowicz
On 12/31, Lorenzo Stoakes wrote: On 31 December 2014 at 19:00, Konrad Zapalowicz bergo.tor...@gmail.com wrote: You also fix the line length here which shall be the subject of a separate patch as this is not C99 comments related change. Apologies - I missed this, will prepare a v2

Re: [PATCH] Staging: comedi: dmm32at: Fixed a code indent issue

2015-01-06 Thread Konrad Zapalowicz
On 01/06, Sudip Mukherjee wrote: On Tue, Jan 06, 2015 at 10:08:37AM +, Ian Abbott wrote: On 06/01/15 06:02, Sudip Mukherjee wrote: On Mon, Jan 05, 2015 at 08:24:06PM +0100, Piotr Kubus wrote: On Sun, Jan 04, 2015 at 11:31:29PM +0100, Konrad Zapalowicz wrote: On 01/04, Piotr Kubus

Re: [PATCH v8 0/4] FPGA Manager Framework

2015-01-10 Thread Konrad Zapalowicz
On 01/06, at...@opensource.altera.com wrote: From: Alan Tull at...@opensource.altera.com Alan, there is something wrong with your email client configuration and you need to fix. thanks, konrad v8 changes the compatible string for SOCFPGA FPGA managers to be more chip specific.

Re: [PATCH v8 0/4] FPGA Manager Framework

2015-01-11 Thread Konrad Zapalowicz
On 01/11, atull wrote: On Sat, 10 Jan 2015, Konrad Zapalowicz wrote: On 01/06, at...@opensource.altera.com wrote: From: Alan Tull at...@opensource.altera.com Alan, there is something wrong with your email client configuration and you need to fix. thanks, konrad Hi Konrad

Re: [PATCH v8 0/4] FPGA Manager Framework

2015-01-11 Thread Konrad Zapalowicz
On 01/11, Pavel Machek wrote: On Sun 2015-01-11 17:24:26, Konrad Zapalowicz wrote: On 01/11, atull wrote: On Sat, 10 Jan 2015, Konrad Zapalowicz wrote: On 01/06, at...@opensource.altera.com wrote: From: Alan Tull at...@opensource.altera.com Alan, there is something

Re: [PATCH 0/5] *** SUBJECT HERE ***

2015-01-03 Thread Konrad Zapalowicz
On 01/03, Paul Bolle wrote: On Sat, 2015-01-03 at 08:45 -0800, Greg KH wrote: On Sat, Jan 03, 2015 at 02:06:22PM +0530, jitendra kumar khasdev wrote: *** BLURB HERE *** What blurb? What subject? jitendra used git-send-email to send this series. You'd expect git-send-email to die

Re: [PATCH] Staging: comedi: dmm32at: Fixed a code indent issue

2015-01-04 Thread Konrad Zapalowicz
On 01/04, Piotr Kubus wrote: This is a patch to the dmm32at.c file that fixes up a code indent error found by the checkpatch.pl tool. Nice however improve your commit message. The rule is that the lines should wrap at 72nd column except for quoted material such as compiler output, etc... The

Re: [PATCH] staging: wilc1000: fix warning while printing

2015-06-02 Thread Konrad Zapalowicz
On 06/02, Sudip Mukherjee wrote: On Tue, Jun 02, 2015 at 10:29:17AM +0200, Konrad Zapalowicz wrote: On 06/02, Sudip Mukherjee wrote: size_t should print using %zu, but here it was using %d and hence we were getting warning while printing. Signed-off-by: Sudip Mukherjee su

Re: [PATCH] staging: wilc1000: fix warning while printing

2015-06-02 Thread Konrad Zapalowicz
On 06/02, Sudip Mukherjee wrote: size_t should print using %zu, but here it was using %d and hence we were getting warning while printing. Signed-off-by: Sudip Mukherjee su...@vectorindia.org --- I think it will be easy to remove the other warnings if all the typedefs are removed first.

Re: [PATCH] android/ion: fix coding style

2015-06-22 Thread Konrad Zapalowicz
On 06/22, zack.chang wrote: Nice, however there is to little information in the commit message of wha exactly has been fixed. I assume it is 'line over 80 chars', right? and this information shoule be wrien there. thanks - konrad Signed-off-by: zack.chang zector1...@gmail.com ---

Re: [PATCH] staging: wilc1000: remove oswrapper type file

2015-06-12 Thread Konrad Zapalowicz
On 06/12, Dean Lee wrote: remove OS Wrapper Type files. now does not used os wrapper file. type file is included os wrapper file. so delete files and rework include method. I do not understand the commit message and it does not parse well. - konrad Signed-off-by: Dean Lee

Re: [PATCH] staging: wilc1000: remove oswrapper type file

2015-06-12 Thread Konrad Zapalowicz
On 06/12, Dean.lee wrote: On 2015년 06월 12일 18:17, Konrad Zapalowicz wrote: On 06/12, Dean Lee wrote: remove OS Wrapper Type files. now does not used os wrapper file. type file is included os wrapper file. so delete files and rework include method. I do not understand the commit message

Re: [PATCH] staging: sm750fb: fix c99 comments

2015-06-12 Thread Konrad Zapalowicz
On 06/12, Juston Li wrote: fixed all checkpatch.pl ERROR: do not use C99 // comments Any C99 comments used to comment out code are simply removed. Also some of the errors occur inside '#if 0' blocks which I might as well fix since checkpatch.pl caught them but the blocks themselves should

Re: [PATCH] staging: xgifb: remove braces around else clause

2015-06-01 Thread Konrad Zapalowicz
On 06/01, Gujulan Elango, Hari Prasath (H.) wrote: From: Hari Prasath Gujulan Elango hguju...@visteon.com Remove braces around else clause with single line Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com --- drivers/staging/xgifb/vb_init.c | 10 -- 1 file

Re: [PATCHv2 1/2] staging: dgnc: delete all references to 'flipbuf'

2015-06-01 Thread Konrad Zapalowicz
On 06/01, Gujulan Elango, Hari Prasath (H.) wrote: From: Hari Prasath Gujulan Elango hguju...@visteon.com The above line should not be here and it will appear as long as the email client is not configured correctly. Just take a step back and fix it as this is something that you do once and then